[clang] [clang-tools-extra] Reland "[clang] Preserve found-decl when constructing VarTemplateIds" (PR #82612)

2024-02-22 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/82612 Update include-cleaner tests. Now that we have proper found-decls set up for VarTemplates, in case of instationtations we point to primary templates and not specializations. To be changed in a follow-up patch.

[clang] [clang-tools-extra] Reland "[clang] Preserve found-decl when constructing VarTemplateIds" (PR #82612)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: kadir çetinkaya (kadircet) Changes Update include-cleaner tests. Now that we have proper found-decls set up for VarTemplates, in case of instationtations we point to primary templates and not specializations. To be changed in a follow-up pa

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-22 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80656 >From 48211eb7778db8fb8af144d59adb2e0941957c4c Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 5 Feb 2024 18:01:34 +0800 Subject: [PATCH 1/4] GH78524 --- clang/docs/ReleaseNotes.rst |

[clang] [clang-format] Fix crash in TokenAnnotator (PR #82349)

2024-02-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/82349 >From 25ca98534f0d5dbd96ff74c802528171787ced45 Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Tue, 20 Feb 2024 14:11:33 +0200 Subject: [PATCH 1/2] [clang-format] Fix crash in TokenAnnotator The while loop on li

[clang] [clang-format] Fix crash in TokenAnnotator (PR #82349)

2024-02-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/82349 >From 25ca98534f0d5dbd96ff74c802528171787ced45 Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Tue, 20 Feb 2024 14:11:33 +0200 Subject: [PATCH 1/3] [clang-format] Fix crash in TokenAnnotator The while loop on li

[clang] [clang-format] Fix crash in TokenAnnotator (PR #82349)

2024-02-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/82349 >From 25ca98534f0d5dbd96ff74c802528171787ced45 Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Tue, 20 Feb 2024 14:11:33 +0200 Subject: [PATCH 1/4] [clang-format] Fix crash in TokenAnnotator The while loop on li

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-22 Thread Younan Zhang via cfe-commits
zyn0217 wrote: All done. Thanks for the review & wording suggestions! (I'll try the windows CI again before landing it.) https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive mat

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/81514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18f1166 - Multilib support for libraries with exceptions (#75031)

2024-02-22 Thread via cfe-commits
Author: pwprzybyla Date: 2024-02-22T13:04:21Z New Revision: 18f116651af0e328e6f9f6b0619171bd8a2c4817 URL: https://github.com/llvm/llvm-project/commit/18f116651af0e328e6f9f6b0619171bd8a2c4817 DIFF: https://github.com/llvm/llvm-project/commit/18f116651af0e328e6f9f6b0619171bd8a2c4817.diff LOG: Mu

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-02-22 Thread via cfe-commits
https://github.com/amilendra closed https://github.com/llvm/llvm-project/pull/75031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-02-22 Thread via cfe-commits
amilendra wrote: Merged because Piotr does not have merge permissions. https://github.com/llvm/llvm-project/pull/75031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][StaticAnalyzer] Crash on loop unrolling mode (PR #82089)

2024-02-22 Thread via cfe-commits
https://github.com/huang-me updated https://github.com/llvm/llvm-project/pull/82089 >From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001 From: huang-me Date: Sat, 17 Feb 2024 10:43:48 +0800 Subject: [PATCH 1/4] Fix crash on StaticAnalyzer loop unrolling --- clang/lib/Static

[clang] [clang][StaticAnalyzer] Crash on loop unrolling mode (PR #82089)

2024-02-22 Thread via cfe-commits
@@ -226,6 +226,21 @@ static bool isPossiblyEscaped(ExplodedNode *N, const DeclRefExpr *DR) { return false; } } + +if (const SwitchStmt *SS = dyn_cast(S)) { + if (const CompoundStmt *CST = dyn_cast(SS->getBody())) { +for (const Stmt *CB : CS

[clang] b47f63d - [Clang][SME] Detect always_inline used with mismatched streaming attributes (#77936)

2024-02-22 Thread via cfe-commits
Author: Sam Tebbs Date: 2024-02-22T13:07:31Z New Revision: b47f63d3c8fedf7c98b7f58e892e784fddee4601 URL: https://github.com/llvm/llvm-project/commit/b47f63d3c8fedf7c98b7f58e892e784fddee4601 DIFF: https://github.com/llvm/llvm-project/commit/b47f63d3c8fedf7c98b7f58e892e784fddee4601.diff LOG: [Cl

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-02-22 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 closed https://github.com/llvm/llvm-project/pull/77936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][StaticAnalyzer] Crash on loop unrolling mode (PR #82089)

2024-02-22 Thread via cfe-commits
https://github.com/huang-me updated https://github.com/llvm/llvm-project/pull/82089 >From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001 From: huang-me Date: Sat, 17 Feb 2024 10:43:48 +0800 Subject: [PATCH 1/6] Fix crash on StaticAnalyzer loop unrolling --- clang/lib/Static

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-02-22 Thread Sam Tebbs via cfe-commits
@@ -814,6 +820,43 @@ Address AArch64ABIInfo::EmitMSVAArg(CodeGenFunction &CGF, Address VAListAddr, /*allowHigherAlign*/ false); } +static bool isStreaming(const FunctionDecl *F) { + if (F->hasAttr()) +return true; + if (const auto *T = F->getTy

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/82614 To fix https://github.com/llvm/llvm-project/issues/81597, I'm planning to refactor the usage of CallDescription; and as I was preparing for this I noticed that there are two superfluous references to this head

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (NagyDonat) Changes To fix https://github.com/llvm/llvm-project/issues/81597, I'm planning to refactor the usage of CallDescription; and as I was preparing for this I noticed that there are two superfluous references to this header.

[clang] fa8a211 - [analyzer] Improve handling of unsigned values in ArrayBoundCheckerV2 (#81034)

2024-02-22 Thread via cfe-commits
Author: NagyDonat Date: 2024-02-22T14:19:20+01:00 New Revision: fa8a21144ec9a6836e9bf1e3bf5cd0b2f058209e URL: https://github.com/llvm/llvm-project/commit/fa8a21144ec9a6836e9bf1e3bf5cd0b2f058209e DIFF: https://github.com/llvm/llvm-project/commit/fa8a21144ec9a6836e9bf1e3bf5cd0b2f058209e.diff LOG

[clang] [analyzer] Improve handling of unsigned values in ArrayBoundCheckerV2 (PR #81034)

2024-02-22 Thread via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/81034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [include-cleaner] Use FoundDecl only for using-shadow-decls (PR #82615)

2024-02-22 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/82615 None From 1ae249119856ae2d8c1d2d4a3c3e311fa3d66dd0 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 22 Feb 2024 13:22:11 +0100 Subject: [PATCH 1/2] Reland "[clang] Preserve found-decl when constructing

[clang] [clang-tools-extra] [include-cleaner] Use FoundDecl only for using-shadow-decls (PR #82615)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang Author: kadir çetinkaya (kadircet) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/82615.diff 5 Files Affected: - (modified) clang-tools-extra/include-cleaner/lib/WalkAST.cpp (+5) - (mod

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits approved this pull request. It looks good to me. https://github.com/llvm/llvm-project/pull/82614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive mat

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread via cfe-commits
NagyDonat wrote: I'm merging this to be able to build on it. https://github.com/llvm/llvm-project/pull/82614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] afa8a2e - [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (#82614)

2024-02-22 Thread via cfe-commits
Author: NagyDonat Date: 2024-02-22T14:29:05+01:00 New Revision: afa8a2eed0c4ca61ac19abd88022e63e58408af1 URL: https://github.com/llvm/llvm-project/commit/afa8a2eed0c4ca61ac19abd88022e63e58408af1 DIFF: https://github.com/llvm/llvm-project/commit/afa8a2eed0c4ca61ac19abd88022e63e58408af1.diff LOG

[clang] [analyzer] Remove superfluous #include "CallDescription.h" (NFC) (PR #82614)

2024-02-22 Thread via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/82614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for determining constness of more expressions. (PR #82617)

2024-02-22 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/82617 This uses a more systematic approach for determining whcich `DeclRefExpr`s mutate the underlying object: Instead of using a few matchers, we walk up the AST until we find a parent that we can prove cannot c

[clang-tools-extra] [clang-tidy] Add support for determining constness of more expressions. (PR #82617)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Clement Courbet (legrosbuffle) Changes This uses a more systematic approach for determining whcich `DeclRefExpr`s mutate the underlying object: Instead of using a few matchers, we walk up the AST until we find a parent that we

[clang] 5b8e560 - [AIX] Lower intrinsic __builtin_cpu_is into AIX platform-specific code. (#80069)

2024-02-22 Thread via cfe-commits
Author: zhijian lin Date: 2024-02-22T08:46:08-05:00 New Revision: 5b8e5604c297aa8fd09bf641d12d0a663e0ea801 URL: https://github.com/llvm/llvm-project/commit/5b8e5604c297aa8fd09bf641d12d0a663e0ea801 DIFF: https://github.com/llvm/llvm-project/commit/5b8e5604c297aa8fd09bf641d12d0a663e0ea801.diff L

[clang] [llvm] [AIX] Lower intrinsic __builtin_cpu_is into AIX platform-specific code. (PR #80069)

2024-02-22 Thread zhijian lin via cfe-commits
https://github.com/diggerlin closed https://github.com/llvm/llvm-project/pull/80069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix renaming single argument ObjC methods (PR #82396)

2024-02-22 Thread kadir çetinkaya via cfe-commits
@@ -811,8 +811,14 @@ renameWithinFile(ParsedAST &AST, const NamedDecl &RenameDecl, continue; Locs.push_back(RenameLoc); } - if (const auto *MD = dyn_cast(&RenameDecl)) -return renameObjCMethodWithinFile(AST, MD, NewName, std::move(Locs)); + if (const auto *MD

[clang-tools-extra] [clangd] SelectionTree marks nodes as complete only if children are complete (PR #82237)

2024-02-22 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. mentioned this offline already but putting in here as well for my sanity. the patch is missing the actual changes to the logic, it only has test changes. https://github.com/llvm/llvm-project/pull/82237 _

[clang] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2024-02-22 Thread Phil Camp via cfe-commits
https://github.com/FlameTop closed https://github.com/llvm/llvm-project/pull/72387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2024-02-22 Thread Phil Camp via cfe-commits
FlameTop wrote: Closing this PR. I will redesign the change and re-submit. https://github.com/llvm/llvm-project/pull/72387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [clang][analyzer] Fix argument invalidations in StreamChecker. (PR #79470)

2024-02-22 Thread Alejandro Álvarez Ayllón via cfe-commits
@@ -763,6 +779,11 @@ void StreamChecker::evalFreadFwrite(const FnDescription *Desc, return; } + // At read, invalidate the buffer in any case of error or success, + // except if EOF was already present. + if (IsFread && (OldSS->ErrorState != ErrorFEof)) +State =

[clang] [Clang] Fix looking for immediate calls in default arguments. (PR #80690)

2024-02-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/80690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix looking for immediate calls in default arguments. (PR #80690)

2024-02-22 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/80690 >From 77556982a14dc7969a5ab6dc19ce0bfc8a0a763c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 5 Feb 2024 15:42:21 +0100 Subject: [PATCH 1/2] [Clang] Fix looking for immediate calls in default argument

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/81514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reland "[clang] Preserve found-decl when constructing VarTemplateIds" (PR #82612)

2024-02-22 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/82612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread Victor Campos via cfe-commits
https://github.com/vhscampos created https://github.com/llvm/llvm-project/pull/82624 Fix some title headers to align them with the actual ACLE document. >From 30c1dca1d5a25bd4124ec3cb2ef7b6f681773ea0 Mon Sep 17 00:00:00 2001 From: Victor Campos Date: Thu, 22 Feb 2024 14:32:56 + Subject: [P

[clang] [NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Victor Campos (vhscampos) Changes Fix some title headers to align them with the actual ACLE document. --- Full diff: https://github.com/llvm/llvm-project/pull/82624.diff 1 Files Affected: - (modified) cl

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 2cf6f184e2e8a6abc31e0dfb19c706569357597d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [clang-tools-extra] [include-cleaner] Use FoundDecl only for using-shadow-decls (PR #82615)

2024-02-22 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/82615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove deprecated `ValueModel::merge()` function. (PR #82602)

2024-02-22 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/82602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-02-22 Thread zhijian lin via cfe-commits
@@ -337,12 +350,77 @@ CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { return CharUnits::fromQuantity(4); } +ABIArgInfo PPC32_SVR4_ABIInfo::handleComplex(QualType Ty, + uint64_t &TypeSize) const { + ---

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/81514 >From 13fd73932251843173cbbc31ca93905ca0469277 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 12 Feb 2024 10:58:19 -0800 Subject: [PATCH 1/4] [CLANG] Full support of complex multiplication and division.

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-02-22 Thread zhijian lin via cfe-commits
@@ -184,11 +184,13 @@ createTargetCodeGenInfo(CodeGenModule &CGM) { bool IsSoftFloat = CodeGenOpts.FloatABI == "soft" || Target.hasFeature("spe"); -return createPPC32TargetCodeGenInfo(CGM, IsSoftFloat); +unsigned RLen = Target.getPointerWidth(LangAS::Defaul

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-02-22 Thread zhijian lin via cfe-commits
@@ -184,11 +184,13 @@ createTargetCodeGenInfo(CodeGenModule &CGM) { bool IsSoftFloat = CodeGenOpts.FloatABI == "soft" || Target.hasFeature("spe"); -return createPPC32TargetCodeGenInfo(CGM, IsSoftFloat); +unsigned RLen = Target.getPointerWidth(LangAS::Defaul

[clang-tools-extra] [include-cleaner] Dont apply name-match for non-owning headers (PR #82625)

2024-02-22 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/82625 None From 11dee86b09f99da7ce3d6dd0d3f8fcb7a3b53b43 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 22 Feb 2024 15:46:20 +0100 Subject: [PATCH] [include-cleaner] Dont apply name-match for non-owning h

[clang-tools-extra] [include-cleaner] Dont apply name-match for non-owning headers (PR #82625)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: kadir çetinkaya (kadircet) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/82625.diff 2 Files Affected: - (modified) clang-tools-extra/include-cleaner/lib/FindHeaders.cpp (+6) - (modified) clang-tools-extr

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,171 @@ +//===--- UnsafeCrtpCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,171 @@ +//===--- UnsafeCrtpCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,62 @@ +.. title:: clang-tidy - bugprone-unsafe-crtp + +bugprone-unsafe-crtp + + +Finds CRTP used in an error-prone way. + +If the constructor of a class intended to be used in a CRTP is public, then +it allows users to construct that class on its own

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,31 @@ +//===--- UnsafeCrtpCheck.h - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,62 @@ +.. title:: clang-tidy - bugprone-unsafe-crtp + +bugprone-unsafe-crtp + + +Finds CRTP used in an error-prone way. + +If the constructor of a class intended to be used in a CRTP is public, then +it allows users to construct that class on its own

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,232 @@ +// RUN: %check_clang_tidy %s bugprone-unsafe-crtp %t + +namespace class_implicit_ctor { +template +class CRTP {}; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: the implicit default constructor of the CRTP is publicly accessible [bugprone-unsafe-crtp] +// CHECK-

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,171 @@ +//===--- UnsafeCrtpCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,232 @@ +// RUN: %check_clang_tidy %s bugprone-unsafe-crtp %t + +namespace class_implicit_ctor { +template +class CRTP {}; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: the implicit default constructor of the CRTP is publicly accessible [bugprone-unsafe-crtp] +// CHECK-

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,171 @@ +//===--- UnsafeCrtpCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,62 @@ +.. title:: clang-tidy - bugprone-unsafe-crtp + +bugprone-unsafe-crtp + + +Finds CRTP used in an error-prone way. + +If the constructor of a class intended to be used in a CRTP is public, then +it allows users to construct that class on its own

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,232 @@ +// RUN: %check_clang_tidy %s bugprone-unsafe-crtp %t + +namespace class_implicit_ctor { +template +class CRTP {}; +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: the implicit default constructor of the CRTP is publicly accessible [bugprone-unsafe-crtp] +// CHECK-

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,171 @@ +//===--- UnsafeCrtpCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-22 Thread via cfe-commits
@@ -0,0 +1,62 @@ +.. title:: clang-tidy - bugprone-unsafe-crtp + +bugprone-unsafe-crtp + + +Finds CRTP used in an error-prone way. + +If the constructor of a class intended to be used in a CRTP is public, then +it allows users to construct that class on its own

[clang-tools-extra] [run-clang-tidy.py] Add option to ignore source files from compilation database (PR #82416)

2024-02-22 Thread Alexander Scholz via cfe-commits
https://github.com/duddel updated https://github.com/llvm/llvm-project/pull/82416 >From a3596bf357ef991abcaef04f8811958c0984d9f6 Mon Sep 17 00:00:00 2001 From: duddel Date: Tue, 20 Feb 2024 21:11:26 +0100 Subject: [PATCH 1/5] add -source-ignore option to run-clang-tidy.py --- .../clang-tidy/t

[clang] [libc] [llvm] [openmp] [libc] Rework the GPU build to be a regular target (PR #81921)

2024-02-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81921 >From 575390d65fd35729e855823e38dfd28f7a15debd Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 13 Feb 2024 21:08:02 -0600 Subject: [PATCH] [libc] Rework the GPU build to be a regular target Summary: This

[clang] [NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread James Westwood via cfe-commits
https://github.com/jwestwood921 approved this pull request. LGTM, but wait for @DavidSpickett to review before merging. https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang-tools-extra] [run-clang-tidy.py] Add option to ignore source files from compilation database (PR #82416)

2024-02-22 Thread Alexander Scholz via cfe-commits
@@ -97,6 +97,9 @@ The improvements are... Improvements to clang-tidy -- +- Improved :program:`run-clang-tidy.py` script. Added argument `-source-filter` + to filter out source files from the compilation database. duddel wrote: Ok, I c

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @andykaylor I am opening up this for review in order to have other people chime in. @AaronBallman what do you think about the warnings (and the rest of course)? -fcomplex-arithmetic=full -ffast-math generates this warning: "use of nnan or ninf flags in the presence of '-fcom

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/81514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang-driver Author: Zahira Ammarguellat (zahiraam) Changes In clang there are two options `-f[no]cx-limited-range` and `-f[no]cx-fortran-rules` that control the range of complex multiplication and division. However,

[clang] [clang] Implement CWG2759 "`[[no_unique_address]` and common initial sequence" (PR #82607)

2024-02-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM modulo formatting nits https://github.com/llvm/llvm-project/pull/82607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM, thanks. https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2759 "`[[no_unique_address]` and common initial sequence" (PR #82607)

2024-02-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/82607 >From 22facf44ec3f97fcdc40f2431ec26ca7ef441c67 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 22 Feb 2024 13:28:04 +0300 Subject: [PATCH 1/4] [clang] Implement CWG2759 "`[[no_unique_address]` and c

[clang] [clang] Implement CWG2759 "`[[no_unique_address]` and common initial sequence" (PR #82607)

2024-02-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fde344aef20bc4280f01294ac6e14a5c2db2d572 263468bd571a274125883cdc3acb4c4b73c6d908 --

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Erich Keane via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [clang] Implement CWG2759 "`[[no_unique_address]` and common initial sequence" (PR #82607)

2024-02-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/82607 >From 22facf44ec3f97fcdc40f2431ec26ca7ef441c67 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 22 Feb 2024 13:28:04 +0300 Subject: [PATCH 1/5] [clang] Implement CWG2759 "`[[no_unique_address]` and c

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-02-22 Thread zhijian lin via cfe-commits
@@ -271,22 +271,33 @@ namespace { class PPC32_SVR4_ABIInfo : public DefaultABIInfo { bool IsSoftFloatABI; bool IsRetSmallStructInRegABI; + bool isComplexInRegABI; + // Size of GPR in bits + unsigned RLen; diggerlin wrote: `RLen` is too short to understa

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Erich Keane via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] 601c9be - [clang][NFC] Fix arm_acle.h title headers (#82624)

2024-02-22 Thread via cfe-commits
Author: Victor Campos Date: 2024-02-22T15:25:36Z New Revision: 601c9bec736739da9160092ef60e3468266816bd URL: https://github.com/llvm/llvm-project/commit/601c9bec736739da9160092ef60e3468266816bd DIFF: https://github.com/llvm/llvm-project/commit/601c9bec736739da9160092ef60e3468266816bd.diff LOG:

[clang] [clang][NFC] Fix arm_acle.h title headers (PR #82624)

2024-02-22 Thread Victor Campos via cfe-commits
https://github.com/vhscampos closed https://github.com/llvm/llvm-project/pull/82624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][Headers] Update refs to ACLE in comments (PR #78305)

2024-02-22 Thread Victor Campos via cfe-commits
vhscampos wrote: Fixed @jwestwood921 's comments in #82624 https://github.com/llvm/llvm-project/pull/78305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
@@ -3371,6 +3379,20 @@ Sema::ActOnBreakStmt(SourceLocation BreakLoc, Scope *CurScope) { if (S->isOpenMPLoopScope()) return StmtError(Diag(BreakLoc, diag::err_omp_loop_cannot_use_stmt) << "break"); + + // OpenACC doesn't allow 'break'ing from a compu

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-02-22 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/81418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-02-22 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Not the best one to review this, but some drive-bys https://github.com/llvm/llvm-project/pull/81418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-02-22 Thread Erich Keane via cfe-commits
@@ -263,6 +263,14 @@ namespace { } } +QualType Expr::getEnumCoercedType(const ASTContext &Ctx) const { + bool NotEnumType = dyn_cast(this->getType()) == nullptr; + if (NotEnumType) erichkeane wrote: ```suggestion if (!isa(this->getType())) ``` Though,

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-02-22 Thread Erich Keane via cfe-commits
@@ -4097,6 +4105,14 @@ FieldDecl *Expr::getSourceBitField() { return nullptr; } +EnumConstantDecl *Expr::getEnumConstantDecl() { + Expr *E = this->IgnoreParenImpCasts(); + if (DeclRefExpr *DRE = dyn_cast(E)) +if (EnumConstantDecl *ECD = dyn_cast(DRE->getDecl())) --

[clang] [clang][analyzer] Fix argument invalidations in StreamChecker. (PR #79470)

2024-02-22 Thread Balázs Kéri via cfe-commits
@@ -763,6 +779,11 @@ void StreamChecker::evalFreadFwrite(const FnDescription *Desc, return; } + // At read, invalidate the buffer in any case of error or success, + // except if EOF was already present. + if (IsFread && (OldSS->ErrorState != ErrorFEof)) +State =

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-02-22 Thread zhijian lin via cfe-commits
https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/77732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/82543 >From 5ea47a31eb0ce851441cb7f1851b13303732ca91 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Wed, 21 Feb 2024 10:08:06 -0800 Subject: [PATCH 1/4] [OpenACC] Implement 'break' and 'continue' errors for Comput

[clang] [OpenACC] Implement 'break' and 'continue' errors for Compute Cnstrcts (PR #82543)

2024-02-22 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/82543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2024-02-22 Thread Nico Weber via cfe-commits
nico wrote: Wow, that clang/lib/Headers/yvals_core.h hacks is gross, I love it :D lgtm, and good to land provided you do a quick re-check to confirm that this doesn't tank compile times now with that part included. Thanks! https://github.com/llvm/llvm-project/pull/75711 ___

<    1   2   3   4   5   >