@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
PiotrZSL wrote:
why not u
https://github.com/PiotrZSL approved this pull request.
LGTM.
Just 2 nits, but not a blocker.
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
felix642 wrote:
Simply di
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-02-11T12:59:05-08:00
New Revision: 03f571995b4f0c260254955afd16ec44d0764794
URL:
https://github.com/llvm/llvm-project/commit/03f571995b4f0c260254955afd16ec44d0764794
DIFF:
https://github.com/llvm/llvm-project/commit/03f571995b4f0c260254955afd16ec44d0764794.diff
LOG:
Author: Owen Pan
Date: 2024-02-11T13:08:28-08:00
New Revision: 3dc8ef677d7d05116a0bf6524eb38b02ca6ba042
URL:
https://github.com/llvm/llvm-project/commit/3dc8ef677d7d05116a0bf6524eb38b02ca6ba042
DIFF:
https://github.com/llvm/llvm-project/commit/3dc8ef677d7d05116a0bf6524eb38b02ca6ba042.diff
LOG:
https://github.com/kevinjoseph1995 created
https://github.com/llvm/llvm-project/pull/81435
When applying the recommended fix for the
"modernize-use-override" clang-tidy diagnostic
there was a stray whitespace. This PR fixes that.
Resolves https://github.com/clangd/clangd/issues/1704
>From db2c4
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Kevin Joseph (kevinjoseph1995)
Changes
When applying the recommended fix for the
"modernize-use-override" clang-tidy diagnostic
there was a stray whitespace. This PR fixes that.
Resolves https://g
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
@@ -898,6 +898,34 @@ TEST(DiagnosticTest, ClangTidySelfContainedDiags) {
withFix(equalToFix(ExpectedDFix));
}
+TEST(DiagnosticTest, ClangTidySelfContainedDiagsFormatting) {
PiotrZSL wrote:
Tests for clang tidy should be added here:
clang-
@@ -228,8 +228,8 @@ void UseOverrideCheck::check(const MatchFinder::MatchResult
&Result) {
if (HasVirtual) {
for (Token Tok : Tokens) {
if (Tok.is(tok::kw_virtual)) {
-Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange(
-Tok.getLoca
PiotrZSL wrote:
Release notes entry (for clang-tidy) is also missing.
https://github.com/llvm/llvm-project/pull/81435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
Something else I noticed while trying out the patch locally: before the patch,
the description of the quick fix in the editor is "change 'foo' to 'Foo'", i.e.
a description of what the code action will do.
After the patch, the description of the quick fix is now "invalid
https://github.com/5chmidti created
https://github.com/llvm/llvm-project/pull/81437
When parsing the ASTMatchers.h file, a matcher could specify an argument that
is a matcher using the not needed namespace `(clang::)ast_matchers::`.
Change the argument parsing in dump_ast_matchers.py to remove
HighCommander4 wrote:
(It's also no longer labelled as a "quick fix", likely due to the
`CodeActionKind` changing from `quickfix` to `refactor`, but that's probably
fine.)
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
c
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Julian Schmidt (5chmidti)
Changes
When parsing the ASTMatchers.h file, a matcher could specify an argument that
is a matcher using the not needed namespace `(clang::)ast_matchers::`.
Change the argument parsing in dump_ast_matchers.py to r
5chmidti wrote:
Should the tag of this pr be [ASTMatcher] or [clang]?
https://github.com/llvm/llvm-project/pull/81437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/81437
>From 3470dc38c1864b2fb6b773e99c30251c083dfd09 Mon Sep 17 00:00:00 2001
From: Julian Schmidt
Date: Mon, 12 Feb 2024 00:38:05 +0100
Subject: [PATCH 1/2] [clang] remove (clang::)ast_matchers:: namespace from
pars
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?[clang-tidy]=C2=A0Rem
@@ -308,13 +309,21 @@ Error
RawCoverageMappingReader::readMappingRegionsSubArray(
return Err;
if (auto Err = readIntMax(FID, std::numeric_limits::max()))
return Err;
+ if (ID == 0)
+return make_error(
+cove
ornata wrote:
Is the main benefit of this avoiding zero initialization?
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/AtariDreams edited
https://github.com/llvm/llvm-project/pull/81335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni commented:
@ornata I want to isolate Decision stuff and Branch stuff in `MCDCParams`.
Also I'd like to encapsulate params into each record. Once parameters are set,
they are expected to hold "valid" values. Zeroing really confused me, (possibly
us).
I've found `std::
@@ -308,13 +309,21 @@ Error
RawCoverageMappingReader::readMappingRegionsSubArray(
return Err;
if (auto Err = readIntMax(FID, std::numeric_limits::max()))
return Err;
+ if (ID == 0)
+return make_error(
+cove
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/81335
>From 7ef83de2bfc13da0b317d144a38f223b3738889b Mon Sep 17 00:00:00 2001
From: Rose <83477269+ataridre...@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:51:15 -0500
Subject: [PATCH 1/2] [ObjC] Add pre-commi
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kevinjoseph1995 updated
https://github.com/llvm/llvm-project/pull/81435
>From db2c4ee74ffb0592ec7f3fd5557dbb5399ef998d Mon Sep 17 00:00:00 2001
From: Kevin Joseph
Date: Sun, 11 Feb 2024 13:39:51 -0800
Subject: [PATCH 1/2] [clangd] Clean formatting modernize-use-override
When
@@ -898,6 +898,34 @@ TEST(DiagnosticTest, ClangTidySelfContainedDiags) {
withFix(equalToFix(ExpectedDFix));
}
+TEST(DiagnosticTest, ClangTidySelfContainedDiagsFormatting) {
kevinjoseph1995 wrote:
Added a case in
clang-tools-extra/test/cla
Author: Owen Pan
Date: 2024-02-11T22:01:23-08:00
New Revision: 32e65b0b8a743678974c7ca7913c1d6c41bb0772
URL:
https://github.com/llvm/llvm-project/commit/32e65b0b8a743678974c7ca7913c1d6c41bb0772
DIFF:
https://github.com/llvm/llvm-project/commit/32e65b0b8a743678974c7ca7913c1d6c41bb0772.diff
LOG:
Author: Owen Pan
Date: 2024-02-11T22:51:18-08:00
New Revision: 00918933fc4e181fe3c74006d81d7a598c2227b3
URL:
https://github.com/llvm/llvm-project/commit/00918933fc4e181fe3c74006d81d7a598c2227b3
DIFF:
https://github.com/llvm/llvm-project/commit/00918933fc4e181fe3c74006d81d7a598c2227b3.diff
LOG:
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,
=?utf-8?q?“Nhat?= ,Nhat Nguyen
Message-ID:
In-Reply-To:
https://github.com/changkhothuychung updated
https://github.com/llvm/llvm-project/pull/75902
>From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/81444
Closes #81399.
>From 9d91878e9cb65ab67de8251976ee748ed03fc2b6 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 11 Feb 2024 23:28:25 -0800
Subject: [PATCH] [clang-format] Don't remove parentheses in macro defini
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Closes #81399.
---
Full diff: https://github.com/llvm/llvm-project/pull/81444.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+1-1)
- (modified) clang/unittests/Format/Form
prj- wrote:
Any hope that this lands in 18.1? Thanks anyway!
https://github.com/llvm/llvm-project/pull/81444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 142 of 142 matches
Mail list logo
