[clang] [llvm] __ARM_ARCH macro definition fix (PR #81301)

2024-02-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] __ARM_ARCH macro definition fix (PR #81301)

2024-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: James Westwood (jwestwood921) Changes …ARCH Added functionality to the ARMTargetParser to obtain the minor version of each architecture, and amended ARM.cpp and AArch64.cpp to define __ARM_ARCH correctly. In ACLE 5.4.1, __ARM_ARCH is de

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/81302 The spurious -Wunused-function warning issue for `target_version` #80227 also applied to `__attribute__((target(...)))` based FMV. #81167 removed warnings for all `target`-based FMV. This patch restores the warnin

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes The spurious -Wunused-function warning issue for `target_version` #80227 also applied to `__attribute__((target(...)))` based FMV. #81167 removed warnings for all `target`-based FMV. This patch restores the wa

[clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-02-09 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/74512 >From 169d962b64b8ae242c3a6d332677296cf7503839 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 5 Dec 2023 10:28:44 -0800 Subject: [PATCH 1/6] [clang] Avoid -Wshadow warning when init-capture

[clang] [llvm] __ARM_ARCH macro definition fix (PR #81301)

2024-02-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 301f6840522e3d924cf00ab6a04f93f1354142f5 4f3a6f2ee1c6b8684f7a1eba1dc6db8c82925169 --

[clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-02-09 Thread Mariya Podchishchaeva via cfe-commits
@@ -8328,35 +8328,47 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, unsigned WarningDiag = diag::warn_decl_shadow; SourceLocation CaptureLoc; - if (isa(D) && isa(ShadowedDecl) && NewDC && - isa(NewDC)) { + if (isa(D) && NewDC && isa(NewDC)) {

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -159,6 +159,7 @@ BUILTIN(__nvvm_read_ptx_sreg_pm3, "i", "n") BUILTIN(__nvvm_prmt, "UiUiUiUi", "") BUILTIN(__nvvm_exit, "v", "r") +BUILTIN(__nvvm_reflect, "UicC*", "r") jhuber6 wrote: It's in the `NVPTXUsage.rst`, and https://github.com/llvm/llvm-project/p

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread Argyrios Kyrtzidis via cfe-commits
https://github.com/akyrtzi approved this pull request. https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] __ARM_ARCH macro definition fix (PR #81301)

2024-02-09 Thread James Westwood via cfe-commits
https://github.com/jwestwood921 updated https://github.com/llvm/llvm-project/pull/81301 >From 4f3a6f2ee1c6b8684f7a1eba1dc6db8c82925169 Mon Sep 17 00:00:00 2001 From: James Westwood Date: Fri, 9 Feb 2024 19:06:20 + Subject: [PATCH 1/2] __ARM_ARCH macro definition fix Added functionality to

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread Jon Roelofs via cfe-commits
jroelofs wrote: Thanks! https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -1624,8 +1624,9 @@ def int_nvvm_compiler_error : def int_nvvm_compiler_warn : Intrinsic<[], [llvm_anyptr_ty], [], "llvm.nvvm.compiler.warn">; -def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; +def int_nvvm_reflect :

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -1624,8 +1624,9 @@ def int_nvvm_compiler_error : def int_nvvm_compiler_warn : Intrinsic<[], [llvm_anyptr_ty], [], "llvm.nvvm.compiler.warn">; -def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; +def int_nvvm_reflect :

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81277 >From 7b97388a5f251684cf4ae69c3b0cae0ff6fe1397 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 10:50:20 -0600 Subject: [PATCH 1/2] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic Summa

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -1624,8 +1624,9 @@ def int_nvvm_compiler_error : def int_nvvm_compiler_warn : Intrinsic<[], [llvm_anyptr_ty], [], "llvm.nvvm.compiler.warn">; -def int_nvvm_reflect : - Intrinsic<[llvm_i32_ty], [llvm_anyptr_ty], [IntrNoMem], "llvm.nvvm.reflect">; +def int_nvvm_reflect :

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: LGTM https://github.com/llvm/llvm-project/pull/81277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-02-09 Thread via cfe-commits
@@ -8328,35 +8328,47 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, unsigned WarningDiag = diag::warn_decl_shadow; SourceLocation CaptureLoc; - if (isa(D) && isa(ShadowedDecl) && NewDC && - isa(NewDC)) { + if (isa(D) && NewDC && isa(NewDC)) {

[clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-02-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/74512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-02-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/74512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

2024-02-09 Thread Alan Phipps via cfe-commits
@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; evodius96 wrote: is `std::array<>` better than `std::pair<>` when it only has two elements? http

[clang] [clang-format] Rename option AlwaysBreakTemplateDeclarations (PR #81093)

2024-02-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/81093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-02-09 Thread Artem Belevich via cfe-commits
@@ -140,6 +140,17 @@ define void @test_exit() { ret void } +; CHECK-LABEL: test_globaltimer +define i64 @test_globaltimer() { +; CHECK: mov.u64 %r{{.*}}, %globaltimer; + %a = tail call i64 @llvm.nvvm.read.ptx.sreg.globaltimer() Artem-B wrote: Thise

[clang] [clang-format] Rename option AlwaysBreakTemplateDeclarations (PR #81093)

2024-02-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks commented: I'd go contrary to your [comment](https://github.com/llvm/llvm-project/pull/80827#issuecomment-1935386091) and rename the attribute. Because otherwise you still have the contradiction within the code. https://github.com/llvm/llvm-project/pull/8

[clang] 9d9cc37 - [clang-format][docs] Fix version (#81185)

2024-02-09 Thread via cfe-commits
Author: Björn Schäpers Date: 2024-02-09T20:40:16+01:00 New Revision: 9d9cc3706f59499f443ce4ebaeb24f7c8417e797 URL: https://github.com/llvm/llvm-project/commit/9d9cc3706f59499f443ce4ebaeb24f7c8417e797 DIFF: https://github.com/llvm/llvm-project/commit/9d9cc3706f59499f443ce4ebaeb24f7c8417e797.diff

[clang] [clang-format][docs] Fix version (PR #81185)

2024-02-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/81185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

2024-02-09 Thread Yuriy Chernyshov via cfe-commits
georgthegreat wrote: @ldionne, do you find @arichardson reasoning good enough to proceed with merging this PR? https://github.com/llvm/llvm-project/pull/80443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

2024-02-09 Thread Alan Phipps via cfe-commits
@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; evodius96 wrote: Ah, well it's iterable. https://github.com/llvm/llvm-project/pull/81221 ___

[clang] [llvm] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -140,6 +140,17 @@ define void @test_exit() { ret void } +; CHECK-LABEL: test_globaltimer +define i64 @test_globaltimer() { +; CHECK: mov.u64 %r{{.*}}, %globaltimer; + %a = tail call i64 @llvm.nvvm.read.ptx.sreg.globaltimer() jhuber6 wrote: Okay,

[clang] Add the support for calling Ref::ptr accessor. (PR #80919)

2024-02-09 Thread Artem Dergachev via cfe-commits
@@ -0,0 +1,86 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s +// expected-no-diagnostics + +template +class Ref { haoNoQ wrote: It looks like you're copying this definition in every pull request. Can you put it

[clang] Ignore assignment to Ref / RefPtr in alpha.webkit.UncountedCallArgsChecker. (PR #80810)

2024-02-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/80810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add the support for calling Ref::ptr accessor. (PR #80919)

2024-02-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/80919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix an implicit cast to a base ref counted class generates a false positive. (PR #80934)

2024-02-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/80934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Allow default arguments to be evaluated like other arguments. (PR #80956)

2024-02-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/80956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/80698 >From 28d90711ff8e4924135d4bd4e5f252d96ac41b93 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 23 Jan 2024 20:18:25 + Subject: [PATCH 1/8] [misc-coroutine-hostile-raii] Use getOperand instead of getCom

[clang] [llvm] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-02-09 Thread Joseph Huber via cfe-commits
@@ -140,6 +140,17 @@ define void @test_exit() { ret void } +; CHECK-LABEL: test_globaltimer +define i64 @test_globaltimer() { +; CHECK: mov.u64 %r{{.*}}, %globaltimer; + %a = tail call i64 @llvm.nvvm.read.ptx.sreg.globaltimer() jhuber6 wrote: Done

[clang] [llvm] [NVPTX][Draft] Make `__nvvm_nanosleep` a no-op if unsupported (PR #81033)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/81033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81277 >From 5c9bc83db318d5c8608108942e494d6f0c1a27d5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 10:50:20 -0600 Subject: [PATCH] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic Summary:

[clang] 3c70731 - [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (#81277)

2024-02-09 Thread via cfe-commits
Author: Joseph Huber Date: 2024-02-09T14:11:01-06:00 New Revision: 3c707310a3e0233c1bc364a408e6fb43e56e1b78 URL: https://github.com/llvm/llvm-project/commit/3c707310a3e0233c1bc364a408e6fb43e56e1b78 DIFF: https://github.com/llvm/llvm-project/commit/3c707310a3e0233c1bc364a408e6fb43e56e1b78.diff

[clang] [llvm] [NVPTX] Add clang builtin for `__nvvm_reflect` intrinsic (PR #81277)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/81277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/80698 >From 28d90711ff8e4924135d4bd4e5f252d96ac41b93 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 23 Jan 2024 20:18:25 + Subject: [PATCH 1/9] [misc-coroutine-hostile-raii] Use getOperand instead of getCom

[clang] 228e9d5 - [clang] Document the type_visibility attribute (#79157)

2024-02-09 Thread via cfe-commits
Author: Louis Dionne Date: 2024-02-09T15:31:08-05:00 New Revision: 228e9d5bcfcb6411d2a257b560464323d0248c35 URL: https://github.com/llvm/llvm-project/commit/228e9d5bcfcb6411d2a257b560464323d0248c35 DIFF: https://github.com/llvm/llvm-project/commit/228e9d5bcfcb6411d2a257b560464323d0248c35.diff

[clang] [clang] Document the type_visibility attribute (PR #79157)

2024-02-09 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/79157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] add cast_{user,kern} instructions (PR #79902)

2024-02-09 Thread via cfe-commits
https://github.com/eddyz87 updated https://github.com/llvm/llvm-project/pull/79902 >From 30be2a60d3f514bd1a34fec430ebf30f5c220ca7 Mon Sep 17 00:00:00 2001 From: Eduard Zingerman Date: Fri, 26 Jan 2024 04:18:32 +0200 Subject: [PATCH 1/4] [BPF] Add cast_{user,kern} instructions This commit aims

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-09 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/3] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang] Full control of range reduction for complex multiplication and (PR #81316)

2024-02-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/81316 division. >From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Fri, 9 Feb 2024 12:38:34 -0800 Subject: [PATCH] Full control of range reduction for complex multiplicat

[clang] Full control of range reduction for complex multiplication and division. (PR #81316)

2024-02-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/81316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Full control of range reduction for complex multiplication and division. (PR #81316)

2024-02-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/81316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Full control of range reduction for complex multiplication and division. (PR #81316)

2024-02-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e5638c5a00682243b1ee012d7dd8292aa221dff8 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 --

[clang] [CLANG] Full control of range reduction for complex multiplication and division. (PR #81316)

2024-02-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/81316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-09 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert edited https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-09 Thread Johannes Doerfert via cfe-commits
@@ -2953,7 +2953,7 @@ int bar(int n){ // CHECK3-NEXT:[[TMP8:%.*]] = getelementptr inbounds [[STRUCT__GLOBALIZED_LOCALS_TY_0:%.*]], ptr [[TMP4]], i32 [[TMP5]] // CHECK3-NEXT:[[C:%.*]] = getelementptr inbounds [[STRUCT__GLOBALIZED_LOCALS_TY_0]], ptr [[TMP8]], i32 0, i32

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-09 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert commented: So, just to double check. On the Clang side, all you did is move the codegen and adapt it to work in the OMPIRBuilder, right? Expected outcome is the same, modulo the two small changes. https://github.com/llvm/llvm-project/pull/80343

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-09 Thread Johannes Doerfert via cfe-commits
@@ -36,14 +36,14 @@ void test() { // CHECK1-NEXT:[[DYN_PTR_ADDR:%.*]] = alloca ptr, align 8 // CHECK1-NEXT:[[DOTZERO_ADDR:%.*]] = alloca i32, align 4 // CHECK1-NEXT:[[DOTTHREADID_TEMP_:%.*]] = alloca i32, align 4 -// CHECK1-NEXT:store ptr [[DYN_PTR]], ptr [[DYN_

[clang] [CLANG] Full control of range reduction for complex multiplication and division. (PR #81316)

2024-02-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/81316 >From 5cf9dd1073ce6ae72aebbbd8fc4723ec48b39816 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Fri, 9 Feb 2024 12:38:34 -0800 Subject: [PATCH 1/2] Full control of range reduction for complex multiplication an

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-09 Thread Akash Banerjee via cfe-commits
TIFitis wrote: Yup, code generated is identical, except for the align issue I've highlighted and some cast instructions being moved around. Also no TBAA Info. https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] [HLSL] Implementation of dot intrinsic (PR #81190)

2024-02-09 Thread Xiang Li via cfe-commits
@@ -19,4 +19,9 @@ def int_dx_flattened_thread_id_in_group : Intrinsic<[llvm_i32_ty], [], [IntrNoMe def int_dx_create_handle : ClangBuiltin<"__builtin_hlsl_create_handle">, Intrinsic<[ llvm_ptr_ty ], [llvm_i8_ty], [IntrWillReturn]>; -} + +def int_dx_dot : +Intrinsic<[

[clang] [NFC][clang][Driver] Specify options for with -save-temps= (PR #80921)

2024-02-09 Thread Fangrui Song via cfe-commits
@@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group, MarshallingInfoFlag>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, - HelpText<"Save intermediate compilatio

[clang] 1d0f86b - [Sema] Warn unused functions for FMV based on the target attribute (#81302)

2024-02-09 Thread via cfe-commits
Author: Fangrui Song Date: 2024-02-09T13:39:08-08:00 New Revision: 1d0f86ba80543931d467d6ce3f2ad8cdde514710 URL: https://github.com/llvm/llvm-project/commit/1d0f86ba80543931d467d6ce3f2ad8cdde514710 DIFF: https://github.com/llvm/llvm-project/commit/1d0f86ba80543931d467d6ce3f2ad8cdde514710.diff

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

2024-02-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of dot intrinsic (PR #81190)

2024-02-09 Thread Farzon Lotfi via cfe-commits
@@ -19,4 +19,9 @@ def int_dx_flattened_thread_id_in_group : Intrinsic<[llvm_i32_ty], [], [IntrNoMe def int_dx_create_handle : ClangBuiltin<"__builtin_hlsl_create_handle">, Intrinsic<[ llvm_ptr_ty ], [llvm_i8_ty], [IntrWillReturn]>; -} + +def int_dx_dot : +Intrinsic<[

[clang] [Driver] Unify InstalledDir and Dir (PR #80527)

2024-02-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: Ping:) @ldionne I know you are discussing a `-isysroot` related issue (don't recall which one off my head) for Apple platforms. I think unifying InstalledDir and Dir will help. https://github.com/llvm/llvm-project/pull/80527 ___ cfe-c

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Philipp Tomsich via cfe-commits
ptomsich wrote: The clang-format failures are caused by preexisting/unchanged code. All newly added code passes clang-format. https://github.com/llvm/llvm-project/pull/81297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [libcxx] [Clang] Add __is_invocable_r and __is_nothrow_invocable_r (PR #81213)

2024-02-09 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/81213 >From b0b0072067c650e0eb1f4a556301cbc5b873935d Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Mon, 11 Sep 2023 04:31:02 +0200 Subject: [PATCH] [Clang] Add __is_invocable_r and __is_nothrow_invocable_r T

[clang] [NFC][clang][Driver] Specify options for with -save-temps= (PR #80921)

2024-02-09 Thread Jacob Lambert via cfe-commits
@@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group, MarshallingInfoFlag>; def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, - HelpText<"Save intermediate compilatio

[clang] [clang-tools-extra] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/80698 >From 28d90711ff8e4924135d4bd4e5f252d96ac41b93 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 23 Jan 2024 20:18:25 + Subject: [PATCH 01/10] [misc-coroutine-hostile-raii] Use getOperand instead of getC

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray requested changes to this pull request. https://github.com/llvm/llvm-project/pull/81297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/81297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Jonathan Thackray via cfe-commits
@@ -784,27 +784,32 @@ inline constexpr CpuInfo CpuInfos[] = { (AArch64::ExtensionBitset( {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_CRC}))}, {"tsv110", ARMV8_2A, - (AArch64::ExtensionBitset( - {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Jonathan Thackray via cfe-commits
jthackray wrote: > The clang-format failures are caused by preexisting/unchanged code. All newly > added code passes clang-format. Yes, I had this issue when I landed new cores previously. This whole file needs an NFC clang-format cleanup, IMHO. https://github.com/llvm/llvm-project/pull/81297

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Philipp Tomsich via cfe-commits
@@ -784,27 +784,32 @@ inline constexpr CpuInfo CpuInfos[] = { (AArch64::ExtensionBitset( {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_CRC}))}, {"tsv110", ARMV8_2A, - (AArch64::ExtensionBitset( - {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-09 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > I don't think it's unreasonable to switch the logic of `-mdaz-ftz` from > linking a file with a global initializer that sets the flags to making it > emit the entry-point call to such a function instead, it still largely > follows the same logic to me. And having a command

[clang] [NFC] Refactor fast-math handling for clang driver (PR #81173)

2024-02-09 Thread James Y Knight via cfe-commits
https://github.com/jyknight approved this pull request. https://github.com/llvm/llvm-project/pull/81173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add the support for calling Ref::ptr accessor. (PR #80919)

2024-02-09 Thread Ryosuke Niwa via cfe-commits
@@ -0,0 +1,86 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s +// expected-no-diagnostics + +template +class Ref { rniwa wrote: Sure. https://github.com/llvm/llvm-project/pull/80919 _

[clang] [NFC] Refactor fast-math handling for clang driver (PR #81173)

2024-02-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/81173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9397d23 - [docs] --save-temps=: add single quotes after #80921 and update --save-temps

2024-02-09 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-02-09T14:26:49-08:00 New Revision: 9397d23671f26ab8631e90f688ae2ea212f3c770 URL: https://github.com/llvm/llvm-project/commit/9397d23671f26ab8631e90f688ae2ea212f3c770 DIFF: https://github.com/llvm/llvm-project/commit/9397d23671f26ab8631e90f688ae2ea212f3c770.diff

[clang] [clang] Fix incorrect line numbers with -E and raw string (#47577) (PR #77021)

2024-02-09 Thread Steve Cornett via cfe-commits
@@ -0,0 +1,6 @@ +// RUN: %clang_cc1 -E %s | FileCheck %s +// CHECK: AAA +// CHECK-NEXT: BBB +R"( +AAA)" +BBB stevecor wrote: This test demonstrates that the line `AAA` is followed immediately by the line `BBB` with no intervening blank line. Without the fix, the

[clang] [clang] Fix incorrect line numbers with -E and raw string (#47577) (PR #77021)

2024-02-09 Thread Steve Cornett via cfe-commits
stevecor wrote: > This will need a release note Are you asking me to do this? I did not see any instructions about how to do this. https://github.com/llvm/llvm-project/pull/77021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-09 Thread Andy Kaylor via cfe-commits
@@ -1569,6 +1569,40 @@ // RUN:--gcc-toolchain="" \ // RUN:--sysroot=%S/Inputs/basic_linux_tree 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-NOCRTFASTMATH %s +// Don't link crtfastmath.o with -shared +// RUN: %clang --target=x86_64-unknown-linux -no-pie -###

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-09 Thread Andy Kaylor via cfe-commits
@@ -117,6 +117,11 @@ C23 Feature Support Non-comprehensive list of changes in this release - +* Code compiled with ``-shared`` and ``-ffast-math`` will no longer enable + flush-to-zero floating-point mode by default. This decisi

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-09 Thread Andy Kaylor via cfe-commits
@@ -117,6 +117,11 @@ C23 Feature Support Non-comprehensive list of changes in this release - +* Code compiled with ``-shared`` and ``-ffast-math`` will no longer enable andykaylor wrote: ```suggestion * Code com

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-02-09 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/79035 >From 5c088a59bd36df40bae9a3a712f3994feded359d Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Mon, 22 Jan 2024 12:43:27 -0600 Subject: [PATCH 1/3] [AMDGPU] Adding the amdgpu-num-work-groups function attribute

[clang] Add the support for calling Ref::ptr accessor. (PR #80919)

2024-02-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/80919 >From 26f23953843b7c79664c7e721c3cbf130be405c0 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 6 Feb 2024 17:56:01 -0800 Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Add the support for calling R

[clang] [Driver] Unify InstalledDir and Dir (PR #80527)

2024-02-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: From my point of view, I think this sounds fine - it looks like you've looked through this and thought deeper about it than I have at least. I'm not deep enough into this to comfortably press approved on this for now though, so hopefully someone else can chime in as well. http

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2024-02-09 Thread via cfe-commits
https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/74852 >From f281d34a51f662c934f158e4770774b0dc3588a2 Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Thu, 7 Dec 2023 08:45:51 -0800 Subject: [PATCH 01/12] [Clang][Sema] Print more static_assert exprs This change int

[clang] [llvm] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin (PR #81331)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/81331 Summary: This patch adds a new intrinsic and builtin function mirroring the existing `__builtin_readcyclecounter`. The difference is that this implementation targets a separate counter that some targets have which

[clang] [llvm] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin (PR #81331)

2024-02-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This is a draft, I'm trying to get this to map to either `s_memtime` or `s_sendmsg_rtn(0x83)` depending on the target for AMDGPU. Currently, it will recognize the new intrinsic but just lower it to `i64 0`. I'm not overly familiar with the backend, so any suggestions would be gr

[clang] [llvm] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin (PR #81331)

2024-02-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 967374123bd6eee23db9a57fcac7324e420648c5 f6d905fe46c18b8076bb9af4ccb6583ed60d5ca6 --

[clang] [llvm] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin (PR #81331)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81331 >From 4008cb94b59ea1be8aa6936c4dc6b5b7ad4e749a Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 16:13:42 -0600 Subject: [PATCH] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin

[clang] [llvm] [WIP][LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin (PR #81331)

2024-02-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-02-09 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/79035 >From 5c088a59bd36df40bae9a3a712f3994feded359d Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Mon, 22 Jan 2024 12:43:27 -0600 Subject: [PATCH 1/4] [AMDGPU] Adding the amdgpu-num-work-groups function attribute

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Philipp Tomsich via cfe-commits
https://github.com/ptomsich updated https://github.com/llvm/llvm-project/pull/81297 >From 257576aca04412413318b0a14f096c3616db7cd9 Mon Sep 17 00:00:00 2001 From: Philipp Tomsich Date: Thu, 8 Feb 2024 12:58:55 +0100 Subject: [PATCH] [AArch64] Add the Ampere1B core The Ampere1B is Ampere's third

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Philipp Tomsich via cfe-commits
@@ -784,27 +784,32 @@ inline constexpr CpuInfo CpuInfos[] = { (AArch64::ExtensionBitset( {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::AEK_CRC}))}, {"tsv110", ARMV8_2A, - (AArch64::ExtensionBitset( - {AArch64::AEK_AES, AArch64::AEK_SHA2, AArch64::

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-09 Thread via cfe-commits
https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/81335 If an NSObject subclass has fixed offsets, then so must the subclasses of that subclass! >From 13611985a4879ecb43daaf336f7ecfa8d13514db Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-09 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 13611985a4879ecb43daaf336f7ecfa8d13514db Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: AtariDreams (AtariDreams) Changes If an NSObject subclass has fixed offsets, then so must the subclasses of that subclass! --- Full diff: https://github.com/llvm/llvm-project/pull/81335.diff 2 Files Affected: - (modified) clang

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes If an NSObject subclass has fixed offsets, then so must the subclasses of that subclass! --- Full diff: https://github.com/llvm/llvm-project/pull/81335.diff 2 Files Affected: - (modified) clang/lib/Cod

[clang] [llvm] [AArch64] Add the Ampere1B core (PR #81297)

2024-02-09 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/81297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-09 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-em

<    1   2   3   4   >