Author: Jan Svoboda
Date: 2024-02-08T10:19:18-08:00
New Revision: da95d926f6fce4ed9707c77908ad96624268f134
URL:
https://github.com/llvm/llvm-project/commit/da95d926f6fce4ed9707c77908ad96624268f134
DIFF:
https://github.com/llvm/llvm-project/commit/da95d926f6fce4ed9707c77908ad96624268f134.diff
L
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/81061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jon Roelofs (jroelofs)
Changes
We should only warn if the default version is the one that is unused.
Fixes: https://github.com/llvm/llvm-project/issues/80227
---
Full diff: https://github.com/llvm/llvm-project/pull/81167.diff
4 Files Af
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ff8c865838b46d0202963b816fbed50aaf96a7f4
96e3020eaa69f7f14b67617a250df3041cc1996b --
@@ -1562,8 +1562,9 @@ bool IRTranslator::translateBitCast(const User &U,
bool IRTranslator::translateCast(unsigned Opcode, const User &U,
MachineIRBuilder &MIRBuilder) {
- if (U.getType()->getScalarType()->isBFloatTy() ||
- U.getOperand(0
@@ -521,8 +521,11 @@ void AMDGPUInstPrinter::printImmediateV216(uint32_t Imm,
uint8_t OpType,
if (printImmediateFloat32(Imm, STI, O))
return;
break;
+ case AMDGPU::OPERAND_REG_IMM_V2BF16:
case AMDGPU::OPERAND_REG_IMM_V2FP16:
+ case AMDGPU::OPERAND_REG_INLINE
@@ -79,17 +79,17 @@ define amdgpu_ps void @test_llvm_amdgcn_fdot2_bf16_bf16_sis(
; GFX11: ; %bb.0: ; %entry
; GFX11-NEXT:v_mov_b32_e32 v2, s1
; GFX11-NEXT:s_delay_alu instid0(VALU_DEP_1)
-; GFX11-NEXT:v_dot2_bf16_bf16 v2, s0, 0x10001, v2
+; GFX11-NEXT:v_do
@@ -4181,13 +4181,20 @@ bool SIInstrInfo::isInlineConstant(const MachineOperand
&MO,
case AMDGPU::OPERAND_REG_INLINE_C_V2INT16:
case AMDGPU::OPERAND_REG_INLINE_AC_V2INT16:
return AMDGPU::isInlinableLiteralV2I16(Imm);
+ case AMDGPU::OPERAND_REG_IMM_V2BF16:
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/81167
>From 96e3020eaa69f7f14b67617a250df3041cc1996b Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Thu, 8 Feb 2024 10:02:50 -0800
Subject: [PATCH 1/2] [clang][sema] Fix -Wunused-function on target_version'd
file-s
https://github.com/rampitec edited
https://github.com/llvm/llvm-project/pull/80908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80171
>From 6f8851bf21ff0a6bc9b4f2ff39df6bf00f30ee34 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 31 Jan 2024 11:09:11 -0500
Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend declarations with enum
@@ -17242,6 +17242,23 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind
TUK, SourceLocation KWLoc,
return true;
}
+ if (TUK == TUK_Friend && Kind == TagTypeKind::Enum) {
+// C++23 [dcl.type.elab]p4:
+// If an elaborated-type-specifier appears with th
aeubanks wrote:
> Good example. This pass should be run post-inline. @aeubanks, any reason we
> want to run it early in the pipeline?
We want the main function simplification pipeline to see these function
attributes because some optimizations trigger or don't trigger depending on the
presenc
Author: Jan Svoboda
Date: 2024-02-08T10:28:48-08:00
New Revision: 687304a018d36c4b0def4618a98fee6975172453
URL:
https://github.com/llvm/llvm-project/commit/687304a018d36c4b0def4618a98fee6975172453
DIFF:
https://github.com/llvm/llvm-project/commit/687304a018d36c4b0def4618a98fee6975172453.diff
L
andykaylor wrote:
> I'm suggesting that we modify Clang so that `-ffast-math` _doesn't affect_
> `denormal-fp-math`, by (as I mentioned before) removing the overload
> [Linux::getDefaultDenormalModeForType](https://github.com/llvm/llvm-project/blob/d4c5acac99e83ffa12d2d720c9e502a181cbd7ea/clang
sdkrystian wrote:
Looks like there is a test
(`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp`) that
contains the following:
```cpp
#ifdef PR64602 // Should not crash
template
struct S
{
auto foo(auto);
};
template <>
auto S<>::foo(auto)
{
return 1;
}
// CHECK8: error
@@ -538,11 +564,205 @@ std::optional checkName(const NamedDecl
&RenameDecl,
Conflict->getLocation().printToString(ASTCtx.getSourceManager())};
}
}
- if (Result)
+ if (Result) {
InvalidNameMetric.record(1, toString(Result->K));
+return makeError(*Re
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/80171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17242,6 +17242,23 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind
TUK, SourceLocation KWLoc,
return true;
}
+ if (TUK == TUK_Friend && Kind == TagTypeKind::Enum) {
+// C++23 [dcl.type.elab]p4:
+// If an elaborated-type-specifier appears with th
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/80171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
> > We also need to figure out what to do w/ `clang::assume`, because the
> > entire situation with the two being separate attributes is a bit of a mess,
> > as @erichkeane also pointed out. That can probably be resolved separately
> > from the RFC, however—though I’m not that
erichkeane wrote:
> Looks like there is a test
> (`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp`) that
> contains the following:
>
> ```c++
> #ifdef PR64602 // Should not crash
> template
> struct S
> {
> auto foo(auto);
> };
>
> template <>
> auto S<>::foo(auto)
> {
>
erichkeane wrote:
> > > We also need to figure out what to do w/ `clang::assume`, because the
> > > entire situation with the two being separate attributes is a bit of a
> > > mess, as @erichkeane also pointed out. That can probably be resolved
> > > separately from the RFC, however—though I’m
https://github.com/jkorous-apple edited
https://github.com/llvm/llvm-project/pull/80084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
This breaks check-clang-tools: http://45.33.8.238/linux/130320/step_8.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/80864
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/81171
The following test case in
`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp` is failing:
```cpp
#ifdef PR64602 // Should not crash
template
struct S
{
auto foo(auto);
};
template <>
auto
erichkeane wrote:
> Looks like there is a test
> (`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp`) that
> contains the following:
>
> ```c++
> #ifdef PR64602 // Should not crash
> template
> struct S
> {
> auto foo(auto);
> };
>
> template <>
> auto S<>::foo(auto)
> {
>
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/81171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Krystian Stasiowski (sdkrystian)
Changes
The following test case in
`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp` is failing:
```cpp
#ifdef PR64602 // Should not crash
template
struct S
{
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/81171
>From ca871fca01e07bd1dcbdab3256cb1631dabca853 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 8 Feb 2024 13:42:38 -0500
Subject: [PATCH] [clang-tidy] Fix failing test after
17f0680f69f44d340fd0
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/80347
>From 463a9904c1ae85fbdc0bd6029c6effea3fb16ea6 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Tue, 23 Jan 2024 16:16:10 -0800
Subject: [PATCH 01/18] [-Wunsafe-buffer-usage] Move Strategy class to the
head
https://github.com/erichkeane approved this pull request.
This seems right to me, though a 2nd reviewer would be nice. I don't think we
should wait for CI on this due to it fixing a bot-breakage.
https://github.com/llvm/llvm-project/pull/81171
___
cf
https://github.com/PiotrZSL approved this pull request.
LGTM, purpose of this test is just to verify that errors (any) are shown in
clang-tidy
https://github.com/llvm/llvm-project/pull/81171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
sdkrystian wrote:
@erichkeane I'm building the check-clang-extra target locally just to make sure
that the test passes... should be done in ~5 mins
https://github.com/llvm/llvm-project/pull/81171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/mahtohappy created
https://github.com/llvm/llvm-project/pull/81172
For templates, isDependentContext() is true, that's why the previous if check
was failing.
Here, we traverse the RD and upon finding a Union declaration we check if at
least one member of the union is initial
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (mahtohappy)
Changes
For templates, isDependentContext() is true, that's why the previous if check
was failing.
Here, we traverse the RD and upon finding a Union declaration we check if at
least one member of the union is initialized
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ab4a793e8bc78f50f9f104c9c732e2dd91bf70a2
aeb0686c76f2745111acd92c0d6b77faf69d2ed6 --
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/81173
This refactors the fast-math handling in the clang driver, moving the settings
into a lambda that is shared by the -ffp-model=fast and -ffast-math code.
Previously the -ffp-model=fast handler changed the loca
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Andy Kaylor (andykaylor)
Changes
This refactors the fast-math handling in the clang driver, moving the settings
into a lambda that is shared by the -ffp-model=fast and -ffast-math code.
Previously the -ff
Author: Krystian Stasiowski
Date: 2024-02-08T13:59:47-05:00
New Revision: a56fa161ab2617fa3aab3f91285fc757b6a8e09b
URL:
https://github.com/llvm/llvm-project/commit/a56fa161ab2617fa3aab3f91285fc757b6a8e09b
DIFF:
https://github.com/llvm/llvm-project/commit/a56fa161ab2617fa3aab3f91285fc757b6a8e09b
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/81171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3061,22 +3080,7 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
continue;
[[fallthrough]];
MaskRay wrote:
Should fallthrough still be used?
https://github.com/llvm/llvm-project/pull/81173
_
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/80171
>From 921ee093c7366210a8e8587baab6f5d26ae506c3 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 31 Jan 2024 11:09:11 -0500
Subject: [PATCH] [Clang][Sema] Diagnose friend declarations with enum
el
@@ -3061,22 +3080,7 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
continue;
[[fallthrough]];
andykaylor wrote:
This is falling through from OPT_Ofast to OPT_ffast_math. I think we still want
that to happen. It's
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/81172
>From aeb0686c76f2745111acd92c0d6b77faf69d2ed6 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 8 Feb 2024 10:51:22 -0800
Subject: [PATCH 1/2] [Clang][Sema] Diagnosis for constexpr constructor not
initial
https://github.com/hvdijk created
https://github.com/llvm/llvm-project/pull/81175
This reverts commit def720726b73e0d7ab139376ab3ea955f25f4d89.
As noted in #60925 and in D86310, with the current implementation of `_BitInt`
in Clang, we can have either a correct `__int128` implementation, or a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Harald van Dijk (hvdijk)
Changes
This reverts commit def720726b73e0d7ab139376ab3ea955f25f4d89.
As noted in #60925 and in D86310, with the current implementation of
`_BitInt` in Clang, we can have either a correct `__int128` implementation
https://github.com/zahiraam approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/81173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JustinStitt wrote:
ping!
https://github.com/llvm/llvm-project/pull/80089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michalpaszkowski approved this pull request.
https://github.com/llvm/llvm-project/pull/81038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Doing ad-hoc changes like that to provide an apparent guarantee without
actually documenting it, testing it and enforcing it throughout is just
churning the code base. Unless we actually have a plan to do that properly, I
would push back this change. I understand you're just try
https://github.com/nemanjai commented:
Do we really want to support only `__builtin_cpu_is` on AIX? It doesn't seem
like this would achieve the desired goal. Most users will use these builtins to
test for some capability on the target machine. It almost never really matters
to a user whether t
https://github.com/nemanjai edited
https://github.com/llvm/llvm-project/pull/80069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10347,6 +10347,8 @@ def err_x86_builtin_tile_arg_duplicate : Error<
def err_builtin_target_unsupported : Error<
"builtin is not supported on this target">;
+def err_builtin_aix_os_unsupported : Error<
+ "this builtin is available only in AIX 7.2 and later operating syst
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
nemanjai wrote:
This is getting a bit tangled. Can you please provide t
@@ -362,8 +362,18 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public
TargetInfo {
// We support __builtin_cpu_supports/__builtin_cpu_is on targets that
// have Glibc since it is Glibc that provides the HWCAP[2] in the auxv.
+#define MINIMUM_AIX_OS_MAJOR 7
---
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
Author: Jacob Lambert
Date: 2024-02-08T11:35:04-08:00
New Revision: 35c4f025f9d4c398eff0c8e49a47a5c7067939ba
URL:
https://github.com/llvm/llvm-project/commit/35c4f025f9d4c398eff0c8e49a47a5c7067939ba
DIFF:
https://github.com/llvm/llvm-project/commit/35c4f025f9d4c398eff0c8e49a47a5c7067939ba.diff
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/80921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Natalie Chouinard
Date: 2024-02-08T14:35:44-05:00
New Revision: 3b57b647a9bb821137f91dfbc2172a9947f620cc
URL:
https://github.com/llvm/llvm-project/commit/3b57b647a9bb821137f91dfbc2172a9947f620cc
DIFF:
https://github.com/llvm/llvm-project/commit/3b57b647a9bb821137f91dfbc2172a9947f620cc.d
https://github.com/sudonatalie closed
https://github.com/llvm/llvm-project/pull/81038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight wrote:
> I don't see why the current denormal-fp-math setting behavior is a blocking
> issue for this change
Because this PR as-is causes us to start parsing the "-shared" flag for
compilation actions in order to determine which denormal-fp-math setting to
use. Users should not pass
@@ -2540,6 +2540,10 @@ def ffp_contract : Joined<["-"], "ffp-contract=">,
Group,
HelpText<"Form fused FP ops (e.g. FMAs)">,
Values<"fast,on,off,fast-honor-pragmas">;
+def fcomplex_ppc_gnu_abi : Flag<["-"], "fcomplex-ppc-gnu-abi">,
Group, Visibility<[ClangOption, CC1Optio
@@ -78,6 +78,13 @@ class CodeGenOptions : public CodeGenOptionsBase {
SRCK_InRegs// Small structs in registers (-freg-struct-return).
};
+ enum ComplexArgumentConventionKind {
+CMPLX_Default,
+CMPLX_OnStack,
+CMPLX_OnGPR, // if ppc32 -fcomplex-ppc-gnu-ab
@@ -486,7 +486,8 @@ std::unique_ptr
createAIXTargetCodeGenInfo(CodeGenModule &CGM, bool Is64Bit);
std::unique_ptr
-createPPC32TargetCodeGenInfo(CodeGenModule &CGM, bool SoftFloatABI);
+createPPC32TargetCodeGenInfo(CodeGenModule &CGM, bool SoftFloatABI,
+
nemanjai wrote:
My review is not complete, I just submitted what I have so far so at least we
can get started on answering the questions I have so far.
https://github.com/llvm/llvm-project/pull/77732
___
cfe-commits mailing list
cfe-commits@lists.llvm
georgthegreat wrote:
I am OK with fixing this particular guarantee with a test.
However, I am not familiar with libc++ testset organization and I need to be
guided.
Could you, please, provide me with some clues to start wtih?
https://github.com/llvm/llvm-project/pull/80443
https://github.com/Sh0g0-1758 created
https://github.com/llvm/llvm-project/pull/81183
Fixes: #79580
**PR SUMMARY**: Changed LibASTMatcher to give an appropriate warning when a
const loop bound is initialized with a function declaration.
>From 88dac6713284ee4f0b7ce73c944f78085412645f Mon Sep
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Shourya Goel (Sh0g0-1758)
Changes
Fixes: #79580
**PR SUMMARY**: Changed LibASTMatcher to give an appropriate warning when a
const loop bound is initialized with a function declaration.
---
Full diff: https://github.com/llvm/llvm-pr
https://github.com/t-tye approved this pull request.
https://github.com/llvm/llvm-project/pull/76955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/81185
#78752 was not merged in time for clang-format 18.
From 0a6d07033cbc8218763bbee44df688b29bf7aa55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?=
Date: Thu, 8 Feb 2024 21:08:52 +0
=?utf-8?q?Björn_Schäpers?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Björn Schäpers (HazardyKnusperkeks)
Changes
#78752 was not merged in time for clang-format 18.
---
Full diff: https://github.com/llvm/llvm-project/pull/81185.diff
2 Files Affected:
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/81172
>From aeb0686c76f2745111acd92c0d6b77faf69d2ed6 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 8 Feb 2024 10:51:22 -0800
Subject: [PATCH 1/2] [Clang][Sema] Diagnosis for constexpr constructor not
initial
@@ -1010,7 +1010,8 @@ struct FormatStyle {
/// \version 3.7
DefinitionReturnTypeBreakingStyle AlwaysBreakAfterDefinitionReturnType;
- /// The function declaration return type breaking style to use.
+ /// The function declaration return type breaking style to use. This
+
@@ -833,13 +885,207 @@ class AnnotatingParser {
Left->setType(TT_ArrayInitializerLSquare);
}
FormatToken *Tok = CurrentToken;
+ if (Style.isTableGen()) {
+if (CurrentToken->isOneOf(tok::comma, tok::minus, tok::ellipsis)) {
+ // '-' and
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/80241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > @Sirraide, would you be comfortable if you, @erichkeane, and I co-authored
> > an RFC to the community?
>
> Sure, I’d be happy to help with that as best I can. An RFC makes sense imo
> seeing as this really impacts more parts of LLVM than just Clang.
Excellent, thanks!
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
@@ -10347,6 +10347,8 @@ def err_x86_builtin_tile_arg_duplicate : Error<
def err_builtin_target_unsupported : Error<
"builtin is not supported on this target">;
+def err_builtin_aix_os_unsupported : Error<
+ "this builtin is available only in AIX 7.2 and later operating syst
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
am
@@ -904,8 +904,17 @@ bool PPCTargetInfo::validateCpuSupports(StringRef
FeatureStr) const {
}
bool PPCTargetInfo::validateCpuIs(StringRef CPUName) const {
+ llvm::Triple Triple = getTriple();
+ if (Triple.isOSLinux()) {
amy-kwan wrote:
Can if we do somethin
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
@@ -0,0 +1,83 @@
+// RUN: echo "int main() { return __builtin_cpu_is(\"ppc970\");}" > %t.c
+// RUN: %clang_cc1 -triple powerpc-ibm-aix7.2.0.0 -emit-llvm -o - %t.c |
FileCheck %s \
+// RUN: --check-prefix=CHECKBOOL
+
+// RUN: echo "int main() { return __builtin_cpu_is(\"ppc-cel
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
@@ -0,0 +1,83 @@
+// RUN: echo "int main() { return __builtin_cpu_is(\"ppc970\");}" > %t.c
+// RUN: %clang_cc1 -triple powerpc-ibm-aix7.2.0.0 -emit-llvm -o - %t.c |
FileCheck %s \
+// RUN: --check-prefix=CHECKBOOL
+
+// RUN: echo "int main() { return __builtin_cpu_is(\"ppc-cel
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned
BuiltinID,
Intrinsic::ID ID = Intrinsic::not_intrinsic;
+#include "llvm/TargetParser/PPCTargetParser.def"
+ auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op,
+
@@ -3061,22 +3080,7 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
continue;
[[fallthrough]];
AaronBallman wrote:
Oh! Thank you for mentioning they're in different `switch` statements, I had
missed that as well.
@@ -2842,9 +2862,8 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
<< Args.MakeArgString("-ffp-model=" + FPModel)
<< Args.MakeArgString("-ffp-model=" + Val);
if (Val.equals("fast")) {
-optID = options::OPT_f
@@ -53,13 +55,34 @@ struct RenameInputs {
struct RenameResult {
// The range of the symbol that the user can attempt to rename.
Range Target;
+ // Placeholder text for the rename operation if non-empty.
+ std::string Placeholder;
// Rename occurrences for the current m
@@ -569,8 +840,13 @@ renameWithinFile(ParsedAST &AST, const NamedDecl
&RenameDecl,
// }
if (!isInsideMainFile(RenameLoc, SM))
continue;
+Locs.push_back(RenameLoc);
+ }
+ if (const auto *MD = dyn_cast(&RenameDecl))
+return renameObjCMethodWithinFile(AS
DavidGoldman wrote:
Thanks, PTAL, I'll save the remaining comments for follow ups.
https://github.com/llvm/llvm-project/pull/76466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/81188
'serial', 'parallel', and 'kernel' constructs are all considered
'Compute' constructs. This patch creates the AST type, plus the required
infrastructure for such a type, plus some base types that will be useful
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/81188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Erich Keane (erichkeane)
Changes
'serial', 'parallel', and 'kernel' constructs are all considered
'Compute' constructs. This patch creates the AST type, plus the required
infrastructure for such a type, plus some base types that wil
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Erich Keane (erichkeane)
Changes
'serial', 'parallel', and 'kernel' constructs are all considered
'Compute' constructs. This patch creates the AST type, plus the required
infrastructure f
@@ -2838,6 +2838,27 @@ void
ASTStmtWriter::VisitOMPTargetParallelGenericLoopDirective(
Code = serialization::STMT_OMP_TARGET_PARALLEL_GENERIC_LOOP_DIRECTIVE;
}
+//===--===//
+// OpenACC Constructs/Directive
https://github.com/jroelofs updated
https://github.com/llvm/llvm-project/pull/81167
>From 96e3020eaa69f7f14b67617a250df3041cc1996b Mon Sep 17 00:00:00 2001
From: Jon Roelofs
Date: Thu, 8 Feb 2024 10:02:50 -0800
Subject: [PATCH 1/2] [clang][sema] Fix -Wunused-function on target_version'd
file-s
@@ -2842,9 +2862,8 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
<< Args.MakeArgString("-ffp-model=" + FPModel)
<< Args.MakeArgString("-ffp-model=" + Val);
if (Val.equals("fast")) {
-optID = options::OPT_f
201 - 300 of 414 matches
Mail list logo
