[clang] [clang][Interp] Bail out on missing ComparisonCategoryInfo (PR #80131)

2024-02-06 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/80131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang][Interp] Bail out on missing ComparisonCategoryInfo (PR #80131)

2024-02-06 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/80131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Bail out on missing ComparisonCategoryInfo (PR #80131)

2024-02-06 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1,4 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only %s -verify +// RUN: %clang_cc1 -fsyntax-only %s -fexperimental-new-constant-interpreter -verify AaronBallman wrote: Excellent, thank you! https://github.com/llv

[lldb] [lld] [libc] [llvm] [compiler-rt] [clang] [flang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/80783 >From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Tue, 6 Feb 2024 01:58:58 + Subject: [PATCH] [Driver] Check the environment version except wasm case. --- cl

[lldb] [lld] [libc] [llvm] [compiler-rt] [clang] [flang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/80783 >From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Tue, 6 Feb 2024 01:58:58 + Subject: [PATCH 1/2] [Driver] Check the environment version except wasm case. ---

[clang] 5b780c8 - Diagnose invalid fixed point conversion (#80763)

2024-02-06 Thread via cfe-commits
Author: PiJoules Date: 2024-02-06T11:29:30-08:00 New Revision: 5b780c8c6c558ec283a9eec485a4f172df0f9fe1 URL: https://github.com/llvm/llvm-project/commit/5b780c8c6c558ec283a9eec485a4f172df0f9fe1 DIFF: https://github.com/llvm/llvm-project/commit/5b780c8c6c558ec283a9eec485a4f172df0f9fe1.diff LOG:

[clang] Diagnose invalid fixed point conversion (PR #80763)

2024-02-06 Thread via cfe-commits
https://github.com/PiJoules closed https://github.com/llvm/llvm-project/pull/80763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [libc] [flang] [compiler-rt] [llvm] [lldb] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread via cfe-commits
ZijunZhaoCCK wrote: > Add a test? Done. Add several tests. https://github.com/llvm/llvm-project/pull/80783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [CodeGen] Mark mem intrinsic loads and stores as dereferenceable (PR #80184)

2024-02-06 Thread Derek Schuff via cfe-commits
dschuff wrote: I am getting one local test failure here, in `/test/CodeGen/BPF/undef.ll`: The test has a bunch of [stores](https://github.com/llvm/llvm-project/blob/cdd9221489ec4ed6afc0e5146c2fae4daa8ab260/llvm/test/CodeGen/BPF/undef.ll#L44-L54) into an alloca, which i think are supposed to get

[llvm] [clang] Revert "InstCombine: Fold is.fpclass(x, fcInf) to fabs+fcmp" (PR #76338)

2024-02-06 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > @dtcxzyw are you planning on a codegen patch to improve the backend handling? I will post a patch this week. https://github.com/llvm/llvm-project/pull/76338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [llvm] [clang-tools-extra] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread via cfe-commits
@@ -159,14 +159,26 @@ declare i32 @bar(i32) ; SYM: Symbols [ ; SYM-NEXT: Symbol { ; SYM-NEXT: Index: 0 -; SYM-NEXT: Name: +; SYM-NEXT: Name: .file ; SYM-NEXT: Value (SymbolTableIndex): 0x0 ; SYM-NEXT: Section: N_DEBUG ; SYM-NEXT: Source Langua

[clang] [WebAssembly] Add tests for generic CPU config (PR #80775)

2024-02-06 Thread Thomas Lively via cfe-commits
https://github.com/tlively approved this pull request. https://github.com/llvm/llvm-project/pull/80775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/80899 Per the approved resolution for [CWG2847](https://cplusplus.github.io/CWG/issues/2847.html), [temp.expl.spec] p8 will state: > An explicit specialization shall not have a trailing _requires-clause_ unless >

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin created https://github.com/llvm/llvm-project/pull/80900 This test is not working as intended. Specifying `-mcpu=[mvp|generic|bleeding-edge]` in `clang` command line does NOT add arguments like `-target-feature`, `+feature-name`, ... to `clang-14` command line. Specif

[clang-tools-extra] `cppcoreguidelines-macro-usage`: Skip common macros which cannot be converted to `constexpr` (PR #80797)

2024-02-06 Thread via cfe-commits
https://github.com/bwrsandman converted_to_draft https://github.com/llvm/llvm-project/pull/80797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes Per the approved resolution for [CWG2847](https://cplusplus.github.io/CWG/issues/2847.html), [temp.expl.spec] p8 will state: > An explicit specialization shall not have a trailing _requires-clause_

[clang] [clang-tools-extra] [llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread via cfe-commits
stephenpeckham wrote: The other failing testcase was added after my PR was created. I didn't notice the failure that occured after the merge. https://github.com/llvm/llvm-project/pull/80162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Heejin Ahn (aheejin) Changes This test is not working as intended. Specifying `-mcpu=[mvp|generic|bleeding-edge]` in `clang` command line does NOT add arguments like `-target-feature`, `+feature-name`, ..

[clang] [-Wunsafe-buffer-usage] Ignore constant safe indices in array subscripts (PR #80504)

2024-02-06 Thread via cfe-commits
https://github.com/jkorous-apple updated https://github.com/llvm/llvm-project/pull/80504 >From 463a9904c1ae85fbdc0bd6029c6effea3fb16ea6 Mon Sep 17 00:00:00 2001 From: Jan Korous Date: Tue, 23 Jan 2024 16:16:10 -0800 Subject: [PATCH 01/20] [-Wunsafe-buffer-usage] Move Strategy class to the head

[clang] [llvm] [clang-tools-extra] Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass"" (PR #74056)

2024-02-06 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: @arsenm Can you rebase this patch first? https://github.com/llvm/llvm-project/pull/74056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] `cppcoreguidelines-macro-usage`: Skip common macros which cannot be converted to `constexpr` (PR #80797)

2024-02-06 Thread via cfe-commits
@@ -80,6 +80,20 @@ void MacroUsageCheck::warnMacro(const MacroDirective *MD, StringRef MacroName) { const MacroInfo *Info = MD->getMacroInfo(); StringRef Message; + for (const auto &T : MD->getMacroInfo()->tokens()) { +if (T.is(tok::hash)) { + return; +} +

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

2024-02-06 Thread Jeremy Morse via cfe-commits
jmorse wrote: I see what you're saying about the metadata being incorrect; I feel like I've seen it before, but can't pin it down. For the record, all the builds where we saw this assertion were thin/full LTO. I've kicked off a reduction of a large reproducer that I have to hand; I'm not imme

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-02-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic demilestoned https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Thomas Lively via cfe-commits
tlively wrote: > The reason it is passing is because it only has `-NOT` checks This doesn't look right, though. There are plenty of positive checks in the file, so how could it be passing if it's not checking the right things? https://github.com/llvm/llvm-project/pull/80900

[clang-tools-extra] c13e271 - Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (#77816)

2024-02-06 Thread via cfe-commits
Author: Bhuminjay Soni Date: 2024-02-06T20:57:34+01:00 New Revision: c13e271a38363d354294e2af1651470bed8facb3 URL: https://github.com/llvm/llvm-project/commit/c13e271a38363d354294e2af1651470bed8facb3 DIFF: https://github.com/llvm/llvm-project/commit/c13e271a38363d354294e2af1651470bed8facb3.diff

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
@@ -252,4 +252,14 @@ namespace dr2397 { // dr2397: 17 auto (*c)[5] = &a; } } // namespace dr2397 + +// CWG2363 was closed as NAD, but its resolution does affirm that +// a friend declaration cannot have an opaque-enumm-specifier. +namespace dr2363 { // dr2363: yes +struct

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-02-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
aheejin wrote: Sorry, I was confused. Enabling individual features with `-mfeature-name` to `clang` adds `-target-feature` `feature-name` to the `clang-14` as intended. Only the `-mcpu` tests were not working as intended. I think I need to only delete the parts that test CPUs instead. https:/

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin updated https://github.com/llvm/llvm-project/pull/80900 >From 540b5036be1ae1d867b5d3a48b31fa7a1f415898 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Tue, 6 Feb 2024 19:28:18 + Subject: [PATCH 1/2] [WebAssembly] Remove wasm-features.c test This test is not worki

[clang-tools-extra] `cppcoreguidelines-macro-usage`: Skip common macros which cannot be converted to `constexpr` (PR #80797)

2024-02-06 Thread Piotr Zegar via cfe-commits
@@ -80,6 +80,20 @@ void MacroUsageCheck::warnMacro(const MacroDirective *MD, StringRef MacroName) { const MacroInfo *Info = MD->getMacroInfo(); StringRef Message; + for (const auto &T : MD->getMacroInfo()->tokens()) { +if (T.is(tok::hash)) { + return; +} +

[clang] [WebAssembly] Remove wasm-features.c test (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Remove CPU tests from wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add new `join` API and replace existing `merge` implementations. (PR #80361)

2024-02-06 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/80361 >From 660d1afbda79416beb6f373e6252670f912a5181 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Tue, 30 Jan 2024 16:02:21 + Subject: [PATCH 1/4] Add new `join` API and replace existing `merge` implementa

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you, aside from some small suggestions, this LGTM https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-06 Thread Aaron Ballman via cfe-commits
@@ -396,6 +396,15 @@ class VerifyDiagnosticConsumer::MarkerTracker { } }; +std::string DetailedErrorString(DiagnosticsEngine &Diags) { + std::string ErrDirective; + if (Diags.getDiagnosticOptions().VerifyPrefixes.empty()) +ErrDirective = "expected"; + else +ErrDir

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Fangrui Song via cfe-commits
MaskRay wrote: wasm tests in android-* seem weird. A wasm file should be used https://github.com/llvm/llvm-project/pull/80783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll requested changes to this pull request. Since you're creating a new file in C++ DR test suite, I left several comments to guide you towards bringing this new file up to speed with the rest of the suite. https://github.com/llvm/llvm-project/pull/80899

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -std=c++20 -verify=expected %s + +namespace dr2847 { // dr2847: 19 + +template +void i(); + +struct A { + template + void f() requires true; + + template<> + void f() requires true; // expected-error {{explicit specialization cannot have a

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -std=c++20 -verify=expected %s + +namespace dr2847 { // dr2847: 19 + Endilll wrote: As this test requires C++20, it should be wrapped in `#if __cplusplus`. https://github.com/llvm/llvm-project/pull/80899

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -std=c++20 -verify=expected %s Endilll wrote: Can you copy RUN lines from `dr26xx.cpp`, adding verify prefixed you need in your test (`since-cxx20`)? https://github.com/llvm/llvm-project/pull/80899 __

[clang] [WebAssembly] Cleanup feature tests (PR #80780)

2024-02-06 Thread Heejin Ahn via cfe-commits
@@ -50,3 +60,73 @@ // DEFAULT-NOT: "-target-feature" "-multimemory" // MVP-NOT: "-target-feature" "+multimemory" // BLEEDING-EDGE-NOT: "-target-feature" "-multimemory" + +// RUN: %clang --target=wasm32-unknown-unknown -### %s -matomics 2>&1 | FileCheck %s -check-prefix=ATOMICS

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From a39aab07696acfea3e3b78d6ad92c8b771eaf0d2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/3] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Mike Hommey via cfe-commits
@@ -1443,16 +1443,18 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) { const ToolChain &TC = getToolChain( *UArgs, computeTargetTriple(*this, TargetTriple, *UArgs)); - // Check if the environment version is valid. - llvm::Triple Triple = TC.getTriple(); -

[clang] [WebAssembly] Remove CPU tests from wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
aheejin wrote: Hmm, on second thought, I think it'd be better to test `-target-cpu` lines instead than deleting the whole thing. Sorry for the flip-flopping. https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @Endilll I applied your suggested changes... how does it look? https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Remove CPU tests from wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin updated https://github.com/llvm/llvm-project/pull/80900 >From 540b5036be1ae1d867b5d3a48b31fa7a1f415898 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Tue, 6 Feb 2024 19:28:18 + Subject: [PATCH 1/3] [WebAssembly] Remove wasm-features.c test This test is not worki

[clang] [WebAssembly] Fix CPU tests from wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Fix CPU tests in wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Fix CPU tests in wasm-features.c (PR #80900)

2024-02-06 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Much better, thank you. Couple of small changes, and DR test should be good to go. https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -std=c++20 -verify=expected %s + +namespace dr2847 { // dr2847: 19 + Endilll wrote: `#if __cplusplus >= 202302L` skips over C++20, which doesn't seem intentional given the previous iteration of this PR I reviewed. I also put

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Whoops... changed it to `202002L` :) https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-06 Thread Eli Friedman via cfe-commits
@@ -628,7 +628,7 @@ CodeGenFunction::getJumpDestForLabel(const LabelDecl *D) { // Create, but don't insert, the new block. Dest = JumpDest(createBasicBlock(D->getName()), - EHScopeStack::stable_iterator::invalid(), + EHScopeStack::stable_i

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28

[clang] [WebAssembly] Fix CPU tests in wasm-features.c (PR #80900)

2024-02-06 Thread Thomas Lively via cfe-commits
https://github.com/tlively approved this pull request. This makes sense, thanks! https://github.com/llvm/llvm-project/pull/80900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-06 Thread Eli Friedman via cfe-commits
@@ -628,7 +628,7 @@ CodeGenFunction::getJumpDestForLabel(const LabelDecl *D) { // Create, but don't insert, the new block. Dest = JumpDest(createBasicBlock(D->getName()), - EHScopeStack::stable_iterator::invalid(), + EHScopeStack::stable_i

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. DR testing looks good now. Thank you for bearing with me! I tried to give this a proper in-depth review, but the only corner case that comes to my mind is conversion functions. Feel free to dismiss it if you don't think it's relevant or int

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-02-06 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue converted_to_draft https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3f1e95a - [clang][Interp] consider "MS constexpr" functions as well

2024-02-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-06T21:49:13+01:00 New Revision: 3f1e95a9d4cc1fdb933390247d0bd4391cf93f60 URL: https://github.com/llvm/llvm-project/commit/3f1e95a9d4cc1fdb933390247d0bd4391cf93f60 DIFF: https://github.com/llvm/llvm-project/commit/3f1e95a9d4cc1fdb933390247d0bd4391cf93f60.diff LO

[clang] cc55af7 - [clang][Interp] Only check ComparisonCategoryInfo in C++ (#80131)

2024-02-06 Thread via cfe-commits
Author: Timm Baeder Date: 2024-02-06T22:01:59+01:00 New Revision: cc55af777a19b69f466875683655810f5d485386 URL: https://github.com/llvm/llvm-project/commit/cc55af777a19b69f466875683655810f5d485386 DIFF: https://github.com/llvm/llvm-project/commit/cc55af777a19b69f466875683655810f5d485386.diff L

[clang] [clang][Interp] Bail out on missing ComparisonCategoryInfo (PR #80131)

2024-02-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/80131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From 671a0b01f0131b3d1dedfd3c9f74dcbe29a615b5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH] [Clang][Sema] Implement proposed resolution for CWG2847

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/80783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. LGTM with glandium's suggestion. https://github.com/llvm/llvm-project/pull/80783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Fangrui Song via cfe-commits
@@ -14,3 +14,18 @@ // RUN: FileCheck --check-prefix=CHECK-TARGET %s // CHECK-TARGET: "aarch64-unknown-linux-android31" + +// RUN: not %clang --target=armv7-linux-gnuS -c %s -### 2>&1 | \ +// RUN: FileCheck --check-prefix=CHECK-ERROR2 %s + +// CHECK-ERROR2: error: version '

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread Fangrui Song via cfe-commits
@@ -14,3 +14,18 @@ // RUN: FileCheck --check-prefix=CHECK-TARGET %s MaskRay wrote: Sorry, I didn't see the `[clang/test/Driver/invalid-version.cpp](https://github.com/llvm/llvm-project/pull/80783/files#diff-6c20c1f9b36f569382ab3c9daebb660db0eb8666af4beaf59813

[clang] 51a3019 - [Clang][Sema] Implement proposed resolution for CWG2847 (#80899)

2024-02-06 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-02-06T16:06:38-05:00 New Revision: 51a3019e4d096d93820f921af20d7a0bf3fffc48 URL: https://github.com/llvm/llvm-project/commit/51a3019e4d096d93820f921af20d7a0bf3fffc48 DIFF: https://github.com/llvm/llvm-project/commit/51a3019e4d096d93820f921af20d7a0bf3fffc48

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-02-06 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 823e05ca073366f54996a74b2a6d6661ed4e575a Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module b

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-02-06 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From b47b42eec3752270fa65c3e6ba0b9c78485d811e Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module b

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Subclass `-Wshorten-64-to-32` under `-Wimplicit-int-conversion` (PR #80814)

2024-02-06 Thread David Blaikie via cfe-commits
dwblaikie wrote: Can't seem to load the image - and generally a copy/paste of the text is more usable for everyone than a screenshot. If you could include the copy/pasted text, that'd be handy, thanks! https://github.com/llvm/llvm-project/pull/80814

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-06 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [clang] require template arg list after template kw (PR #80801)

2024-02-06 Thread Erick Velez via cfe-commits
@@ -868,6 +868,9 @@ def err_requires_expr_in_simple_requirement : Error< "requires expression in requirement body; did " "you intend to place it in a nested requirement? (add another 'requires' " "before the expression)">; +def err_missing_template_arg_list_after_template

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Krystian Stasiowski via cfe-commits
@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -252,4 +252,14 @@ namespace dr2397 { // dr2397: 17 auto (*c)[5] = &a; } } // namespace dr2397 + +// CWG2363 was closed as NAD, but its resolution does affirm that +// a friend declaration cannot have an opaque-enumm-specifier. +namespace dr2363 { // dr2363: yes +struct

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-02-06 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 03d3310ca300630a94517fa300858d1f2645e843 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module b

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-02-06 Thread Tony Tye via cfe-commits
@@ -605,12 +606,197 @@ class SIGfx12CacheControl : public SIGfx11CacheControl { bool IsNonTemporal) const override; }; +class SIPreciseMemorySupport { t-tye wrote: My initial thought had been that this would be part of th

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-02-06 Thread Tony Tye via cfe-commits
@@ -605,12 +606,197 @@ class SIGfx12CacheControl : public SIGfx11CacheControl { bool IsNonTemporal) const override; }; +class SIPreciseMemorySupport { +protected: + const GCNSubtarget &ST; + const SIInstrInfo *TII = nullptr; + + IsaVers

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/80381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Document the type_visibility attribute (PR #79157)

2024-02-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the improved documentation! In general, heading in the right direction. There might be some more details we'd like to add, but if you don't know those details, that's totally fine (this at least moves the needle in the right direction).

[clang] [clang] Document the type_visibility attribute (PR #79157)

2024-02-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/79157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Document the type_visibility attribute (PR #79157)

2024-02-06 Thread Aaron Ballman via cfe-commits
@@ -3220,8 +3220,8 @@ def TypeVisibility : InheritableAttr { let Args = [EnumArgument<"Visibility", "VisibilityType", ["default", "hidden", "internal", "protected"], ["Default", "Hidden", "Hidden", "Protected"]>]; -// let

[clang] [clang] Document the type_visibility attribute (PR #79157)

2024-02-06 Thread Aaron Ballman via cfe-commits
@@ -5557,6 +5557,21 @@ See :doc:`LTOVisibility`. }]; } +def TypeVisibilityDocs : Documentation { + let Category = DocCatType; + let Content = [{ +The ``type_visibility`` attribute allows the ELF visibility of a type and its vague AaronBallman wrote: Does

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-06 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 updated https://github.com/llvm/llvm-project/pull/78338 >From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001 From: Sh0g0-1758 Date: Wed, 17 Jan 2024 01:24:17 +0530 Subject: [PATCH 01/22] Fix : more detailed no expected directive message --- cla

[clang] [Clang][Sema] Diagnose declarative nested-name-specifiers naming alias templates (PR #80842)

2024-02-06 Thread Vlad Serebrennikov via cfe-commits
@@ -6295,22 +6297,36 @@ bool Sema::diagnoseQualifiedDeclaration(CXXScopeSpec &SS, DeclContext *DC, << FixItHint::CreateRemoval(TemplateId->TemplateKWLoc); NestedNameSpecifierLoc SpecLoc(SS.getScopeRep(), SS.location_data()); - while (SpecLoc.getPrefix()) { + do {

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/80783 >From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Tue, 6 Feb 2024 01:58:58 + Subject: [PATCH 1/2] [Driver] Check the environment version except wasm case. ---

[clang] [Driver] Check the environment version except wasm case. (PR #80783)

2024-02-06 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/80783 >From 84506beecc20a064a5c895cf5c04135118da6606 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Tue, 6 Feb 2024 01:58:58 + Subject: [PATCH 1/3] [Driver] Check the environment version except wasm case. ---

<    1   2   3   4   5   6   >