[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Timm Baeder via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[libcxx] [libc] [compiler-rt] [lld] [clang] [lldb] [llvm] [flang] [clang-tools-extra] [libc++] P2602R2 Poison Pills are Too Toxic (PR #74534)

2024-02-05 Thread Jakub Mazurkiewicz via cfe-commits
https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/74534 >From aaccb9e13618517803df1230741b02b4c5ee08c7 Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Tue, 5 Dec 2023 23:36:57 +0100 Subject: [PATCH 1/6] [libc++] P2602R2 Poison Pills are Too Toxic --- l

[clang] [mlir] [llvm] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-05 Thread Akash Banerjee via cfe-commits
@@ -2953,7 +2953,7 @@ int bar(int n){ // CHECK3-NEXT:[[TMP8:%.*]] = getelementptr inbounds [[STRUCT__GLOBALIZED_LOCALS_TY_0:%.*]], ptr [[TMP4]], i32 [[TMP5]] // CHECK3-NEXT:[[C:%.*]] = getelementptr inbounds [[STRUCT__GLOBALIZED_LOCALS_TY_0]], ptr [[TMP8]], i32 0, i32

[clang] [mlir] [llvm] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-05 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis edited https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread Alfie Richards via cfe-commits
https://github.com/AlfieRichardsArm created https://github.com/llvm/llvm-project/pull/80691 This is to be inline with the Arm C Language Specification. (https://github.com/ARM-software/acle/releases/download/r2022Q2/acle-2022Q2.pdf) and with GCC. This fixes https://github.com/llvm/llvm-projec

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-02-05 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @cor3ntin https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alfie Richards (AlfieRichardsArm) Changes This is to be inline with the Arm C Language Specification. (https://github.com/ARM-software/acle/releases/download/r2022Q2/acle-2022Q2.pdf) and with GCC. This fixes https://github.com/llvm/llvm-

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread Alfie Richards via cfe-commits
AlfieRichardsArm wrote: This could be an ABI break. `poly8_t` will now be `uint8_t` rather than `int8_t`, which also changes the signatures of certain functions. Certainly there were some comments in the effected code as to why this was not done initially referring to ABI. @mmalcomson I was s

[clang] d172286 - [Clang] Make AMDGPU OpenCL tests require AMD registered target

2024-02-05 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-02-05T09:08:31-06:00 New Revision: d1722868d34a69df8466b72098176f54a7af8823 URL: https://github.com/llvm/llvm-project/commit/d1722868d34a69df8466b72098176f54a7af8823 DIFF: https://github.com/llvm/llvm-project/commit/d1722868d34a69df8466b72098176f54a7af8823.diff

[clang] [mlir] [llvm] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-02-05 Thread Akash Banerjee via cfe-commits
@@ -36,14 +36,14 @@ void test() { // CHECK1-NEXT:[[DYN_PTR_ADDR:%.*]] = alloca ptr, align 8 // CHECK1-NEXT:[[DOTZERO_ADDR:%.*]] = alloca i32, align 4 // CHECK1-NEXT:[[DOTTHREADID_TEMP_:%.*]] = alloca i32, align 4 -// CHECK1-NEXT:store ptr [[DYN_PTR]], ptr [[DYN_

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d15c454bedc05775b5080e1d2130b0554d5e5a81 0993e1c309a56c7e3813658ae4ebdd87a4573aa3 --

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread Alfie Richards via cfe-commits
https://github.com/AlfieRichardsArm updated https://github.com/llvm/llvm-project/pull/80691 >From 1897afe4d3568fbe007ab53fae1722ebe831b09e Mon Sep 17 00:00:00 2001 From: Alfie Richards Date: Mon, 5 Feb 2024 14:25:32 + Subject: [PATCH] [ARM] Change NEON poly type to be unsigned. (#56781) Th

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[clang-tools-extra] [llvm] [clang] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] [clang-tools-extra] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] [clang-tools-extra] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] [analyzer] Model Microsoft "__assume" in the same way as clang "__builtin_assume" (PR #80456)

2024-02-05 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/80456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79753 >From 0e108e92b3165f95a934895e14f6c330f6c5e3fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 16:13:08 +0100 Subject: [PATCH] [clang][Interp] Emit const references for Float

[clang-tools-extra] [clang] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang-tools-extra] [clang] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] [ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread Alfie Richards via cfe-commits
https://github.com/AlfieRichardsArm updated https://github.com/llvm/llvm-project/pull/80691 >From 1d956381662f4e20c8fff2655c60862711b6e69d Mon Sep 17 00:00:00 2001 From: Alfie Richards Date: Mon, 5 Feb 2024 14:25:32 + Subject: [PATCH] [ARM] Change NEON poly type to be unsigned. (#56781) Th

[clang] [clang-tools-extra] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] 41ea022 - [Clang] Fix crash when recovering from an invalid pack indexing type. (#80652)

2024-02-05 Thread via cfe-commits
Author: cor3ntin Date: 2024-02-05T16:28:05+01:00 New Revision: 41ea02261224446dadb1b1561d70137699255518 URL: https://github.com/llvm/llvm-project/commit/41ea02261224446dadb1b1561d70137699255518 DIFF: https://github.com/llvm/llvm-project/commit/41ea02261224446dadb1b1561d70137699255518.diff LOG:

[clang] [Clang] Fix crash when recovering from an invalid pack indexing type. (PR #80652)

2024-02-05 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/80652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy ,

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Timm Baeder via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[clang] [CLANG] Fix INF/NAN warning. (PR #80290)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -73,7 +73,7 @@ def warn_pragma_debug_unexpected_argument : Warning< def warn_fp_nan_inf_when_disabled : Warning< "use of %select{infinity|NaN}0%select{| via a macro}1 is undefined behavior " "due to the currently enabled floating-point options">, - InGroup>; + InGroup>

[clang] [CLANG] Fix INF/NAN warning. (PR #80290)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -87,3 +87,10 @@ program by treating all string literals as having type ``const char *`` instead of ``char *``. This can cause unexpected behaviors with type-sensitive constructs like ``_Generic``. }]; + +defvar NanInfDisabledDocs = [{ +This warning is enabled when source co

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-02-05 Thread Guillot Tony via cfe-commits
to268 wrote: Ping: @AaronBallman https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[clang] 4881cbd - [clang][Interp] Fix MemberExpr initializing an existing value (#79973)

2024-02-05 Thread via cfe-commits
Author: Timm Baeder Date: 2024-02-05T16:41:55+01:00 New Revision: 4881cbd407e73f940a8e9ede501c2eee190ec9dd URL: https://github.com/llvm/llvm-project/commit/4881cbd407e73f940a8e9ede501c2eee190ec9dd DIFF: https://github.com/llvm/llvm-project/commit/4881cbd407e73f940a8e9ede501c2eee190ec9dd.diff L

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-02-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Change NEON poly type to be unsigned (#56781) (PR #80691)

2024-02-05 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/80691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-05 Thread Erich Keane via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -fsyntax-only -Wunused-lambda-capture -Wused-but-marked-unused -Wno-uninitialized -verify -std=c++20 %s + +void test() { + int i; + auto explicit_by_value_unused_requires = [i] (auto) requires requires { i; } {}; // expected-warning{{lambda

[clang-tools-extra] [llvm] [clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-05 Thread Erich Keane via cfe-commits
@@ -19706,22 +19706,29 @@ static void buildLambdaCaptureFixit(Sema &Sema, LambdaScopeInfo *LSI, } } +static DeclContext *ignoreReuquiresBodyDecl(DeclContext *DC) { erichkeane wrote: Name here doesn't match what you're doing here. Perhaps something closer

[clang] [llvm] [clang-tools-extra] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-05 Thread Erich Keane via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang -fsyntax-only -std=c++20 -Xclang -verify %s + +// expected-no-diagnostics + +auto GH69307_Func_1() { + constexpr auto b = 1; + return [&](auto c) -> int erichkeane wrote: Can you do a similar test with NO capture here? To show

[llvm] [clang] [clang-tools-extra] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-05 Thread Erich Keane via cfe-commits
@@ -19706,22 +19706,29 @@ static void buildLambdaCaptureFixit(Sema &Sema, LambdaScopeInfo *LSI, } } +static DeclContext *ignoreReuquiresBodyDecl(DeclContext *DC) { erichkeane wrote: ```suggestion static DeclContext *ignoreRequiresBodyDecl(DeclContext *DC)

[llvm] [clang] [lldb] [clang-tools-extra] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #78977)

2024-02-05 Thread Paolo Severini via cfe-commits
https://github.com/paolosevMSFT updated https://github.com/llvm/llvm-project/pull/78977 >From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001 From: Paolo Severini Date: Mon, 22 Jan 2024 06:06:56 -0800 Subject: [PATCH 1/3] Add support for DW_OP_WASM_location to DWARFExpression

[llvm] [clang] [clang-tools-extra] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread Balazs Benics via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy ,

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/80662 >From 91c130565aca5e915140aacf3ffca5c59b689523 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 5 Feb 2024 10:29:45 +0100 Subject: [PATCH] [clang][Interp] Do r-to-l conversion immediately

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Timm Baeder via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[clang] [llvm] [RISCV] Add support for RISC-V Pointer Masking (PR #79929)

2024-02-05 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/79929 >From fafae54117daf3d871e9df63cc4f1430a433edf0 Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Mon, 29 Jan 2024 12:33:59 -0800 Subject: [PATCH 1/3] [RISCV] Add support for RISC-V Pointer Masking Th

[clang] [clang-tools-extra] [llvm] [codegen] Emit cleanups for lifetime-extended temporaries when stmt-expr has control-flow (PR #80698)

2024-02-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/80698 Partially solves https://github.com/llvm/llvm-project/issues/63818 for control flow in braced aggregate initialisation. The reason why we miss cleanups for temporaries in braced aggregate init is that the lifetime

[clang] ae354c5 - [analyzer] Model Microsoft "__assume" in the same way as clang "__builtin_assume"

2024-02-05 Thread Balazs Benics via cfe-commits
Author: Loïc Joly Date: 2024-02-05T17:02:24+01:00 New Revision: ae354c5a45d319b3117c2822b8f6988461f3cb33 URL: https://github.com/llvm/llvm-project/commit/ae354c5a45d319b3117c2822b8f6988461f3cb33 DIFF: https://github.com/llvm/llvm-project/commit/ae354c5a45d319b3117c2822b8f6988461f3cb33.diff LOG

[clang] [clang-tools-extra] [llvm] [codegen] Emit cleanups for lifetime-extended temporaries when stmt-expr has control-flow (PR #80698)

2024-02-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Utkarsh Saxena (usx95) Changes Partially solves https://github.com/llvm/llvm-project/issues/63818 for control flow in braced aggregate initialisation. The reason why we miss cleanups for temporaries in braced aggregate init is th

[clang] [analyzer] Model Microsoft "__assume" in the same way as clang "__builtin_assume" (PR #80456)

2024-02-05 Thread Balazs Benics via cfe-commits
steakhal wrote: Pushed manually to preserve the patch author. (I believe, "squash&merge" would overwrite it.) Merged as ae354c5a45d319b3117c2822b8f6988461f3cb33. https://github.com/llvm/llvm-project/pull/80456 ___ cfe-commits mailing list cfe-commits@

[clang] [analyzer] Model Microsoft "__assume" in the same way as clang "__builtin_assume" (PR #80456)

2024-02-05 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/80456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [codegen] Emit cleanups for lifetime-extended temporaries when stmt-expr has control-flow (PR #80698)

2024-02-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 702664e7870c27f197dfb744a4db54aa259ce452 eeabfa285a660debf9a38bdb4a956996ee06a59b --

[clang] fee204f - [analyzer] Support interestingness in ArrayBoundV2 (#78315)

2024-02-05 Thread via cfe-commits
Author: NagyDonat Date: 2024-02-05T17:07:14+01:00 New Revision: fee204f0c9b3b77898c1faa2a7415b0f64f5e7f0 URL: https://github.com/llvm/llvm-project/commit/fee204f0c9b3b77898c1faa2a7415b0f64f5e7f0 DIFF: https://github.com/llvm/llvm-project/commit/fee204f0c9b3b77898c1faa2a7415b0f64f5e7f0.diff LOG

[clang] [clang-tools-extra] [llvm] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-02-05 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy ,

[clang] Fix clang crash when printing highlighted code in diagnostic (after #66514) (PR #80442)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -1349,7 +1349,7 @@ void TextDiagnostic::emitSnippetAndCaret( // Prepare source highlighting information for the lines we're about to // emit, starting from the first line. std::unique_ptr[]> SourceStyles = - highlightLines(BufStart, Lines.first, Lines.second, PP,

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -119,12 +121,26 @@ template bool EvalEmitter::emitRet(const SourceInfo &Info) { template <> bool EvalEmitter::emitRet(const SourceInfo &Info) { if (!isActive()) return true; - EvalResult.setPointer(S.Stk.pop()); + + const Pointer &Ptr = S.Stk.pop(); + // Implicitl

[llvm] [clang] [RISCV] Add support for RISC-V Pointer Masking (PR #79929)

2024-02-05 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/79929 >From e5e34889db5d64e5b918f434f16408756e8cb90d Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Mon, 29 Jan 2024 12:33:59 -0800 Subject: [PATCH] [RISCV] Add support for RISC-V Pointer Masking This p

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-02-05 Thread Matt Arsenault via cfe-commits
@@ -1129,8 +1129,97 @@ struct BitTest { static BitTest decodeBitTestBuiltin(unsigned BuiltinID); }; + +// Returns the first convergence entry/loop/anchor instruction found in |BB|. +// std::nullopt otherwise. +std::optional getConvergenceToken(llvm::BasicBlock *BB) { + for

[llvm] [clang] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-02-05 Thread Matt Arsenault via cfe-commits
@@ -1129,8 +1129,97 @@ struct BitTest { static BitTest decodeBitTestBuiltin(unsigned BuiltinID); }; + +// Returns the first convergence entry/loop/anchor instruction found in |BB|. +// std::nullopt otherwise. +std::optional getConvergenceToken(llvm::BasicBlock *BB) { + for

[clang] [clang][Interp] Do r-to-l conversion immediately when returning (PR #80662)

2024-02-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/80662 >From bd8e8351850d843a64da05964f817b918c1ebd59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 5 Feb 2024 10:29:45 +0100 Subject: [PATCH] [clang][Interp] Do r-to-l conversion immediately

[clang] 66cd768 - [clang][Interp] Handle __assume like __builtin_assume.

2024-02-05 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-05T17:33:08+01:00 New Revision: 66cd768504b349f7bd16d236a3b4f611ffabf78f URL: https://github.com/llvm/llvm-project/commit/66cd768504b349f7bd16d236a3b4f611ffabf78f DIFF: https://github.com/llvm/llvm-project/commit/66cd768504b349f7bd16d236a3b4f611ffabf78f.diff LO

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie edited https://github.com/llvm/llvm-project/pull/80687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie commented: Generally seems like good stuff to write down - I'm not sure about the ABI breaking version (that mostly seems like it would make more problems than solutions). Commented on some minor grammatical issues. https://github.com/llvm/llvm-project/pull/80687

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[clang] [docs] [C++20] [Modules] Ideas for transitioning to modules (PR #80687)

2024-02-05 Thread David Blaikie via cfe-commits
@@ -610,6 +610,345 @@ the following style significantly: The key part of the tip is to reduce the duplications from the text includes. +Ideas for converting to modules +--- + +For new libraries, we encourage them to use modules completely from day

[llvm] [clang] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -126,4 +126,57 @@ PPC_LNX_CPU("power10",47) #undef PPC_LNX_DEFINE_OFFSETS #undef PPC_LNX_FEATURE #undef PPC_LNX_CPU + +// Definition of following value are found in the AIX header file amy-kwan wrote: ```suggestion // Definition of the following values are

[llvm] [clang] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned BuiltinID, Intrinsic::ID ID = Intrinsic::not_intrinsic; +#include "llvm/TargetParser/PPCTargetParser.def" + auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op, +

[clang] [llvm] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -126,4 +126,57 @@ PPC_LNX_CPU("power10",47) #undef PPC_LNX_DEFINE_OFFSETS #undef PPC_LNX_FEATURE #undef PPC_LNX_CPU + +// Definition of following value are found in the AIX header file +#ifndef AIX_POWERPC_SYS_CONF +#define AIX_POWERPC_SYS_CONF +#define AIX_SYSCON_IMPL_IDX

[clang] [llvm] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -16542,22 +16542,75 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned BuiltinID, Intrinsic::ID ID = Intrinsic::not_intrinsic; +#include "llvm/TargetParser/PPCTargetParser.def" + auto GetOpRes = [&](Value *FieldValue, unsigned Mask, unsigned Op, +

[llvm] [clang] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -362,8 +362,18 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { // We support __builtin_cpu_supports/__builtin_cpu_is on targets that // have Glibc since it is Glibc that provides the HWCAP[2] in the auxv. +#define MINIMUM_AIX_OS_MAJOR 7 +#define MI

[clang] [llvm] [AIX] support builtin_cpu_is() for aix (PR #80069)

2024-02-05 Thread Amy Kwan via cfe-commits
@@ -126,4 +126,57 @@ PPC_LNX_CPU("power10",47) #undef PPC_LNX_DEFINE_OFFSETS #undef PPC_LNX_FEATURE #undef PPC_LNX_CPU + +// Definition of following value are found in the AIX header file +#ifndef AIX_POWERPC_SYS_CONF +#define AIX_POWERPC_SYS_CONF +#define AIX_SYSCON_IMPL_IDX

[clang] Diagnose misuse of the cleanup attribute (PR #80040)

2024-02-05 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > tried to implement the requested changes along the new direction, I have some > queries should I let this statament as is or assign to a variable: > > ``` > S.CheckFunctionCall(FD, FunctionCallExpression, > FD->getType()->getAs()); > ``` That call on

[clang] Diagnose misuse of the cleanup attribute (PR #80040)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -106,6 +106,9 @@ Improvements to Clang's diagnostics - Clang now applies syntax highlighting to the code snippets it prints. +- Clang now provides improved warnings for the cleanup attribute to detect misuse scenarios, + such as attempting to call `free` on unallocated

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-05 Thread James Y Knight via cfe-commits
jyknight wrote: > It is not always safe to run preserve-sign code under IEEE settings I can see that this is used in a bunch of optimization/constant-folding passes, but I don't have a feel for what the actual impact is: 1. Which value allows generating the "fastest" math code -- disregarding

[clang] [clang-tools-extra] [llvm] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/80698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [codegen] Emit cleanups for lifetime-extended temporaries when an expr contains control-flow (PR #80698)

2024-02-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/80698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [openmp] [OpenMP] Remove `register_requires` global constructor (PR #80460)

2024-02-05 Thread Joseph Huber via cfe-commits
@@ -6872,35 +6883,6 @@ void OpenMPIRBuilder::loadOffloadInfoMetadata(StringRef HostFilePath) { loadOffloadInfoMetadata(*M.get()); } -Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) { jhuber6 wrote: It was a very obvious problem. I mixed u

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/80713 This patch adjusts the build process for building the toolchain for the CI container to perform more rigorous perf-training for PGO, particularly building the entirety of LLVM as that is what showed the b

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/80713 >From bef28f6d909060aeb4993866fad52dbe8a897d20 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 3 Feb 2024 20:46:57 -0800 Subject: [PATCH 1/2] [Github] Use building LLVM as perf-training for CI co

[llvm] [clang] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-05 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (PR #68515)

2024-02-05 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/68515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Change default value of checker option in unix.StdCLibraryFunctions. (PR #80457)

2024-02-05 Thread Balazs Benics via cfe-commits
steakhal wrote: I'm excited to see this change. I've not reviewed this yet. https://github.com/llvm/llvm-project/pull/80457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5e8626c - [clang][Interp] Handle ObjCBoolLiteralExprs

2024-02-05 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-05T18:21:30+01:00 New Revision: 5e8626c920a8c4e286cd8521528cc80c0a3e URL: https://github.com/llvm/llvm-project/commit/5e8626c920a8c4e286cd8521528cc80c0a3e DIFF: https://github.com/llvm/llvm-project/commit/5e8626c920a8c4e286cd8521528cc80c0a3e.diff LO

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aiden Grossman (boomanaiden154) Changes This patch adjusts the build process for building the toolchain for the CI container to perform more rigorous perf-training for PGO, particularly building the entirety of LLVM as that is what showed

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-02-05 Thread David Goldman via cfe-commits
@@ -508,24 +513,46 @@ static bool mayBeValidIdentifier(llvm::StringRef Ident) { !isAsciiIdentifierStart(Ident.front(), AllowDollar)) return false; for (char C : Ident) { +if (AllowColon && C == ':') + continue; if (llvm::isASCII(C) && !isAsciiIdentifie

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-05 Thread Matt Arsenault via cfe-commits
arsenm wrote: > * Which value allows generating the "fastest" math code -- disregarding > correctness? I'd assume that "dynamic" is least optimizable, "ieee" in the > middle, and "preserve-sign" is likely to generate the "fastest" code? This depends on the target and operations. For some funct

[clang] [clang] emit an error when the same identifier appears with both internal and external linkage in a translation unit (PR #78064)

2024-02-05 Thread Aaron Ballman via cfe-commits
@@ -4754,6 +4754,11 @@ void Sema::MergeVarDecl(VarDecl *New, LookupResult &Previous) { return New->setInvalidDecl(); } + if (Old->getFormalLinkage() != New->getFormalLinkage()) { +Diag(New->getLocation(), diag::err_multiple_linkage) << New->getDeclName(); +retu

[llvm] [clang] [clang-tools-extra] [AMDGPU] GlobalISel for f8 conversions (PR #80503)

2024-02-05 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/80503 >From b07f5866aa8acf881fbdb15450ecda4dfc8a68e8 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Fri, 2 Feb 2024 14:28:00 -0800 Subject: [PATCH 1/2] [AMDGPU] Fixed byte_sel of v_cvt_f32_bf8/v_cvt_f32_fp

[clang-tools-extra] [llvm] [clang] [DebugInfo][RemoveDIs] Don't allocate one DPMarker per instruction (PR #79345)

2024-02-05 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse updated https://github.com/llvm/llvm-project/pull/79345 >From 0620bf77b4a8586dc1aa96d72bd088a3e601edd4 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Wed, 24 Jan 2024 16:33:16 + Subject: [PATCH 1/4] [DebugInfo][RemoveDIs] Don't allocate one DPMarker per instruc

[clang-tools-extra] Add support for renaming objc methods, even those with multiple selector pieces (PR #76466)

2024-02-05 Thread David Goldman via cfe-commits
@@ -538,11 +565,254 @@ std::optional checkName(const NamedDecl &RenameDecl, Conflict->getLocation().printToString(ASTCtx.getSourceManager())}; } } - if (Result) + if (Result) { InvalidNameMetric.record(1, toString(Result->K)); +return makeError(*Re

[clang-tools-extra] [llvm] [clang] [AMDGPU] GlobalISel for f8 conversions (PR #80503)

2024-02-05 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/80503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (PR #68515)

2024-02-05 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: I don't have commit access, @arsenm please merge. https://github.com/llvm/llvm-project/pull/68515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5942868 - [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (#68515)

2024-02-05 Thread via cfe-commits
Author: Mészáros Gergely Date: 2024-02-05T23:23:13+05:30 New Revision: 5942868a215ce4dbd927a7f0b06432e1eeaed698 URL: https://github.com/llvm/llvm-project/commit/5942868a215ce4dbd927a7f0b06432e1eeaed698 DIFF: https://github.com/llvm/llvm-project/commit/5942868a215ce4dbd927a7f0b06432e1eeaed698.di

<    1   2   3   4   5   >