[clang] [clang][dataflow] In the CFG visualization, mark converged blocks. (PR #79999)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78720 >From e0c682e9fd2c88554c78349bc0b4f32403959e7b Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 19 Jan 2024 08:37:21 -0500 Subject: [PATCH] [Clang][Sema] Allow elaborated-type-specifiers that decl

[compiler-rt] [libcxxabi] [llvm] [lld] [mlir] [openmp] [libunwind] [clang-tools-extra] [clang] [libcxx] [lldb] [libc] [flang] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 01/15] [clang] static operators should evaluate object argumen

[openmp] [lld] [clang-tools-extra] [flang] [compiler-rt] [clang] [lldb] [libunwind] [llvm] [libcxx] [libcxxabi] [mlir] [libc] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
SuperSodaSea wrote: Should be easy to backport using llvmbot once it is merged. https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Add assumptions to vsetvli/vsetvlimax (PR #79975)

2024-01-30 Thread Kito Cheng via cfe-commits
kito-cheng wrote: Does it possible to add testcases to demonstrate that can improve optimization? https://github.com/llvm/llvm-project/pull/79975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [clang-tools-extra] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle approved this pull request. https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [flang] [libcxx] [mlir] [clang] [lld] [compiler-rt] [libc] [libc++][complex] P2819R2: Add `tuple` protocol to `complex` (PR #79744)

2024-01-30 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/79744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78720 >From e2cf4ed5f8f6d695ce3eea5b969357d02f42e6ab Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 19 Jan 2024 08:37:21 -0500 Subject: [PATCH] [Clang][Sema] Allow elaborated-type-specifiers that decl

[llvm] [clang-tools-extra] [flang] [libcxx] [mlir] [clang] [libcxxabi] [openmp] [compiler-rt] [libc] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/78632 >From a786cdedc2c9a9898cd0b80d84f5b11aace5da1c Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 28 Nov 2023 15:44:02 + Subject: [PATCH 01/10] [AArch64] Add custom lowering for load <3 x i8>. Add custom co

[llvm] [clang-tools-extra] [flang] [libcxx] [mlir] [clang] [libcxxabi] [openmp] [compiler-rt] [libc] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/78632 >From a786cdedc2c9a9898cd0b80d84f5b11aace5da1c Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 28 Nov 2023 15:44:02 + Subject: [PATCH 01/11] [AArch64] Add custom lowering for load <3 x i8>. Add custom co

[clang] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXDefaultInitExpr (PR #80001)

2024-01-30 Thread via cfe-commits
https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/80001 This patch dump the rewritten sub-expressions in `CXXDefaultArgExpr` and `CXXDefaultInitExpr`. This machinery is useful for checking whether the materialized temporaries is lifetime-extended in the sub-AST of

[clang] [Driver] Fix erroneous warning for -fcx-limited-range and -fcx-fortran-rules. (PR #79821)

2024-01-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e37a6008831b38477516362892dd3c0d97087eff aea883b73a072e8a7bd261a4d6b5885660bd215f --

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-01-30 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/77936 >From 7314429a203900a8f555e1b0471fdd4cfd4d8d03 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Wed, 10 Jan 2024 14:57:04 + Subject: [PATCH 01/12] [Clang][SME] Detect always_inline used with mismatched s

[llvm] [clang] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-01-30 Thread Sam Tebbs via cfe-commits
@@ -814,6 +821,93 @@ Address AArch64ABIInfo::EmitMSVAArg(CodeGenFunction &CGF, Address VAListAddr, /*allowHigherAlign*/ false); } +class SMEAttributes { +public: + bool IsStreaming = false; + bool IsStreamingBody = false; + bool IsStreamingCompati

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected direc

[clang] [llvm] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! Can you please add more description to what is being fixed and how to the PR summary (as that becomes the commit message when we land the changes)? I don't think a release note is necessary because this isn't really a user-faci

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; AaronBallman wrote: I think @jrtc27 is sayin

[llvm] [clang] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -1098,7 +1098,14 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { - Diags.Report(diag::err_verify_no_directives).setForc

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/72892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix erroneous warning for -fcx-limited-range and -fcx-fortran-rules. (PR #79821)

2024-01-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXDefaultInitExpr (PR #80001)

2024-01-30 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/80001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-30 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776

[clang] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXDefaultInitExpr (PR #80001)

2024-01-30 Thread via cfe-commits
yronglin wrote: > LGTM Thanks for your review! https://github.com/llvm/llvm-project/pull/80001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program &P, std::vector &Code, const Floating &Val, Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program &P, std::vector &Code, + const IntegralAP &Val, bool &Success) { + size_t Size = Val.bytesToSerialize(); + +

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program &P, std::vector &Code, const Floating &Val, Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program &P, std::vector &Code, + const IntegralAP &Val, bool &Success) { + size_t Size = Val.bytesToSerialize(); + +

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Aaron Ballman via cfe-commits
@@ -263,6 +263,30 @@ template class IntegralAP final { *R = IntegralAP(A.V.lshr(ShiftAmount)); } + // === Serialization support === + size_t bytesToSerialize() const { +// 1 byte for the BitWidth followed by N bytes for the actual APInt. +// FIXME: Is 1 byte

[clang-tools-extra] [compiler-rt] [llvm] [libc] [mlir] [libcxxabi] [clang] [flang] [libcxx] [openmp] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/78632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Here's gnome-terminal's default colors, first normal and then bright: ![Screenshot from 2024-01-30 14-55-37](https://github.com/llvm/llvm-project/assets/49720664/9f225494-0cc9-4d53-a0e1-98b45b5b4c4b) Here the same with xterm: ![Screenshot from 2024-01-30 14-58-24](https://githu

[clang] [NVPTX] Allow compiling LLVM-IR without `-march` set (PR #79873)

2024-01-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Right now if you specify target-cpu you get target-cpu attributes, which is > > what we don't want. > > I'm fine handling 'generic' in a special way under the hood and not > specifying target-CPU. > > My concern is about user-facing interface. Command line options must be

[clang] [llvm] [flang] [lld] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-30 Thread Konstantin Zhuravlyov via cfe-commits
@@ -44,8 +44,15 @@ constexpr uint32_t VersionMajorV5 = 1; /// HSA metadata minor version for code object V5. constexpr uint32_t VersionMinorV5 = 2; +/// HSA metadata major version for code object V6. +constexpr uint32_t VersionMajorV6 = 1; +/// HSA metadata minor version for c

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread via cfe-commits
@@ -154,6 +154,47 @@ const D &d3(c); // FIXME ill-formed #endif } +namespace dr2273 { // dr2273: 3.3 +#if __cplusplus >= 201103L +struct A { + A(int = 0) = delete; // #dr2273-A +}; + +struct B : A { // #dr2273-B + using A::A; +}; + +B b; +// since-cxx11-error@-1 {{call to im

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/79981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxx] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-01-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/80007 However, mark them as EXCLUDE_FROM_ALL when we don't want to build them. Simply declaring the targets should be of no harm, and it allows other projects to mention these targets regardless of whether they end up

[libunwind] [libcxxabi] [libcxx] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxxabi Author: Louis Dionne (ldionne) Changes However, mark them as EXCLUDE_FROM_ALL when we don't want to build them. Simply declaring the targets should be of no harm, and it allows other projects to mention these targets regardless of whether the

[libcxxabi] [libunwind] [libcxx] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) Changes However, mark them as EXCLUDE_FROM_ALL when we don't want to build them. Simply declaring the targets should be of no harm, and it allows other projects to mention these targets regardless of whether the

[clang-tools-extra] [clang] [llvm] [SLP]Improve findReusedOrderedScalars and graph rotation. (PR #77529)

2024-01-30 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > Please can you add better comments explaining the process Improves the rendering info, taken from gathered/buildvector nodes. Currently, this info is taken only from vector nodes. E.g. if we have 2 nodes: vectorized and gather/buildvector , the reoder info is build only

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexcept

[libcxxabi] [libunwind] [libcxx] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-01-30 Thread Louis Dionne via cfe-commits
ldionne wrote: CC @petrhosek @vitalybuka since this broke your setups last time. The reproduction steps were really non-trivial so I never got around to reproducing, but it would be great to see if this is still problematic. https://github.com/llvm/llvm-project/pull/80007 _

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Also should get a run line that errors due to wavesize? https://github.com/llvm/llvm-project/pull/79980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[lld] [flang] [llvm] [clang] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-30 Thread Pierre van Houtryve via cfe-commits
@@ -44,8 +44,15 @@ constexpr uint32_t VersionMajorV5 = 1; /// HSA metadata minor version for code object V5. constexpr uint32_t VersionMinorV5 = 2; +/// HSA metadata major version for code object V6. +constexpr uint32_t VersionMajorV6 = 1; +/// HSA metadata minor version for c

[clang-tools-extra] [compiler-rt] [libcxx] [lld] [libc] [flang] [clang] [lldb] [llvm] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #79985)

2024-01-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/79985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [compiler-rt] [libcxx] [lld] [flang] [libcxxabi] [libc] [lldb] [libunwind] [openmp] [clang] [llvm] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
@@ -5865,10 +5867,24 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType, const CGCallee &OrigCallee break; } } + +if (const auto *MD = +dyn_cast_if_present(OCE->getCalleeDecl()); +MD && MD->isStatic()) + StaticOperator = true

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-30 Thread Andrew Schenk via cfe-commits
schenka0 wrote: > (I'm not sure how that happened in the first place.) I believe you suggested a (minor) change and I just clicked commit suggestion: ![Screenshot_20240130_091821_Chrome](https://github.com/llvm/llvm-project/assets/154034018/cb668631-29fa-498d-9ba3-d02e40bcb4e9) Didn't realize

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread via cfe-commits
cor3ntin wrote: This looks good. I think we should create a meta issue to track our remaining inheriting constructor bugs. Is there anything in P0136R1 that would not be covered by these core issues? https://github.com/llvm/llvm-project/pull/79981 ___

[clang] [Clang] Fix typo in __fprintf_chk Prototype (PR #80012)

2024-01-30 Thread Jinsong Ji via cfe-commits
https://github.com/jsji created https://github.com/llvm/llvm-project/pull/80012 And extra int was copied. >From 6df91613ae5a5a5f844167cae6f2f799c6a32aa8 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Tue, 30 Jan 2024 06:46:54 -0800 Subject: [PATCH] [Clang] Fix typo in __fprintf_chk Prototype

[clang] [Clang] Fix typo in __fprintf_chk Prototype (PR #80012)

2024-01-30 Thread Jinsong Ji via cfe-commits
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/80012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [llvm] [libc] [compiler-rt] [lld] [libcxx] [clang-tools-extra] [libcxxabi] [flang] [SLP]Improve findReusedOrderedScalars and graph rotation. (PR #77529)

2024-01-30 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev updated https://github.com/llvm/llvm-project/pull/77529 >From 7440ee8ba235fd871af0999f66d5d6130456400b Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Tue, 9 Jan 2024 21:43:31 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[lldb] [openmp] [clang] [llvm] [libc] [libcxx] [libcxxabi] [mlir] [flang] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXDefaultInitExpr (PR #80001)

2024-01-30 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/80001 >From 1e45decdaeb529904fd2076b9be42234dbd5a871 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 30 Jan 2024 21:11:48 +0800 Subject: [PATCH] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXD

[clang] [Clang] Fix typo in __fprintf_chk Prototype (PR #80012)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) Changes An extra int was copied. --- Full diff: https://github.com/llvm/llvm-project/pull/80012.diff 1 Files Affected: - (modified) clang/include/clang/Basic/Builtins.td (+1-1) ``diff diff --git a/clang/inc

[clang] [clang] [MinGW] Handle linking ARM64EC code (PR #78912)

2024-01-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo commented: Code wise, this seems good, but I think we'd like to have a testcase for it. https://github.com/llvm/llvm-project/pull/78912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > with stack exhaustion warning, the compiler can continue (albeit being slow > or unstable). The depth limit here will be a hard restriction and so there > will be no workaround if the code reaches it. It is a surprise to me that this is only a warning instead of a hard erro

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program &P, std::vector &Code, const Floating &Val, Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program &P, std::vector &Code, + const IntegralAP &Val, bool &Success) { + size_t Size = Val.bytesToSerialize(); + +

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
@@ -228,6 +229,42 @@ void emit(Program &P, std::vector &Code, const Floating &Val, Val.serialize(Code.data() + ValPos); } +template <> +void emit(Program &P, std::vector &Code, + const IntegralAP &Val, bool &Success) { + size_t Size = Val.bytesToSerialize(); + +

[clang] [clang][dataflow] Extend debug output for `Environment`. (PR #79982)

2024-01-30 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/79982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Nathan Chancellor via cfe-commits
nathanchance wrote: > But due to I can't reproduce the failure, @nathanchance would you like to > make this? I don't want to make something that I can't test. I don't mind submitting something if I have some guidance around how this should be handled (I am a little lost in this thread at the m

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-01-30 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Yeah, that's my proposal for metadata that's useful to record, especially since `min == max` gives the present case https://github.com/llvm/llvm-project/pull/79035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2024-01-30 Thread via cfe-commits
Aokamal wrote: Hi, Sorry I kind of don't know much about the change. We have the following code snippet ``` #if ABSL_HAVE_BUILTIN(__builtin_cpu_supports) if (__builtin_cpu_supports("avx2")) { ... } #endif ``` when run with arm cpu, it fails with `error: builtin is not supported on thi

[clang] 0058263 - [clang-format] Support of TableGen tokens with unary operator like form, bang operators and numeric literals. (#78996)

2024-01-30 Thread via cfe-commits
Author: Hirofumi Nakamura Date: 2024-01-31T00:30:37+09:00 New Revision: 00582636009d51c5781b9cae8fde858ab3758306 URL: https://github.com/llvm/llvm-project/commit/00582636009d51c5781b9cae8fde858ab3758306 DIFF: https://github.com/llvm/llvm-project/commit/00582636009d51c5781b9cae8fde858ab3758306.d

[clang] [clang-format] Support of TableGen tokens with unary operator like form, bang operators and numeric literals. (PR #78996)

2024-01-30 Thread Hirofumi Nakamura via cfe-commits
https://github.com/hnakamura5 closed https://github.com/llvm/llvm-project/pull/78996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Support of TableGen tokens with unary operator like form, bang operators and numeric literals. (PR #78996)

2024-01-30 Thread Hirofumi Nakamura via cfe-commits
hnakamura5 wrote: @HazardyKnusperkeks Thank you for checking and accepting! @mydeveloperday You will be able to see the points in the consequent PRs. https://github.com/llvm/llvm-project/pull/78996 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From 60e72f20f5bf74a3e62688cfcaa2bc623f0faff1 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From a9a6b6ea71ef57eabd136d3b00a9dad0011a86e5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @cor3ntin Addressed review comments... Please approve if it all checks out :) https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[llvm] [clang] [HLSL] Implementation of tan intrinsic (PR #79948)

2024-01-30 Thread Farzon Lotfi via cfe-commits
@@ -1010,6 +1010,7 @@ let IntrProperties = [IntrNoMem, IntrSpeculatable, IntrWillReturn] in { def int_powi : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>, llvm_anyint_ty]>; def int_sin : DefaultAttrsIntrinsic<[llvm_anyfloat_ty], [LLVMMatchType<0>]>; def

[llvm] [clang] [HLSL] Implementation of tan intrinsic (PR #79948)

2024-01-30 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/79948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From c9f1518241b27978c40b7a5fc52f2c5ad9d32604 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 15:57:07 +0100 Subject: [PATC

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-30 Thread Rohit Aggarwal via cfe-commits
@@ -0,0 +1,332 @@ +; RUN: opt -vector-library=AMDLIBM -passes=inject-tli-mappings,loop-vectorize -S < %s | FileCheck %s + +; Test to verify that when math headers are built with +; __FINITE_MATH_ONLY__ enabled, causing use of ___finite +; function versions, vectorization can map

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-30 Thread Rohit Aggarwal via cfe-commits
@@ -1279,6 +1281,213 @@ void TargetLibraryInfoImpl::addVectorizableFunctionsFromVecLib( } break; } + case AMDLIBM: { +#define FIXED(NL) ElementCount::getFixed(NL) +const VecDesc VecFuncs[] = { rohitaggarwal007 wrote: done https://github.com/ll

[llvm] [clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c61686e8abc2aee6e2e0ad09c6d1ade534e

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-30 Thread Rohit Aggarwal via cfe-commits
@@ -129,7 +129,8 @@ class TargetLibraryInfoImpl { MASSV,// IBM MASS vector library. SVML, // Intel short vector math library. SLEEFGNUABI, // SLEEF - SIMD Library for Evaluating Elementary Functions. -ArmPL// Arm Performance Libra

[lld] [clang-tools-extra] [clang] [flang] [openmp] [compiler-rt] [mlir] [llvm] [libc] [lldb] [libcxx] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-30 Thread Oleksandr Alex Zinenko via cfe-commits
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve modeling of 'realpath' in StdLibraryFunctionsChecker (PR #79939)

2024-01-30 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/79939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve modeling of 'realpath' in StdLibraryFunctionsChecker (PR #79939)

2024-01-30 Thread Balázs Kéri via cfe-commits
@@ -2992,12 +2992,14 @@ void StdLibraryFunctionsChecker::initFunctionSummaries( // char *realpath(const char *restrict file_name, //char *restrict resolved_name); -// FIXME: Improve for errno modeling. addToFunctionSummaryMap( "realpat

[clang] [clang][analyzer] Improve modeling of 'realpath' in StdLibraryFunctionsChecker (PR #79939)

2024-01-30 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. https://github.com/llvm/llvm-project/pull/79939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

2024-01-30 Thread via cfe-commits
https://github.com/Yaraslaut updated https://github.com/llvm/llvm-project/pull/75545 >From 79c0d0a8304184f276a6f854500b8965eb2b5c3f Mon Sep 17 00:00:00 2001 From: Yaraslau Tamashevich Date: Fri, 15 Dec 2023 01:57:15 +0200 Subject: [PATCH] Fix check for empty Compilation --- clang/tools/clang-

[clang] [clang-scan-deps] Fix check for empty `Compilation` (PR #75545)

2024-01-30 Thread via cfe-commits
@@ -728,7 +728,7 @@ getCompilationDataBase(int argc, char **argv, std::string &ErrorMessage) { *Diags); std::unique_ptr C( TheDriver.BuildCompilation(CommandLine)); - if (!C) + if (C->getJobs().empty()) Yaraslaut wrote: Co

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79747 >From 13b8fa29188bcf1f2122fb8a0708ecc468b8e097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 09:48:15 +0100 Subject: [PATCH] [clang][Interp] Support arbitrary precision cons

[clang] [clang] Fix a possible out-of-bounds read (PR #80023)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/80023 Fixes #79964 >From 77c9461b321fa82c82e3e4a1e29c825b912c8ed2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 17:04:23 +0100 Subject: [PATCH] [clang] Fix a possible out-of-boun

[clang] [clang] Fix a possible out-of-bounds read (PR #80023)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Fixes #79964 --- Full diff: https://github.com/llvm/llvm-project/pull/80023.diff 1 Files Affected: - (modified) clang/lib/Frontend/TextDiagnostic.cpp (+1-1) ``diff diff --git a/clang/lib/Fronten

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread via cfe-commits
@@ -6327,12 +6331,42 @@ bool Sema::diagnoseQualifiedDeclaration(CXXScopeSpec &SS, DeclContext *DC, return false; } + // C++23 [temp.names]p5: + // The keyword template shall not appear immediately after a declarative + // nested-name-specifier. + if (TemplateId

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread via cfe-commits
@@ -4394,8 +4394,14 @@ NestedNameSpecifierLoc TreeTransform::TransformNestedNameSpecifierLoc( SS.Adopt(ETL.getQualifierLoc()); TL = ETL.getNamedTypeLoc(); } -SS.Extend(SemaRef.Context, /*FIXME:*/ SourceLocation(), TL, - Q.ge

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread via cfe-commits
@@ -3,21 +3,21 @@ template // expected-note{{previous template}} class X0 { public: typedef int size_type; - + X0(int); ~X0(); - + void f0(const T&, const U&); - + T& operator[](int i) const; - + void f1(size_type) const; void f2(size_type) const;

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread via cfe-commits
@@ -6327,12 +6331,42 @@ bool Sema::diagnoseQualifiedDeclaration(CXXScopeSpec &SS, DeclContext *DC, return false; } + // C++23 [temp.names]p5: + // The keyword template shall not appear immediately after a declarative + // nested-name-specifier. + if (TemplateId

[clang] [Clang][Parse] Diagnose member template declarations with multiple declarators (PR #78243)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @cor3ntin https://github.com/llvm/llvm-project/pull/78243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [mlir] [flang] [llvm] [clang-tools-extra] [clang] [libc] [lldb] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-30 Thread Dawei Pan via cfe-commits
dwpan wrote: > Hello. Can you explain why this is needed, as opposed to using the equivalent > shift/and/ors? In Verilog/SystemVerilog language, the basic type is bit or bit vector, and length is arbitrary, insert/extract bits are common features in language. Introducing corresponding intrin

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
@@ -3,21 +3,21 @@ template // expected-note{{previous template}} class X0 { public: typedef int size_type; - + X0(int); ~X0(); - + void f0(const T&, const U&); - + T& operator[](int i) const; - + void f1(size_type) const; void f2(size_type) const;

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
@@ -4394,8 +4394,14 @@ NestedNameSpecifierLoc TreeTransform::TransformNestedNameSpecifierLoc( SS.Adopt(ETL.getQualifierLoc()); TL = ETL.getNamedTypeLoc(); } -SS.Extend(SemaRef.Context, /*FIXME:*/ SourceLocation(), TL, - Q.ge

[clang] [Clang][NFC] Remove TemplateArgumentList::OnStack (PR #79760)

2024-01-30 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79760 >From 1f6d9f32e21032b11f6e6a4fd6186ccaee88e2e2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Sun, 28 Jan 2024 11:03:52 -0500 Subject: [PATCH] [Clang][NFC] Remove TemplateArgumentList::OnStack ---

[clang-tools-extra] [lld] [clang] [flang] [compiler-rt] [llvm] [libc] [lldb] [libcxx] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-30 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Given the problem in https://github.com/llvm/llvm-project/pull/77753#issuecomment-1912258038 , @cor3ntin , @AaronBallman WDYT about adding new flags to `CXXRecordDecl`, saying that constructor/destructor is not really `constexpr` before C++23? https://github.com/llvm/llvm-pro

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman requested changes to this pull request. It looks like a bunch of formatting changes came in with SemaChecking.cpp. You should only be formatting the code that your patch needs to touch. We've got a script for that: https://clang.llvm.org/docs/ClangFormat.html#sc

[clang] [clang][analyzer] Add note tags to alpha.unix.BlockInCriticalSection (PR #80029)

2024-01-30 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 created https://github.com/llvm/llvm-project/pull/80029 checker On entering a critical section, a note tag is now placed along the bugpath. From 54da4f5ff32a0e35777fd77f6a928c65789c22af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Tue,

[clang] [clang][analyzer] Add note tags to alpha.unix.BlockInCriticalSection (PR #80029)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Endre Fülöp (gamesh411) Changes checker On entering a critical section, a note tag is now placed along the bugpath. --- Full diff: https://github.com/llvm/llvm-project/pull/80029.diff 2 Files Affected: - (modified) clang/lib/StaticAna

[clang] [clang][analyzer] Add note tags to alpha.unix.BlockInCriticalSection (PR #80029)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Endre Fülöp (gamesh411) Changes checker On entering a critical section, a note tag is now placed along the bugpath. --- Full diff: https://github.com/llvm/llvm-project/pull/80029.diff 2 Files Affected: - (modified) c

[clang] [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (PR #80030)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: Gabor, please let me know if you think anyone else should review this change, given that there are assorted clients of the PostCFG view. We think this is a benefit for anyone using a post-order view in a worklist algorithm, but have a hard time anticipating all the potential uses.

[clang] [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (PR #80030)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/80030 >From 974b337c522973cc03eca3d6c1e873e83f8201aa Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Mon, 29 Jan 2024 21:26:27 + Subject: [PATCH] [clang][CFG] Change child order in Reverse Post Order (RPO) it

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand created https://github.com/llvm/llvm-project/pull/80033 As per the FIXME, this cap never really served its purpose. This patch simplifies to a single, caller-specified, absolute cap. >From fef909302d31b131007558252981270360fcac39 Mon Sep 17 00:00:00 2001 From: Yitzhak M

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yitzhak Mandelbaum (ymand) Changes As per the FIXME, this cap never really served its purpose. This patch simplifies to a single, caller-specified, absolute cap. --- Full diff: https://github.com/llvm/llvm-project/pull/80033.diff 1 File

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > Could you show the stack (omitting/annotating the repeated part) that leads > > to failure? and/or the AST shape that leads to failure? > > See the test I added. All you need is ~10k overloads of a method in a class > and a `using Base::func` in the derived class. The AST

  1   2   3   4   5   6   7   >