[clang] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes We preserve the trailing requires-expression during the lambda expression transformation. In order to get those referenced parameters inside a requires-expression properly resolved to the instantiated decls, w

[clang] [Concepts] Traverse the instantiation chain for parameter injection inside a constraint scope (PR #79568)

2024-01-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. This makes sense to me. https://github.com/llvm/llvm-project/pull/79568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] be8e462 - [Clang][RISCV] Forward --no-relax option to linker for RISC-V (#76432)

2024-01-26 Thread via cfe-commits
Author: Andreu Carminati Date: 2024-01-26T09:36:59-08:00 New Revision: be8e462a0c27e4850020c96290cabdcdbcab46f3 URL: https://github.com/llvm/llvm-project/commit/be8e462a0c27e4850020c96290cabdcdbcab46f3 DIFF: https://github.com/llvm/llvm-project/commit/be8e462a0c27e4850020c96290cabdcdbcab46f3.di

[clang] [Clang][RISCV] Forward --no-relax option to linker for RISC-V (PR #76432)

2024-01-26 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/76432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d5fe1bd - [AIX][TLS] Disallow the use of -maix-small-local-exec-tls and -fno-data-sections (#79252)

2024-01-26 Thread via cfe-commits
Author: Amy Kwan Date: 2024-01-26T12:39:25-05:00 New Revision: d5fe1bd081ec129a1259cccf5171692d87dbd1f3 URL: https://github.com/llvm/llvm-project/commit/d5fe1bd081ec129a1259cccf5171692d87dbd1f3 DIFF: https://github.com/llvm/llvm-project/commit/d5fe1bd081ec129a1259cccf5171692d87dbd1f3.diff LOG:

[llvm] [clang] [AIX][TLS] Disallow the use of -maix-small-local-exec-tls and -fno-data-sections (PR #79252)

2024-01-26 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan closed https://github.com/llvm/llvm-project/pull/79252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libc] [libcxx] [openmp] [compiler-rt] [clang-tools-extra] [mlir] [llvm] [flang] [clang] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-01-26 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/74512 >From 169d962b64b8ae242c3a6d332677296cf7503839 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 5 Dec 2023 10:28:44 -0800 Subject: [PATCH 1/4] [clang] Avoid -Wshadow warning when init-capture

[openmp] [compiler-rt] [clang] [mlir] [libcxx] [libcxxabi] [clang-tools-extra] [libc] [flang] [llvm] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-01-26 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Ok, now it emits `-Wshadow-uncaptured-local` when lambda doesn't capture this, and `-Wshadow` when it does. https://github.com/llvm/llvm-project/pull/74512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[openmp] [compiler-rt] [clang] [mlir] [libcxx] [libcxxabi] [clang-tools-extra] [libc] [flang] [llvm] [clang] Avoid -Wshadow warning when init-capture named same as class field (PR #74512)

2024-01-26 Thread Mariya Podchishchaeva via cfe-commits
@@ -8395,10 +8395,11 @@ void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl, unsigned WarningDiag = diag::warn_decl_shadow; SourceLocation CaptureLoc; - if (isa(D) && isa(ShadowedDecl) && NewDC && - isa(NewDC)) { + if (isa(D) && NewDC && isa(NewDC)) {

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the Fix! Your summary should be a description of the problem and how your solution fixes that problem. You should also link to the github issue in the summary. Questions about the changes in the PR should go as a comment to the PR. Please add

[libc] [compiler-rt] [clang-tools-extra] [llvm] [lldb] [flang] [clang] LLDB Debuginfod usage tests (with fixes) (PR #79181)

2024-01-26 Thread Kevin Frei via cfe-commits
@@ -0,0 +1,65 @@ +# Tests for basic Debuginfod functionality + +Because the Debuginfod protocol is a simple HTTP path-based system, one can +mimic a Debuginfod server by setting up a directory structure to reflect the +protocol properly. That's how all these tests operate. We over

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread via cfe-commits
AdvenamTacet wrote: I rewrote all functions with turned off instrumentation (I removed `_LIBCPP_STRING_INTERNAL_MEMORY_ACCESS` completely) and I see no change in behavior. Error happens in the very same way with the very same shadow memory (and backtrace). I don't see where annotations can be

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Louis Dionne via cfe-commits
ldionne wrote: @AaronBallman We're struggling a bit to find the right person to help review this -- do you know who would be a good candidate? Hui is very familiar with libc++ but he's less familiar with codegen, and I'm not very useful in that area of the project :-). https://github.com/llvm

[llvm] [clang] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-26 Thread David Green via cfe-commits
davemgreen wrote: It looks like this needs to update testAArch64CPUArchList too. Otherwise it LGTM https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-26 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-26 Thread Pil Eghoff via cfe-commits
https://github.com/pileghoff edited https://github.com/llvm/llvm-project/pull/79588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [lldb] [libunwind] [compiler-rt] [clang] [flang] [clang-tools-extra] [mlir] [openmp] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud edited https://github.com/llvm/llvm-project/pull/77608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [lldb] [libunwind] [compiler-rt] [clang] [flang] [clang-tools-extra] [mlir] [openmp] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud edited https://github.com/llvm/llvm-project/pull/77608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [lldb] [libunwind] [compiler-rt] [clang] [flang] [clang-tools-extra] [mlir] [openmp] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud edited https://github.com/llvm/llvm-project/pull/77608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-01-26 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -245,10 +265,15 @@ int *nothingIsCertain(int x, int y) { if (x >= 2) return 0; int *mem = (

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-26 Thread Pil Eghoff via cfe-commits
pileghoff wrote: > Thank you for the Fix! Your summary should be a description of the problem > and how your solution fixes that problem. You should also link to the github > issue in the summary. > > Questions about the changes in the PR should go as a comment to the PR. > > Please add a rel

[llvm] [clang-tools-extra] [clang] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-01-26 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To:

[libc] [compiler-rt] [flang] [clang-tools-extra] [clang] [llvm] [X86] Do not end 'note.gnu.property' section with -fcf-protection (PR #79360)

2024-01-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/79360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [llvm] [clang-tools-extra] [flang] [libc] [X86] Do not end 'note.gnu.property' section with -fcf-protection (PR #79360)

2024-01-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/79360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [analyzer] Support interestingness in ArrayBoundV2 (PR #78315)

2024-01-26 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/75371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2327,6 +2327,25 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, } case Builtin::BI__builtin_launder: return SemaBuiltinLaunder(*this, TheCall); + case Builtin::BI__builtin_clear_padding: { +const Expr *PtrArg = TheCall->getArg(0)->Ig

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -60,9 +60,14 @@ #include "llvm/Support/ScopedPrinter.h" #include "llvm/TargetParser/AArch64TargetParser.h" #include "llvm/TargetParser/X86TargetParser.h" +#include #include #include + + +#include efriedma-quic wrote: iostream is forbidden in LLVM co

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2327,6 +2327,25 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, } case Builtin::BI__builtin_launder: return SemaBuiltinLaunder(*this, TheCall); + case Builtin::BI__builtin_clear_padding: { +const Expr *PtrArg = TheCall->getArg(0)->Ig

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2327,6 +2327,25 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, } case Builtin::BI__builtin_launder: return SemaBuiltinLaunder(*this, TheCall); + case Builtin::BI__builtin_clear_padding: { +const Expr *PtrArg = TheCall->getArg(0)->Ig

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -4315,6 +4453,13 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, return RValue::get(Ptr); } + case Builtin::BI__builtin_clear_padding: { +const Expr *Op = E->getArg(0); +Value *Address = EmitScalarExpr(Op); ---

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: Please clang-format changes. https://github.com/llvm/llvm-project/pull/75371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,556 @@ +// RUN: mkdir -p %t +// RUN: %clang++ %s -o %t/run +// RUN: %t/run efriedma-quic wrote: Tests that need to actually run generated code go into the test-suite repo. (I don't think that's really necessary here, though; if you're going to start

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
@@ -2456,6 +2461,139 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +template +void RecursivelyClearPaddingImpl(CodeGenFunction &CGF, Value *Ptr, QualType Ty, size_t CurrentStartOffset, size

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-26 Thread Pil Eghoff via cfe-commits
pileghoff wrote: I can also see i broke the `n3042.c` test. Stuff like `if (null_val) {}` now throws a warning, since `null_val` is a constant. I would expect this warning to be okay in that scenario? https://github.com/llvm/llvm-project/pull/79588 _

[clang] [libc++] Add builtin to clear padding bytes (prework for P0528R3) (PR #75371)

2024-01-26 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Also, please fix the title so it isn't prefixed with "[libc++]"; the intent is for this to be used in libc++, but it's proposing a clang intrinsic. https://github.com/llvm/llvm-project/pull/75371 ___ cfe-commits mailing list cfe-c

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-26 Thread Akira Hatanaka via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[llvm] [clang] [clang-tools-extra] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Shourya Goel via cfe-commits
https://github.com/Sh0g0-1758 updated https://github.com/llvm/llvm-project/pull/78338 >From b98f02d4c155b5be9bd4f5b2e4bf73720a81f39a Mon Sep 17 00:00:00 2001 From: Sh0g0-1758 Date: Wed, 17 Jan 2024 01:24:17 +0530 Subject: [PATCH 01/15] Fix : more detailed no expected directive message --- cla

[clang-tools-extra] silence clang-tidy warning (llvm-qualified-auto) (PR #79617)

2024-01-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/79617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6c74d80 - [clangd] fix clang-tidy warning (llvm-qualified-auto) (#79617)

2024-01-26 Thread via cfe-commits
Author: Nour1248 Date: 2024-01-26T14:21:07-05:00 New Revision: 6c74d8083bd97ff47cadb43cdf03da35f450389a URL: https://github.com/llvm/llvm-project/commit/6c74d8083bd97ff47cadb43cdf03da35f450389a DIFF: https://github.com/llvm/llvm-project/commit/6c74d8083bd97ff47cadb43cdf03da35f450389a.diff LOG:

[clang-tools-extra] silence clang-tidy warning (llvm-qualified-auto) (PR #79617)

2024-01-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/79617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 5014d98b1893225ebdcc1e9ce0941b348f504740 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets Ad

[clang] 2a06850 - [-Wcompletion-handler] Fix a non-termination issue (#78380)

2024-01-26 Thread via cfe-commits
Author: Ziqing Luo Date: 2024-01-26T11:23:15-08:00 New Revision: 2a068507016e476893b6b1b9c55b255dbae5829e URL: https://github.com/llvm/llvm-project/commit/2a068507016e476893b6b1b9c55b255dbae5829e DIFF: https://github.com/llvm/llvm-project/commit/2a068507016e476893b6b1b9c55b255dbae5829e.diff LO

[clang] [-Wcompletion-handler] Fix a non-termination issue (PR #78380)

2024-01-26 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/78380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread Vitaly Buka via cfe-commits
@@ -13288,9 +13288,23 @@ EvaluateComparisonBinaryOperator(EvalInfo &Info, const BinaryOperator *E, // Reject differing bases from the normal codepath; we special-case // comparisons to null. if (!HasSameBase(LHSValue, RHSValue)) { - auto DiagComparison = [&] (

[clang-tools-extra] [libcxx] [clang] [lld] [lldb] [llvm] [mlir] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH] Add elementwise criteria to match.structured.body --- .../Linalg/Transf

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

2024-01-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread via cfe-commits
@@ -13288,9 +13288,23 @@ EvaluateComparisonBinaryOperator(EvalInfo &Info, const BinaryOperator *E, // Reject differing bases from the normal codepath; we special-case // comparisons to null. if (!HasSameBase(LHSValue, RHSValue)) { - auto DiagComparison = [&] (

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-26 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/79031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-26 Thread Paul Kirth via cfe-commits
ilovepi wrote: Abandoning in favor of https://github.com/llvm/llvm-project/pull/79256 https://github.com/llvm/llvm-project/pull/79031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [llvm] [clang-tools-extra] [flang] [libunwind] [lld] [lldb] [mlir] [libcxx] [compiler-rt] [clang] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-26 Thread Petr Hosek via cfe-commits
petrhosek wrote: I tried this branch on our Windows builders although I'm not sure if it's related or not to this patch: ``` # COMPILED WITH C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe C:\b\s\w\ir\x\w\github-H-G-Hristov-llvm-project\libcxx\test\libcxx\fuzzing\random.pass.cpp --driver-mode=g+

[clang] [libcxx] [flang] [lld] [libunwind] [libc] [compiler-rt] [lldb] [clang-tools-extra] [llvm] [mlir] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-26 Thread Hristo Hristov via cfe-commits
Zingam wrote: @petrhosek It is not related. It was supposedly fixed by this: https://github.com/llvm/llvm-project/pull/79619 I've been observing the chromium Windows CI failing for a while. Let's see if the above patch fixes it. I'll rebase now this one now. https://github.com/llvm/llvm-projec

[flang] [lldb] [lld] [clang-tools-extra] [libunwind] [llvm] [mlir] [compiler-rt] [libcxx] [clang] [libc] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-26 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/79032 >From e03452fda84a5284420bba1913299b68caabb6cd Mon Sep 17 00:00:00 2001 From: Zingam Date: Mon, 22 Jan 2024 20:35:00 +0200 Subject: [PATCH 1/6] Revert "Revert "[libc++][format] P2637R3: Member `visit` (`std::basi

[flang] [lldb] [lld] [clang-tools-extra] [libunwind] [llvm] [mlir] [compiler-rt] [libcxx] [clang] [libc] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-26 Thread Hristo Hristov via cfe-commits
Zingam wrote: @petrhosek According to the log, the tests in this patch pass. Could you please try again. I'll wait a while and if there is not negative feedback I'll reland the patch. > https://logs.chromium.org/logs/fuchsia/led/phosek_google.com/62644843c966785c9dedf065a79d80df8734b4df5ff7703

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: I believe the problem is that `DiagComparison` is capturing the locals `LHSValue` and `RHSValue` the lambda is being returned, the local are not longer in lifetime but we are calling `toString` on them. Maybe there is some SSO going on here that changes wh

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/79522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread lorenzo chelini via cfe-commits
chelini wrote: Is it ready for review? Is marked as "draft". https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH] Add elementwise criteria to match.structured.body --- .../Linalg/Transf

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread via cfe-commits
https://github.com/AdvenamTacet converted_to_draft https://github.com/llvm/llvm-project/pull/79522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/2] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll edited https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[llvm] [lld] [mlir] [clang-tools-extra] [lldb] [libcxx] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
https://github.com/srcarroll ready_for_review https://github.com/llvm/llvm-project/pull/79626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lld] [mlir] [clang-tools-extra] [lldb] [libcxx] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: None (srcarroll) Changes As far as I am aware, there is no simple way to match on elementwise ops. I propose to add an `elementwise` criteria to the `match.structured.body` op. Although my only hesitation is that elementwise is not only

[flang] [clang] [mlir] [llvm] [libcxx] [lld] [libc] [libunwind] [clang-tools-extra] [compiler-rt] [lldb] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-26 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/79032 >From e03452fda84a5284420bba1913299b68caabb6cd Mon Sep 17 00:00:00 2001 From: Zingam Date: Mon, 22 Jan 2024 20:35:00 +0200 Subject: [PATCH 1/6] Revert "Revert "[libc++][format] P2637R3: Member `visit` (`std::basi

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-01-26 Thread via cfe-commits
AdvenamTacet wrote: > I think we need to understand the problem better. Agree as well, I changed PR to WIP. But I don't really know where to look now. > I think popping into a debugger would likely help here. @shafik What is the correct way of building a single test, so we have access to a

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-26 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/79371 From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Wed, 24 Jan 2024 21:21:26 +0100 Subject: [PATCH 01/16] [Sema]Substitue template parameter packs when deduced from fu

[libcxx] [mlir] [clang] [libcxxabi] [lld] [clang-tools-extra] [libc] [llvm] [flang] [lldb] [compiler-rt] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

2024-01-26 Thread Kai Sasaki via cfe-commits
https://github.com/Lewuathe updated https://github.com/llvm/llvm-project/pull/76316 >From a5810363e546da073543cb2d62cceb956c46b2e6 Mon Sep 17 00:00:00 2001 From: Kai Sasaki Date: Fri, 15 Dec 2023 15:53:54 +0900 Subject: [PATCH 1/2] [mlir][complex] Prevent underflow in complex.abs --- .../Comp

[clang-tools-extra] [lldb] [openmp] [compiler-rt] [libclc] [flang] [mlir] [llvm] [libc] [libcxx] [lld] [clang] [libc++][memory] P1132R8: `out_ptr` - a scalable output pointer abstraction (PR #73618)

2024-01-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/73618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix outline member function template with default align crash (PR #78400)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/78400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix outline member function template with default align crash (PR #78400)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: nitpick https://github.com/llvm/llvm-project/pull/78400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix outline member function template with default align crash (PR #78400)

2024-01-26 Thread Shafik Yaghmour via cfe-commits
@@ -3061,11 +3062,19 @@ bool Sema::SubstDefaultArgument( /*ForDefinition*/ false); if (addInstantiatedParametersToScope(FD, PatternFD, *LIS, TemplateArgs)) return true; + if (FD->isOutOfLine()) { +TemplateArgumentList *CurrentTemplateArgumen

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/79660 Summary: Currently, the AMDGPU toolchain accepts not passing `-mcpu` as a means to create a sort of "generic" IR. The resulting IR will not contain any target dependent attributes and can then be inserted into ano

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Joseph Huber (jhuber6) Changes Summary: Currently, the AMDGPU toolchain accepts not passing `-mcpu` as a means to create a sort of "generic" IR. The resulting IR will not contain any target dependent attributes and can then be inse

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 55c6d9103444aaf70bf680c3768c14e8649bf580 63d0328f9b17b833762ad599ee97381158958f3b --

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/79660 >From ba04b20709cbf76ef6f1490081aecc125bdafec7 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 26 Jan 2024 16:25:30 -0600 Subject: [PATCH] [AMDGPU] Do not emit arch dependent macros with unspecified cpu

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-26 Thread via cfe-commits
https://github.com/jkorous-apple approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Resolve FIXME in altivec.h (PR #78905)

2024-01-26 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/78905 >From 3a5987046ea03dc552e1dc54ca1c60c4afe984cf Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sun, 21 Jan 2024 11:52:11 -0500 Subject: [PATCH] [clang] Resolve FIXME i

[clang] [clang-tools-extra] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected direc

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; def err_verify_no_directives : Error< -"no expected direc

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-26 Thread Jessica Clarke via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; jrtc27 wrote: This looks like it needs templ

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Yaxun Liu via cfe-commits
@@ -274,30 +274,31 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions &Opts, else Builder.defineMacro("__R600__"); - if (GPUKind != llvm::AMDGPU::GK_NONE) { -StringRef CanonName = isAMDGCN(getTriple()) ? - getArchNameAMDGCN(GPUKind) : getArchNameR600

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: LGTM. AFAIK only device libs compile OpenCL code without -mcpu. I don't think it uses any of these predefined macros. https://github.com/llvm/llvm-project/pull/79660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/79660 >From ba04b20709cbf76ef6f1490081aecc125bdafec7 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 26 Jan 2024 16:25:30 -0600 Subject: [PATCH 1/2] [AMDGPU] Do not emit arch dependent macros with unspecified c

[clang] 9816863 - [-Wunsafe-buffer-usage] Add a new warning for uses of std::span two-parameter constructors (#77148)

2024-01-26 Thread via cfe-commits
Author: Ziqing Luo Date: 2024-01-26T15:43:46-08:00 New Revision: 9816863dd439cd60c96d5764c4c21ca1a7f3d8da URL: https://github.com/llvm/llvm-project/commit/9816863dd439cd60c96d5764c4c21ca1a7f3d8da DIFF: https://github.com/llvm/llvm-project/commit/9816863dd439cd60c96d5764c4c21ca1a7f3d8da.diff LO

[clang] [-Wunsafe-buffer-usage] Add a new warning for uses of std::span two-parameter constructors (PR #77148)

2024-01-26 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/77148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
https://github.com/trcrsired created https://github.com/llvm/llvm-project/pull/79667 The wasm unwind build appears to be dysfunctional, likely because the author has only supplied a customized LLVM build on request, rather than a fully functional patch. This patch fixes the build >From 39bc0

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: cqwrteur (trcrsired) Changes The wasm unwind build appears to be dysfunctional, likely because the author has only supplied a customized LLVM build on request, rather than a fully functional patch. This patch fixes the build --- Ful

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 55c6d9103444aaf70bf680c3768c14e8649bf580 39bc0171e7c07e367446dd1abdc56fd918013a9d --

[libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via cfe-commits
trcrsired wrote: i do not know whether old code should be formatted or not, because the LLVM dev said do not format old code https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

<    1   2   3   4   >