weliveindetail wrote:
@shiltian Does that fix the issue for you?
https://github.com/llvm/llvm-project/pull/78959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
5chmidti wrote:
@PiotrZSL is this a reconfirmation of your previous approval (given the changed
tests and release note), or is this an approval for everything?
Specifically
> LGTM, but i'm not 100% sure about ExprMutationAnalyzer part (if thats a right
> place).
> Leave it open for few days, so
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -124,3 +124,25 @@ int assumingConverted2(struct foo f, int arg) {
// expected-note@-2 {{Access of 'array' at negative byte offset}}
return a + b + c;
}
+
+int assumingPla
@@ -253,22 +253,22 @@ def ROCDL_mfma_f32_32x32x16_fp8_fp8 :
ROCDL_Mfma_IntrOp<"mfma.f32.32x32x16.fp8.f
//===-===//
// WMMA intrinsics
-class ROCDL_Wmma_IntrOp traits = []> :
+class ROCDL_Wmma_IntrOp overloade
@@ -253,22 +253,22 @@ def ROCDL_mfma_f32_32x32x16_fp8_fp8 :
ROCDL_Mfma_IntrOp<"mfma.f32.32x32x16.fp8.f
//===-===//
// WMMA intrinsics
-class ROCDL_Wmma_IntrOp traits = []> :
+class ROCDL_Wmma_IntrOp overloade
banach-space wrote:
> @banach-space I tentatively support this. But I am concerned that disallowing
> `-lFortran_main` and renaming the library will break some existing (badly
> configured) builds (this is not just theoretical - see my comments above).
> Maybe we should merge a deprecation war
ostannard wrote:
Ping
https://github.com/llvm/llvm-project/pull/74460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paschalis-mpeis updated
https://github.com/llvm/llvm-project/pull/78749
>From c342eea051da7eed2ef4541e5daf445114258e1d Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis
Date: Fri, 19 Jan 2024 16:27:20 +
Subject: [PATCH 1/2] [LTO] Fix Veclib flags correctly pass to LTO flags
@@ -253,22 +253,22 @@ def ROCDL_mfma_f32_32x32x16_fp8_fp8 :
ROCDL_Mfma_IntrOp<"mfma.f32.32x32x16.fp8.f
//===-===//
// WMMA intrinsics
-class ROCDL_Wmma_IntrOp traits = []> :
+class ROCDL_Wmma_IntrOp overloade
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/78930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/syzaara updated
https://github.com/llvm/llvm-project/pull/67999
>From dced11bd242aba08158a5a0a399b2b0ea7381a69 Mon Sep 17 00:00:00 2001
From: Zaara Syeda
Date: Thu, 28 Sep 2023 15:01:56 -0400
Subject: [PATCH 1/7] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX
This patc
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/78315
>From c75c05c6e894a46797913c5bdccb240cbcc01ae9 Mon Sep 17 00:00:00 2001
From: =?UTF-8
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -318,17 +396,87 @@ static Messages getTaintMsgs(const SubRegion *Region,
const char *OffsetName) {
RegName, OffsetName)};
}
-void
https://github.com/PiotrZSL approved this pull request.
Just few style issues. For me from functional point of view this check looks
fine and even in this limited state could be delivered.
Personaly:
- I would like to see more code moved into AST matchers
- Support for if/else
- Support for cod
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,32 @@
+.. title:: clang-tidy - readability-use-std-min-max
+
+readability-use-std-min-max
+===
+
+Replaces certain conditional statements with equivalent ``std::min`` or
+``std::max`` expressions. Note: This may impact
+performance in critical co
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
w2yehia wrote:
will need instructions for how to recreate this file in the future.
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
NagyDonat wrote:
@steakhal I handled all the suggestions from the first review round (either by
updating the PR, or by replying / asking follow-up questions when the situ
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/78315
>From c75c05c6e894a46797913c5bdccb240cbcc01ae9 Mon Sep 17 00
PiotrZSL wrote:
@PiotrZSL I would say: fell free to merge it. It's not that it would break too
much. In worst case we got around ~1 month to fix it on a branch (if someone
would complain).
https://github.com/llvm/llvm-project/pull/78320
___
cfe-commi
PiotrZSL wrote:
@5chmidti I would say: fell free to merge it. It's not that it would break too
much. In worst case we got around ~1 month to fix it on a branch (if someone
would complain).
https://github.com/llvm/llvm-project/pull/78320
___
cfe-commi
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> @steakhal I handled all the suggestions from the first review round (either
> by updating the PR, or by replying / asking follo
@@ -31,3 +31,27 @@
// RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target
arm64-apple-ios8.0.0 -### 2>&1 | FileCheck
--check-prefix=CHECK-LINK-NODEFAULTLIBS %s
// CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate"
+
+
+/* Verify that the correct vector library is
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
shiltian wrote:
> @shiltian Does that fix the issue for you?
Yes, thanks!
https://github.com/llvm/llvm-project/pull/78959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/shafik commented:
Thank you for the patch.
This needs a release note and a set of test cases.
https://github.com/llvm/llvm-project/pull/78889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/78774
>From 3833b05746922726eb5a8b512a8a9f5caf7a96c5 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Fri, 19 Jan 2024 12:11:20 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/78774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pratlucas wrote:
No, V9.5-A is v9-only. The v9.4-A version was the last one to have a matching
v8.x.
https://github.com/llvm/llvm-project/pull/78994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
petrhosek wrote:
This is still broken so I'm going to revert the change.
https://github.com/llvm/llvm-project/pull/76449
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
NagyDonat wrote:
Ouch, that seems to be a nasty issue. Thanks for doing the review and I hope
that you'll be able to share it eventually :)
(If
@@ -305,6 +305,11 @@ class VOP3OpSel_gfx10 op, VOPProfile p> :
VOP3e_gfx10 {
class VOP3OpSel_gfx11_gfx12 op, VOPProfile p> : VOP3OpSel_gfx10;
+class VOP3FP8OpSel_gfx11_gfx12 op, VOPProfile p> : VOP3e_gfx10
{
+ let Inst{11} = !if(p.HasSrc0, src0_modifiers{2}, 0);
+ let Ins
https://github.com/jthackray approved this pull request.
Thanks, Lucas. I can't spot anything obviously wrong, so approved.
https://github.com/llvm/llvm-project/pull/78994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/78944
>From a72bbb3ae04c7be90af36d2cd025329d4ef2ab16 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Sun, 21 Jan 2024 22:18:48 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF
@@ -21095,6 +21095,50 @@ static SDValue foldTruncStoreOfExt(SelectionDAG &DAG,
SDNode *N) {
return SDValue();
}
+// A custom combine to lower load <3 x i8> as the more efficient sequence
+// below:
+//ldrb wX, [x0, #2]
+//ldrh wY, [x0]
+//orr wX, wY, wX, lsl #16
@@ -1462,10 +1462,12 @@ WindowsARM64TargetInfo::WindowsARM64TargetInfo(const
llvm::Triple &Triple,
}
void WindowsARM64TargetInfo::setDataLayout() {
- resetDataLayout(Triple.isOSBinFormatMachO()
- ? "e-m:o-i64:64-i128:128-n32:64-S128"
-
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/78944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
> You mean the publicness of `getResultObjectLocation()`?
Yeah, I was wondering if it would be more user friendly if something like
`State.Env.get(Expr);` would automatically recognize
that the user actually wants the result location and returned that without the
user having
https://github.com/MDevereau closed
https://github.com/llvm/llvm-project/pull/78961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inclyc approved this pull request.
LGTM because I just did similar thing in our (unfortunately, closed source)
backend. Let's wait for aarch64 code owners :) !
https://github.com/llvm/llvm-project/pull/78632
___
cfe-commits mailing
https://github.com/paschalis-mpeis converted_to_draft
https://github.com/llvm/llvm-project/pull/78432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
> No, V9.5-A is v9-only. The v9.4-A version was the last one to have a matching
> v8.x.
Cool. If you can find where we encode that mapping, it's worth adding a comment
to say explicitly that the relation stops at 9.5.
https://github.com/llvm/llvm-project/pull/78994
__
https://github.com/ilinpv approved this pull request.
https://github.com/llvm/llvm-project/pull/74358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76451
>From f3f0db64da4d341f8e4a2054f9f25c87f8eda829 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 27 Dec 2023 17:34:10 +0100
Subject: [PATCH 01/13] [clang][modules] Print library module manifest path.
This
DavidSpickett wrote:
It's already there for AArch64,
https://github.com/llvm/llvm-project/blob/312acdfae1409bee29a33f71306e3ae3e1ea7d66/llvm/include/llvm/TargetParser/AArch64TargetParser.h#L434.
Maybe ARM does it differently.
https://github.com/llvm/llvm-project/pull/78994
___
@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const
CodeGenModule &CGM,
const TargetInfo &TI = CGM.getTarget();
if (TI.getTriple().isAArch64()) {
jroelofs wrote:
@DanielKristofKiss slightly off topic: it's too bad `default` is implied, as i
https://github.com/atrosinenko updated
https://github.com/llvm/llvm-project/pull/78027
>From 304b5e7834ff071822fbd4e85eb4655d220d4e49 Mon Sep 17 00:00:00 2001
From: Anatoly Trosinenko
Date: Thu, 18 Jan 2024 19:54:04 +0300
Subject: [PATCH] [AArch64] Make Armv8.3-a extension set +pauth by default
Mirko =?utf-8?q?Brkušanin?=
Message-ID:
In-Reply-To:
@@ -305,6 +305,11 @@ class VOP3OpSel_gfx10 op, VOPProfile p> :
VOP3e_gfx10 {
class VOP3OpSel_gfx11_gfx12 op, VOPProfile p> : VOP3OpSel_gfx10;
+class VOP3FP8OpSel_gfx11_gfx12 op, VOPProfile p> : VOP3e_gfx10
{
+ let Ins
https://github.com/michaelmaitland created
https://github.com/llvm/llvm-project/pull/79015
This is an OOO core that has a vector unit. For more information see
https://www.sifive.com/cores/performance-p650-670.
Scheduler model and other tuning will come in separate patches.
>From abaf154799d8
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Michael Maitland (michaelmaitland)
Changes
This is an OOO core that has a vector unit. For more information see
https://www.sifive.com/cores/performance-p650-670.
Scheduler model and other tuning will come in separate patches.
-
@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const
CodeGenModule &CGM,
const TargetInfo &TI = CGM.getTarget();
if (TI.getTriple().isAArch64()) {
ilinpv wrote:
@jroelofs currently in [FMV
spec](https://github.com/ARM-software/acle/blob/mai
@@ -237,6 +237,43 @@ def SIFIVE_P450 : RISCVProcessorModel<"sifive-p450",
SiFiveP400Model,
TuneLUIADDIFusion,
TuneAUIPCADDIFusion]>;
+def SIFIVE_P670 : RISCVProcessorModel<"sifive-p670", NoSchedMode
minglotus-6 wrote:
> I'm missing the full context behind this patch, but code seems reasonable
Thanks for the review! This patch is supposed to be self-contained as a fix,
although it's spotted when I worked on relevant larger efforts ([type
profiling](https://discourse.llvm.org/t/rfc-dynamic
@@ -2000,6 +2000,14 @@ bool RISCVTargetLowering::shouldSinkOperands(
if (!I->getType()->isVectorTy() || !Subtarget.hasVInstructions())
return false;
+ // Don't sink splat operands if the target prefers it. Some targets requires
topperc wrote:
This chan
gbaraldi wrote:
What is needed for merging this? (Do the compiler-rt/sanitizer tests run in
CI)? Apparently they used to be an issue with this change.
https://github.com/llvm/llvm-project/pull/77370
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/michaelmaitland updated
https://github.com/llvm/llvm-project/pull/79015
>From 639d404b3b8a8ca7e92160fa8512459be07e631f Mon Sep 17 00:00:00 2001
From: Michael Maitland
Date: Mon, 22 Jan 2024 07:53:55 -0800
Subject: [PATCH 1/2] [RISCV] Add sifive-p670 processor
This is an OOO
https://github.com/michaelmaitland edited
https://github.com/llvm/llvm-project/pull/79015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -237,6 +237,43 @@ def SIFIVE_P450 : RISCVProcessorModel<"sifive-p450",
SiFiveP400Model,
TuneLUIADDIFusion,
TuneAUIPCADDIFusion]>;
+def SIFIVE_P670 : RISCVProcessorModel<"sifive-p670", NoSchedMode
@@ -2000,6 +2000,14 @@ bool RISCVTargetLowering::shouldSinkOperands(
if (!I->getType()->isVectorTy() || !Subtarget.hasVInstructions())
return false;
+ // Don't sink splat operands if the target prefers it. Some targets requires
michaelmaitland wrote:
U
atrosinenko wrote:
No-change rebase to fix the merge conflict. This time shown as a single commit,
as expected. I do understand that LLVM review policy suggests to only rebase
right before "squash and merge", but there are no comments yet and the conflict
is almost as large as the patch itself
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/79016
Intended to warn users of the 19.x release not to do this.
A better solution should be found for the 20.x release. See discussion in
https://github.com/llvm/llvm-project/pull/78152.
Unfortunately there is no warni
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-flang-driver
@llvm/pr-subscribers-clang-driver
Author: Tom Eccles (tblah)
Changes
Intended to warn users of the 19.x release not to do this.
A better solution should be found for the 20.x release. See discussion in
https://gi
@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const
CodeGenModule &CGM,
const TargetInfo &TI = CGM.getTarget();
if (TI.getTriple().isAArch64()) {
jroelofs wrote:
Right, it's too bad this incompatibility is baked into the spec. Are there
ot
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/74358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,14 @@
+# REQUIRES: x86
+# RUN: mkdir -p %t
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s
-o %t/hello.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o
+# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out
---
mjklemm wrote:
I'm OK with landing this for Linux only at this point.
https://github.com/llvm/llvm-project/pull/79016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mjklemm approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/79016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mbrkusanin wrote:
If there are no further comments, should I merge this?
https://github.com/llvm/llvm-project/pull/77795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kkwli approved this pull request.
LG. Thanks
https://github.com/llvm/llvm-project/pull/79016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/quic-asaravan created
https://github.com/llvm/llvm-project/pull/79021
This patch inlines float division function calls for hexagon.
>From e8beb77010becb9a9c82d875597bdedbfed9be9e Mon Sep 17 00:00:00 2001
From: Awanish Pandey
Date: Sun, 6 Sep 2020 14:39:57 +0530
Subject: [PAT
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
- Diags.Report(diag::err_verify_no_directives).setForc
vitalybuka wrote:
> Note that on Gentoo, this isn't right either, we have e.g.:
>
> ```
> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/new_allocator.h
> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/ext/new_allocator.h
> ```
I guess it's fine to expand the FrameIsInternal to c
w2yehia wrote:
@qiongsiwu explained to me offline that the issue on Windows is that calls
__llvm_orderfile_dump fail so he's not able to execute the instrumented program
if it calls that function.
Regarding the `compiler-rt/test/profile/instrprof-api.c` test. The disadvantage
of having a profd
bhamiltoncx wrote:
Seems like this regressed `clang-format - -dump_config < path/to/objc_file.m`.
I filed https://github.com/llvm/llvm-project/issues/79023.
https://github.com/llvm/llvm-project/pull/74794
___
cfe-commits mailing list
cfe-commits@list
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/78903
>From 2622ca430d7edb1c49cda9bbbf6145b60e2e37c4 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 03:50:14 +
Subject: [PATCH] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in
c99
@@ -2263,15 +2263,27 @@ class UnsafeBufferUsageReporter : public
UnsafeBufferUsageHandler {
MsgParam = 3;
} else if (const auto *ECE = dyn_cast(Operation)) {
QualType destType = ECE->getType();
-const uint64_t dSize =
-Ctx.getTypeSize(
https://github.com/rjmccall requested changes to this pull request.
I'm sorry for failing to notice this in my previous review, but I don't think
this patch is right. A global initializer should be FP-constrained based on
whether the variable is defined in an FP-constrained context. This is t
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/79026
OpenCL 1.2 kernel assumes uniform workgroup size. By default a function attr is
added to allow backend to do optimizations. These optimizations may cause UB if
such kernels are launched with non-uniform workgro
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
OpenCL 1.2 kernel assumes uniform workgroup size. By default a function attr is
added to allow backend to do optimizations. These optimizations may cause UB if
such ker
https://github.com/Artem-B commented:
It would be great to add some tests for local AS null pointers for NVPTX and
AMDGPU back-ends.
https://github.com/llvm/llvm-project/pull/78759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/malavikasamak updated
https://github.com/llvm/llvm-project/pull/78815
>From 6334cd361f79fc79f32b8ca95c6f31a083704332 Mon Sep 17 00:00:00 2001
From: MalavikaSamak
Date: Fri, 19 Jan 2024 15:16:12 -0800
Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Fix the crash introduced by the
@@ -544,28 +544,23 @@ static void PrintVersion(raw_ostream &OS) {
}
// Dump the configuration.
-static int dumpConfig() {
- StringRef FileName;
+static int dumpConfig(bool IsSTDIN) {
std::unique_ptr Code;
- if (FileNames.empty()) {
-// We can't read the code to detect
topperc wrote:
Need to update docs/ReleaseNotes.rst
https://github.com/llvm/llvm-project/pull/79015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc created
https://github.com/llvm/llvm-project/pull/79030
None
>From a3f43ca1e5bc1ab4fd9c41f86d1904a54242a281 Mon Sep 17 00:00:00 2001
From: Craig Topper
Date: Mon, 22 Jan 2024 10:33:39 -0800
Subject: [PATCH] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Craig Topper (topperc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/79030.diff
2 Files Affected:
- (modified) clang/test/Driver/riscv-cpus.c (+6)
- (modified) llvm/lib/Target/RISCV/RISCVProcessors.td (+6)
``
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Craig Topper (topperc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/79030.diff
2 Files Affected:
- (modified) clang/test/Driver/riscv-cpus.c (+6)
- (modified) llvm/lib/Target/RISCV/RISCVProcessors.td (+6)
https://github.com/minglotus-6 closed
https://github.com/llvm/llvm-project/pull/78610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-use-std-min-max
+
+readability-use-std-min-max
+===
+
+Replaces certain conditional statements with equivalent ``std::min`` or
+``std::max`` expressions. Note: This may impact
PiotrZSL w
301 - 400 of 673 matches
Mail list logo
