qiongsiwu wrote:
> thanks! Mostly lg with a pending discussion on whether we want to have test
> coverage for `clang_pgogen` in `compiler-rt/test/profile/instrprof-api.c`,
> and the open-ended discussion about the observed build failure in another
> compiler-rt test.
Thanks for the feedback!
https://github.com/minglotus-6 edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// Test the linker feature that treats undefined weak symbols as null values.
+
+// RUN: %clang_pgogen -o %t %s
minglotus-6 wrote:
This just occurred to me, if the tested feature relies on linker
implementation, does it need `REQUIRES: ` so tha
https://github.com/minglotus-6 commented:
thanks for making the changes!
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,38 @@
+// RUN: %clang_profgen %s --target=ppc64le-unknown-linux-gnu -S \
+// RUN:-emit-llvm -o - | FileCheck %s --check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
minglotus-6 wrote:
> I don't h
https://github.com/minglotus-6 edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// Test the linker feature that treats undefined weak symbols as null values.
+
+// RUN: %clang_pgogen -o %t %s
minglotus-6 wrote:
Please discard this comment.
@snehasish pointed out build-bots doesn't really have coverage of AIX linker,
and
https://github.com/minglotus-6 edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -81,6 +81,15 @@ static bool DecodeAArch64Features(const Driver &D, StringRef
text,
else
return false;
+// +jsconv and +complxnum implies +neon and +fp-armv8
Qi-Hu wrote:
I have made some changes and included AEK_JSCVT and AEK_FCMA in Armv8.3
minglotus-6 wrote:
> > thanks! Mostly lg with a pending discussion on whether we want to have test
> > coverage for `clang_pgogen` in `compiler-rt/test/profile/instrprof-api.c`,
> > and the open-ended discussion about the observed build failure in another
> > compiler-rt test.
>
> Thanks for
ajordanr-google wrote:
All CI runs are failing on unrelated tests... can we re-run the CI again in a
week or so?
https://github.com/llvm/llvm-project/pull/74791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/malavikasamak edited
https://github.com/llvm/llvm-project/pull/75650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Malavika Samak
Date: 2024-01-02T15:41:00-08:00
New Revision: 7122f55c639a00e719b6088249f4fca1810cf04c
URL:
https://github.com/llvm/llvm-project/commit/7122f55c639a00e719b6088249f4fca1810cf04c
DIFF:
https://github.com/llvm/llvm-project/commit/7122f55c639a00e719b6088249f4fca1810cf04c.diff
https://github.com/malavikasamak closed
https://github.com/llvm/llvm-project/pull/75650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Qi-Hu updated https://github.com/llvm/llvm-project/pull/75516
>From c7334de4f54ebd7755827c35a09c8a63743027ec Mon Sep 17 00:00:00 2001
From: Qi Hu
Date: Thu, 14 Dec 2023 13:35:52 -0500
Subject: [PATCH] [TargetParser] Define AEK_FCMA and AEK_JSCVT for tsv110
We define AEK_JSCVT
@@ -0,0 +1,16 @@
+// Test the linker feature that treats undefined weak symbols as null values.
+
+// RUN: %clang_pgogen -o %t %s
qiongsiwu wrote:
Ah no worries! I actually tried running this on AIX and the test is
unsupported. I think compiler-rt
[checks](http
@@ -0,0 +1,38 @@
+// RUN: %clang_profgen %s --target=ppc64le-unknown-linux-gnu -S \
+// RUN:-emit-llvm -o - | FileCheck %s --check-prefix=PROFGEN
+// RUN: %clang_profgen -o %t %s
+// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t
qiongsiwu wrote:
Ah thanks for
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/76471
>From 6c9381ec324595947237bd25642b03ab40b6a4df Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Wed, 27 Dec 2023 13:05:01 -0500
Subject: [PATCH 01/12] Initial commit
---
.../ExpandModularHeadersPPCallbacks.cpp
phoebewang wrote:
> I also think we need a policy regarding what test coverage we need for
> various avx512 features (when should we assume avx512vl etc.)
Considering the new evolution in AVX10, we should switch testing model from
`avx512xxx ± avx512vl` to `avx512xxx + avx512vl ±
evex512`.
I
jrmwng wrote:
492>Failed Tests (1):
492> Clang :: Lexer/case-insensitive-include-absolute.c
I built with "clang", "X86" and "AArch64" under Windows 11 and VS2022 community
edition
```
492>-- Build started: Project: check-all, Configuration: Release x64 --
492>Running all regression te
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From ab1ace9573588153f1e8caf992a6abda3322c6a7 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
StructuralEquivalen
https://github.com/minglotus-6 edited
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jansvoboda11 wrote:
Thanks for reporting @jrmwng, I'll look into it.
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
avillega wrote:
I think this change might be breaking some of our builds, please revert if
possible.
This is the error I am getting:
```
TEST 'Polly :: ScheduleOptimizer/schedule_computeout.ll'
FAILED
Exit Code: 1
Command Output (stderr):
--
RUN: at l
ChuanqiXu9 wrote:
@dwblaikie @rjmccall ping~
https://github.com/llvm/llvm-project/pull/75912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
@iains @dwblaikie ping~
https://github.com/llvm/llvm-project/pull/75894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lifengxiang1025 wrote:
> Thanks for looking into this. I didn't know you're still working on it. I
> have a complete PR (including changes to llvm-objdump, llvm-readobj, etc.)
> ready here : https://github.com/rlavaee/llvm-project/tree/bb-addr-map
@rlavaee It's ok. This PR doesn't take me lon
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
jcsxky wrote:
Done.
https://github.com/llvm/llvm-project/pull/
efriedma-quic wrote:
Pushed revert.
@kartcq please fix the test so it either doesn't depend on DEBUG output, or
uses `REQUIRES: asserts`.
https://github.com/llvm/llvm-project/pull/75141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/76774
The idea comes from @vgvassilev and @vgvassilev had patch for it on phab.
Unfortunately phab is closed and I forgot the Dxxx number of that patch. But I
remember the last comment from @vgvassilev is that we s
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Chuanqi Xu (ChuanqiXu9)
Changes
The idea comes from @vgvassilev and @vgvassilev had patch for
it on phab. Unfortunately phab is closed and I forgot the Dxxx number of that
patch. But I remember the last comment from @vgvassilev is
https://github.com/benshi001 created
https://github.com/llvm/llvm-project/pull/76776
None
>From 8a7caba467e121290d36ad75626ea95ea47b41f2 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 3 Jan 2024 11:30:57 +0800
Subject: [PATCH] [clang][analyzer] Support 'fdopen' in the StreamChecker
---
cl
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Ben Shi (benshi001)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/76776.diff
8 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+1-1)
- (modified) clang/lib/Stat
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/76776
>From 19122ac9df0e621ffb25fcb64bfad2336476b94b Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Wed, 3 Jan 2024 11:30:57 +0800
Subject: [PATCH] [clang][analyzer] Support 'fdopen' in the StreamChecker
---
clang/do
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/76774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/76774
>From af6f8ca9b739c532a489881245fac1413ec84a07 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 3 Jan 2024 11:33:17 +0800
Subject: [PATCH] Load Specializations Lazily
---
clang/include/clang/AST/DeclTemp
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7a3b0cbb143d02b70b2bfae5cd40e9867c124748
af6f8ca9b739c532a489881245fac1413ec84a07 --
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/76774
>From 79cefc9f0f006acd788b6ac4e240c17d9deadf13 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 3 Jan 2024 11:33:17 +0800
Subject: [PATCH] Load Specializations Lazily
---
clang/include/clang/AST/DeclTemp
WenleiHe wrote:
We will need some protection against accidentally consuming old profile with
new toolchain and vice versa. The cost of investigating mysterious perf
regression can be high and we'd rather simply error out in those cases. Maybe
consider some flag for `SecProfSummaryFlags` (also
https://github.com/tdupes edited https://github.com/llvm/llvm-project/pull/71605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/daltairwalter updated
https://github.com/llvm/llvm-project/pull/70621
>From f44d7746a990a3bd8e53de047a30baee4da2c790 Mon Sep 17 00:00:00 2001
From: Daniel Walter
Date: Mon, 30 Oct 2023 00:08:56 -0500
Subject: [PATCH 1/5] Initial commit of add new check before changes
---
..
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Wang Pengcheng (wangpc-pp)
Changes
This commit includes the necessary changes to clang and LLVM to support
codegen of `RVE` and the `ilp32e`/`lp64e` ABIs.
The differences between `RVE` and `RVI` are:
* `RVE` reduces the integer register co
@@ -1273,6 +1293,22 @@ public:
__impl_.__swap(__that.__impl_);
}
+# if _LIBCPP_STD_VER >= 26
+ // [variant.visit], visitation
+
+ template
frederick-vs-ja wrote:
Would it be better to use a special tag type like this
```C++
struct __variant_visit_ba
https://github.com/frederick-vs-ja edited
https://github.com/llvm/llvm-project/pull/76447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
topperc wrote:
What was the last bit of discussion on the phabricator review? I can no longer
access it.
https://github.com/llvm/llvm-project/pull/76777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/rikhuijzer updated
https://github.com/llvm/llvm-project/pull/76292
>From 0ff5a0ec09f7c26824bd90e6c7656222ee2448ae Mon Sep 17 00:00:00 2001
From: Rik Huijzer
Date: Sat, 23 Dec 2023 16:32:27 +0100
Subject: [PATCH 1/3] [mlir][vector] Fix invalid `LoadOp` indices being created
-
@@ -897,7 +921,8 @@ struct TransferOpConversion : public
VectorToSCFPattern {
} else {
// It's safe to assume the mask buffer can be unpacked if the data
// buffer was unpacked.
-auto castedMaskType = *unpackOneDim(maskBufferType);
+auto m
@@ -0,0 +1,221 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -target-abi lp64e -verify-machineinstrs < %s \
+; RUN: | FileCheck -check-prefix=RV64I-LP64E-FPELIM %s
+; RUN: llc -mtriple=riscv64 -target-abi lp64e -ve
@@ -499,7 +514,8 @@ void RISCVFrameLowering::emitPrologue(MachineFunction &MF,
if (int LibCallRegs = getLibCallID(MF, MFI.getCalleeSavedInfo()) + 1) {
// Calculate the size of the frame managed by the libcall. The libcalls are
// implemented such that the stack will a
@@ -0,0 +1,2556 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv32 -target-abi ilp32e -verify-machineinstrs < %s \
+; RUN: | FileCheck -check-prefix=ILP32E-FPELIM %s
+; RUN: llc -mtriple=riscv32 -target-abi ilp32e -fram
@@ -17134,30 +17133,64 @@ static const MCPhysReg ArgVRM4s[] = {RISCV::V8M4,
RISCV::V12M4, RISCV::V16M4,
RISCV::V20M4};
static const MCPhysReg ArgVRM8s[] = {RISCV::V8M8, RISCV::V16M8};
-ArrayRef RISCV::getArgGPRs() {
- static const MCPhysR
@@ -68,6 +68,11 @@ ABI computeTargetABI(const Triple &TT, const FeatureBitset
&FeatureBits,
TargetABI = ABI_Unknown;
}
+ if ((TargetABI == RISCVABI::ABI::ABI_ILP32E ||
+ (TargetABI == ABI_Unknown && IsRVE && !IsRV64)) &&
+ FeatureBits[RISCV::FeatureStdExtD])
@@ -285,13 +286,16 @@ StringRef riscv::getRISCVArch(const llvm::opt::ArgList
&Args,
// 3. Choose a default based on `-mabi=`
//
// ilp32e -> rv32e
+ // lp64e -> rv64e
// ilp32 | ilp32f | ilp32d -> rv32imafdc
// lp64 | lp64f | lp64d -> rv64imafdc
if (const Arg *
@@ -109,6 +115,11 @@ BitVector RISCVRegisterInfo::getReservedRegs(const
MachineFunction &MF) const {
// beginning with 'x0' for instructions that take register pairs.
markSuperRegs(Reserved, RISCV::DUMMY_REG_PAIR_WITH_X0);
+ // There are only 16 GPRs for RVE.
+ if (STI.
kadircet wrote:
hi @owenca looks like this is still regressing certain patterns, e.g:
```cpp
int foo BAR;
```
annotations before your modifications to `isStartOfName`:
```
AnnotatedTokens(L=0):
M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=int L=3 PPK=2 FakeLParens=
FakeRParens=0 II=0x216ebe0 T
FreddyLeaf wrote:
Keeping `-march` supports for knl/knm meanwhile removing the specific ISA's
intrinsic supports doesn't sound quite good to me. And thanks @phoebewang
mentioned, removing the KNL/KNM supports could make all other targets always
support AVX512F and AVX512VL meanwhile. This can
kadircet wrote:
@s1Sharp are there any conclusions here? our code also incidentally relied on
having new lines between string literals, mostly for the sake of having a line
break after string literals that end with `\n`.
what do people think about restoring the functionality to break after str
https://github.com/yuanfang-chen updated
https://github.com/llvm/llvm-project/pull/72607
>From 471f87e727d71e3984d533eeb9db9ebab40e63ff Mon Sep 17 00:00:00 2001
From: Yuanfang Chen
Date: Fri, 17 Nov 2023 03:16:38 +
Subject: [PATCH] [clang][ExprConst] allow single element access of vector
o
201 - 258 of 258 matches
Mail list logo