[clang] [RISCV][NFC] Use AddTargetFeature to add fast-unaligned-access (PR #74280)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Wang Pengcheng (wangpc-pp) Changes We can reduce some code. --- Full diff: https://github.com/llvm/llvm-project/pull/74280.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Arch/RISCV.cpp (+2-7) ``diff

[clang] [clang][CGOpenMPRuntimeGPU] Merge consecutive AddrSpaceCasts (NFC) (PR #74279)

2023-12-03 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/74279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
xiangzh1 wrote: > We should add TTI check for the condition. I believe don't unroll on X86 is a > correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy > stack cost need this. > > And I think you need to precommit tests first. In fact, there is no direct/strong relation wit

[clang] [clang-format] Fix a bug in `git-clang-format --binary` (PR #74176)

2023-12-03 Thread Youngsuk Kim via cfe-commits
JOE1994 wrote: I've been using `git clang-format` without the `--bin` flag using the following setting 1. `PATH=$PATH:~/llvm-project/build/bin:~/llvm-project/clang/tools/clang-format` 2. Run `git clang-format HEAD~1` at `~/llvm-project` directory After this revision, I get the following error:

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert updated https://github.com/llvm/llvm-project/pull/74199 >From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001 From: Shengchen Kan Date: Sat, 2 Dec 2023 23:52:53 +0800 Subject: [PATCH 1/3] [X86] Support CFE flags for APX features Positive options:

[llvm] [mlir] [clang-tools-extra] [clang] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Kai Sasaki via cfe-commits
@@ -139,12 +139,36 @@ SmallVector getValuesSortedByKey(ArrayRef keys, ArrayRef values, llvm::function_ref compare); +/// Helper function to check whether the passed in `sizes` or `values` are Lewuathe wrote: ```suggestion /// Helper funct

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Kai Sasaki via cfe-commits
https://github.com/Lewuathe edited https://github.com/llvm/llvm-project/pull/74200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [mlir] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Kai Sasaki via cfe-commits
@@ -139,12 +139,36 @@ SmallVector getValuesSortedByKey(ArrayRef keys, ArrayRef values, llvm::function_ref compare); +/// Helper function to check whether the passed in `sizes` or `values` are +/// valid. This can be used to re-check whether dimensions are

[clang-tools-extra] [mlir] [clang] [llvm] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Kai Sasaki via cfe-commits
https://github.com/Lewuathe commented: Is it possible to add the test case (or minimal similar example) with `--inline` option so that we can confirm the original issue is resolved. https://github.com/llvm/llvm-project/issues/73383 https://github.com/llvm/llvm-project/pull/74200 __

[clang] [llvm] [SimplifyCFG] Not folding branch in loop header with constant iterations (PR #74268)

2023-12-03 Thread via cfe-commits
bcl5980 wrote: > > We should add TTI check for the condition. I believe don't unroll on X86 is > > a correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy > > stack cost need this. > > And I think you need to precommit tests first. > > In fact, there is no direct/strong rela

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-12-03 Thread Vikram Hegde via cfe-commits
vikramRH wrote: > Is there a separate PR open for "Add vector processing support to AMDGPU > printf"? I think it's easiest to move this part forward first @arsenm , you are right. I just want to make sure we are good on runtime changes too now since there seems to be a blocker. The changes her

[llvm] [clang] [RISCV] Update the interface of sifive vqmaccqoq (PR #74284)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brandon Wu (4vtomat) Changes The spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf) is updated. --- Patch is 121.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/

[clang] [llvm] [RISCV] Update the interface of sifive vqmaccqoq (PR #74284)

2023-12-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes The spec(https://sifive.cdn.prismic.io/sifive/60d5a660-3af0-49a3-a904-d2bbb1a21517_int8-matmul-spec.pdf) is updated. --- Patch is 121.79 KiB, truncated to 20.00 KiB below, full version: https://gi

[clang] [clang-format] Remove duplicates in @property using std::set (PR #74235)

2023-12-03 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/74235 >From 7323d9261fe8c876fe3a656a98e186af3dd0b2a0 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 3 Dec 2023 01:41:57 -0800 Subject: [PATCH 1/2] [clang-format] Remove duplicates in @property using std::set Re-im

[clang-tools-extra] [mlir] [llvm] [clang] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74200 >From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 20 Nov 2023 09:02:41 +0100 Subject: [PATCH 1/6] [mlir][tensor] Fix canon via `hasNegativeDimension` --- ml

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

2023-12-03 Thread Sander de Smalen via cfe-commits
@@ -298,3 +298,11 @@ multiclass ZAAddSub { defm SVADD : ZAAddSub<"add">; defm SVSUB : ZAAddSub<"sub">; + +// +// Spill and fill of ZT0 +// +let TargetGuard = "sme2" in { + def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt", [IsOverloadNone, IsStreamin

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Phoebe Wang via cfe-commits
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">, Group, HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; def mno_scatter : Flag<["-"], "mno-scatter">, Group, HelpText<"Disable generatio

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Phoebe Wang via cfe-commits
@@ -927,6 +939,16 @@ void X86TargetInfo::getTargetDefines(const LangOptions &Opts, Builder.defineMacro("__USERMSR__"); if (HasCRC32) Builder.defineMacro("__CRC32__"); + if (HasEGPR) +Builder.defineMacro("__EGPR__"); + if (HasPush2Pop2) +Builder.defineMacro(

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert edited https://github.com/llvm/llvm-project/pull/74199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">, Group, HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; def mno_scatter : Flag<["-"], "mno-scatter">, Group, HelpText<"Disable generatio

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Phoebe Wang via cfe-commits
@@ -422,3 +422,28 @@ // RUN: touch %t.o // RUN: %clang -fdriver-only -Werror --target=x86_64-pc-linux-gnu -mharden-sls=all %t.o -o /dev/null 2>&1 | count 0 +// RUN: %clang -target x86_64-unknown-linux-gnu -mapxf %s -### -o %t.o 2>&1 | FileCheck -check-prefix=APXF %s +// RUN:

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Phoebe Wang via cfe-commits
@@ -422,3 +422,28 @@ // RUN: touch %t.o // RUN: %clang -fdriver-only -Werror --target=x86_64-pc-linux-gnu -mharden-sls=all %t.o -o /dev/null 2>&1 | count 0 +// RUN: %clang -target x86_64-unknown-linux-gnu -mapxf %s -### -o %t.o 2>&1 | FileCheck -check-prefix=APXF %s

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert updated https://github.com/llvm/llvm-project/pull/74199 >From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001 From: Shengchen Kan Date: Sat, 2 Dec 2023 23:52:53 +0800 Subject: [PATCH 1/4] [X86] Support CFE flags for APX features Positive options:

[libcxx] [clang] [llvm] [mlir] [compiler-rt] [flang] [clang-tools-extra] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/74200 >From 22928e7e5da508d8d9dc8d4b7e54f84cccadef06 Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Mon, 20 Nov 2023 09:02:41 +0100 Subject: [PATCH 1/7] [mlir][tensor] Fix canon via `hasNegativeDimension` --- ml

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Phoebe Wang via cfe-commits
@@ -5999,6 +5999,12 @@ def mno_gather : Flag<["-"], "mno-gather">, Group, HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; def mno_scatter : Flag<["-"], "mno-scatter">, Group, HelpText<"Disable generatio

[libcxx] [clang] [llvm] [mlir] [compiler-rt] [flang] [clang-tools-extra] [mlir] Fix a zero stride canonicalizer crash (PR #74200)

2023-12-03 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > Is it possible to add the test case (or minimal similar example) with > `--inline` option so that we can confirm the original issue is resolved. > > #73383 Thanks for the review and fixing the typos that I've made! I've added a test in a new `MemRef/inlining.mlir` file, wh

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
@@ -927,6 +939,16 @@ void X86TargetInfo::getTargetDefines(const LangOptions &Opts, Builder.defineMacro("__USERMSR__"); if (HasCRC32) Builder.defineMacro("__CRC32__"); + if (HasEGPR) +Builder.defineMacro("__EGPR__"); + if (HasPush2Pop2) +Builder.defineMacro(

[llvm] [clang] [X86] Support CFE flags for APX features (PR #74199)

2023-12-03 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert updated https://github.com/llvm/llvm-project/pull/74199 >From 246d6e2bc3f6fb60623b5d4c3f07b53c628ed88a Mon Sep 17 00:00:00 2001 From: Shengchen Kan Date: Sat, 2 Dec 2023 23:52:53 +0800 Subject: [PATCH 1/5] [X86] Support CFE flags for APX features Positive options:

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-12-03 Thread via cfe-commits
@@ -367,3 +394,14 @@ clang::dataflow::FieldSet clang::dataflow::getObjectFields(QualType Type) { getFieldsFromClassHierarchy(Type, Fields); return Fields; } + +bool clang::dataflow::containsSameFields( +const clang::dataflow::FieldSet &Fields, +const clang::dataflo

<    1   2