[llvm] [clang] Revert HWASAN failure (#74163) (PR #74180)

2023-12-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 28eead018d80a5384b8be6f259c3d2e2b849e8cf ef876c72f3d828055ce58d0f22ec40c7468bc6c1 --

[clang] b6d0ee0 - Revert HWASAN failure (#74163)

2023-12-01 Thread Kirill Stoimenov via cfe-commits
Author: Kirill Stoimenov Date: 2023-12-02T04:39:14Z New Revision: b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b URL: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b DIFF: https://github.com/llvm/llvm-project/commit/b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b.diff L

[llvm] [clang] Revert HWASAN failure (#74163) (PR #74180)

2023-12-01 Thread Kirill Stoimenov via cfe-commits
https://github.com/kstoimenov closed https://github.com/llvm/llvm-project/pull/74180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Revert HWASAN failure (#74163) (PR #74180)

2023-12-01 Thread Kirill Stoimenov via cfe-commits
kstoimenov wrote: I pushed it manually: b6d0ee056d247e1ecfd4ecd3f97fb2d31740d79b. https://github.com/llvm/llvm-project/pull/74180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][LTO] Copy fix empty stats filename to AMDGPU, HIPAMD, MinGW (PR #74178)

2023-12-01 Thread Fangrui Song via cfe-commits
MaskRay wrote: At this point, it does seem that changing `addLTOOption` to accept `Inputs` instead of `Input` will eliminate duplication and ensure consistency among targets. https://github.com/llvm/llvm-project/pull/74178 ___ cfe-commits mailing lis

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-12-01 Thread Tom Ritter via cfe-commits
tomrittervg wrote: This sounds crazy, but I think I found a bug in this patchset. I applied it on top of the 17.0.2 tag, and then ran the whole analysis on mozilla-central. I got segfaults on about 4000 executions, all with the same stack trace: ``` 1. parser at end of file 2. Whi

[clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-01 Thread Kees Cook via cfe-commits
kees wrote: > ``` > int foo(struct s *p, int index) { > return __builtin_dynamic_object_size((++p)->array[index], 1); > } > ``` > > This _shouldn't_ increment `p`, but we need to get the array size of the > element _after_ `p`. I suspect that this is probably a horrible security > violation

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

2023-12-01 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/74025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2023-12-01 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can you add a little more details in the description on the root cause of the bug? https://github.com/llvm/llvm-project/pull/74110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/73214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,8 @@ +// UNSUPPORTED: system-windows +// MaskRay wrote: Drop `^//$` lines. The conventional style doesn't add these markers for otherwise blank lines. Without them, we can navigate among the tests using vim-style `{` `}` . https://github.com/llvm/ll

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,8 @@ +// UNSUPPORTED: system-windows +// +// RUN: %clang --target=x86_64-redhat-linux-gnu \ +// RUN: --sysroot=%S/Inputs/fedora_39_tree --gcc-triple=x86_64-redhat-linux -v 2>&1 | \ MaskRay wrote: Indent continuation lines. https://github.com/llvm/llv

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,8 @@ +// UNSUPPORTED: system-windows +// +// RUN: %clang --target=x86_64-redhat-linux-gnu \ +// RUN: --sysroot=%S/Inputs/fedora_39_tree --gcc-triple=x86_64-redhat-linux -v 2>&1 | \ +// RUN: FileCheck %s +// MaskRay wrote: Add another test when `--gcc-

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/73214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix import of variable template redeclarations. (PR #72841)

2023-12-01 Thread Shafik Yaghmour via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: @@ -5050,6 +5050,59 @@ TEST_P(ImportFriendClasses, RecordVarTemplateDecl) { EXPECT_EQ(ToTUX, ToX); } +TEST_P(ASTImporterOptionSpecificTestBase, VarTemplateDeclConflict) { + getToTuDecl( + R"( + template

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/73214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add the --gcc-triple option (PR #73214)

2023-12-01 Thread Fangrui Song via cfe-commits
@@ -2130,6 +2130,15 @@ void Generic_GCC::GCCInstallationDetector::init( return; } + // If --gcc-triple is specified use this instead of trying to + // auto-detect a triple. + if (const Arg *A = + Args.getLastArg(clang::driver::options::OPT_gcc_triple_EQ)) { +

[clang] [clang] Reject incomplete type arguments for __builtin_dump_struct (PR #72749)

2023-12-01 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM you should put the bug report in the problem description so it automatically links the PR and closes it when you merge it. https://github.com/llvm/llvm-project/pull/72749 ___ cfe-commits maili

[flang] [clang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

2023-12-01 Thread Fangrui Song via cfe-commits
MaskRay wrote: Perhaps `nostdlib.c` since nostdlib encompasses nodefaultlibs/nostartfiles. However, if we need another test for a `-no*` style option that is less related to `-nostdlib`, reusing `nostdlib.c` maybe slightly strange. https://github.com/llvm/llv

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread David Li via cfe-commits
https://github.com/david-xl updated https://github.com/llvm/llvm-project/pull/73845 >From 4cf62b1b780edef9902b5ec50b56d676810c3922 Mon Sep 17 00:00:00 2001 From: David Li Date: Wed, 29 Nov 2023 11:56:31 -0800 Subject: [PATCH] Fix PGO documentation in user manual --- clang/docs/UsersManual.rst

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread Petr Hosek via cfe-commits
@@ -4401,13 +4415,21 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread Petr Hosek via cfe-commits
@@ -4401,13 +4415,21 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread Petr Hosek via cfe-commits
@@ -4401,13 +4413,18 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread David Li via cfe-commits
https://github.com/david-xl updated https://github.com/llvm/llvm-project/pull/73845 >From 29b5b28f52c88ebd862163c4feb1573460c5c79e Mon Sep 17 00:00:00 2001 From: David Li Date: Wed, 29 Nov 2023 11:56:31 -0800 Subject: [PATCH] Fix PGO documentation in user manual --- clang/docs/UsersManual.rst

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread David Li via cfe-commits
@@ -4401,13 +4415,21 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread David Li via cfe-commits
@@ -4401,13 +4415,21 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

[clang] Fix documentation on PGO/coverage related options. (PR #73845)

2023-12-01 Thread David Li via cfe-commits
@@ -4401,13 +4413,18 @@ Execute ``clang-cl /?`` to see a list of supported options: Instrument only functions from files where names don't match all the regexes separated by a semi-colon -fprofile-filter-files=

<    1   2   3   4