ldionne wrote:
I'm not familiar with your exact setup, but I think you should probably report
those warnings to Google Test and turn off deprecation warnings in your build
with `-Wno-deprecated` until you're able to update to a version of Google Test
that has fixed this issue?
https://github.
https://github.com/DominikAdamski closed
https://github.com/llvm/llvm-project/pull/72638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Dominik Adamski
Date: 2023-11-28T19:57:36+01:00
New Revision: a8ac930b99d93b2a539ada7e566993d148899144
URL:
https://github.com/llvm/llvm-project/commit/a8ac930b99d93b2a539ada7e566993d148899144
DIFF:
https://github.com/llvm/llvm-project/commit/a8ac930b99d93b2a539ada7e566993d148899144.dif
cor3ntin wrote:
@zygoloid It took me a while, but I think I got it; what do you think of
direction ? (description in the last commit message)
It appears I am doing something a bit novel, but I couldn't think of a better
way.
https://github.com/llvm/llvm-project/pull/73463
_
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/8] [Flang][Clang] Add support for frame pointers in Flang
---
clang/in
https://github.com/sandeepkosuri created
https://github.com/llvm/llvm-project/pull/73690
- Removed an unnecessary check that was preventing `nothing` to work properly
inside `metadirective`.
>From 0aad8e5ca5d7e9f2d2400e6c2f3db0a374d55ed8 Mon Sep 17 00:00:00 2001
From: Sandeep Kosuri
Date: Tue
llvmbot wrote:
@llvm/pr-subscribers-openmp
Author: Sandeep Kosuri (sandeepkosuri)
Changes
- Removed an unnecessary check that was preventing `nothing` to work properly
inside `metadirective`.
---
Full diff: https://github.com/llvm/llvm-project/pull/73690.diff
4 Files Affected:
- (modi
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/5] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
alexey-bataev wrote:
I think this error message should remain
https://github.com/llvm/llvm-project/pull/73690
___
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
sandeepkosuri wrote:
But I don't see such a restriction for `nothing` in spec 5.1, is it really
required ?
https://github.com/ll
aheejin wrote:
Hmm, yes, I thought we didn't build `libunwind.cpp` because the code next to
the part I excluded was wrapped with `#ifdef __APPLE__`:
https://github.com/llvm/llvm-project/blob/a8ac930b99d93b2a539ada7e566993d148899144/libunwind/src/libunwind.cpp#L352-L432
But yeah then we build th
https://github.com/aheejin edited
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
alexey-bataev wrote:
3 Directive and Construct Syntax
Neither a stand-alone directive nor a declarative directive may be used in
https://github.com/aheejin edited
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aheejin updated
https://github.com/llvm/llvm-project/pull/73196
>From cb110aba7df1c74e3c5f21664f9e22515a1d820f Mon Sep 17 00:00:00 2001
From: Heejin Ahn
Date: Wed, 22 Nov 2023 18:18:19 -0800
Subject: [PATCH] [libunwind][WebAssembly] Omit unused parts of libunwind.cpp
for Was
Author: Dominik Adamski
Date: 2023-11-28T13:18:46-06:00
New Revision: f00ffcdb58d6db902a8f86b0ce83a03874d113ad
URL:
https://github.com/llvm/llvm-project/commit/f00ffcdb58d6db902a8f86b0ce83a03874d113ad
DIFF:
https://github.com/llvm/llvm-project/commit/f00ffcdb58d6db902a8f86b0ce83a03874d113ad.dif
https://github.com/shafik created
https://github.com/llvm/llvm-project/pull/73691
Currently when parsing a nested requirement we attempt to balance parens if we
have a parameter list. This will fail in some cases of ill-formed code and keep
going until we fall off the token stream and crash. T
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
Changes
Currently when parsing a nested requirement we attempt to balance parens if we
have a parameter list. This will fail in some cases of ill-formed code and keep
going until we fall off the token stream and c
@@ -3639,6 +3639,10 @@ ExprResult Parser::ParseRequiresExpression() {
// TryParseParameterDeclarationClause).
shafik wrote:
I don't think the above fixme above is needed, I don't think there is any other
way to handle this, at least based on so
Logikable wrote:
I believe Clang currently does not properly propagate alignment information for
certain IR (e.g. atomicrmw and cmpxchg). Look at the definitions of
`CreateAtomic*` in Clang. The patches in
https://bugs.llvm.org/show_bug.cgi?id=27168 did not address this (thanks
@MaskRay for h
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/73694
The internals manual seems like a more obvious home for the details instead of
hiding them away in a header file and relying on doxygen output to document it
publicly.
>From 12a2c85005c32e55541bc7f9ebb5492
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
The internals manual seems like a more obvious home for the details instead of
hiding them away in a header file and relying on doxygen output to document it
publicly.
---
Full diff: https://github.co
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
sandeepkosuri wrote:
oh sorry for missing that ! So, is this supposed to produce a compilation error
(provided arch is x86_64)?
https://github.com/HazardyKnusperkeks commented:
I can not say if TextProto should be handled equally to Proto.
https://github.com/llvm/llvm-project/pull/73582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
@@ -6481,6 +6481,33 @@ void Sema::PerformPendingInstantiations(bool LocalOnly) {
PendingInstantiations.swap(delayedPCHInstantiations);
}
+// Instantiate all referenced specializations of the given function template
+// definition. This make sure that function template that
https://github.com/zygoloid edited
https://github.com/llvm/llvm-project/pull/73463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zygoloid commented:
Thanks!
https://github.com/llvm/llvm-project/pull/73463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4836,6 +4837,16 @@ ASTFileSignature ASTWriter::WriteASTCore(Sema &SemaRef,
StringRef isysroot,
assert(SemaRef.PendingLocalImplicitInstantiations.empty() &&
"There are local ones at end of translation unit!");
+ // Build a record containing all of pending insta
@@ -181,6 +181,9 @@ class ExternalSemaSource : public ExternalASTSource {
SmallVectorImpl > &Pending) {}
+ virtual void ReadPendingOfInstantiationsForConstexprEntity(
zygoloid wrote:
The "Of" here seems out of place; maybe remove it? You also
@@ -6481,6 +6481,33 @@ void Sema::PerformPendingInstantiations(bool LocalOnly) {
PendingInstantiations.swap(delayedPCHInstantiations);
}
+// Instantiate all referenced specializations of the given function template
+// definition. This make sure that function template that
@@ -8718,6 +8731,18 @@ void ASTReader::ReadPendingInstantiations(
PendingInstantiations.clear();
}
+void ASTReader::ReadPendingOfInstantiationsForConstexprEntity(
+const NamedDecl *D, llvm::SmallSetVector &Decls) {
+ for (auto *Redecl : D->redecls()) {
+DeclID Id =
@@ -6481,6 +6481,33 @@ void Sema::PerformPendingInstantiations(bool LocalOnly) {
PendingInstantiations.swap(delayedPCHInstantiations);
}
+// Instantiate all referenced specializations of the given function template
+// definition. This make sure that function template that
philnik777 wrote:
gentle ping~
https://github.com/llvm/llvm-project/pull/70976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
I think another question is whether warning on code like `int& val = arr[i]`
where `val` is not actually used on the path where `i == size` is OK. I would
not block this PR on a case like this, but it might be nice to add a test and
potentially a comment about the desired beha
@@ -129,7 +130,14 @@ static SmallString<32> buildSuspendPrefixStr(CGCoroData
&Coro, AwaitKind Kind) {
return Prefix;
}
-static bool memberCallExpressionCanThrow(const Expr *E) {
+static bool ResumeExprCanThrow(const CoroutineSuspendExpr &S) {
+ const Expr *E = S.getResumeE
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Klemm
Date: 2023-11-28T14:20:30-06:00
New Revision: 17feb330aab39c6c0c21ee9b02efb484dfb2261e
URL:
https://github.com/llvm/llvm-project/commit/17feb330aab39c6c0c21ee9b02efb484dfb2261e
DIFF:
https://github.com/llvm/llvm-project/commit/17feb330aab39c6c0c21ee9b02efb484dfb2261e.diff
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/73124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rampitec wrote:
After some digging I believe with this bug fixed we are fine now. Since we are
passing all bf16 inputs as i16 we can only inline small integers, and inline
integer 1 shall be the same as using 1 in an input register I believe. Although
we are missing a potential optimization, s
minglotus-6 wrote:
Per offline discussion, I'm going to construct c program test cases (to
generate raw profiles) to exercise the code path that annotates value profiles
and extend
https://github.com/llvm/llvm-project/blob/main/llvm/test/Transforms/PGOProfile/thinlto_indirect_call_promotion.ll
https://github.com/minglotus-6 converted_to_draft
https://github.com/llvm/llvm-project/pull/73570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
alexey-bataev wrote:
Seems to me, this should be allowed
https://github.com/llvm/llvm-project/pull/73690
https://github.com/jyknight closed
https://github.com/llvm/llvm-project/pull/72869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
dreachem wrote:
@alexey-bataev That restriction shouldn't apply to the `nothing` directive.
The `nothing` directive is not execu
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/72180
>From 6f07f561df390cfd1b0f36d510110f4daef0bc54 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Mon, 13 Nov 2023 23:54:51 +
Subject: [PATCH 1/6] [clang][llvm][fatlto] Avoid cloning modules in FatLTO
https://g
@@ -1530,14 +1530,11 @@
PassBuilder::buildPerModuleDefaultPipeline(OptimizationLevel Level,
}
ModulePassManager
-PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO,
-bool EmitSummary) {
+PassBuilder::buildFatL
https://github.com/llvm-beanz closed
https://github.com/llvm/llvm-project/pull/72139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chris B
Date: 2023-11-28T15:03:10-06:00
New Revision: d4626216943f8c4712bd17a709e439a0ffd0006b
URL:
https://github.com/llvm/llvm-project/commit/d4626216943f8c4712bd17a709e439a0ffd0006b
DIFF:
https://github.com/llvm/llvm-project/commit/d4626216943f8c4712bd17a709e439a0ffd0006b.diff
LOG:
llvm-beanz wrote:
Friendly ping @AaronBallman & @cor3ntin.
https://github.com/llvm/llvm-project/pull/67700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Andrés?= Villegas
Message-ID:
In-Reply-To:
https://github.com/avillega updated
https://github.com/llvm/llvm-project/pull/73194
>From 31c40ba8aea7192c8481a3ab046d9e756231e986 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Villegas?=
Date: Thu, 23 Nov 2023 02:14:42 +
Subj
=?utf-8?q?Andrés?= Villegas
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a3529aa92ee48552946066330f5302
=?utf-8?q?Andrés?= Villegas ,
=?utf-8?q?Andrés?= Villegas
Message-ID:
In-Reply-To:
https://github.com/avillega updated
https://github.com/llvm/llvm-project/pull/73194
>From 31c40ba8aea7192c8481a3ab046d9e756231e986 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Villegas?=
Date: Thu, 2
https://github.com/erichkeane approved this pull request.
Urgh, I finally set a bookmark on that page, so this is going to break that!
But yeah, this makes a lot more sense here, and I think ends up being easier to
maintain. It passes a quick proofread, so lgtm.
https://github.com/llvm/llvm-p
Author: Chris Bieneman
Date: 2023-11-28T15:30:15-06:00
New Revision: ce731770f869e8e61afa2dccb772e8367105a1a6
URL:
https://github.com/llvm/llvm-project/commit/ce731770f869e8e61afa2dccb772e8367105a1a6
DIFF:
https://github.com/llvm/llvm-project/commit/ce731770f869e8e61afa2dccb772e8367105a1a6.diff
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
alexey-bataev wrote:
@dreachem The problem is, that the compiler has no idea what to do with this
code.
`nothing` has no associat
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/70976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -177,17 +177,17 @@ DiagnosticBuilder ClangTidyContext::diag(
StringRef CheckName, SourceLocation Loc, StringRef Description,
DiagnosticIDs::Level Level /* = DiagnosticIDs::Warning*/) {
assert(Loc.isValid());
- unsigned ID = DiagEngine->getDiagnosticIDs()->getCusto
https://github.com/erichkeane commented:
I like this! I can't really review the tidy stuff immediately, but I think
this really makes sense. You DO have some unrelated WS changes that should be
removed though.
Also, Most of the changes this causes along the way I think are vast
improvements
@@ -177,17 +177,17 @@ DiagnosticBuilder ClangTidyContext::diag(
StringRef CheckName, SourceLocation Loc, StringRef Description,
DiagnosticIDs::Level Level /* = DiagnosticIDs::Warning*/) {
assert(Loc.isValid());
- unsigned ID = DiagEngine->getDiagnosticIDs()->getCusto
@@ -171,13 +172,61 @@ class DiagnosticMapping {
class DiagnosticIDs : public RefCountedBase {
public:
/// The level of the diagnostic, after it has been through mapping.
- enum Level {
+ enum Level : uint8_t {
Ignored, Note, Remark, Warning, Error, Fatal
};
+ //
@@ -171,13 +172,61 @@ class DiagnosticMapping {
class DiagnosticIDs : public RefCountedBase {
public:
/// The level of the diagnostic, after it has been through mapping.
- enum Level {
+ enum Level : uint8_t {
Ignored, Note, Remark, Warning, Error, Fatal
};
+ //
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
}
}
}
-// If typo correction failed or was not performed, fall through
-[[fallthrough]];
+Result.suppressDiagnostics();
+return nullptr;
+ cas
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
}
}
}
-// If typo correction failed or was not performed, fall through
-[[fallthrough]];
+Result.suppressDiagnostics();
+return nullptr;
+ cas
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
dreachem wrote:
As I understand it, the `nothing` directive is not the equivalent of a null
statement. It is an "ignore me" direc
https://github.com/steven-johnson created
https://github.com/llvm/llvm-project/pull/73702
Apparently the gcc 7.5 compiler for arm32-linux fails to implicitly convert to
std::optional; this inserts an explicit constructor to unbreak that compiler.
[Injection from
https://reviews.llvm.org/rG414
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Steven Johnson (steven-johnson)
Changes
Apparently the gcc 7.5 compiler for arm32-linux fails to implicitly convert to
std::optional; this inserts an explicit constructor to unbreak that compiler.
[Injection from
https://reviews.llvm.org
https://github.com/ljmf00 approved this pull request.
https://github.com/llvm/llvm-project/pull/73691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mjklemm wrote:
Thanks all for your reviews and the all the feedback you have provided! Much
appreciated!
https://github.com/llvm/llvm-project/pull/73124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -12,7 +12,6 @@ int mixed() {
x=d;
}
-// expected-error@+2 {{#pragma omp nothing' cannot be an immediate
substatement}}
alexey-bataev wrote:
Ah, ok, I see. Then yes, this check must be removed.
https://github.com/llvm/llvm-project/pull/73690
___
https://github.com/alexey-bataev approved this pull request.
https://github.com/llvm/llvm-project/pull/73690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/73160
>From dbd06bc001c0e00436fcacac231d9d80b443edf4 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 21 Nov 2023 21:38:12 -0800
Subject: [PATCH 1/2] add checks for nested noexcept in cxxtempexpr
---
clan
yuxuanchen1997 wrote:
@ChuanqiXu9, I updated the check like you suggested, and it should look much
nicer now. The only caveat is that the `children()` call isn't going to cover
the implicit destructor call in a `CXXBindTemporaryExpr`. That pattern matching
case is here to stay and likely there
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/73160
>From dbd06bc001c0e00436fcacac231d9d80b443edf4 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 21 Nov 2023 21:38:12 -0800
Subject: [PATCH 1/3] add checks for nested noexcept in cxxtempexpr
---
clan
https://github.com/steven-johnson closed
https://github.com/llvm/llvm-project/pull/73702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
> Looks like LLDB linux buildbot isn't happy, checking...
Fix in https://github.com/llvm/llvm-project/pull/73707
https://github.com/llvm/llvm-project/pull/73626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
psteinfeld wrote:
@mjklemm, after this change was integrated, the test Driver/ctofortran no
longer succeeds. This test gets run when you call `make check-flang`. I'm not
sure why the pre- and post-build checks did not run check-flang.
https://github.com/llvm/llvm-project/pull/73124
_
=?utf-8?q?Andrés?= Villegas ,
=?utf-8?q?Andrés?= Villegas
Message-ID:
In-Reply-To:
avillega wrote:
I've addressed the review comments so far, please re review and leave comments
if any.
https://github.com/llvm/llvm-project/pull/73194
___
cfe-commit
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/73709
In this patch, we add support for checking a heterogeneous archive. We also
significantly improve the clang-offload-bundler documentation.
>From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001
F
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Jacob Lambert (lamb-j)
Changes
In this patch, we add support for checking a heterogeneous archive. We also
significantly improve the clang-offload-bundler documentation.
---
Patch is 23.51 KiB, truncated
lamb-j wrote:
For context, these changes reconcile differences between the upstream
clang-offload-bundler and the AMD Fork offload bundler
(https://github.com/RadeonOpenCompute/llvm-project/tree/amd-stg-open)
https://github.com/llvm/llvm-project/pull/73709
_
philnik777 wrote:
Would it make sense to document this more publicly? While it's designed to be
an internal tool, it's really useful for people who want to make sure their
library produces high quality diagnostics (e.g. `nodiscard`, `static_assert`s
etc.). I'm sure you are aware that libc++ us
https://github.com/jdoerfert approved this pull request.
LG, see the nit.
Also, add a runtime test with bare and verify we stick with values we otherwise
would not, e.g., 1 teams and 1024 threads.
https://github.com/llvm/llvm-project/pull/70612
_
@@ -14633,6 +14633,26 @@ StmtResult
Sema::ActOnOpenMPTargetTeamsDirective(ArrayRef Clauses,
}
setFunctionHasBranchProtectedScope();
+ bool HasBareClause = false;
+ bool HasThreadLimitClause = false;
+ bool HasNumTeamsClause = false;
+ OMPClause *BareClause = nullptr;
https://github.com/jdoerfert edited
https://github.com/llvm/llvm-project/pull/70612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/73719
The working directory is included in the PCM, but is not currently part of the
context hash. This causes problems because different builds of a PCM with
exactly the same command line can end up with different
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Spencer (Bigcheese)
Changes
The working directory is included in the PCM, but is not currently part of the
context hash. This causes problems because different builds of a PCM with
exactly the same command line can end up with dif
Author: Alex Voicu
Date: 2023-11-29T00:15:18Z
New Revision: 57a0416e0e8ccd522d4242dbe5d0d7893864a10a
URL:
https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a
DIFF:
https://github.com/llvm/llvm-project/commit/57a0416e0e8ccd522d4242dbe5d0d7893864a10a.diff
LOG: [c
https://github.com/AlexVlx closed
https://github.com/llvm/llvm-project/pull/69266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
This patch makes `isProto()` a convenience function like `isCpp()`, which
doesn't prevent us from handling C++ and Objective-C separately when needed.
Although `LK_TextProto` is not always formatted like `LK_Proto`, it's frequent
enough (about 16 times in the codebase) that we sh
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/70258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 reopened
https://github.com/llvm/llvm-project/pull/65148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/17] [libc++] Implement ranges::contains
Differential Revision:
philnik777 wrote:
I've reopened the old one for you. Let's keep the discussion in one place.
https://github.com/llvm/llvm-project/pull/70258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/17] [libc++] Implement ranges::contains
Differential Revision
https://github.com/bwendling created
https://github.com/llvm/llvm-project/pull/73730
This is an alternative to https://github.com/llvm/llvm-project/pull/73465. It
generates the GEP directly. It's not tested well, but it might be a nicer
solution rather than adding AST nodes.
PTAL
>From 3e500
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Bill Wendling (bwendling)
Changes
This is an alternative to https://github.com/llvm/llvm-project/pull/73465. It
generates the GEP directly. It's not tested well, but it might be a nicer
solution rather than adding AST nodes.
PTAL
---
Fu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4eb421192479dbecae2621b868e55aaf6d945b02
3e500c2a7c6b7895ebe292a1ed50e04409ba149c --
201 - 300 of 366 matches
Mail list logo
