[clang] [Clang] Eagerly instantiate used constexpr function upon definition. (PR #73463)

2023-11-27 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73463 >From 80fc2336d14e6929c67f2e67d8bb2469fa48cbc4 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Sun, 26 Nov 2023 22:47:51 +0100 Subject: [PATCH] [Clang] Eagerly instantiate used constexpr function upon defin

[clang] [llvm] [clang][RISCV] Change default abi when only have f extension but no d extension (PR #73489)

2023-11-27 Thread Jianjian Guan via cfe-commits
https://github.com/jacquesguan created https://github.com/llvm/llvm-project/pull/73489 Now we have default abi lp64 for rv64if and ilp32 for rv32if, which is different with riscv-gnu-toolchain. In https://github.com/riscv-collab/riscv-gnu-toolchain/blob/8e9fb09a0c4b1e566492ee6f42e8c1fa5ef7e0c2

[clang] [llvm] [clang][RISCV] Change default abi when only have f extension but no d extension (PR #73489)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-risc-v Author: Jianjian Guan (jacquesguan) Changes Now we have default abi lp64 for rv64if and ilp32 for rv32if, which is different with riscv-gnu-toolchain. In https://github.com/ris

[clang] [clang-format] Add BreakConcatenatedStrings option (PR #73432)

2023-11-27 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/73432 >From def7bbb22cdd9269aa927d8dcf4247c88877503b Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 25 Nov 2023 23:55:11 -0800 Subject: [PATCH 1/2] [clang-format] Add BreakConcatenatedStrings option Closes #70451.

[clang] [clang-format] Add BreakAdjacentStringLiterals option (PR #73432)

2023-11-27 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakAdjacentStringLiterals option (PR #73432)

2023-11-27 Thread Owen Pan via cfe-commits
@@ -2088,6 +2088,19 @@ struct FormatStyle { /// \version 3.7 bool BreakBeforeTernaryOperators; + /// Break between concatenated string literals in C, C++, and Objective-C. owenca wrote: Fixed. https://github.com/llvm/llvm-project/pull/73432

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Thinking some more about "Approach 2", I realized there is a challenge with it: given the node we are trying to resolve (for example, a dependent member expr) as a starting point, we need to find the enclosing template decl, so that we can query it for its "only instantia

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,455 @@ +//===--- InterpBitcast.cpp - Interpreter for the constexpr VM

[clang] [Clang][SME2] Add outer product and accumulate/subtract builtins (PR #71176)

2023-11-27 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau approved this pull request. https://github.com/llvm/llvm-project/pull/71176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-11-27 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > I also discovered some complications related to nested templates [...] > > Does my previous comment elaborate on the same issue you've encountered? I believe so, yes. > Could you kindly share your thoughts more? Let's consider a nested template like this: ```c++ tem

[llvm] [clang] [clang][RISCV] Change default abi when only have f extension but no d extension (PR #73489)

2023-11-27 Thread Jianjian Guan via cfe-commits
https://github.com/jacquesguan updated https://github.com/llvm/llvm-project/pull/73489 >From e03da61c3ad76b76a99639ad1735ec556aaec10b Mon Sep 17 00:00:00 2001 From: Jianjian GUAN Date: Mon, 27 Nov 2023 16:14:04 +0800 Subject: [PATCH] [clang][RISCV] Change default abi when only have f extension

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

2023-11-27 Thread Nathan Ridge via cfe-commits
@@ -585,6 +585,17 @@ TEST_F(TokenCollectorTest, DelayedParsing) { EXPECT_THAT(collectAndDump(Code), StartsWith(ExpectedTokens)); } +TEST_F(TokenCollectorTest, UnclosedToken) { HighCommander4 wrote: Indeed, it looks like `TokenBuffer::spelledForExpanded()` (

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/73491 It is quite common to symlink clang-format-diff.py to clang-format-diff, and in that case the help output still refers to the .py version. Compute it instead to work in both setup. >From 788d03126f95f

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (serge-sans-paille) Changes It is quite common to symlink clang-format-diff.py to clang-format-diff, and in that case the help output still refers to the .py version. Compute it instead to work in both setup. --- Full diff: h

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 772f296214e10323ca16921c02b1852307b7d51b..788d03126f95ffc8d3b9701fdba73bb931e25cfc clang/

[clang-tools-extra] [llvm] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2023-11-27 Thread Qiu Chaofan via cfe-commits
@@ -8900,6 +8900,83 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[clang] [llvm] [clang-tools-extra] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2023-11-27 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/67302 >From a1567f579531c3abbd1f4e9b7c7edd2f95ead42c Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 25 Sep 2023 17:10:51 +0800 Subject: [PATCH 1/3] [PowerPC] Implement llvm.set.rounding intrinsic According to

[clang-tools-extra] [llvm] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2023-11-27 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/67302 >From a1567f579531c3abbd1f4e9b7c7edd2f95ead42c Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 25 Sep 2023 17:10:51 +0800 Subject: [PATCH 1/4] [PowerPC] Implement llvm.set.rounding intrinsic According to

[clang] [Clang] CWG2789 Overload resolution with implicit and explicit object… (PR #73493)

2023-11-27 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/73493 … member functions Implement the resolution to CWG2789 from https://wiki.edg.com/pub/Wg21kona2023/StrawPolls/p3046r0.html The DR page is not updated because the issue has not made it to a published list yet.

[clang] [Clang] CWG2789 Overload resolution with implicit and explicit object… (PR #73493)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes … member functions Implement the resolution to CWG2789 from https://wiki.edg.com/pub/Wg21kona2023/StrawPolls/p3046r0.html The DR page is not updated because the issue has not made it to a published list yet.

[clang] d1652ff - [Clang][SME2] Add outer product and accumulate/subtract builtins (#71176)

2023-11-27 Thread via cfe-commits
Author: Kerry McLaughlin Date: 2023-11-27T09:54:23Z New Revision: d1652ff0803ac9f2f3ea99336f71edacdf95a721 URL: https://github.com/llvm/llvm-project/commit/d1652ff0803ac9f2f3ea99336f71edacdf95a721 DIFF: https://github.com/llvm/llvm-project/commit/d1652ff0803ac9f2f3ea99336f71edacdf95a721.diff L

[clang] [Clang][SME2] Add outer product and accumulate/subtract builtins (PR #71176)

2023-11-27 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm closed https://github.com/llvm/llvm-project/pull/71176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/73491 >From 788d03126f95ffc8d3b9701fdba73bb931e25cfc Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 27 Nov 2023 10:17:32 +0100 Subject: [PATCH 1/2] Improve clang-format-diff help output It is qu

[clang] 0e86d3e - [clang] Print static_assert values of arithmetic binary operators (#71671)

2023-11-27 Thread via cfe-commits
Author: Timm Baeder Date: 2023-11-27T11:10:02+01:00 New Revision: 0e86d3ea9b93da273ee800a251dd60a44b85a320 URL: https://github.com/llvm/llvm-project/commit/0e86d3ea9b93da273ee800a251dd60a44b85a320 DIFF: https://github.com/llvm/llvm-project/commit/0e86d3ea9b93da273ee800a251dd60a44b85a320.diff L

[clang] [clang] Print static_assert values of arithmetic binary operators (PR #71671)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/71671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang][analyzer] Support `fputs` in the StreamChecker (PR #73335)

2023-11-27 Thread Balázs Kéri via cfe-commits
@@ -824,20 +817,76 @@ void StreamChecker::evalFgetcFputc(const FnDescription *Desc, // If a (non-EOF) error occurs, the resulting value of the file position // indicator for the stream is indeterminate. - StreamErrorState NewES; - if (IsRead) -NewES = -OldSS

[clang] [clang][analyzer] Support `fputs` in the StreamChecker (PR #73335)

2023-11-27 Thread Balázs Kéri via cfe-commits
@@ -824,20 +817,76 @@ void StreamChecker::evalFgetcFputc(const FnDescription *Desc, // If a (non-EOF) error occurs, the resulting value of the file position // indicator for the stream is indeterminate. - StreamErrorState NewES; - if (IsRead) -NewES = -OldSS

[clang] [clang][analyzer] Support `fputs` in the StreamChecker (PR #73335)

2023-11-27 Thread Balázs Kéri via cfe-commits
@@ -824,20 +817,76 @@ void StreamChecker::evalFgetcFputc(const FnDescription *Desc, // If a (non-EOF) error occurs, the resulting value of the file position // indicator for the stream is indeterminate. - StreamErrorState NewES; - if (IsRead) -NewES = -OldSS

[clang] [clang][analyzer] Support `fputs` in the StreamChecker (PR #73335)

2023-11-27 Thread Balázs Kéri via cfe-commits
@@ -824,20 +817,76 @@ void StreamChecker::evalFgetcFputc(const FnDescription *Desc, // If a (non-EOF) error occurs, the resulting value of the file position // indicator for the stream is indeterminate. - StreamErrorState NewES; - if (IsRead) -NewES = -OldSS

[clang] [clang][analyzer] Support `fputs` in the StreamChecker (PR #73335)

2023-11-27 Thread Balázs Kéri via cfe-commits
@@ -141,6 +141,24 @@ void error_fputc(void) { fputc('A', F); // expected-warning {{Stream might be already closed}} } +void error_fputs(void) { + FILE *F = tmpfile(); + if (!F) +return; + int Ret = fputs("XYZ", F); + if (Ret >= 0) { +clang_analyzer_eval(feof(F) |

[clang] 489df61 - [clang][Interp][NFC] const qualify a local variable

2023-11-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-11-27T11:17:49+01:00 New Revision: 489df61a2960cbd154fe0a2c23918c2609ef4357 URL: https://github.com/llvm/llvm-project/commit/489df61a2960cbd154fe0a2c23918c2609ef4357 DIFF: https://github.com/llvm/llvm-project/commit/489df61a2960cbd154fe0a2c23918c2609ef4357.diff LO

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Kiran Chandramohan via cfe-commits
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis, + options::OP

[clang] [lld] [clang-tools-extra] [libcxxabi] [libcxx] [libunwind] [mlir] [llvm] [flang] [lldb] [libc] [compiler-rt] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-27 Thread Shahid Iqbal via cfe-commits
shahidiqbal13 wrote: Hi @DrTodd13 , Any further needs to be done here ?? Can you please add more devs for reviewing this Thanks, Shahid https://github.com/llvm/llvm-project/pull/72654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[llvm] [clang] [clang-tools-extra] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2023-11-27 Thread Qiu Chaofan via cfe-commits
ecnelises wrote: > The patch looks good but I am not familiar with PPC instructions enough. > Could you please run the runtime tests from here: > https://github.com/llvm/llvm-test-suite/tree/main/MultiSource/UnitTests/Float/rounding? > You just need to build application from two files: clang r

[clang] [llvm] AArch64: add support for currently released Apple CPUs. (PR #73499)

2023-11-27 Thread Tim Northover via cfe-commits
https://github.com/TNorthover created https://github.com/llvm/llvm-project/pull/73499 These are still v8.6a and have no real changes as far as LLVM cares, so it's mostly just a copy/paste job (actually from https://github.com/llvm/llvm-project/pull/73497 rather than `main` as I write this).

[clang] [llvm] AArch64: add support for currently released Apple CPUs. (PR #73499)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Tim Northover (TNorthover) Changes These are still v8.6a and have no real changes as far as LLVM cares, so it's mostly just a copy/paste job (actually from https://github.com/llvm/llvm-project/pull/73497 rather than `main` as I

[llvm] [clang] AArch64: add support for currently released Apple CPUs. (PR #73499)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tim Northover (TNorthover) Changes These are still v8.6a and have no real changes as far as LLVM cares, so it's mostly just a copy/paste job (actually from https://github.com/llvm/llvm-project/pull/73497 rather than `main` as I write thi

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Andrzej Warzyński via cfe-commits
@@ -2,12 +2,25 @@ ! See flang/test/Fir/tbaa-codegen.fir for a test that the output is correct ! RUN: %flang -c -emit-llvm -falias-analysis %s -o - | llvm-dis | FileCheck %s --check-prefix=CHECK-AA --check-prefix=CHECK-ALL -! RUN: %flang -c -emit-llvm -falias-analysis -fno-ali

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space commented: Thanks for addressing my comments - this is looking really good now! https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Andrzej Warzyński via cfe-commits
@@ -142,6 +142,24 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis, + options::OP

[llvm] [clang] AArch64: add support for currently released Apple CPUs. (PR #73499)

2023-11-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ea5de6021cf69a233106689cc6f0ee14899e1a83 c415ffd79582e6a24e4da7152935c93cbe17210e --

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread Krystian Stasiowski via cfe-commits
@@ -4,7 +4,8 @@ void f(T); template struct A { - // expected-error@+1{{cannot declare an explicit specialization in a friend}} + // expected-error@+2{{cannot declare an explicit specialization in a friend}} + // expected-error@+1{{friend function specialization cannot be de

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread Krystian Stasiowski via cfe-commits
@@ -373,6 +373,7 @@ template void foo() {} // expected-note{{candidate ignored: not a memb } using ns::foo; template struct A { + // expected-error@+1{{friend function specialization cannot be defined}} sdkrystian wrote: Per my other comment, I think the r

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= ,

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Tom Eccles via cfe-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/73111 >From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Thu, 14 Sep 2023 09:09:29 + Subject: [PATCH 1/8] [flang] Enable alias tags pass by default Enable by default when o

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Tom Eccles via cfe-commits
@@ -2,12 +2,25 @@ ! See flang/test/Fir/tbaa-codegen.fir for a test that the output is correct ! RUN: %flang -c -emit-llvm -falias-analysis %s -o - | llvm-dis | FileCheck %s --check-prefix=CHECK-AA --check-prefix=CHECK-ALL -! RUN: %flang -c -emit-llvm -falias-analysis -fno-ali

[clang] [flang] [Flang][Clang] Add support for frame pointers in Flang Driver (PR #72146)

2023-11-27 Thread Radu Salavat via cfe-commits
@@ -49,6 +49,26 @@ class CodeGenOptionsBase { class CodeGenOptions : public CodeGenOptionsBase { public: + /// The type of frame pointer used + enum class FramePointerKind { +None,// Omit all frame pointers. +NonLeaf, // Keep non-leaf frame pointers. +All,

[llvm] [clang] [clang][RISCV] Change default abi when only have f extension but no d extension (PR #73489)

2023-11-27 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp approved this pull request. I have similar patch before: https://reviews.llvm.org/D125947, so it LGTM as GCC's default behavior has changed. :-) But please wait for others' opinions. https://github.com/llvm/llvm-project/pull/73489 ___

[clang] [clang][ASTImporter] Improve structural equivalence of overloadable operators. (PR #72242)

2023-11-27 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/72242 From 5300f979c96eb2f88c298872f0519e274c155cfe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Tue, 14 Nov 2023 11:53:20 +0100 Subject: [PATCH 1/2] [clang][ASTImporter] Improve structural

[clang] [clang][ASTImporter] Improve structural equivalence of overloadable operators. (PR #72242)

2023-11-27 Thread Balázs Kéri via cfe-commits
balazske wrote: I have updated the comment. Probably I can test it with more projects after the other fixes with variable templates (#72841) are finished, then there may be less crashes. https://github.com/llvm/llvm-project/pull/72242 ___ cfe-commits

[clang] [clang-format] Option to ignore macro definitions (PR #70338)

2023-11-27 Thread via cfe-commits
tomekpaszek wrote: > After giving more thoughts to this, I think what we really want is > `SkipMacroDefinitionBody`, which would format the code below: > (...) > That is, only the body (except comments) of a macro definition is not > formatted. I understand that: - we do want to align the mac

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -1280,6 +1280,7 @@ void SVEEmitter::createHeader(raw_ostream &OS) { OS << "typedef __SVBfloat16_t svbfloat16_t;\n"; OS << "#include \n"; + OS << "#include \n"; sdesmalen-arm wrote: I'm missing similar changes for NeonEmitter.cpp where this include wou

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -2546,6 +2548,44 @@ void NeonEmitter::runFP16(raw_ostream &OS) { OS << "#endif /* __ARM_FP16_H */\n"; } +void NeonEmitter::runVectorType(raw_ostream &OS) { + OS << "/*=== arm_vector_type - ARM vector type " +"--===\n" +" *\n" +" *\n" +

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -279,11 +282,14 @@ cl::opt Action( "Generate riscv_vector_builtin_cg.inc for clang"), clEnumValN(GenRISCVVectorBuiltinSema, "gen-riscv-vector-builtin-sema", "Generate riscv_vector_builtin_sema.inc for clang"), -clEnumValN

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -2546,6 +2548,44 @@ void NeonEmitter::runFP16(raw_ostream &OS) { OS << "#endif /* __ARM_FP16_H */\n"; } +void NeonEmitter::runVectorType(raw_ostream &OS) { + OS << "/*=== arm_vector_type - ARM vector type " +"--===\n" +" *\n" +" *\n" +

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -0,0 +1,13 @@ +//===--- arm_vector_type.td - ARM Fixed vector types compiler interface ---===// sdesmalen-arm wrote: What is the value of this file? https://github.com/llvm/llvm-project/pull/73258 ___ cfe-commits m

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -2546,6 +2548,44 @@ void NeonEmitter::runFP16(raw_ostream &OS) { OS << "#endif /* __ARM_FP16_H */\n"; } +void NeonEmitter::runVectorType(raw_ostream &OS) { + OS << "/*=== arm_vector_type - ARM vector type " sdesmalen-arm wrote: For here and everywhe

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -2546,6 +2548,44 @@ void NeonEmitter::runFP16(raw_ostream &OS) { OS << "#endif /* __ARM_FP16_H */\n"; } +void NeonEmitter::runVectorType(raw_ostream &OS) { + OS << "/*=== arm_vector_type - ARM vector type " +"--===\n" +" *\n" +" *\n" +

[clang] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-11-27 Thread Sander de Smalen via cfe-commits
@@ -0,0 +1,113 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 sdesmalen-arm wrote: Given my previous comment, I think it's also worth having a test for: ``` #include #include ``` and ``` #include #i

[clang] [clang][ASTImporter] Improve structural equivalence of overloadable operators. (PR #72242)

2023-11-27 Thread via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: @@ -437,12 +439,67 @@ class StmtComparer { }; } // namespace +static bool IsStructurallyEquivalent(StructuralEquivalenceContext &Context, + const UnaryOperator *E1, +

[clang] [clang][Interp] Diagnose reads from non-const global variables (PR #71919)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/71919 >From 047249032d70e486380e8790915a8edeb70add56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 27 Nov 2023 12:10:48 +0100 Subject: [PATC

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-27 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang-tools-extra] [clangd] Add tweak to inline concept requirements (PR #69693)

2023-11-27 Thread via cfe-commits
https://github.com/Venyla updated https://github.com/llvm/llvm-project/pull/69693 >From d42a9f963471d6e78584febdacf4c5e99419a3c2 Mon Sep 17 00:00:00 2001 From: Vina Zahnd Date: Fri, 20 Oct 2023 10:01:54 +0200 Subject: [PATCH] [clangd] Add tweak to inline concept requirements Co-authored-by: Je

[clang] [clang][Interp] Implement inc/dec for IntegralAP (PR #69597)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69597 >From 047249032d70e486380e8790915a8edeb70add56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 27 Nov 2023 12:10:48 +0100 Subject: [PATC

[clang] [clang-format] Option to ignore macro definitions (PR #70338)

2023-11-27 Thread Owen Pan via cfe-commits
owenca wrote: > > After giving more thoughts to this, I think what we really want is > > `SkipMacroDefinitionBody`, which would format the code below: > > (...) > > That is, only the body (except comments) of a macro definition is not > > formatted. > > I understand that: > > * we do want to

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-27 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm updated https://github.com/llvm/llvm-project/pull/73124 >From 2a2693364cb8e9b657b9ff54aa78df0466b55fe4 Mon Sep 17 00:00:00 2001 From: Michael Klemm Date: Wed, 22 Nov 2023 14:22:20 +0100 Subject: [PATCH 01/11] Let the linker fail on multiple definitions of main() ---

[clang] [flang] [flang][Driver] Let the linker fail on multiple definitions of main() (PR #73124)

2023-11-27 Thread Michael Klemm via cfe-commits
mjklemm wrote: FYI: Rebased and resolved conflict flagged by GitHub. Alas, this means that I have lost the change to also make the linker fail on Windows. I've sent a request to the authors of the code to perform linking on Windows to help me figure out what to do. https://github.com/llvm/l

[flang] [clang] [clang-tools-extra] [llvm] [flang ]GETLOG runtime and extension implementation: get login username (PR #70917)

2023-11-27 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: > > Hello @klausler, could you please share your thoughts or comments on this > > patch, particularly with regard to the Windows side? Thanks in advance. > > You should use modern C++ braced initialization in flang/runtime. Hi @klausler. Thanks for the comment! I have updated

[clang] [clang] Fix sorting header paths (PR #73323)

2023-11-27 Thread Tulio Magno Quites Machado Filho via cfe-commits
tuliom wrote: > So what breakage is caused by the sorting failure? @dwblaikie This is not causing a breakage. It is just not working as designed because the sort function has been comparing `""` against `""` since commit https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @erichkeane the most recent commit results in the following: ```cpp template void f(T); void g() { } template struct A { // error: cannot declare an explicit specialization in a friend template<> friend void f<>(T) { } // error: friend function specialization cannot be de

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/72863 >From 3e191f245325742338eba223a3f98b6bb5ad414b Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 20 Nov 2023 07:11:41 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend function specializatio

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 57a11b7f75742ba74b563b8af75bc106a1e9d29e 2dc6567a7054feb755351b8d403b228f3d4b91ea --

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

2023-11-27 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/72863 >From 3e191f245325742338eba223a3f98b6bb5ad414b Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 20 Nov 2023 07:11:41 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend function specializatio

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2023-11-27 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/73511 External symbols created from a linker script may not get the ABI minimum alignment and must therefore be treated as unaligned by the compiler. To implement this, getMinGlobalAlign() (and getAlignOfGlobalVar)

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jonas Paulsson (JonPsson1) Changes External symbols created from a linker script may not get the ABI minimum alignment and must therefore be treated as unaligned by the compiler. To implement this, getMinGlobalAlign() (and getAlign

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2023-11-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/71315 >From 047249032d70e486380e8790915a8edeb70add56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 27 Nov 2023 12:10:48 +0100 Subject: [PATC

[clang] [llvm] [clang-tools-extra] [MCP] Enhance MCP copy Instruction removal for special case (PR #70778)

2023-11-27 Thread Björn Pettersson via cfe-commits
bjope wrote: Tracked down some miscompiles found downstream that points at this commit. Also wrote a new issue here about it: https://github.com/llvm/llvm-project/issues/73512 https://github.com/llvm/llvm-project/pull/70778 ___ cfe-commits mailing lis

[clang] d7c03a1 - [clang][AArch64][NFC] Remove trailing space in SME intriniscs header

2023-11-27 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2023-11-27T13:31:15Z New Revision: d7c03a196edb1e5f5a45121bb51899e8f5e72ca6 URL: https://github.com/llvm/llvm-project/commit/d7c03a196edb1e5f5a45121bb51899e8f5e72ca6 DIFF: https://github.com/llvm/llvm-project/commit/d7c03a196edb1e5f5a45121bb51899e8f5e72ca6.diff LOG

[clang] 5bd643e - [clang][dataflow] Strengthen widening of boolean values. (#73484)

2023-11-27 Thread via cfe-commits
Author: martinboehme Date: 2023-11-27T14:55:49+01:00 New Revision: 5bd643e1456bd2acc53ac0bf594d285be89a44fe URL: https://github.com/llvm/llvm-project/commit/5bd643e1456bd2acc53ac0bf594d285be89a44fe DIFF: https://github.com/llvm/llvm-project/commit/5bd643e1456bd2acc53ac0bf594d285be89a44fe.diff

[clang] [clang][dataflow] Strengthen widening of boolean values. (PR #73484)

2023-11-27 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/73484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan edited https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Kiran Chandramohan via cfe-commits
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis, + options::OP

[clang] piper export cl 583969847 (PR #73518)

2023-11-27 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/73518 - [clang][dataflow] Strengthen widening of boolean values. - [clang][dataflow] Defer initialization of `Environment`. - [clang][dataflow] Add synthetic fields to `RecordStorageLocation`. - [clang][dataflow] M

[clang] piper export cl 583969847 (PR #73518)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes - [clang][dataflow] Strengthen widening of boolean values. - [clang][dataflow] Defer initialization of `Environment`. - [clang][dataflow] Add synthetic fields to `RecordStorageLocation`. - [clang][datafl

[clang] piper export cl 583969847 (PR #73518)

2023-11-27 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/73518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit TBAA info for enums in C (PR #73326)

2023-11-27 Thread David Sherwood via cfe-commits
https://github.com/david-arm updated https://github.com/llvm/llvm-project/pull/73326 >From af76f6b6b3469fd0f5f24427c5a175c8d9d7c83a Mon Sep 17 00:00:00 2001 From: David Sherwood Date: Fri, 24 Nov 2023 13:20:23 + Subject: [PATCH 1/2] [Clang] Emit TBAA info for enums in C When emitting TBAA

[clang] [Clang] Emit TBAA info for enums in C (PR #73326)

2023-11-27 Thread David Sherwood via cfe-commits
@@ -196,11 +196,14 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type *Ty) { // Enum types are distinct types. In C++ they have "underlying types", // however they aren't related for TBAA. if (const EnumType *ETy = dyn_cast(Ty)) { +if (!Features.CPlusPlus) +

[llvm] [clang] [SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics (PR #73317)

2023-11-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/73317 >From f5b909e24e3cea49d98b40797880e4329a7a1e4f Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 20 Nov 2023 15:50:28 + Subject: [PATCH 1/2] [SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics See

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-27 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space commented: I think that what's being proposed here is quite non-standard. In particular, what should happen here: ```bash flang-new {A very long list of options copied from somewhere, including -fno-alias-analysis) -O3 file.f90 ``` How is the user meant to know

[clang] [AArch64][SME2] Add PEXT, PSEL builtins for SME2 (PR #72827)

2023-11-27 Thread Dinar Temirbulatov via cfe-commits
@@ -1,10 +1,17 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S -O1 -Werror -emit-llvm -o - %s | FileCheck %s -// RUN: %clang_cc1

[llvm] [clang] [SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics (PR #73317)

2023-11-27 Thread Kerry McLaughlin via cfe-commits
@@ -5098,6 +5099,12 @@ void AArch64DAGToDAGISel::Select(SDNode *Node) { AArch64::LUTI2_4ZTZI_S})) // Second Immediate must be <= 3: SelectMultiVectorLuti<3>(Node, 4, Opc); + else if (auto Opc = SelectOpcodeFromVT( kmclaughlin

[clang] [AArch64][SME2] Add PEXT, PSEL builtins for SME2 (PR #72827)

2023-11-27 Thread Dinar Temirbulatov via cfe-commits
@@ -1859,19 +1859,28 @@ def SVBGRP : SInst<"svbgrp[_{d}]", "ddd", "UcUsUiUl", MergeNone, "aarch64_sv def SVBGRP_N : SInst<"svbgrp[_n_{d}]", "dda", "UcUsUiUl", MergeNone, "aarch64_sve_bgrp_x">; } +let TargetGuard = "sve2p1|sme" in { dtemirbulatov wrote:

[llvm] [libc] [libcxx] [compiler-rt] [flang] [clang] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-27 Thread Aaron Ballman via cfe-commits
@@ -940,7 +940,7 @@ static llvm::Value *getArrayIndexingBound(CodeGenFunction &CGF, if (const ValueDecl *VD = CGF.FindCountedByField(Base)) { IndexedType = Base->getType(); - const Expr *E = CGF.BuildCountedByFieldExpr(Base, VD); + Expr *E = CGF.BuildCount

[compiler-rt] [llvm] [libc] [flang] [clang] [libcxx] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-27 Thread Aaron Ballman via cfe-commits
@@ -956,37 +956,55 @@ static llvm::Value *getArrayIndexingBound(CodeGenFunction &CGF, return nullptr; } -const Expr * -CodeGenFunction::BuildCountedByFieldExpr(const Expr *Base, - const ValueDecl *CountedByVD) { +Expr *CodeGenFunction

[libc] [llvm] [compiler-rt] [libcxx] [flang] [clang] [Clang] Use correct base expression for counted_by field (#73168) (PR #73465)

2023-11-27 Thread Aaron Ballman via cfe-commits
@@ -916,7 +916,7 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, // Build a load of the counted_by field. bool IsSigned = CountedByFD->getType()->isSignedIntegerType(); - const Expr *CountedByExpr = BuildCountedByFieldExpr(Base, CountedByFD)

[clang] [clang] Accept lambdas in C++03 as an extensions (PR #73376)

2023-11-27 Thread Aaron Ballman via cfe-commits
@@ -3,8 +3,8 @@ extern groupshared float f; extern float groupshared f; // Ok, redeclaration? -// NOTE:lambda is not enabled except for hlsl202x. -// expected-error@+2 {{expected expression}} +// expected-warning@+3 {{lambdas are a C++11 extension}} +// expected-error@+2 {{

[clang] ba1c869 - [OpenACC] Implement 'routine' construct parsing (#73143)

2023-11-27 Thread via cfe-commits
Author: Erich Keane Date: 2023-11-27T06:49:29-08:00 New Revision: ba1c869f0026923e0db80ffbd94d02e4718cc1f1 URL: https://github.com/llvm/llvm-project/commit/ba1c869f0026923e0db80ffbd94d02e4718cc1f1 DIFF: https://github.com/llvm/llvm-project/commit/ba1c869f0026923e0db80ffbd94d02e4718cc1f1.diff L

  1   2   3   4   >