[llvm] [clang] [mlir] [llvm][TypeSize] Consider TypeSize of '0' to be fixed/scalable-agnostic. (PR #72994)

sdesmalen-arm wrote: > Creating a scalable vector of size 0 should not even be allowed. Correct, but that is no reason to disallow a value of '0' for TypeSize. This is just a class to represent a value (fixed or scalable), and it's up to the places where TypeSize is used on whether that use is

[llvm] [clang] [mlir] [llvm][TypeSize] Consider TypeSize of '0' to be fixed/scalable-agnostic. (PR #72994)

michaelmaitland wrote: > Correct, but that is no reason to disallow a value of '0' for TypeSize. Fair enough! https://github.com/llvm/llvm-project/pull/72994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[llvm] [clang] [mlir] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

paulwalker-arm wrote: > The static functions renaming is going to produce a lot of noise but I guess > this is too late already... Shall we revert to keep the change minimal? > @nikic @paulwalker-arm WDYT ? For my money the function's were originally named correctly and then erroneously chang

[clang] [CUDA][HIP] make trivial ctor/dtor host device (PR #72394)

requested here 25 | template class Abc; |^ /opt/compiler-explorer/clang-trunk-20231121/bin/../include/c++/v1/__memory/unique_ptr.h:263:59: note: '~unique_ptr' declared here 263 | _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINC

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

DonatNagyE wrote: ..and it turns out that `ValistChecker` already has a function called `ValistChecker::getVAListAsRegion` that handles different representations of `va_list` under various systems. (I was not familiar with it because it was added by @Xazax-hun after the initial commit https://

[clang] [flang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/72601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

gchatelet wrote: > > The static functions renaming is going to produce a lot of noise but I > > guess this is too late already... Shall we revert to keep the change > > minimal? @nikic @paulwalker-arm WDYT ? > > For my money the functions were originally named correctly and then > erroneously

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/ilya-biryukov approved this pull request. LGTM with a few suggestiosn. One is in the comment. I also suggest to add a warning when users mark the type as `coro_lifetimebound` without `coro_return_type`. The analysis will be disabled in this case and it may be hard to understa

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -334,6 +334,10 @@ Attribute Changes in Clang [[clang::code_align(A)]] for(;;) { } } +- Clang now introduced ``[[clang::coro_lifetimebound]]`` attribute. + All arguments to a function are considered to be lifetime bound if the function ilya-b

[mlir] [clang] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

https://github.com/gchatelet approved this pull request. https://github.com/llvm/llvm-project/pull/72979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/72979 >From ffc1922935f6c5e9fc66db7fcce72ad0f5d8bef8 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Tue, 21 Nov 2023 13:50:33 + Subject: [PATCH 1/2] [llvm][TypeSize] Fix addition/subtraction in TypeSiz

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[mlir] [clang] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

sdesmalen-arm wrote: Thanks @paulwalker-arm @gchatelet! https://github.com/llvm/llvm-project/pull/72979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

https://github.com/momchil-velikov closed https://github.com/llvm/llvm-project/pull/70474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [llvm] [clang] [clang-tools-extra] [flang] [libc] [AMDGPU] - Add constant folding to s_wqm intrinsic (PR #72382)

https://github.com/OutOfCache closed https://github.com/llvm/llvm-project/pull/72382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

@@ -349,6 +358,36 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + { + R"cpp( +namespace

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

@@ -349,6 +358,36 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + { + R"cpp( +namespace

[clang] 147b38b - [OpenACC] Implement enter data/exit data construct parsing (#72916)

Author: Erich Keane Date: 2023-11-21T07:46:12-08:00 New Revision: 147b38b1464cb39e763a9865c476d5c3d54bc619 URL: https://github.com/llvm/llvm-project/commit/147b38b1464cb39e763a9865c476d5c3d54bc619 DIFF: https://github.com/llvm/llvm-project/commit/147b38b1464cb39e763a9865c476d5c3d54bc619.diff L

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/72916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657175 , @hans wrote: > We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to > this commit. I think Zequan is investigating: > https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 It

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

@@ -349,6 +358,36 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + { + R"cpp( +namespace

[llvm] [clang] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/70476 >From 9f90ac3383b37e9d2310836527d01a94b6fbadb9 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Fri, 27 Oct 2023 16:09:07 +0100 Subject: [PATCH 1/2] [AArch64] Add SVE2.1 intrinsics for indexed quadwor

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4657193 , @zequanwu wrote: > In D138846#4657175 , @hans wrote: > >> We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to >> this commit. I think Zequan

[clang] [CUDA][HIP] make trivial ctor/dtor host device (PR #72394)

yxsamliu wrote: Thanks for reporting. A reduced testcase is https://godbolt.org/z/MY84az9xh `template struct ptr { ~ptr() { static int x = 1;} }; template struct Abc : ptr { public: Abc(); ~Abc() {} }; template class Abc; ` clang thinks Abc::~Abc() is trivial but it is not. It cou

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657194 , @alanphipps wrote: > In D138846#4657193 , @zequanwu > wrote: > >> In D138846#4657175 , @hans wrote: >> >>> We're seeing cr

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657195 , @zequanwu wrote: > In D138846#4657194 , @alanphipps > wrote: > >> In D138846#4657193 , @zequanwu >> wrote: >> >>> In D1388

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

usx95 wrote: I would add the mentioned warning in a follow-up change. https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 164bf1e94ec05e50be05d085ce2a4381711df11b Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 01/10] Introduce [[clang::coro_lifetimebound]] (cherry picked from

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

@@ -311,7 +318,10 @@ computeBlockInputState(const CFGBlock &Block, AnalysisContext &AC) { } } - JoinedStateBuilder Builder(AC); + // When performing the join, only retain state for those expressions that are + // consumed by this block. This avoids performing joins a

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/72850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 28f62d7 - [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (#70476)

Author: Momchil Velikov Date: 2023-11-21T16:44:14Z New Revision: 28f62d72f4d56de0db0ed20c9b8c309ec5e8e193 URL: https://github.com/llvm/llvm-project/commit/28f62d72f4d56de0db0ed20c9b8c309ec5e8e193 DIFF: https://github.com/llvm/llvm-project/commit/28f62d72f4d56de0db0ed20c9b8c309ec5e8e193.diff LO

[clang] [llvm] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

https://github.com/momchil-velikov closed https://github.com/llvm/llvm-project/pull/70476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

Xazax-hun wrote: +1 for the simpler approach. I think I have a high-level question about the stability of the locations, its effect on convergence. But I am happy with the `ExprToVal` part of the simple patch. https://github.com/llvm/llvm-project/pull/72850

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/73015 `atomic` is required to be followed by a special `atomic clause`, so this patch manages the parsing of that. We are representing each of the variants of the atomic construct as separate kinds, because they h

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes `atomic` is required to be followed by a special `atomic clause`, so this patch manages the parsing of that. We are representing each of the variants of the atomic construct as separate kinds, because the

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

MaskRay wrote: We need an update to the documentation `JSONCompilationDatabase` and formal description of the problem you have seen. Your Buck2 feature is not blocked. You can use `/proc/self/cwd`, which is probably unavoidable if you use other features that require reproducible builds (https

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/73017 This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes This is the largest chunk of the AP

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes This is the largest chunk of the

[libcxx] [compiler-rt] [lldb] [libc] [flang] [clang-tools-extra] [clang] [llvm] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 1/7] FDATE extension implementation: get date and time in ctime format

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2fe24fdc94cb10795a196eadcf3eed8055ea4000 b3b1a6c3c6774bc4158d7e273abcfbac5b5db02d --

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/73018 Due to d0d2ee0e4bbe915d649e983c12d37bcfcf58823c clang doesn't perform qualified name lookup into the current instantiation when it has dependent bases, because of that `getTypeName` call always returns null fo

[clang] [clang][NFC] Reorder Atomic builtins to be consistent. (PR #72718)

https://github.com/jyknight approved this pull request. https://github.com/llvm/llvm-project/pull/72718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/73017 >From ae8c604e9333b1ea54fc6e80134bdba948eeecb7 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 20 Nov 2023 18:03:18 + Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created implicitly fr

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Due to d0d2ee0e4bbe915d649e983c12d37bcfcf58823c clang doesn't perform qualified name lookup into the current instantiation when it has dependent bases, because of that `getTypeName` call always re

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/73017 >From ae8c604e9333b1ea54fc6e80134bdba948eeecb7 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 20 Nov 2023 18:03:18 + Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created implicitly fr

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/73017 >From ae8c604e9333b1ea54fc6e80134bdba948eeecb7 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 20 Nov 2023 18:03:18 + Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created implicitly fr

[clang] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

https://github.com/erichkeane approved this pull request. The patch makes sense to me, though my knowledge of this function is limited. Please give @cor3ntin a chance to look at it too in case he sees something I don't. https://github.com/llvm/llvm-project/pull/73018 _

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/69704 >From 40df0527b2a3af8012f32d771a1bb2c861d42ed3 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 19 Oct 2023 17:51:11 +0200 Subject: [PATCH] [clangd] Allow "move function body out-of-line" in non-hea

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

https://github.com/aartbik updated https://github.com/llvm/llvm-project/pull/69704 >From 40df0527b2a3af8012f32d771a1bb2c861d42ed3 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 19 Oct 2023 17:51:11 +0200 Subject: [PATCH] [clangd] Allow "move function body out-of-line" in non-heade

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/73017 >From d7d8e8520681b6a71fda9848b18828cff8ed7415 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 20 Nov 2023 18:03:18 + Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created implicitly fr

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -94,6 +94,37 @@ void func() { #pragma acc kernels loop for(;;){} + int i = 0, j = 0, k = 0; + // expected-error@+2{{missing OpenACC 'atomic-clause'; expected 'read', 'write', 'update', or 'capture'}} + // expected-warning@+1{{OpenACC directives not yet implemented, pr

[clang] [clang][CodeGen] Remove ptr-to-ptr bitcasts (NFC) (PR #73020)

https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/73020 Opaque ptr cleanup effort >From 30cff5f1f27e047247ae126bb4b2d1c6103f7022 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Tue, 21 Nov 2023 11:16:23 -0600 Subject: [PATCH] [clang][CodeGen] Remove ptr-to-ptr bitc

[clang] [clang][CodeGen] Remove ptr-to-ptr bitcasts (NFC) (PR #73020)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Youngsuk Kim (JOE1994) Changes Opaque ptr cleanup effort --- Full diff: https://github.com/llvm/llvm-project/pull/73020.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGBuiltin.cpp (+4-9) - (modified) clang/lib/CodeGen/C

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -94,6 +94,37 @@ void func() { #pragma acc kernels loop for(;;){} + int i = 0, j = 0, k = 0; + // expected-error@+2{{missing OpenACC 'atomic-clause'; expected 'read', 'write', 'update', or 'capture'}} + // expected-warning@+1{{OpenACC directives not yet implemented, pr

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[llvm] [clang] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/71290 >From 22ecaa7d6f7854bd89da7390a7813bd9f1397f0b Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Sat, 4 Nov 2023 12:02:06 + Subject: [PATCH 1/2] [AArch64] Add quadword gather load/scatter store in

[clang-tools-extra] [clang] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

DanielKristofKiss wrote: I proposed a change to the aarch64 spec to help the harmonisation. https://github.com/ARM-software/acle/pull/277 I'd drop the aarch64 specifics. I have a few more lines to make it work on aarch64 (e.g. AppendTargetVersionMangling and AppendTargetClonesMangling needs d

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/73015 >From e656fb03feeafa1997a4b93126063ad77ecf5b2c Mon Sep 17 00:00:00 2001 From: erichkeane Date: Tue, 21 Nov 2023 08:56:00 -0800 Subject: [PATCH 1/2] [OpenACC] Implement Atomic construct variants `atomic` is re

[openmp] [clang] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -59,9 +60,21 @@ OpenACCDirectiveKindEx getOpenACCDirectiveKind(StringRef Name) { return llvm::StringSwitch(Name) .Case("enter", OpenACCDirectiveKindEx::Enter) .Case("exit", OpenACCDirectiveKindEx::Exit) + .Case("atomic", OpenACCDirectiveKindEx::Atomic)

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -143,26 +139,25 @@ ParseOpenACCEnterExitDataDirective(Parser &P, Token FirstTok, : OpenACCDirectiveKind::ExitData; } -OpenACCDirectiveKind ParseOpenACCAtomicDirective(Parser &P) { +OpenACCAtomicKind ParseOpenACCAtomicKind(Parser &P) { Token AtomicClauseToke

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

@@ -143,26 +139,25 @@ ParseOpenACCEnterExitDataDirective(Parser &P, Token FirstTok, : OpenACCDirectiveKind::ExitData; } -OpenACCDirectiveKind ParseOpenACCAtomicDirective(Parser &P) { +OpenACCAtomicKind ParseOpenACCAtomicKind(Parser &P) { Token AtomicClauseToke

[clang] Honor -fno-sanitize-link-runtime for libclang_rt.asan_static (PR #66414)

pirama-arumuga-nainar wrote: @vitalybuka can you help review this change? https://github.com/llvm/llvm-project/pull/66414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/73017 >From cea6998f68ffca08edb8bed555df093c8fe48d1c Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 20 Nov 2023 18:03:18 + Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created implicitly fr

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/73015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [llvm] [lld] [mlir] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

dwblaikie wrote: (patches like this should probably be broken up - test changes to the defaults in lld and llvm for instance don't depend on the change to the clang driver which is the only real semantic change in this patch, right? So probably only change the semantics of clang, and the tests

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

@@ -15,38 +20,57 @@ int main(void) { if (__builtin_cpu_supports("sse4.2")) a("sse4.2"); - // CHECK: [[LOAD:%[^ ]+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0) - // CHECK: [[AND:%[^ ]+]] = and i32 [[LOAD

[llvm] [clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

@@ -15,38 +20,57 @@ int main(void) { if (__builtin_cpu_supports("sse4.2")) a("sse4.2"); - // CHECK: [[LOAD:%[^ ]+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0) - // CHECK: [[AND:%[^ ]+]] = and i32 [[LOAD

[llvm] [clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

@@ -15,38 +20,57 @@ int main(void) { if (__builtin_cpu_supports("sse4.2")) a("sse4.2"); - // CHECK: [[LOAD:%[^ ]+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0) - // CHECK: [[AND:%[^ ]+]] = and i32 [[LOAD

[llvm] [clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

@@ -15,38 +20,57 @@ int main(void) { if (__builtin_cpu_supports("sse4.2")) a("sse4.2"); - // CHECK: [[LOAD:%[^ ]+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0) - // CHECK: [[AND:%[^ ]+]] = and i32 [[LOAD

[llvm] [clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

@@ -15,38 +20,57 @@ int main(void) { if (__builtin_cpu_supports("sse4.2")) a("sse4.2"); - // CHECK: [[LOAD:%[^ ]+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0) - // CHECK: [[AND:%[^ ]+]] = and i32 [[LOAD

[clang-tools-extra] [llvm] [clang] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

omjavaid wrote: This breaks on Arm/AArch64 lldb bots with llvm-mc not accepting sve2p1 when --mattr=all is supplied on commandline see error below: `home/omair.javaid/work/llvm-dev/build/bin/llvm-mc -filetype=obj -triple aarch64-linux-gnueabihf /home/omair.javaid/work/llvm-dev/llvm-project/lld

[clang] [OpenACC] Implement Atomic construct variants (PR #73015)

https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/73015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 04e9b61 - [OpenACC] Implement Atomic construct variants (#73015)

Author: Erich Keane Date: 2023-11-21T11:08:48-08:00 New Revision: 04e9b61cec8491ca35ba804d8e004a37caa4045e URL: https://github.com/llvm/llvm-project/commit/04e9b61cec8491ca35ba804d8e004a37caa4045e DIFF: https://github.com/llvm/llvm-project/commit/04e9b61cec8491ca35ba804d8e004a37caa4045e.diff L

[clang] [C++20] [Modules] Introduce a tool 'clang-named-modules-querier' and two plugins 'ClangGetUsedFilesFromModulesPlugin' and 'ClangGetDeclsInModulesPlugin' (PR #72956)

dwblaikie wrote: I'm still really hesitant about this direction. One starting concern: what happens if someone adds an overload, or other interesting name resolution to the module? The downstream caller hasn't textually changed, but it should be rebuilt because it should be calling a differen

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/68926 >From 78f82bcf33998de0663f4684a64a240f2e97f8a9 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Thu, 12 Oct 2023 16:56:27 -0400 Subject: [PATCH 01/17] This change adds support for the PPA2 section in zOS --- cla

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() { OutStreamer->popSection(); } +static uint32_t getProductVersion(Module &M) { + if (auto *VersionVal = cast_or_null( + M.getModuleFlag("zos_product_major_version"))) +return cast(VersionVal->getVa

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/68926 >From 78f82bcf33998de0663f4684a64a240f2e97f8a9 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Thu, 12 Oct 2023 16:56:27 -0400 Subject: [PATCH 01/18] This change adds support for the PPA2 section in zOS --- cla

[clang-tools-extra] [llvm] [clang] [MachineLICM][AArch64] Hoist COPY instructions with other uses in the loop (PR #71403)

@@ -1262,6 +1262,18 @@ bool MachineLICMBase::IsProfitableToHoist(MachineInstr &MI, return false; } + // If we have a COPY with other uses in the loop, hoist to allow the users to davemgreen wrote: Hello. From what I've seen in our benchmarks this has

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() { OutStreamer->popSection(); } +static uint32_t getProductVersion(Module &M) { + if (auto *VersionVal = cast_or_null( + M.getModuleFlag("zos_product_major_version"))) +return cast(VersionVal->getVa

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() { OutStreamer->popSection(); } +static uint32_t getProductVersion(Module &M) { + if (auto *VersionVal = cast_or_null( + M.getModuleFlag("zos_product_major_version"))) +return cast(VersionVal->getVa

[flang] [clang] [llvm] [clang-tools-extra] [flang ]GETLOG runtime and extension implementation: get login username (PR #70917)

klausler wrote: > Hello @klausler, could you please share your thoughts or comments on this > patch, particularly with regard to the Windows side? Thanks in advance. You should use modern C++ braced initialization in flang/runtime. https://github.com/llvm/llvm-project/pull/70917 __

[llvm] [clang] [clang-tools-extra] [Clang] Fix linker error for function multiversioning (PR #71706)

efriedma-quic wrote: @DanielKristofKiss From your response, I gather you want AArch64 to align with the other targets, but additional changes are required to make that work? In the interest of keeping things moving, how do you want to stage this? Would it make sense to land this as-is? Rhen

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/72452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 36e5388 - [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (#72452)

Author: bd1976bris Date: 2023-11-21T11:46:34-08:00 New Revision: 36e53885e6ac52ff948fac909178f82b602477dd URL: https://github.com/llvm/llvm-project/commit/36e53885e6ac52ff948fac909178f82b602477dd DIFF: https://github.com/llvm/llvm-project/commit/36e53885e6ac52ff948fac909178f82b602477dd.diff LO

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/72452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

https://github.com/justincady commented: LGTM as well, as the original fix remains in place. https://github.com/llvm/llvm-project/pull/72452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. FWIW, it's the first time for as long as I remember that mixing LLVM versions causes a runtime crash (that looks like a null deref). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D1388

[clang-tools-extra] [clang] [llvm] [MachineLICM][AArch64] Hoist COPY instructions with other uses in the loop (PR #71403)

@@ -1262,6 +1262,18 @@ bool MachineLICMBase::IsProfitableToHoist(MachineInstr &MI, return false; } + // If we have a COPY with other uses in the loop, hoist to allow the users to bjope wrote: It is a bit tricky of course, depending on the properties o

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/73030 Summary: We support standalone compilation for the NVPTX architecture using 'nvlink' as our linker. Because of the special handling required to transform input files to cubins, as nvlink expects for some reason, w

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: We support standalone compilation for the NVPTX architecture using 'nvlink' as our linker. Because of the special handling required to transform input files to cubins

[clang] [Clang][NVPTX] Allow passing arguments to the linker while standalone (PR #73030)

jhuber6 wrote: I have a review up to change the issue I was observing in CMake when building the `libc` project https://github.com/llvm/llvm-project/pull/73030. That is required for this to work when compiling the test suite. https://github.com/llvm/llvm-project/pull/73030

[llvm] [lld] [mlir] [clang] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

@@ -75,8 +75,8 @@ bb.2: store volatile i32 0, ptr addrspace(1) undef ret void } -; DEFAULTSIZE: .amdhsa_private_segment_fixed_size 4112 -; DEFAULTSIZE: ; ScratchSize: 4112 +; DEFAULTSIZE: .amdhsa_private_segment_fixed_size 16 JonChesterfield wrote: This se

<    1   2   3   4   >