[clang] 527fcb8 - [analyzer] Add std::variant checker (#66481)

2023-11-21 Thread via cfe-commits
Author: Gábor Spaits Date: 2023-11-21T14:02:22+01:00 New Revision: 527fcb8e5d6b1d491b6699cde818db1127bbb12c URL: https://github.com/llvm/llvm-project/commit/527fcb8e5d6b1d491b6699cde818db1127bbb12c DIFF: https://github.com/llvm/llvm-project/commit/527fcb8e5d6b1d491b6699cde818db1127bbb12c.diff

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-11-21 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/72985 We never need to access entries from these maps outside of the current basic block. This could only ever become a consideration when flow control happens inside a full-expression (i.e. we have multiple basic

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 527fcb8e5d6b1d491b6699cde818db1127bbb12c c50be6452130d2ea01f8845b037ce1fe9b9c9367 --

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
martinboehme wrote: Update: Here's a draft implementation of the "simpler, bolder approach" referenced above: https://github.com/llvm/llvm-project/pull/72985 The code is a _lot_ simpler -- it's mainly deleting code -- and I think I'm convinced at this point that this is the preferable thing t

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/72987 None >From 16434d49d87b3da8778de5ee3a0355eec2e2ba13 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 21 Nov 2023 13:07:23 + Subject: [PATCH] [clang][dataflow] Remove deprecated synonyms from `E

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/72987.diff 1 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h (-6) ``diff diff --git

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread Christian Kandeler via cfe-commits
@@ -499,17 +473,64 @@ class DefineOutline : public Tweak { HeaderUpdates = HeaderUpdates.merge(*DelInline); } -auto HeaderFE = Effect::fileEdit(SM, SM.getMainFileID(), HeaderUpdates); -if (!HeaderFE) - return HeaderFE.takeError(); - -Effect->ApplyEdi

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread Christian Kandeler via cfe-commits
@@ -19,7 +19,7 @@ TWEAK_TEST(DefineOutline); TEST_F(DefineOutlineTest, TriggersOnFunctionDecl) { FileName = "Test.cpp"; - // Not available unless in a header file. + // Not available for free function unless in a header file. ckandeler wrote: Do you have

[clang] [clang][Interp] Implement __builtin_ffs (PR #72988)

2023-11-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/72988 None >From efd400e2f928cfa2bd062c549a02bcbed5c8f95e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 21 Nov 2023 13:44:07 +0100 Subject:

[clang] [clang][Interp] Implement __builtin_ffs (PR #72988)

2023-11-21 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/72988.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/InterpBuiltin.cpp (+67) - (modif

[lldb] [libc] [flang] [clang-tools-extra] [compiler-rt] [llvm] [libcxx] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread Yi Wu via cfe-commits
@@ -10,9 +10,26 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "terminator.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#include "flang/Runtim

[lldb] [libc] [flang] [clang-tools-extra] [compiler-rt] [llvm] [libcxx] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 1/7] FDATE extension implementation: get date and time in ctime format

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/69704 >From 27af98b5a9b71255b2873f25943ed23e42946b27 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 19 Oct 2023 17:51:11 +0200 Subject: [PATCH] [clangd] Allow "move function body out-of-line" in non-hea

[clang-tools-extra] [clang] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -1708,6 +1710,13 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF, } ++Iter; +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + auto builder = jayfoad wrote: Upper case B for Builder. https://github.com/llv

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -388,6 +388,8 @@ class SIInsertWaitcnts : public MachineFunctionPass { // message. DenseSet ReleaseVGPRInsts; + // bool insertWaitcntAfterMemOp(MachineFunction &MF); jayfoad wrote: Remove all the unused code, don't just comment it out. https://github

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -1708,6 +1710,13 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF, } ++Iter; +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + auto builder = + BuildMI(Block, Iter, DebugLoc(), TII->get(AMDGPU::S_WAITCNT)) +

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -0,0 +1,222 @@ +; Testing the -amdgpu-precise-memory-op option +; COM: llc -mtriple=amdgcn -mcpu=hawaii -mattr=+amdgpu-precise-memory-op -verify-machineinstrs < %s | FileCheck %s -check-prefixes=GFX7 jayfoad wrote: What is COM: ? https://github.com/llvm/llvm

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

2023-11-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69713 >From 64dbeb52f05dd9c5b9559ed3de571cb87959f63e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 20 Oct 2023 14:16:22 +0200 Subject: [PATCH] [clang][Interp] Implement builtin_expect --- c

[clang] [llvm] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -2314,9 +2314,8 @@ void AMDGPUDAGToDAGISel::SelectBRCOND(SDNode *N) { SDValue VCMP = Cond->getOperand(0); auto CC = cast(Cond->getOperand(2))->get(); auto *CRHS = dyn_cast(Cond->getOperand(1)); -if ((CC == ISD::SETEQ || CC == ISD::SETNE) && CRHS && CRHS->isZe

[lldb] [libcxx] [clang] [clang-tools-extra] [flang] [compiler-rt] [libc] [llvm] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via cfe-commits
@@ -10,9 +10,26 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "terminator.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#include "flang/Runtim

[clang] e6ef315 - [APINotes] Introduce APINotes infrastructure in Clang Sema and Frontend

2023-11-21 Thread via cfe-commits
Author: Egor Zhdan Date: 2023-11-21T13:36:50Z New Revision: e6ef31524729fc03275b1ea4f92b66c1e1eb013e URL: https://github.com/llvm/llvm-project/commit/e6ef31524729fc03275b1ea4f92b66c1e1eb013e DIFF: https://github.com/llvm/llvm-project/commit/e6ef31524729fc03275b1ea4f92b66c1e1eb013e.diff LOG: [A

[clang] [APINotes] Introduce APINotes infrastructure in Clang Sema and Frontend (PR #72907)

2023-11-21 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/72907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -52,27 +52,41 @@ AST_MATCHER_P(Stmt, forEachPrevStmt, ast_matchers::internal::Matcher, } return IsHostile; } + +// Matches the expression awaited by the `co_await`. +AST_MATCHER_P(CoawaitExpr, awaiatable, ast_matchers::internal::Matcher, + InnerMatcher) { +

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-11-21 Thread Alan Phipps via Phabricator via cfe-commits
alanphipps added a comment. In D138846#4657152 , @glandium wrote: > In D138846#4656607 , @glandium > wrote: > >> Code built with older versions of LLVM (e.g. rust) and running with the >> updated runtime crash a

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -52,27 +52,41 @@ AST_MATCHER_P(Stmt, forEachPrevStmt, ast_matchers::internal::Matcher, } return IsHostile; } + +// Matches the expression awaited by the `co_await`. +AST_MATCHER_P(CoawaitExpr, awaiatable, ast_matchers::internal::Matcher, + InnerMatcher) { +

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -94,5 +108,7 @@ void CoroutineHostileRAIICheck::storeOptions( ClangTidyOptions::OptionMap &Opts) { Options.store(Opts, "RAIITypesList", utils::options::serializeStringList(RAIITypesList)); + Options.store(Opts, "SafeAwaitableList", Pio

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -52,27 +52,41 @@ AST_MATCHER_P(Stmt, forEachPrevStmt, ast_matchers::internal::Matcher, } return IsHostile; } + +// Matches the expression awaited by the `co_await`. +AST_MATCHER_P(CoawaitExpr, awaiatable, ast_matchers::internal::Matcher, + InnerMatcher) { +

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Overall looks +- fine for me. Wait like 1-2 weeks before merging if someone got some more comments. https://github.com/llvm/llvm-project/pull/72954 ___ cfe-commits mailing list cfe-commits@lists.l

[clang-tools-extra] [llvm] [clang] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE requested changes to this pull request. While this commit may fix some of the false negatives, it is introducing a very general and (if I understood it correctly) semantically incorrect modeling step, so I don't think that it can be merged. The first issue is that

[llvm] [clang] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-21 Thread Valery Pykhtin via cfe-commits
@@ -2314,9 +2314,8 @@ void AMDGPUDAGToDAGISel::SelectBRCOND(SDNode *N) { SDValue VCMP = Cond->getOperand(0); auto CC = cast(Cond->getOperand(2))->get(); auto *CRHS = dyn_cast(Cond->getOperand(1)); -if ((CC == ISD::SETEQ || CC == ISD::SETNE) && CRHS && CRHS->isZe

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/70476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/70476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

2023-11-21 Thread via cfe-commits
@@ -420,6 +449,35 @@ let TargetGuard = "sve,bf16" in { def SVSTNT1_VNUM_BF : MInst<"svstnt1_vnum[_{d}]", "vPpld", "b", [IsStore], MemEltTyDefault, "aarch64_sve_stnt1">; } +let TargetGuard = "sve2p1" in { + // Contiguous truncating store from quadword (single vector). + de

[llvm] [clang] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

2023-11-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/70474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

2023-11-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/70474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -349,6 +358,36 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + { + R"cpp( +namespace

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -499,17 +473,64 @@ class DefineOutline : public Tweak { HeaderUpdates = HeaderUpdates.merge(*DelInline); } -auto HeaderFE = Effect::fileEdit(SM, SM.getMainFileID(), HeaderUpdates); -if (!HeaderFE) - return HeaderFE.takeError(); - -Effect->ApplyEdi

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -19,7 +19,7 @@ TWEAK_TEST(DefineOutline); TEST_F(DefineOutlineTest, TriggersOnFunctionDecl) { FileName = "Test.cpp"; - // Not available unless in a header file. + // Not available for free function unless in a header file. kadircet wrote: well, availab

[clang] [llvm] [AArch64] Add SVE2.1 intrinsics for indexed quadword gather loads and scatter stores (PR #70476)

2023-11-21 Thread Momchil Velikov via cfe-commits
@@ -420,6 +449,35 @@ let TargetGuard = "sve,bf16" in { def SVSTNT1_VNUM_BF : MInst<"svstnt1_vnum[_{d}]", "vPpld", "b", [IsStore], MemEltTyDefault, "aarch64_sve_stnt1">; } +let TargetGuard = "sve2p1" in { + // Contiguous truncating store from quadword (single vector). + de

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/72985 >From ca3aef11b57e3c1ee9d04061064867dfbece8bef Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 21 Nov 2023 14:25:57 + Subject: [PATCH] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/72987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme ready_for_review https://github.com/llvm/llvm-project/pull/72985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes We never need to access entries from these maps outside of the current basic block. This could only ever become a consideration when flow control happens inside a full-expression (i.e. we have multiple basic bloc

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes We never need to access entries from these maps outside of the current basic block. This could only ever become a consideration when flow control happens inside a full-expression (i.e. we have multiple b

[clang] 9cd617c - [clang] Fix lit test failure caused by https://github.com/llvm/llvm-project/pull/70762 (#72928)

2023-11-21 Thread via cfe-commits
Author: smanna12 Date: 2023-11-21T06:37:47-08:00 New Revision: 9cd617c5dc5c082fb64c3436bb6b0d46088d8ac1 URL: https://github.com/llvm/llvm-project/commit/9cd617c5dc5c082fb64c3436bb6b0d46088d8ac1 DIFF: https://github.com/llvm/llvm-project/commit/9cd617c5dc5c082fb64c3436bb6b0d46088d8ac1.diff LOG:

[clang] [clang] Fix lit test failure caused by https://github.com/llvm/llvm-project/pull/70762 (PR #72928)

2023-11-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/72928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

2023-11-21 Thread Erich Keane via cfe-commits
@@ -91,10 +140,19 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = getOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
martinboehme wrote: The clang-format check is failing on code that this PR does not touch. To avoid touching unrelated code, I suggest not fixing the issue reported by clang-format. https://github.com/llvm/llvm-project/pull/72985 ___ cfe-commits mail

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
martinboehme wrote: After some internal discussion with @ymand, I think I'd like to retract this PR in favor of https://github.com/llvm/llvm-project/pull/72985. I will still keep this PR open for the time being however, until we've resolved the discussion. https://github.com/llvm/llvm-project

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [clang][dataflow] Clear `ExprToLoc` and `ExprToVal` at the start of a block. (PR #72985)

2023-11-21 Thread via cfe-commits
@@ -257,7 +257,12 @@ class JoinedStateBuilder { // initialize the state of each basic block differently. return {AC.Analysis.typeErasedInitialElement(), AC.InitEnv.fork()}; if (All.size() == 1) - return Owned.empty() ? All.front()->fork() : std::move(Owned.

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Joseph Huber via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

2023-11-21 Thread Alexey Bataev via cfe-commits
@@ -91,10 +140,19 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = getOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

2023-11-21 Thread Erich Keane via cfe-commits
@@ -91,10 +140,19 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = getOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Alexey Bataev via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [clang-tools-extra] [libcxx] [compiler-rt] [llvm] [libc] [flang] [AMDGPU] - Add constant folding to s_wqm intrinsic (PR #72382)

2023-11-21 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle approved this pull request. LGTM w/ a squash. BTW, I'm not a fan of merge commits in PRs. I find it makes it more confusing to review. https://github.com/llvm/llvm-project/pull/72382 ___ cfe-commits mailing list cfe-commit

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

2023-11-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72916 >From 5bdbe165e73eea4c01d0a02dec33afdd752a1858 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 20 Nov 2023 13:07:55 -0800 Subject: [PATCH 1/2] [OpenACC] Implement enter data/exit data construct parsing

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [OpenACC] Implement enter data/exit data construct parsing (PR #72916)

2023-11-21 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/72916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [lld] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld @llvm/pr-subscribers-clang Author: Saiyedul Islam (saiislam) Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata --- Patch is 1.95 MiB, truncated to 20.00 KiB below, full vers

[clang] [lld] [mlir] [llvm] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Saiyedul Islam (saiislam) Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata --- Patch is 1.95 MiB, truncated to 20.00 KiB below, full version: https://gi

[mlir] [lld] [clang] [llvm] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Saiyedul Islam (saiislam) Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata --- Patch is 1.95 MiB, truncated to 20.00 KiB below, full version: https://github.

[mlir] [lld] [clang] [llvm] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread Joseph Huber via cfe-commits
@@ -88,7 +88,7 @@ class TargetOptions { COV_5 = 500, }; /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_5; j

[clang] 49f0070 - [clang][dataflow] Remove deprecated synonyms from `Environment`. (#72987)

2023-11-21 Thread via cfe-commits
Author: martinboehme Date: 2023-11-21T16:01:04+01:00 New Revision: 49f0070237709a979905d8fe823f47a1b0ebd8ee URL: https://github.com/llvm/llvm-project/commit/49f0070237709a979905d8fe823f47a1b0ebd8ee DIFF: https://github.com/llvm/llvm-project/commit/49f0070237709a979905d8fe823f47a1b0ebd8ee.diff

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/72987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2023-11-21 Thread Paul T Robinson via cfe-commits
pogo59 wrote: The psABI doesn't say anything about function alignment, implying that align(1) is functionally correct, and anything more than that is either an optimization or functional dependency for our target. So, if we depend on anything more, we have to set alignment explicitly. @FlameT

[clang] [flang] [flang] Add runtimes using --dependent-lib on MSVC targets (PR #72519)

2023-11-21 Thread David Truby via cfe-commits
DavidTruby wrote: Yes, these are checking the invocation of the frontend driver https://github.com/llvm/llvm-project/pull/72519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[mlir] [clang] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

2023-11-21 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/72979 >From ffc1922935f6c5e9fc66db7fcce72ad0f5d8bef8 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Tue, 21 Nov 2023 13:50:33 + Subject: [PATCH] [llvm][TypeSize] Fix addition/subtraction in TypeSize.

[clang] [llvm] [mlir] [llvm][TypeSize] Consider TypeSize of '0' to be fixed/scalable-agnostic. (PR #72994)

2023-11-21 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/72994 >From ffc1922935f6c5e9fc66db7fcce72ad0f5d8bef8 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Tue, 21 Nov 2023 13:50:33 + Subject: [PATCH 1/2] [llvm][TypeSize] Fix addition/subtraction in TypeSiz

[openmp] [clang] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[libc] [compiler-rt] [clang] [flang] [clang-tools-extra] [libcxx] [llvm] [AMDGPU] - Add constant folding to s_wqm intrinsic (PR #72382)

2023-11-21 Thread Jessica Del via cfe-commits
OutOfCache wrote: > LGTM w/ a squash. > > BTW, I'm not a fan of merge commits in PRs. I find it makes it more confusing > to review. Understandable. I just tried using the website UI instead of rebasing for the minor merge conflict with the other PRs. Will avoid them in the future. https://g

[openmp] [clang] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Alexey Bataev via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[flang] [mlir] [lld] [clang-tools-extra] [clang] [llvm] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72954 >From c863646669d0b2b54e1c1c353b063a8209730528 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 21 Nov 2023 06:51:48 +0100 Subject: [PATCH 01/13] [clangtidy]Allow safe suspensions in coroutine-hostile-raii

[clang] [mlir] [llvm] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

2023-11-21 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/72979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-21 Thread Valery Pykhtin via cfe-commits
https://github.com/vpykhtin updated https://github.com/llvm/llvm-project/pull/71556 >From 526c635b3f70fd779f0919c5c40acd017a0f800e Mon Sep 17 00:00:00 2001 From: Valery Pykhtin Date: Mon, 20 Nov 2023 15:22:16 +0100 Subject: [PATCH] add instcombine rule --- .../CodeGenOpenCL/builtins-amdgcn-wa

[clang] [mlir] [llvm] [llvm][TypeSize] Consider TypeSize of '0' to be fixed/scalable-agnostic. (PR #72994)

2023-11-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 49f0070237709a979905d8fe823f47a1b0ebd8ee 674ade1adf2f66d81c8bf940479798a78ab32cb8 --

[clang] [llvm] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-21 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: - Undo the assert per Jay's comment for -O0 mode. - Restored the original test and added runs with opt to it. https://github.com/llvm/llvm-project/pull/71556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [mlir] [llvm] [llvm][TypeSize] Consider TypeSize of '0' to be fixed/scalable-agnostic. (PR #72994)

2023-11-21 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: > TypeSize::Scalable(0) + TypeSize::Fixed(4) == TypeSize::Fixed(4) >From the [docs](https://llvm.org/docs/LangRef.html#t-vector) > The number of elements is a constant integer value larger than 0; elementtype > may be any integer, floating-point or pointer type. Vectors o

[libunwind] [libunwind] Remove unnecessary dependencies on fprintf and stdio.h for increased baremetal friendliness (PR #72040)

2023-11-21 Thread Louis Dionne via cfe-commits
ldionne wrote: The CI issues are flakes (we just made major changes to our infrastructure and we're still adjusting). I think this is good to go. https://github.com/llvm/llvm-project/pull/72040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Alexey Bataev via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[flang] [clang] [flang] Add runtimes using --dependent-lib on MSVC targets (PR #72519)

2023-11-21 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/72519 >From eeb1e7c7b7905d541c9359bd1800fdfb70f0219e Mon Sep 17 00:00:00 2001 From: David Truby Date: Thu, 16 Nov 2023 14:32:27 + Subject: [PATCH 1/2] [flang] Add runtimes using --dependent-lib on MSVC targets

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
DonatNagyE wrote: In fact, as I think about this, I realized that it's probably a bad idea to perform "initialization" for each `va_list` variable in a `check::PreStmt` callback -- e.g. because in theory the programmer could write code like ``` void f(int fst, ...) { va_list *pva = (va_list

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

2023-11-21 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > We're already assigning names to the different scopes; we're just doing it in > the `__MEMORY_SCOPE_*` preprocessor macros. Replacing `_MEMORY_SCOPE_SYSTEM` > in the code with `"system"` doesn't really change the nature of how we assign > names to scopes. > > If these are sup

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Alexey Bataev via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[llvm] [mlir] [clang] [lld] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread Saiyedul Islam via cfe-commits
@@ -88,7 +88,7 @@ class TargetOptions { COV_5 = 500, }; /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_5; s

[llvm] [clang] [mlir] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

2023-11-21 Thread Guillaume Chatelet via cfe-commits
gchatelet wrote: The static functions renaming is going to produce a lot of noise but I guess this is too late already... Shall we revert to keep the change minimal? @nikic @paulwalker-arm WDYT ? https://github.com/llvm/llvm-project/pull/72979 ___ cf

[clang] [llvm] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-11-21 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/69559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [mlir] [llvm] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Assuming all the tests pass, this LG and has been a long time coming. Thanks for working on this. https://github.com/llvm/llvm-project/pull/73000 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [openmp] [Clang][OpenMP] Fix ordering of processing of map clauses when mapping a struct. (PR #72410)

2023-11-21 Thread Gheorghe-Teodor Bercea via cfe-commits
@@ -7731,10 +7731,30 @@ class MappableExprsHandler { IsImplicit, Mapper, VarRef, ForDeviceAddr); }; +// Sort all map clauses and make sure all the maps containing array +// sections are processed last. +llvm::SmallVector SortedMapClauses;

[llvm] [clang] [mlir] [llvm][TypeSize] Fix addition/subtraction in TypeSize. (PR #72979)

2023-11-21 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm approved this pull request. It looks like there's a code formatter issue with the MLIR change but otherwise this looks good to me. https://github.com/llvm/llvm-project/pull/72979 ___ cfe-commits mailing list cfe-commi

<    1   2   3   4   >