https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/70429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher approved this pull request.
LGTM. Thank you.
https://github.com/llvm/llvm-project/pull/72221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher closed https://github.com/llvm/llvm-project/pull/71887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jh7370 approved this pull request.
Are there any options that expect 2+ values (i.e. something that would give a
different response to "expected 1 value(s)"? If so, it might be worth switching
one of the cases for that one, just for additional bonus coverage without
addition
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/71371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/71371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -461,3 +461,8 @@
// DRIVER-PASS-INCLUDES: "-cc1" {{.*}}"-resource-dir" "[[RESOURCE:[^"]+]]"
// DRIVER-PASS-INCLUDES-SAME: "-internal-isystem"
"[[RESOURCE]]{{/|}}include"
// DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-externc-isystem"
"{{.*}}/usr/include"
+
+// Che
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/71371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Fangrui Song
Date: 2023-11-14T00:43:40-08:00
New Revision: 47297775347cbdb7624d6a766c2a3eec4a59
URL:
https://github.com/llvm/llvm-project/commit/47297775347cbdb7624d6a766c2a3eec4a59
DIFF:
https://github.com/llvm/llvm-project/commit/47297775347cbdb7624d6a766c2a3eec4a59.diff
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/72221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ecnelises created
https://github.com/llvm/llvm-project/pull/72230
Fixes #72198
>From 0b74141dec486989f75f4c361e8b950b869f7a1e Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Tue, 14 Nov 2023 16:20:42 +0800
Subject: [PATCH] [Sema] Check nullness of captured type before use
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qiu Chaofan (ecnelises)
Changes
Fixes #72198
---
Full diff: https://github.com/llvm/llvm-project/pull/72230.diff
2 Files Affected:
- (modified) clang/lib/Sema/SemaExpr.cpp (+2)
- (modified) clang/test/SemaCXX/lambda-invalid-capture.cp
zyn0217 wrote:
Could you please explain why the `CaptureType` might be null at the time when
exercising `tryCaptureVariable`? I'm worried that doing so would hide a more
significant issue.
https://github.com/llvm/llvm-project/pull/72230
___
cfe-commi
https://github.com/Fznamznon commented:
LGTM, but someone else must approve. I added more folks for visibility.
https://github.com/llvm/llvm-project/pull/71696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
statham-arm wrote:
> my only concern is to make sure we don't unintentionally make it harder to
> integrate potential future extensions such as the mutually dependent groups.
Hmmm. So if you had both ME and MD groups, you might also need a _group_ to be
able to be a member of another group? Th
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Author: Balázs Kéri
Date: 2023-11-14T10:58:05+01:00
New Revision: 41fe5c9a08f585a548ccf917804d67c79abcd3c3
URL:
https://github.com/llvm/llvm-project/commit/41fe5c9a08f585a548ccf917804d67c79abcd3c3
DIFF:
https://github.com/llvm/llvm-project/commit/41fe5c9a08f585a548ccf917804d67c79abcd3c3.diff
L
https://github.com/balazske closed
https://github.com/llvm/llvm-project/pull/71373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72234
This patch adds the LLVM-side infrastructure to implement DWARFv5 issue
161118.1: "DW_TAG for C++ static data members".
The clang-side of this patch will simply construct the DIDerivedType with a
different D
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72235
This patch implements the DWARFv5 issue
161118.1: "DW_TAG for C++ static data members".
This will simplify LLDB's handling of static data
members greatly in the long term since we no longer need to differentia
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
This patch adds the LLVM-side infrastructure to implement DWARFv5 issue
161118.1: "DW_TAG for C++ static data members".
The clang-side of this patch will simply construct the DIDerivedType with a
differe
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Michael Buch (Michael137)
Changes
This patch implements the DWARFv5 issue
161118.1: "DW_TAG for C++ static data members".
This will simplify LLDB's handling of static data
members greatly in the long term since we no longer need to
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tomekpaszek updated
https://github.com/llvm/llvm-project/pull/70338
>From b5ba0b3fde2c6662e19dfdf96a787621ec767460 Mon Sep 17 00:00:00 2001
From: Tomek Paszek
Date: Sat, 11 Nov 2023 19:38:00 +0100
Subject: [PATCH 1/8] Added an option to ignore macro definitions.
---
clang/i
balazske wrote:
The functional change looks good but the reformatting should be put into a
separate change.
https://github.com/llvm/llvm-project/pull/72016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
arsenm added inline comments.
Comment at: llvm/lib/IR/CMakeLists.txt:84
Demangle
+ TransformUtils
+
This introduces a circular dependency between LLVMCore and TransformUtils.
Options are:
1. Move appendToUsed into Module
2. Don't bother with bitcode compati
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/70829
>From ac30780250875802d13450d17e6959f9e2ad3a70 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 31 Oct 2023 09:27:51 -0700
Subject: [PATCH 1/4] [clang] Fix false positive -Wmissing-field-initi
@@ -727,6 +734,38 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (hadError || VerifyOnly) {
// Do nothing
} else if (Init < NumInits) {
+ if (WarnIfMissing) {
+auto CheckAnonMember = [&](const FieldDecl *FD,
+
@@ -654,11 +655,17 @@ void InitListChecker::FillInEmptyInitForBase(
}
}
-void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field,
-const InitializedEntity &ParentEntity,
-
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH] [Flang][Clang] Add support for frame pointers in Flang
---
clang/includ
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (hadError || VerifyOnly) {
// Do nothing
} else if (Init < NumInits) {
Fznamznon wrote:
> Maybe consider changing the L674 condition to an ass
https://github.com/balazske created
https://github.com/llvm/llvm-project/pull/72242
Operators that are overloadable may be parsed as `CXXOperatorCallExpr` or as
`UnaryOperator` (or `BinaryOperator`). This depends on the context and can be
different if a similar construct is imported into an ex
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Balázs Kéri (balazske)
Changes
Operators that are overloadable may be parsed as `CXXOperatorCallExpr` or as
`UnaryOperator` (or `BinaryOperator`). This depends on the context and can be
different if a similar construct is imported into an
arsenm updated this revision to Diff 558095.
arsenm added a comment.
Drop bitcode auto upgrade handling
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141700/new/
https://reviews.llvm.org/D141700
Files:
clang/lib/CodeGen/Targets/AMDGPU.cpp
clang/test/CodeGenOpenCL/amdgpu-enqueue-ker
JohnyTheCarrot wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SamTebbs33 edited
https://github.com/llvm/llvm-project/pull/66525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SamTebbs33 approved this pull request.
Thanks Momchil. This looks good to me with a couple of questions. The tests are
comprehensive as well.
https://github.com/llvm/llvm-project/pull/66525
___
cfe-commits mailing list
cfe-commits@l
@@ -861,6 +861,12 @@ def AArch64stilp : SDNode<"AArch64ISD::STILP",
SDT_AArch64stilp, [SDNPHasChain,
def AArch64stnp : SDNode<"AArch64ISD::STNP", SDT_AArch64stnp, [SDNPHasChain,
SDNPMayStore, SDNPMemOperand]>;
def AArch64tbl : SDNode<"AArch64ISD::TBL", SDT_AArch64TBL>;
+
+de
@@ -9461,6 +9462,94 @@ bool AArch64InstrInfo::isReallyTriviallyReMaterializable(
return TargetInstrInfo::isReallyTriviallyReMaterializable(MI);
}
+MachineBasicBlock::iterator
+AArch64InstrInfo::probedStackAlloc(MachineBasicBlock::iterator MBBI,
SamTebbs33 wr
Author: Matthew Devereau
Date: 2023-11-14T11:27:41Z
New Revision: cc1244980b74f45a06e2002a33444ce757b577aa
URL:
https://github.com/llvm/llvm-project/commit/cc1244980b74f45a06e2002a33444ce757b577aa
DIFF:
https://github.com/llvm/llvm-project/commit/cc1244980b74f45a06e2002a33444ce757b577aa.diff
L
https://github.com/MDevereau closed
https://github.com/llvm/llvm-project/pull/71795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Radu2k updated
https://github.com/llvm/llvm-project/pull/72146
>From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001
From: Radu2k
Date: Mon, 13 Nov 2023 17:49:06 +
Subject: [PATCH 1/2] [Flang][Clang] Add support for frame pointers in Flang
---
clang/in
@@ -4825,6 +4827,113 @@ SDValue AArch64TargetLowering::getPStateSM(SelectionDAG
&DAG, SDValue Chain,
Mask);
}
+// Lower an SME LDR/STR ZA intrinsic to LDR_ZA_PSEUDO or STR_ZA.
+// Case 1: If the vector number (vecnum) is an immediate in range, it gets
+//
https://github.com/tblah approved this pull request.
LGTM with Andrzej's comments
https://github.com/llvm/llvm-project/pull/72121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/72243
None
>From 0a5cc373736f6c9e29f4f8af438d37dd007f09e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 14 Nov 2023 12:42:03 +0100
Subject: [PATCH] [clang][Interp] Implement __builtin_clrsb
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/72243.diff
2 Files Affected:
- (modified) clang/lib/AST/Interp/InterpBuiltin.cpp (+16)
- (modified) clang/test/AST/Interp/builtin-functions.cpp (+
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 65eaa9e01bcd32dccf1e0c9bd3f2bdd3e53ccb2a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH 1/3] [clang-tidy] Improved readabil
https://github.com/daniel-grumberg closed
https://github.com/llvm/llvm-project/pull/71753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: QuietMisdreavus
Date: 2023-11-14T11:46:12Z
New Revision: 63537872aefe845ba40770112d0a2cf0927f27b8
URL:
https://github.com/llvm/llvm-project/commit/63537872aefe845ba40770112d0a2cf0927f27b8
DIFF:
https://github.com/llvm/llvm-project/commit/63537872aefe845ba40770112d0a2cf0927f27b8.diff
LO
https://github.com/tomekpaszek updated
https://github.com/llvm/llvm-project/pull/70338
>From b5ba0b3fde2c6662e19dfdf96a787621ec767460 Mon Sep 17 00:00:00 2001
From: Tomek Paszek
Date: Sat, 11 Nov 2023 19:38:00 +0100
Subject: [PATCH 1/9] Added an option to ignore macro definitions.
---
clang/i
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/72246
This was creating discrepancy in cases where we might have a physical
file entry (e.g. because we followed a source location from a stdlib
file) and tried to find its exporters.
From 49ea3ae3468c5d67b2b6b03339d
@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() {
OutStreamer->popSection();
}
+static uint32_t getProductVersion(Module &M) {
+ if (auto *VersionVal = cast_or_null(
+ M.getModuleFlag("zos_product_major_version")))
+return cast(VersionVal->getVa
@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() {
OutStreamer->popSection();
}
+static uint32_t getProductVersion(Module &M) {
+ if (auto *VersionVal = cast_or_null(
+ M.getModuleFlag("zos_product_major_version")))
+return cast(VersionVal->getVa
https://github.com/uweigand edited
https://github.com/llvm/llvm-project/pull/68926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() {
OutStreamer->popSection();
}
+static uint32_t getProductVersion(Module &M) {
+ if (auto *VersionVal = cast_or_null(
+ M.getModuleFlag("zos_product_major_version")))
+return cast(VersionVal->getVa
@@ -1026,6 +1030,78 @@ void SystemZAsmPrinter::emitADASection() {
OutStreamer->popSection();
}
+static uint32_t getProductVersion(Module &M) {
+ if (auto *VersionVal = cast_or_null(
+ M.getModuleFlag("zos_product_major_version")))
+return cast(VersionVal->getVa
@@ -976,6 +976,40 @@ void CodeGenModule::Release() {
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
getModule().addModuleFlag(llvm::Module::Error, "wchar_size", WCharWidth);
+ if (getTriple().isOSzOS()) {
+getModule().addModuleFlag(llvm::Modu
https://github.com/uweigand commented:
Please find a couple of additional comments inline, related to module flag
processing.
https://github.com/llvm/llvm-project/pull/68926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
artagnon wrote:
Gentle ping.
https://github.com/llvm/llvm-project/pull/71399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/72251
Fixed #69610.
>From 8e61a470fc7e4cf11a6cf285668a7f9eca72702c Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 14 Nov 2023 05:05:14 -0800
Subject: [PATCH] [clang-format] Handle constrained auto in QualifierAlign
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixed #69610.
---
Full diff: https://github.com/llvm/llvm-project/pull/72251.diff
2 Files Affected:
- (modified) clang/lib/Format/QualifierAlignmentFixer.cpp (+5)
- (modified) clang/unittests/Format/Qua
https://github.com/rymiel approved this pull request.
A hooray for getting rid of invalid-code-generation
https://github.com/llvm/llvm-project/pull/72251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -10088,9 +10088,13 @@ static bool allowAmbiguity(ASTContext &Context, const
FunctionDecl *F1,
const FunctionDecl *F2) {
if (declaresSameEntity(F1, F2))
return true;
- if (F1->isTemplateInstantiation() && F2->isTemplateInstantiation() &&
-
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SamTebbs33 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10088,9 +10088,13 @@ static bool allowAmbiguity(ASTContext &Context, const
FunctionDecl *F1,
const FunctionDecl *F2) {
if (declaresSameEntity(F1, F2))
return true;
- if (F1->isTemplateInstantiation() && F2->isTemplateInstantiation() &&
-
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/72213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10088,9 +10088,13 @@ static bool allowAmbiguity(ASTContext &Context, const
FunctionDecl *F1,
const FunctionDecl *F2) {
if (declaresSameEntity(F1, F2))
return true;
- if (F1->isTemplateInstantiation() && F2->isTemplateInstantiation() &&
-
https://github.com/GkvJwa updated
https://github.com/llvm/llvm-project/pull/71564
>From c014adafc88625e1f513494400f74a155f344cd4 Mon Sep 17 00:00:00 2001
From: GkvJwa
Date: Wed, 8 Nov 2023 01:37:19 +0800
Subject: [PATCH] Supports viewing class member in lambda when using the vs
debugger
Use "
https://github.com/SamTebbs33 approved this pull request.
Looks good to me :+1:
https://github.com/llvm/llvm-project/pull/68993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thyecust created
https://github.com/llvm/llvm-project/pull/72257
We can simplify this function and move some calculations out of loop.
>From 52b0204fec8394f9c2cfaeb3cc4f28e5d4c16170 Mon Sep 17 00:00:00 2001
From: thyecust
Date: Tue, 14 Nov 2023 21:51:55 +0800
Subject: [PATCH
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: thyecust (thyecust)
Changes
We can simplify this function and move some calculations out of loop.
---
Full diff: https://github.com/llvm/llvm-project/pull/72257.diff
1 Files Affected:
- (modified) clang/lib/Analysis/ReachableCode.cpp (+
https://github.com/GkvJwa updated
https://github.com/llvm/llvm-project/pull/71564
>From 60fca5e4300aa88f18daa53f86b56a764834515a Mon Sep 17 00:00:00 2001
From: GkvJwa
Date: Wed, 8 Nov 2023 01:37:19 +0800
Subject: [PATCH] Supports viewing class member in lambda when using the vs
debugger
Use "
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff daddf402d9a4e3bacc37098d990e56dc9957ca3e
52b0204fec8394f9c2cfaeb3cc4f28e5d4c16170 --
https://github.com/thyecust updated
https://github.com/llvm/llvm-project/pull/72257
>From 52b0204fec8394f9c2cfaeb3cc4f28e5d4c16170 Mon Sep 17 00:00:00 2001
From: thyecust
Date: Tue, 14 Nov 2023 21:51:55 +0800
Subject: [PATCH 1/2] Update ReachableCode.cpp
---
clang/lib/Analysis/ReachableCode.c
@@ -23,3 +23,9 @@ int pr43080(int i) { // expected-note {{declared here}}
i; // expected-error {{variable 'i' cannot be implicitly captured in a
lambda with no capture-default specified}}
}();
}
+
+void pr72198() {
+ int [_, b] = {0, 0}; // expected-error{{decompositi
https://github.com/thyecust updated
https://github.com/llvm/llvm-project/pull/72257
>From 52b0204fec8394f9c2cfaeb3cc4f28e5d4c16170 Mon Sep 17 00:00:00 2001
From: thyecust
Date: Tue, 14 Nov 2023 21:51:55 +0800
Subject: [PATCH 1/3] Update ReachableCode.cpp
---
clang/lib/Analysis/ReachableCode.c
@@ -129,7 +129,13 @@ class ByteCodeExprGen : public
ConstStmtVisitor, bool>,
/// Classifies a type.
std::optional classify(const Expr *E) const {
-return E->isGLValue() ? PT_Ptr : classify(E->getType());
+if (E->isGLValue()) {
+ if (E->getType()->isFunctionTy
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/70663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, lol, yes, everything is possible in C. :-D
https://github.com/llvm/llvm-project/pull/70587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
AaronBallman wrote:
> * @AaronBallman Having a nullptr init capture seems fishy, do we actually
> mean to allow capturing vla by reference here?
That does seem fishy to me -- I would expect VLA to behave the same as a
constant-size array in terms of what we capture. So I think we do want to
c
@@ -129,7 +129,13 @@ class ByteCodeExprGen : public
ConstStmtVisitor, bool>,
/// Classifies a type.
std::optional classify(const Expr *E) const {
-return E->isGLValue() ? PT_Ptr : classify(E->getType());
+if (E->isGLValue()) {
+ if (E->getType()->isFunctionTy
@@ -129,7 +129,13 @@ class ByteCodeExprGen : public
ConstStmtVisitor, bool>,
/// Classifies a type.
std::optional classify(const Expr *E) const {
-return E->isGLValue() ? PT_Ptr : classify(E->getType());
+if (E->isGLValue()) {
+ if (E->getType()->isFunctionTy
https://github.com/AaronBallman approved this pull request.
LGTM with unrelated changes pulled; I'm fine landing this PR after landing the
fix for the function pointer classification changes if necessary.
https://github.com/llvm/llvm-project/pull/70763
__
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
Yes, please. :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148474/new/
https://reviews.llvm.org/D148474
___
cfe-commits mailing list
cfe-comm
https://github.com/DavidTruby approved this pull request.
LGTM with a few small comments. Please wait for @jeanPerier to approve before
merging.
https://github.com/llvm/llvm-project/pull/70917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
@@ -13,6 +13,44 @@
#include "flang/Runtime/command.h"
#include "flang/Runtime/descriptor.h"
#include "flang/Runtime/io-api.h"
+#include
DavidTruby wrote:
We should use `cstring` instead of `string.h` and make sure all C standard
functions are prefixed with `
@@ -13,6 +13,44 @@
#include "flang/Runtime/command.h"
#include "flang/Runtime/descriptor.h"
#include "flang/Runtime/io-api.h"
+#include
+
+#ifdef _WIN32
+#define WIN32_LEAN_AND_MEAN
+#define NOMINMAX
+#include
+
+#include // UNLEN=256
+#include // wcstombs_s
---
@@ -37,5 +75,19 @@ void FORTRAN_PROCEDURE_NAME(getarg)(
(void)RTNAME(GetCommandArgument)(
n, &value, nullptr, nullptr, __FILE__, __LINE__);
}
+
+void FORTRAN_PROCEDURE_NAME(getlog)(std::int8_t *arg, std::int64_t length) {
+ std::array str;
+ int error = getlogin_r(str
@@ -37,5 +75,19 @@ void FORTRAN_PROCEDURE_NAME(getarg)(
(void)RTNAME(GetCommandArgument)(
n, &value, nullptr, nullptr, __FILE__, __LINE__);
}
+
+void FORTRAN_PROCEDURE_NAME(getlog)(std::int8_t *arg, std::int64_t length) {
+ std::array str;
+ int error = getlogin_r(str
https://github.com/DavidTruby edited
https://github.com/llvm/llvm-project/pull/70917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidTruby approved this pull request.
LGTM, maybe wait for @jeanPerier to check as well though. Thanks!
https://github.com/llvm/llvm-project/pull/71222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -99,6 +99,9 @@ FEATURE(memory_sanitizer,
FEATURE(thread_sanitizer, LangOpts.Sanitize.has(SanitizerKind::Thread))
FEATURE(dataflow_sanitizer, LangOpts.Sanitize.has(SanitizerKind::DataFlow))
FEATURE(scudo, LangOpts.Sanitize.hasOneOf(SanitizerKind::Scudo))
+FEATURE(swiftcc,
---
@@ -99,6 +99,9 @@ FEATURE(memory_sanitizer,
FEATURE(thread_sanitizer, LangOpts.Sanitize.has(SanitizerKind::Thread))
FEATURE(dataflow_sanitizer, LangOpts.Sanitize.has(SanitizerKind::DataFlow))
FEATURE(scudo, LangOpts.Sanitize.hasOneOf(SanitizerKind::Scudo))
+FEATURE(swiftcc,
---
1 - 100 of 404 matches
Mail list logo
