[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

qiucf added a comment. Hi, it seems rG086b65340cca2648a2a91a0a47d28c7d9bafd1e5 causes build failure: llvm-project/clang/lib/Basic/OpenMPKinds.cpp:444:13: error: 97 enumeration values not handled in switch: 'OMPC_adjust_arg

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

HighCommander4 wrote: This sounds like it might be the culprit behind https://github.com/clangd/clangd/issues/1358 https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. Only on ppc64 this error is being seen because it is expecting a default in the switch statement: OpenMPClauseKind CK = ... switch(CK) This is similar to what has been added in OMPClauseWithPreInit::get() { switch(C->getClauseKind()) { case ... default: } I am about t

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

https://github.com/arsenm requested changes to this pull request. https://github.com/llvm/llvm-project/pull/68932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/68932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

@@ -52,6 +52,11 @@ static cl::opt ForceEmitZeroFlag( cl::desc("Force all waitcnt instrs to be emitted as s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)"), cl::init(false), cl::Hidden); +static cl::opt +PreciseMemOpFlag("amdgpu-precise-memory-op", + cl::de

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

@@ -1809,6 +1816,23 @@ bool SIInsertWaitcnts::shouldFlushVmCnt(MachineLoop *ML, return HasVMemLoad && UsesVgprLoadedOutside; } +bool SIInsertWaitcnts::insertWaitcntAfterMemOp(MachineFunction &MF) { + bool Modified = false; + + for (auto &MBB : MF) { arsenm

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558051. koops added a comment. To avoid build error in ppc64 adding a "default" to switch statement. This is similar to the way it is currently handled in OMPClauseWithPreInit::get() { switch(C->getClauseKind()) { case ... default: } CHANG

[clang] [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses. (PR #68618)

https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/68618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c468e89 - [clang][Interp][NFC] Fix right shifting signed IntegralAP values

Author: Timm Bäder Date: 2023-11-08T09:33:37+01:00 New Revision: c468e8923cadfa4c181eaa8bdbcf8d95feb70132 URL: https://github.com/llvm/llvm-project/commit/c468e8923cadfa4c181eaa8bdbcf8d95feb70132 DIFF: https://github.com/llvm/llvm-project/commit/c468e8923cadfa4c181eaa8bdbcf8d95feb70132.diff LO

[llvm] [clang] [InstCombine] Infer zext nneg flag (PR #71534)

https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/71534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5918f62 - [InstCombine] Infer zext nneg flag (#71534)

Author: Nikita Popov Date: 2023-11-08T09:34:40+01:00 New Revision: 5918f62301788b53e7d3a23f3203c483e9d4d791 URL: https://github.com/llvm/llvm-project/commit/5918f62301788b53e7d3a23f3203c483e9d4d791 DIFF: https://github.com/llvm/llvm-project/commit/5918f62301788b53e7d3a23f3203c483e9d4d791.diff

[compiler-rt] [llvm] [clang] [Profile] Refactor profile correlation. (PR #70856)

petrhosek wrote: > > What I think would be a better design is to just omit the respective > > sections altogether when -debug-info-correlate/-profile-correlate= is > > enabled. > > I don't understand how this solves the problem you described above. Can you > elaborate a bit more? We still nee

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

https://github.com/pravinjagtap updated https://github.com/llvm/llvm-project/pull/71139 >From c28e9f9fb753e41bc539fa4c45bd7896d7c5d04d Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Fri, 3 Nov 2023 00:04:14 -0400 Subject: [PATCH 1/3] [AMDGPU] const-fold imm operands of amdgcn_update_dpp in

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

uabelho added a comment. In D123235#4656427 , @koops wrote: > To avoid build error in ppc64 adding a "default" to switch statement. I don't think it has anything particular to do with ppc64. I see the warning/error when i compile with clang 15 on a RHEL

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

tschuett wrote: It could also be a `surface BMI` as it only describes the surface of the module, but it does not contain its content. https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/71640 Enums without enumerators (empty) are now excluded from analysis as it's not possible to peroperly determinate new narrowed type, and such enums can be used in diffrent way, like as strong-types. Closes #71544

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Enums without enumerators (empty) are now excluded from analysis as it's not possible to peroperly determinate new narrowed type, and such enums can be used in diffrent way, like as strong-types. Close

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

PiotrZSL wrote: No release notes entry, as this check were added in this release. https://github.com/llvm/llvm-project/pull/71640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

uabelho added a comment. Btw, a bit confusing (to me at least) to reopen this review since it's already landed. Comment at: clang/lib/Basic/OpenMPKinds.cpp:450 +case OMPC_unknown: +default: + return "unknown"; Adding "default:" here silences the w

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

https://github.com/arsenm approved this pull request. Could probably golf this down for more sharing with the default path but this is a start https://github.com/llvm/llvm-project/pull/71139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

https://github.com/PiotrZSL requested changes to this pull request. Update release notes, and update pull request description. Except those two, looks fine for me. https://github.com/llvm/llvm-project/pull/71586 ___ cfe-commits mailing list cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/71640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

@@ -23,6 +23,10 @@ namespace clang::tidy::performance { namespace { +AST_MATCHER(EnumDecl, hasEnumerators) { + return Node.enumerator_begin() != Node.enumerator_end(); HerrCai0907 wrote: ```suggestion return !Node.enumerators().empty(); ``` https://githu

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

https://github.com/simpal01 edited https://github.com/llvm/llvm-project/pull/71545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/71640 >From eeacce5ffae9eca72484a7e51f9e55592fe4ca13 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 8 Nov 2023 09:02:54 + Subject: [PATCH 1/2] [clang-tidy] Improve performance-enum-size to exclude empty en

[clang] 32a3f2a - [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (#71139)

Author: Pravin Jagtap Date: 2023-11-08T15:09:10+05:30 New Revision: 32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c URL: https://github.com/llvm/llvm-project/commit/32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c DIFF: https://github.com/llvm/llvm-project/commit/32a3f2afe6ea7ffb02a6a188b123ded6f4c89f6c.diff

[clang] [AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (PR #71139)

https://github.com/pravinjagtap closed https://github.com/llvm/llvm-project/pull/71139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/68267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8c014e5949fdbecc31a82138361f8cdf886768a9 5fca3fdf781dc849db770975b9f7017b091cd112 --

[clang] [clang][Interp] Consider bit width in toAPSInt() (PR #71646)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71646 In `Interp.h`, when a add/sub/mul fails, we call this code and expect to get an `APSInt` back that can handle more than the current bitwidth of the type. >From a5a7c82862990475630a21d6aabb319acc6a80b2 Mon Sep 1

[clang] [clang][Interp] Consider bit width in toAPSInt() (PR #71646)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes In `Interp.h`, when a add/sub/mul fails, we call this code and expect to get an `APSInt` back that can handle more than the current bitwidth of the type. --- Full diff: https://github.com/llvm/llvm-project/p

[clang] [clang][Interp] Consider bit width in IntegralAP::toAPSInt() (PR #71646)

https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/71646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e6a94dc - [clang][Interp] Fix creating APSInt from IntegralAP (#71410)

Author: Timm Baeder Date: 2023-11-08T10:48:07+01:00 New Revision: e6a94dca38d77db2678366c55bb7b72cfa312487 URL: https://github.com/llvm/llvm-project/commit/e6a94dca38d77db2678366c55bb7b72cfa312487 DIFF: https://github.com/llvm/llvm-project/commit/e6a94dca38d77db2678366c55bb7b72cfa312487.diff L

[clang] [clang][Interp] Fix creating APSInt from IntegralAP (PR #71410)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/71410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/71640 >From f74559586a11455e2b4c1f2c63076c5c441c527b Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 8 Nov 2023 09:02:54 + Subject: [PATCH] [clang-tidy] Improve performance-enum-size to exclude empty enums

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

@@ -3197,6 +3197,26 @@ TEST(TransferTest, AggregateInitialization_NotExplicitlyInitializedField) { }); } +TEST(TransferTest, AggregateInitializationFunctionPointer) { + // This is a crash repro. martinboehme wrote: ```suggestion // This is a repro f

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement IntegralAP subtraction (PR #71648)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71648 The tests currently fail because they need one of the other open `IntegralAP` PRs. Will update this once they are pushed. >From 068feee9c34a8fc22675d17e257f166235a8803e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q

[clang] [clang][Interp] Implement IntegralAP subtraction (PR #71648)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The tests currently fail because they need one of the other open `IntegralAP` PRs. Will update this once they are pushed. --- Full diff: https://github.com/llvm/llvm-project/pull/71648.diff 2 Files Affect

[clang] a141a9f - Revert "[OpenMP] atomic compare fail : Parser & AST support"

Author: Mitch Phillips Date: 2023-11-08T11:20:17+01:00 New Revision: a141a9fa9706e939415a929a46b6f2f77cd56c55 URL: https://github.com/llvm/llvm-project/commit/a141a9fa9706e939415a929a46b6f2f77cd56c55 DIFF: https://github.com/llvm/llvm-project/commit/a141a9fa9706e939415a929a46b6f2f77cd56c55.diff

[clang-tools-extra] 3716b5b - [clang-tidy] Improve performance-enum-size to exclude empty enums (#71640)

Author: Piotr Zegar Date: 2023-11-08T11:22:31+01:00 New Revision: 3716b5b4bac6ab41291b6558ad0444cbcca04aa3 URL: https://github.com/llvm/llvm-project/commit/3716b5b4bac6ab41291b6558ad0444cbcca04aa3 DIFF: https://github.com/llvm/llvm-project/commit/3716b5b4bac6ab41291b6558ad0444cbcca04aa3.diff L

[clang-tools-extra] [clang-tidy] Improve performance-enum-size to exclude empty enums (PR #71640)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/71640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

ChuanqiXu9 wrote: The term `sparse` makes me wondering its format is not efficiency.. And for the term `surface`, ..., it may beyond my knowledge, I feel it is odd but I can't give a concrete reason. https://github.com/llvm/llvm-project/pull/71622 _

[clang-tools-extra] 2626916 - [clangd] Allow hover over 128-bit variable without crashing (#71415)

Author: Björn Pettersson Date: 2023-11-08T11:30:03+01:00 New Revision: 2626916c45f428226052f5e431e510743aba9e75 URL: https://github.com/llvm/llvm-project/commit/2626916c45f428226052f5e431e510743aba9e75 DIFF: https://github.com/llvm/llvm-project/commit/2626916c45f428226052f5e431e510743aba9e75.di

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

https://github.com/bjope closed https://github.com/llvm/llvm-project/pull/71415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix handling of functional cast in google-readability-casting (PR #71650)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/71650 Fix issue with constructor call being interpreted as functional cast and considered for a replacement with static cast or being removed as redundant. Closes #57959 >From b2da54fc89e99d3056ee80d47b8be2874916e02

[clang-tools-extra] [clang-tidy] Fix handling of functional cast in google-readability-casting (PR #71650)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Fix issue with constructor call being interpreted as functional cast and considered for a replacement with static cast or being removed as redundant. Closes #57959 --- Full diff: https://github.com/llv

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71653 There used to be a patch similar to this on Phabricator. I asked a long time ago if I can pick it up but the author told me they will work on it, which never happened. IIRC there also was a problem with this s

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes There used to be a patch similar to this on Phabricator. I asked a long time ago if I can pick it up but the author told me they will work on it, which never happened. IIRC there also was a problem with thi

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/71627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Fix stale comments. (PR #71654)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/71654 None >From 3e889b59ee171c1665b365a933ba3578c4135ed3 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Wed, 8 Nov 2023 10:51:50 + Subject: [PATCH] [clang][dataflow][NFC] Fix stale comments. --- clang

[clang] [clang][dataflow][NFC] Fix stale comments. (PR #71654)

llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71654.diff 1 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/Arena.h (+4-4) ``diff diff --git a/clang/incl

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

https://github.com/nvartolomei updated https://github.com/llvm/llvm-project/pull/71586 >From 0dbdbc35e9dd3f28f8688d8ebf91f977fda98c79 Mon Sep 17 00:00:00 2001 From: Nicolae Vartolomei Date: Tue, 7 Nov 2023 20:25:43 + Subject: [PATCH] [clang-tidy] readability-identifier-naming: add support f

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

https://github.com/nvartolomei edited https://github.com/llvm/llvm-project/pull/71586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

nvartolomei wrote: @PiotrZSL thank you for your time reviewing this change. I have updated the release notes and PR description. I'm new to this project and not familiar with its customs. Apologize for any mistakes. https://github.com/llvm/llvm-project/pull/71586 __

[clang] 8d72079 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-11-08T10:45:20Z New Revision: 8d72079077f8b8bf4a8d7173edbb09be083d975b URL: https://github.com/llvm/llvm-project/commit/8d72079077f8b8bf4a8d7173edbb09be083d975b DIFF: https://github.com/llvm/llvm-project/commit/8d72079077f8b8bf4a8d7173edbb09be083d975b.diff LOG:

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/71627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

https://github.com/ChuanqiXu9 ready_for_review https://github.com/llvm/llvm-project/pull/71627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:450 +case OMPC_unknown: +default: + return "unknown"; uabelho wrote: > Adding "default:" here silences the warning. > But looks like @ABataev commented on something similar earl

[clang] [C++20] [Modules] Introduce thin BMI (PR #71622)

ChuanqiXu9 wrote: Let's discuss the higher level problems in https://discourse.llvm.org/t/rfc-c-20-modules-introduce-thin-bmi-and-decls-hash/74755 https://github.com/llvm/llvm-project/pull/71622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/71627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [lldb] [flang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

https://github.com/markoshorro closed https://github.com/llvm/llvm-project/pull/71072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Bring Decls Hash to BMI for C++20 Module units (PR #71627)

ChuanqiXu9 wrote: Let's discuss the higher level problems in Let's discuss the higher level problems in https://discourse.llvm.org/t/rfc-c-20-modules-introduce-thin-bmi-and-decls-hash/74755. Especially this one is not good to review since we don't support stacked review now. https://github.c

[clang] Fix lit test clang/test/CodeGenHIP/dpp-const-fold.hip. added (PR #71656)

https://github.com/pravinjagtap created https://github.com/llvm/llvm-project/pull/71656 during #71139 -nogpulib was missing. >From 5adcc2a60aeb2d648b90a9f87009a93dde60a64e Mon Sep 17 00:00:00 2001 From: Pravin Jagtap Date: Wed, 8 Nov 2023 06:17:38 -0500 Subject: [PATCH] Fix lit test clang/tes

[clang] Fix lit test clang/test/CodeGenHIP/dpp-const-fold.hip. added (PR #71656)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Pravin Jagtap (pravinjagtap) Changes during #71139 -nogpulib was missing. --- Full diff: https://github.com/llvm/llvm-project/pull/71656.diff 1 Files Affected: - (modified) clang/test/CodeGenHIP/dpp-const-fold.hip (+1-1) ``d

[clang] Fix lit test clang/test/CodeGenHIP/dpp-const-fold.hip. added (PR #71656)

https://github.com/vikramRH approved this pull request. https://github.com/llvm/llvm-project/pull/71656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -O3 -emit-llvm %s -o - | FileCheck %s --check-pre

[llvm] [clang] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 \ +// RUN: -O3 -emit-llvm %s -o - | FileCheck %s --check-pre

[clang] [clang][Interp] Implement __builtin_parity (PR #71662)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71662 None >From a4a04d1ef43a680d9ced9d1cdd7db05cbc567436 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 8 Nov 2023 12:28:52 +0100 Subject: [PATCH] [clang][Interp] Implement __builtin_parity

[clang] [clang][Interp] Implement __builtin_parity (PR #71662)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71662.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/InterpBuiltin.cpp (+16) - (modified) clang/test/AST/Interp/builtin-functions.cpp (+

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

https://github.com/zyn0217 approved this pull request. I'd like to approve the patch boldly since the findTokenAfterCompletionPoint is mostly duplicated from `Lexer::findNextToken` except for a difference that our version calls `Loc.getLocWithOffset(1)` rather than MeasureTokenLength() for the

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

@@ -1491,6 +1491,46 @@ FuzzyFindRequest speculativeFuzzyFindRequestForCompletion( return CachedReq; } +// This function is similar to Lexer::findNextToken(), but assumes +// that the input SourceLocation is the completion point (which is +// a case findNextToken() does not

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Correctly identify the next token after the completion point (PR #69153)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

ChuanqiXu9 wrote: > > > Presumably there should only be one spelling everywhere. > > > > > > Done > > Missed a few. ;-) Sorry and thanks for the detailed comment! https://github.com/llvm/llvm-project/pull/71014 ___ cfe-commits mailing list cfe-comm

[clang] [llvm] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]] (PR #71014)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/71014 >From 4531d8b95ecaf08e672939a49fa18415851d136e Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 2 Nov 2023 11:11:59 +0800 Subject: [PATCH] [Coroutines] Introduce [[clang::coro_only_destroy_when_complete]]

[clang] [mlir] [llvm] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68565 >From de07976922782b9dcf5d13d44551b782dc8b3b94 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 01/10] [AArch64][SME] Remove immediate argument restriction for

[clang] d1fb930 - Revert "[AMDGPU] const-fold imm operands of amdgcn_update_dpp intrinsic (#71139)"

Author: Mitch Phillips Date: 2023-11-08T12:50:53+01:00 New Revision: d1fb9307951319eea3e869d78470341d603c8363 URL: https://github.com/llvm/llvm-project/commit/d1fb9307951319eea3e869d78470341d603c8363 DIFF: https://github.com/llvm/llvm-project/commit/d1fb9307951319eea3e869d78470341d603c8363.diff

[clang-tools-extra] ee03dc1 - Revert "[clangd] Allow hover over 128-bit variable without crashing (#71415)"

Author: Bjorn Pettersson Date: 2023-11-08T12:56:26+01:00 New Revision: ee03dc1836348420221f8830cae9868d3a51484c URL: https://github.com/llvm/llvm-project/commit/ee03dc1836348420221f8830cae9868d3a51484c DIFF: https://github.com/llvm/llvm-project/commit/ee03dc1836348420221f8830cae9868d3a51484c.di

[llvm] [clang] [SystemZ] Add backchain target-feature (PR #71668)

https://github.com/iii-i created https://github.com/llvm/llvm-project/pull/71668 GCC supports building individual functions with backchain using the __attribute__((target("backchain"))) syntax, and Clang should too. Clang translates this into the "target-features"="+backchain" attribute, and t

[llvm] [clang] [SystemZ] Add backchain target-feature (PR #71668)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Leoshkevich (iii-i) Changes GCC supports building individual functions with backchain using the __attribute__((target("backchain"))) syntax, and Clang should too. Clang translates this into the "target-features"="+backchain" attribut

[clang] Revert "Revert "[AMDGPU] const-fold imm operands of (PR #71669)

https://github.com/pravinjagtap created https://github.com/llvm/llvm-project/pull/71669 amdgcn_update_dpp intrinsic (#71139)"" This reverts commit d1fb9307951319eea3e869d78470341d603c8363 and fixes the lit test clang/test/CodeGenHIP/dpp-const-fold.hip >From 63f870074df10d0e2624632ac2ab0cb0996

[clang] Revert "Revert "[AMDGPU] const-fold imm operands of (PR #71669)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Pravin Jagtap (pravinjagtap) Changes amdgcn_update_dpp intrinsic (#71139)"" This reverts commit d1fb9307951319eea3e869d78470341d603c8363 and fixes the lit test clang/test/CodeGenHIP/dpp-const-fold.hip -

[clang] Fix lit test clang/test/CodeGenHIP/dpp-const-fold.hip. added (PR #71656)

https://github.com/pravinjagtap closed https://github.com/llvm/llvm-project/pull/71656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Print static_assert values of arithmetic binary operators (PR #71671)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71671 These are actually quite useful to print. >From 2b257a11a78db4769af6751dbc9bd2f37a2b4c71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 8 Nov 2023 13:32:41 +0100 Subject: [PATCH] [clang

[clang] [clang] Print static_assert values of arithmetic binary operators (PR #71671)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes These are actually quite useful to print. --- Full diff: https://github.com/llvm/llvm-project/pull/71671.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+4-4) - (modified) clang/test/S

[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)

https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/71672 Fixes http://llvm.org/PR55487 The code did not match the documentation about Cpp11BracedListStyle. Changed handling of comments after opening braces, which are supposedly function call like to behave

[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Björn Schäpers (HazardyKnusperkeks) Changes Fixes http://llvm.org/PR55487 The code did not match the documentation about Cpp11BracedListStyle. Changed handling of comments after opening braces, which are supposedly function call l

[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b44399296a7fa4323ab32739df6dbcfc6068af8f 4548aa1186531fb93a623144278fe72896d47e89 --

[llvm] [flang] [clang] [libc] [libunwind] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] Test pr (PR #71086)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/71086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SystemZ] Add backchain target-feature (PR #71668)

https://github.com/uweigand approved this pull request. LGTM. Thanks for taking care of this, Ilya! https://github.com/llvm/llvm-project/pull/71668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] 5e09c4e - [clang][NFC] Partially annotate `IdentifierInfo` with `preferred_type`

Author: Vlad Serebrennikov Date: 2023-11-08T15:44:46+03:00 New Revision: 5e09c4e6a865707ed26f9a893dbef8b499591459 URL: https://github.com/llvm/llvm-project/commit/5e09c4e6a865707ed26f9a893dbef8b499591459 DIFF: https://github.com/llvm/llvm-project/commit/5e09c4e6a865707ed26f9a893dbef8b499591459.

[clang-tools-extra] d5cfdca - [clangd] Allow hover over 128-bit variable without crashing (#71415)

Author: Björn Pettersson Date: 2023-11-08T14:13:11+01:00 New Revision: d5cfdcaacbd36d6c25011f03a4eb51137f7a804a URL: https://github.com/llvm/llvm-project/commit/d5cfdcaacbd36d6c25011f03a4eb51137f7a804a DIFF: https://github.com/llvm/llvm-project/commit/d5cfdcaacbd36d6c25011f03a4eb51137f7a804a.di

  1   2   3   4   5   >