@@ -56,26 +69,151 @@ class ReplCompletionConsumer : public CodeCompleteConsumer
{
std::shared_ptr CCAllocator;
CodeCompletionTUInfo CCTUInfo;
std::vector &Results;
+ ReplCodeCompleter &CC;
+};
+
+/*
+ The abstract class CompletionContextHandler contains four interfaces
@@ -56,26 +69,151 @@ class ReplCompletionConsumer : public CodeCompleteConsumer
{
std::shared_ptr CCAllocator;
CodeCompletionTUInfo CCTUInfo;
std::vector &Results;
+ ReplCodeCompleter &CC;
+};
+
+/*
+ The abstract class CompletionContextHandler contains four interfaces
@@ -159,29 +308,62 @@ void ExternalSource::completeVisibleDeclsMap(
for (auto *DeclCtxt = ParentTUDeclCtxt; DeclCtxt != nullptr;
DeclCtxt = DeclCtxt->getPreviousDecl()) {
for (auto &IDeclContext : DeclCtxt->decls()) {
- if (NamedDecl *Decl = llvm::dyn_cast(IDe
@@ -56,26 +69,151 @@ class ReplCompletionConsumer : public CodeCompleteConsumer
{
std::shared_ptr CCAllocator;
CodeCompletionTUInfo CCTUInfo;
std::vector &Results;
+ ReplCodeCompleter &CC;
+};
+
+/*
+ The abstract class CompletionContextHandler contains four interfaces
@@ -159,29 +308,62 @@ void ExternalSource::completeVisibleDeclsMap(
for (auto *DeclCtxt = ParentTUDeclCtxt; DeclCtxt != nullptr;
DeclCtxt = DeclCtxt->getPreviousDecl()) {
for (auto &IDeclContext : DeclCtxt->decls()) {
- if (NamedDecl *Decl = llvm::dyn_cast(IDe
@@ -56,26 +69,151 @@ class ReplCompletionConsumer : public CodeCompleteConsumer
{
std::shared_ptr CCAllocator;
CodeCompletionTUInfo CCTUInfo;
std::vector &Results;
+ ReplCodeCompleter &CC;
+};
+
+/*
+ The abstract class CompletionContextHandler contains four interfaces
@@ -155,10 +162,10 @@ class EmitAssemblyHelper {
return F;
}
- void
- RunOptimizationPipeline(BackendAction Action,
+ void RunOptimizationPipeline(BackendAction Action,
std::unique_ptr &OS,
- std::unique_ptr &ThinLin
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/71398
>From 1d54a5cc6b34aca0e34ab57d7ee62815707d9153 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Mon, 6 Nov 2023 08:54:40 -0500
Subject: [PATCH 1/3] [C23] Complete support for WG14 N2508
In Clang 16, we im
@@ -32,8 +32,8 @@ T tmain(T argc) {
}
switch (argc) {
#pragma omp error // expected-error {{ERROR}}
- case 1:
-#pragma omp error // expected-error {{ERROR}}
+ case 1: // FIXME: error without 'at execution' is not a stand-alone
directive and so this should be accepted.
--
@@ -48,428 +49,369 @@
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/YAMLTraits.h"
#include "llvm/Transforms/IPO/Internalize.h"
+#include "llvm/Transforms/Utils/Cloning.h"
-#include
#include
using namespace clang;
using namespace llvm;
#define DEBUG_T
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -29,12 +30,11 @@
_LIBCPP_BEGIN_NAMESPACE_STD
-template <
-typename _DifferenceType,
-typename _Tp,
-typename _BinaryOperation,
-typename _UnaryOperation,
-__enable_if_t<__is_trivial_plus_operation<_BinaryOperation, _Tp,
_Tp>::value && is_arithmetic_v<_
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
@@ -0,0 +1,29 @@
+//===-- LinkInModulesPass.cpp - Module Linking pass --- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Jon Roelofs
Date: 2023-11-06T11:10:59-08:00
New Revision: fa71f9e87aee87c899a6ed600c1748aeb1c1a05d
URL:
https://github.com/llvm/llvm-project/commit/fa71f9e87aee87c899a6ed600c1748aeb1c1a05d
DIFF:
https://github.com/llvm/llvm-project/commit/fa71f9e87aee87c899a6ed600c1748aeb1c1a05d.diff
L
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
@@ -0,0 +1,29 @@
+//===-- LinkInModulesPass.cpp - Module Linking pass --- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Vlad Serebrennikov
Date: 2023-11-06T22:17:03+03:00
New Revision: 60f7fa123d77ecf8e138be35ad8880622586fa03
URL:
https://github.com/llvm/llvm-project/commit/60f7fa123d77ecf8e138be35ad8880622586fa03
DIFF:
https://github.com/llvm/llvm-project/commit/60f7fa123d77ecf8e138be35ad8880622586fa03.
https://github.com/jhuber6 approved this pull request.
I'm not entirely happy with the existence of this hack, but it's an ugly
solution to an ugly self-inflicted problem, so I can live with it for now.
https://github.com/llvm/llvm-project/pull/69371
https://github.com/nico approved this pull request.
lg2m
https://github.com/llvm/llvm-project/pull/71321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniel Bertalan
Date: 2023-11-06T20:36:47+01:00
New Revision: 609fe2cb4b2037b546686d5f50c2f330dbca4111
URL:
https://github.com/llvm/llvm-project/commit/609fe2cb4b2037b546686d5f50c2f330dbca4111
DIFF:
https://github.com/llvm/llvm-project/commit/609fe2cb4b2037b546686d5f50c2f330dbca4111.dif
https://github.com/BertalanD closed
https://github.com/llvm/llvm-project/pull/71321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-11-06T22:39:26+03:00
New Revision: 565e21b3e079e53c4fcf47d2ec898dbc248fbd3a
URL:
https://github.com/llvm/llvm-project/commit/565e21b3e079e53c4fcf47d2ec898dbc248fbd3a
DIFF:
https://github.com/llvm/llvm-project/commit/565e21b3e079e53c4fcf47d2ec898dbc248fbd3a.
https://github.com/shafik created
https://github.com/llvm/llvm-project/pull/71435
As noted in this bug report: https://github.com/llvm/llvm-project/issues/37647
Due to this clang bug we added the template keyword in Redeclarable.h. The bug
has been fixed since then, so removing it.
>From a743
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shafik Yaghmour (shafik)
Changes
As noted in this bug report: https://github.com/llvm/llvm-project/issues/37647
Due to this clang bug we added the template keyword in Redeclarable.h. The bug
has been fixed since then, so removing it.
---
https://github.com/bcardosolopes commented:
Can you please add a testcase?
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Johannes Doerfert
Date: 2023-11-06T11:50:41-08:00
New Revision: abe71b77f9ac2fc689e899fa6aa2486120c53912
URL:
https://github.com/llvm/llvm-project/commit/abe71b77f9ac2fc689e899fa6aa2486120c53912
DIFF:
https://github.com/llvm/llvm-project/commit/abe71b77f9ac2fc689e899fa6aa2486120c53912.d
Author: Johannes Doerfert
Date: 2023-11-06T11:50:41-08:00
New Revision: 921bd299134fbe17c676b2486af269e18281def4
URL:
https://github.com/llvm/llvm-project/commit/921bd299134fbe17c676b2486af269e18281def4
DIFF:
https://github.com/llvm/llvm-project/commit/921bd299134fbe17c676b2486af269e18281def4.d
Author: Vlad Serebrennikov
Date: 2023-11-06T22:55:51+03:00
New Revision: f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed
URL:
https://github.com/llvm/llvm-project/commit/f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed
DIFF:
https://github.com/llvm/llvm-project/commit/f2d8a0ac1dd1fe55b2c3b358c525fbc01b0121ed.
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/71437
Because the SmallVectorImpl destructor is not virtual, the destructor of
derived classes will not be called if pointers to the SmallVectorImpl class are
deleted directly. Making the SmallVectorImpl destructor
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/70762
>From 93d46d40f46663cfa30fc01da965887508684e25 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Mon, 30 Oct 2023 21:41:00 -0700
Subject: [PATCH 1/7] [clang] Add support for new loop attribute
[[clang::code_a
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/71437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10026,6 +10026,11 @@ def err_duplicate_case_differing_expr : Error<
def warn_case_empty_range : Warning<"empty case range specified">;
def warn_missing_case_for_condition :
Warning<"no case matching constant switch condition '%0'">;
+def err_loop_attr_duplication : Error<
@@ -322,6 +322,57 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const
ParsedAttr &A,
return ::new (S.Context) UnlikelyAttr(S.Context, A);
}
+CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI,
+Expr *E) {
+ if
@@ -322,6 +322,57 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const
ParsedAttr &A,
return ::new (S.Context) UnlikelyAttr(S.Context, A);
}
+CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI,
+Expr *E) {
+ if
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/71439
Because the SmallVectorImpl destructor is not virtual, the destructor of
derived classes will not be called if pointers to the SmallVectorImpl class are
deleted directly. Making the SmallVectorImpl destructor
llvmbot wrote:
@llvm/pr-subscribers-llvm-adt
Author: Andy Kaylor (andykaylor)
Changes
Because the SmallVectorImpl destructor is not virtual, the destructor of
derived classes will not be called if pointers to the SmallVectorImpl class are
deleted directly. Making the SmallVectorImpl dest
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Andy Kaylor (andykaylor)
Changes
Because the SmallVectorImpl destructor is not virtual, the destructor of
derived classes will not be called if pointers to the SmallVectorImpl class are
deleted directly. Making the SmallVectorImpl destruct
Author: Vlad Serebrennikov
Date: 2023-11-06T23:08:39+03:00
New Revision: 088932d8ef1f80ba9e1349ce7cda95accd2f745e
URL:
https://github.com/llvm/llvm-project/commit/088932d8ef1f80ba9e1349ce7cda95accd2f745e
DIFF:
https://github.com/llvm/llvm-project/commit/088932d8ef1f80ba9e1349ce7cda95accd2f745e.
https://github.com/AntonRydahl updated
https://github.com/llvm/llvm-project/pull/68642
>From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001
From: AntonRydahl
Date: Mon, 9 Oct 2023 15:13:22 -0700
Subject: [PATCH 1/6] Merged __is_trivial_equality_predicate and
__is_trivial_plu
https://github.com/AntonRydahl updated
https://github.com/llvm/llvm-project/pull/68642
>From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001
From: AntonRydahl
Date: Mon, 9 Oct 2023 15:13:22 -0700
Subject: [PATCH 1/7] Merged __is_trivial_equality_predicate and
__is_trivial_plu
@@ -788,6 +797,17 @@ void LoopInfoStack::push(BasicBlock *Header,
clang::ASTContext &Ctx,
}
}
+ // Identify loop attribute 'code_align' from Attrs.
+ // For attribute code_align:
+ // n - 'llvm.loop.align i32 n' metadata will be emitted.
+ for (const auto *A : Attrs
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/70762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/70762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -95,7 +95,7 @@ class SerializeToHsacoPass
std::unique_ptr>
serializeISA(const std::string &isa) override;
- std::unique_ptr> assembleIsa(const std::string &isa);
+ std::unique_ptr> assembleIsa(const std::string &isa);
kuhar wrote:
IMO this should eit
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kuhar commented:
Overall I think this makes sense, but the `SerializeToHsaco` changes look
suboptimal
https://github.com/llvm/llvm-project/pull/71439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b14d3441a67939533df1b10cc456516c85a3386a
57c4db247df3e02f83b287015de2a6154b6b5749 --
https://github.com/796e43a5a8cdb73b92b created
https://github.com/llvm/llvm-project/pull/71441
The `traverse` function has been updated for better readability and
maintainability. The function now has clearer function names.
>From 1fc6f26966f0192bb1789b66778381d94cd6bbe5 Mon Sep 17 00:00:00 20
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (796e43a5a8cdb73b92b)
Changes
The `traverse` function has been updated for better readability and
maintainability. The function now has clearer function names.
---
Full diff: https://github.com/llvm/llvm-project/pull/71441.diff
1 F
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 74e0a26fd114cac39e251e4c2b6fbbadd6009887
1fc6f26966f0192bb1789b66778381d94cd6bbe5 --
https://github.com/796e43a5a8cdb73b92b closed
https://github.com/llvm/llvm-project/pull/71441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-11-06T23:27:13+03:00
New Revision: b6f2597a45f426f3a276c1c59f7ff5521b6dcc89
URL:
https://github.com/llvm/llvm-project/commit/b6f2597a45f426f3a276c1c59f7ff5521b6dcc89
DIFF:
https://github.com/llvm/llvm-project/commit/b6f2597a45f426f3a276c1c59f7ff5521b6dcc89.
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
The code formatter says that it's not happy. Can you try `git clang-format
HEAD~1` in your branch?
https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
brad0 wrote:
Thanks.
https://github.com/llvm/llvm-project/pull/70255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -95,7 +95,7 @@ class SerializeToHsacoPass
std::unique_ptr>
serializeISA(const std::string &isa) override;
- std::unique_ptr> assembleIsa(const std::string &isa);
+ std::unique_ptr> assembleIsa(const std::string &isa);
andykaylor wrote:
I'm not famili
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
lamb-j wrote:
I am getting this from the formatter:
- void RunOptimizationPipeline(BackendAction Action,
- std::unique_ptr &OS,
- std::unique_ptr &ThinLinkOS,
- BackendConsumer *BC);
+ void RunOptimizationPipeline(
+
elizabethandrews wrote:
@tahonermann @AaronBallman does that sound ok to you ? Can I merge this (after
a rebase)?
https://github.com/llvm/llvm-project/pull/70224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
jhuber6 wrote:
> I am getting this from the formatter:
>
> ```
> - void RunOptimizationPipeline(BackendAction Action,
> - std::unique_ptr &OS,
> - std::unique_ptr &ThinLinkOS,
> - BackendConsumer *BC);
> + void RunOptim
lamb-j wrote:
>
> Just do what the formatter says, not every file is 100% clang-formatted so
> there's bits of old code that haven't been properly cleaned yet. This was the
> same line that I thought looked wrong so it should probably be fixed. Using
> `git clang-format HEAD~1` only formats w
https://github.com/maksfb updated
https://github.com/llvm/llvm-project/pull/70147
>From 0860630c42430aa8c571ebe8931fd7a009ade560 Mon Sep 17 00:00:00 2001
From: Maksim Panchenko
Date: Thu, 19 Oct 2023 19:34:44 -0700
Subject: [PATCH] [BOLT] Use direct storage for Label annotations. NFCI.
Store t
jhuber6 wrote:
> > Just do what the formatter says, not every file is 100% clang-formatted so
> > there's bits of old code that haven't been properly cleaned yet. This was
> > the same line that I thought looked wrong so it should probably be fixed.
> > Using `git clang-format HEAD~1` only for
@@ -802,9 +842,19 @@ InitListChecker::FillInEmptyInitializations(const
InitializedEntity &Entity,
}
}
} else {
+ InitListExpr *SForm =
+ ILE->isSyntacticForm() ? ILE : ILE->getSyntacticForm();
// The fields beyond ILE->getNumInits() are d
@@ -465,7 +460,8 @@ class InitListChecker {
void FillInEmptyInitForField(unsigned Init, FieldDecl *Field,
const InitializedEntity &ParentEntity,
InitListExpr *ILE, bool &RequiresSecondPass,
-
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (hadError || VerifyOnly) {
// Do nothing
} else if (Init < NumInits) {
zygoloid wrote:
Is it OK that we don't warn on the `else` case here? Do
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (hadError || VerifyOnly) {
// Do nothing
} else if (Init < NumInits) {
+ if (MaybeEmitMFIWarning) {
+auto CheckAnonMember = [&](const FieldDecl *FD
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/71446
The downside of the --gcc-install-dir is that you are required to specify a
path that includes the gcc major version. This makes it hard to use for
distributions in configuration files, because an upgrade of g
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0156b6ed6561f67f1b86ceef027908dd425e0615
924768f777245a271cfb84243c2c6ac980df1671 --
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Tom Stellard (tstellar)
Changes
The downside of the --gcc-install-dir is that you are required to specify a
path that includes the gcc major version. This makes it hard to use for
distributions in configuration files, because an u
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Tom Stellard (tstellar)
Changes
The downside of the --gcc-install-dir is that you are required to specify a
path that includes the gcc major version. This makes it hard to use for
distributions in configuration files, because an upgrade
https://github.com/maksfb updated
https://github.com/llvm/llvm-project/pull/70147
>From 0860630c42430aa8c571ebe8931fd7a009ade560 Mon Sep 17 00:00:00 2001
From: Maksim Panchenko
Date: Thu, 19 Oct 2023 19:34:44 -0700
Subject: [PATCH 1/2] [BOLT] Use direct storage for Label annotations. NFCI.
Sto
https://github.com/nickdesaulniers approved this pull request.
maybe @rapidsna has parting thoughts?
https://github.com/llvm/llvm-project/pull/70606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -330,6 +330,23 @@ def getStdFlag(cfg, std):
default=f"{shlex.quote(sys.executable)}
{shlex.quote(str(Path(__file__).resolve().parent.parent.parent / 'run.py'))}",
help="Custom executor to use instead of the configured default.",
actions=lambda execut
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bc7a3bd864be696217c4d11eddf16bed7646b60f
2474aad8585829936af66d8b1238a1876c0f8327 --
https://github.com/slinder1 requested changes to this pull request.
I don't mean to make existing debt your problem, but if it isn't too much work
could you post a pre-patch that just adds the `FileCheck`s to the existing
tests where the behavior changes, so the test diff is more self-documenti
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
https://github.com/slinder1 edited
https://github.com/llvm/llvm-project/pull/70898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
lamb-j wrote:
> this doesn't really apply since you changed the function signature so it
> needs to be reformatted.
I don't follow the logic there. The function signature can have a style as
well. And I think this is actually a good example to demonstrate a reason not
to reformat if we look a
https://github.com/maksfb closed https://github.com/llvm/llvm-project/pull/70147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/71450
After #70144 Clang started resolving module maps even for `__has_include()`
expressions. The unintended consequence of this is that diagnostics related to
module mis-use started trigerring. These diagnostic
jhuber6 wrote:
> That said, I definitely don't want this to be a barrier to getting this patch
> in, so if you still feel like we should go with the clang-format
> recommendation, I'll change it and also update the EmitAssembly and
> EmitBackendOutput signatures which were flagged by clang-for
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
After #70144 Clang started resolving module maps even for
`__has_include()` expressions. The unintended consequence of this is that
diagnostics related to module mis-use started trigerring. These diagnos
Author: Petr Hosek
Date: 2023-11-06T22:37:49Z
New Revision: c6a198c72ab0bae4bc8c322ce84feb691c190e5d
URL:
https://github.com/llvm/llvm-project/commit/c6a198c72ab0bae4bc8c322ce84feb691c190e5d
DIFF:
https://github.com/llvm/llvm-project/commit/c6a198c72ab0bae4bc8c322ce84feb691c190e5d.diff
LOG: [C
https://github.com/antoniofrighetto created
https://github.com/llvm/llvm-project/pull/71452
Emission of `mustprogress` attribute was previously occuring only when entering
`EmitFunctionBody`. Other paths for function body generation may lack the
attribute, potentially leading to suboptimal opt
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/71450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wsmoses updated
https://github.com/llvm/llvm-project/pull/70171
>From ee967e7cd00f3943494ca04576325c2f28f2c614 Mon Sep 17 00:00:00 2001
From: "William S. Moses"
Date: Wed, 25 Oct 2023 02:10:32 -0500
Subject: [PATCH] [Clang] Add codegen option to add passbuilder callback
func
Author: Jan Svoboda
Date: 2023-11-06T14:45:04-08:00
New Revision: 4f31d328aa165e559c9f374dc3201657921f150d
URL:
https://github.com/llvm/llvm-project/commit/4f31d328aa165e559c9f374dc3201657921f150d
DIFF:
https://github.com/llvm/llvm-project/commit/4f31d328aa165e559c9f374dc3201657921f150d.diff
L
Author: Jan Svoboda
Date: 2023-11-06T14:56:25-08:00
New Revision: 8c099168509da532c26ba843eed612dc53b27afc
URL:
https://github.com/llvm/llvm-project/commit/8c099168509da532c26ba843eed612dc53b27afc
DIFF:
https://github.com/llvm/llvm-project/commit/8c099168509da532c26ba843eed612dc53b27afc.diff
L
https://github.com/AntonRydahl updated
https://github.com/llvm/llvm-project/pull/68642
>From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001
From: AntonRydahl
Date: Mon, 9 Oct 2023 15:13:22 -0700
Subject: [PATCH 1/8] Merged __is_trivial_equality_predicate and
__is_trivial_plu
https://github.com/lntue updated https://github.com/llvm/llvm-project/pull/71298
>From e2142963eccd2ff4d3a0869445064f798fba1ff7 Mon Sep 17 00:00:00 2001
From: Tue Ly
Date: Sat, 4 Nov 2023 21:29:04 +
Subject: [PATCH] [libc][math] Add min/max/min_denorm/max_denorm constants to
FPBits and clea
https://github.com/lntue updated https://github.com/llvm/llvm-project/pull/71298
>From e2142963eccd2ff4d3a0869445064f798fba1ff7 Mon Sep 17 00:00:00 2001
From: Tue Ly
Date: Sat, 4 Nov 2023 21:29:04 +
Subject: [PATCH 1/2] [libc][math] Add min/max/min_denorm/max_denorm constants
to FPBits and
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/70171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks approved this pull request.
thanks for adding the test!
https://github.com/llvm/llvm-project/pull/70171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 463 matches
Mail list logo
