https://github.com/pmatos created
https://github.com/llvm/llvm-project/pull/71029
Replace this with PointerType::get().
Also adds AS = 0 as an optional argument to get() methods.
>From 28745bc7877747f998f658ee2f661f8312c54814 Mon Sep 17 00:00:00 2001
From: Paulo Matos
Date: Thu, 2 Nov 2023 08:
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-clang
Author: Paulo Matos (pmatos)
Changes
Replace this with PointerType::get().
Also adds AS = 0 as an optional argument to get() methods.
---
Patch is 81.99 KiB, truncated to 20.00 KiB below, full version:
https:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e98195f318375978e3e0b153cade8bb3a05029bb
28745bc7877747f998f658ee2f661f8312c54814 --
@@ -197,6 +197,7 @@ CODEGENOPT(HIPCorrectlyRoundedDivSqrt, 1, 1) ///<
-fno-hip-fp32-correctly-rounde
CODEGENOPT(HIPSaveKernelArgName, 1, 0) ///< Set when -fhip-kernel-arg-name is
enabled.
CODEGENOPT(UniqueInternalLinkageNames, 1, 0) ///< Internal Linkage symbols get
unique na
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/71031
Close https://github.com/llvm/llvm-project/issues/60996.
Previously, clang will try to import function bodies from other module units to
get more optimization oppotunities as much as possible. Then the motiva
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Chuanqi Xu (ChuanqiXu9)
Changes
Close https://github.com/llvm/llvm-project/issues/60996.
Previously, clang will try to import function bodies from other module units to
get more optimization oppotunities as much as possible. Then
ChuanqiXu9 wrote:
I'd like to land this next week if no objection comes in. Since the
`frameworks` looks not intended to be the places too.
https://github.com/llvm/llvm-project/pull/69555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -5011,6 +5011,12 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
Args.AddLastArg(CmdArgs, options::OPT_fthinlto_index_EQ);
}
+ if (const Arg *A =
+ Args.getLastArg(options::OPT_mregnames, options::OPT_mno_regnames)) {
MaskR
Author: Martin Storsjö
Date: 2023-11-02T09:51:33+02:00
New Revision: 3bc056d5f0ebe9e4074afa088c3a0355f9ab901a
URL:
https://github.com/llvm/llvm-project/commit/3bc056d5f0ebe9e4074afa088c3a0355f9ab901a
DIFF:
https://github.com/llvm/llvm-project/commit/3bc056d5f0ebe9e4074afa088c3a0355f9ab901a.diff
https://github.com/mstorsjo closed
https://github.com/llvm/llvm-project/pull/70991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5723,16 +5723,14 @@ void Clang::ConstructJob(Compilation &C, const
JobAction &JA,
if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) {
StringRef CM = A->getValue();
bool Ok = false;
-if (Triple.isOSAIX() && CM == "medium") {
+if (Triple.isOSAIX() && C
https://github.com/balazske edited
https://github.com/llvm/llvm-project/pull/70540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske approved this pull request.
https://github.com/llvm/llvm-project/pull/70540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -fno-builtin
-analyzer-checker=core,alpha.unix.Stream -verify %s
+// expected-no-diagnostics
+
+typedef struct _FILE FILE;
+
+// These functions are not standard C library functions.
+FILE *tmpfile(const char *restrict path); // Real '
@@ -3856,10 +3856,19 @@ CodeGenModule::isTriviallyRecursive(const FunctionDecl
*FD) {
bool CodeGenModule::shouldEmitFunction(GlobalDecl GD) {
if (getFunctionLinkage(GD) != llvm::Function::AvailableExternallyLinkage)
return true;
+
const auto *F = cast(GD.getDecl());
@@ -3856,10 +3856,19 @@ CodeGenModule::isTriviallyRecursive(const FunctionDecl
*FD) {
bool CodeGenModule::shouldEmitFunction(GlobalDecl GD) {
if (getFunctionLinkage(GD) != llvm::Function::AvailableExternallyLinkage)
return true;
+
const auto *F = cast(GD.getDecl());
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -fno-builtin
-analyzer-checker=core,alpha.unix.Stream -verify %s
+// expected-no-diagnostics
+
+typedef struct _FILE FILE;
+
+// These functions are not standard C library functions.
+FILE *tmpfile(const char *restrict path); // Real '
Bigcheese wrote:
This is fine, it's definitely wrong to include framework headers like this too.
https://github.com/llvm/llvm-project/pull/69555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -1224,7 +1233,27 @@ void SVEEmitter::createHeader(raw_ostream &OS) {
OS << "typedef __SVBFloat16_t svbfloat16_t;\n";
- OS << "#include \n";
+ OS << "#include \n\n";
+
+ OS << "typedef __attribute__((vector_size (16))) int8_t __sve_int8x16_t;\n";
sdesm
@@ -0,0 +1,285 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: aarch64-registered-target
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -S
-O1 -Werror -Wall -emit-llvm -o - %s | FileCheck %s
+// RUN: %cla
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/70540
>From bf36469281f52fe34866e6df5eeafdc51d28819c Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Tue, 31 Oct 2023 13:05:19 +0800
Subject: [PATCH] [clang][analyzer] Restrict 'fopen' & 'tmpfile' modeling to
POSIX ver
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From b670986c19e412b3c140b610f2c26d957544b23a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATC
mstorsjo wrote:
This broke on PS5 bots, like
https://lab.llvm.org/buildbot/#/builders/216/builds/29677; those are configured
with a triple like `x86_64-sie-ps5`, which seems to use an MSVC like C++ ABI
behaviour, so I pushed a revert.
Not sure whom to CC to pull in Sony people to discuss this
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -fno-builtin
-analyzer-checker=core,alpha.unix.Stream -verify %s
+// expected-no-diagnostics
+
+typedef struct _FILE FILE;
+
+// These functions are not standard C library functions.
+FILE *tmpfile(const char *restrict path); // Real '
ChuanqiXu9 wrote:
Got it. Thanks. Then I feel this is ready to land.
https://github.com/llvm/llvm-project/pull/69555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chuanqi Xu
Date: 2023-11-02T16:40:20+08:00
New Revision: 0d2143611425081bb9db5bb6ee57aaddfd1eda53
URL:
https://github.com/llvm/llvm-project/commit/0d2143611425081bb9db5bb6ee57aaddfd1eda53
DIFF:
https://github.com/llvm/llvm-project/commit/0d2143611425081bb9db5bb6ee57aaddfd1eda53.diff
LO
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/69555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 -fno-builtin
-analyzer-checker=core,alpha.unix.Stream -verify %s
+// expected-no-diagnostics
+
+typedef struct _FILE FILE;
+
+// These functions are not standard C library functions.
+FILE *tmpfile(const char *restrict path); // Real '
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/70540
>From bbdb534d7c1300c4b18128fc0ccdd3476c3f6d7f Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Tue, 31 Oct 2023 13:05:19 +0800
Subject: [PATCH] [clang][analyzer] Restrict 'fopen' & 'tmpfile' modeling to
POSIX ver
Author: Martin Storsjö
Date: 2023-11-02T10:49:55+02:00
New Revision: b73d7390732b48014983aa9569e68c139f61bfcb
URL:
https://github.com/llvm/llvm-project/commit/b73d7390732b48014983aa9569e68c139f61bfcb
DIFF:
https://github.com/llvm/llvm-project/commit/b73d7390732b48014983aa9569e68c139f61bfcb.diff
nikic wrote:
> Also adds AS = 0 as an optional argument to get() methods.
I believe that was intentionally omitted to make sure address spaces aren't
forgotten (getUnqual is used for the case where they aren't relevant). cc
@arsenm
Not sure whether this consideration is still relevant with o
arsenm wrote:
I still think all the defaulted address space parameters should be purged and
it only invites bugs. It's a regression to introduce a new defaulted argument.
https://github.com/llvm/llvm-project/pull/71029
___
cfe-commits mailing list
cfe
ilg-ul wrote:
Then can this bug fix be accepted? Are there any other solutions?
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -167,17 +169,13 @@ template class IntegralAP final {
}
static bool increment(IntegralAP A, IntegralAP *R) {
-// FIXME: Implement.
-assert(false);
-*R = IntegralAP(A.V - 1);
-return false;
+IntegralAP One(1, A.bitWidth());
tbaederr w
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593
>From 261f571d28b8398be221f3928f93bcee211e26ae Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Sun, 29 Oct 2023 09:02:12 -0400
Subject: [PATCH] [OpenMP] Add support for Solaris/x86_64
Tested on `amd64-pc-solaris2.1
Author: Ben Shi
Date: 2023-11-02T17:10:56+08:00
New Revision: 32521bb37caad512fd539d95bda26170a91e8a4b
URL:
https://github.com/llvm/llvm-project/commit/32521bb37caad512fd539d95bda26170a91e8a4b
DIFF:
https://github.com/llvm/llvm-project/commit/32521bb37caad512fd539d95bda26170a91e8a4b.diff
LOG:
https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/70540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
peterwaller-arm wrote:
Worth a simultaneous update to the langref?
https://github.com/llvm/llvm-project/blob/e2564b27472638d2e2019e6cd2fc6d6d608f8b8c/llvm/docs/LangRef.rst#L5080-L5106
https://github.com/llvm/llvm-project/pull/70970
___
cfe-commits mai
@@ -8201,6 +8201,66 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
@@ -8201,6 +8201,66 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
@@ -8201,6 +8201,66 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode
*Node,
return SDValue();
}
+SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N,
+SelectionDAG &DAG) const {
+ SDLoc DL(N);
+ SDValue LHS = N-
@@ -167,17 +169,13 @@ template class IntegralAP final {
}
static bool increment(IntegralAP A, IntegralAP *R) {
-// FIXME: Implement.
-assert(false);
-*R = IntegralAP(A.V - 1);
-return false;
+IntegralAP One(1, A.bitWidth());
+return add(A, One, A.b
tbaederr wrote:
> FWIW, when the description for the PR says it can't be merged for some
> reason, it usually goes on the bottom of my review queue until those issues
> are addressed. It's difficult to accept known-broken code. :-(
Sorry, I forgot to re-enable the tests here. Now that
https:/
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/69597
>From 26780a13123c14763467c1b9de6b0cef3d92ff1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 18 Oct 2023 15:36:13 +0200
Subject: [PATC
serge-sans-paille wrote:
As expected, the formatter iw now red, otherwise looks good (to me at least),
waiting for official approval :-)
https://github.com/llvm/llvm-project/pull/70381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/71039
The goal of this patch is to refine how the `SVal` base and sub-kinds are
represented by forming one unified enum describing the possible SVals. This
means that the `unsigned SVal::Kind` and the attached bit-pa
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
The goal of this patch is to refine how the `SVal` base and sub-kinds are
represented by forming one unified enum describing the possible SVals. This
means that the `unsigned SVal::Kind`
steakhal wrote:
This PR relates to #69835
([comment](https://github.com/llvm/llvm-project/issues/69835#issuecomment-1775533393)).
https://github.com/llvm/llvm-project/pull/71039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
4vtomat wrote:
Since it's possible that **ISA spec** and **intrinsics spec** are not
synchronized, so the updates add an dummy extension called **zexperimental**,
once `-menable-experimental-extensions` is specified, the feature
`zexperimental` is automatically added.
If specifying `let Requir
@@ -290,37 +291,40 @@ bool SIFoldOperands::updateOperand(FoldCandidate &Fold)
const {
if (Fold.Commuted)
TII->commuteInstruction(*Inst32, false);
-return true;
- }
- assert(!Fold.needsShrink() && "not handled");
+Fold.UseMI = Inst32;
+Fold.UseOpNo =
https://github.com/jayfoad converted_to_draft
https://github.com/llvm/llvm-project/pull/68426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -216,11 +216,12 @@ void PreferMemberInitializerCheck::check(
return;
}
-const FieldDecl *Field = nullptr;
-const Expr *InitValue = nullptr;
-std::tie(Field, InitValue) = isAssignmentToMemberOf(Class, S, Ctor);
-if (!Field)
+std::optional>
+
@@ -118,45 +118,45 @@ static void updateAssignmentLevel(
}
}
-static std::pair
+static std::optional>
PiotrZSL wrote:
Consider changing this std::pair into normal struct, in such way there will be
no need to make aliases to fields later in check method
ht
https://github.com/PiotrZSL approved this pull request.
+1, as it's better than was before.
https://github.com/llvm/llvm-project/pull/71006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/pravinjagtap updated
https://github.com/llvm/llvm-project/pull/71019
>From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001
From: Pravin Jagtap
Date: Thu, 2 Nov 2023 01:05:35 -0400
Subject: [PATCH 1/2] [AMDGPU] Add code model (#70760) test for amdgpu target.
@@ -13,6 +13,11 @@
// RUN: not %clang -### -c --target=aarch64 -mcmodel=medium %s 2>&1 |
FileCheck --check-prefix=ERR-MEDIUM %s
// RUN: not %clang -### -c --target=aarch64 -mcmodel=kernel %s 2>&1 |
FileCheck --check-prefix=ERR-KERNEL %s
// RUN: not %clang --target=aarch64_32-
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/70235
>From e02640686a8cf0a42cec01da4f32b6888f5de11f Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Wed, 25 Oct 2023 17:14:40 +0100
Subject: [PATCH 1/2] [AMDGPU] New ttracedata intrinsics
Add llvm.amdgcn.s.ttracedata a
pmatos wrote:
> I still think all the defaulted address space parameters should be purged and
> it only invites bugs. It's a regression to introduce a new defaulted argument.
Understandable, although always writing `PointerType::get(Ctx, 0);` really
looks weird given most of the time the secon
brad added inline comments.
Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202
+ addSystemInclude(DriverArgs, CC1Args,
+ concat(D.SysRoot, "/usr/local/include"));
+ addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include"));
---
brad added a comment.
But the rest LGTM as a start.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154396/new/
https://reviews.llvm.org/D154396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
tblah wrote:
Hi @vzakhari, currently there is a serious performance regression in spec2017
exchange2. With the TBAA tags we produce slightly better code (less repeated
loads, hoisting some code out of loops, etc). Unfortunately, this change to the
generated code causes LLVM's function speciali
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/70235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/71006
>From 69b7688f56f7fe96031201eef1c3804f391c5abe Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 2 Nov 2023 08:49:22 +0800
Subject: [PATCH 1/2] [NFC][clang-tidy]refactor isAssignmentToMemberOf in
Prefer
https://github.com/chandankds created
https://github.com/llvm/llvm-project/pull/71043
None
>From 029b1687e5217e73655442b319a482865587277b Mon Sep 17 00:00:00 2001
From: chandan singh <36783761+chandan...@users.noreply.github.com>
Date: Thu, 2 Nov 2023 11:53:03 +0530
Subject: [PATCH 1/2] [Flang]
https://github.com/pravinjagtap updated
https://github.com/llvm/llvm-project/pull/71019
>From ef0118818249da417706db7f8e7086d051d17d50 Mon Sep 17 00:00:00 2001
From: Pravin Jagtap
Date: Thu, 2 Nov 2023 01:05:35 -0400
Subject: [PATCH 1/3] [AMDGPU] Add code model (#70760) test for amdgpu target.
@@ -13,6 +13,11 @@
// RUN: not %clang -### -c --target=aarch64 -mcmodel=medium %s 2>&1 |
FileCheck --check-prefix=ERR-MEDIUM %s
// RUN: not %clang -### -c --target=aarch64 -mcmodel=kernel %s 2>&1 |
FileCheck --check-prefix=ERR-KERNEL %s
// RUN: not %clang --target=aarch64_32-
https://github.com/DominikAdamski created
https://github.com/llvm/llvm-project/pull/71045
If -nogpulib option is passed by the user, then the OpenMP device runtime is
not used and we should not emit globals to configure debugging at compile-time
for the device runtime.
Link to -nogpulib flag
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-mlir
Author: Dominik Adamski (DominikAdamski)
Changes
If -nogpulib option is passed by the user, then the OpenMP device runtime is
not used and we should not emit globals to configure debugging at compile-time
for the
llvmbot wrote:
@llvm/pr-subscribers-mlir-llvm
Author: Dominik Adamski (DominikAdamski)
Changes
If -nogpulib option is passed by the user, then the OpenMP device runtime is
not used and we should not emit globals to configure debugging at compile-time
for the device runtime.
Link to -nog
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
Author: Dominik Adamski (DominikAdamski)
Changes
If -nogpulib option is passed by the user, then the OpenMP device runtime is
not used and we should not emit globals to configure debugging at compile-time
for the device runtime.
Link to -
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/71039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll commented:
Converting packed `unsigned Kind` into non-packed `SValKind Kind` is definitely
going to help debuggers to display the value correctly.
But I have to point out that this patch doesn't address the fact that `const
void* Data` is not friendly to debuggers, e
@@ -105,38 +86,25 @@ class SVal {
return llvm::dyn_cast(*this);
}
- unsigned getRawKind() const { return Kind; }
- BaseKind getBaseKind() const { return (BaseKind) (Kind & BaseMask); }
- unsigned getSubKind() const { return Kind >> BaseBits; }
+ SValKind getKind() co
steakhal wrote:
> But I have to point out that this patch doesn't address the fact that `const
> void* Data` is not friendly to debuggers, especially with type information
> encoded in another member. So even with this patch applied, someone would
> still have to write (and maintain) a custom
ArcsinX added a comment.
> One such heuristic is to check the nodes in the selection tree for the exact
> line match
It looks like this heuristic doesn't work well in multiline cases.
E.g.
int
f^unc() {
return 0;
}
will give empty result with this patch applied.
Repository:
rG L
Author: Congcong Cai
Date: 2023-11-02T19:30:06+08:00
New Revision: 43e13fdc9e8edd425f640c424071377879c07822
URL:
https://github.com/llvm/llvm-project/commit/43e13fdc9e8edd425f640c424071377879c07822
DIFF:
https://github.com/llvm/llvm-project/commit/43e13fdc9e8edd425f640c424071377879c07822.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/71006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71049
This patch introduces a new enumerator `Invalid = 0`, shifting other
enumerators by +1. Contrary to how it might sound, this actually affirms status
quo of how this enum is stored in `clang::Decl`:
```
/// If
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Vlad Serebrennikov (Endilll)
Changes
This patch introduces a new enumerator `Invalid = 0`, shifting other
enumerators by +1. Contrary to how it might sound, this actually affirms status
quo of how this enum is stored in `clang::De
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Vlad Serebrennikov (Endilll)
Changes
This patch introduces a new enumerator `Invalid = 0`, shifting other
enumerators by +1. Contrary to how it might sound, this actually affirms status
quo of how this enum is stored in `clang::De
@@ -84,22 +88,33 @@ inline bool isUniqueGVALinkage(GVALinkage L) {
}
inline bool isExternallyVisible(Linkage L) {
- return L >= VisibleNoLinkage;
+ switch (L) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage hasn't been computed!");
Endilll wrote:
@@ -2214,7 +2214,7 @@ void ASTWriter::WriteDeclAbbrevs() {
Abv->Add(BitCodeAbbrevOp(0)); // TSCSpec
Abv->Add(BitCodeAbbrevOp(0)); // InitStyle
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
- Abv->Ad
Endilll wrote:
> I've considered this but I found the number of alternatives too large to make
> it feasible. Consider that we have 11 possible SValKinds, which would require
> 4 bits to encode. Requiring all Data pointers to be aligned as such seems
> rough - although not impossible.
Sorry,
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/71039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -777,6 +777,12 @@ void CodeGenFunction::EmitCoroutineBody(const
CoroutineBodyStmt &S) {
// LLVM require the frontend to mark the coroutine.
CurFn->setPresplitCoroutine();
+
+ {
+CXXRecordDecl *RD = FnRetTy->getAsCXXRecordDecl();
+if (RD && RD->hasAttr())
+
Author: Vlad Serebrennikov
Date: 2023-11-02T16:17:17+04:00
New Revision: 98da18344eed96cabfd2214131185686b1983412
URL:
https://github.com/llvm/llvm-project/commit/98da18344eed96cabfd2214131185686b1983412
DIFF:
https://github.com/llvm/llvm-project/commit/98da18344eed96cabfd2214131185686b1983412.
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amcn created https://github.com/llvm/llvm-project/pull/71053
scan-build's `UpdatePrefix` calculates the shared prefix of a set of files. Its
use of strings and regular expressions to do so means that it can sometimes end
up calculating a prefix which does not correspond to a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (amcn)
Changes
scan-build's `UpdatePrefix` calculates the shared prefix of a set of files. Its
use of strings and regular expressions to do so means that it can sometimes end
up calculating a prefix which does not correspond to a rea
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: None (amcn)
Changes
scan-build's `UpdatePrefix` calculates the shared prefix of a set of files. Its
use of strings and regular expressions to do so means that it can sometimes end
up calculating a prefix which does not c
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/70349
>From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 26 Oct 2023 16:09:25 +0300
Subject: [PATCH 1/6] [clang][NFC] Annotate `Type` bit-fields with
`clang::pr
@@ -84,22 +88,33 @@ inline bool isUniqueGVALinkage(GVALinkage L) {
}
inline bool isExternallyVisible(Linkage L) {
- return L >= VisibleNoLinkage;
+ switch (L) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage hasn't been computed!");
AaronBallman wr
@@ -1921,7 +1920,20 @@ bool NamedDecl::declarationReplaces(NamedDecl *OldD,
bool IsKnownNewer) const {
}
bool NamedDecl::hasLinkage() const {
- return getFormalLinkage() != NoLinkage;
+ switch (getFormalLinkage()) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage h
@@ -2214,7 +2214,7 @@ void ASTWriter::WriteDeclAbbrevs() {
Abv->Add(BitCodeAbbrevOp(0)); // TSCSpec
Abv->Add(BitCodeAbbrevOp(0)); // InitStyle
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
- Abv->Ad
@@ -560,7 +562,7 @@ bool CXIndexDataConsumer::handleDecl(const NamedDecl *D,
if (shouldSuppressRefs())
markEntityOccurrenceInFile(D, Loc);
-
+
AaronBallman wrote:
Every other change in this file is unrelated to the linkage enum and should be
backed o
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
hnrklssn wrote:
Nice. I realise you're following the convention already established in the test
file, but have you considered compiling with `-verify=new,both` and
`-verify=ref,both`, respectively, and combining the shared diagnostics into
`bo
Author: Egor Zhdan
Date: 2023-11-02T12:39:55Z
New Revision: f1c9a1c3a590970ba88e28a58d0f3622e8c2c415
URL:
https://github.com/llvm/llvm-project/commit/f1c9a1c3a590970ba88e28a58d0f3622e8c2c415
DIFF:
https://github.com/llvm/llvm-project/commit/f1c9a1c3a590970ba88e28a58d0f3622e8c2c415.diff
LOG: Re
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/70975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1921,7 +1920,20 @@ bool NamedDecl::declarationReplaces(NamedDecl *OldD,
bool IsKnownNewer) const {
}
bool NamedDecl::hasLinkage() const {
- return getFormalLinkage() != NoLinkage;
+ switch (getFormalLinkage()) {
+ case Linkage::Invalid:
+llvm_unreachable("Linkage h
@@ -560,7 +562,7 @@ bool CXIndexDataConsumer::handleDecl(const NamedDecl *D,
if (shouldSuppressRefs())
markEntityOccurrenceInFile(D, Loc);
-
+
Endilll wrote:
I guess that's clang-format at work. I'll revert this.
https://github.com/llvm/llvm-project/
1 - 100 of 430 matches
Mail list logo
