[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Yinan Xu via cfe-commits
poemonsense wrote: > @dtcxzyw Could you please confirm the status of this core - is it > commercially available, an academic test chip, something else? It's maintained by Beijing Institute of Open Source Chip (BOSC), a non-profit organziation founded by companies and researech institutions. It

[clang] f3f0672 - [Clang] Fix several `-Wdocumentation` warnings (NFC)

2023-10-26 Thread via cfe-commits
Author: Egor Zhdan Date: 2023-10-26T16:14:23+01:00 New Revision: f3f0672039f42610101db8bbe97f521a65ede413 URL: https://github.com/llvm/llvm-project/commit/f3f0672039f42610101db8bbe97f521a65ede413 DIFF: https://github.com/llvm/llvm-project/commit/f3f0672039f42610101db8bbe97f521a65ede413.diff LO

[clang] [Clang] Fix several `-Wdocumentation` warnings (NFC) (PR #70333)

2023-10-26 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/70333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. Thanks! LGTM with a nit. https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Chuanqi Xu via cfe-commits
@@ -1198,6 +1198,11 @@ void Sema::CheckCompletedCoroutineBody(FunctionDecl *FD, Stmt *&Body) { if (FD->hasAttr()) Diag(FD->getLocation(), diag::warn_always_inline_coroutine); + // We don't allow use of VLAs within a coroutine, so diagnose if we've seen

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > LGTM but it is missing a release note :) it may be fine to not mention it clearly since VLAs in coroutines never got compiled.. user might meet backend crashes.. https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mail

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Yinan Xu via cfe-commits
poemonsense wrote: > Please update the official document then. :-) I'll do it. We did not list it previously because it is not the usual thing for user programs, as we were initially implementing it for internal usage. Sorry for causing the confusion. https://github.com/llvm/llvm-project/pull

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a6d0e87 - [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (#70296)

2023-10-26 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-26T19:22:52+04:00 New Revision: a6d0e8791e1015a12f8277e6032eae9fdab686fe URL: https://github.com/llvm/llvm-project/commit/a6d0e8791e1015a12f8277e6032eae9fdab686fe DIFF: https://github.com/llvm/llvm-project/commit/a6d0e8791e1015a12f8277e6032eae9fdab686fe.

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/70296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-26 Thread Stefan Pintilie via cfe-commits
@@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { bool IsISA3_0 = false; bool IsISA3_1 = false; bool HasQuadwordAtomics = false; + bool FullRegisterNames = false; stefanp-ibm wrote: I did take a look at trying to do it

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. The comment suggestion makes sense to me, else just needs a release note. https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

2023-10-26 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/68191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-26 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,78 @@ +// REQUIRES: powerpc-registered-target nickdesaulniers wrote: Yeah, a full on integration test for this is a bit much. The backend tests LGTM; just making sure the frontend doesn't error when presented with this flag (and the `-no` variant) w

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-26 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: Thanks for the patch! https://github.com/llvm/llvm-project/pull/70255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/70341 >From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 26 Oct 2023 10:53:06 -0400 Subject: [PATCH 1/2] Diagnose use of VLAs in a coroutine Fixes https://githu

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/69648 >From 843d9b200f3708676119ed0b2b3b0657cd3fd47b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Mon, 18 Sep 2023 18:26:22 + Subject: [PATCH 1/6] Add SYCL runtimet wrappers --- .../ExecutionEngine/SyclRunt

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Nishant Patel via cfe-commits
@@ -0,0 +1,209 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Nishant Patel via cfe-commits
nbpatel wrote: Thanks for the feedback and approval. @grypp can you help me merge this PR ? https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/70341 >From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 26 Oct 2023 10:53:06 -0400 Subject: [PATCH 1/2] Diagnose use of VLAs in a coroutine Fixes https://githu

[clang] 09e8ef9 - Diagnose use of VLAs in a coroutine (#70341)

2023-10-26 Thread via cfe-commits
Author: Aaron Ballman Date: 2023-10-26T11:59:17-04:00 New Revision: 09e8ef975d9970560b893f79ec283f69ea8db953 URL: https://github.com/llvm/llvm-project/commit/09e8ef975d9970560b893f79ec283f69ea8db953 DIFF: https://github.com/llvm/llvm-project/commit/09e8ef975d9970560b893f79ec283f69ea8db953.diff

[clang-tools-extra] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-26 Thread Sunil K via Phabricator via cfe-commits
koops added a comment. Can someone please backout the changes done with this commit? It is resulting in build failures on debian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 _

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: agreed that `-mllvm -verify-machineinstrs` is good enough https://github.com/llvm/llvm-project/pull/70282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix -r handling on Solaris (PR #70322)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/70322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/70349 This patch adds `clang::preferred_type` annotations to Type-related bit-fields where possible. Notable exception are bit-fields that hold values of types that are incomplete at bit-field declaration. This is a l

[clang] b67d370 - [clang] Prioritze decl comments from macro expansion site (#65481)

2023-10-26 Thread via cfe-commits
Author: Daniel Grumberg Date: 2023-10-26T17:32:36+01:00 New Revision: b67d3702577d4a1848bce9be9887e554178a421a URL: https://github.com/llvm/llvm-project/commit/b67d3702577d4a1848bce9be9887e554178a421a DIFF: https://github.com/llvm/llvm-project/commit/b67d3702577d4a1848bce9be9887e554178a421a.dif

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-10-26 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg closed https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch adds `clang::preferred_type` annotations to Type-related bit-fields where possible. Notable exception are bit-fields that hold values of types that are incomplete at bit-field declaration. T

[clang] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2023-10-26 Thread Ben Langmuir via cfe-commits
@@ -230,6 +251,26 @@ class DependencyScanningFilesystemLocalCache { assert(InsertedEntry == &Entry && "entry already present"); return *InsertedEntry; } + + /// Returns real path associated with the filename or nullptr if none is + /// found. + const CachedRealPath

[clang] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2023-10-26 Thread Ben Langmuir via cfe-commits
@@ -168,6 +170,12 @@ class DependencyScanningFilesystemSharedCache { /// The backing storage for cached contents. llvm::SpecificBumpPtrAllocator ContentsStorage; +/// Map from filenames to cached real paths. +llvm::StringMap RealPathsByFilename; ---

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-26 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I don't disagree that if we stop at this step, then the flag doesn't buy much. But it would be worthwhile if we ever implemented LTO integration or implemented a lightweight machine verification which runs the pass 1 or 2 times, which would work similarly to the IR verification

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

2023-10-26 Thread Fred Fu via cfe-commits
https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 4b371d40d74d6297bdb5ecbe2eae0573e20d0569 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/8] [ClangRepl] Type Directed Code Completion Differential Revision:

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

2023-10-26 Thread Fred Fu via cfe-commits
https://github.com/capfredf ready_for_review https://github.com/llvm/llvm-project/pull/67349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-26 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From 9b559ac5504593ab7aa21539b49ece7eea944eb5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH 1/3] [Clang] Diagnose defaulted assignment operator with incomp

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

2023-10-26 Thread Fred Fu via cfe-commits
https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 61bb4c46f6733128d5ec4b511a858f08e86bfd40 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH] [ClangRepl] Type Directed Code Completion Differential Revision: http

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-26 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From 9b559ac5504593ab7aa21539b49ece7eea944eb5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH 1/2] [Clang] Diagnose defaulted assignment operator with incomp

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

2023-10-26 Thread Fred Fu via cfe-commits
https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 582f652f35d813a86790bc62473a0efc4560ae9a Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH] [ClangRepl] Type Directed Code Completion --- .../clang/Interpreter/

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-26 Thread Tom Honermann via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, tahonermann wrote: Hmm, the regex chan

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-10-26 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/70353 When the top of the instantiation stack is in user code. The goal of this PR is to allow deprecation of some char_traits specializations in libc++ as done in https://reviews.llvm.org/D157058 which was later rev

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-10-26 Thread via cfe-commits
cor3ntin wrote: @ldionne @mordante Ping for visibility :) https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes When the top of the instantiation stack is in user code. The goal of this PR is to allow deprecation of some char_traits specializations in libc++ as done in https://reviews.llvm.org/D157058 which was later rev

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Any more questions about XiangShan? If there is no question, I will merge this PR tomorrow. https://github.com/llvm/llvm-project/pull/70294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-26 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From a49b8e2da32c1be06ea956198ba0d01006d64c92 Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder callba

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-10-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D140996#4646880 , @cor3ntin wrote: > It would be nice to figure out a plan for this PR in the next few weeks, > before we get kicked out of Phab! Agreed -- @bolshakov-a are you still planning to actively work on this pa

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/70349 >From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 26 Oct 2023 16:09:25 +0300 Subject: [PATCH 1/3] [clang][NFC] Annotate `Type` bit-fields with `clang::pr

[clang] [Clang][RISCV] Add vundefine intrinsics for tuple types (PR #70354)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yueh-Ting (eop) Chen (eopXD) Changes riscv-non-isa/rvv-intrinsic-doc#288 --- Patch is 127.57 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/70354.diff 2 Files Affected: - (modified) clang/in

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yueh-Ting (eop) Chen (eopXD) Changes riscv-non-isa/rvv-intrinsic-doc#288 --- Patch is 459.83 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/70355.diff 2 Files Affected: - (modified) clang/in

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3e79f4d2c24faaa24a4a12041b4c33d39fec2ec7 a49b8e2da32c1be06ea956198ba0d01006d64c92 --

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-10-26 Thread Andrey Ali Khan Bolshakov via Phabricator via cfe-commits
bolshakov-a added a comment. Sorry, but I don't know what remains to be done here. It seems that the only important question is about ABI, but I've already answered that the changes under discussion seem to be already fixed in the Itanium ABI document. CHANGES SINCE LAST ACTION https://revie

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 45ccc1666c723e11d7b0148b2ef5c37c7a36e916 3eb936f9351d1252c465372023423344b63488fa --

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-10-26 Thread Tom Honermann via cfe-commits
tahonermann wrote: I like this very much so long as it doesn't turn out to be too noisy! https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread Craig Topper via cfe-commits
@@ -345,6 +345,54 @@ class VString { !eq(nf, 8): !if(signed, "", "UvUvUvUvUvUvUvUv")); } + +class FixedVString { + string V = "(LFixedLog2LMUL:" # fixed_lmul # ")" # !if(signed, "v", "Uv"); topperc wrote: Why not pass "v" or "Uv" i

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread Craig Topper via cfe-commits
@@ -345,6 +345,54 @@ class VString { !eq(nf, 8): !if(signed, "", "UvUvUvUvUvUvUvUv")); } + +class FixedVString { + string V = "(LFixedLog2LMUL:" # fixed_lmul # ")" # !if(signed, "v", "Uv"); + string S = !cond(!eq(num, 1): V, topper

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread Craig Topper via cfe-commits
@@ -345,6 +345,54 @@ class VString { !eq(nf, 8): !if(signed, "", "UvUvUvUvUvUvUvUv")); } + +class FixedVString { + string V = "(LFixedLog2LMUL:" # fixed_lmul # ")" # !if(signed, "v", "Uv"); + string S = !cond(!eq(num, 1): V, + !eq

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-26 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From 547d498662c3b8da2cb87abe9f5c13b39123d90f Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder callba

[clang-tools-extra] [clang-tidy] Improve bugprone-unused-return-value check (PR #66573)

2023-10-26 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/66573 >From 2068098bb3a3e93150459f97f278209488d18943 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Sat, 16 Sep 2023 08:46:02 + Subject: [PATCH 1/3] [clang-tidy] Improve bugprone-unused-return-value diagnostic

[clang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-10-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/5] [OpenACC] Initial commit for OpenACC Support This is the ini

[clang-tools-extra] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-10-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/5] [OpenACC] Initial commit for OpenACC Support This is the ini

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -66,6 +67,12 @@ class Boolean final { Boolean toUnsigned() const { return *this; } constexpr s

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,816 @@ +// RUN: %clang_cc1 -verify -std=c++2a -fsyntax-only -fexperimental-new-constant-inter

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,458 @@ +//===--- InterpBitcast.cpp - Interpreter for the constexpr VM ---*- C++ -*-===// +//

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Guray Ozen via cfe-commits
https://github.com/grypp closed https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread via cfe-commits
@@ -263,17 +267,11 @@ class SVEEmitter { // which is inconvenient to specify in the arm_sve.td file or // generate in CGBuiltin.cpp. struct ReinterpretTypeInfo { +SVEType BaseType; const char *Suffix; -const char *Type; -const char *BuiltinType; }; -

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread via cfe-commits
@@ -954,13 +967,13 @@ std::string Intrinsic::replaceTemplatedArgs(std::string Name, TypeSpec TS, default: llvm_unreachable("Unknown predication specifier"); case 'd': - T = SVEType(TS, 'd'); + T = SVEType(TS, 'd', 1); CarolineConcatto w

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread via cfe-commits
@@ -64,26 +65,29 @@ class ImmCheck { }; class SVEType { - TypeSpec TS; bool Float, Signed, Immediate, Void, Constant, Pointer, BFloat; bool DefaultType, IsScalable, Predicate, PredicatePattern, PrefetchOp, Svcount; unsigned Bitwidth, ElementBitwidth, NumVector

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread via cfe-commits
@@ -383,6 +381,20 @@ class SVEEmitter { SmallVectorImpl> &Out); }; +const std::array SVEEmitter::Reinterprets = +{{{SVEType("c"), "s8"}, CarolineConcatto wrote: Can we change this to be SVEType("c", 'd'), so we don't need to change

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-26 Thread via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, elizabethandrews wrote: It looks like

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/70360 This patch addresses some example of bad formatting in Clang. The following commit contains only changes suggested by clang-format: https://github.com/llvm/llvm-project/pull/70349/commits/21689b56d1fc1db0b2263e8

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Vlad Serebrennikov (Endilll) Changes This patch addresses some example of bad formatting in Clang. The following commit contains only changes suggested by clang-format: https://github.com/llvm/llvm-project/pull/70349/commits/21689b

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/69487 >From 7214e2ad580724c6b747ce5da126f4e8dbdc825c Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Wed, 18 Oct 2023 13:20:58 -0400 Subject: [PATCH 1/2] add language to string function --- clang/include/clang/Basic/

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Formatting is good. I created a PR against `clang-format` to convince the tool: https://github.com/llvm/llvm-project/pull/70360 https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Yusra Syeda via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

2023-10-26 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: We can still pass `-mllvm` for LTO builds. If we have a more lightweight version, then I wonder if we just fold that under the previous verification flag. Yeah I'd hold off on this until we have a more compelling reason to add it. https://github.com/llvm/llvm-project/pull/7028

[clang] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: None (CarolineConcatto) Changes This patch implements the builtins in Clang and the LLVM-IR intrinsic for the following: For BFADD , BFSUB, BFMAX, BFMIN, BFMAXNM and BFMINNM, for instance: svbfloat16_t svadd[_bf16]_m (svbool_t p

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
@@ -163,9 +163,9 @@ // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-mfpu=softvfp" // CHECK-ARM-EABIHF-NOT: as{{.*}}" "-matpcs" -// RUN: %clang --target=sparc-unknown-freebsd -### %s -fpic -no-integrated-as 2>&1 \ -// RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s -// CHECK-SPARC-P

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 brad0 wrote: I already removed the other OS specific tests as I enabled IAS

[clang] [Driver] Fix -r handling on Solaris (PR #70322)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/70322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Ed Maste via cfe-commits
https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Ed Maste via cfe-commits
https://github.com/emaste edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Ed Maste via cfe-commits
@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 emaste wrote: Maybe worth noting that in the commit message too but either w

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread Momchil Velikov via cfe-commits
@@ -64,26 +65,29 @@ class ImmCheck { }; class SVEType { - TypeSpec TS; bool Float, Signed, Immediate, Void, Constant, Pointer, BFloat; bool DefaultType, IsScalable, Predicate, PredicatePattern, PrefetchOp, Svcount; unsigned Bitwidth, ElementBitwidth, NumVector

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/69598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread Momchil Velikov via cfe-commits
@@ -383,6 +381,20 @@ class SVEEmitter { SmallVectorImpl> &Out); }; +const std::array SVEEmitter::Reinterprets = +{{{SVEType("c"), "s8"}, momchil-velikov wrote: Ok, I'll do that. https://github.com/llvm/llvm-project/pull/69598

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-10-26 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 closed https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/70262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 183158b - [Driver] Fix -r handling on Solaris (#70322)

2023-10-26 Thread via cfe-commits
Author: Rainer Orth Date: 2023-10-26T20:37:31+02:00 New Revision: 183158b4bc57131cc6223ee0fa9a540dfe7a0653 URL: https://github.com/llvm/llvm-project/commit/183158b4bc57131cc6223ee0fa9a540dfe7a0653 DIFF: https://github.com/llvm/llvm-project/commit/183158b4bc57131cc6223ee0fa9a540dfe7a0653.diff L

[clang] [Driver] Fix -r handling on Solaris (PR #70322)

2023-10-26 Thread Rainer Orth via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/70322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
@@ -247,12 +247,8 @@ std::unique_ptr AllocateTarget(const llvm::Triple &Triple, switch (os) { case llvm::Triple::Linux: return std::make_unique>(Triple, Opts); -case llvm::Triple::FreeBSD: brad0 wrote: Ya, even with support being removed I d

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-26 Thread Momchil Velikov via cfe-commits
@@ -954,13 +967,13 @@ std::string Intrinsic::replaceTemplatedArgs(std::string Name, TypeSpec TS, default: llvm_unreachable("Unknown predication specifier"); case 'd': - T = SVEType(TS, 'd'); + T = SVEType(TS, 'd', 1); momchil-velikov wr

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69809 >From c50e534591cadcd41759608bffdda3a01a304ea7 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 18:41:03 -0400 Subject: [PATCH] [Driver] Clean up unused architecture related bits for *BSD's - FreeBSD

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
@@ -191,11 +191,6 @@ // RUN: | FileCheck -check-prefix=CHECK-MIPS64-CPU %s // CHECK-MIPS64-CPU: "-target-cpu" "mips3" -// Check that the integrated assembler is enabled for SPARC64 brad0 wrote: Done. https://github.com/llvm/llvm-project/pull/69809

[clang] 15254eb - [Driver] Clean up unused architecture related bits for *BSD's (#69809)

2023-10-26 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-26T14:44:12-04:00 New Revision: 15254eb74039c2c0bd7695d87e71890868f8e308 URL: https://github.com/llvm/llvm-project/commit/15254eb74039c2c0bd7695d87e71890868f8e308 DIFF: https://github.com/llvm/llvm-project/commit/15254eb74039c2c0bd7695d87e71890868f8e308.diff LO

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/70366 Fixes a bug introduced by commit b54294e2c959 ("[clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first") In the added test case, the QualType is a LValueReferenceTy

<    1   2   3   4   5   >