[clang] [Driver] Fix -r handling on Solaris (PR #70322)

2023-10-26 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/70322 As discussed in [[Driver] Link Flang runtime on Solaris](https://github.com/llvm/llvm-project/pull/65644), `clang -r` incorrectly passes both `-Bdynamic` and `-e _start` to `ld` which lets the linker choke. This

[clang] [Driver] Fix -r handling on Solaris (PR #70322)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Rainer Orth (rorth) Changes As discussed in [[Driver] Link Flang runtime on Solaris](https://github.com/llvm/llvm-project/pull/65644), `clang -r` incorrectly passes both `-Bdynamic` and `-e _start` to `ld` which lets the linker ch

[clang] [clang][Interp] Correctly emit destructors for multi-dimensional arrays (PR #69140)

2023-10-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69140 >From 8476b0b2b2666310048fe58dbd2e1ffc7a0fb21d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 16 Oct 2023 06:09:36 +0200 Subject: [PATCH] [clang][Interp] Correctly emit destructors for

[clang] [clang][Interp] Correctly emit destructors for multi-dimensional arrays (PR #69140)

2023-10-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69140 >From 93e7bdec10a51a6f783e51d8880b73fcc8300e29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 16 Oct 2023 06:09:36 +0200 Subject: [PATCH] [clang][Interp] Correctly emit destructors for

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM though I have some NFC suggestions you can take or leave. https://github.com/llvm/llvm-project/pull/70296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -1739,10 +1734,8 @@ class DeclContext { uint64_t IsSimpleExplicit : 1; }; - /// Number of non-inherited bits in CXXConstructorDeclBitfields. - enum { -NumCXXConstructorDeclBits = 64 - NumDeclContextBits - NumFunctionDeclBits - }; + /// Number of inherited and

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -1663,11 +1663,12 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { /// Actually an ArrayType::ArraySizeModifier. unsigned SizeModifier : 3; }; + enum { NumArrayTypeBits = NumTypeBits + 3 + 3 }; AaronBallman wrote: ```sugges

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -1819,10 +1812,10 @@ class DeclContext { SourceLocation AtStart; }; - /// Number of non-inherited bits in ObjCContainerDeclBitfields. + /// Number of inherited and non-inherited bits in ObjCContainerDeclBitfields. /// Note that here we rely on the fact that Sourc

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Piotr Zegar via cfe-commits
@@ -54,31 +56,43 @@ static bool shouldBeDefaultMemberInitializer(const Expr *Value) { } namespace { + AST_MATCHER_P(FieldDecl, indexNotLessThan, unsigned, Index) { return Node.getFieldIndex() >= Index; } + +enum class AssignedLevel { None, Assigned, UnsafetyAssigned }; +

[clang] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-10-26 Thread via cfe-commits
DonatNagyE wrote: I also think that the [reports](https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_errno_alpha_unix&newcheck=postgres_REL_13_0_errno_unix&is-unique=on&diff-type=New&report-id=3253666&report-hash=b4e0b723164236269fe6078ad32a0456&report

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
https://github.com/Hardcode84 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
https://github.com/Hardcode84 edited https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,209 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
https://github.com/Hardcode84 edited https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,209 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-26 Thread Ivan Butygin via cfe-commits
https://github.com/Hardcode84 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70306 >From 33d24cd22642d2a6f9b00aaa3826472381e93d33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Da

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Piotr Zegar via cfe-commits
@@ -250,7 +250,8 @@ Changes in existing checks - Improved :doc:`cppcoreguidelines-prefer-member-initializer ` check to - ignore delegate constructors. + ignore delegate constructors and ignore re-assignment for reference or after + unsafety assignment. Pi

[clang] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-10-26 Thread via cfe-commits
https://github.com/DonatNagyE commented: I'd say that the `readlink` modeling tweak is not a blocking issue; but the bug reports coming from "size is zero" corner case should be clarified (in a separate commit) before merging this. As these are both easy to fix, I hope that we can move this ch

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman requested changes to this pull request. Agreed with others; what's the in-tree use case for this? https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Piotr Zegar via cfe-commits
@@ -54,31 +56,43 @@ static bool shouldBeDefaultMemberInitializer(const Expr *Value) { } namespace { + AST_MATCHER_P(FieldDecl, indexNotLessThan, unsigned, Index) { return Node.getFieldIndex() >= Index; } + +enum class AssignedLevel { None, Assigned, UnsafetyAssigned }; -

[clang] e01efdd - [clang][Interp] Correctly emit destructors for multi-dimensional arrays (#69140)

2023-10-26 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-26T14:51:30+02:00 New Revision: e01efddbf3f977525707d25f500300f62b98fe28 URL: https://github.com/llvm/llvm-project/commit/e01efddbf3f977525707d25f500300f62b98fe28 DIFF: https://github.com/llvm/llvm-project/commit/e01efddbf3f977525707d25f500300f62b98fe28.diff L

[clang] [clang][Interp] Correctly emit destructors for multi-dimensional arrays (PR #69140)

2023-10-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only diagnose null field access in constant contexts (PR #69223)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69223 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Piotr Zegar via cfe-commits
@@ -570,3 +570,19 @@ struct PR52818 { int bar; }; + +struct RefReassignment { + RefReassignment(int &i) : m_i{i} { +m_i = 1; + } + int & m_i; +}; + +struct ReassignmentAfterUnsafetyAssignment { + ReassignmentAfterUnsafetyAssignment() { +int a = 10; +m_i =

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Just few nits, mainly naming. https://github.com/llvm/llvm-project/pull/70316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Ulrich Weigand via cfe-commits
uweigand wrote: This is intended to be used by the z/OS target, see the patch here: https://github.com/llvm/llvm-project/pull/68926 I asked Yusra to pull this part out into a separate PR. https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commit

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70306 >From 33d24cd22642d2a6f9b00aaa3826472381e93d33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/6 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/6 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

2023-10-26 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -109,6 +109,8 @@ struct Descriptor final { const bool IsTemporary = false; /// Flag indicating if the block is an array. const bool IsArray = false; + /// Flag indicating if this is a dummy descriptor. + const bool I

[clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-26 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-26 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6282b74 - [clang][Interp][NFC] Fix a doc comment

2023-10-26 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-26T15:09:42+02:00 New Revision: 6282b745e09d57a29e8221db638a7d393d66608d URL: https://github.com/llvm/llvm-project/commit/6282b745e09d57a29e8221db638a7d393d66608d DIFF: https://github.com/llvm/llvm-project/commit/6282b745e09d57a29e8221db638a7d393d66608d.diff LO

[clang] 1b6b4d6 - [analyzer] Loop should contain CXXForRangeStmt (#70190)

2023-10-26 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-10-26T21:11:51+08:00 New Revision: 1b6b4d6a08321fb914127dadcd6677dcd9b1b222 URL: https://github.com/llvm/llvm-project/commit/1b6b4d6a08321fb914127dadcd6677dcd9b1b222 DIFF: https://github.com/llvm/llvm-project/commit/1b6b4d6a08321fb914127dadcd6677dcd9b1b222.diff LOG:

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-26 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > This is intended to be used by the z/OS target, see the patch here: #68926 > > I asked Yusra to pull this part out into a separate PR. Thank you for the context! https://github.com/llvm/llvm-project/pull/69487 ___ cfe-commits ma

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: @@ -109,6 +109,8 @@ struct Descriptor final { const bool IsTemporary = false; /// Flag indicating if the block is an array. const bool IsArray = false; + /// Flag indicating if this is a dummy descriptor. + const b

[clang] 7f677fe - [clang][Interp] Add explicit dummy descriptors (#68888)

2023-10-26 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-26T15:15:25+02:00 New Revision: 7f677fe3100131214386f9ce1fa308c235a595e9 URL: https://github.com/llvm/llvm-project/commit/7f677fe3100131214386f9ce1fa308c235a595e9 DIFF: https://github.com/llvm/llvm-project/commit/7f677fe3100131214386f9ce1fa308c235a595e9.diff L

[clang] [clang][Interp] Add explicit dummy descriptors (PR #68888)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/6 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -43,6 +43,7 @@ enum class Language : uint8_t { HLSL, ///@} }; +const char *languageToString(Language L); AaronBallman wrote: ```suggestion StringRef languageToString(Language L); ``` https://github.com/llvm/llvm-project/pull/69487 _

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" AaronBallman wrote: Let's drop this, it's kind of overkill for an unreachable message. htt

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[clang] [clang] Language to String function (PR #69487)

2023-10-26 Thread Aaron Ballman via cfe-commits
@@ -10,9 +10,49 @@ #include "clang/Config/config.h" #include "llvm/ADT/StringSwitch.h" #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/FormatVariadic.h" #include "llvm/TargetParser/Triple.h" using namespace clang; +const char *clang::languageToString(Languag

[libunwind] Complex range (PR #70244)

2023-10-26 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 01/11] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang-tools-extra] [libc++] Make sure we implement and test LWG2280 properly (PR #67670)

2023-10-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/67670 >From 72bda6810909f90f22dc77a04cabf0b4c19668cf Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 26 Sep 2023 19:02:00 -0400 Subject: [PATCH 1/2] [libc++] Make sure we implement and test LWG2280 properly We

[libunwind] Complex range (PR #70244)

2023-10-26 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 01/11] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] [clang][Interp] Only diagnose null field access in constant contexts (PR #69223)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69223 >From a4610e034b8331b201e282ef034e83095cbe395f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Da

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie created https://github.com/llvm/llvm-project/pull/70330 This test has been failing since the SPIR-V backend started failing explicitly on unsupported shader types. Switched this test to a compute shader since it is currently the only type supported. >From 4738a5

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Natalie Chouinard (sudonatalie) Changes This test has been failing since the SPIR-V backend started failing explicitly on unsupported shader types. Switched this test to a compute shader since it is currently the only type supporte

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts edited https://github.com/llvm/llvm-project/pull/70330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Nathan Gauër via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts commented: One question, otherwise LGTM, thanks for this! https://github.com/llvm/llvm-project/pull/70330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix several `-Wdocumentation` warnings (NFC) (PR #70333)

2023-10-26 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/70333 ``` clang/include/clang/Lex/Preprocessor.h:2893:14: warning: parameter 'isEnter:' not found in the function declaration [-Wdocumentation] /// \param isEnter: true if this PP is entering a region; otherwise, t

[clang] [Clang] Fix several `-Wdocumentation` warnings (NFC) (PR #70333)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes ``` clang/include/clang/Lex/Preprocessor.h:2893:14: warning: parameter 'isEnter:' not found in the function declaration [-Wdocumentation] /// \param isEnter: true if this PP is entering a region; otherwise,

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski updated https://github.com/llvm/llvm-project/pull/67000 >From f1d803c4f581a9212368ac775036b97b3144a67c Mon Sep 17 00:00:00 2001 From: Dominik Adamski Date: Thu, 26 Oct 2023 05:30:38 -0500 Subject: [PATCH 1/2] [NFC][clang][OpenMP] Update OpenMP clang tests Repl

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1026,25 +1026,25 @@ for (int i = 0; i < argc; ++i) { // CHECK3-NEXT:call void @llvm.experimental.noalias.scope.decl(metadata [[META8:![0-9]+]]) // CHECK3-NEXT:call void @llvm.experimental.noalias.scope.decl(metadata [[META10:![0-9]+]]) // CHECK3-NEXT:call void

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [OpenMP][OMPIRBuilder] Add support to omp target parallel (PR #67000)

2023-10-26 Thread Dominik Adamski via cfe-commits
@@ -1126,6 +1133,185 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag, Builder.SetInsertPoint(NonCancellationBlock, NonCancellationBlock->begin()); } +// Callback used to create OpenMP runtime calls to support +// omp parallel clause for the device. +// W

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Natalie Chouinard via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-26 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From 9b559ac5504593ab7aa21539b49ece7eea944eb5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH 1/2] [Clang] Diagnose defaulted assignment operator with incomp

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie updated https://github.com/llvm/llvm-project/pull/65989 >From 4738a535e24114ce24647f0935b1cec897bf0a1b Mon Sep 17 00:00:00 2001 From: Natalie Chouinard Date: Thu, 26 Oct 2023 13:21:23 + Subject: [PATCH 1/4] [HLSL][SPIR-V] Fix clang driver lang target test Thi

[clang] [Clang] Fix several `-Wdocumentation` warnings (NFC) (PR #70333)

2023-10-26 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/70333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Nathan Gauër via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie edited https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][SPIR-V] Fix clang driver lang target test (PR #70330)

2023-10-26 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/70330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Natalie Chouinard via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] ba11d31 - [clang][Interp] Only diagnose null field access in constant contexts (#69223)

2023-10-26 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-26T16:15:29+02:00 New Revision: ba11d314a67638454989d4e0aebae64145d1a8ac URL: https://github.com/llvm/llvm-project/commit/ba11d314a67638454989d4e0aebae64145d1a8ac DIFF: https://github.com/llvm/llvm-project/commit/ba11d314a67638454989d4e0aebae64145d1a8ac.diff L

[clang] [clang][Interp] Only diagnose null field access in constant contexts (PR #69223)

2023-10-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Nathan Gauër via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie updated https://github.com/llvm/llvm-project/pull/65989 >From 331e1a92f2d93dcd5e7e1cae25ce51f33b2c8ffe Mon Sep 17 00:00:00 2001 From: Natalie Chouinard Date: Mon, 11 Sep 2023 18:08:17 + Subject: [PATCH 1/3] [SPIRV] Add -spirv option to DXC driver Add an optio

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-26 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From ba3bb1ae28c14f6720e17d26e037c7406a638436 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/6] [flang][Driver] Support -rpath, -shared, and -static in t

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-26 Thread via cfe-commits
https://github.com/tomekpaszek created https://github.com/llvm/llvm-project/pull/70338 None >From 8404d703d58658593e6112b478533edb124cd0e1 Mon Sep 17 00:00:00 2001 From: Tomek Paszek Date: Thu, 26 Oct 2023 16:19:36 +0200 Subject: [PATCH] Added an option to ignore macro definitions. --- clang

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-26 Thread via cfe-commits
https://github.com/tomekpaszek edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-26 Thread Natalie Chouinard via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

2023-10-26 Thread via cfe-commits
Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/68191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

2023-10-26 Thread via cfe-commits
Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -72,21 +72,36 @@ EnumValueVector getDeclValuesForEnum(const EnumDecl *ED) { EnumValueVector DeclValues( std::distance(ED->enumerator_begin(), ED->enumerator_end())); llvm::transform(ED->e

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

2023-10-26 Thread via cfe-commits
Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= Message-ID: In-Reply-To: https://github.com/DonatNagyE approved this pull request. https://github.com/llvm/llvm-project/pull/68191 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-26 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From cf4ae971c3fd30f705fa79b8b918288649766d14 Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] add module builtin headers relative to resource dir When inc

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/70296 >From 9a20b9609c5d4c18772907e82af4995411c42da6 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 26 Oct 2023 09:04:22 +0300 Subject: [PATCH 1/2] [clang][NFC] Refactor enums that hold size of Type and

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
@@ -1819,10 +1812,10 @@ class DeclContext { SourceLocation AtStart; }; - /// Number of non-inherited bits in ObjCContainerDeclBitfields. + /// Number of inherited and non-inherited bits in ObjCContainerDeclBitfields. /// Note that here we rely on the fact that Sourc

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
@@ -1739,10 +1734,8 @@ class DeclContext { uint64_t IsSimpleExplicit : 1; }; - /// Number of non-inherited bits in CXXConstructorDeclBitfields. - enum { -NumCXXConstructorDeclBits = 64 - NumDeclContextBits - NumFunctionDeclBits - }; + /// Number of inherited and

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
@@ -1663,11 +1663,12 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { /// Actually an ArrayType::ArraySizeModifier. unsigned SizeModifier : 3; }; + enum { NumArrayTypeBits = NumTypeBits + 3 + 3 }; Endilll wrote: Applied. http

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Alex Bradbury via cfe-commits
asb wrote: @dtcxzyw Could you please confirm the status of this core - is it commercially available, an academic test chip, something else? https://github.com/llvm/llvm-project/pull/70294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [libc++] Fix complexity guarantee in std::clamp (PR #68413)

2023-10-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68413 >From 24d5794c366670fb4d8fe3ec72c27d7c9ef335b9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 6 Oct 2023 08:57:23 -0400 Subject: [PATCH 1/2] [libc++] Fix complexity guarantee in std::clamp This patch pre

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/70341 Fixes https://github.com/llvm/llvm-project/issues/65858 >From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 26 Oct 2023 10:53:06 -0400 Subject: [PATCH] Dia

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Aaron Ballman (AaronBallman) Changes Fixes https://github.com/llvm/llvm-project/issues/65858 --- Full diff: https://github.com/llvm/llvm-project/pull/70341.diff 5 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSem

[clang] [clang] Fix --entry command line option (PR #69114)

2023-10-26 Thread Sergei Barannikov via cfe-commits
@@ -5474,7 +5474,8 @@ def _dyld_prefix_EQ : Joined<["--"], "dyld-prefix=">; def _dyld_prefix : Separate<["--"], "dyld-prefix">, Alias<_dyld_prefix_EQ>; def _encoding_EQ : Joined<["--"], "encoding=">, Alias; def _encoding : Separate<["--"], "encoding">, Alias; -def _entry : Flag

[clang] [clang][NFC] Refactor enums that hold size of `Type` and `DeclContext` bit-fields (PR #70296)

2023-10-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/70296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Yinan Xu via cfe-commits
poemonsense wrote: > LGTM in general, except one question: will zicbom and zicboz be in the final > RTL? Yes, it's in the final RTL. https://github.com/llvm/llvm-project/pull/70294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread via cfe-commits
cor3ntin wrote: LGTM but it is missing a release note :) https://github.com/llvm/llvm-project/pull/70341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >