[clang] [clang]improve diagnosing redefined defaulted constructor with different exception specs (PR #69688)

2023-10-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 deleted https://github.com/llvm/llvm-project/pull/69688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Support fixed point types in C++ (#67750)" (PR #69963)

2023-10-24 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/69963 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/3] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/4] [clang]Transform uninstantiated ExceptionSpec in Template

[clang] [clang]improve diagnosing redefined defaulted constructor with different exception specs (PR #69688)

2023-10-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69688 >From 2629b346123f9838a4fc3d8b6fb6a98508773965 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 20 Oct 2023 15:45:42 +0800 Subject: [PATCH 1/2] [clang]improve diagnosing redefined defaulted constructor

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Aaron Ballman via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Aaron Ballman via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Aaron Ballman via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Aaron Ballman via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Aaron Ballman via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [flang] add tbaa tags to global and direct values (PR #68727)

2023-10-24 Thread Tom Eccles via cfe-commits
tblah wrote: @Renaud-K ping https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

2023-10-24 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Alright, looks like @shafik isn't going to review this, so I'll just have to accept it. LGTM. https://github.com/llvm/llvm-project/pull/69521 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Erich Keane via cfe-commits
@@ -455,6 +455,10 @@ Bug Fixes in This Version cannot be used with ``Release`` mode builds. (`#68237 `_). - Fix crash in evaluating ``constexpr`` value for invalid template function. Fixes (`#68542

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. LGTM, please update the release notes if it fixes that bug too. https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. LGTM, please update the release notes if it fixes that bug too. https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

2023-10-24 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Alright, looks like @shafik isn't going to review this, so I'll just have to > accept it. LGTM. FWIW, he was out of town all last week and a bit of the week before that. I think he's still digging out from under the mountain of email. Changes LGTM as well! https://githu

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/70046 This allows querying whether, given the flow condition, a certain formula still has a solution (though it is not necessarily implied by the flow condition, as `flowConditionImplies()` would check). This can

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes This allows querying whether, given the flow condition, a certain formula still has a solution (though it is not necessarily implied by the flow condition, as `flowConditionImplies()` would check). This can be c

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [AArch64] Implement reinterpret builtins for SVE vector tuples (PR #69598)

2023-10-24 Thread Momchil Velikov via cfe-commits
@@ -263,17 +267,11 @@ class SVEEmitter { // which is inconvenient to specify in the arm_sve.td file or // generate in CGBuiltin.cpp. struct ReinterpretTypeInfo { +SVEType BaseType; const char *Suffix; -const char *Type; -const char *BuiltinType; }; -

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Shilei Tian via cfe-commits
shiltian wrote: Waiting for the evaluation, if possible https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-24 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Could you please revert? It was already reverted in https://github.com/llvm/llvm-project/commit/2e955c0504d4cc529e33e0342b60183170b5c815. https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits

[clang] [clang][Interp] Only diagnose null field access in constant contexts (PR #69223)

2023-10-24 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: @@ -295,7 +295,7 @@ class Pointer { bool isUnion() const; /// Checks if the storage is extern. - bool isExtern() const { return Pointee->isExtern(); } + bool isExtern() const { return Pointee && Pointee->isExtern();

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/70018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correct end for the `CastOperation.OpRange` (PR #69480)

2023-10-24 Thread Botond István Horváth via cfe-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/69480 From c06535386eb736fc11397cf11efaa8d52fdae4fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Botond=20Istv=C3=A1n=20Horv=C3=A1th?= <56926027+hob...@users.noreply.github.com> Date: Wed, 18 Oct 2023 18:05:01 +0200 Subject

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie updated https://github.com/llvm/llvm-project/pull/65989 >From 46b615e1c40ca89b8d4b9e924c139a5e9c430565 Mon Sep 17 00:00:00 2001 From: Natalie Chouinard Date: Mon, 11 Sep 2023 18:08:17 + Subject: [PATCH 1/2] [SPIRV] Add -spirv option to DXC driver Add an optio

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie edited https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1f02743 - Reland "Add Documentation for Execution Results Handling in Clang-Repl (#65650)"

2023-10-24 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2023-10-24T14:43:00Z New Revision: 1f02743851d82d6515f49f5b4379b9793d5ff5c9 URL: https://github.com/llvm/llvm-project/commit/1f02743851d82d6515f49f5b4379b9793d5ff5c9 DIFF: https://github.com/llvm/llvm-project/commit/1f02743851d82d6515f49f5b4379b9793d5ff5c9.diff LO

[clang] d8a5c79 - [clang][Sema] Correct end for the `CastOperation.OpRange` (#69480)

2023-10-24 Thread via cfe-commits
Author: Botond István Horváth Date: 2023-10-24T16:44:12+02:00 New Revision: d8a5c79e8e006cf878e05aa316367c9684193117 URL: https://github.com/llvm/llvm-project/commit/d8a5c79e8e006cf878e05aa316367c9684193117 DIFF: https://github.com/llvm/llvm-project/commit/d8a5c79e8e006cf878e05aa316367c96841931

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Jose Manuel Monsalve Diaz via cfe-commits
josemonsalve2 wrote: > Waiting for the evaluation, if possible Thanks Shilai, Chenle is working on the evaluation. The one aspect that we are still not sure what to do about is if we should split this up into multiple PRs or not. https://github.com/llvm/llvm-project/pull/66919 _

[clang] [clang] Correct end for the `CastOperation.OpRange` (PR #69480)

2023-10-24 Thread via cfe-commits
https://github.com/whisperity closed https://github.com/llvm/llvm-project/pull/69480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-24 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Shilei Tian via cfe-commits
shiltian wrote: I'd prefer to split it into at least one front end and one runtime, both with proper tests. https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-10-24 Thread via cfe-commits
https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/70053 This patch removes the two `FIXME`s that were added with patches related to the expression mentioned in the title. >From 7cca7a3a6d969318fb8531751f75bb41715c7475 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-10-24 Thread via cfe-commits
@@ -816,22 +816,18 @@ bool ByteCodeExprGen::VisitArrayInitLoopExpr( const ArrayInitLoopExpr *E) { assert(Initializing); assert(!DiscardResult); + + // We visit the common opaque expression here once so we have its value + // cached. + if (!this->discard(E->getCommonE

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (isuckatcs) Changes This patch removes the two `FIXME`s that were added with patches related to the expression mentioned in the title. --- Full diff: https://github.com/llvm/llvm-project/pull/70053.diff 2 Files Affected: - (modifi

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-24 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/69534 >From cd6fbd376f6d6f13074aa5751480d2a429bac444 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Wed, 18 Oct 2023 13:21:17 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate syntax of map modifiers without comma sep

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Jose Manuel Monsalve Diaz via cfe-commits
josemonsalve2 wrote: My concern is how to split it up is I do not know a set of features that can work independently to each other. We can add the ompx infrastructure in one, but it won't be used by anything in that PR. Will that be ok? https://github.com/llvm/llvm-project/pull/66919

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-10-24 Thread Timm Baeder via cfe-commits
@@ -816,22 +816,18 @@ bool ByteCodeExprGen::VisitArrayInitLoopExpr( const ArrayInitLoopExpr *E) { assert(Initializing); assert(!DiscardResult); + + // We visit the common opaque expression here once so we have its value + // cached. + if (!this->discard(E->getCommonE

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Shilei Tian via cfe-commits
shiltian wrote: By "ompx infrastructure" do you mean the frond end code? https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-24 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I think the changes are reasonable, but should come with a release note so users know about the change in diagnostic behavior. (We have a section in `clang/docs/ReleaseNotes.rst` for diagnostic improvements.) Otherwise, I think the changes LGTM https

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Jose Manuel Monsalve Diaz via cfe-commits
josemonsalve2 wrote: I mean front end code minus the taskgraph directive part. Just the part that allows for ompx to be used. If we include the taskgraph, then it will generate code that cannot be linked. So it would be a PR that will not work for programs. https://github.com/llvm/llvm-proj

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
https://github.com/sudonatalie updated https://github.com/llvm/llvm-project/pull/65989 >From 46b615e1c40ca89b8d4b9e924c139a5e9c430565 Mon Sep 17 00:00:00 2001 From: Natalie Chouinard Date: Mon, 11 Sep 2023 18:08:17 + Subject: [PATCH 1/4] [SPIRV] Add -spirv option to DXC driver Add an optio

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
sudonatalie wrote: Left this on the back burner for a bit, but it would be nice to land now. @llvm-beanz or @bogner Can you take a look? https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Driver] Add `--` to some test clang-cl command lines. (PR #70055)

2023-10-24 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm created https://github.com/llvm/llvm-project/pull/70055 If clang/test/Driver/cl-offload.cu is run on Unix in a directory whose absolute pathname starts with `/w`, such as the `/workspace` used by at least some Jenkins CI setups, then the file name on the clang co

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Chris B via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [Driver] Add `--` to some test clang-cl command lines. (PR #70055)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Simon Tatham (statham-arm) Changes If clang/test/Driver/cl-offload.cu is run on Unix in a directory whose absolute pathname starts with `/w`, such as the `/workspace` used by at least some Jenkins CI setups, then the file name on t

[clang] [analyzer] Improve reports from ArrayBoundCheckerV2 (PR #70056)

2023-10-24 Thread via cfe-commits
https://github.com/DonatNagyE created https://github.com/llvm/llvm-project/pull/70056 Previously alpha.security.ArrayBoundV2 produced very spartan bug reports; this commit ensures that the relevant (and known) details are reported to the user. The logic for detecting bugs is not changed, after

[clang] [analyzer] Improve reports from ArrayBoundCheckerV2 (PR #70056)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (DonatNagyE) Changes Previously alpha.security.ArrayBoundV2 produced very spartan bug reports; this commit ensures that the relevant (and known) details are reported to the user. The logic for detecting bugs is not changed, after thi

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-24 Thread Simon Tatham via cfe-commits
statham-arm wrote: @yxsamliu I've just raised https://github.com/llvm/llvm-project/pull/70055 which fixes an issue with the new test here. Perhaps it might also allow you to remove the exclusion for `system-darwin`? https://github.com/llvm/llvm-project/pull/68921 __

[clang] [clang][Interp] Cleaning up `FIXME`s added during `ArrayInitLoopExpr` implementation. (PR #70053)

2023-10-24 Thread via cfe-commits
@@ -816,22 +816,18 @@ bool ByteCodeExprGen::VisitArrayInitLoopExpr( const ArrayInitLoopExpr *E) { assert(Initializing); assert(!DiscardResult); + + // We visit the common opaque expression here once so we have its value + // cached. + if (!this->discard(E->getCommonE

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-24 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > @yxsamliu I've just raised #70055 which fixes an issue with the new test > here. Perhaps it might also allow you to remove the exclusion for > `system-darwin`? Yes it should allow it to remove exclusion of system-darwin. Thanks https://github.com/llvm/llvm-project/pull/68921

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-10-24 Thread Shilei Tian via cfe-commits
shiltian wrote: It's fine that it will generate code that cannot be linked, as long as we don't have runtime use. We just need to check generated IR. https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [Driver] Add `--` to some test clang-cl command lines. (PR #70055)

2023-10-24 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: can you remove // REQUIRES: !system-darwin ? Thanks. https://github.com/llvm/llvm-project/pull/70055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Improve reports from ArrayBoundCheckerV2 (PR #70056)

2023-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e3e21d2032216b5d01b47a0442638225e66dc1b 77143e74edda6177248bebdf0424db915aa68a05 --

[clang] [Driver] Add `--` to some test clang-cl command lines. (PR #70055)

2023-10-24 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/70055 >From 029eecc71b94130bb6d058c9f9d0779e32cd45f1 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Tue, 24 Oct 2023 15:52:38 +0100 Subject: [PATCH] [Driver] Add `--` to some test clang-cl command lines. If cla

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread Stanislav Gatev via cfe-commits
sgatev wrote: LGTM https://github.com/llvm/llvm-project/pull/70046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-24 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. Thanks, LGTM https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread Stanislav Gatev via cfe-commits
@@ -184,6 +192,12 @@ class DataflowAnalysisContext { addTransitiveFlowConditionConstraints(Atom Token, llvm::SetVector &Out); + /// Returns true if the solver is able to prove that there is a satisfying + /// assignment for `Constrai

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread Stanislav Gatev via cfe-commits
@@ -546,12 +546,29 @@ class Environment { Atom getFlowConditionToken() const { return FlowConditionToken; } /// Record a fact that must be true if this point in the program is reached. - void addToFlowCondition(const Formula &); + void assume(const Formula &); + + /// D

[clang] [clang][dataflow] Add `Environment::allows()`. (PR #70046)

2023-10-24 Thread Stanislav Gatev via cfe-commits
@@ -129,9 +129,17 @@ class DataflowAnalysisContext { /// token. Atom joinFlowConditions(Atom FirstToken, Atom SecondToken); - /// Returns true if and only if the constraints of the flow condition - /// identified by `Token` imply that `Val` is true. - bool flowCondition

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-24 Thread David Tenty via cfe-commits
https://github.com/daltenty approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 7c651a1 - [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (#69767)

2023-10-24 Thread via cfe-commits
Author: xingxue-ibm Date: 2023-10-24T11:55:22-04:00 New Revision: 7c651a1fc006929674c0795086144f099c61ff8c URL: https://github.com/llvm/llvm-project/commit/7c651a1fc006929674c0795086144f099c61ff8c DIFF: https://github.com/llvm/llvm-project/commit/7c651a1fc006929674c0795086144f099c61ff8c.diff L

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-24 Thread via cfe-commits
https://github.com/xingxue-ibm closed https://github.com/llvm/llvm-project/pull/69767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Congcong Cai via cfe-commits
@@ -455,6 +455,10 @@ Bug Fixes in This Version cannot be used with ``Release`` mode builds. (`#68237 `_). - Fix crash in evaluating ``constexpr`` value for invalid template function. Fixes (`#68542

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Congcong Cai via cfe-commits
@@ -455,6 +455,10 @@ Bug Fixes in This Version cannot be used with ``Release`` mode builds. (`#68237 `_). - Fix crash in evaluating ``constexpr`` value for invalid template function. Fixes (`#68542

[clang] [flang] add tbaa tags to global and direct values (PR #68727)

2023-10-24 Thread Renaud Kauffmann via cfe-commits
https://github.com/Renaud-K approved this pull request. https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9f3e340 - [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (#68878)

2023-10-24 Thread via cfe-commits
Author: Congcong Cai Date: 2023-10-25T00:01:22+08:00 New Revision: 9f3e3405603177c46b873fa219624b759e6ef851 URL: https://github.com/llvm/llvm-project/commit/9f3e3405603177c46b873fa219624b759e6ef851 DIFF: https://github.com/llvm/llvm-project/commit/9f3e3405603177c46b873fa219624b759e6ef851.diff

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-24 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 513b950 - Make -frewrite-includes handle -include correctly

2023-10-24 Thread Paul Robinson via cfe-commits
Author: Paul Robinson Date: 2023-10-24T09:08:31-07:00 New Revision: 513b950a79d0e92af1baa969207dd296068a71b9 URL: https://github.com/llvm/llvm-project/commit/513b950a79d0e92af1baa969207dd296068a71b9 DIFF: https://github.com/llvm/llvm-project/commit/513b950a79d0e92af1baa969207dd296068a71b9.diff

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69916 >From 58ebdda4e44b3fa2547d85a6cc9d5b0aa913b22a Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 23 Oct 2023 13:55:46 +0300 Subject: [PATCH 1/2] [clang][NFC] Refactor `Selector` to use `PointerIntPair`

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm commented: Thank you for reviewing this @david-arm! https://github.com/llvm/llvm-project/pull/69725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm edited https://github.com/llvm/llvm-project/pull/69725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
@@ -9893,24 +9888,37 @@ Value *CodeGenFunction::FormSVEBuiltinResult(Value *Call) { return Call; } -Value *CodeGenFunction::EmitAArch64SVEBuiltinExpr(unsigned BuiltinID, - const CallExpr *E) { +void CodeGenFunction::GetAArch6

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
@@ -1016,29 +1021,24 @@ std::string Intrinsic::mangleName(ClassKind LocalCK) const { getMergeSuffix(); } -void Intrinsic::emitIntrinsic(raw_ostream &OS, SVEEmitter &Emitter) const { +void Intrinsic::emitIntrinsic(raw_ostream &OS, ACLEKind Kind) const { bool IsOver

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
@@ -10272,29 +10291,13 @@ Value *CodeGenFunction::EmitAArch64SMEBuiltinExpr(unsigned BuiltinID, getContext().GetBuiltinType(BuiltinID, Error, &ICEArguments); kmclaughlin-arm wrote: I've removed this, it wasn't needed here now that it's checked in GetAArch64S

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-24 Thread Kerry McLaughlin via cfe-commits
@@ -9893,24 +9888,37 @@ Value *CodeGenFunction::FormSVEBuiltinResult(Value *Call) { return Call; } -Value *CodeGenFunction::EmitAArch64SVEBuiltinExpr(unsigned BuiltinID, - const CallExpr *E) { +void CodeGenFunction::GetAArch6

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-24 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/69747 >From 8abc9204d4148f1b224623ac54d5f58e2ab04e6b Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 20 Oct 2023 11:03:30 -0700 Subject: [PATCH 1/2] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO Transl

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-24 Thread Min-Yih Hsu via cfe-commits
@@ -694,6 +694,16 @@ void tools::addLTOOptions(const ToolChain &ToolChain, const ArgList &Args, CmdArgs.push_back(Args.MakeArgString(Twine(PluginOptPrefix) + ParallelismOpt + Parallelism)); + // Pass down GlobalISel options. + if

[clang] ebf4c69 - [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (#69747)

2023-10-24 Thread via cfe-commits
Author: Min-Yih Hsu Date: 2023-10-24T09:13:01-07:00 New Revision: ebf4c698c35662087bc52f54c6ea51e2e263b101 URL: https://github.com/llvm/llvm-project/commit/ebf4c698c35662087bc52f54c6ea51e2e263b101 DIFF: https://github.com/llvm/llvm-project/commit/ebf4c698c35662087bc52f54c6ea51e2e263b101.diff L

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-24 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave closed https://github.com/llvm/llvm-project/pull/69747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-24 Thread Krzysztof Drewniak via cfe-commits
https://github.com/krzysz00 updated https://github.com/llvm/llvm-project/pull/69126 >From 357a21c38c1036a012affc85026fcba376ab7128 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sun, 15 Oct 2023 13:20:31 -0700 Subject: [PATCH 1/2] [Sema] -Wzero-as-null-pointer-constant: don't warn for

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-24 Thread Arseny Kapoulkine via cfe-commits
https://github.com/zeux updated https://github.com/llvm/llvm-project/pull/69126 >From 357a21c38c1036a012affc85026fcba376ab7128 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sun, 15 Oct 2023 13:20:31 -0700 Subject: [PATCH 1/2] [Sema] -Wzero-as-null-pointer-constant: don't warn for __nul

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff febf5c97bba7910e796041c9518fce01f31ae826 3cae7350cc4eed7c3f23e812afe3ee50f465fce3 --

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-24 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-10-24 Thread Natalie Chouinard via cfe-commits
@@ -2,8 +2,8 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-pixel %s -S -o /dev/null 2>&1 | FileCheck --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-shadermodel6.2-library %s -S -o /dev/null 2>&1 | FileCheck --check-prefix

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-24 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69916 >From 58ebdda4e44b3fa2547d85a6cc9d5b0aa913b22a Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 23 Oct 2023 13:55:46 +0300 Subject: [PATCH 1/3] [clang][NFC] Refactor `Selector` to use `PointerIntPair`

[clang] 16fe53c - [NFC][Clang] Remove unused variable "AOBFileNames"

2023-10-24 Thread Juan Manuel MARTINEZ CAAMAÑO via cfe-commits
Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-10-24T18:28:33+02:00 New Revision: 16fe53c47e3a83bfca9795e59aa664976620c034 URL: https://github.com/llvm/llvm-project/commit/16fe53c47e3a83bfca9795e59aa664976620c034 DIFF: https://github.com/llvm/llvm-project/commit/16fe53c47e3a83bfca9795e59aa6649

[clang-tools-extra] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-24 Thread Arseny Kapoulkine via cfe-commits
zeux wrote: Thanks! I've updated this PR with a release note. https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

2023-10-24 Thread Arseny Kapoulkine via cfe-commits
zeux wrote: Thanks! I've updated this PR with a release note. https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-24 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70018 >From c6edb59fe6283a751445d44724465eaad5d287cb Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 24 Oct 2023 11:20:30 +0200 Subject: [PATCH] [Clang] Mark declarators invalid in the presence of ill-formed

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-10-24 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg updated https://github.com/llvm/llvm-project/pull/65481 >From d5054bcc53dad87232a4969e1a1f978b8d5a593d Mon Sep 17 00:00:00 2001 From: Daniel Grumberg Date: Wed, 6 Sep 2023 12:20:30 +0100 Subject: [PATCH] [clang] Prioritze decl comments from macro expansion sit

<    1   2   3   4   >