[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @erichkeane I guess you'd be pretty happy if our enums were declared the following way: ```cpp enum E : unsigned _BitInt(4) { e0 = 16, }; ``` Then you'd be warned on the spot if you have more values than bits can hold, and bit-fields side check would be trivial to implement: ``

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/2] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/3] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang-tools-extra] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-19 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/69277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
@@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) { "-bugprone-use-after-move", // Alias for bugprone-use-after-move. "-hicpp-invalid-access-moved", + // Check uses dataflow analysis, which might hang/crash unexpectedl

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (PR #69370)

2023-10-19 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/69370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (PR #69370)

2023-10-19 Thread Haojian Wu via cfe-commits
@@ -77,9 +77,15 @@ class BodyIndexer : public RecursiveASTVisitor { const Stmt *Parent = *It; if (auto BO = dyn_cast(Parent)) { - if (BO->getOpcode() == BO_Assign && BO->getLHS()->IgnoreParenCasts() == E) -Roles |= (unsigned)SymbolRole::Write; - + if

[clang] [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (PR #69370)

2023-10-19 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. good catch. https://github.com/llvm/llvm-project/pull/69370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread kadir çetinkaya via cfe-commits
kadircet wrote: thanks for the pointers @HighCommander4 ! https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] e63ab13 - [clangd] Disable crashy unchecked-optional-access tidy check (#69427)

2023-10-19 Thread via cfe-commits
Author: kadir çetinkaya Date: 2023-10-19T09:24:22+02:00 New Revision: e63ab13c82e78f65baca48d5b5e4f6ea8d55dbc7 URL: https://github.com/llvm/llvm-project/commit/e63ab13c82e78f65baca48d5b5e4f6ea8d55dbc7 DIFF: https://github.com/llvm/llvm-project/commit/e63ab13c82e78f65baca48d5b5e4f6ea8d55dbc7.dif

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 created https://github.com/llvm/llvm-project/pull/69567 Currently __builtin_read_exec_hi lowers to llvm.read_register, this patch lowers it to use amdgcn_ballot. >From 340e633da9e3ab10efc0c0d430b9546cd2f19cfe Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Th

[clang] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Rana Pratap Reddy (ranapratap55) Changes Currently __builtin_read_exec_hi lowers to llvm.read_register, this patch lowers it to use amdgcn_ballot. --- Full diff: https://github.com/llvm/llvm-project/pull/69567.diff 2 Files Affec

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: This may be a good candidate for a 17.0.x backport. https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-19 Thread kadir çetinkaya via cfe-commits
kadircet wrote: yeah, initiated that (i think) already in https://github.com/llvm/llvm-project/issues/69568 https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Iain Sandoe via cfe-commits
@@ -922,6 +922,10 @@ def err_header_import_semi_in_macro : Error< def err_header_import_not_header_unit : Error< "header file %0 (aka '%1') cannot be imported because " "it is not known to be a header unit">; +def warn_pp_include_angled_in_module_purview : Warning< + "'#in

[clang] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e63ab13c82e78f65baca48d5b5e4f6ea8d55dbc7 340e633da9e3ab10efc0c0d430b9546cd2f19cfe --

[clang] [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (PR #69370)

2023-10-19 Thread Aleksandr Platonov via cfe-commits
@@ -77,9 +77,15 @@ class BodyIndexer : public RecursiveASTVisitor { const Stmt *Parent = *It; if (auto BO = dyn_cast(Parent)) { - if (BO->getOpcode() == BO_Assign && BO->getLHS()->IgnoreParenCasts() == E) -Roles |= (unsigned)SymbolRole::Write; - + if

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Iain Sandoe via cfe-commits
https://github.com/iains commented: When I suggested this, it was an intention to limit it to C++ std library headers. Do we not have some existing mechanism that knows which headers are in this category (for typo correction etc?) My concern with making it more general is that it then covers

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
@@ -922,6 +922,10 @@ def err_header_import_semi_in_macro : Error< def err_header_import_not_header_unit : Error< "header file %0 (aka '%1') cannot be imported because " "it is not known to be a header unit">; +def warn_pp_include_angled_in_module_purview : Warning< + "'#in

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Iain Sandoe via cfe-commits
https://github.com/iains commented: Is delayed template parsing an optimisation or a correctness measure? If it's an optimisation, then it seems that we should disable it for modules (because that then makes the modules cases correct). If it's needed for correctness, then we have more of a pro

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
https://github.com/yubingex007-a11y created https://github.com/llvm/llvm-project/pull/69569 None >From de699709ee73acf9f04a02471255bffdde9bd0cf Mon Sep 17 00:00:00 2001 From: Bing1 Yu Date: Thu, 19 Oct 2023 15:42:02 +0800 Subject: [PATCH] [X86][AMX] remove related code of X86PreAMXConfigPass

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > When I suggested this, it was an intention to limit it to C++ std library > headers. Do we not have some existing mechanism that knows which headers are > in this category (for typo correction etc?) As far as I can reach, we don't have such a mechanism. I was wondering if w

[clang] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/69567 >From 19582446dbabffb0b25f9fa8b8b62a06ce6a4c66 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Thu, 19 Oct 2023 12:52:13 +0530 Subject: [PATCH] [AMDGPU] Lower __builtin_read_exec_hi to use amdgcn_ballot -

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Iain Sandoe via cfe-commits
@@ -922,6 +922,10 @@ def err_header_import_semi_in_macro : Error< def err_header_import_not_header_unit : Error< "header file %0 (aka '%1') cannot be imported because " "it is not known to be a header unit">; +def warn_pp_include_angled_in_module_purview : Warning< + "'#in

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/68389 >From bdf991f4563e3aa840bec35b1678ad4fe8f9fbb6 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Fri, 6 Oct 2023 12:32:24 +0530 Subject: [PATCH 1/4] [Docs][LTO] Update HowToSubmitABug.rst for LTO crashes --- llv

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 edited https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-19 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 edited https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Is delayed template parsing an optimisation or a correctness measure? If it's > an optimisation, then it seems that we should disable it for modules (because > that then makes the modules cases correct). If it's needed for correctness, > then we have more of a problem - do

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
https://github.com/yubingex007-a11y edited https://github.com/llvm/llvm-project/pull/69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
https://github.com/yubingex007-a11y ready_for_review https://github.com/llvm/llvm-project/pull/69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Iain Sandoe via cfe-commits
iains wrote: > > When I suggested this, it was an intention to limit it to C++ std library > > headers. Do we not have some existing mechanism that knows which headers > > are in this category (for typo correction etc?) > > As far as I can reach, we don't have such a mechanism. Ah, that's un

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (yubingex007-a11y) Changes In https://reviews.llvm.org/D125075, we switched to use FastPreTileConfig in O0 and abandoned X86PreAMXConfigPass. --- Patch is 34.12 KiB, truncated to 20.00 KiB below, full version: https://github.

[clang] Support target names with dots in more utilities (PR #65812)

2023-10-19 Thread James Henderson via cfe-commits
jh7370 wrote: @dankm, is there a particular reason you haven't merged this change in yet? FWIW, the formatter check failed for some reason, but I'm not sure it's related to any formatting issue. Please verify by running clang-format on your changes before merging. https://github.com/llvm/llvm

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Iain Sandoe via cfe-commits
https://github.com/iains edited https://github.com/llvm/llvm-project/pull/69555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
https://github.com/yubingex007-a11y edited https://github.com/llvm/llvm-project/pull/69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread via cfe-commits
https://github.com/yubingex007-a11y edited https://github.com/llvm/llvm-project/pull/69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-19 Thread via cfe-commits
https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From 72f63b695c9ebd9c7032c4b754ff7965c28fad5c Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors --- .../include

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Markus Böck via cfe-commits
zero9178 wrote: According to the docs [0], MSVC actually defaults to `-fno-delayed-template-parsing` (`/Zc:twoPhase-` with MSVC CLI) if using C++20. This is due to `-std:c++20` implying `/permissive-` which implies `/Zc:twoPhase-`. We could therefore just disable it based on language version

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69555 >From 86663a35a7af039f9440af2cc1896e8b4cf33310 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 19 Oct 2023 11:28:01 +0800 Subject: [PATCH 1/2] [C++20] [Modules] Warn if we found #include in module purvi

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
@@ -922,6 +922,10 @@ def err_header_import_semi_in_macro : Error< def err_header_import_not_header_unit : Error< "header file %0 (aka '%1') cannot be imported because " "it is not known to be a header unit">; +def warn_pp_include_angled_in_module_purview : Warning< + "'#in

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > (in this context) Framework headers are like system (or user headers) but > searched by a different mechanism (so they are #include-ed). In principle, > the same constraints should apply - indicates a "system" > header and probably should not be included in the module purv

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via cfe-commits
lawben wrote: As nobody has come forward in the the last two days, I'm gonna merge this now. I'll have a look a mangling this for Microsoft in a follow-up, as this may require a few changes. I'm not yet sure what has to be changed for mangling. https://github.com/llvm/llvm-project/pull/69010 _

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b858309ddc977d5e70de54f3fa3888915b5fbc0c 49ead327fec98f5276a9667414668a05fb03c705 --

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > According to the docs [0], MSVC actually defaults to > `-fno-delayed-template-parsing` (`/Zc:twoPhase-` with MSVC CLI) if using > C++20. This is due to `-std:c++20` implying `/permissive-` which implies > `/Zc:twoPhase-`. We could therefore just disable it based on language

[clang] de65b6b - [Clang] Add __builtin_vectorelements to get number of elements in vector (#69010)

2023-10-19 Thread via cfe-commits
Author: Lawrence Benson Date: 2023-10-19T10:45:08+02:00 New Revision: de65b6bec6771fe50f3aa73fdb79594f675be456 URL: https://github.com/llvm/llvm-project/commit/de65b6bec6771fe50f3aa73fdb79594f675be456 DIFF: https://github.com/llvm/llvm-project/commit/de65b6bec6771fe50f3aa73fdb79594f675be456.dif

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-19 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69555 >From 86663a35a7af039f9440af2cc1896e8b4cf33310 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 19 Oct 2023 11:28:01 +0800 Subject: [PATCH 1/3] [C++20] [Modules] Warn if we found #include in module purvi

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9f0f606 - [clang] Provide an SSE4.2 implementation of identifier token lexer (#68962)

2023-10-19 Thread via cfe-commits
Author: serge-sans-paille Date: 2023-10-19T08:45:54Z New Revision: 9f0f6060810ebd3006f62149d4739fc54af68536 URL: https://github.com/llvm/llvm-project/commit/9f0f6060810ebd3006f62149d4739fc54af68536 DIFF: https://github.com/llvm/llvm-project/commit/9f0f6060810ebd3006f62149d4739fc54af68536.diff

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

2023-10-19 Thread via cfe-commits
https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ba47bc7 - [Clang][SVE2.1] Add pfalse builtin

2023-10-19 Thread Caroline Concatto via cfe-commits
Author: Caroline Concatto Date: 2023-10-19T08:55:32Z New Revision: ba47bc7fd41278926552becca758d42cf4f793c1 URL: https://github.com/llvm/llvm-project/commit/ba47bc7fd41278926552becca758d42cf4f793c1 DIFF: https://github.com/llvm/llvm-project/commit/ba47bc7fd41278926552becca758d42cf4f793c1.diff

[PATCH] D151199: [Clang][SVE2.1] Add pfalse builtin

2023-10-19 Thread Caroline via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba47bc7fd412: [Clang][SVE2.1] Add pfalse builtin (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151199/new/ https://reviews.l

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-19 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: GCC deprecation done: [commit details](https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=56ed1055b2f40ac162ae8d382280ac07a33f789f;hp=8f4bbdc28df6e87a7ad5ec5ca191a7a836a4f016). https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commi

[clang] 7338eb5 - Reapply "[dataflow] use true/false literals in formulas, rather than variables"

2023-10-19 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2023-10-19T11:34:08+02:00 New Revision: 7338eb561c48803ec244cd6116154163f56e9717 URL: https://github.com/llvm/llvm-project/commit/7338eb561c48803ec244cd6116154163f56e9717 DIFF: https://github.com/llvm/llvm-project/commit/7338eb561c48803ec244cd6116154163f56e9717.diff LO

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 1/4] [clang] Add clang::debug_info_type attribute --- clang

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -107,6 +107,10 @@ def NonBitField : SubsetSubjectisBitField()}], "non-bit-field non-static data members">; +def BitField : SubsetSubjectisBitField()}], + "bit-field non-static data members">; Endill

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -7219,6 +7219,18 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def DebugInfoTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows to alter type of a bitfield in debug information. +Such a

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -7219,6 +7219,18 @@ its underlying representation to be a WebAssembly ``funcref``. }]; } +def DebugInfoTypeDocumentation : Documentation { + let Category = DocCatField; + let Content = [{ +This attribute allows to alter type of a bitfield in debug information. +Such a

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -3153,6 +3153,8 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_unde

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -verify -DMISMATCH %s Endilll wrote: Tests are split now. `const` case is now checked and working as expected (qualifiers are ignored). https://git

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,28 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] 2b97fe2 - [clang][Interp][NFC] Add more tests for bitfield initializers

2023-10-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-19T11:46:43+02:00 New Revision: 2b97fe2e5158d3803c6d45a38e72c9cd308e2daf URL: https://github.com/llvm/llvm-project/commit/2b97fe2e5158d3803c6d45a38e72c9cd308e2daf DIFF: https://github.com/llvm/llvm-project/commit/2b97fe2e5158d3803c6d45a38e72c9cd308e2daf.diff LO

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 1/5] [clang] Add clang::debug_info_type attribute --- clang

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Have you seen the failing buildbots? https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Have you seen the failing buildbots? https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Have you seen the failing buildbots? https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben created https://github.com/llvm/llvm-project/pull/69582 Small fix for failing tests after merge of #69010. The tests need `REQUIRES` to ensure that the correct headers are available. I've also added a generic x86 build which does not need headers, so there is at least

[clang] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via cfe-commits
lawben wrote: @tbaederr Jupp, I'm on it. I was not aware that I had to add `REQUIRES` to all the tests for it to find the header files. I assumed they are always available. See #69582. https://github.com/llvm/llvm-project/pull/69010 ___ cfe-commits m

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Lawrence Benson (lawben) Changes Small fix for failing tests after merge of #69010. The tests need `REQUIRES` to ensure that the correct headers are available. I've also added a generic x86 build which does not need headers, so there is a

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: > _a)_ Is this the correct way to do this You don't need review for this I think. I can't review this patch. If it takes a while you should rather revert your original patch. > _b)_ can I trigger the full tests before merging to main to avoid a second > set of failed buildbot

[clang] Correctly compute conversion seq for args to fn with reversed param order (PR #68999)

2023-10-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: I think this is important that clang chooses not to error but only warn here as a clang extension (it already chooses to do so in cases when it the can match the function params([1](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaOverload.cpp#L10274-L10290) and

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-10-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 557771. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files: clang-to

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-10-19 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/tweaks/OrganizeImportsTests.cpp:35-41 + { + R"cpp( +#include "Te^stTU.h" +)cpp", + true, + {}}, + {"void foo(^) {}"

[clang] 202de4a - Fix __builtin_vectorelements tests with REQUIRES (#69582)

2023-10-19 Thread via cfe-commits
Author: Lawrence Benson Date: 2023-10-19T12:14:25+02:00 New Revision: 202de4a5c6edb82d50d4bd7586c4b1db5f51073d URL: https://github.com/llvm/llvm-project/commit/202de4a5c6edb82d50d4bd7586c4b1db5f51073d DIFF: https://github.com/llvm/llvm-project/commit/202de4a5c6edb82d50d4bd7586c4b1db5f51073d.dif

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Nikita Popov via cfe-commits
nikic wrote: The correct check is `REQUIRES: aarch64-registered-target`, not `REQUIRES: target=aarch64`. https://github.com/llvm/llvm-project/pull/69582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,30 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handleDebugInfoTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-19 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -verify %s + +struct A { + enum E : unsigned {}; + [[clang::preferred_type(E)]] unsigned b : 2; + [[clang::preferred_type(E)]] int b2 : 2; + // expected-warning@-1 {{underlying type 'unsigned int' of enumeration 'E' doesn't match bit-field

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

2023-10-19 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/69463 From aff47154ae4d45c2852382aed034ea44df4886d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH 1/3] [NFC][Clang] Remove u

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

2023-10-19 Thread via cfe-commits
Dominik =?utf-8?q?Wójt?= Message-ID: In-Reply-To: https://github.com/john-brawn-arm closed https://github.com/llvm/llvm-project/pull/67412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] b3c4f64 - [ARM] fix "+fp.dp" in multilib selection (#67412)

2023-10-19 Thread via cfe-commits
Author: Dominik Wójt Date: 2023-10-19T11:27:33+01:00 New Revision: b3c4f64943dcabe990c8d23c90de5e8c2cd199d0 URL: https://github.com/llvm/llvm-project/commit/b3c4f64943dcabe990c8d23c90de5e8c2cd199d0 DIFF: https://github.com/llvm/llvm-project/commit/b3c4f64943dcabe990c8d23c90de5e8c2cd199d0.diff

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

2023-10-19 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] GetSDLFromOffloadArchive and SDLSearch (PR #69463)

2023-10-19 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

2023-10-19 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/69463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0e1d723 - [clang][Interp][NFC] Use an APInt instead of APSint

2023-10-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-19T12:29:42+02:00 New Revision: 0e1d7239d6fddebdaf39e58eb931ff4916306b23 URL: https://github.com/llvm/llvm-project/commit/0e1d7239d6fddebdaf39e58eb931ff4916306b23 DIFF: https://github.com/llvm/llvm-project/commit/0e1d7239d6fddebdaf39e58eb931ff4916306b23.diff LO

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Lawrence Benson via cfe-commits
lawben wrote: @nikic Sorry for the mess :/ I took the `target=` approach from [here](https://llvm.org/docs/TestingGuide.html#constraining-test-execution). Following the current buildbot status, this also does not seem to crash. Does this mean the rests are still incorrect and are not being e

[clang] Fix __builtin_vectorelements tests with REQUIRES (PR #69582)

2023-10-19 Thread Nikita Popov via cfe-commits
nikic wrote: > @nikic Sorry for the mess :/ > > I took the `target=` approach from > [here](https://llvm.org/docs/TestingGuide.html#constraining-test-execution). > Following the current buildbot status, this also does not seem to crash. Does > this mean the rests are still incorrect and are n

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

2023-10-19 Thread via cfe-commits
Juan Manuel MARTINEZ =?utf-8?q?CAAMAÑO?= , Juan Manuel MARTINEZ =?utf-8?q?CAAMAÑO?= Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bas

[clang] [AST] Use explicit type erasure in TypeSourceInfo constructor (PR #68435)

2023-10-19 Thread via cfe-commits
bonktree wrote: Ping. Is there something to be done next to get this merged? Thanks. https://github.com/llvm/llvm-project/pull/68435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments (PR #69463)

2023-10-19 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/69463 From aff47154ae4d45c2852382aed034ea44df4886d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH 1/3] [NFC][Clang] Remove u

[clang] 4ed0dfe - [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

2023-10-19 Thread Caroline Concatto via cfe-commits
Author: Caroline Concatto Date: 2023-10-19T10:47:32Z New Revision: 4ed0dfe6adfe2a8b7b1420fec313c4250542747e URL: https://github.com/llvm/llvm-project/commit/4ed0dfe6adfe2a8b7b1420fec313c4250542747e DIFF: https://github.com/llvm/llvm-project/commit/4ed0dfe6adfe2a8b7b1420fec313c4250542747e.diff

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

2023-10-19 Thread Caroline via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ed0dfe6adfe: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo CHA

[clang] [Clang] Actually fix tests for __builtin_vectorelements (PR #69589)

2023-10-19 Thread Lawrence Benson via cfe-commits
https://github.com/lawben created https://github.com/llvm/llvm-project/pull/69589 In #69582, I accidentally disabled all tests for the changed introduced in #69010. This change should use the correct `REQUIRES` syntax to en-/disable target-specific tests. >From 52c2267696651c533d9ffa8f5110479

  1   2   3   4   5   >