[clang] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Michael Buch via cfe-commits
@@ -574,6 +574,20 @@ benchmarks) generate-cmake check-cxx-benchmarks ;; +check-lldb-data-formatters) +clean +${CMAKE}\ +-S "${MONOREPO_ROOT}/llvm" \ +-B "${BUILD_DIR}"

[clang-tools-extra] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/65174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/65174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-12 Thread Richard Smith via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-12 Thread via cfe-commits
@@ -827,6 +829,9 @@ bool ByteCodeExprGen::VisitArrayInitLoopExpr( template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { + if (OpaqueExprs.contains(E)) +return this->emitGetLocal(*classify(E), OpaqueExprs[E], E); isuckatcs wrote:

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread Artem Belevich via cfe-commits
Artem-B wrote: @rnk -- would that be acceptable for clang-cl on windows? https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf created https://github.com/llvm/llvm-project/pull/68944 For more details about this instruction, please refer to the latest ISE document: https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.h

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/68944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Freddy Ye (FreddyLeaf) Changes For more details about this instruction, please refer to the latest ISE document: https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a712244f3b76cd2ef60b4f3ce5efaf6d4d49c6fe 2377ab2b9865d8f152996fd38f6b543767f8c2ae --

[clang] [mlir] Add ContractionOpInterface utility functions for vector matrix multiplication (PR #68945)

2023-10-12 Thread via cfe-commits
https://github.com/NatashaKnk created https://github.com/llvm/llvm-project/pull/68945 None >From e431cc466e5609e19757481604dad47558219166 Mon Sep 17 00:00:00 2001 From: Natasha Kononenko Date: Fri, 13 Oct 2023 00:48:17 + Subject: [PATCH 1/2] Add ContractionOpInterface utility functions for

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Phoebe Wang via cfe-commits
@@ -20,6 +20,11 @@ #include #endif +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +defined(__UINTR__) phoebewang wrote: __USERMSR__ https://github.com/llvm/llvm-project/pull/68944 _

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Phoebe Wang via cfe-commits
@@ -922,8 +922,6 @@ endif() include(HandleLLVMOptions) -## - phoebewang wrote: Unrelated change https://github.com/llvm/llvm-project/pull/68944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Phoebe Wang via cfe-commits
@@ -241,6 +241,7 @@ X86_FEATURE (SM3, "sm3") X86_FEATURE (SM4, "sm4") X86_FEATURE (AVXVNNIINT16,"avxvnniint16") X86_FEATURE (EVEX512, "evex512") +X86_FEATURE (USERMSR,"usermsr") phoeb

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,26 @@ +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL + +# ATT: urdmsr $123, %r9 +# INTEL: urdmsr r9, 123 +0xc4,0xc7,0x7b

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Phoebe Wang via cfe-commits
@@ -325,6 +325,8 @@ def FeatureTSXLDTRK : SubtargetFeature<"tsxldtrk", "HasTSXLDTRK", "true", "Support TSXLDTRK instructions">; def FeatureUINTR : SubtargetFeature<"uintr", "HasUINTR", "true", "Has UINT

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-12 Thread Hongtao Yu via cfe-commits
htyu wrote: > The performance win depends a lot on value distribution. For large copies, > using SIMD with nontemporal hint is the way to go. Right, and the dominating single-range distribution is also important for our approach, similar to how speculative indirect call promotion works. Rece

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -0,0 +1,26 @@ +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL + +# ATT: urdmsr $123, %r9 +# INTEL: urdmsr r9, 123 +0xc4,0xc7,0x7b

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/68944 >From 2377ab2b9865d8f152996fd38f6b543767f8c2ae Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Wed, 11 Oct 2023 14:09:02 +0800 Subject: [PATCH 1/2] Add USER_MSR instructions. For more details about this instru

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -325,6 +325,8 @@ def FeatureTSXLDTRK : SubtargetFeature<"tsxldtrk", "HasTSXLDTRK", "true", "Support TSXLDTRK instructions">; def FeatureUINTR : SubtargetFeature<"uintr", "HasUINTR", "true", "Has UINT

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -0,0 +1,26 @@ +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL + +# ATT: urdmsr $123, %r9 +# INTEL: urdmsr r9, 123 +0xc4,0xc7,0x7b

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -241,6 +241,7 @@ X86_FEATURE (SM3, "sm3") X86_FEATURE (SM4, "sm4") X86_FEATURE (AVXVNNIINT16,"avxvnniint16") X86_FEATURE (EVEX512, "evex512") +X86_FEATURE (USERMSR,"usermsr") Fredd

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -922,8 +922,6 @@ endif() include(HandleLLVMOptions) -## - FreddyLeaf wrote: 3e32e495d8fa56ad3770769a5d4559ea0a41af96 https://github.com/llvm/llvm-project/pull/68944 ___ cfe-commits mailing list cfe-commits@

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Freddy Ye via cfe-commits
@@ -20,6 +20,11 @@ #include #endif +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +defined(__UINTR__) FreddyLeaf wrote: 3e32e495d8fa56ad3770769a5d4559ea0a41af96 https://github.com/llvm/llvm-project/pull/68944

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-12 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68832 >From 9ca88d1a30ec1bcaa9c3c943c32649c36ad136d0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 11 Oct 2023 12:21:39 -0700 Subject: [PATCH 1/3] [libc++] Use -nostdlib++ on GCC unconditionally We support GC

[clang] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-12 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68832 >From 9ca88d1a30ec1bcaa9c3c943c32649c36ad136d0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 11 Oct 2023 12:21:39 -0700 Subject: [PATCH 1/3] [libc++] Use -nostdlib++ on GCC unconditionally We support GC

[libunwind] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-12 Thread Louis Dionne via cfe-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to us

[clang] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-12 Thread Louis Dionne via cfe-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to us

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-12 Thread Yueh-Ting Chen via cfe-commits
@@ -0,0 +1,57 @@ +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+v,+xsfvqmaccqoq,+xsfvqmaccdod %s \ +# RUN:| FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST +# RUN: not llvm-mc -triple=riscv64 -show-encoding %s 2>&1 \ +# RUN:| FileCheck %s --check-

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-12 Thread Ding Fei via cfe-commits
danix800 wrote: Caused by missing `MemberSpecializationInfo` when importing so moving testcase into `ASTImporterTest` as unittest would be better. https://github.com/llvm/llvm-project/pull/68774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][LoongArch] Support compiler options -mlsx/-mlasx for clang (PR #68952)

2023-10-12 Thread via cfe-commits
https://github.com/yjijd created https://github.com/llvm/llvm-project/pull/68952 This patch adds compiler options -mlsx/-mlasx which enables the instruction sets of LSX and LASX, and sets related predefined macros acording to the options. >From ba3d3560675bcfd84bd11bfed9e26ad86b60faaf Mon Sep

[clang] [Clang][LoongArch] Add ABI implementation of passing vectors (PR #68954)

2023-10-12 Thread via cfe-commits
https://github.com/yjijd created https://github.com/llvm/llvm-project/pull/68954 None >From 74d9ea74aea28db6f5a3a4c6dfccb132d87d1fa8 Mon Sep 17 00:00:00 2001 From: licongtian Date: Tue, 10 Oct 2023 15:51:58 +0800 Subject: [PATCH] [Clang][LoongArch] Add ABI implementation of passing vectors ---

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-12 Thread via cfe-commits
@@ -2732,100 +2732,114 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { // rotate matching code under visitSelect and visitTrunc? unsigned Width = Or.getType()->getScalarSizeInBits(); - // First, find an or'd pair of opposite shifts: - //

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-12 Thread via cfe-commits
@@ -2732,100 +2732,114 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { // rotate matching code under visitSelect and visitTrunc? unsigned Width = Or.getType()->getScalarSizeInBits(); - // First, find an or'd pair of opposite shifts: - //

[clang] [X86] Add USER_MSR instructions. (PR #68944)

2023-10-12 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-12 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/68075 >From 91bb1d9884276a37f93515a648aa6ece353fdc70 Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 12 Sep 2023 12:28:00 +0800 Subject: [PATCH 1/4] [RISCV] Add MC layer support for Zicfiss. The patch adds the in

[clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2023-10-12 Thread Yeting Kuo via cfe-commits
yetingk wrote: > The patch basically changes the ShadowCallStack back-end to emit an > sspush/sspopchk instead of the usual SCS push/pop, which seems like a > reasonable approach to me. However, it would be helpful to mention the > dependency on `-fsanitize=shadow-call-stack` in the commit mes

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/68957 This prevents redefinition errors due to having multiple paths for the same module map. (rdar://24116019) Originally implemented and tested downstream by @bcardosolopes, I just made use of `FileEntryRef::g

[clang] [clang][modules] Use file name as requested (PR #68957)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes This prevents redefinition errors due to having multiple paths for the same module map. (rdar://24116019) Originally implemented and tested downstream by @bcardosolopes, I just made use of `File

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in Template

[clang] [clang][Interp] Support AddOffset with 128bit offsets (PR #68679)

2023-10-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/68679 >From 9598f33926ede7a35a431bebc3ed6f8ce20b03ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 10 Oct 2023 08:52:43 +0200 Subject: [PATCH] [clang][Interp] Support AddOffset with 128bit of

[clang-tools-extra] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Mark de Wever via cfe-commits
@@ -574,6 +574,20 @@ benchmarks) generate-cmake check-cxx-benchmarks ;; +check-lldb-data-formatters) +clean +${CMAKE}\ +-S "${MONOREPO_ROOT}/llvm" \ +-B "${BUILD_DIR}"

[clang] [libc++] Add a CI job for the LLDB data formatters (PR #65174)

2023-10-12 Thread Mark de Wever via cfe-commits
@@ -574,6 +574,20 @@ benchmarks) generate-cmake check-cxx-benchmarks ;; +check-lldb-data-formatters) +clean +${CMAKE}\ +-S "${MONOREPO_ROOT}/llvm" \ +-B "${BUILD_DIR}"

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Timm Baeder via cfe-commits
@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); tbaederr wrote: This is unimplemented right now, I just added the bitw

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Timm Baeder via cfe-commits
@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); } - static IntegralAP zero() { -assert(false); -return IntegralAP(0); + s

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Timm Baeder via cfe-commits
@@ -1642,9 +1642,9 @@ bool ByteCodeExprGen::visitZeroInitializer(QualType QT, case PT_Uint64: return this->emitZeroUint64(E); case PT_IntAP: +return this->emitZeroIntAP(128, E); // FIXME: Ctx.getBitWidth() case PT_IntAPS: -assert(false); -return false; +

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread via cfe-commits
mikaelholmen wrote: Hi @rampitec With UBSan built binaries the MC/AMDGPU/literals.s testcase fails and triggers UB like ``` 07:33:04 ../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2246:59: runtime error: left shift of negative value -54321 07:33:04 SUMMARY: UndefinedBehaviorSanitizer: und

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/68081 >From a7f0b32783bd8e9ce4d74d98e5a45351d3b38d24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Oct 2023 11:05:27 +0200 Subject: [PATCH] [clang][Interp] IntegralAP zero-init --- clang/

[clang] [clang][Interp] Only emit function_param_value_unknown in C++11 (PR #67990)

2023-10-12 Thread Timm Baeder via cfe-commits
tbaederr wrote: https://reviews.llvm.org/D156565 hasn't been merged as far as I can tell and it's the only test case I have for this. :( https://github.com/llvm/llvm-project/pull/67990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-12 Thread via cfe-commits
@@ -2732,100 +2732,114 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { // rotate matching code under visitSelect and visitTrunc? unsigned Width = Or.getType()->getScalarSizeInBits(); - // First, find an or'd pair of opposite shifts: - //

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-12 Thread via cfe-commits
@@ -2732,100 +2732,114 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { // rotate matching code under visitSelect and visitTrunc? unsigned Width = Or.getType()->getScalarSizeInBits(); - // First, find an or'd pair of opposite shifts: - //

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > Hi @rampitec > > With UBSan built binaries the MC/AMDGPU/literals.s testcase fails and > triggers UB like > > ``` > 07:33:04 ../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2246:59: runtime > error: left shift of negative value -54321 > 07:33:04 SUMMARY: UndefinedBehavior

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-12 Thread Timm Baeder via cfe-commits
@@ -478,6 +480,43 @@ template class SourceLocScope final { bool Enabled = false; }; +template class StoredOpaqueValueScope final { +public: + StoredOpaqueValueScope(ByteCodeExprGen *Ctx) : Ctx(Ctx) {} + + bool VisitAndStoreOpaqueValue(const OpaqueValueExpr *Ove) { +a

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-12 Thread Timm Baeder via cfe-commits
@@ -478,6 +480,43 @@ template class SourceLocScope final { bool Enabled = false; }; +template class StoredOpaqueValueScope final { +public: + StoredOpaqueValueScope(ByteCodeExprGen *Ctx) : Ctx(Ctx) {} + + bool VisitAndStoreOpaqueValue(const OpaqueValueExpr *Ove) { +a

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > > Hi @rampitec > > With UBSan built binaries the MC/AMDGPU/literals.s testcase fails and > > triggers UB like > > ``` > > 07:33:04 ../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2246:59: > > runtime error: left shift of negative value -54321 > > 07:33:04 SUMMARY: Undefined

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-12 Thread Fangrui Song via cfe-commits
MaskRay wrote: (Was out of town...) As mentioned at https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374 , I think a default error is probably not appropriate. A priority value <= 100 may compete with a runtime `__attribute__((constructor(X)))` but more often it will work.

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: I have a small little problem that I cannot build tip now: ``` FAILED: tools/llvm-remarkutil/CMakeFiles/llvm-remarkutil.dir/RemarkCounter.cpp.o CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread via cfe-commits
mikaelholmen wrote: I suppose left shift of negative values is undefined because if you shift out the sign bit you can overflow and get a positive value. https://github.com/llvm/llvm-project/pull/68740 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-12 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > I suppose left shift of negative values is undefined because if you shift out > the sign bit you can overflow and get a positive value. Sounds like BS. It is defined. Unexpected maybe. https://github.com/llvm/llvm-project/pull/68740 ___

<    1   2   3