[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

MatzeB wrote: > There are two ways ProfileFuncRef can originate (ignoring copy constructions): > ... So you are saying there can be hashcode `ProfileFuncRef`s coming from the profile, but an `llvm::Function` would always produce a string `ProfileFuncRef`? > B - Whenever we lookup a ProflieFuncR

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

MatzeB wrote: > There are two ways ProfileFuncRef can originate (ignoring copy constructions): > ... So you are saying there can be hashcode `ProfileFuncRef`s coming from the profile, but an `llvm::Function` would always produce a string `ProfileFuncRef`? > B - Whenever we lookup a ProflieFuncR

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

jansvoboda11 wrote: This is now always storing an absolute path into `Header::PathRelativeToRootModuleDirectory` for built-in headers. I guess that's not much more surprising than the "as-written" resource directory prepended to the header name we stored previously, but I think this should be

[clang] [Fuchsia] Change driver build to default to off (PR #68341)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/68341 We use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in. >From f8464ee99b3b2b

[clang] [Fuchsia] Change driver build to default to off (PR #68341)

llvmbot wrote: @llvm/pr-subscribers-clang Changes We use this cache file for local builds too where the driver build is not a sensible default because it makes incremental links take too long. Instead lets change this option to be opt in. --- Full diff: https://github.com/llvm/llvm-proje

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: AaronBallman wrote: > > Also, redirecting output to a file doesn't alwa

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

AaronBallman wrote: > There's a problem with this attribute where the declaration in a header file > doesn't have the attribute, but the definition in the source file has. As a > result, the attribute doesn't take effect when just the header file is > included. Errr, that's the behavior of ba

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

https://github.com/AaronBallman approved this pull request. Thank you for the fix, the changes LGTM! The precommit CI failure appears to be unrelated to these changes. I don't think this requires test coverage or a release note. https://github.com/llvm/llvm-project/pull/68127 _

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

huangjd wrote: > > There are two ways ProfileFuncRef can originate (ignoring copy > > constructions): > > ... > > So you are saying there can be hashcode `ProfileFuncRef`s coming from the > profile, but an `llvm::Function` would always produce a string > `ProfileFuncRef`? > > > B - Whenever

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From 8598d5f4cfad4f3887ec40b7c3d21e385f731d9d Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/4] Correct unreachable hint in release mode When LLVM_UNRE

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

@@ -343,6 +343,8 @@ Bug Fixes in This Version - Fix a crash when evaluating value-dependent structured binding variables at compile time. Fixes (`#67690 `_) +- Fixes a regression where ``LLVM_UNREACHABLE_OPTIMIZE=OFF`` cann

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/68127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a50e63b - Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)

Author: Rajkumar Ananthu Date: 2023-10-05T14:51:57-04:00 New Revision: a50e63b38b931d945f97eac882278068221eca17 URL: https://github.com/llvm/llvm-project/commit/a50e63b38b931d945f97eac882278068221eca17 DIFF: https://github.com/llvm/llvm-project/commit/a50e63b38b931d945f97eac882278068221eca17.di

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: @AaronBallman, @erichkeane; whenever ya'll are done with the review, can you merge this in? I don't think I have access. And about the backporting, do we need it for 17.x bugfix releases? https://github.com/llvm/llvm-project/pull/68284 _

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/6] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/6] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/6] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang-tools-extra] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/6] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/6] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

AaronBallman wrote: > @AaronBallman you have a preference as to which PR we pursue? No strong preference, but the author of D141177 seems to have gone silent again so if @jerinphilip is actively working on this patch, I'd say let's go with this one. https://github.com/llvm/llvm-project/pull/6

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

AaronBallman wrote: > @erichkeane @AaronBallman, I've added the release notes and rebased the > change on `main`. Does this need to be backported to 17.x? 16.x doesn't have > this issue Yeah, I think we should probably backport this to 17.x. We have instructions on how to kick that off here:

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

rmaz wrote: > This is now always storing an absolute path into > Header::PathRelativeToRootModuleDirectory for built-in headers Wouldn't this always have been the case? I'll check shortly with a resource dir picked up via toolchain bundle layout. > My bigger concern is that we now generate ab

[clang] bffbe9a - [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (#68284)

Author: Arvind Mukund Date: 2023-10-05T15:01:56-04:00 New Revision: bffbe9a9cf3a287648d81675a99ff9a808fab990 URL: https://github.com/llvm/llvm-project/commit/bffbe9a9cf3a287648d81675a99ff9a808fab990 DIFF: https://github.com/llvm/llvm-project/commit/bffbe9a9cf3a287648d81675a99ff9a808fab990.diff

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

rmaz wrote: > Maybe prepending #pragma before #include of each builtin header? Could you expand on this? Not sure I get the idea. https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: > > @erichkeane @AaronBallman, I've added the release notes and rebased the > > change on `main`. Does this need to be backported to 17.x? 16.x doesn't > > have this issue > > Yeah, I think we should probably backport this to 17.x. We have instructions > on how to kick th

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 557619. ZijunZhao added a comment. Run the script to update the test Test command: llvm/utils/update_cc_test_checks.py --clang build/bin/clang ./clang/test/C/C2x/n2683_2.c llvm/utils/update_cc_test_checks.py --clang build/bin/clang ./clang/test/Headers/s

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

rmaz wrote: > Wouldn't this always have been the case? I'll check shortly with a resource > dir picked up via toolchain bundle layout. Looks like yes: ``` Process 77520 stopped * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 frame #0: 0x000109b568fd clang`cla

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

AaronBallman wrote: > > > @erichkeane @AaronBallman, I've added the release notes and rebased the > > > change on `main`. Does this need to be backported to 17.x? 16.x doesn't > > > have this issue > > > > > > Yeah, I think we should probably backport this to 17.x. We have > > instructions o

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

ldionne wrote: @jyknight Is there anything you need in order to make progress on this? If so, please let us know and we'll try to help. I think this patch is pretty much ready to go based on @philnik777 's comment above. https://github.com/llvm/llvm-project/pull/66576 _

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

ldionne wrote: @jyknight Is there anything you need in order to make progress on this? If so, please let us know and we'll try to help. I think this patch is pretty much ready to go based on @philnik777 's comment above. https://github.com/llvm/llvm-project/pull/66576 _

[clang] [clang][driver] Fix an issue where clang does not correctly resolve the system header if invoked via symlink (on MacOS) (PR #68091)

ilg-ul wrote: Any suggestions how to proceed from here? https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

jrtc27 added a comment. One more thought: we need to specify a triple for the tests as otherwise it'll use whatever default you have configured in LLVM, which will affect the exact code generated (especially wrt argument and return lowering), no? Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

jyknight wrote: I don't think I will be able to work on that the discussed Clang diagnostics anytime soon. Unless someone else is volunteering to implement it, that may not be implemented at all. So, I'd like to hear explicit consensus is that folks are generally OK to submit this _without_ s

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

ldionne wrote: > I don't think I will be able to work on that the discussed Clang diagnostics > anytime soon. Unless someone else is volunteering to implement it, that may > not be implemented at all. > > So, I'd like to hear explicit consensus is that folks are generally OK to > submit this

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

https://github.com/PiJoules created https://github.com/llvm/llvm-project/pull/68344 None >From 631458f0a988062666d04e7be99989e2a5635289 Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Thu, 5 Oct 2023 19:19:47 + Subject: [PATCH] [clang] Ensure fixed point conversions work in C++ --- cla

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dc129d6f715cf83a2072fc8de8b4e4c70bca6935 631458f0a988062666d04e7be99989e2a5635289 --

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

philnik777 wrote: I didn't consider that blocking either. IMO that's actually out-of-scope for this patch. https://github.com/llvm/llvm-project/pull/66576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

philnik777 wrote: I didn't consider that blocking either. IMO that's actually out-of-scope for this patch. https://github.com/llvm/llvm-project/pull/66576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

@@ -1,6 +1,8 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py -// RUN: %clang_cc1 -ffixed-point -triple x86_64-unknown-linux-gnu -S -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,SIGNED -// RUN: %clang_cc1 -ffixed-point -triple x86_64-un

[PATCH] D157331: [clang] Implement C23

aaron.ballman added a comment. In D157331#4653222 , @jrtc27 wrote: > One more thought: we need to specify a triple for the tests as otherwise > it'll use whatever default you have configured in LLVM, which will affect the > exact code generated (especia

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

jansvoboda11 wrote: > If the resource dir is outside of the cwd then you would have to have an > absolute path here anyway, wouldn't you? Yes. But my understanding was that's not what you're interested in. I thought you're trying to fix the situation where your resource dir is in the CWD, so

[clang] [libc] Enable remaining string functions on the GPU (PR #68346)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68346 Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very diffi

[clang] [libc] Enable remaining string functions on the GPU (PR #68346)

llvmbot wrote: @llvm/pr-subscribers-libc Changes Summary: We previously had to disable these string functions because they were not compatible with the definitions coming from the GNU / host environment. The GPU, when exporting its declarations, has a very difficult requirement that it be c

[PATCH] D157331: [clang] Implement C23

jrtc27 added a comment. In D157331#4653224 , @aaron.ballman wrote: > In D157331#4653222 , @jrtc27 wrote: > >> One more thought: we need to specify a triple for the tests as otherwise >> it'll use whatever defaul

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/68134 >From baf9d8e19d2b064c05527757c6173f875b59b286 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Tue, 3 Oct 2023 10:39:02 -0700 Subject: [PATCH 1/3] [clang-tidy][libc] Fix namespace check with macro Th

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/michaelrj-google edited https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/michaelrj-google commented: I've addressed the comments with my latest commit https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +45,20 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function starts

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

brad0 wrote: I'd like for this to move forward. https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

Author: Kazu Hirata Date: 2023-10-05T13:08:24-07:00 New Revision: a6acf3fd49a20c570a390af2a3c84e10b9545b68 URL: https://github.com/llvm/llvm-project/commit/a6acf3fd49a20c570a390af2a3c84e10b9545b68 DIFF: https://github.com/llvm/llvm-project/commit/a6acf3fd49a20c570a390af2a3c84e10b9545b68.diff L

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

@@ -44,12 +44,8 @@ BACKDEPLOYMENT_PARAMETERS = [ config.substitutions.append(('%{flags}', '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) -config.substitutions.append(('%{compile_flags}', -'-nostdinc++ -I %{include} -I %{libcxx}/test/su

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/68349 None >From 2403d91e2f4b8ed848a8af1103fd50ce4d36c926 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together usage of AddAllArgs --- clang/lib/Driver

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

On Thu, Oct 5, 2023 at 4:08 PM Kazu Hirata via cfe-commits wrote: > > > Author: Kazu Hirata > Date: 2023-10-05T13:08:24-07:00 > New Revision: a6acf3fd49a20c570a390af2a3c84e10b9545b68 > > URL: > https://github.com/llvm/llvm-project/commit/a6acf3fd49a20c570a390af2a3c84e10b9545b68 > DIFF: > https:/

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

On Thu, Oct 5, 2023 at 4:18 PM Aaron Ballman wrote: > > On Thu, Oct 5, 2023 at 4:08 PM Kazu Hirata via cfe-commits > wrote: > > > > > > Author: Kazu Hirata > > Date: 2023-10-05T13:08:24-07:00 > > New Revision: a6acf3fd49a20c570a390af2a3c84e10b9545b68 > > > > URL: > > https://github.com/llvm/llvm

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7a46baa465c49db84b7b5f8fa9ab847ec1da3ce4 2403d91e2f4b8ed848a8af1103fd50ce4d36c926 --

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

On Thu, Oct 5, 2023 at 4:19 PM Aaron Ballman wrote: > > On Thu, Oct 5, 2023 at 4:18 PM Aaron Ballman wrote: > > > > On Thu, Oct 5, 2023 at 4:08 PM Kazu Hirata via cfe-commits > > wrote: > > > > > > > > > Author: Kazu Hirata > > > Date: 2023-10-05T13:08:24-07:00 > > > New Revision: a6acf3fd49a20c

[clang] [Driver] Remove identifier with the comment (PR #68351)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/68351 MaskRay suggested removal of the identifer in a review for another ToolChain so doing the same for the rest. >From 977aaf66e606f454949edae1d18b14cb06307a51 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oc

[clang] [Driver] Remove identifier with the comment (PR #68351)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes MaskRay suggested removal of the identifer in a review for another ToolChain so doing the same for the rest. --- Full diff: https://github.com/llvm/llvm-project/pull/68351.diff 8 Files Affected: - (modified) clang/lib/Driver/Tool

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68349 >From 6542f6aae993dd186f736da7d3d2fcb54647f01f Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together usage of AddAllArgs --- clang/lib/Driver/ToolC

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

rmaz wrote: > I thought you're trying to fix the situation where your resource dir is in > the CWD, so that's the context I'm assuming. Is that correct? Yes. > I was considering your test case, where we'd previously store > "resource-dir/include/float.h" into Header::PathRelativeToRootModuleD

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68349 >From 74ad5f7b60f7e78e524311c5dbbce16650d9d890 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together usage of AddAllArgs --- clang/lib/Driver/ToolC

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68349 >From c4a869323ede651b71dc514199cee112279b0ce9 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together usage of AddAllArgs --- clang/lib/Driver/ToolC

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -45,6 +45,10 @@ class GlobalCompilationDatabase { return std::nullopt; } + virtual std::vector getAllFilesInProjectOf(PathRef File) const { mathstuf wrote: `compile_commands.json` probably isn't the best place for it as it cannot be filled out at t

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang] [clang][driver] Fix an issue where clang does not correctly resolve the system header if invoked via symlink (on MacOS) (PR #68091)

jansvoboda11 wrote: > @jansvoboda11, since the Apple clang already fixed this bug, could you > suggest how to proceed? Could you backport the Apple patch to upstream? I'm not familiar with this, but @yln might. https://github.com/llvm/llvm-project/pull/68091 ___

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

https://github.com/cachemeifyoucan commented: I haven't read the PR in details but one thing we found difficult to do is how to write a test for daemon spawning logic, because if anything went wrong, you left an unbounded daemon process on CI node. The strategy in this PR (try to kill it after

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/PiotrZSL approved this pull request. >From functional point of view looks fine, could be more strict but should >still work. https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

@@ -0,0 +1,302 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

jdoerfert wrote: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/68264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

https://github.com/jdoerfert approved this pull request. LG if others don't object https://github.com/llvm/llvm-project/pull/68264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From 5010ba6ec2f7370d2efc01d2fafb86d55c4dd883 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost va

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

@@ -1,6 +1,8 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py -// RUN: %clang_cc1 -ffixed-point -triple x86_64-unknown-linux-gnu -S -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,SIGNED -// RUN: %clang_cc1 -ffixed-point -triple x86_64-un

[clang] [clang] Ensure fixed point conversions work in C++ (PR #68344)

https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/68344 >From 1eb1638a12c619febf1fe9830f34e51a56d4c20e Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Thu, 5 Oct 2023 19:19:47 + Subject: [PATCH] [clang] Ensure fixed point conversions work in C++ --- clang/inc

[clang] [clang][driver] Fix an issue where clang does not correctly resolve the system header if invoked via symlink (on MacOS) (PR #68091)

ilg-ul wrote: @jansvoboda11, as Martin showed before, Apple clang did not fix this, so this patch applies to it too. https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 557621. ZijunZhao added a comment. Add --triple=x86_64 into the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

@@ -45,18 +46,21 @@ void CalleeNamespaceCheck::check(const MatchFinder::MatchResult &Result) { if (FuncDecl->getBuiltinID() != 0) return; - // If the outermost namespace of the function is __llvm_libc, we're good. + // If the outermost namespace of the function is a m

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

https://github.com/AMS21 created https://github.com/llvm/llvm-project/pull/68359 The previous code was pretty messy and treated value dependant expressions which could not be evaluated the same as if they evaluted to `false`. Which was obviously not correct. We now check if we can evaluate the

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes The previous code was pretty messy and treated value dependant expressions which could not be evaluated the same as if they evaluted to `false`. Which was obviously not correct. We now check if we can evaluate the dependant expressio

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/68134 >From baf9d8e19d2b064c05527757c6173f875b59b286 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Tue, 3 Oct 2023 10:39:02 -0700 Subject: [PATCH 1/4] [clang-tidy][libc] Fix namespace check with macro Th

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

aartbik wrote: This broke the bot? https://lab.llvm.org/buildbot/#/builders/61/builds/50100 https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/68264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1d959f9 - [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (#68264)

Author: Joseph Huber Date: 2023-10-05T17:10:03-05:00 New Revision: 1d959f932752b39cd535cb22f04e348a4b01 URL: https://github.com/llvm/llvm-project/commit/1d959f932752b39cd535cb22f04e348a4b01 DIFF: https://github.com/llvm/llvm-project/commit/1d959f932752b39cd535cb22f04e348a4b01.diff

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

jansvoboda11 wrote: > > I was going to suggest keeping Header::PathRelativeToRootModuleDirectory as > > "float.h", and generating this into the buffer > > Wouldn't this work without the pragma? Isn't the resource directory always > added to the header search paths, so the header should be fou

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: > > > > @erichkeane @AaronBallman, I've added the release notes and rebased the > > > > change on `main`. Does this need to be backported to 17.x? 16.x doesn't > > > > have this issue > > > > > > > > > Yeah, I think we should probably backport this to 17.x. We have > > >

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68349 >From c333fbefacc648600fbf84466a60a20cb2331fc3 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together usage of AddAllArgs --- clang/lib/Driver/ToolC

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From 83dd0fa7956942b6cffefb12caf5f070196b4ca3 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types W

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68364 This patch adds support for `thread_limit` and upperbound on `num_teams` clause for the teams construct in OpenMP. Added testcases for the same. >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:

[libclc] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68364 This patch adds support for `thread_limit` and upperbound on `num_teams` clause for the teams construct in OpenMP. Added testcases for the same. >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:

<    1   2   3   4   >