[clang] 5099dc3 - [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (#68169)

2023-10-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2023-10-04T23:41:49+02:00 New Revision: 5099dc341f7fa9baec160c2991072eb445469d46 URL: https://github.com/llvm/llvm-project/commit/5099dc341f7fa9baec160c2991072eb445469d46 DIFF: https://github.com/llvm/llvm-project/commit/5099dc341f7fa9baec160c2991072eb445469d46.dif

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/68169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68264 Summary: There's some logic in the AMDGPU target that manually resets the requested visibility of certain variables. This was triggering when we set a constant variable in OpenMP. However, we shouldn't do this for

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: There's some logic in the AMDGPU target that manually resets the requested visibility of certain variables. This was triggering when we set a constant variable in OpenMP. However, we shouldn't do this for OpenMP when the variable ha

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/9] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Jan Svoboda via cfe-commits
@@ -1444,6 +1444,74 @@ llvm::Error ASTReader::ReadSourceManagerBlock(ModuleFile &F) { } } +llvm::Expected +ASTReader::readSLocOffset(ModuleFile *F, unsigned Index) { + BitstreamCursor &Cursor = F->SLocEntryCursor; + SavedStreamPosition SavedPosition(Cursor); + if (llvm::

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread Felipe de Azevedo Piovezan via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread Felipe de Azevedo Piovezan via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
ilg-ul wrote: > I wonder if this would need to be somewhat target specific. I took a first look, and it seems target specific. The strategy was to search for `InstalledDir` and see how it is used. It looks like in many places both locations are used, which means things are not that bad: ```c

[clang] e599422 - [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (#67691)

2023-10-04 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-10-04T18:11:37-04:00 New Revision: e5994229541bbe78c3e6eb548224b46f8c3c91be URL: https://github.com/llvm/llvm-project/commit/e5994229541bbe78c3e6eb548224b46f8c3c91be DIFF: https://github.com/llvm/llvm-project/commit/e5994229541bbe78c3e6eb548224b46f8c3c91b

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the fix and sorry for the delay! https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the fix and sorry for the delay! https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Thanks for iterating! I find the current implementation much clearer. Thanks for your patience! > The only thing I might quibble about is the "child" vs. "parent" terminology > you changed: I think it's fairly ambiguous either way, because the node is > the "child" from

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -261,6 +261,11 @@ def err_test_module_file_extension_version : Error< "test module file extension '%0' has different version (%1.%2) than expected " "(%3.%4)">; +def warn_module_build_daemon : Warning<"%0">, + InGroup; +def remark_module_build_daemon : Remark<"%0">, +

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,109 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,109 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,128 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,109 @@ +//===- SocketSupport.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,211 @@ +//===- Client.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-04 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,302 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread Felipe de Azevedo Piovezan via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread Felipe de Azevedo Piovezan via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: @sam-mccall Do you have any additional feedback? You might want to check how this PR and #66966 impact performance for you. https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-10-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/68267 Just follow allow with the reassociate pragma. This allows locally setting the arcp fast math flag. Previously you could only access this through the global -freciprocal-math. >From 082efa2687b0b6a250bbdbe60040c

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Just follow allow with the reassociate pragma. This allows locally setting the arcp fast math flag. Previously you could only access this through the global -freciprocal-math. --- Full diff: https://github.com/llvm/llvm-project/pull/68267

[clang] [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (PR #68241)

2023-10-04 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. https://github.com/llvm/llvm-project/pull/68241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (PR #68241)

2023-10-04 Thread Michael Spencer via cfe-commits
Bigcheese wrote: I think splitting out the test here is good. https://github.com/llvm/llvm-project/pull/68241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ee8c67 - [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (#68241)

2023-10-04 Thread via cfe-commits
Author: Ian Anderson Date: 2023-10-04T15:43:17-07:00 New Revision: 4ee8c676ee370f5cd53cb6ac3a9c27c7088f2eae URL: https://github.com/llvm/llvm-project/commit/4ee8c676ee370f5cd53cb6ac3a9c27c7088f2eae DIFF: https://github.com/llvm/llvm-project/commit/4ee8c676ee370f5cd53cb6ac3a9c27c7088f2eae.diff

[clang] [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (PR #68241)

2023-10-04 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/68241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Matt Harding via cfe-commits
https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/13] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Matt Harding via cfe-commits
https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/13] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6da382d - [Clang][Driver] Add new flags to control IR verification (#68172)

2023-10-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2023-10-05T00:50:30+02:00 New Revision: 6da382d27bb5c21dfce8ae5239ab5797bc191cab URL: https://github.com/llvm/llvm-project/commit/6da382d27bb5c21dfce8ae5239ab5797bc191cab DIFF: https://github.com/llvm/llvm-project/commit/6da382d27bb5c21dfce8ae5239ab5797bc191cab.dif

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Index] Use canonical function parameter types in USRs (PR #68222)

2023-10-04 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Also, would you make sure to add a test case for this? Thanks. https://github.com/llvm/llvm-project/pull/68222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Index] Use canonical function parameter types in USRs (PR #68222)

2023-10-04 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @mizvekov Sure, I'll take care of that tomorrow https://github.com/llvm/llvm-project/pull/68222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread via cfe-commits
nolange wrote: > On the other hand; I agree that it's kinda implausible that this directory > would exist at all anywhere else than next to the actual executable. In that > case, perhaps those testcases are the only cases that would need to be > handled after all? If it exists this might caus

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. Latest change to shrink memory use LGTM. https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang][driver] Prevent clang picking the system headers when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
ilg-ul wrote: @nolange, English is not my first language, and I know sometimes I'm very confusing. In my understanding, the title suggest that if clang is not invoked directly but via a symlink, it does not behave correctly, i.e. instead of picking the headers from the folders where clang is i

[clang] [clang][driver] Prevent clang picking the system headers when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Prevent clang picking the system headers when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
ilg-ul wrote: > ... I understand this is only a bug on MacOS? I'm using clang only to compile my binary packages on macOS (the Linux binaries are compiled with gcc), so I got bitten by this bug only on macOS. The other platforms/targets may or may not be affected, I don't know; but my initial

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

2023-10-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I'll move this PR to github, and I'll update it to reflect the current state of things, with the aim to have it in good shape (and, possibly, land) before the Dev Meeting. There weren't any major course corrections, but I'll need to spell out what are the things that we've

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-04 Thread via cfe-commits
https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/68276 We noticed that clang does not check for bitfield assignment widths, while gcc does check this. gcc produced a warning like so for it's -Wconversion flag: $ gcc -Wconversion -c test.c test.c: In function 'fo

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes We noticed that clang does not check for bitfield assignment widths, while gcc does check this. gcc produced a warning like so for it's -Wconversion flag: $ gcc -Wconversion -c test.c test.c: In function 'foo': test.c:10:15: warning: conv

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-04 Thread via cfe-commits
vabridgers wrote: I don't claim this is ready to merge, but I would like to get the review party started. I'm looking for constructive comments to advance this patch to a mergeable state. I don't do a lot of these patches, so have probably missed some basic things. Thanks. https://github.com/

[clang] 9a954c6 - [Clang] Implement the 'counted_by' attribute

2023-10-04 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-10-04T18:26:15-07:00 New Revision: 9a954c693573281407f6ee3f4eb1b16cc545033d URL: https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d DIFF: https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d.diff

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-10-04 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9a954c693573: [Clang] Implement the 'counted_by' attribute (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llv

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/68277 With opaque pointers, CreatePointerBitCastOrAddrSpaceCast is same as CreateAddrSpaceCast. Replace or remove uses of CreatePointerBitCastOrAddrSpaceCast. Opaque pointer cleanup effort. >From 1299c48eb032aa7543f

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes With opaque pointers, CreatePointerBitCastOrAddrSpaceCast is same as CreateAddrSpaceCast. Replace or remove uses of CreatePointerBitCastOrAddrSpaceCast. Opaque pointer cleanup effort. --- Full diff: https://github.com/llvm/llvm-project/p

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9a954c693573281407f6ee3f4eb1b16cc545033d 1299c48eb032aa7543f5c4569de75b45ef07bfb5 --

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread William Junda Huang via cfe-commits
huangjd wrote: To clarify the implementation of ProfileFuncRef and how it guarantees correctness. There are two ways ProfileFuncRef can originate (ignoring copy constructions): 1 - From reading the profile, in which all ProfileFuncRef should have the same representation (either StringRef or M

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread William Junda Huang via cfe-commits
huangjd wrote: To clarify the implementation of ProfileFuncRef and how it guarantees correctness. There are two ways ProfileFuncRef can originate (ignoring copy constructions): 1 - From reading the profile, in which all ProfileFuncRef should have the same representation (either StringRef or M

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread Youngsuk Kim via cfe-commits
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs( CharUnits Align = CGM.getContext().getDeclAlign(VD); Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align); } -if (Val->getType() != Wrapper->getReturnType()) - Val = Builder

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/68277 >From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Mon, 2 Oct 2023 12:28:33 -0400 Subject: [PATCH] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC)

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread Youngsuk Kim via cfe-commits
JOE1994 wrote: Applied git clang-format. https://github.com/llvm/llvm-project/pull/68277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-04 Thread Youngsuk Kim via cfe-commits
JOE1994 wrote: No new regressions with `ninja check-clang` https://github.com/llvm/llvm-project/pull/68277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66167 >From 7abe016b179a986ee6f94973a1a2c313185705f0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 18:13:22 -0500 Subject: [PATCH] [libc] Partially implement 'rand' for the GPU Summary: This patch

[clang-tools-extra] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/66167 >From 7abe016b179a986ee6f94973a1a2c313185705f0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 12 Sep 2023 18:13:22 -0500 Subject: [PATCH] [libc] Partially implement 'rand' for the GPU Summary: This patch

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/66167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Partially implement 'rand' for the GPU (PR #66167)

2023-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/66167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,638 @@ +//===--- IRCanonicalizer.cpp - IR Canonicalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] llvm-canon (PR #68176)

2023-10-04 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,638 @@ +//===--- IRCanonicalizer.cpp - IR Canonicalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] f37028c - [Support] Rename HashBuilderImpl to HashBuilder (NFC) (#68173)

2023-10-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2023-10-04T20:33:38-07:00 New Revision: f37028c2cc216accea8946a84a21d48739a32569 URL: https://github.com/llvm/llvm-project/commit/f37028c2cc216accea8946a84a21d48739a32569 DIFF: https://github.com/llvm/llvm-project/commit/f37028c2cc216accea8946a84a21d48739a32569.diff L

[clang] [Support] Rename HashBuilderImpl to HashBuilder (NFC) (PR #68173)

2023-10-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/68173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Support] Deprecate system_endianness (PR #68279)

2023-10-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/68279 system_endianness() just returns llvm::endianness::native, a compile-time constant equivalent to std::native in C++20. This patch deprecates system_endianness() while replacing all invocations of system_en

[clang] [Support] Deprecate system_endianness (PR #68279)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Changes system_endianness() just returns llvm::endianness::native, a compile-time constant equivalent to std::native in C++20. This patch deprecates system_endianness() while replacing all invocations of system_endianness() with llvm::endian

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

2023-10-04 Thread Yaxun Liu via cfe-commits
@@ -1,5 +1,5 @@ // RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x c++ -triple nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s -fopenmp-is-target-device -o - | FileCheck %s -// RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x

[clang] c6ed5a6 - Revert "[HIP] Support compressing device binary (#67162)"

2023-10-04 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2023-10-05T00:29:42-04:00 New Revision: c6ed5a612556a43b856cc63f6c8cb948074275fc URL: https://github.com/llvm/llvm-project/commit/c6ed5a612556a43b856cc63f6c8cb948074275fc DIFF: https://github.com/llvm/llvm-project/commit/c6ed5a612556a43b856cc63f6c8cb948074275fc.dif

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Why not wrap this into `-Wconversion` on clang as well? https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome created https://github.com/llvm/llvm-project/pull/68284 When LLVM_UNREACHABLE_OPTIMIZE is turned off during release mode, a `do { BUILTIN_TRAP; BUILTIN_UNREACHABLE; } while(0)` is emitted this causes the ternary operator to not work as expected. Correct this be

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From edb04da9e4db6043f0905ad887a1fe5ffad48fca Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/2] Correct unreachable hint in release mode When LLVM_UNRE

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] eef35c2 - [clang-tidy]: Add TagDecl into LastTagDeclRanges in UseUsingCheck only when it is a definition (#67639)

2023-10-04 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-10-05T13:49:21+08:00 New Revision: eef35c287ee093b3521c6c2b682d8da538ad28be URL: https://github.com/llvm/llvm-project/commit/eef35c287ee093b3521c6c2b682d8da538ad28be DIFF: https://github.com/llvm/llvm-project/commit/eef35c287ee093b3521c6c2b682d8da538ad28be.diff LOG:

[clang-tools-extra] [clang-tidy]: Add TagDecl into LastTagDeclRanges in UseUsingCheck only when it is a definition (PR #67639)

2023-10-04 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/67639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

2023-10-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Overall looks fine, but please update release notes for this (update current entry or even merge them together instead of adding new one). https://github.com/llvm/llvm-project/pull/68185 ___ cfe-

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

2023-10-04 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
@@ -6,12 +6,8 @@ ; "end_function" lines intact when you commit. -; --trap-unreachable and --no-trap-after-noreturn are sensitive and bug-prone -; options for the WebAssembly back-end as, unlike in many other target -; architechtures, unreachable code being compiled to a trap

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
@@ -95,57 +92,4 @@ define i32 @missing_ret_noreturn_unreachable() { ; CHECK-NEXT:end_function call void @ext_never_return() unreachable -} - -; We could emit no instructions at all for the llvm unreachables in these next -; three tests, as the signatures match and reach

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
@@ -85,7 +81,8 @@ define i32 @missing_ret_unreachable() { } ; This is similar to the above test, but ensures wasm unreachable is emitted -; even after a noreturn call. +; even after a noreturn call. Using --no-trap-after-noreturn was previously +; known to break this.

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
@@ -95,57 +92,4 @@ define i32 @missing_ret_noreturn_unreachable() { ; CHECK-NEXT:end_function call void @ext_never_return() unreachable -} - -; We could emit no instructions at all for the llvm unreachables in these next -; three tests, as the signatures match and reach

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin deleted https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Heejin Ahn via cfe-commits
@@ -1,33 +1,95 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s +; The assertions in this file were autogenerated by +; utils/update_llc_test_checks.p

[clang] [clang][ExprConst] Don't try to evaluate value-dependent DeclRefExprs (PR #67778)

2023-10-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67778 >From 55a0f4abbb9ad9270aa18e2eec08b4a0bfb4dae0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 29 Sep 2023 11:23:55 +0200 Subject: [PATCH] [clang][ExprConst] Don't try to evaluate value-d

[clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome ready_for_review https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

2023-10-04 Thread Arvind Mukund via cfe-commits
https://github.com/MasterAwesome edited https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5ef904b - [clang][ExprConst] Don't try to evaluate value-dependent DeclRefExprs (#67778)

2023-10-04 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-05T08:42:34+02:00 New Revision: 5ef904b5da96562d3209c8f98e1175e623c37bc1 URL: https://github.com/llvm/llvm-project/commit/5ef904b5da96562d3209c8f98e1175e623c37bc1 DIFF: https://github.com/llvm/llvm-project/commit/5ef904b5da96562d3209c8f98e1175e623c37bc1.diff L

[clang] [clang][ExprConst] Don't try to evaluate value-dependent DeclRefExprs (PR #67778)

2023-10-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4