[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-04 Thread Richard Smith via cfe-commits
@@ -7304,6 +7382,21 @@ class BufferToAPValueConverter { return ArrayValue; } + std::optional visit(const VectorType *Ty, CharUnits Offset) { +SmallVector Bytes; +if (!Buffer.readObject(Offset, Info.Ctx.getTypeSizeInChars(Ty), Bytes)) + return std::nullopt;

[clang] 7d21086 - Revert "[clang] Predefined macros for float128 support (#67196)"

2023-10-04 Thread Pranav Kant via cfe-commits
Author: Pranav Kant Date: 2023-10-04T18:19:24Z New Revision: 7d21086d0ca4a680e96e0f4cd3e2597ebe027a48 URL: https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597ebe027a48 DIFF: https://github.com/llvm/llvm-project/commit/7d21086d0ca4a680e96e0f4cd3e2597ebe027a48.diff LOG: R

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @ldionne @arichardson , the problem is still there for more than 10 days already. Do you guys plan to fix it! https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Nikita Popov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

2023-10-04 Thread David Stone via cfe-commits
davidstone wrote: Would someone be able to merge this for me? I do not have permission. https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] `checkModuleIsAvailable` should use a const & parameter instead of pointer (PR #67902)

2023-10-04 Thread David Stone via cfe-commits
davidstone wrote: Would someone be able to merge this for me? I do not have permission. https://github.com/llvm/llvm-project/pull/67902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-04 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-04 Thread Richard Smith via cfe-commits
@@ -7441,6 +7500,28 @@ static bool handleLValueToRValueBitCast(EvalInfo &Info, APValue &DestValue, return true; } +static bool handleLValueToRValueBitCast(EvalInfo &Info, APValue &DestValue, +APValue &SourceValue, +

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-04 Thread Richard Smith via cfe-commits
https://github.com/zygoloid approved this pull request. Thanks, looks good. Just a couple of minor suggestions. https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-10-04 Thread Richard Smith via cfe-commits
@@ -10517,41 +10598,19 @@ bool VectorExprEvaluator::VisitCastExpr(const CastExpr *E) { return Success(Elts, E); } case CK_BitCast: { -// Evaluate the operand into an APInt we can extract from. -llvm::APInt SValInt; -if (!EvalAndBitcastToAPInt(Info, SE, SVal

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @ldionne @arichardson , the problem is still there for more than 10 days > already. Do you guys plan to fix it! I am waiting for @ldionne to approve this PR. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (PR #68241)

2023-10-04 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/68241 >From 2c6f1a7b618f00f6fae2fddaab94a60a01f3ce90 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Wed, 4 Oct 2023 10:52:33 -0700 Subject: [PATCH] [Modules] no_undeclared_includes modules (Apple Darwin) d

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread David Blaikie via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread David Blaikie via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread David Blaikie via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-04 Thread David Blaikie via cfe-commits
@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-04 Thread Craig Topper via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-04 Thread Craig Topper via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-04 Thread Craig Topper via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-04 Thread Craig Topper via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Nikita Popov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -618,7 +623,7 @@ class SampleContext { void clearState(ContextStateMask S) { State &= (uint32_t)~S; } bool hasContext() const { return State != UnknownContext; } bool isBaseContext() const { return FullContext.size() == 1; } - StringRef getName() const { return Name;

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -643,14 +648,11 @@ class SampleContext { uint64_t getHashCode() const { if (hasContext()) return hash_value(getContextFrames()); - -// For non-context function name, use its MD5 as hash value, so that it is -// consistent with the profile map's key. -

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
https://github.com/MatzeB edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-04 Thread Matthias Braun via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

2023-10-04 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield approved this pull request. LinkerWrapper turning into a linker is kind of inevitable and not a very happy thing. One option would be to lean on lld for amdgpu and split out the nvptx stuff in the hopes that we eventually have an alternative to nvlink, but it

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-04 Thread Rik Huijzer via cfe-commits
rikhuijzer wrote: > [...] I am a bit afraid of the burden of having to maintain what is > essentially a third GEP representation. Thanks for the explanation @zero9178. I am affraid I do not fully understand your reasoning (most likely due to a lack of knowledge on my side). However, it sounds

[clang] [clang][Interp] Fix crash during `InterpStack` printing (PR #68246)

2023-10-04 Thread via cfe-commits
https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/68246 `InterpStack` is using an `std::vector<>` to track the `ItemTypes`. As a result, the new types are inserted to the back of the `std::vector<>`, however `dump()` was reading the types from the front (the bottom

[clang] [clang][Interp] Fix crash during `InterpStack` printing (PR #68246)

2023-10-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes `InterpStack` is using an `std::vector<>` to track the `ItemTypes`. As a result, the new types are inserted to the back of the `std::vector<>`, however `dump()` was reading the types from the front (the bottom of the stack) and printing t

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Arthur Eubanks via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [Modules] no_undeclared_includes modules (Apple Darwin) don't work the clang modules (PR #68241)

2023-10-04 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: I could also revert most of the test changes and augment no-undeclared-includes-builtins.cpp, but I liked having a dedicated test that's not necessarily specific to Apple or glibc to test the intended system module setups with `-fbuiltin-headers-in-system-modules` set

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Nikita Popov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49d8a55 - [LinkerWrapper] Fix resolution of weak symbols during LTO (#68215)

2023-10-04 Thread via cfe-commits
Author: Joseph Huber Date: 2023-10-04T14:13:52-05:00 New Revision: 49d8a559d35b5b144d61c8d96b0538db7f719de4 URL: https://github.com/llvm/llvm-project/commit/49d8a559d35b5b144d61c8d96b0538db7f719de4 DIFF: https://github.com/llvm/llvm-project/commit/49d8a559d35b5b144d61c8d96b0538db7f719de4.diff

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

2023-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/68215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

2023-10-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I spotted some minor issues, but this LGTM for the initial implementation. Thank you for all your effort on this project!! There are some outstanding issues that should be handle

[clang] b4a076a - [clang-format][NFC] AlignTokens: Rename Changes[i] to CurrentChange (#68152)

2023-10-04 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-04T21:19:21+02:00 New Revision: b4a076a12d663a35075e371bac1df492e77ac58f URL: https://github.com/llvm/llvm-project/commit/b4a076a12d663a35075e371bac1df492e77ac58f DIFF: https://github.com/llvm/llvm-project/commit/b4a076a12d663a35075e371bac1df492e77ac58f.diff

[clang] [clang-format][NFC] AlignTokens: Rename Changes[i] to CurrentChange (PR #68152)

2023-10-04 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7539bcf - [clang-format][NFC] AlignTokenSequence: Rename Changes[i] to CurrentC…

2023-10-04 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-04T21:19:56+02:00 New Revision: 7539bcf994ed741417bcf86af96c61ff86534177 URL: https://github.com/llvm/llvm-project/commit/7539bcf994ed741417bcf86af96c61ff86534177 DIFF: https://github.com/llvm/llvm-project/commit/7539bcf994ed741417bcf86af96c61ff86534177.diff

[clang] [clang-format][NFC] AlignTokenSequence: Rename Changes[i] to CurrentC… (PR #68153)

2023-10-04 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From a5414db5e14cb40d062e54e780293cabc432197a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control IR verification ---

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's strongly

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] AlignTokenSequence: Skip loop iteration (PR #68154)

2023-10-04 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68154 From ca558ee22c4bc4749e3b7406364f3bbf8fb93ac9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Tue, 3 Oct 2023 17:32:47 +0200 Subject: [PATCH] [clang-format][NFC] AlignTokenS

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-10-04 Thread via cfe-commits
@@ -660,14 +671,16 @@ void PPCAsmPrinter::EmitTlsCall(const MachineInstr *MI, "GETtls[ld]ADDR[32] must read GPR3"); if (Subtarget->isAIXABI()) { -// On AIX, the variable offset should already be in R4 and the region handle -// should already be in R3. -

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

2023-10-04 Thread Guillot Tony via Phabricator via cfe-commits
to268 added a comment. > Do you need me to land this on your behalf? If so, I can fix up the NFC > changes I found for you, but what email address would you like me to use for > patch attribution? It is probably the best thing to do, and yes I need you to land this on your behalf. `Guillot Ton

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/68172 >From a5414db5e14cb40d062e54e780293cabc432197a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH 1/2] [Clang][Driver] Add new flags to control IR verification -

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

2023-10-04 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. lgtm, I tried out the GH feature to directly edit a file in the PR to fix a spelling issue https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

2023-10-04 Thread Rajkumar Ananthu via cfe-commits
https://github.com/rajkumarananthu updated https://github.com/llvm/llvm-project/pull/68127 >From b76f4d351b3e55e2095e3be088a50fdb76d6b7f9 Mon Sep 17 00:00:00 2001 From: Rajkumar Ananthu Date: Tue, 3 Oct 2023 21:53:59 +0530 Subject: [PATCH 1/2] Fixes and closes #53952 The issue #53952 is report

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

2023-10-04 Thread Markus Böck via cfe-commits
zero9178 wrote: > So before I spend more time on the code, shall I rewrite this PR to throw a > clear error from `GEPOp::verify` for the incorrect representation? Then we > can close #63832. I'd personally be in favour of that. There is a **lot** of room for improvements in the verifiers i

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

2023-10-04 Thread Rajkumar Ananthu via cfe-commits
@@ -4628,6 +4628,12 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile, WritingAST = true; ASTHasCompilerErrors = hasErrors; + bool trueHasErrors = SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred(); rajkumarananthu wrot

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

2023-10-04 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b7ac16c - [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (#67506)

2023-10-04 Thread via cfe-commits
Author: Arthur Eubanks Date: 2023-10-04T13:06:23-07:00 New Revision: b7ac16c70faf7274119f393797ce89c054346f48 URL: https://github.com/llvm/llvm-project/commit/b7ac16c70faf7274119f393797ce89c054346f48 DIFF: https://github.com/llvm/llvm-project/commit/b7ac16c70faf7274119f393797ce89c054346f48.diff

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
@@ -458,14 +458,12 @@ SourceManager::AllocateLoadedSLocEntries(unsigned NumSLocEntries, CurrentLoadedOffset - TotalSize < NextLocalOffset) { return std::make_pair(0, 0); } - - unsigned NewTableSize = LoadedSLocEntryTable.size() + NumSLocEntries; - LoadedSLocEntry

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
@@ -1986,13 +1984,15 @@ bool SourceManager::isInTheSameTranslationUnitImpl( if (isLoadedFileID(LOffs.first) != isLoadedFileID(ROffs.first)) return false; - // If both are loaded from different AST files. if (isLoadedFileID(LOffs.first) && isLoadedFileID(ROffs.first))

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
@@ -1986,13 +1984,15 @@ bool SourceManager::isInTheSameTranslationUnitImpl( if (isLoadedFileID(LOffs.first) != isLoadedFileID(ROffs.first)) return false; - // If both are loaded from different AST files. if (isLoadedFileID(LOffs.first) && isLoadedFileID(ROffs.first))

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 61e8961cde95e9e8ce8cea3efd6aa52273f430e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/6] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] b6f2919 - [clang-format][NFC] AlignTokenSequence: Skip loop iteration

2023-10-04 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-04T22:20:33+02:00 New Revision: b6f29191adb26ee870e624c414683cb3e6e03a87 URL: https://github.com/llvm/llvm-project/commit/b6f29191adb26ee870e624c414683cb3e6e03a87 DIFF: https://github.com/llvm/llvm-project/commit/b6f29191adb26ee870e624c414683cb3e6e03a87.diff

[clang] [clang-format][NFC] AlignTokenSequence: Skip loop iteration (PR #68154)

2023-10-04 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

2023-10-04 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. I was going to delegate the review to @aeubanks, who was the last one I'm aware of to touch the strict vptr feature, but I think this is a pretty straightforward fix. https://github.com/llvm/llvm-project/pull/68169

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > it's quite possible that someone has ended up depending on the previous de > > facto behaviour. > > Then we have to be super creative and find a better solution. > > How about changing the logic, and where `Driver.InstalledDir` is used, if the > desired file/folder is not

[clang] 0fb1ad5 - [Clang][CodeGen][NFC] Add (broken) test case for GH67937

2023-10-04 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2023-10-04T22:36:20+02:00 New Revision: 0fb1ad564e59a7259b81b7828fca272c762d30f5 URL: https://github.com/llvm/llvm-project/commit/0fb1ad564e59a7259b81b7828fca272c762d30f5 DIFF: https://github.com/llvm/llvm-project/commit/0fb1ad564e59a7259b81b7828fca272c762d30f5.dif

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68169 >From bd6cb19d6261b46ff1c7014140eff59609134272 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 02:40:25 +0200 Subject: [PATCH] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePoin

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

2023-10-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM after fixing nits. https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
@@ -14143,8 +14145,9 @@ static void AnalyzeComparison(Sema &S, BinaryOperator *E) { } // Otherwise, calculate the effective range of the signed operand. - IntRange signedRange = GetExprRange( - S.Context, signedOperand, S.isConstantEvaluated(), /*Approximate*/ true)

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
@@ -15090,8 +15093,9 @@ static void CheckImplicitConversion(Sema &S, Expr *E, QualType T, if (SourceBT && TargetBT && SourceBT->isIntegerType() && TargetBT->isFloatingType() && !IsListInit) { // Determine the number of precision bits in the source integer type. -

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. Thanks for iterating! I find the current implementation much clearer. The only thing I might quibble about is the "child" vs. "parent" terminology you changed: I think it's fairly ambiguous either way, because the node is the "child" f

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. Thanks for iterating! I find the current implementation much clearer. The only thing I might quibble about is the "child" vs. "parent" terminology you changed: I think it's fairly ambiguous either way, because the node is the "child" f

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
@@ -1444,6 +1444,74 @@ llvm::Error ASTReader::ReadSourceManagerBlock(ModuleFile &F) { } } +llvm::Expected +ASTReader::readSLocOffset(ModuleFile *F, unsigned Index) { + BitstreamCursor &Cursor = F->SLocEntryCursor; + SavedStreamPosition SavedPosition(Cursor); + if (llvm::

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. LGTM; you might need a `std::move` in `readSLocOffset` to appease an older compiler. https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-10-04 Thread Ben Langmuir via cfe-commits
@@ -288,10 +288,12 @@ class ModuleFile { /// for the entry is SLocEntryOffsetsBase + SLocEntryOffsets[i]. uint64_t SLocEntryOffsetsBase = 0; - /// Offsets for all of the source location entries in the - /// AST file. + /// Stream bit offsets for all of the source locati

[clang] [clang] fix hasAnyBase not binding submatchers (PR #67939)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I think you should also add `[ASTMatcher]` to the subject after `[Clang]` at least that is what past PRs seem to do. https://github.com/llvm/llvm-project/pull/67939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

2023-10-04 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/5] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Matt Harding via cfe-commits
https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/12] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-10-04 Thread Matt Harding via cfe-commits
https://github.com/majaha updated https://github.com/llvm/llvm-project/pull/65876 >From 7c43c803764bf9e0256d4e3e9f497d2622bb8f69 Mon Sep 17 00:00:00 2001 From: Matt Harding Date: Fri, 25 Aug 2023 06:19:14 +0100 Subject: [PATCH 01/12] Add no-trap-after-noreturn flag and wasm tests Add the comma

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson , would you commit these changes without @ldionne 's approval? or revert your #66545? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

2023-10-04 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @arichardson , would you commit these changes without @ldionne 's approval? or revert your #66545? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

2023-10-04 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I would hate to lose the non-diagram part of this documentation. Do the criticism mainly apply to the diagrams and the text documentation is ok for most? https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-c

<    1   2   3   4   >