https://github.com/qcolombet approved this pull request.
I think the singleton implementation for the warpsize value is broken and
anyway overkill.
I believe we still miss a change in a cmake file.
Other than that couple of nits but LGTM.
https://github.com/llvm/llvm-project/pull/65441
___
@@ -529,6 +530,39 @@ LogicalResult WarpgroupMmaOp::verify() {
return success();
}
+LogicalResult WarpgroupMmaStoreOp::verify() {
+ MemRefType dstMemrefType = getDstMemref().getType();
+ VectorType firstVtype = getMatrixD()
+ .front()
+
@@ -727,4 +727,24 @@ def NVGPU_WarpgroupMmaOp : NVGPU_Op<"warpgroup.mma"> {
let hasVerifier = 1;
}
+def NVGPU_WarpgroupMmaStoreOp : NVGPU_Op<"warpgroup.mma.store"> {
+ let description = [{
+The `nvgpu.warpgroup.mma.store` op performs the store of fragmented result
+
@@ -5277,6 +5277,7 @@ cc_library(
":LLVMCommonConversion",
":LLVMDialect",
":MemRefDialect",
+":MLIRArithDialect",
qcolombet wrote:
I think we need a similar change in
`mlir/lib/Conversion/NVGPUToNVVM/CMakeLists.txt`
https://g
@@ -529,6 +530,39 @@ LogicalResult WarpgroupMmaOp::verify() {
return success();
}
+LogicalResult WarpgroupMmaStoreOp::verify() {
+ MemRefType dstMemrefType = getDstMemref().getType();
+ VectorType firstVtype = getMatrixD()
+ .front()
+
@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter,
Location loc,
return rewriter.create(loc, rewriter.getI32Type(), value);
}
+/// Returns warp-size as a value.
+static Value getWarpSizeValue(ImplicitLocOpBuilder &b) {
qcolombet
https://github.com/qcolombet edited
https://github.com/llvm/llvm-project/pull/65441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter,
Location loc,
return rewriter.create(loc, rewriter.getI32Type(), value);
}
+/// Returns warp-size as a value.
+static Value getWarpSizeValue(ImplicitLocOpBuilder &b) {
qcolombet
Author: Aaron Ballman
Date: 2023-10-04T10:22:06-04:00
New Revision: 01526696717e0694b906ccab412f1ec5da2a574d
URL:
https://github.com/llvm/llvm-project/commit/01526696717e0694b906ccab412f1ec5da2a574d
DIFF:
https://github.com/llvm/llvm-project/commit/01526696717e0694b906ccab412f1ec5da2a574d.diff
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/68220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE commented:
This change is a good step forward and cleanly implemented. Could you show some
results from open source projects?
As a side remark, I'd like to mention that the separate handling of the "size
is zero" and the "size is negative" cases is logically incor
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/68140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -220,7 +220,7 @@ void VLASizeChecker::reportTaintBug(const Expr *SizeE,
ProgramStateRef State,
SmallString<256> buf;
llvm::raw_svector_ostream os(buf);
os << "Declared variable-length array (VLA) ";
- os << "has tainted size";
+ os << "has a tainted (attacker contro
aaron.ballman added a comment.
I guess I'm a bit lost as to what the code example has to do with the constant
expression interpreter in the first place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156453/new/
https://reviews.llvm.org/D156453
__
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -265,10 +265,13 @@ void USRGenerator::VisitFunctionDecl(const FunctionDecl
*D) {
Out << '>';
}
+ QualType CanonicalType = D->getType().getCanonicalType();
// Mangle in type information for the arguments.
- for (auto *PD : D->parameters()) {
-Out << '#';
-
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a request for some comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:76
llvm::DenseMap> LambdaCaptures;
- unsigned LambdaThisCapt
ilg-ul wrote:
I took some time to analyse the failed tests. I managed to reproduce them
(except `rocm-detect.hip`) on my macOS, so I had more freedom to experiment.
The failing tests are:
- `Clang::Driver/mingw-sysroot.cpp`
- `Clang::Driver/no-canonical-prefixes.c`
- `Clang::Driver/program-pat
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yaxun (Sam) Liu
Date: 2023-10-04T11:05:16-04:00
New Revision: ba01ce60665848478ba4e76190907153a8c26fe9
URL:
https://github.com/llvm/llvm-project/commit/ba01ce60665848478ba4e76190907153a8c26fe9
DIFF:
https://github.com/llvm/llvm-project/commit/ba01ce60665848478ba4e76190907153a8c26fe9.dif
ilg-ul wrote:
@jansvoboda11, since the Apple clang already fixed this bug, could you suggest
how to proceed? Could you backport the Apple patch to upstream?
Please also take a look at the original bug report #66704, since it is related
to macOS.
https://github.com/llvm/llvm-project/pull/6809
smcpeak wrote:
As the feedback has been mostly negative, I'm closing this PR.
https://github.com/llvm/llvm-project/pull/66436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smcpeak closed
https://github.com/llvm/llvm-project/pull/66436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/16] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/16] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/hnrklssn edited
https://github.com/llvm/llvm-project/pull/67519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hnrklssn requested changes to this pull request.
Please update `clang/test/CodeGen/profile-filter.c` with some cases that
exercise the new code path.
https://github.com/llvm/llvm-project/pull/67519
___
cfe-commits mailing list
cfe-c
@@ -139,9 +139,23 @@ std::optional
ProfileList::isFileExcluded(StringRef FileName,
CodeGenOptions::ProfileInstrKind Kind) const {
StringRef Section = getSectionName(Kind);
- // Check for "source:="
+
+ // Convert the input file path to its canoni
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
@@ -85,3 +85,38 @@ int main() {
}
+
+namespace deduceTemplatedConstructor{
whisperity wrote:
There is a slight formatting issue here. There should be a space before ` {`.
https://github.
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
ilg-ul wrote:
Another way to rephrase the question: the current implementation that preserves
the symlinks, was it an explicitly required feature, or rather a side effect
that came into existence by accident when implementing the current tests?
https://github.com/llvm/llvm-project/pull/68091
_
@@ -85,3 +85,38 @@ int main() {
}
+
+namespace deduceTemplatedConstructor{
HoBoIs wrote:
Done
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
@@ -85,3 +85,38 @@ int main() {
}
+
+namespace deduceTemplatedConstructor{
HoBoIs wrote:
Done
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
@@ -85,3 +85,38 @@ int main() {
}
+
+namespace deduceTemplatedConstructor{
HoBoIs wrote:
Done
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/4] [mlir][sparse] Print new syntax
Printing changes from #s
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/4] [mlir][sparse] Print new syntax
Printing changes from #s
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/5] [mlir][sparse] Print new syntax
Printing changes from #s
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/5] [mlir][sparse] Print new syntax
Printing changes from #s
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/68222
>From db0887d6c68dc5610a9189c96de8fcbb631385a1 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 4 Oct 2023 10:06:28 -0400
Subject: [PATCH] [clang][Index] Use canonical function parameter types in
https://github.com/alex-t updated
https://github.com/llvm/llvm-project/pull/68004
>From 7d894c0b039e6804079c096f1bbeb2980cafe378 Mon Sep 17 00:00:00 2001
From: Alexander Timofeev
Date: Mon, 2 Oct 2023 18:35:12 +0200
Subject: [PATCH 1/2] [AMDGPU][MachineScheduler] Alternative way to control
exc
https://github.com/alex-t updated
https://github.com/llvm/llvm-project/pull/68004
>From 7d894c0b039e6804079c096f1bbeb2980cafe378 Mon Sep 17 00:00:00 2001
From: Alexander Timofeev
Date: Mon, 2 Oct 2023 18:35:12 +0200
Subject: [PATCH 1/2] [AMDGPU][MachineScheduler] Alternative way to control
exc
https://github.com/alex-t updated
https://github.com/llvm/llvm-project/pull/68004
>From 7d894c0b039e6804079c096f1bbeb2980cafe378 Mon Sep 17 00:00:00 2001
From: Alexander Timofeev
Date: Mon, 2 Oct 2023 18:35:12 +0200
Subject: [PATCH 1/2] [AMDGPU][MachineScheduler] Alternative way to control
exc
https://github.com/alex-t updated
https://github.com/llvm/llvm-project/pull/68004
>From 7d894c0b039e6804079c096f1bbeb2980cafe378 Mon Sep 17 00:00:00 2001
From: Alexander Timofeev
Date: Mon, 2 Oct 2023 18:35:12 +0200
Subject: [PATCH 1/2] [AMDGPU][MachineScheduler] Alternative way to control
exc
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity commented:
LGTM with previous discussion. I will do the commit... On the UI...
:slightly_smiling_face:
https://github.com/llvm/llvm-project/pull/66487
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=,
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
https://github.com/whisperity approved this pull request.
> TIL there is no way to resign a review here like there was on Phab...
https://github.com/llvm/llvm-project/pull/66487
__
https://github.com/jryans approved this pull request.
Looks good to me, thanks! 😄
Other reviewers had more comments last time around, so probably best to wait
for at least one more review before landing.
https://github.com/llvm/llvm-project/pull/66745
_
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Author: Botond István Hprváth
Date: 2023-10-04T09:11:43-07:00
New Revision: 66c19167f127013f6834ea1a316b783e57490939
URL:
https://github.com/llvm/llvm-project/commit/66c19167f127013f6834ea1a316b783e57490939
DIFF:
https://github.com/llvm/llvm-project/commit/66c19167f127013f6834ea1a316b783e574909
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=,
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=
Message-ID:
In-Reply-To:
erichkeane wrote:
I had permissions, so I squash/merged.
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cf
@@ -701,6 +701,10 @@ class SourceManager : public RefCountedBase
{
/// use (-ID - 2).
SmallVector LoadedSLocEntryTable;
+ /// For each allocation in LoadedSLocEntryTable, we keep the new size. This
+ /// can be used to determine whether two FileIDs come from the same AS
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
whisperity wrote:
It looks like the authorship metadata was set up incorrectly in the commits. I
was in the process of fixing the things locally.
https://github.com/llvm/llvm-project/pull/66487
___
Botond =?utf-8?q?István_Hprváth?=,
Botond =?utf-8?q?István_Hprváth?Message-ID:
In-Reply-To:
erichkeane wrote:
Ah, I see, apologies. I thought you meant the resign/etc complaint meant you
couldn't commit through the UI.
https://github.com/llvm/llvm-project/pull/66487
_
@@ -176,3 +176,34 @@ Predefined Macros
* - ``HIP_API_PER_THREAD_DEFAULT_STREAM``
- Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated.
+C++20 Concepts with HIP and CUDA
+
+
+In Clang, when working with HIP or CUDA, it's impor
mstorsjo wrote:
> Without any other reference, I checked the Apple clang, on my macOS:
>
> ```
> ilg@wksi ~ % /usr/bin/clang -v
> Apple clang version 14.0.0 (clang-1400.0.29.202)
> Target: x86_64-apple-darwin21.6.0
> Thread model: posix
> InstalledDir: /Library/Developer/CommandLineTools/usr/bin
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/68126
>From 87e7bba138e2d702d0e2433f2b81c891fec4d2bd Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Tue, 3 Oct 2023 12:21:10 -0400
Subject: [PATCH] [HIP] Document func ptr and virtual func
Document clang supp
tbaeder added a comment.
It gets interpreted as a constant expression in
`Sema::CheckCompleteVariableInitialization()`:
* #0: Context.cpp:73
clang::interp::Context::evaluateAsInitializer(this=0x60805d20,
Parent=0x7fff6dc2a8d0, VD=0x62173b48, Result=0x62199e90)
ilg-ul wrote:
> it's quite possible that someone has ended up depending on the previous de
> facto behaviour.
Then we have to be super creative and find a better solution.
How about changing the logic, and where `Driver.InstalledDir` is used, if the
desired file/folder is not found (like head
chaitanyav updated this revision to Diff 557588.
chaitanyav added a comment.
Rebase with upstream
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147844/new/
https://reviews.llvm.org/D147844
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/Sema
https://github.com/ldionne requested changes to this pull request.
Thanks a lot for the patch! I think this is really great and I'm glad we're
paving the way for new backends being added in the library. Since this is the
first such backend, there are some thing to change as we discussed during
@@ -0,0 +1,44 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,27 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,50 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,50 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,41 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -807,6 +815,11 @@ else()
Valid backends are: serial, std_thread and libdispatch")
endif()
+config_define_if(LIBCXX_ENABLE_GPU_OFFLOAD _LIBCPP_PSTL_GPU_OFFLOAD)
ldionne wrote:
I think we should do something like this instead:
```
if
@@ -0,0 +1,37 @@
+//===--===//
ldionne wrote:
I think this header can go away entirely.
https://github.com/llvm/llvm-project/pull/66968
___
cfe-commit
@@ -0,0 +1,120 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,27 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,44 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,349 @@
+//===--===//
ldionne wrote:
Not attached to this line:
We need to discuss how exceptions are handled when we offload to the GPU.
@AntonRydahl mentioned that `throw` was compi
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/66968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
Thanks a lot for the patch! I think this is really great and I'm glad we're
paving the way for new backends being added in the library. Since this is the
first such backend, there are some thing to change as we discussed during
@@ -0,0 +1,87 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,50 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,37 @@
+//===--===//
ldionne wrote:
I think this header can go away entirely.
https://github.com/llvm/llvm-project/pull/66968
___
cfe-commit
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/66962
>From 61e8961cde95e9e8ce8cea3efd6aa52273f430e9 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Wed, 20 Sep 2023 16:50:48 -0700
Subject: [PATCH 1/4] [clang][modules] Remove preloaded SLocEntries from PCM
fi
rsmith added a comment.
I've been pondering what I'd want from a warning here. I think generally I
would like to warn if there are two plausible interpretations of the token
sequence -- that is, if giving the `?` different precedence could plausibly
lead to a different valid program. I think co
ZijunZhao updated this revision to Diff 557589.
ZijunZhao added a comment.
Remove stdckdint.h in module.map
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157331/new/
https://reviews.llvm.org/D157331
Files:
clang/docs/ReleaseNotes.rst
clang/inc
@@ -176,3 +176,65 @@ Predefined Macros
* - ``HIP_API_PER_THREAD_DEFAULT_STREAM``
- Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated.
+Function Pointers Support in Clang with HIP
+===
+
+Function pointers' support va
@@ -176,3 +176,65 @@ Predefined Macros
* - ``HIP_API_PER_THREAD_DEFAULT_STREAM``
- Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated.
+Function Pointers Support in Clang with HIP
+===
+
+Function pointers' support va
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/66962
>From 61e8961cde95e9e8ce8cea3efd6aa52273f430e9 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Wed, 20 Sep 2023 16:50:48 -0700
Subject: [PATCH 1/5] [clang][modules] Remove preloaded SLocEntries from PCM
fi
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/68241
All of the _Builtin_stdarg and _Builtin_stddef submodules need to be allowed
from [no_undeclared_includes] modules. Split the builtin headers tests out from
the compiler_builtins test so that the testi
@@ -458,14 +458,12 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
-
- unsigned NewTableSize = LoadedSLocEntryTable.size() + NumSLocEntries;
- LoadedSLocEntry
@@ -1986,13 +1984,15 @@ bool SourceManager::isInTheSameTranslationUnitImpl(
if (isLoadedFileID(LOffs.first) != isLoadedFileID(ROffs.first))
return false;
- // If both are loaded from different AST files.
if (isLoadedFileID(LOffs.first) && isLoadedFileID(ROffs.first))
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
All of the _Builtin_stdarg and _Builtin_stddef submodules need to be allowed
from [no_undeclared_includes] modules. Split the builtin headers tests out from
the compiler_builtins test so that the testing modules can be modified without
af
efriedma updated this revision to Diff 557592.
efriedma added a comment.
Updated with feedback from @dpaoliello and additional internal testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157547/new/
https://reviews.llvm.org/D157547
Files:
cl
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zero9178 wrote:
Thank you for your elaboration!
I am not sure whether the original commit is referring to also supporting both
typed pointers and opaque pointers in the exact same IR. This behaviour
deviates from LLVM entirely as LLVM only supported one or the other as well.
Furthermore, your
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e86d6a43f03b6d635d8d1101a936088c8cf0cf23
389a174b0e8462ed15d9ca1e1b223618aec99d21 --
@@ -458,14 +458,12 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
-
- unsigned NewTableSize = LoadedSLocEntryTable.size() + NumSLocEntries;
- LoadedSLocEntry
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/66962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -458,14 +458,12 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
-
- unsigned NewTableSize = LoadedSLocEntryTable.size() + NumSLocEntries;
- LoadedSLocEntry
101 - 200 of 394 matches
Mail list logo
