[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/68185 None From 91ce80c89689518c20f18efd172628a51aebb769 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 4 Oct 2023 09:38:28 +0200 Subject: [PATCH] [clang-tidy][IncludeCleaner] Fix analysis supression in p

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246 >From 1c2f558a80635333655011c723af69371d3587af Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 01/12] [Clang] Fix missing diagnostic for non-standard layout

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH 1/4] [IPSCCP] Variable not visible at Og: htt

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of th

[libclc] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of th

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of th

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

CarlosAlbertoEnciso wrote: @jryans, @felipepiovezan, @nikic, @dwblaikie: Thanks for all your feedback. I have uploaded a new patch that addresses all your points. I am sorry if there are extra commits on this branch. This is the first update since moving to GitHub. https://github.com/llvm/llvm

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

https://github.com/CarlosAlbertoEnciso edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

@@ -97,9 +98,12 @@ bool IncludeCleanerCheck::shouldIgnore(const include_cleaner::Header &H) { return llvm::any_of(IgnoreHeadersRegex, [&H](const llvm::Regex &R) { switch (H.kind()) { case include_cleaner::Header::Standard: + // We don't trim braces around standa

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652785 , @AlexVlx wrote: > In D155775#4652780 , @dyung wrote: > >> >> At this point, would it be easier to add a REQUIRES line for the target the >> test should support rather

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

@@ -179,12 +183,14 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { if (getCurrentMainFile().endswith(PHeader)) continue; } - -if (llvm::none_of( -IgnoreHeadersRegex, -[Resolved = (*I.Resolved).getFileEn

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

https://github.com/VitaNuo requested changes to this pull request. Thank you. What was the bug that triggered this? It seems like the verbatim headers were only matched if they were specified as quoted in the ignore config? https://github.com/llvm/llvm-project/pull/68185 ___

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

gchatelet wrote: It would be ideal to move the [following lines]( https://github.com/llvm/llvm-project/blob/b3c710beda5b45dc18a5cbd74e141c1169971450/clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.cpp#L17-L18) to a shared header and use them in both implementations. https:

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

https://github.com/gamesh411 created https://github.com/llvm/llvm-project/pull/68191 EnumCastOutOfRange checker now reports the name of the enum in the warning message. Additionally, a note-tag is placed to highlight the location of the declaration. From 6b70c3246747b5a1204062f40f91273f60a386

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

llvmbot wrote: @llvm/pr-subscribers-clang Changes EnumCastOutOfRange checker now reports the name of the enum in the warning message. Additionally, a note-tag is placed to highlight the location of the declaration. --- Patch is 30.39 KiB, truncated to 20.00 KiB below, full version: htt

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

https://github.com/Fznamznon commented: Probably needs a release note. https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/5] Choose the correct deduction guide If there are two guides, one of th

[libclc] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/5] Choose the correct deduction guide If there are two guides, one of th

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/5] Choose the correct deduction guide If there are two guides, one of th

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

@@ -179,12 +183,14 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { if (getCurrentMainFile().endswith(PHeader)) continue; } - -if (llvm::none_of( -IgnoreHeadersRegex, -[Resolved = (*I.Resolved).getFileEn

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/68185 From 91ce80c89689518c20f18efd172628a51aebb769 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 4 Oct 2023 09:38:28 +0200 Subject: [PATCH 1/2] [clang-tidy][IncludeCleaner] Fix analysis supression in pre

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

kadircet wrote: > Thank you. What was the bug that triggered this? It seems like the verbatim > headers were only matched if they were specified as quoted in the ignore > config? I just noticed it while trying to fix an internal issue. https://github.com/llvm/llvm-project/pull/68185 _

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

https://github.com/Krishna-13-cyber updated https://github.com/llvm/llvm-project/pull/65650 >From 63b41d9498a71e090cbf1fdca2d87f368aeb809c Mon Sep 17 00:00:00 2001 From: Krishna-13-cyber Date: Thu, 7 Sep 2023 22:35:53 +0530 Subject: [PATCH 1/2] Add Documentation for Execution Results Handling i

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

https://github.com/Krishna-13-cyber updated https://github.com/llvm/llvm-project/pull/65650 >From 001c8fe5627bb83c71a11535889d3c717a869df5 Mon Sep 17 00:00:00 2001 From: Krishna-13-cyber Date: Thu, 7 Sep 2023 22:35:53 +0530 Subject: [PATCH] Add Documentation for Execution Results Handling in C

[clang] [CodeGen] Respect pointer-overflow sanitizer for void pointers (PR #67772)

https://github.com/bwendling approved this pull request. https://github.com/llvm/llvm-project/pull/67772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

bgra8 wrote: @FreddyLeaf functions with `__attribute__((target("avx")))` trigger the newly added warning. Code like this no longer builds and creates a lot of fallout for us (google internal code): ``` #include __attribute__((target("avx"))) void test(__m128 a, __m128 b) { _mm_cmp_ps(a, b

[clang] 077e1b8 - [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (#66641)

Author: zyn0217 Date: 2023-10-04T04:45:46-05:00 New Revision: 077e1b892d9555c503b86d5361278aa999764884 URL: https://github.com/llvm/llvm-project/commit/077e1b892d9555c503b86d5361278aa999764884 DIFF: https://github.com/llvm/llvm-project/commit/077e1b892d9555c503b86d5361278aa999764884.diff LOG:

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155775#4652851 , @ro wrote: > In D155775#4652785 , @AlexVlx wrote: > >> In D155775#4652780 , @dyung wrote: >> >>> > > > >>> At this point, wo

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b6f6fe98a856e9ce8ab945ef18d49291a8486acc..001c8fe5627bb83c71a11535889d3c717a869df5 clang/

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652872 , @AlexVlx wrote: > In D155775#4652851 , @ro wrote: > >> In D155775#4652785 , @AlexVlx >> wrote: >> >>> In D155775#4652780

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

rikhuijzer wrote: > What are the use cases for allowing either of these two syntaxes? > The LLVM Dialect tries to closely mirror LLVM proper as much as possible and > this would deviate from LLVMs behaviour. While the transition is currently > stalled, in the future typed pointers will be remov

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

@@ -179,12 +183,14 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult &Result) { if (getCurrentMainFile().endswith(PHeader)) continue; } - -if (llvm::none_of( -IgnoreHeadersRegex, -[Resolved = (*I.Resolved).getFileEn

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From ee49cd2bddc21be68f73fca7cb344150cd7ad7a6 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [CLang][Driver] Add new flags to control IR verification ---

[clang] [clang][dataflow] HTML logger: Mark iterations that have converged. (PR #68204)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/68204 I've eliminated the `logText("Block converged")` call entirely because a) These logs are associated with an individual `CFGElement`, while convergence should be associated with a block, and b) The log me

[clang] [clang][dataflow] HTML logger: Mark iterations that have converged. (PR #68204)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/68204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] HTML logger: Mark iterations that have converged. (PR #68204)

llvmbot wrote: @llvm/pr-subscribers-clang Changes I've eliminated the `logText("Block converged")` call entirely because a) These logs are associated with an individual `CFGElement`, while convergence should be associated with a block, and b) The log message was being associated with t

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246 >From 1c2f558a80635333655011c723af69371d3587af Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 01/13] [Clang] Fix missing diagnostic for non-standard layout

[clang] 9f406e4 - [HIP][Clang][Driver] Correctly specify test requirements as Linux + x86 + AMDGPU; temporarily retain targeted XFAILs for Hexagon & PS.

Author: Alex Voicu Date: 2023-10-04T12:04:13+01:00 New Revision: 9f406e450b6dfebe41be54cc7a7a6861b8eaf618 URL: https://github.com/llvm/llvm-project/commit/9f406e450b6dfebe41be54cc7a7a6861b8eaf618 DIFF: https://github.com/llvm/llvm-project/commit/9f406e450b6dfebe41be54cc7a7a6861b8eaf618.diff LO

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From 8a0226386732cea374558a38475c7d629c84ef28 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [CLang][Driver] Add new flags to control IR verification ---

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From 634c0f8ea4acd0694d89c3e2d278e6bcb78b923f Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control IR verification ---

[clang] [clang][dataflow] HTML logger: Mark iterations that have converged. (PR #68204)

https://github.com/sam-mccall approved this pull request. This is great! https://github.com/llvm/llvm-project/pull/68204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman updated this revision to Diff 557575. aaron.ballman added a comment. Updated based on review feedback. Specifically: - Added test cases, fixed handling of parenthesized expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565

[clang] 2be7c65 - [clang][dataflow] HTML logger: Mark iterations that have converged. (#68204)

Author: martinboehme Date: 2023-10-04T13:47:24+02:00 New Revision: 2be7c651c4a221a681b4a668617e73bf4a681a34 URL: https://github.com/llvm/llvm-project/commit/2be7c651c4a221a681b4a668617e73bf4a681a34 DIFF: https://github.com/llvm/llvm-project/commit/2be7c651c4a221a681b4a668617e73bf4a681a34.diff

[clang] [clang][dataflow] HTML logger: Mark iterations that have converged. (PR #68204)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/68204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/68191 From 6b70c3246747b5a1204062f40f91273f60a38600 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 4 Oct 2023 10:38:00 +0200 Subject: [PATCH 1/2] [analyzer] Extend EnumCastOutOfRange di

[clang-tools-extra] [include-cleaner] don't consider the associated header unused (PR #67228)

https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/67228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] don't consider the associated header unused (PR #67228)

@@ -379,6 +379,54 @@ TEST_F(PragmaIncludeTest, IWYUKeep) { EXPECT_TRUE(PI.shouldKeep(FM.getFile("std/set").get())); } +TEST_F(PragmaIncludeTest, AssociatedHeader) { + createEmptyFiles({"foo/main.h", "bar/main.h", "bar/other.h", "std/vector"}); + auto IsKeep = [&](llvm::Str

[clang-tools-extra] [include-cleaner] don't consider the associated header unused (PR #67228)

@@ -379,6 +379,54 @@ TEST_F(PragmaIncludeTest, IWYUKeep) { EXPECT_TRUE(PI.shouldKeep(FM.getFile("std/set").get())); } +TEST_F(PragmaIncludeTest, AssociatedHeader) { + createEmptyFiles({"foo/main.h", "bar/main.h", "bar/other.h", "std/vector"}); + auto IsKeep = [&](llvm::Str

[clang-tools-extra] [include-cleaner] don't consider the associated header unused (PR #67228)

@@ -276,6 +280,27 @@ class PragmaIncludes::RecordPragma : public PPCallbacks, public CommentHandler { KeepStack.pop_back(); // Pop immediately for single-line keep pragma. } + // Consider marking H as the "associated header" of the main file. + // + // Our heuristi

[clang-tools-extra] [include-cleaner] don't consider the associated header unused (PR #67228)

https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/67228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Support compressing device binary (PR #67162)

https://github.com/jhuber6 approved this pull request. I think in the long term we need to move away from the bundler, which would suggest we probably want something similar in the "new driver". But overall the changes here are pretty self contained and the concept is straightforward. https://

[clang] [analyzer][NFC] Remove outdated FIXME comment (PR #68211)

https://github.com/DonatNagyE created https://github.com/llvm/llvm-project/pull/68211 This trivial commit removes a 13-year-old FIXME comment from MallocChecker.cpp because it was fixed at least 10 years ago when `getConjuredHeapSymbolVal()` was added. >From 70a4adb3ef1444130ddaf9b04d9d7fb887

[clang] [analyzer][NFC] Remove outdated FIXME comment (PR #68211)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This trivial commit removes a 13-year-old FIXME comment from MallocChecker.cpp because it was fixed at least 10 years ago when `getConjuredHeapSymbolVal()` was added. --- Full diff: https://github.com/llvm/llvm-project/pull/68211.diff 1

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 01/11] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 01/11] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/AaronBallman commented: I'd appreciate some unit tests showing that we print the elaboration in other circumstances. e.g., ``` struct S { int x; }; namespace NS { class C {}; } S foo(S s1, NS::C c1) { S s12{12}; using namespace NS; C c; } ``` ensuring that we pretty pri

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/AaronBallman commented: I'd appreciate some unit tests showing that we print the elaboration in other circumstances. e.g., ``` struct S { int x; }; namespace NS { class C {}; } S foo(S s1, NS::C c1) { S s12{12}; using namespace NS; C c; } ``` ensuring that we pretty pri

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

cor3ntin wrote: > Probably needs a release note. Nah, this fixes a bug with deducing this I introduced on Monday :) https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

@@ -4628,6 +4628,12 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile, WritingAST = true; ASTHasCompilerErrors = hasErrors; + bool trueHasErrors = SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred(); AaronBallman wrote:

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D148381#4652825 , @void wrote: > Yes, I mean to do it as a direct follow-up. 😊 Okay, let's go that route then. This gets a fairly sig

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68215 Summary: Weak symbols are supposed to have the semantics that they can be overriden by a strong (i.e. global) definition. This wasn't being respected by the LTO pass because we simply used the first definition tha

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: Weak symbols are supposed to have the semantics that they can be overriden by a strong (i.e. global) definition. This wasn't being respected by the LTO pass because we simply used the first definition that was available. This patch

[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

https://github.com/asb created https://github.com/llvm/llvm-project/pull/68216 This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this. Skip the test until the issue is resolved. It seems that D159167 enabled this test for more tha

[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this. Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the te

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ceec9a7874af2eea8b00b5616fad388ccfa2b4f3 0fec18f2f745b798fe48ce08c1441c3439d009a6 --

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

diseraluca wrote: > > @vgvassilev If that is an acceptable interface for the LLVM interface then, > > yes, it would be perfect from our side, and I'm more than happy to update > > the PR in the next few days. > > Just to be sure that I understood your proposal. > > `getFullyQualified*` calls wi

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

tripleCC added a comment. merged in https://github.com/llvm/llvm-project/pull/67563#event-10544755217 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159549/new/ https://reviews.llvm.org/D159549 ___ cfe-co

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

@@ -4628,6 +4628,12 @@ ASTFileSignature ASTWriter::WriteAST(Sema &SemaRef, StringRef OutputFile, WritingAST = true; ASTHasCompilerErrors = hasErrors; + bool trueHasErrors = SemaRef.PP.getDiagnostics().hasUncompilableErrorOccurred(); rajkumarananthu wrot

[clang] [CodeGen] Respect pointer-overflow sanitizer for void pointers (PR #67772)

https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/67772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 39d5532 - [CodeGen] Respect pointer-overflow sanitizer for void pointers (#67772)

Author: Nikita Popov Date: 2023-10-04T15:16:00+02:00 New Revision: 39d55321bd0b8ce436d6fcd8e5ba51b8bf535559 URL: https://github.com/llvm/llvm-project/commit/39d55321bd0b8ce436d6fcd8e5ba51b8bf535559 DIFF: https://github.com/llvm/llvm-project/commit/39d55321bd0b8ce436d6fcd8e5ba51b8bf535559.diff

[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

https://github.com/mtvec approved this pull request. https://github.com/llvm/llvm-project/pull/68216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Fix resolution of weak symbols during LTO (PR #68215)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68215 >From f2e29b6136d245e0712bfb87de1f4253d12dd6f5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 07:34:01 -0500 Subject: [PATCH] [LinkerWrapper] Fix resolution of weak symbols during LTO Summary:

[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/68216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a1e81d2 - [HIP] Support compressing device binary (#67162)

Author: Yaxun (Sam) Liu Date: 2023-10-04T09:32:56-04:00 New Revision: a1e81d2ead02e041471ec2299d7382f80c4dbba6 URL: https://github.com/llvm/llvm-project/commit/a1e81d2ead02e041471ec2299d7382f80c4dbba6 DIFF: https://github.com/llvm/llvm-project/commit/a1e81d2ead02e041471ec2299d7382f80c4dbba6.dif

[clang] [HIP] Support compressing device binary (PR #67162)

https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/67162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca003ee - [clang-repl] Disable InterpreterExceptionTest on RISC-V (#68216)

Author: Alex Bradbury Date: 2023-10-04T14:33:31+01:00 New Revision: ca003ee06d0eac7e8facc179181298a05e4d03ed URL: https://github.com/llvm/llvm-project/commit/ca003ee06d0eac7e8facc179181298a05e4d03ed DIFF: https://github.com/llvm/llvm-project/commit/ca003ee06d0eac7e8facc179181298a05e4d03ed.diff

[clang] [clang-repl] Disable InterpreterExceptionTest on RISC-V (PR #68216)

https://github.com/asb closed https://github.com/llvm/llvm-project/pull/68216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM We should give this a try, but I think there is a fairly large chance that this will cause regressions somewhere and a more targeted change may be necessary (e.g. only do this for loop-inv

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

yxsamliu wrote: ping https://github.com/llvm/llvm-project/pull/67721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3701 + QualType PointeeType = E->getType()->getPointeeType(); + if (PointeeType.isNull()) +return false; eddyz87 wrote: > erichkeane wrote: > > We override `operator bool` to make th

[clang] AddDefaultRTL (PR #68220)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/68220 - [LinkerWrapper] Fix resolution of weak symbols during LTO - [Libomptarget] Make the DeviceRTL configuration globals weak >From f2e29b6136d245e0712bfb87de1f4253d12dd6f5 Mon Sep 17 00:00:00 2001 From: Joseph Hub

[clang] AddDefaultRTL (PR #68220)

llvmbot wrote: @llvm/pr-subscribers-clang Changes - [LinkerWrapper] Fix resolution of weak symbols during LTO - [Libomptarget] Make the DeviceRTL configuration globals weak --- Full diff: https://github.com/llvm/llvm-project/pull/68220.diff 4 Files Affected: - (modified) clang/tools/cl

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

eddyz87 marked 3 inline comments as done. eddyz87 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3701 + QualType PointeeType = E->getType()->getPointeeType(); + if (PointeeType.isNull()) +return false; erichkeane wrote: > eddyz87 wrote: > >

[PATCH] D157331: [clang] Implement C23

aaron.ballman added a comment. Precommit CI is still finding some issues that boil down to: # .---command stderr # | C:\ws\src\clang\test\Modules/Inputs/System/usr/include\module.map:19:12: error: header 'stdckdint.h' not found # |19 | header "stdckdint.h" # | |

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor naming nit. I think finding a way to unify with `SkipUntil` would be good follow-up work, though. Comment at: clang/lib/Lex/Preprocesso

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Pointer.h:81-88 + /// Equality operators are just for tests. + bool operator==(const Pointer &P) const { +return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset; + } + + bool operator!=(con

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I suspect this may have to change for `constexpr` support in C23, but we can burn that bridge when we get to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] [clang][Index] Use canonical function parameter types in USRs (PR #68222)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/68222 This is necessary to ensure that functions declared in different translation units whose parameter types only differ in top-level cv-qualification generate the same USR. For example: ```cpp // A.cpp void f(

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

HoBoIs wrote: @erichkeane @shafik I don't have write access. Could you merge if there is nothing to be done? https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter, Location loc, return rewriter.create(loc, rewriter.getI32Type(), value); } +/// Returns warp-size as a value. +static Value getWarpSizeValue(ImplicitLocOpBuilder &b) { qcolombet

[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

@@ -727,4 +727,24 @@ def NVGPU_WarpgroupMmaOp : NVGPU_Op<"warpgroup.mma"> { let hasVerifier = 1; } +def NVGPU_WarpgroupMmaStoreOp : NVGPU_Op<"warpgroup.mma.store"> { + let description = [{ +The `nvgpu.warpgroup.mma.store` op performs the store of fragmented result +

[clang-tools-extra] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

https://github.com/qcolombet edited https://github.com/llvm/llvm-project/pull/65441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter, Location loc, return rewriter.create(loc, rewriter.getI32Type(), value); } +/// Returns warp-size as a value. +static Value getWarpSizeValue(ImplicitLocOpBuilder &b) { qcolombet

  1   2   3   4   >