[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -390,6 +390,11 @@ Bug Fixes to C++ Support we now produce a diagnostic. Fixes: (`#65522 `_) +- Fixed a bug where clang incorrectly considered implicitly generated deduction + guides from a non-templated constructor and

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/erichkeane approved this pull request. Just need a period after the note, otherwise LGTM! https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [HIP] Document func ptr and virtual func (PR #68126)

https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/68126 Document clang support for function pointers and virtual functions with HIP >From 659831a00a74a05dfd2d77c98544e02fee88e7bd Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Tue, 3 Oct 2023 12:21:10 -0400 S

[clang] 0701ee6 - [HIP][Clang][Driver] Disable `hipstdpar` driver test on Mac & Windows, since `hipstdpar` is Linux only at the moment.

Author: Alex Voicu Date: 2023-10-03T17:26:15+01:00 New Revision: 0701ee69f7ac82b49a9709e610227ebf387f1d30 URL: https://github.com/llvm/llvm-project/commit/0701ee69f7ac82b49a9709e610227ebf387f1d30 DIFF: https://github.com/llvm/llvm-project/commit/0701ee69f7ac82b49a9709e610227ebf387f1d30.diff LO

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/3] Choose the correct deduction guide If there are two guides, one of th

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Document func ptr and virtual func (PR #68126)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Document clang support for function pointers and virtual functions with HIP --- Full diff: https://github.com/llvm/llvm-project/pull/68126.diff 1 Files Affected: - (modified) clang/docs/HIPSupport.rst (+67) ``diff diff --git a

[clang] [clang] Document -Wglobal-constructors behavior (PR #68084)

https://github.com/cor3ntin approved this pull request. More documentation is always nice, thanks! https://github.com/llvm/llvm-project/pull/68084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] Fixes and closes #53952 (PR #68127)

https://github.com/rajkumarananthu created https://github.com/llvm/llvm-project/pull/68127 The issue #53952 is reported indicating clang is giving a crashing pch file, when hasErrors is been passed incorrectly to WriteAST method. To fix the issue, I have a added an assertion to make sure the g

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. https://reviews.llvm.org/rG0701ee69f7ac should fix it, once again apologies for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___

[clang] Fixes and closes #53952 (PR #68127)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes The issue #53952 is reported indicating clang is giving a crashing pch file, when hasErrors is been passed incorrectly to WriteAST method. To fix the issue, I have a added an assertion to make sure the given value of ASTHasCompile

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

https://github.com/rajkumarananthu edited https://github.com/llvm/llvm-project/pull/68127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: > > That said, isBeforeInTranslationUnit is slow already, and I don't think > > it's hot in clang, moreso in tools like clang-tidy whose performance is > > less-critical. So let's make it right, and then optimize it again if > > problems arise. > > It may not be a hot func

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

DanielCChen added a comment. Sorry about the breakage and thanks to @DavidSpickett for revert it. We will reconsider all the input and bring it back as a PR in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.l

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: @AaronBallman you have a preference as to which PR we pursue? https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0701ee69f7ac82b49a9709e610227ebf387f1d30 b76f4d351b3e55e2095e3be088a50fdb76d6b7f9 --

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

https://github.com/cor3ntin approved this pull request. LGTM, thanks! (Feel free to squash-merge yourself) https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

cor3ntin wrote: @cjdb wanna look at this one? https://github.com/llvm/llvm-project/pull/66005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Document func ptr and virtual func (PR #68126)

@@ -176,3 +176,70 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +Function Pointers Support in Clang with HIP +=== + +Function pointers' support va

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of th

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/67964 >From 79ab61e07a01e503f22e717c4b0e64b7741c59a0 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 2 Oct 2023 11:06:44 +0100 Subject: [PATCH 1/4] [RISCV] Update Zfa extension version to 1.0 The Zfa specification

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/68113 >From 79ab61e07a01e503f22e717c4b0e64b7741c59a0 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 2 Oct 2023 11:06:44 +0100 Subject: [PATCH 1/6] [RISCV] Update Zfa extension version to 1.0 The Zfa specification

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/asb edited https://github.com/llvm/llvm-project/pull/68113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

asb wrote: > Please update the header comment at the top of RISCVInstrInfoZfa.td Thanks, split that change between #67964 and this one. https://github.com/llvm/llvm-project/pull/68113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18c3c46 - [RISCV] Update Zfa extension version to 1.0 (#67964)

Author: Alex Bradbury Date: 2023-10-03T17:54:29+01:00 New Revision: 18c3c46858c3a40f60f0f7cd74eff5e282c8813b URL: https://github.com/llvm/llvm-project/commit/18c3c46858c3a40f60f0f7cd74eff5e282c8813b DIFF: https://github.com/llvm/llvm-project/commit/18c3c46858c3a40f60f0f7cd74eff5e282c8813b.diff

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb closed https://github.com/llvm/llvm-project/pull/67964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. In D154869#4652703 , @DanielCChen wrote: > Sorry about the breakage This is why we have CI ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.ll

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/68113 >From 54783e0af749e95be28c47604e411236cca0efcc Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Tue, 3 Oct 2023 15:46:28 +0100 Subject: [PATCH 1/2] [RISCV] Mark the Zfa extension as non-experimental Following the v

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/AaronBallman approved this pull request. LGTM aside from a grammar nit https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

@@ -1621,6 +1621,10 @@ QualType CallExpr::getCallReturnType(const ASTContext &Ctx) const { // This should never be overloaded and so should never return null. CalleeType = Expr::findBoundMemberType(Callee); assert(!CalleeType.isNull()); + } else if (CalleeType->is

[clang] 6d209bd - [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (#67751)

Author: Matheus Izvekov Date: 2023-10-03T19:00:10+02:00 New Revision: 6d209bd436292f77705c2890ed8965315e80f290 URL: https://github.com/llvm/llvm-project/commit/6d209bd436292f77705c2890ed8965315e80f290 DIFF: https://github.com/llvm/llvm-project/commit/6d209bd436292f77705c2890ed8965315e80f290.dif

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Document func ptr and virtual func (PR #68126)

@@ -176,3 +176,70 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +Function Pointers Support in Clang with HIP +=== + +Function pointers' support va

[clang] [HIP] Document func ptr and virtual func (PR #68126)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/68126 >From 9dd5da61a18ca642245c966125b2d4e26eed5b61 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Tue, 3 Oct 2023 12:21:10 -0400 Subject: [PATCH] [HIP] Document func ptr and virtual func Document clang supp

[PATCH] D156565: Diagnose use of VLAs in C++ by default

jyknight added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2617 + } else if (getLangOpts().CPlusPlus) { +if (getLangOpts().CPlusPlus11 && IsStaticAssertLike(ArraySize, Context)) + VLADiag = getLangOpts().GNUMode aaron.ballman wrote: > jykni

[clang] eae1e28 - [RISCV] Mark the Zfa extension as non-experimental (#68113)

Author: Alex Bradbury Date: 2023-10-03T18:16:13+01:00 New Revision: eae1e28cc2674c6a22dd0ee9d68d17df7ee9c225 URL: https://github.com/llvm/llvm-project/commit/eae1e28cc2674c6a22dd0ee9d68d17df7ee9c225 DIFF: https://github.com/llvm/llvm-project/commit/eae1e28cc2674c6a22dd0ee9d68d17df7ee9c225.diff

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/asb closed https://github.com/llvm/llvm-project/pull/68113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] `checkModuleIsAvailable` should use a const & parameter instead of pointer (PR #67902)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67902 >From 43d6a4e8e07ef3dba977e3e3c2adf05ac184ba85 Mon Sep 17 00:00:00 2001 From: David Stone Date: Sun, 1 Oct 2023 00:41:34 -0600 Subject: [PATCH] [clang][Modules] `checkModuleIsAvailable` should use a const & p

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 557565. ZijunZhao added a comment. Rebase to latest main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/include

[clang] [clang][Modules] Move `ASTSourceDescriptor` into its own file (PR #67930)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67930 >From 3cb09af262cf53cecb73e2da342a7891bc9fe853 Mon Sep 17 00:00:00 2001 From: David Stone Date: Sun, 1 Oct 2023 12:02:48 -0600 Subject: [PATCH] [clang][Modules] Move `ASTSourceDescriptor` into its own file --

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

@@ -331,6 +340,56 @@ static void SetInstallDir(SmallVectorImpl &argv, // path being a symlink. SmallString<128> InstalledPath(argv[0]); +#if defined(__linux__) ilg-ul wrote: > Can we use `getMainExecutable()` instead? Good point! > So is the problem h

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

kstoimenov wrote: Could you please send me a link which describes that process? I assume that by MR you mean merge request? Thanks, Kirill On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: > @kstoimenov I believe you are supposed to > notify the

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/68078 >From a14d189cfd513d4b2c8353fbab1a53927d2feaf5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 3 Oct 2023 09:55:08 +0200 Subject: [PATCH 1/3] [Clang] Do not try to classify dependant call expression wh

[clang] 9c1c221 - [Clang] Correctly handle callees whose type is a Record type when classifying expressions (#68078)

Author: cor3ntin Date: 2023-10-03T19:38:45+02:00 New Revision: 9c1c2211693cd14b23c3899e95af1ba3129ab5db URL: https://github.com/llvm/llvm-project/commit/9c1c2211693cd14b23c3899e95af1ba3129ab5db DIFF: https://github.com/llvm/llvm-project/commit/9c1c2211693cd14b23c3899e95af1ba3129ab5db.diff LOG:

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67201 >From 337df13c04d7ac289de3d77f9e29f20693e206e9 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 6 Sep 2023 11:41:56 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Add cross-compilation fl

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

https://github.com/michaelrj-google created https://github.com/llvm/llvm-project/pull/68134 The name of the namespace for LLVM's libc is now provided by a macro. The ImplementationNamespaceCheck was updated to handle this, but the CalleeNamespaceCheck was missed. This patch updates the CalleeNam

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes The name of the namespace for LLVM's libc is now provided by a macro. The ImplementationNamespaceCheck was updated to handle this, but the CalleeNamespaceCheck was missed. This patch updates the CalleeNamespaceCheck to handle the macro.

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: > Could you please send me a link which describes that process? I assume that > by MR you mean merge request? Thanks, Kirill > […](#) > On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: > @kstoimenov I believe you are supposed to

[clang-tools-extra] [RISCV][GISel] Select G_SELECT (PR #67614)

https://github.com/nitinjohnraj updated https://github.com/llvm/llvm-project/pull/67614 >From 72ba591ed3cc3ab1b6321eaa215ef47a67803dac Mon Sep 17 00:00:00 2001 From: Nitin John Raj Date: Wed, 27 Sep 2023 15:13:26 -0700 Subject: [PATCH] [RISCV][GISel] Select G_SELECT --- .../RISCV/GISel/RISCVI

[clang] [RISCV][GISel] Select G_SELECT (PR #67614)

https://github.com/nitinjohnraj updated https://github.com/llvm/llvm-project/pull/67614 >From 72ba591ed3cc3ab1b6321eaa215ef47a67803dac Mon Sep 17 00:00:00 2001 From: Nitin John Raj Date: Wed, 27 Sep 2023 15:13:26 -0700 Subject: [PATCH] [RISCV][GISel] Select G_SELECT --- .../RISCV/GISel/RISCVI

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. Hi @AlexVlx, the test you added is failing on an linux bot, can you take a look and revert if you need time to investigate? It appears it has been failing for over 6 hours. https://lab.llvm.org/buildbot/#/builders/139/builds/50940 Repository: rG LLVM Github Monorepo

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` for `FileID` creation (PR #67838)

@@ -527,17 +527,6 @@ FileID SourceManager::getNextFileID(FileID FID) const { /// Create a new FileID that represents the specified file /// being \#included from the specified IncludePosition. -/// -/// This translates NULL into standard input. -FileID SourceManager::createFil

[clang] [HIP] Document func ptr and virtual func (PR #68126)

https://github.com/b-sumner commented: This looks fine to me. https://github.com/llvm/llvm-project/pull/68126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68136 >From 57ec61b03b4c54164f40be996b1d57420f2d4a2c Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Tue, 3 Oct 2023 19:31:03 +0200 Subject: [PATCH] [mlir][llvm] Fix elem type passing into `getelementptr` --- mli

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` for `FileID` creation (PR #67838)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67838 >From 87a590f89f346113fce04ad6e75908a896b3894b Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 12 Sep 2023 15:02:23 -0700 Subject: [PATCH 1/2] [clang] NFCI: Use `FileEntryRef` for `FileID` creation in

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. In D155775#4652698 , @AlexVlx wrote: > https://reviews.llvm.org/rG0701ee69f7ac should fix it, once again apologies > for the noise. FYI, the test is still failing on the Windows PS5 bot after your change: https://lab.llvm.org/bui

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155775#4652767 , @dyung wrote: > Hi @AlexVlx, the test you added is failing on an linux bot, can you take a > look and revert if you need time to investigate? It appears it has been > failing for over 6 hours. > > https://la

[clang] [AArch64][FMV] Add rcpc3 support, introduce bits for features extensi… (PR #68104)

https://github.com/DanielKristofKiss approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: Use `FileEntryRef` for `FileID` creation (PR #67838)

jansvoboda11 wrote: Thanks for the feedback. I used `llvm::cantFail(FM.getFileRef(Name))` in some places to fail more gracefully. The error-reporting changes you suggest I'd like to put into a follow-up patch, to keep this one as NFC as possible. WDYT? https://github.com/llvm/llvm-project/pull

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik updated this revision to Diff 557569. shafik added a comment. - Integrate fix from https://github.com/llvm/llvm-project/pull/67373 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/Sem

[clang] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

shraiysh wrote: > Will the wrapper function stay or be removed? I would like to get it removed, because that is unnecessary (I did not realize this earlier while submitting the patch). But because nobody is actively reviewing #67723, I do not want to delay progress for the construct. So, I wil

[libunwind] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68042 >From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Mon, 2 Oct 2023 16:43:13 -0500 Subject: [PATCH 1/2] [mlir][OpenMP] Added translation for `omp.teams` to LLVM

[clang] 3cbdd9f - [HIP][Clang][Driver] Disable `hipstdpar` driver test on Hexagon & PS5, since `hipstdpar` is not going to be available on either of them.

Author: Alex Voicu Date: 2023-10-03T19:06:56+01:00 New Revision: 3cbdd9f1e3b40761e5d5db428d66e71591444f18 URL: https://github.com/llvm/llvm-project/commit/3cbdd9f1e3b40761e5d5db428d66e71591444f18 DIFF: https://github.com/llvm/llvm-project/commit/3cbdd9f1e3b40761e5d5db428d66e71591444f18.diff LO

[clang] f659ef4 - [AST] Fix a warning

Author: Kazu Hirata Date: 2023-10-03T11:08:24-07:00 New Revision: f659ef43cd4e72fe84a1fa50966ac78ca6675428 URL: https://github.com/llvm/llvm-project/commit/f659ef43cd4e72fe84a1fa50966ac78ca6675428 DIFF: https://github.com/llvm/llvm-project/commit/f659ef43cd4e72fe84a1fa50966ac78ca6675428.diff L

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

zero9178 wrote: What are the use cases for allowing either of these two syntaxes? The LLVM Dialect tries to closely mirror LLVM proper as much as possible and this would deviate from LLVMs behaviour. While the transition is currently stalled, in the future typed pointers will be removed from th

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 557571. NoumanAmir657 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/docs/Release

[clang] [clang][ExprConst] Don't try to evaluate value-dependent DeclRefExprs (PR #67778)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67778 >From 1b6fcc49f5ef9b99b4b2f7019de6d8d24a03f232 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Oct 2023 08:35:57 +0200 Subject: [PATCH

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. In D155775#4652773 , @AlexVlx wrote: > In D155775#4652767 , @dyung wrote: > >> Hi @AlexVlx, the test you added is failing on an linux bot, can you take a >> look and revert if you need time

[clang] [analyzer] Fix core.VLASize checker false positive taint reports (PR #68140)

https://github.com/dkrupp created https://github.com/llvm/llvm-project/pull/68140 The checker reported a false positive on this code void testTaintedSanitizedVLASize(void) { int x; scanf("%d", &x); if (x<1) return; int vla[x]; // no-warning } After the fix, the checker only emits

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

goldsteinn wrote: > It looks like x86-bswap.c still has the C++ guarded code in it. > > Any thoughts on > > > Though I think we might be better off passing `-no-enable-noundef-analysis` > > to these tests, as noundef is really not what they want to test. > > to avoid the test duplication? Th

[clang] [analyzer] Fix core.VLASize checker false positive taint reports (PR #68140)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The checker reported a false positive on this code void testTaintedSanitizedVLASize(void) { int x; scanf("%d", &x); if (x<1) return; int vla[x]; // no-warning } After the fix, the checker only emits tainted warning if the vla

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

rampitec wrote: > > I've just tested this on 1 graphics shaders and it seems to make no > > difference at all. I tried gfx900 and gfx1100. Can anyone else from the > > graphics team confirm this? > > I can confirm no difference on gfx1102 gfx11 is the same as gfx10, it just bails because

[libunwind] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68042 >From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Mon, 2 Oct 2023 16:43:13 -0500 Subject: [PATCH 1/3] [mlir][OpenMP] Added translation for `omp.teams` to LLVM

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` for `FileID` creation (PR #67838)

https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/67838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/68011 >From bde5fc6394df80e598835f01d2ab8c0c186a9d5b Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Tue, 25 Jul 2023 18:46:50 -0600 Subject: [PATCH] [Driver] Silence stdlib warning when linking C Similar to the Gnu to

[clang] e791e9f - Add a release note for https://github.com/llvm/llvm-project/pull/68001 (#68061)

Author: Akira Hatanaka Date: 2023-10-03T11:25:31-07:00 New Revision: e791e9faa7af4f002ae7b61a4c4b38803d23159a URL: https://github.com/llvm/llvm-project/commit/e791e9faa7af4f002ae7b61a4c4b38803d23159a DIFF: https://github.com/llvm/llvm-project/commit/e791e9faa7af4f002ae7b61a4c4b38803d23159a.diff

[clang] Add a release note for https://github.com/llvm/llvm-project/pull/68001 (PR #68061)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/68061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155775#4652780 , @dyung wrote: > In D155775#4652773 , @AlexVlx wrote: > >> In D155775#4652767 , @dyung wrote: >> >>> Hi @AlexVlx, the test you

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

mstorsjo wrote: FWIW, I'd be quite wary about modifying the logic here (whatever it is - I haven't checked closely); if we used to resolve to one point of a symlink before, and now resolve to the other end, I can almost guarantee you that there are dozens of existing users that rely on the cur

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: AaronBallman wrote: > Of course it's more expensive, I was just trying

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

ilg-ul wrote: > I haven't checked closely Hi Martin, please check the #66704 bug report, the current behaviour is plainly wrong, clang does not pick the correct libraries and silently uses the system libraries, which leads to very subtle and hard to debug errors if the new version is several

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. The only thing left are the comments on the release note, but I can fix that up when landing if you need me to commit on your behalf. If so, what name and email address would you like me to use for patch attribution? Otherwise, if you have commit privileges, then

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4652792 , @aaron.ballman wrote: > The only thing left are the comments on the release note, but I can fix that > up when landing if you need me to commit on your behalf. If so, what name and > email address wou

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman marked an inline comment as not done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2617 + } else if (getLangOpts().CPlusPlus) { +if (getLangOpts().CPlusPlus11 && IsStaticAssertLike(ArraySize, Context)) + VLADiag = getLangOpt

[clang] [mlir][sparse] Print new syntax (PR #68130)

https://github.com/yinying-lisa-li updated https://github.com/llvm/llvm-project/pull/68130 >From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001 From: Yinying Li Date: Tue, 3 Oct 2023 16:43:50 + Subject: [PATCH 1/2] [mlir][sparse] Print new syntax Printing changes from #s

[clang] af16a4e - Improve error message for constexpr constructors of virtual base classes

Author: Nouman Amir Date: 2023-10-03T15:06:08-04:00 New Revision: af16a4e131c1383c1b023f9384f0d73a3d207a2f URL: https://github.com/llvm/llvm-project/commit/af16a4e131c1383c1b023f9384f0d73a3d207a2f DIFF: https://github.com/llvm/llvm-project/commit/af16a4e131c1383c1b023f9384f0d73a3d207a2f.diff L

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf16a4e131c1: Improve error message for constexpr constructors of virtual base classes (authored by NoumanAmir657, committed by aaron.ballman). Cha

[clang] [mlir][sparse] Print new syntax (PR #68130)

https://github.com/yinying-lisa-li edited https://github.com/llvm/llvm-project/pull/68130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

goldsteinn wrote: > Since the langref definition is based on GEP, can we use index width instead > of pointer width? If you disagree with this, it would still be good if you > could add a test where the datalayout has index width < pointer width to show > the current semantics. I think thats

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

vitalybuka wrote: There is automatic github notification about revert, I assume something in the email as well.  What is the value of another message? https://github.com/llvm/llvm-project/pull/67

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

efriedma-quic wrote: I didn't get an an email notification for that. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

@@ -3447,9 +3447,13 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok = Tok->Next) { if (Tok->Previous->EndsCppAttributeGroup) AfterLastAttribute = Tok; -if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

@@ -16339,7 +16345,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { verifyFormat("int f();", SpaceFuncDef); verifyFormat("void f (int a, T b) {}", SpaceFuncDef); - verifyFormat("A::A () : a(1) {}", SpaceFuncDef); + verifyFormat("A::A() : a(1) {}", SpaceFuncDef);

[clang] [clang-format] Annotate ctors/dtors as CtorDtorDeclName instead (PR #67955)

@@ -3447,9 +3447,13 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok = Tok->Next) { if (Tok->Previous->EndsCppAttributeGroup) AfterLastAttribute = Tok; -if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >