[clang] [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (PR #67911)

https://github.com/tru closed https://github.com/llvm/llvm-project/pull/67911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 75441a6 - [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (#67911)

Author: Owen Pan Date: 2023-10-02T09:15:49+02:00 New Revision: 75441a684273268ce91036aa2c770e669d39f501 URL: https://github.com/llvm/llvm-project/commit/75441a684273268ce91036aa2c770e669d39f501 DIFF: https://github.com/llvm/llvm-project/commit/75441a684273268ce91036aa2c770e669d39f501.diff LOG:

[clang] [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (PR #67911)

tru wrote: oh sorry for merging this @owenca - it was tagged for the 17.x release and I thought it was a PR towards the backport branch so ti wasn't my intention to merge it into main for you. https://github.com/llvm/llvm-project/pull/67911 ___ cfe-

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

https://github.com/philnik777 approved this pull request. LGTM from the libc++ side of things. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang-format] Fix a bug in RemoveParentheses: ReturnStatement (PR #67911)

owenca wrote: @tru np! That was my intention anyways. https://github.com/llvm/llvm-project/pull/67911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c83d64f - [clang-format] Fix a bug in mis-annotating arrows (#67780)

Author: Owen Pan Date: 2023-10-02T00:38:26-07:00 New Revision: c83d64f17a6e38f39fde611f06479e6f2a62b70f URL: https://github.com/llvm/llvm-project/commit/c83d64f17a6e38f39fde611f06479e6f2a62b70f DIFF: https://github.com/llvm/llvm-project/commit/c83d64f17a6e38f39fde611f06479e6f2a62b70f.diff LOG:

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8245ca9 - [clang][Interp] Don't disable int128 tests everywhere.

Author: Timm Bäder Date: 2023-10-02T09:55:35+02:00 New Revision: 8245ca994bc524ef7a047526c128dbe0cb14d104 URL: https://github.com/llvm/llvm-project/commit/8245ca994bc524ef7a047526c128dbe0cb14d104 DIFF: https://github.com/llvm/llvm-project/commit/8245ca994bc524ef7a047526c128dbe0cb14d104.diff LO

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5317912 - [clang] Add missing canonicalization in int literal profile (#67822)

Author: Henrik G. Olsson Date: 2023-10-02T10:03:32+02:00 New Revision: 53179129edbff13644b7c46336773fb8740899c9 URL: https://github.com/llvm/llvm-project/commit/53179129edbff13644b7c46336773fb8740899c9 DIFF: https://github.com/llvm/llvm-project/commit/53179129edbff13644b7c46336773fb8740899c9.di

[clang] [clang] Add missing canonicalization in int literal profile (PR #67822)

https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/67822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge updated this revision to Diff 557525. nridge added a comment. Rebased to apply to recent trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

kasuga-fj wrote: Thanks! (The upstream build process seems to be broken now, so I'll wait until it's fixed) https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

mstorsjo wrote: > Did you plan to backport this as well @mstorsjo ? Yes, I did - in #64464, with https://github.com/llvm/llvm-project-release-prs/pull/716 (where tests failed after cherrypicking; looking into that test issue right now). https://github.com/llvm/llvm-project/pull/67891

[clang] [clang][Interp] Implement IntegralAP::comp (PR #67954)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67954 >From 80bd890c332654458014c4acc20709b9cbb6eb90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 1 Oct 2023 19:57:03 +0200 Subject: [PATCH] [clang][Interp] Implement IntegralAP::comp ---

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

tru wrote: Yeah i noticed when I got further down in my notification stack :) https://github.com/llvm/llvm-project/pull/67891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/67663 From 9f7f577c95d7e9fb7e2f929215ff217ca2d7ed53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Fri, 8 Sep 2023 14:20:00 +0200 Subject: [PATCH 1/8] [analyzer][clangsa] Add new option to

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/ktf created https://github.com/llvm/llvm-project/pull/67960 The BitVector is currently used to keep track of which entries of LoadedSLocEntryTable have been loaded. Such information can be stored in the SLocEntry itself. Moreover, thanks to the fact that LoadedSLocEntryTable

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The BitVector is currently used to keep track of which entries of LoadedSLocEntryTable have been loaded. Such information can be stored in the SLocEntry itself. Moreover, thanks to the fact that LoadedSLocEntryTable is now a PagedVector,

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

ktf wrote: @vgvassilev IIUC, this is what you were proposing in some comment in https://github.com/llvm/llvm-project/pull/66430. https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/67961 Before this patch, we would run into an assertion in `APInt::get{S,Z}ExtValue()` because the `AllOnes` value had more than 64 active bits. >From 80bd890c33265

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Changes Before this patch, we would run into an assertion in `APInt::get{S,Z}ExtValue()` because the `AllOnes` value had more than 64 active bits. --- Full diff: https://github.com/llvm/llvm-proj

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

DavidSpickett added a comment. I've reverted this https://github.com/llvm/llvm-project/commit/ffc67bb3602a6a9a4f886af362e1f2d7c9821570 as Linaro's flang and clang bots are red all over and we're also in an upgrade period for the build server (https://discourse.llvm.org/t/llvm-zorg-migration-to

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67961 >From 80bd890c332654458014c4acc20709b9cbb6eb90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 1 Oct 2023 19:57:03 +0200 Subject: [PATCH

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov added a comment. @nikic Updated. Please review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/tblah approved this pull request. https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG472 (PR #67948)

cor3ntin wrote: CC @zygoloid In the proposed resolution, i do not understand why `B* bp = n2p;` should be ill-formed by virtue of being declared in `P2` https://github.com/llvm/llvm-project/pull/67948 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang][Interp] Implement compound assign operators on bitfields (PR #67306)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][Interp] Diagnose uninitialized bases (PR #67131)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list

[clang] [clang][Modules] `checkModuleIsAvailable` should use a const & parameter instead of pointer (PR #67902)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/67902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove duplicate ModuleId alias (PR #67899)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/67899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang]Add vscale argument parsing (PR #67676)

@@ -0,0 +1,55 @@ +! - +! Tests for the -msve-vector-bits flag (taken from the clang test) +! - + +! RUN: %flang -c %s -### --targ

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb created https://github.com/llvm/llvm-project/pull/67964 The Zfa specification was recently ratified . This commit bumps the version to 1.0, but leaves it as an experimental extension (to be done in a follow

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The Zfa specification was recently ratified ;. This commit bumps the version to 1.0, but leaves it as an experimental extension (to be done in a follow-on patch), so reviews

[clang] [clang] Add test for CWG1341 (PR #67965)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/67965 https://cplusplus.github.io/CWG/issues/1341.html https://wg21.link/p0683r1 >From 92fec6fe49de0392596e7f7d4a1c5524dd436747 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 2 Oct 2023 13:17:40 +0300 Su

[clang] [clang] Add test for CWG1341 (PR #67965)

llvmbot wrote: @llvm/pr-subscribers-clang Changes https://cplusplus.github.io/CWG/issues/1341.html https://wg21.link/p0683r1 --- Full diff: https://github.com/llvm/llvm-project/pull/67965.diff 2 Files Affected: - (modified) clang/test/CXX/drs/dr13xx.cpp (+17) - (modified) clang/www/cxx

[clang] [clang] Add test for CWG2267 (PR #67931)

https://github.com/Endilll unassigned https://github.com/llvm/llvm-project/pull/67931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: @rnk Since @efriedma-quic seems to be unavailable, any objections we move forward and merge this, as is? https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

https://github.com/grypp updated https://github.com/llvm/llvm-project/pull/65441 >From 7b71da55fca8fe2a7dbe4982b1959be6a6175fa1 Mon Sep 17 00:00:00 2001 From: Guray Ozen Date: Thu, 7 Sep 2023 11:52:38 +0200 Subject: [PATCH 1/6] [MLIR][NVGPU] Introduce `nvgpu.warpgroup.mma.store` Op for Hopper G

[clang] 3f09273 - [C++20] [Modules] Fix crash when emitting module inits for duplicated modules

Author: Chuanqi Xu Date: 2023-10-02T18:31:54+08:00 New Revision: 3f0927368285505ead516ba7572baaa7f52b01a9 URL: https://github.com/llvm/llvm-project/commit/3f0927368285505ead516ba7572baaa7f52b01a9 DIFF: https://github.com/llvm/llvm-project/commit/3f0927368285505ead516ba7572baaa7f52b01a9.diff LO

[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7bc09a471fbc274d8632d1379d4134bec63fecc4 2cc84d3d83320fc31a2434055939a4ed6569c077 --

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6230 BindKind = BC->getBindKind(); + // First check CancelRegion which is then used in checkNestingOfRegions. Remove this new line Comment at: clang/lib/Sema/SemaO

[clang] 3b25407 - [IR] Mark zext/sext constant expressions as undesirable

Author: Nikita Popov Date: 2023-10-02T12:40:20+02:00 New Revision: 3b25407d977d9ed3dbcaccd4f8850b65e95d70fd URL: https://github.com/llvm/llvm-project/commit/3b25407d977d9ed3dbcaccd4f8850b65e95d70fd DIFF: https://github.com/llvm/llvm-project/commit/3b25407d977d9ed3dbcaccd4f8850b65e95d70fd.diff

[clang] Introduce paged vector (PR #66430)

vgvassilev wrote: > > Looks like this causes a compile-time regression: > > https://llvm-compile-time-tracker.com/compare.php?from=abcaebfe3aacb13d46be5e949fd6ed9b4321e2f6&to=4ae51570806ba5c5fcabe6d6dcbe52e3a5d5453b&stat=instructions%3Au > > About 0.5% at `O0`. > > It is probably the change in

[clang] [clang][ASTImporter] Fix of possible crash "Did not find base!". (PR #67680)

https://github.com/DonatNagyE approved this pull request. Looks reasonable, thanks! https://github.com/llvm/llvm-project/pull/67680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix of possible crash "Did not find base!". (PR #67680)

https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/67680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 11e68c7 - [flang]Add vscale argument parsing (#67676)

Author: Mats Petersson Date: 2023-10-02T12:01:12+01:00 New Revision: 11e68c7e7ffb430f17a02c5ca28f6884b5de563a URL: https://github.com/llvm/llvm-project/commit/11e68c7e7ffb430f17a02c5ca28f6884b5de563a DIFF: https://github.com/llvm/llvm-project/commit/11e68c7e7ffb430f17a02c5ca28f6884b5de563a.diff

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/Leporacanthicus closed https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add check for duplicates to make_cxx_dr_status script (PR #67969)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/67969 While working on #67965, I stumbled upon the fact that `make_cxx_dr_status` script doesn't check for duplicated comment (last comment wins), so I added this check. It even found another instance of duplicated c

[clang] [clang] Add check for duplicates to make_cxx_dr_status script (PR #67969)

llvmbot wrote: @llvm/pr-subscribers-clang Changes While working on #67965, I stumbled upon the fact that `make_cxx_dr_status` script doesn't check for duplicated comment (last comment wins), so I added this check. It even found another instance of duplicated comment: CWG1223 was marked a

[clang] Introduce paged vector (PR #66430)

ktf wrote: > @ktf could you take a look at this? Sure, I did https://github.com/llvm/llvm-project/pull/67972 with your suggestion, however I am not sure how I can run the benchmark myself. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commi

[clang] [clang] Add check for duplicates to make_cxx_dr_status script (PR #67969)

@@ -7145,7 +7145,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/1223.html";>1223 drafting Syntactic disambiguation and trailing-return-types -Not resolved +Clang 17 Endilll wrote: `make_cxx_dr_status` i

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Accepting as-is; we'll keep our eyes peeled for any post-commit feedback. Thank you for all the hard work on this one, it was a big, involved patch! Repository: rG LLVM Github

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

vabridgers wrote: Hey guys, is it ok to merge this fix? Thanks https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][NVGPU] Introduce `nvgpu.wargroup.mma.store` Op for Hopper GPUs (PR #65441)

https://github.com/grypp updated https://github.com/llvm/llvm-project/pull/65441 >From 7b71da55fca8fe2a7dbe4982b1959be6a6175fa1 Mon Sep 17 00:00:00 2001 From: Guray Ozen Date: Thu, 7 Sep 2023 11:52:38 +0200 Subject: [PATCH 1/7] [MLIR][NVGPU] Introduce `nvgpu.warpgroup.mma.store` Op for Hopper G

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/DonatNagyE approved this pull request. It's simple and clean, let's just merge it :) https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] Introduce paged vector (PR #66430)

ktf wrote: I also noticed that LoadedSLocEntryTable uses 42 elements tables, which probably introduces some extra divisions to do the indexing. I can try switching to 32 elements. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailin

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/AaronBallman commented: Please be sure to add a release note about the fix, too! https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

@@ -0,0 +1,10 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=optin.portability.UnixAPI \ +// RUN:-triple x86_64-pc-linux-gnu -x c %s + +// Don't crash! +// expected-no-diagnostics +const __int128_t a = ( (__int128_t)1 << 64 ); AaronBallman wrote: It'd be go

[clang] [analyzer] Remove inaccurate legacy handling of bad bitwise shifts (PR #66647)

DonatNagyE wrote: This commit accidentally left behind two unused functions; thanks @kazutakahirata for quickly fixing my mistake! https://github.com/llvm/llvm-project/pull/66647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Introduce paged vector (PR #66430)

mikaelholmen wrote: Hi @vgvassilev ! Compiling this with gcc we see lots of warnings like ` ../include/llvm/ADT/PagedVector.h:213:59: warning: friend declaration 'bool llvm::operator==(const llvm::PagedVector::MaterializedIterator&, const llvm::PagedVector::MaterializedIterator&)' declares a n

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/67663 From 9f7f577c95d7e9fb7e2f929215ff217ca2d7ed53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Fri, 8 Sep 2023 14:20:00 +0200 Subject: [PATCH 1/7] [analyzer][clangsa] Add new option to

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -9354,13 +9353,14 @@ Sema::CheckDependentFunctionTemplateSpecialization(FunctionDecl *FD, } F.done(); + bool isFriend = FD->getFriendObjectKind() != Decl::FOK_None; AaronBallman wrote: ```suggestion bool IsFriend = FD->getFriendObjectKind() != Decl

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -1481,10 +1481,6 @@ enum DeclCode { /// template template parameter pack. DECL_EXPANDED_TEMPLATE_TEMPLATE_PARM_PACK, - /// A ClassScopeFunctionSpecializationDecl record a class scope - /// function specialization. (Microsoft extension). - DECL_CLASS_SCOPE_FUNCTION_SP

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

https://github.com/AaronBallman commented: The changes should definitely have a release note so that downstreams can be aware of the changes. This isn't really a potentially breaking change, but we should alert clang-vendors in case a downstream actually cares. https://github.com/llvm/llvm-pro

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -752,8 +745,6 @@ class CollectExtraHighlightings } if (auto *Args = D->getTemplateSpecializationArgsAsWritten()) H.addAngleBracketTokens(Args->getLAngleLoc(), Args->getRAngleLoc()); -if (auto *I = D->getDependentSpecializationInfo()) - H.addAngleBracke

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -2154,6 +2144,15 @@ bool RecursiveASTVisitor::TraverseFunctionHelper(FunctionDecl *D) { TALI->NumTemplateArgs)); } } +// FIXME: Do we want to traverse the explicit template arguments for AaronB

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -10442,32 +10441,54 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, if (getLangOpts().CUDA && !isFunctionTemplateSpecialization) maybeAddCUDAHostDeviceAttrs(NewFD, Previous); -// If it's a friend (and only if it's a friend), it's po

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

@@ -2399,13 +2399,34 @@ pointer. These functions include: getenv, localeconv, asctime, setlocale, strerr char *p, *pp; p = getenv("VAR"); -pp = getenv("VAR2"); -// subsequent call to 'getenv' invalidated previous one +setenv("SOMEVAR", "VALUE", /*overwrite

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

@@ -2399,13 +2399,34 @@ pointer. These functions include: getenv, localeconv, asctime, setlocale, strerr char *p, *pp; p = getenv("VAR"); -pp = getenv("VAR2"); -// subsequent call to 'getenv' invalidated previous one +setenv("SOMEVAR", "VALUE", /*overwrite

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

@@ -25,19 +25,36 @@ using namespace clang; using namespace ento; + namespace { + class InvalidPtrChecker : public Checker { private: - BugType BT{this, "Use of invalidated pointer", categories::MemoryError}; + static const BugType *InvalidPtrBugType; + // For accu

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

@@ -146,16 +188,15 @@ void InvalidPtrChecker::postPreviousReturnInvalidatingCall( // Remember to this region. const auto *SymRegOfRetVal = cast(RetVal.getAsRegion()); - const MemRegion *MR = - const_cast(SymRegOfRetVal->getBaseRegion()); + const MemRegion *MR = Sym

[PATCH] D156565: Diagnose use of VLAs in C++ by default

jyknight added a comment. Overall looks good, just a few nits from looking things over. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:143 +def ext_vla_cxx : ExtWarn< + "variable length arrays are a Clang extension">, InGroup; +def ext_vla_cxx_in_gnu_mode : Exten

[clang] Introduce paged vector (PR #66430)

ktf wrote: @mikaelholmen see also https://github.com/llvm/llvm-project/pull/67958. I can't seem to create a version that avoids triggering the warning and is also compatible across both macOS and Windows. Some good idea would be appreciated, especially because I do not have a windows setup and

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: nico wrote: Still broken: http://45.33.8.238/win/84419/step_4.txt https://github.com/llvm/llvm-project/pull/65844 __

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -752,8 +745,6 @@ class CollectExtraHighlightings } if (auto *Args = D->getTemplateSpecializationArgsAsWritten()) H.addAngleBracketTokens(Args->getLAngleLoc(), Args->getRAngleLoc()); -if (auto *I = D->getDependentSpecializationInfo()) - H.addAngleBracke

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

sdkrystian wrote: @AaronBallman > Can you be sure to file an issue or add a test case + FIXME comment so we > don't lose track of the needed follow-up work, or are you planning to do that > work immediately after this lands? I will address that once this gets merged https://github.com/llvm/l

[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

kuganv added a comment. ping? Any thoughts. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159497/new/ https://reviews.llvm.org/D159497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: antmox wrote: Hello, Looks like this also broke lldb-aarch64-windows bot: https://lab.llvm.org/buildbot/#/builders/219/builds/6012 ... https://la

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Sigh, will push a fix as soon as my local build is done. https://github.com/llvm/llvm-project/pull/65844

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

AaronBallman wrote: CC @llvm/clang-vendors for awareness of the AST changing to remove a node. https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [MLIR][Presburger] Fix reduction of Fractions and add tests (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Fix reduction of Fractions and add tests (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Fix reduction of Fractions and add tests (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Fix reduction of Fractions and add tests (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67981 Summary: The `algorithm` header included here sometimes caused issues when using `libc++` over `libstdc++`. This was primarily because of the order they were included in. This patch just gets rid of this dependen

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Summary: The `algorithm` header included here sometimes caused issues when using `libc++` over `libstdc++`. This was primarily because of the order they were included in. This patch just gets rid of this dependency as it was only used for m

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/67212 >From ccf65544918f48800799dea2993168a5a29e11ba Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 23 Sep 2023 01:26:14 +0200 Subject: [PATCH] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

@@ -0,0 +1,10 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=optin.portability.UnixAPI \ +// RUN:-triple x86_64-pc-linux-gnu -x c %s + +// Don't crash! +// expected-no-diagnostics +const __int128_t a = ( (__int128_t)1 << 64 ); vabridgers wrote: I added a te

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67981 >From 3ce25920eb83ed2e859050fd24dada7b232e0431 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 2 Oct 2023 07:25:03 -0500 Subject: [PATCH] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

vabridgers wrote: I'll wait for an ok from @AaronBallman before merging. Thank you! https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >