[clang] [clang][ExprConst] Don't create useless temporary variable (PR #67716)

zygoloid wrote: The semantics of `ArrayInitLoopExpr` are to first evaluate (once, up-front) the common expression, and then evaluate the subexpression once for each array element, where the subexpression can make repeated reference to the value of the common expression. With this change, we wi

[clang] 0ea3d88 - [Modules] Add a flag to control builtin headers being in system modules

Author: Ian Anderson Date: 2023-09-28T11:30:09-07:00 New Revision: 0ea3d88bdb16aa6e9a0043cc3ed93dcb88a89dea URL: https://github.com/llvm/llvm-project/commit/0ea3d88bdb16aa6e9a0043cc3ed93dcb88a89dea DIFF: https://github.com/llvm/llvm-project/commit/0ea3d88bdb16aa6e9a0043cc3ed93dcb88a89dea.diff

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ea3d88bdb16: [Modules] Add a flag to control builtin headers being in system modules (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15948

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zmodem wrote: We're seeing unit test crashes on Windows when building with rpmalloc (via `LLVM_INTEGRATED_CRT_ALLOC`). It's crashing here: https://github.com/google/googletest/blob/v1.14.0/googletest/include/gtest/internal/gtest-port.h#L2092 + @aganea have you also hit this? (Our bug: https:/

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557456. Prabhuk added a comment. Relanding the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Tri

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added a comment. Relanding the change as the build dependency issue related to the original patch is fixed by this commit: c43aa466b8980e620fd27404ca2ba60210b76111 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG720e3bacbd9f: [Basic] Support 64-bit x86 target for UEFI (authored by prabhukr ). Repository: rG LLVM Github Monorepo CHANGE

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/67721 Currently, constraints are checked in Sema::FinishTemplateArgumentDeduction, where the current function in ASTContext is set to the instantiated template function. When resolving functions for the constraints,

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently, constraints are checked in Sema::FinishTemplateArgumentDeduction, where the current function in ASTContext is set to the instantiated template function. When resolving functions for the constraints, clang assumes the caller is

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 720e3bacbd9fdba05645a4d621d43ad712c44df3 93c1086002a4a946ac2fc9066539733db750204f --

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67721 >From ba151e83af264074303ccc1d8f4ecf853a4a153f Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 28 Sep 2023 14:48:28 -0400 Subject: [PATCH] [CUDA][HIP] Fix host/device context in concept Currently, c

[clang] Update GoogleTest to v1.14.0 (PR #65823)

aganea wrote: @zmodem Can you add `ENABLE_ASSERTS` on [this line](https://github.com/llvm/llvm-project/blob/720e3bacbd9fdba05645a4d621d43ad712c44df3/llvm/lib/Support/CMakeLists.txt#L107) and run the test again, see if that gives something interesting? https://github.com/llvm/llvm-project/pul

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/67722 For the following snippets clang performs the same steps: ``` S s[2][2]; auto [a1,a2] = s; ``` ``` void crash() { S s[2][2]; int arr[4]; arr[0] = [s] { return s[0][0].i; }(); } ``` >From the two h

[clang-tools-extra] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

llvmbot wrote: @llvm/pr-subscribers-clang Changes For the following snippets clang performs the same steps: ``` S s[2][2]; auto [a1,a2] = s; ``` ``` void crash() { S s[2][2]; int arr[4]; arr[0] = [s] { return s[0][0].i; }(); } ``` >From the two however the latter crashes. The

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/67722 >From 264c0fa73e48818cccf86d1f1d240fcebd099a96 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 28 Sep 2023 20:43:23 +0200 Subject: [PATCH] [clang] Fix a crash fr

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/67722 >From fb0bf2fcc9d873ce9cf4269cfb6de8786ac6f343 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 28 Sep 2023 20:43:23 +0200 Subject: [PATCH] [clang] Fix a crash fr

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs edited https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

@@ -633,9 +637,10 @@ struct FormatToken { bool canBePointerOrReferenceQualifier() const { return isOneOf(tok::kw_const, tok::kw_restrict, tok::kw_volatile, - tok::kw___attribute, tok::kw__Nonnull, tok::kw__Nullable, + tok::kw__Nonnull,

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zmodem wrote: Just tried it, but I didn't hit any asserts. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3231a365c185094abe8af5970ccdbcbcd2bc001a 5125de27700e5ba8535deaf6039d578890f9f96d --

[clang] 82001e0 - [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (#66755)

Author: Jon Phillips Date: 2023-09-28T21:04:42+02:00 New Revision: 82001e0d01bc7545b3329866eed767c5fff7dc9e URL: https://github.com/llvm/llvm-project/commit/82001e0d01bc7545b3329866eed767c5fff7dc9e DIFF: https://github.com/llvm/llvm-project/commit/82001e0d01bc7545b3329866eed767c5fff7dc9e.diff

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/67618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/67618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. I don't have a whole lot of opinions on the attribute itself (I'm not super familiar with BPF), but did spot some things to do on the Clang side. This will also need reviewers for the LLVM changes -- any ideas on who usua

[clang] Introduce paged vector (PR #66430)

ktf wrote: @dwblaikie apologies. This is my first PR to LLVM and given the effects of it for my use case, I guess I have been a bit to enthusiastic. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: > > I changed SourceManager::isInTheSameTranslationUnit() to check for that > > case explicitly instead of relying on the fact/bug that built-ins buffers > > happened to be assigned an untranslated include SourceLocation. > > What is the translated location you get here? It

[libunwind] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

shafik wrote: I am going to merge this because I was informed that libc++ build is triggered unnecessarily because I merged main into my branch. https://github.com/llvm/llvm-project/pull/67514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 8f768ec - [Clang] Fix crash when visting a fold expression in a default argument (#67514)

Author: Shafik Yaghmour Date: 2023-09-28T12:20:22-07:00 New Revision: 8f768ec00592009cda496c8f7bfeef013887b5f3 URL: https://github.com/llvm/llvm-project/commit/8f768ec00592009cda496c8f7bfeef013887b5f3 DIFF: https://github.com/llvm/llvm-project/commit/8f768ec00592009cda496c8f7bfeef013887b5f3.dif

[clang-tools-extra] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/67514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/67722 >From fb0bf2fcc9d873ce9cf4269cfb6de8786ac6f343 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 28 Sep 2023 20:43:23 +0200 Subject: [PATCH 1/2] [clang] Fix a cras

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/isuckatcs edited https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

isuckatcs wrote: I decided to push the solution where the temporary is put inside a `FullExpressionRAII` instead of not letting clang keep going in case of an evaluation failure. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/4] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/67199 >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 14:40:14 -0700 Subject: [PATCH 1/4] Recommit "Implement [[msvc::no_unique_address]] (#65675)" Chan

[clang] a1b02c9 - [clang][hexagon] Add support for -nolibc (#67515)

Author: androm3da Date: 2023-09-28T14:54:07-05:00 New Revision: a1b02c9512ad6b3ee9d6b6cfaa0972c3d4c7dbb5 URL: https://github.com/llvm/llvm-project/commit/a1b02c9512ad6b3ee9d6b6cfaa0972c3d4c7dbb5 DIFF: https://github.com/llvm/llvm-project/commit/a1b02c9512ad6b3ee9d6b6cfaa0972c3d4c7dbb5.diff LOG

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/androm3da closed https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] 12cb98f - [clang][modules] Use `FileEntryRef` in `ModuleMap` (1/2)

Author: Jan Svoboda Date: 2023-09-28T12:59:26-07:00 New Revision: 12cb98fe04d5ca1d0cec89cdffac99c4243c0819 URL: https://github.com/llvm/llvm-project/commit/12cb98fe04d5ca1d0cec89cdffac99c4243c0819 DIFF: https://github.com/llvm/llvm-project/commit/12cb98fe04d5ca1d0cec89cdffac99c4243c0819.diff L

[clang] 12866a2 - [clang][modules] Use `FileEntryRef` in `ModuleMap` (2/2)

Author: Jan Svoboda Date: 2023-09-28T12:59:26-07:00 New Revision: 12866a2b87038abf2d69f2a6040a4ff4ce27b6cd URL: https://github.com/llvm/llvm-project/commit/12866a2b87038abf2d69f2a6040a4ff4ce27b6cd DIFF: https://github.com/llvm/llvm-project/commit/12866a2b87038abf2d69f2a6040a4ff4ce27b6cd.diff L

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 557462. void marked an inline comment as done. void added a comment. Move attribute checking over to SemaDeclAttr.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Fil

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

shafik wrote: Thank you for the fix! I don't think I understand the bug based on your description. You say >the reason is that after evaluating the first iteration, we note a failure and >would return, however during analyzing the second snippet You start saying *first iteration* and then r

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: Oh, no worries at all. LLVM 's still figuring out this whole GitHub transition anyway. I mention it only for future reference and because it might help reviewers/you if comments are getting missplaced/there's trouble tracking unaddressed feedback, etc. Thanks for sticking wit

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/2] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/3] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/4] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/5] Introduce PagedVector class

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

@@ -10950,6 +10950,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( } bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { + + FullExpressionRAII Scope(Info); + zygoloid wrote: This should be done after we evaluate the

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

https://github.com/zygoloid requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

@@ -10950,6 +10950,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( } bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { + + FullExpressionRAII Scope(Info); + isuckatcs wrote: > so that we destroy temporaries after e

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

erichkeane added a comment. The CFE stuff is pretty innocuous and I don't see a reason to stop this on our accord, but would like someone familiar with the LLVM stuff to review this at one point. Comment at: clang/lib/CodeGen/CGExpr.cpp:3694 +static bool hasBPFPreserveStaticO

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

@@ -10950,6 +10950,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( } bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { + + FullExpressionRAII Scope(Info); + zygoloid wrote: Here's a rejects-valid testcase: https://

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

@@ -633,9 +637,10 @@ struct FormatToken { bool canBePointerOrReferenceQualifier() const { return isOneOf(tok::kw_const, tok::kw_restrict, tok::kw_volatile, - tok::kw___attribute, tok::kw__Nonnull, tok::kw__Nullable, + tok::kw__Nonnull,

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/67518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. @aaron.Ballman Do I need to make changes other than this? The virtual base diagnostic doesn't have a test case in files that would generate it. Should I add the above example as the test case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ ht

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + ldionne wrote: > This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` > variable for each declared `project()` I

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. In D154869#4628847 , @efriedma wrote: > Maybe split the changes to reformat the unittests into a separate patch? > > Otherwise, I'm happy with the current state of this patch, but probably > someone more active in flang should a

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

@@ -10950,6 +10950,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( } bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) { + + FullExpressionRAII Scope(Info); + zygoloid wrote: Better testcase, avoiding the use of muta

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67739 While a DecltypeType node itself is not uniqued, an instantiation dependent DecltypeType will have a DependentDecltypeType as an underlying type, which is uniqued. In that case, there can be non-identical non-s

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

llvmbot wrote: @llvm/pr-subscribers-clang Changes While a DecltypeType node itself is not uniqued, an instantiation dependent DecltypeType will have a DependentDecltypeType as an underlying type, which is uniqued. In that case, there can be non-identical non-sugar DecltypeTypes nodes whic

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/shafik approved this pull request. Thank you for the quick fix. LGTM, please add a release note. https://github.com/llvm/llvm-project/pull/67739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67742 None >From 242fa18a43ced2d738fe5cbe44912293767712f9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 28 Sep 2023 14:24:56 -0700 Subject: [PATCH] [clang] NFCI: Use `FileEntryRef` in `SourceManager::Fil

[clang] 0faee97 - Recommit "Implement [[msvc::no_unique_address]] (#65675)" (#67199)

Author: Amy Huang Date: 2023-09-28T14:29:32-07:00 New Revision: 0faee97a924adec76d5c7cd680c289ced51e6b5a URL: https://github.com/llvm/llvm-project/commit/0faee97a924adec76d5c7cd680c289ced51e6b5a DIFF: https://github.com/llvm/llvm-project/commit/0faee97a924adec76d5c7cd680c289ced51e6b5a.diff LOG

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 33f5087e1b29eec160d82808c1a2c9d4789cbd6c 242fa18a43ced2d738fe5cbe44912293767712f9 --

[clang] Introduce paged vector (PR #66430)

https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/zygoloid unresolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67739 >From 7009ebf7f2016816b5cbb694e0611cd2a86d7cf1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 28 Sep 2023 22:38:59 +0200 Subject: [PATCH] [clang] implement common sugared type of inst-dependent Declt

[clang] [clang] set DebugCompilationDir in PCHContainer (PR #67744)

https://github.com/rmaz created https://github.com/llvm/llvm-project/pull/67744 This change sets the debug compilation directory when generating debug information for PCH object containers. This allows for overriding the compilation directory in debug information in precompiled pcm files. >Fro

[clang] [analyzer] Move alpha checker EnumCastOutOfRange to optin (PR #67157)

haoNoQ wrote: > Before merging this PR, the diagnostics of the EnumCast checker should be > updated to mention the name of the `enum` type in question. @gamesh411 could > you create a PR that implements this improvement (as we discussed)? Yes, it should call out the enum, call out the value, a

[clang] [clang] set DebugCompilationDir in PCHContainer (PR #67744)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes This change sets the debug compilation directory when generating debug information for PCH object containers. This allows for overriding the compilation directory in debug information in precompiled pcm files. --- Full diff: https

[clang] [clang] Fix a crash from nested ArrayInitLoopExpr (PR #67722)

isuckatcs wrote: > I don't think I understand the bug based on your description. I'll try my best to explain it a bit better. So, this is the function that runs and triggers the assertion failure at one point. ```c++ bool ArrayExprEvaluator::VisitArrayInitLoopExpr(const ArrayInitLoopExpr *E) {

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

cjdb wrote: Thanks @amykhuang! 🎉 https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] de85739 - [clang] NFCI: Use `FileEntryRef` in additional module maps

Author: Jan Svoboda Date: 2023-09-28T14:49:45-07:00 New Revision: de85739ded2edddc568f287d4f94c2dc1ab97dd7 URL: https://github.com/llvm/llvm-project/commit/de85739ded2edddc568f287d4f94c2dc1ab97dd7 DIFF: https://github.com/llvm/llvm-project/commit/de85739ded2edddc568f287d4f94c2dc1ab97dd7.diff L

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 557470. ZijunZhao marked 5 inline comments as done. ZijunZhao added a comment. 1. Simplify code in SemaChecking.cpp 2. Fix the nit and rename the variable in SemaChecking.cpp 3. Update the condition in SemaChecking.cpp 4. Add wchar_t test to show our care

[clang] Introduce paged vector (PR #66430)

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/zygoloid approved this pull request. It looks like there were a couple of unaddressed comments from my earlier reviews; I think github may have been "helpfully" hiding them from you by default. I've added comments on them so you should hopefully be able to find them. Thanks

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,282 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] 3e9c363 - [clang] NFCI: Use `FileEntryRef` in `SourceManager::setFileIsTransient()`

Author: Jan Svoboda Date: 2023-09-28T14:50:00-07:00 New Revision: 3e9c36303ca72929275fb97767af43b3aa04cab1 URL: https://github.com/llvm/llvm-project/commit/3e9c36303ca72929275fb97767af43b3aa04cab1 DIFF: https://github.com/llvm/llvm-project/commit/3e9c36303ca72929275fb97767af43b3aa04cab1.diff L

[clang-tools-extra] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos` (PR #67742)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67742 >From 857054623edbd0917b74273cec050770f2d24a80 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 28 Sep 2023 14:24:56 -0700 Subject: [PATCH] [clang] NFCI: Use `FileEntryRef` in `SourceManager::FileInfos

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/6] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 07da9379065daab62d43ba453ba6b71f3880a089 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/7] Introduce PagedVector class

<    1   2   3   4   5   >