[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -146,16 +188,15 @@ void InvalidPtrChecker::postPreviousReturnInvalidatingCall( // Remember

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -94,23 +119,40 @@ REGISTER_MAP_WITH_PROGRAMSTATE(PreviousCallResultMap, const FunctionDecl *,

[clang] [flang]Add vscale argument parsing (PR #67676)

@@ -170,6 +170,39 @@ void Flang::addPicOptions(const ArgList &Args, ArgStringList &CmdArgs) const { } } + +void Flang::AddAArch64TargetArgs(const ArgList &Args, + ArgStringList &CmdArgs) const { + // Handle -msve_vector_bits= + if (Arg *A =

[clang] [flang]Add vscale argument parsing (PR #67676)

@@ -42,6 +42,7 @@ #include "mlir/Target/LLVMIR/ModuleTranslation.h" #include "clang/Basic/Diagnostic.h" #include "clang/Basic/DiagnosticFrontend.h" +#include "clang/Basic/TargetInfo.h" tblah wrote: Is this used anywhere? https://github.com/llvm/llvm-project/p

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/tblah requested changes to this pull request. Please could you add testing, like the tests you wrote for the loop versioning flag. https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

ldionne wrote: This seems to be a bit stuck. I checked out the patch locally and that was helpful to understand some of the issues. I think the final patch should be: ``` commit c667f036c4228b9cf0172c311537ab96ef61fcf5 Author: PandaNinjas Date: Wed Sep 13 17:38:17 2023 -0700 [libc++] Pr

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

ldionne wrote: This seems to be a bit stuck. I checked out the patch locally and that was helpful to understand some of the issues. I think the final patch should be: ``` commit c667f036c4228b9cf0172c311537ab96ef61fcf5 Author: PandaNinjas Date: Wed Sep 13 17:38:17 2023 -0700 [libc++] Pr

[clang] [analyzer] Add std::variant checker (PR #66481)

https://github.com/DonatNagyE approved this pull request. https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

spaits wrote: @steakhal what do you think about the current version of this commit? https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 989173c - [C++20] [Modules] Don't generate call to an imported module that dont init anything (#67638)

Author: Chuanqi Xu Date: 2023-09-28T23:29:24+08:00 New Revision: 989173c09c2930a9f523ccb455111ef446e9f96d URL: https://github.com/llvm/llvm-project/commit/989173c09c2930a9f523ccb455111ef446e9f96d DIFF: https://github.com/llvm/llvm-project/commit/989173c09c2930a9f523ccb455111ef446e9f96d.diff LO

[clang] [C++20] [Modules] Don't generate call to an imported module that dont init anything (PR #67638)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/67638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

shiltian wrote: Can we have a test? https://github.com/llvm/llvm-project/pull/67679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

@@ -0,0 +1,20 @@ + +macro(serialize_lit_param param value) + string(APPEND SERIALIZED_LIT_PARAMS "config.${param} = ${value}\n") ldionne wrote: This looks reasonable, but could we avoid using the global variable `SERIALIZED_LIT_PARAMS` here? We should thread it

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/66740 >From 85f7911dfe0f1e9112881a9f503bcd68edfde580 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 19 Sep 2023 10:19:46 +0800 Subject: [PATCH 1/3] [InstCombine] Canonicalize `and(zext(A), B)` into `select A,

[clang] [C++20] [Modules] Don't generate call to an imported module that dont init anything (PR #67638)

@@ -1245,6 +1245,27 @@ void Sema::ActOnEndOfTranslationUnit() { } } +// Now we can decide whether the modules we're building need an initializer. +if (Module *CurrentModule = getCurrentModule(); +CurrentModule && CurrentModule->isInterfaceOrPartition

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3775 bool UseMemberUsingDeclRules, bool ConsiderCudaAttrs = true, - bool ConsiderRequiresClauses = true); + bool UseOverrideRules = false);

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

@@ -102,7 +102,7 @@ inline bool operator>=(const Fraction &x, const Fraction &y) { inline Fraction reduce(const Fraction &f) { if (f == Fraction(0)) return Fraction(0, 1); - MPInt g = gcd(f.num, f.den); + MPInt g = gcd(abs(f.num), abs(f.den)); return Fraction(f.num

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

https://github.com/Superty requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

https://github.com/Superty edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

@@ -244,6 +244,31 @@ class IntMatrix : public Matrix }; +// An inherited class for rational matrices, with no new data attributes. +// This is only used for the matrix-related method which apply only +// to fractions (inverse). Superty wrote: "This class is

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

@@ -390,4 +390,68 @@ MPInt IntMatrix::normalizeRow(unsigned row, unsigned cols) { MPInt IntMatrix::normalizeRow(unsigned row) { return normalizeRow(row, getNumColumns()); +} + +FracMatrix FracMatrix::identity(unsigned dimension) { + FracMatrix matrix(dimension, dimension);

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

@@ -102,7 +102,7 @@ inline bool operator>=(const Fraction &x, const Fraction &y) { inline Fraction reduce(const Fraction &f) { if (f == Fraction(0)) return Fraction(0, 1); - MPInt g = gcd(f.num, f.den); + MPInt g = gcd(abs(f.num), abs(f.den)); return Fraction(f.num

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

https://github.com/Superty requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: (aside: I was confused why there was only one commit in this PR, since there'd been so many updates to it - but I see they've been force pushed, which my vague understanding is that force pushing can complicate tracking previous comments and the LLVM convention is not to do so

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67679 >From 8b1751a3d3f1dbb9dc9120f1ae3575df32b33221 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 28 Sep 2023 08:46:00 -0500 Subject: [PATCH 1/2] [LinkerWrapper] Correctly handle multiple image wrappers Summ

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

jhuber6 wrote: > Can we have a test? Sure, the reason that it failed w/ `-save-temps` is because normally the output name got a temp file but `-save-temps` keeps it the same name. https://github.com/llvm/llvm-project/pull/67679 ___ cfe-commits mailin

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

kosarev added a comment. @Prabhuk This reproduces with my setup as well. Did you try building with `-DBUILD_SHARED_LIBS=ON`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 __

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2b-deducing-this.cpp:192 +f(); // expected-error{{call to non-static member function without an object argument}} +f(Over_Call_Func_Example{}); // expected-error{{call to non-static m

[clang] d6ae4bd - [Clang][NFC] Add tests for #56071

Author: Corentin Jabot Date: 2023-09-28T17:57:56+02:00 New Revision: d6ae4bd686714d34969012fa273140e547606d81 URL: https://github.com/llvm/llvm-project/commit/d6ae4bd686714d34969012fa273140e547606d81 DIFF: https://github.com/llvm/llvm-project/commit/d6ae4bd686714d34969012fa273140e547606d81.diff

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/67679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added a comment. If there are others experiencing the same error then I can push my fix: https://github.com/llvm/llvm-project/pull/67696 if there are no other suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https

[clang] 06c9cc7 - [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

Author: Manna, Soumi Date: 2023-09-28T09:00:55-07:00 New Revision: 06c9cc7eaa8a19820535bf52e8ad8dcecf07caf4 URL: https://github.com/llvm/llvm-project/commit/06c9cc7eaa8a19820535bf52e8ad8dcecf07caf4 DIFF: https://github.com/llvm/llvm-project/commit/06c9cc7eaa8a19820535bf52e8ad8dcecf07caf4.diff

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c9cc7eaa8a: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812 >From 5f5e57a5c01088e7f0b9276ed02dd436a3f9cc0a Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH 1/3] Support: hoist lld's executable name code to Path Instead of usi

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > Prabhuk wrote: > > mbrkusanin wrote: > > > This is giving me a linker error: > >

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4246 +private: + SourceRange countedByFieldLoc; +public: void wrote: > aaron.ballman wrote: > > void wrote: > > > erichkeane wrote: > > > > aaron.ballman wrote: > > >

[clang] [clang][Sema] Only check RVV types if we have them (PR #67669)

https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/67669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

steakhal wrote: @DonatNagyE I can see you all have a lot of PRs. I have limited time, but I think I can do two this week. Maybe one next week. In what order should I go through the PRs? I guess, this one should be in the lucky two. https://github.com/llvm/llvm-project/pull/66481 ___

[clang-tools-extra] [analyzer] Add std::variant checker (PR #66481)

steakhal wrote: @DonatNagyE I can see you all have a lot of PRs. I have limited time, but I think I can do two this week. Maybe one next week. In what order should I go through the PRs? I guess, this one should be in the lucky two. https://github.com/llvm/llvm-project/pull/66481 ___

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm resolved https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Context.h:88 + /// Returns the program. This is only needed for unittests. + Program &getProgram() const { return *P.get(); } + tbaeder wrote: > cor3ntin wrote: > > This should return a const

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. In D158540#4643563 , @NoumanAmir657 wrote: > **Code:** > > struct Base { >constexpr Base() = default; > }; > struct Derived : virtual Base { > constexpr Derived() = default; > }; > > struct NoCopyMove {

[clang] 7485d36 - [LinkerWrapper] Correctly handle multiple image wrappers (#67679)

Author: Joseph Huber Date: 2023-09-28T11:22:11-05:00 New Revision: 7485d36a6267d1861710dfcb1b64784e4fb1187c URL: https://github.com/llvm/llvm-project/commit/7485d36a6267d1861710dfcb1b64784e4fb1187c DIFF: https://github.com/llvm/llvm-project/commit/7485d36a6267d1861710dfcb1b64784e4fb1187c.diff

[clang] [LinkerWrapper] Correctly handle multiple image wrappers (PR #67679)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

@@ -612,24 +612,21 @@ FileManager::getNoncachedStatValue(StringRef Path, } void FileManager::GetUniqueIDMapping( -SmallVectorImpl &UIDToFiles) const { +SmallVectorImpl &UIDToFiles) const { UIDToFiles.clear(); UIDToFiles.resize(NextFileUID); - // Map file entri

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/67383 >From e2201a10fe76be3de8efd0faca0f381f504b08d3 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 25 Sep 2023 16:37:49 -0700 Subject: [PATCH 1/2] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileI

[clang] 6bbccc0 - [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (#67383)

Author: Jan Svoboda Date: 2023-09-28T09:28:02-07:00 New Revision: 6bbccc0bcb36689507ba98ef338527d43334c7e7 URL: https://github.com/llvm/llvm-project/commit/6bbccc0bcb36689507ba98ef338527d43334c7e7 DIFF: https://github.com/llvm/llvm-project/commit/6bbccc0bcb36689507ba98ef338527d43334c7e7.diff L

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812 >From 5f5e57a5c01088e7f0b9276ed02dd436a3f9cc0a Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH 1/4] Support: hoist lld's executable name code to Path Instead of usi

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D155572#4646353 , @tbaeder wrote: > In D155572#4645997 , @aaron.ballman > wrote: > >> Hmmm,

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/67700 HLSL supports vector swizzles on scalars by implicitly converting the scalar to a single-element vector. This syntax is a convienent way to initialize vectors based on filling a scalar value. There are two p

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

llvmbot wrote: @llvm/pr-subscribers-hlsl Changes HLSL supports vector swizzles on scalars by implicitly converting the scalar to a single-element vector. This syntax is a convienent way to initialize vectors based on filling a scalar value. There are two parts of this change. The first p

[clang] Add -fkeep-system-includes modifier for -E (PR #67684)

jrtc27 wrote: Its limitations, i.e. how in various cases it can break or change correct code, need to be documented somewhere alongside the option (ideally a disclaimer in --help's output and a longer explanation in the rendered documentation). https://github.com/llvm/llvm-project/pull/67684 _

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 7 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3775 bool UseMemberUsingDeclRules, bool ConsiderCudaAttrs = true, - bool ConsiderRequiresClauses = true); +

[clang] [flang]Add vscale argument parsing (PR #67676)

@@ -170,6 +170,39 @@ void Flang::addPicOptions(const ArgList &Args, ArgStringList &CmdArgs) const { } } + +void Flang::AddAArch64TargetArgs(const ArgList &Args, + ArgStringList &CmdArgs) const { + // Handle -msve_vector_bits= + if (Arg *A =

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a comment. Aside from some minor nits in the release notes, I think this LGTM. I'm going to hold off on accepting officially for a day or two just so other code reviews have a chance to weigh in (the codegen code owners were only added to the review today). ==

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6bbccc0bcb36689507ba98ef338527d43334c7e7 2fa183da3991c0bc4da6163609331d198f4a37af --

[clang] Reland [NVPTX] Add support for maxclusterrank in launch_bounds (#66496) (PR #67667)

https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/67667 >From 6d17781780584d5bc123e93e1388e64df0bbd3f9 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Thu, 28 Sep 2023 13:30:27 +0100 Subject: [PATCH] Reland [NVPTX] Add support for maxclusterrank in launch_bounds

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

tahonermann wrote: I am also rather uncomfortable with this behavioral change. There are a lot of build systems in use out there. My preference would be to continue to probe for a .gch file, but also validate that it is a (compatible) Clang PCH file before trying to use it. https://github.com

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1281 +"rocThrust path, required by the HIP Standard Parallel Algorithm " +"Acceleration library, used to implicitly include the rocThrust library.">; +def hips

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/Leporacanthicus updated https://github.com/llvm/llvm-project/pull/67676 >From 25b53fa1d6d52e8f22dcdaaf5c7fbf47132e Mon Sep 17 00:00:00 2001 From: Mats Petersson Date: Fri, 15 Sep 2023 18:52:11 +0100 Subject: [PATCH 1/3] [flang]Add vscale argument parsing Support for vect

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/Leporacanthicus resolved https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang]Add vscale argument parsing (PR #67676)

https://github.com/Leporacanthicus resolved https://github.com/llvm/llvm-project/pull/67676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

MaskRay wrote: I'd appreciate seeing concrete evidence rather than relying solely on intuition. I've considered the potential disruption of deprecating `.gch` files but haven't been able to substantiate it (let's say the concern is about autotools users). When using the regular expression `-o.

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

@@ -98,7 +98,7 @@ // == file2.h // REWRITE: #if 0 // REWRITE: #include "file2.h" -// REWRITE: #endif +// REWRITE: #else /* file2.h expanded MaskRay wrote: Does this line not have `by -frewrite-includes`? https://github.com/llvm/llvm-project/pull/67613 ___

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

@@ -151,6 +151,10 @@ set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS find_package(Python3 COMPONENTS Interpreter) +set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_LIBUNWIND_TEST_PARAMS "${RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_TEST_PARAMS}" CACHE INTERNAL

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

zmodem wrote: > I'd appreciate seeing concrete evidence rather than relying solely on > intuition. XCode and GN are two concrete examples. https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/androm3da updated https://github.com/llvm/llvm-project/pull/67515 >From 4048b1e2557b11650cf2fa568c8814716e45daf5 Mon Sep 17 00:00:00 2001 From: Brian Cain Date: Tue, 26 Sep 2023 19:57:47 -0700 Subject: [PATCH] [clang][hexagon] Add support for -nolibc --- clang/lib/Driver/To

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/67671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

@@ -882,11 +882,8 @@ void tools::addOpenMPRuntimeLibraryPath(const ToolChain &TC, void tools::addArchSpecificRPath(const ToolChain &TC, const ArgList &Args, ArgStringList &CmdArgs) { - // Enable -frtlib-add-rpath by default for the case of VE

[clang] [Clang][VE] Correct rpath handling on VE (PR #67671)

@@ -2213,12 +2210,12 @@ bool tools::GetSDLFromOffloadArchive( // Wrapper function used by driver for adding SDLs during link phase. void tools::AddStaticDeviceLibsLinking(Compilation &C, const Tool &T, -const JobAction &JA, Mask

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

https://github.com/Xazax-hun approved this pull request. Looks good, thanks! I think a comment about how the types in the AST already has the nullability propagated correctly might be helpful for the future readers, otherwise it looks good to me! https://github.com/llvm/llvm-project/pull/67563

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

skc7 wrote: > > > Yeah, `clang/test/CodeGen/memtag-globals-asm.cpp` is for MTE Globals, not > > > ASan - and the sizes of the GVs should be multiple-of-16 bytes: > > > https://github.com/ARM-software/abi-aa/blob/main/memtagabielf64/memtagabielf64.rst#compilation > > > What problem are you tryin

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/androm3da resolved https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/androm3da resolved https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/androm3da resolved https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5db790f - [clang][Parse][NFC] Make ParseOpenMPAttributeArgs() AttrName const

Author: Timm Bäder Date: 2023-09-28T19:37:41+02:00 New Revision: 5db790f96c67f6b610e3d436d6d150f8748fda65 URL: https://github.com/llvm/llvm-project/commit/5db790f96c67f6b610e3d436d6d150f8748fda65 DIFF: https://github.com/llvm/llvm-project/commit/5db790f96c67f6b610e3d436d6d150f8748fda65.diff LO

[clang] 92eaeb6 - [clang][Parse][NFC] Remove dead if statement

Author: Timm Bäder Date: 2023-09-28T19:37:42+02:00 New Revision: 92eaeb6c63d260a4f618a57c6441d2c3153280ca URL: https://github.com/llvm/llvm-project/commit/92eaeb6c63d260a4f618a57c6441d2c3153280ca DIFF: https://github.com/llvm/llvm-project/commit/92eaeb6c63d260a4f618a57c6441d2c3153280ca.diff LO

[clang] [clang][ExprConst] Don't create useless temporary variable (PR #67716)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/67716 We never use it anyway. This code has been introduced in 410306bf6ed906af77978caa199e5d96376bae66, but it didn't really do anything back then either, as far as I can tell. Fixes #57135 >From 9d2444645dfe72889

[clang] [clang][ExprConst] Don't create useless temporary variable (PR #67716)

llvmbot wrote: @llvm/pr-subscribers-clang Changes We never use it anyway. This code has been introduced in 410306bf6ed906af77978caa199e5d96376bae66, but it didn't really do anything back then either, as far as I can tell. Fixes #57135 --- Full diff: https://github.com/llvm/llvm-project/

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

@@ -98,7 +98,7 @@ // == file2.h // REWRITE: #if 0 // REWRITE: #include "file2.h" -// REWRITE: #endif +// REWRITE: #else /* file2.h expanded pogo59 wrote: Yes it does, but the point here is simply to identify that this is the correct `#else`. The Preprocessor

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

https://github.com/shafik commented: Minor comments on testing but I am curious about the size question. https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

@@ -858,8 +858,8 @@ bool ByteCodeExprGen::VisitStringLiteral(const StringLiteral *E) { // If the initializer string is too long, a diagnostic has already been // emitted. Read only the array length from the string literal. - unsigned N = - std::min(unsigned(CAT->get

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

@@ -350,3 +350,22 @@ namespace ZeroInit { static_assert(b.f[0] == 0.0, ""); static_assert(b.f[1] == 0.0, ""); } + +namespace StringZeroFill { + struct A { +char c[12]; + }; + constexpr A a = { "abc" }; + static_assert(a.c[0] == 'a', ""); + static_assert(a.c[1] == '

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

@@ -350,3 +350,22 @@ namespace ZeroInit { static_assert(b.f[0] == 0.0, ""); static_assert(b.f[1] == 0.0, ""); } + +namespace StringZeroFill { + struct A { +char c[12]; + }; + constexpr A a = { "abc" }; + static_assert(a.c[0] == 'a', ""); + static_assert(a.c[1] == '

[clang] [clang] Default x86_64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

https://github.com/aeubanks edited https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

https://github.com/goldsteinn approved this pull request. https://github.com/llvm/llvm-project/pull/65910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

goldsteinn wrote: LGTM. https://github.com/llvm/llvm-project/pull/65910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:373-387 + bool CkdOperation = false; + SourceManager &SM = S.getSourceManager(); + if (BuiltinID == Builtin::BI__builtin_add_overflow && +TheCall->getExprLoc().isMacroID() && Lexer::getImm

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/65910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

https://github.com/rnk approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

@@ -752,27 +751,41 @@ void CGOpenMPRuntimeGPU::emitNonSPMDKernel(const OMPExecutableDirective &D, EntryFunctionState EST; WrapperFunctionsMap.clear(); + bool IsBareKernel = D.getSingleClause(); shiltian wrote: I made the change in the parent scope such

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

https://github.com/shiltian resolved https://github.com/llvm/llvm-project/pull/66844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >