[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -864,74 +864,7 @@ FileID SourceManager::getFileIDLocal(SourceLocation::UIntTy SLocOffset) const { /// This function knows that the SourceLocation is in a loaded buffer, not a /// local one. FileID SourceManager::getFileIDLoaded(SourceLocation::UIntTy SLocOffset) const { -

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -50,6 +50,7 @@ int y = a2; // CHECK: In module 'a': // CHECK-NEXT: a.h:1:45: error: +int z = b; // MISSING-B: could not find file '{{.*}}b.h' // MISSING-B-NOT: please delete the module cache benlangmuir wrote: Can we use this approach to test the current

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -288,10 +288,12 @@ class ModuleFile { /// for the entry is SLocEntryOffsetsBase + SLocEntryOffsets[i]. uint64_t SLocEntryOffsetsBase = 0; - /// Offsets for all of the source location entries in the - /// AST file. + /// Stream bit offsets for all of the source locati

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -2261,43 +2261,68 @@ template struct enumerator_result { mutable range_reference_tuple Storage; }; -/// Infinite stream of increasing 0-based `size_t` indices. -struct index_stream { - struct iterator : iterator_facade_base { -iterator &operator++() { - assert

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

@@ -1444,6 +1444,77 @@ llvm::Error ASTReader::ReadSourceManagerBlock(ModuleFile &F) { } } +std::optional +ASTReader::readSLocOffset(ModuleFile *F, unsigned Index) { benlangmuir wrote: Does every path that returns `std::nullopt` report an error? If so I wou

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. @MyDeveloperDay addressed your comments. Thanks! Would love to get this in before Phabricator closes. Anything else I can do to help? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___

[clang] 880fa7f - Revert "[clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated"

Author: Sam McCall Date: 2023-09-27T18:58:01+02:00 New Revision: 880fa7faa97bad63e403c924263b01fb81783227 URL: https://github.com/llvm/llvm-project/commit/880fa7faa97bad63e403c924263b01fb81783227 DIFF: https://github.com/llvm/llvm-project/commit/880fa7faa97bad63e403c924263b01fb81783227.diff LO

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

paulwalker-arm wrote: I agree and custom lowering also gives a straight forward way to support vectors types as well. https://github.com/llvm/llvm-project/pull/67552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

zahiraam wrote: > Hi @zahiraam - can we revert this change until [#66114 > (comment)](https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259) > is resolved? Unfortunately this is impacting our downstream windows-x64 > builder. I have a fix for it. It should be ready by eod

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. Thanks for the report about the errors in lambdas. The culprit is `clang/lib/Sema/SemaTemplateInstantiateDecl.cpp`. I am pushing constant-evaluated context if the instantiated variable is constexpr variable, and somehow it causes those errors. I'll take deeper look in

[clang] Modify BoundsSan to improve debuggability (PR #65972)

@@ -0,0 +1,83 @@ +; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM +; What this test does is check that even with nomerge, the functions still get merged in +; compiled code as the ubsantrap call gets lowered to a single instructio

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

steakhal wrote: I support changes like this. However, I think we should prefer reusing existing test files to creating more and more new ones. That has one benefit to me, one can see multiple cases of the topic on one screen without jumping around to open multiple. But that's all. I don't thin

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lhames added a comment. Ok -- I'll try disabling `lsan` for now. It'll be good to test this path (even with a leak), and it'll make reproduction extra simple when someone has cycles to look into the leak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

https://github.com/diseraluca updated https://github.com/llvm/llvm-project/pull/67566 >From d19d716609034465bf6be814a322f26c1ea619c9 Mon Sep 17 00:00:00 2001 From: Luca Di Sera Date: Wed, 27 Sep 2023 15:20:22 +0200 Subject: [PATCH] Qualify non-dependent types of a class template with its decla

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

https://github.com/diseraluca edited https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

https://github.com/diseraluca edited https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

diseraluca wrote: Run clang-format on the patch. I made a bit of a mess as I haven't used the PR model in a very long time. Hopefully this is correct. https://github.com/llvm/llvm-project/pull/67566 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D156636: [InstCombine] Deduce `align` and `nonnull` return attributes for `llvm.ptrmask`

goldstein.w.n abandoned this revision. goldstein.w.n added a comment. This has been ported to github PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156636/new/ https://reviews.llvm.org/D156636 ___ cfe

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

sam-mccall wrote: Sorry, there were no notifications, I guess the bot was already red. I'm not really sure what to do other than disable the test on these bots - I don't know why it would fail on win/arm (it seems to pass on win/x86), and I don't have access to such a machine. This behavior is

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

mizvekov wrote: It's recommended to avoid introducing pure clang-format changes mixed with other non-style changes. The recommended way to avoid that is to run clang-format on the modified files on a separate commit, and then just merge that, no review required. https://github.com/llvm/llvm-p

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

sam-mccall wrote: ... and as soon as I said that, I found something: looks like these are maybe building with `DEFAULT_SYSROOT=C:/buildbot/.arm-ubuntu`, which breaks the no-sysroot behavior we're testing here. I'll see if I can override with `--sysroot=` https://github.com/llvm/llvm-project/p

[clang] 5aa3338 - [Driver] Fix VFSGnuLibcxxPathNoSysroot test with DEFAULT_SYSROOT

Author: Sam McCall Date: 2023-09-27T19:31:57+02:00 New Revision: 5aa3338930d15a59dd6ddbd36fc09ffa6610ca72 URL: https://github.com/llvm/llvm-project/commit/5aa3338930d15a59dd6ddbd36fc09ffa6610ca72 DIFF: https://github.com/llvm/llvm-project/commit/5aa3338930d15a59dd6ddbd36fc09ffa6610ca72.diff LO

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

petrhosek wrote: Our preference would be to revert the change and reland it later since this doesn't appear to be a quick fix, which is in line with https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy https://github.com/llvm/llvm-project/pull/66120 ___

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

petrhosek wrote: Our preference would be to revert the change and reland it later since this doesn't appear to be a quick fix, which is in line with https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy https://github.com/llvm/llvm-project/pull/66120 ___

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67557 >From fb3191832cd69633757436d95c176f949c88774b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 27 Sep 2023 09:03:16 -0500 Subject: [PATCH] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for O

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga updated https://github.com/llvm/llvm-project/pull/65972 >From 8dd1d0c534faadd65f546a150bbd2cc5a132aa1e Mon Sep 17 00:00:00 2001 From: Oskar Wirga <10386631+oskarwi...@users.noreply.github.com> Date: Wed, 27 Sep 2023 10:37:49 -0700 Subject: [PATCH 1/2] Modify array-b

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga resolved https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

https://github.com/yinying-lisa-li updated https://github.com/llvm/llvm-project/pull/67569 >From 0f1db4000d971192e0b2b027746cdd37083bf87f Mon Sep 17 00:00:00 2001 From: Yinying Li Date: Wed, 27 Sep 2023 14:51:34 + Subject: [PATCH] [mlir][sparse] Change tests to use new syntax for ELL and s

[clang-tools-extra] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

https://github.com/yinying-lisa-li updated https://github.com/llvm/llvm-project/pull/67569 >From 0f1db4000d971192e0b2b027746cdd37083bf87f Mon Sep 17 00:00:00 2001 From: Yinying Li Date: Wed, 27 Sep 2023 14:51:34 + Subject: [PATCH] [mlir][sparse] Change tests to use new syntax for ELL and s

[clang-tools-extra] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

@@ -240,8 +240,9 @@ def SparseTensorEncodingAttr : SparseTensor_Attr<"SparseTensorEncoding", // CSR slice (offset = 0, size = 4, stride = 1 on the first dimension; // offset = 0, size = 8, and a dynamic stride on the second dimension). #CSR_SLICE = #sparse_tensor.e

[clang] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

@@ -240,8 +240,9 @@ def SparseTensorEncodingAttr : SparseTensor_Attr<"SparseTensorEncoding", // CSR slice (offset = 0, size = 4, stride = 1 on the first dimension; // offset = 0, size = 8, and a dynamic stride on the second dimension). #CSR_SLICE = #sparse_tensor.e

[clang-tools-extra] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

@@ -240,8 +240,9 @@ def SparseTensorEncodingAttr : SparseTensor_Attr<"SparseTensorEncoding", // CSR slice (offset = 0, size = 4, stride = 1 on the first dimension; // offset = 0, size = 8, and a dynamic stride on the second dimension). #CSR_SLICE = #sparse_tensor.e

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557412. efriedma added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157547/new/ https://reviews.llvm.org/D157547 Files: clang/lib/CodeGen/CGCXX.cpp llvm/include/llvm/IR/CallingConv.h

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/67431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/67431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

@@ -122,10 +122,22 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; justify-content: space-between; + cursor: pointer; +} +.value > summary::before { + content:

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

@@ -122,10 +122,22 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; justify-content: space-between; + cursor: pointer; +} +.value > summary::before { + content:

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

@@ -122,10 +122,22 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; justify-content: space-between; sam-mccall wrote: if space-between stays, don

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/67431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/5] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,23 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -2088,12 +2088,12 @@ class TargetInstrInfo : public MCInstrInfo { } /// Insert an architecture-specific instruction to clear a register. If you - /// need to avoid sideeffects (e.g. XOR on x86), set \p NoSideEffects to \p - /// true. + /// need to avoid sideeffects (

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,23 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

vabridgers wrote: > I support changes like this. However, I think we should prefer reusing > existing test files to creating more and more new ones. That has one benefit > to me, one can see multiple cases of the topic on one screen without jumping > around to open multiple. But that's all. I

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

nickdesaulniers wrote: > We could maybe presume glibc on ELF targets Isn't that part of the triple? `aarch64-linux-gnu` gnu -> glibc (as opposed to `aarch64-linux-musl` -> musl, or `aarch64-linux-android` -> bionic) https://github.com/llvm/llvm-project/pull/67360 __

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. I think we're getting pretty close! My goal is to get this landed ASAP; I do not think it needs to be hidden behind a feature flag (-std=c++2b is sufficient), and it's good that we're not defining the feature test

[clang] 9243b1b - Revert "[clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (#66120)"

Author: Aaron Ballman Date: 2023-09-27T14:26:49-04:00 New Revision: 9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac URL: https://github.com/llvm/llvm-project/commit/9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac DIFF: https://github.com/llvm/llvm-project/commit/9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac.diff

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

AaronBallman wrote: I've reverted the changes in 9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac, but you should handle the revert yourself next time because you have commit privileges and it's possible the person requesting a revert does not. (If you can't do the revert immediately for whatever reas

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

AaronBallman wrote: I've reverted the changes in 9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac, but you should handle the revert yourself next time because you have commit privileges and it's possible the person requesting a revert does not. (If you can't do the revert immediately for whatever reas

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -5490,6 +5490,9 @@ TreeTransform::TransformDependentSizedArrayType(TypeLocBuilder &TLB, EnterExpressionEvaluationContext Unevaluated( SemaRef, Sema::ExpressionEvaluationContext::ConstantEvaluated); + // VLA bounds are not truly constant. shafik wr

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -15090,8 +15093,9 @@ static void CheckImplicitConversion(Sema &S, Expr *E, QualType T, if (SourceBT && TargetBT && SourceBT->isIntegerType() && TargetBT->isFloatingType() && !IsListInit) { // Determine the number of precision bits in the source integer type. -

[clang] [RISCV][NFC] Move some common class/multiclass from riscv_vector.td to riscv_vector_common.td (PR #67587)

https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/67587 Since there are more vendor extensions that needs to implement custom intrinsics, it's useful to move some common usages to riscv_vector_common.td. >From 6f3575b70438a0529bd2505ccf55a87cca3eeefd Mon Sep 17 00:00

[clang] [RISCV][NFC] Move some common class/multiclass from riscv_vector.td to riscv_vector_common.td (PR #67587)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Since there are more vendor extensions that needs to implement custom intrinsics, it's useful to move some common usages to riscv_vector_common.td. --- Patch is 35.34 KiB, truncated to 20.00 KiB below, full version: https://github.com/ll

[clang] 47625fe - [clang-repl] Disable LSan in InterpreterExceptionTest.

Author: Lang Hames Date: 2023-09-27T11:36:14-07:00 New Revision: 47625fea5e376082fca65d0ac644f07957605d86 URL: https://github.com/llvm/llvm-project/commit/47625fea5e376082fca65d0ac644f07957605d86 DIFF: https://github.com/llvm/llvm-project/commit/47625fea5e376082fca65d0ac644f07957605d86.diff LO

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/erichkeane commented: I think this generally makes a lot of sense, I have 1 nit (plus a bunch of the 'bool' comments without the = sign that @shafik suggested, but were closed without comment), otherwise LGTM. https://github.com/llvm/llvm-project/pull/66222 _

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -221,6 +221,15 @@ ExprResult Parser::ParseConstantExpression() { return ParseConstantExpressionInExprEvalContext(NotTypeCast); } +ExprResult Parser::ParseArrayBoundExpression() { + EnterExpressionEvaluationContext ConstantEvaluated( + Actions, Sema::ExpressionEvalua

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

AaronBallman wrote: > > I've reverted the changes in > > [9243b1b](https://github.com/llvm/llvm-project/commit/9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac), > > but you should handle the revert yourself next time because you have > > commit privileges and it's possible the person requesting a rev

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

AaronBallman wrote: > > I've reverted the changes in > > [9243b1b](https://github.com/llvm/llvm-project/commit/9243b1bfdbf4c8b8f3f8c8e45b57f784311adaac), > > but you should handle the revert yourself next time because you have > > commit privileges and it's possible the person requesting a rev

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lhames added a comment. lsan disabled in 47625fea5e37 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 __

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 557415. void added a comment. Use CBA as an acronym of CountedByAttribute instead of EBA, which is oldspeak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: cla

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. The GitHub repo with this and the `counted_by` change: https://github.com/bwendling/llvm-project/tree/array-bounds-remarks-with-counted-by Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144136/new/ https://reviews.llvm.org/D14

[clang] b4a8999 - Revert "[test][clang-repl][Orc] Lsan report workaround"

Author: Lang Hames Date: 2023-09-27T11:44:33-07:00 New Revision: b4a89a5edf08af9e03324274ebdce7e032ce URL: https://github.com/llvm/llvm-project/commit/b4a89a5edf08af9e03324274ebdce7e032ce DIFF: https://github.com/llvm/llvm-project/commit/b4a89a5edf08af9e03324274ebdce7e032ce.diff LO

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

AaronBallman wrote: > > We could maybe presume glibc on ELF targets > > Isn't that part of the triple? `aarch64-linux-gnu` gnu -> glibc (as opposed > to `aarch64-linux-musl` -> musl, or `aarch64-linux-android` -> bionic) Oh -- I wasn't aware we tracked that in the triple, that's awesome! I'll

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 9c8e6c71084e1f0e7a96987b7aa2d251b02bea48 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module b

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

aheejin wrote: > There's no difference between "doing nothing with respect to it" and > "silently rejecting", it's the same thing. The wasm backend understands > neither --xcoff-traceback-table, --trap-unreachable, _or_ > --no-trap-after-noreturn (the fact that --no-trap-after-noreturn affects

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,78 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Modify BoundsSan to improve debuggability (PR #65972)

oskarwirga wrote: @vitalybuka Thank you for reviewing! Can you merge this? I don't have write access (yet!) https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/67592 None >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,78 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

https://github.com/kparzysz-quic approved this pull request. https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. Another test that failed: compiler-rt/test/tsan/signal_thread.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits mai

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

https://github.com/leo-ard created https://github.com/llvm/llvm-project/pull/67594 This PR fixes #55013 : the max intrinsics is not generated for this simple loop case : https://godbolt.org/z/hxz1xhMPh. This is caused by a ICMP not being folded into a select, thus not generating the max intrin

[clang-tools-extra] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66034 >From 7a357059d3ca78afcb02e33a6afce225029a3836 Mon Sep 17 00:00:00 2001 From: antonrydahl Date: Mon, 11 Sep 2023 17:06:41 -0700 Subject: [PATCH 1/3] [libc][libm][GPU] Add missing vendor entrypoints to the GP

[clang] [SCCP] [Transform] Adding ICMP folding for zext and sext in SCCPSolver (PR #67594)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5ffbdd9ed5fb719b354e4a46acc8737c5b624f94 399f9d64cfde0761ac8278dd05ba704d879b1f5a --

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

sbc100 wrote: > But `--no-trap-after-noreturn` didn't exist before, so there was no way to > specify that from the command line. You _created_ it, originally in this PR, > and then the split-off PR in #67051. If this is a bugfix, it sounds like you > are fixing a bug of your own making. I thi

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

sbc100 wrote: > But `--no-trap-after-noreturn` didn't exist before, so there was no way to > specify that from the command line. You _created_ it, originally in this PR, > and then the split-off PR in #67051. If this is a bugfix, it sounds like you > are fixing a bug of your own making. I thi

[clang] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5ffbdd9ed5fb719b354e4a46acc8737c5b624f94 78c5f2e9526cdafe2ef89fa059b7a710ae77ff22 --

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -; wasm

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

https://github.com/HazardyKnusperkeks approved this pull request. Sorry you have to ping. I had some downtime on my mailserver and did not receive github mails for a week. https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cf

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557417. chaitanyav added a comment. Add parentheses to the conditional expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.

[clang] Introduce paged vector (PR #66430)

@@ -501,7 +502,7 @@ class ASTReader /// /// When the pointer at index I is non-NULL, the declaration with ID /// = I + 1 has already been loaded. - std::vector DeclsLoaded; + llvm::PagedVector DeclsLoaded; ktf wrote: I will resolve this comment for now

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/3] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

<    1   2   3   4   5   >