[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/66576 >From 209a8f9c06a7633737e9f022bc4e61d580ad95e7 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 16 Sep 2023 12:32:21 + Subject: [PATCH 1/4] [libcxx] Allow string to use SSO in constant evaluation. P

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/66576 >From 209a8f9c06a7633737e9f022bc4e61d580ad95e7 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 16 Sep 2023 12:32:21 + Subject: [PATCH 1/4] [libcxx] Allow string to use SSO in constant evaluation. P

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

@@ -1969,7 +1955,8 @@ private: allocator_type __a = __str.__alloc(); auto __allocation = std::__allocate_at_least(__a, __str.__get_long_cap()); __begin_lifetime(__allocation.ptr, __allocation.count); -

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

@@ -1746,26 +1747,8 @@ private: #endif // _LIBCPP_STD_VER >= 20 } -_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void __default_init() { -__r_.first() = __rep(); -if (__libcpp_is_constant_evaluated()) { -size_type __sz = __recommend(0)

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

@@ -880,7 +880,7 @@ public: _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string() _NOEXCEPT_(is_nothrow_default_constructible::value) : __r_(__default_init_tag(), __default_init_tag()) { -__default_init(); +__r_.first() = __rep();

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

@@ -1969,7 +1955,8 @@ private: allocator_type __a = __str.__alloc(); auto __allocation = std::__allocate_at_least(__a, __str.__get_long_cap()); __begin_lifetime(__allocation.ptr, __allocation.count); -

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

@@ -1746,26 +1747,8 @@ private: #endif // _LIBCPP_STD_VER >= 20 } -_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void __default_init() { -__r_.first() = __rep(); -if (__libcpp_is_constant_evaluated()) { -size_type __sz = __recommend(0)

[clang] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

https://github.com/danix800 created https://github.com/llvm/llvm-project/pull/67458 1. fix crash on 'default' assoc which has no TypeSourceInfo (nullptr); 2. improve equivalency comparison on control expr & associated exprs. >From e411aa494c09a8f412ee90f302504cd469ef1283 Mon Sep 17 00:00:00 200

[clang] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

llvmbot wrote: @llvm/pr-subscribers-clang Changes 1. fix crash on 'default' assoc which has no TypeSourceInfo (nullptr); 2. improve equivalency comparison on control expr & associated exprs. --- Full diff: https://github.com/llvm/llvm-project/pull/67458.diff 2 Files Affected: - (modifie

[clang] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/67458 >From 35bdb04db16c79d68dbe6522d01a0a08b2840d69 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 27 Sep 2023 01:01:06 +0800 Subject: [PATCH] [StructuralEquivalence] fix crash & improve comparing on GenericSelec

[clang] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 64b1fbb3bd03531749792bfb20526c0a0dc07838 e411aa494c09a8f412ee90f302504cd469ef1283 --

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

https://github.com/sbc100 created https://github.com/llvm/llvm-project/pull/67459 Enable nontrapping-fptoint in -mcpu=generic. This makes this feature enabled by default. This feature is part of [finished proposals], and all major wasm engines support it. [finished proposals]: https://githu

[clang] [StructuralEquivalence] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

https://github.com/danix800 edited https://github.com/llvm/llvm-project/pull/67458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

llvmbot wrote: @llvm/pr-subscribers-mc Changes Enable nontrapping-fptoint in -mcpu=generic. This makes this feature enabled by default. This feature is part of [finished proposals], and all major wasm engines support it. [finished proposals]: https://github.com/WebAssembly/proposals/bl

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

sbc100 wrote: @kripken @dschuff @sunfishcode, can you remember why we didn't include this is part of https://reviews.llvm.org/D125728 and https://reviews.llvm.org/D125729? Has the landscape changed enough since then that we can/should land this now? https://github.com/llvm/llvm-project/pull/

[clang] [StructuralEquivalence] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/67458 >From 9bf05ae5cd69fb99e1978cdc766f8392f92626c3 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 27 Sep 2023 01:01:06 +0800 Subject: [PATCH] [StructuralEquivalence] fix crash & improve comparing on GenericSelec

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

probinson added a comment. Hi @rsmith, > these two different templates would have the same mangling: template T returnit() {return I;}; template T returnit() { return I; } I tried compiling `long foo() { return returnit(); }` with these two templates, and got different manglings. `_Z8re

[clang] [StructuralEquivalence] fix crash & improve comparing on GenericSelectionExpr (PR #67458)

@@ -247,6 +247,20 @@ class StmtComparer { bool IsStmtEquivalent(const GenericSelectionExpr *E1, const GenericSelectionExpr *E2) { +if (!IsStructurallyEquivalent(Context, tmroeder wrote: Could you please add comments to the new ch

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

@@ -453,6 +453,8 @@ AIX Support WebAssembly Support ^^^ +The -mcpu=generic configuration now enables -nontrapping-fptoint. This +proposals are standardized and available in all major engines. kripken wrote: ```suggestion proposal is standardiz

[clang] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/66401 >From 4a3211750ede9d375dedc676e2cfb8bc3924aa0b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Wed, 13 Sep 2023 20:58:25 + Subject: [PATCH 1/4] Support lowering of hostShared in gpu.alloc op --- .../Conv

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. In D147655#4650964 , @probinson wrote: > Hi @rsmith, > >> these two different templates would have the same mangling: > > template T returnit() {return I;}; > template T returnit() { return I; } > > I tried compiling `long

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

cjdb wrote: This doesn't really fix the problem, it just shuffles it around. I expect people with blue(ish) terminals will experience the same issue after this is applied, so we ought to try and detect what colours to print out, and then have compatible themes. https://github.com/llvm/llvm-pr

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

https://github.com/jp4a50 updated https://github.com/llvm/llvm-project/pull/66755 >From e07d263a37ef37a21bb5cf424b14be83088eed3d Mon Sep 17 00:00:00 2001 From: Jon Phillips Date: Tue, 19 Sep 2023 10:29:57 +0100 Subject: [PATCH 1/3] [clang-format] Disable OuterScope lambda indentation behaviour

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

https://github.com/pizzud created https://github.com/llvm/llvm-project/pull/67467 This check detects moves of the contents of a shared pointer rather than the pointer itself. Other code with a reference to the shared pointer is probably not expecting the move. The set of shared pointer classe

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: Extracted the shared_ptr parts to https://github.com/llvm/llvm-project/pull/67467. I'll continue the unique_ptr portion here and respond to those comments later today. https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mail

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: Extracted the shared_ptr parts to https://github.com/llvm/llvm-project/pull/67467. I'll continue the unique_ptr portion here and respond to those comments later today. https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mail

[clang] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

nbpatel wrote: Done. https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 4b371d40d74d6297bdb5ecbe2eae0573e20d0569 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/5] [ClangRepl] Type Directed Code Completion Differential Revision:

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 4b371d40d74d6297bdb5ecbe2eae0573e20d0569 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/6] [ClangRepl] Type Directed Code Completion Differential Revision:

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

MaskRay wrote: > Reading the linked bugs, it's not clear that removing this would've helped > all these issues all that much and it introduces a bunch of toil. So maybe we > don't want to do this at all? But if we do, please put it behind a dedicated > warning flag. Clang PCH generation prefe

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

vitalybuka wrote: https://lab.llvm.org/buildbot/#/builders/70/builds/44561/steps/7/logs/stdio https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

dyung wrote: Also caused some test failures (this bot uses GCC to build which is why it didn't hit the compilation failure): https://lab.llvm.org/buildbot/#/builders/247/builds/9484 https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mail

[clang] 50abfc4 - Revert "Diagnose problematic uses of constructor/destructor attribute (#67360)"

Author: Aaron Ballman Date: 2023-09-26T14:05:27-04:00 New Revision: 50abfc4298980fc219c7d70ca2567c61e856b614 URL: https://github.com/llvm/llvm-project/commit/50abfc4298980fc219c7d70ca2567c61e856b614 DIFF: https://github.com/llvm/llvm-project/commit/50abfc4298980fc219c7d70ca2567c61e856b614.diff

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr, TargetSpecificAttr { let Documentation = [ArmMveStrictPolymorphismDocs]; } -def NoUniqueAddress : InheritableAttr, TargetSpecificAttr { - let Spellings = [CXX11<"", "no_unique_address", 201803>]; +def NoUniq

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

AaronBallman wrote: I've reverted in 50abfc4298980fc219c7d70ca2567c61e856b614 due to bots going red, I think we may need to make priority-related issues a warning rather than an error. https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits m

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/66496 >From 437c41f418be8a812229acc3573ebba688832ad5 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Fri, 15 Sep 2023 12:08:04 +0100 Subject: [PATCH] [NVPTX] Add support for maxclusterrank in launch_bounds Since S

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139 >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents chec

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139 >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents chec

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,23 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Given a smart pointer containing a movable type, such as a pizzud wrote: Done. https://github

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,23 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Given a smart pointer containing a movable type, such as a pizzud wrote: Done. https://github

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 557368. AlexVlx added a comment. Use double dash flags exclusively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSupport.rst clang/docs/ReleaseNotes.rst Index: clang/docs/Relea

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139 >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents chec

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139 >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents chec

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Predefined macros for float128 support (PR #67196)

https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/67196 >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH 1/3] [clang] Predefined macros for float128 support --- clang/lib/

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

zmodem wrote: > Having a `-Wdeprecated-include-gch` looks good to me. But do we intend to remove it later? That will break the drop-in ability of Clang, and probably a lot of people's builds. > The inconvenience probing .gch happens when GCC and Clang .pch files are > mismatched To solve thi

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: After looking at the various comments (thanks all!) it feels like the consensus was: - don't suggest fixes (done) - move shared_ptr out to its own check (done in #67467 ) - be more precise in both language and implementation Is there a reasonable way to detect expensive moves? Loo

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

pizzud wrote: After looking at the various comments (thanks all!) it feels like the consensus was: - don't suggest fixes (done) - move shared_ptr out to its own check (done in #67467 ) - be more precise in both language and implementation Is there a reasonable way to detect expensive moves? Loo

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

https://github.com/sbc100 updated https://github.com/llvm/llvm-project/pull/67459 >From 64d9d8eb1da9f275cde47bd92c39e600e5a2f9b3 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Tue, 26 Sep 2023 09:55:59 -0700 Subject: [PATCH] [WebAssembly] Update generic CPU configuration to include nontrapping

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

https://github.com/sbc100 resolved https://github.com/llvm/llvm-project/pull/67459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Update generic CPU configuration to include nontrapping-fptoint (PR #67459)

sbc100 wrote: Oh I see I think the issue was Safari: https://webassembly.org/roadmap/. Looks like this requires Safari 15 :( https://github.com/llvm/llvm-project/pull/67459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

AaronBallman wrote: There are six failures I've found, three in tests and three in source: Source: * https://github.com/llvm/llvm-project/blob/ebfea261e6a28e0ba33f437476202a25212b2d34/compiler-rt/lib/fuzzer/afl/afl_driver.cpp#L112 * https://github.com/llvm/llvm-project/blob/ebfea261e6a28e0ba33

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9796,27 +9796,34 @@ X86InstrInfo::insertOutlinedCall(Module &M, MachineBasicBlock &MBB, return It; } -void X86InstrInfo::buildClearRegister(Register Reg, - MachineBasicBlock &MBB, +void X86InstrInfo::buildClearRegister(Register Reg,

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

david-xl wrote: The change looks good to me, but wait for other reviewers to chime in as well. Also a good idea to run tests with sanitizers on. https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66222 >From 44867abb2e1c0c34963229ec93b0d1d71aa33db5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 13 Sep 2023 17:36:39 +0200 Subject: [PATCH 1/3] [Clang] Handle consteval expression in array bounds expres

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/67396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

tbaederr wrote: I know, this only fixes the problem in the vast majority of cases. I don't know of any tool implementing dynamic background color checking so it can adjust the foreground color though. This is a one-liner that fixes the problem on terminals with a dark background and the solut

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff feb7b1914d513c709b9e024dfed709bb889cc853 39a76d2db07f4c6eda9a0227da28d575553f7f6f --

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff feb7b1914d513c709b9e024dfed709bb889cc853 39a76d2db07f4c6eda9a0227da28d575553f7f6f --

[clang] f8aab28 - [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

Author: Vladislav Dzhidzhoev Date: 2023-09-26T23:07:29+04:00 New Revision: f8aab289b5549086062588fba627b0e4d3a5ab15 URL: https://github.com/llvm/llvm-project/commit/f8aab289b5549086062588fba627b0e4d3a5ab15 DIFF: https://github.com/llvm/llvm-project/commit/f8aab289b5549086062588fba627b0e4d3a5ab1

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8aab289b554: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Changed prior to commit: https:

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b26157edf08184f2620b3df95048a97a1658c021 4b62211b22950a9bdd3764093f6716d0f792469e --

[clang] [clang][NFC] Preprocessor only needs const LangOptions (PR #66874)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/66874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/4] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/4] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

MaskRay wrote: > > Having a `-Wdeprecated-include-gch` looks good to me. > > But do we intend to remove it later? That will break the drop-in ability of > Clang, and probably a lot of people's builds. > > > The inconvenience probing .gch happens when GCC and Clang .pch files are > > mismatche

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

MaskRay wrote: I haven't looked closely, but the patch made constructor with priority 0~100 an error? ``` error: 'destructor' attribute requires integer constant between 101 and 65535 inclusive ``` I think we should just use a warning to discourage user programs to use 0~100. Compiler runtime

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

erichkeane wrote: I think we're going to be stuck with 'warning-as-default-error' here, and let compiler-rt and tests/etc opt-out. I realize that makes the error not as effective, but it is really the one 'good' way for the 'implementation' in this case to handle itself. https://github.com/l

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 47392e5996cccada1d638495a9376b0430142c8c Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/2] Introduce PagedVector class

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

cjdb wrote: > This is a one-liner that fixes the problem on terminals with a dark > background and the solution also works on light backgrounds. So, basically > all of them. Before approving this change, I want confirmation that it doesn't adversely impact popular themes. The Tomorrow Night B

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

Prabhuk updated this revision to Diff 557372. Prabhuk added a comment. Removed IsIntegratedAssemblerDefault. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159541/new/ https://reviews.llvm.org/D159541 Files: clang/lib/Basic/Targets.cpp clang/li

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

vvereschaka wrote: @arichardson here is a problem with your changes when building the libraries on the windows cross toolchain builders * https://lab.llvm.org/buildbot/#/builders/60/builds/14086 * https://lab.llvm.org/buildbot/#/builders/119/builds/15283 https://lab.llvm.org/buildbot/#/builde

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

vvereschaka wrote: @arichardson here is a problem with your changes when building the libraries on the windows cross toolchain builders * https://lab.llvm.org/buildbot/#/builders/60/builds/14086 * https://lab.llvm.org/buildbot/#/builders/119/builds/15283 https://lab.llvm.org/buildbot/#/builde

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -699,7 +700,7 @@ class SourceManager : public RefCountedBase { /// /// Negative FileIDs are indexes into this table. To get from ID to an index, /// use (-ID - 2). - SmallVector LoadedSLocEntryTable; + llvm::PagedVector LoadedSLocEntryTable; ktf wrot

[clang] [clang] Predefined macros for float128 support (PR #67196)

https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/67196 >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH 1/3] [clang] Predefined macros for float128 support --- clang/lib/

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

probinson added a comment. > You need to do `returnit`. Doh! Thanks. Those two instantiations could have different function bodies, but would have the same mangled name. Got it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147655/new/ https://re

[clang] Introduce paged vector (PR #66430)

@@ -501,7 +502,7 @@ class ASTReader /// /// When the pointer at index I is non-NULL, the declaration with ID /// = I + 1 has already been loaded. - std::vector DeclsLoaded; + llvm::PagedVector DeclsLoaded; ktf wrote: I actually tried to change those as

<    1   2   3   4   5   >