[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

orcguru wrote: I saw comments being folded, paste here for notice, sorry about the duplication: So I did have another version which can essentially remove the assert check with some side effects: (1) It did generated extra external symbol reference, which looks like no harm with simple HelloW

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/67331 >From 988dcf4f568a58d9b1127b2adf8890a7c7867ac5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Mon, 25 Sep 2023 15:37:34 +0200 Subject: [PATCH] [clang] Fix pretty-printing assume_aligned attributes Inside `w

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9f276d4ddd0efa2e323d674a35317c253ab66d58 67e19382fb45fe5e06a5c8de2e7b1434c8b1c68f --

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie added a comment. @steakhal gentle ping for one last round of reviews CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158156/new/ https://reviews.llvm.org/D158156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

chenzheng1030 wrote: > Is it possible that we fix the hack implementation with some future version > (I will open an issue and work on it afterwards)? How about let's move on > with current approach? > @amy-kwan @stephenpeckham @bzEq @chenzheng1030 Appreciate your comments. > Thank you! I am

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

chenzheng1030 wrote: The code formatting check fails. https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

mstorsjo wrote: > But even regardless of #67201, the intended way to use the libc++ test suite > is to create a `.cfg.in` file that suits your needs if the general ones > don't, not to add more configuration options to the general ones. IMO, I think this is something I fundamentally disagree w

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67095 >From 174144b3d2101964a438a22644cbfa4c2314700b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 22 Sep 2023 08:42:05 +0200 Subject: [PATC

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67095 >From 174144b3d2101964a438a22644cbfa4c2314700b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 22 Sep 2023 08:42:05 +0200 Subject: [PATC

[clang] [X86][FP16] Add missing handling for FP16 constrained cmp intrinsics (PR #67400)

https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/67400 None >From 08a386acd5e14a7af905ae3ea819e5d29d84e4c1 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Tue, 26 Sep 2023 16:07:17 +0800 Subject: [PATCH] [X86][FP16] Add missing handling for FP16 constrained cmp

[clang] [clang][RISCV] Fix the condition of checking signature in getIndex (PR #67403)

https://github.com/jacquesguan created https://github.com/llvm/llvm-project/pull/67403 The current condition causes assert failing if try to add a new vendor vector file which only contains the same type signature. >From 3ad50442210c7303f0ac55339db778aa777532c8 Mon Sep 17 00:00:00 2001 From: J

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [X86][FP16] Add missing handling for FP16 constrained cmp intrinsics (PR #67400)

https://github.com/RKSimon approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/vgvassilev unresolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/FreddyLeaf created https://github.com/llvm/llvm-project/pull/67410 None >From 3ae0fa2592d3a11dd084d3aefb54c26819016781 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Tue, 26 Sep 2023 16:44:01 +0800 Subject: [PATCH] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

kasuga-fj wrote: > Do we have any Github workflow documentation that mentions we shouldn't > force-push to update PRs? According to the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes), we should generally avoid rebasing and pushing force. Bu

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

FreddyLeaf wrote: This PR is to align with icc: https://godbolt.org/z/EzbfzTrzr We can modify intrinsic guide if required. intel.com/SDM shows: ``` CMPSD xmm1, xmm2/m64, imm8 SSE2: Compare low double-precision floating-point value in xmm2/m64 and xmm1 using bits 2:0 of imm8 as comparison predi

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7675f541f75baa20e8ec007cd625a837e89fc01f 3ae0fa2592d3a11dd084d3aefb54c26819016781 --

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/67410 >From 3ae0fa2592d3a11dd084d3aefb54c26819016781 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Tue, 26 Sep 2023 16:44:01 +0800 Subject: [PATCH 1/2] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

philnik777 wrote: Assuming that Clang doesn't plan on optimizing anything based on this, I think it should be fine to just silence the warning. We could also add a `__datasizeof` builtin in a separate patch if we want. That would probably be less error-prone and cheaper than our current soluti

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

prj- wrote: Pinging @owenca. https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

https://github.com/domin144 created https://github.com/llvm/llvm-project/pull/67412 When the FPU was selected with "+(no)fp(.dp)" extensions in "-march" or "-mcpu" options, the FPU used for multilib selection was still the default one for given architecture or CPU. From 4cc2328982cc8260263aa8

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,39 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,38 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,39 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,39 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

owenca wrote: > Pinging @owenca. Waiting for one of @mydeveloperday @HazardyKnusperkeks @rymiel https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/67410 >From 3ae0fa2592d3a11dd084d3aefb54c26819016781 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Tue, 26 Sep 2023 16:44:01 +0800 Subject: [PATCH 1/3] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

orcguru wrote: > The code formatting check fails. That is intentional: https://github.com/llvm/llvm-project/pull/66316#discussion_r1333195506 https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

@@ -4742,6 +4742,125 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

@@ -4742,6 +4742,125 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/RKSimon commented: No strong objections, but I think the documentation needs to be tweaked to better explain SSE vs AVX handling. https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 31631d3 - [X86][FP16] Add missing handling for FP16 constrained cmp intrinsics (#67400)

Author: Phoebe Wang Date: 2023-09-26T19:27:57+08:00 New Revision: 31631d307fe065966c512f8383948fafa23a5bd8 URL: https://github.com/llvm/llvm-project/commit/31631d307fe065966c512f8383948fafa23a5bd8 DIFF: https://github.com/llvm/llvm-project/commit/31631d307fe065966c512f8383948fafa23a5bd8.diff L

[clang] [X86][FP16] Add missing handling for FP16 constrained cmp intrinsics (PR #67400)

https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/67400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/2] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/3] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/4] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/5] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/6] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

nico wrote: Can we add a dedicated `-Wdeprecated-gch` diag group or something for this? This is a very disruptive change, and it'd be good if we didn't have to disable all deprecation warnings while we rearrange things. Reading the linked bugs, it's not clear that removing this would've helped

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

FreddyLeaf wrote: > No strong objections, but I think the documentation needs to be tweaked to > better explain SSE vs AVX handling. I have an idea to show two results for the `_mm_cmp_sd`, one's CPUID is SSE2, the other one's is AVX. https://github.com/llvm/llvm-project/pull/67410 __

[clang] [clang analysis][NFCI] Preparatory work for D153131. (PR #67420)

https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/67420 This was ported over from phabricator. Review https://reviews.llvm.org/D153131. >From 3581fc00f690194ac4bac631311ecdb18593b7ba Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Tue, 26 Sep 2023 14:02:44

[clang] [clang analysis][NFCI] Preparatory work for D153131. (PR #67420)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This was ported over from phabricator. Review https://reviews.llvm.org/D153131. --- Full diff: https://github.com/llvm/llvm-project/pull/67420.diff 1 Files Affected: - (modified) clang/lib/Analysis/ThreadSafety.cpp (+72-61) `

[clang] 39f36d5 - [Driver] Give warn_drv_include_probe_gch a dedicated flag

Author: Hans Wennborg Date: 2023-09-26T14:14:37+02:00 New Revision: 39f36d5d5c88f49eaa946a3ee9ef887c04275a33 URL: https://github.com/llvm/llvm-project/commit/39f36d5d5c88f49eaa946a3ee9ef887c04275a33 DIFF: https://github.com/llvm/llvm-project/commit/39f36d5d5c88f49eaa946a3ee9ef887c04275a33.diff

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67422 Fixed #67407. >From 1c74983f9d2a16ab26d64624448df89e5fff87c4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 26 Sep 2023 05:17:25 -0700 Subject: [PATCH] [clang-format] Fix a bug in NamespaceEndCommentsFixer F

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From c22ccc3153ccaac0e97f7ac41349fcc382508884 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixed #67407. --- Full diff: https://github.com/llvm/llvm-project/pull/67422.diff 2 Files Affected: - (modified) clang/lib/Format/NamespaceEndCommentsFixer.cpp (+2-2) - (modified) clang/unittests/Format/NamespaceEndCommentsFixerT

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

zmodem wrote: > Can we add a dedicated -Wdeprecated-gch diag group or something for this? I gave it a flag in 39f36d5d5c88f49eaa946a3ee9ef887c04275a33 > (not sure what projects actually do this with Clang) Turns out Chromium (and anyone else using gn) does: https://crbug.com/1486799 And probab

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

zmodem wrote: As an archaeological note, the gch probing was added a long time ago in a2aedc69435dd430925e77022cbd26cc51e30982 with the motivation > It's wonky, but we include looking for .gch so we can support seamless > replacement into a build system already set up to be generating .gch fil

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

AaronBallman wrote: > Should they be valid for `constexpr` functions? Sure, but perhaps not for `consteval` functions. A `constexpr` function can be deferred to runtime, whereas a `consteval` one cannot. WDYT? https://github.com/llvm/llvm-project/pull/67360

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/kwk resolved https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From c22ccc3153ccaac0e97f7ac41349fcc382508884 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/2] Introduce PagedVector class

[clang] [libc++] P2770R0: "Stashing stashing iterators for proper flattening" (PR #66033)

https://github.com/JMazurkiewicz updated https://github.com/llvm/llvm-project/pull/66033 >From bf7096f8f435268fd830c27056e2f24564f4356b Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Fri, 8 Sep 2023 18:20:59 +0200 Subject: [PATCH 1/5] [libc++] P2770R0: "Stashing stashing iterators for

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

@@ -4742,6 +4742,125 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 47392e5996cccada1d638495a9376b0430142c8c Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

@@ -4742,6 +4742,125 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] 166074e - [clang analysis][NFCI] Preparatory work for D153131. (#67420)

Author: Clement Courbet Date: 2023-09-26T15:05:14+02:00 New Revision: 166074eff2e9a5f79b791f1cc9b641a4e2968616 URL: https://github.com/llvm/llvm-project/commit/166074eff2e9a5f79b791f1cc9b641a4e2968616 DIFF: https://github.com/llvm/llvm-project/commit/166074eff2e9a5f79b791f1cc9b641a4e2968616.dif

[clang] [clang analysis][NFCI] Preparatory work for D153131. (PR #67420)

https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/67420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added a comment. Thanks for the review. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2304-2305 + CFGBlockInfo &Initial = BlockInfo[CFGraph->getEntry().getBlockID()]; + CFGBlockInfo &Final = BlockInfo[CFGraph->getExit().getBlockID()]; + aaronpuche

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 557354. courbet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/include/clang/Analysis/Analyses/ThreadSafety.h clang/include/

[clang] [clang analysis][thread-safety] Handle return-by-reference... (PR #67428)

https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/67428 ...of guarded variables, when the function is not marked as requiring locks: ``` class Return { Mutex mu; Foo foo GUARDED_BY(mu); Foo &returns_ref_locked() { MutexLock lock(&mu); return foo;

[clang] [clang][Interp] Three-way comparisons (PR #65901)

https://github.com/erichkeane commented: This has been sitting a while, else I wouldn't feel comfortable reviewing (as I haven't been keeping up on these as much as I should have). However, I saw 1 issue with the comment I think, else I'm OK with this. So if you can fix that, I'll approve.

[clang] [clang][Interp] Three-way comparisons (PR #65901)

@@ -253,6 +253,29 @@ bool ByteCodeExprGen::VisitBinaryOperator(const BinaryOperator *BO) { return this->delegate(RHS); } + // Special case for C++'s three-way/spaceship operator <=>, which + // returns a std::strong_ordering (which is class, so doesn't have a

[clang] [clang][Interp] Three-way comparisons (PR #65901)

@@ -253,6 +253,29 @@ bool ByteCodeExprGen::VisitBinaryOperator(const BinaryOperator *BO) { return this->delegate(RHS); } + // Special case for C++'s three-way/spaceship operator <=>, which + // returns a std::strong_ordering (which is class, so doesn't have a

[clang] [clang][Interp] Three-way comparisons (PR #65901)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/65901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang analysis][thread-safety] Handle return-by-reference... (PR #67428)

llvmbot wrote: @llvm/pr-subscribers-clang Changes ...of guarded variables, when the function is not marked as requiring locks: ``` class Return { Mutex mu; Foo foo GUARDED_BY(mu); Foo &returns_ref_locked() { MutexLock lock(&mu); return foo; // BAD } Foo &returns_ref_lo

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1596,6 +1599,9 @@ bool ByteCodeExprGen::visitZeroInitializer(QualType QT, return this->emitZeroSint64(E); case PT_Uint64: return this->emitZeroUint64(E); + case

  1   2   3   4   5   >