[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

https://github.com/ldionne commented: Is there a reason why *all* configurations shouldn't be doing this? https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream &OS) { printLine(OS, Prefix, ' ', Suffix); printLine(OS, "\\*===", '-', "===*/"); OS << '\n'; + + // Print the path of source file + if (!Record.getInputFilename().empty()) +OS << "// Gen

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/5] [flang][Driver] Support -rpath, -shared, and -static in t

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

https://github.com/chapuni requested changes to this pull request. Hang on, would it expose build paths to installed headers? https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream &OS) { printLine(OS, Prefix, ' ', Suffix); printLine(OS, "\\*===", '-', "===*/"); OS << '\n'; + + // Print the path of source file + if (!Record.getInputFilename().empty()) +OS << "// Gen

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

arichardson wrote: > Is there a reason why _all_ configurations shouldn't be doing this? I think it would be good if all of them did it, the reason I didn't is that I limited it to the ones I can test locally. Seeing as there is probably CI coverage for all of the configs, should I try updatin

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67205 >From 27c0526c4b21e2b19eeeae3c23928421437b885a Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 22 Sep 2023 16:11:49 -0700 Subject: [PATCH] [libunwind] Pass -Wl,--export-dynamic on all supported pla

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

sdkrystian wrote: Ping @erichkeane & @shafik -- I left comments responding to your feedback https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar approved this pull request. Thanks for all the changes, LGTM. Please wait for a second approval before submitting if you can. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang][Interp] Fix compiling undefined templated functions (PR #67232)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

@@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -verify -fopenmp %s +// RUN: %clang_cc1 -verify -fopenmp-simd %s +// RUN: %clang_cc1 -verify -fopenmp -fopenmp-targets=nvptx64 %s + +void foo() { +} + +void bar() { +#pragma omp target ompx_bare // expected-error {{unexpected OpenMP clause 'om

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the executo

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the executo

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

jdoerfert wrote: I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One is trivial, one is probably easy, and then one with the new stuff. https://github.com/llvm/llvm-project/pull/66036 ___ cfe-commits mailing list cfe-commits@li

[clang] [libc++] Re-enable the clang_modules_include test for Objective-C++ (PR #66801)

ldionne wrote: @mordante I'm not certain what's going on here, I get ``` [...]/clang_modules_include.gen.py/__std_clang_module.compile.pass.mm:22:2: error: import of module 'std' imported non C++20 importable modules 22 | @import std; | ^ 1 error generated. ``` Can you assist? It onl

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( arichardson wrote: Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( arichardson wrote: Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -134,3 +134,8 @@ ABI Affecting Changes Build System Changes + +- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are relying on this, the new replacement + is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it persistent

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -134,3 +134,8 @@ ABI Affecting Changes Build System Changes + +- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are relying on this, the new replacement + is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it persistent

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the ex

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the ex

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

erichkeane wrote: I don't have any comments, though someone with knowledge of teh clang-tools-extra stuff would be nice to take a look, as well as someone familiar with the serialization. @AaronBallman . ALSO, this might need a release note and does this need to be mailed to the 'breaking ch

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T == "TypeSourceInf

[clang] 364757d - [clang][Interp] Fix compiling undefined templated functions (#67232)

Author: Timm Baeder Date: 2023-09-25T17:28:44+02:00 New Revision: 364757d2d5e1498239566941f8ba334e9846c53b URL: https://github.com/llvm/llvm-project/commit/364757d2d5e1498239566941f8ba334e9846c53b DIFF: https://github.com/llvm/llvm-project/commit/364757d2d5e1498239566941f8ba334e9846c53b.diff L

[clang] [clang][Interp] Fix compiling undefined templated functions (PR #67232)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

sunshaoce wrote: I am not sure how to keep only the `llvm-project//Filename` path except by hard-coding. Or how to keep only the base file name? This could limit it to within 80 characters. https://github.com/llvm/llvm-project/pull/65744 ___ cfe-

[clang] [clang][dataflow] Remove declarations from `DeclToLoc` when their lifetime ends. (PR #67300)

https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/67300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

AaronBallman wrote: > I am not sure how to keep only the `llvm-project//Filename` path except > by hard-coding. Or how about only keeping the base file name? This could > limit it to within 80 characters. I'd recommend using this API: https://github.com/llvm/llvm-project/blob/2f23666ae7e4

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

goldsteinn wrote: > I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One > is trivial, one is probably easy, and then one with the new stuff. So PR based on PR? The thing is there are dependencies between commits. My expectation is that I will push commits as they are app

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,135 @@ + +#include "clang/Frontend/CodeSnippetHighlighter.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "cla

[clang] [clang][dataflow] Avoid putting an assertion in an `LLVM_DEBUG` block. (PR #67313)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/67313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

arichardson wrote: > > I think it would be good if all of them did it, the reason I didn't is that > > I limited it to the ones I can test locally. Seeing as there is probably CI > > coverage for all of the configs, should I try updating the remaining ones? > > Yes, I think it makes sense for

[libunwind] dae7e2d - [libunwind] Pass -Wl,--export-dynamic on all supported platforms (#67205)

Author: Alexander Richardson Date: 2023-09-25T16:42:08+01:00 New Revision: dae7e2da795b262837007dc96d7681b819376382 URL: https://github.com/llvm/llvm-project/commit/dae7e2da795b262837007dc96d7681b819376382 DIFF: https://github.com/llvm/llvm-project/commit/dae7e2da795b262837007dc96d7681b81937638

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,135 @@ + +#include "clang/Frontend/CodeSnippetHighlighter.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "cla

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. Note we have a second crash linked to this PR: https://github.com/llvm/llvm-project/issues/67173#issuecomment-1733647699 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 __

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

jdoerfert wrote: > > I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One > > is trivial, one is probably easy, and then one with the new stuff. > > So PR based on PR? The thing is there are dependencies between commits. My > expectation is that I will push commits as th

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

ldionne wrote: You could add it to all the `.cfg.in` files (I think we agree that it's what makes sense in theory) and then see whether the flags change in the configurations tested in the CI. https://github.com/llvm/llvm-project/pull/67201 ___ cfe-c

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/ldionne resolved https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -314,5 +317,14 @@ def getStdFlag(cfg, std): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( +name="executor", +type=str, +default=f"{sys.executable} {Path(__file__).resolve().parent.parent.parent

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -314,5 +317,14 @@ def getStdFlag(cfg, std): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( +name="executor", +type=str, +default=f"{sys.executable} {Path(__file__).resolve().parent.parent.parent

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

https://github.com/jansvoboda11 approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/sunshaoce updated https://github.com/llvm/llvm-project/pull/65744 >From 23d0b738bf40ea44e159f4f8d7355d4d6bc0688d Mon Sep 17 00:00:00 2001 From: Shao-Ce SUN Date: Sat, 23 Sep 2023 11:38:33 +0800 Subject: [PATC

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: sunshaoce wrote: Addressed. Thanks! Now it is ``` /*===- TableGen'erated file -*- C++ -*-===*\ |**| |* ValueTypes Sou

[clang] 4cd3741 - Add documentation for the constructor and destructor attributes

Author: Aaron Ballman Date: 2023-09-25T12:22:54-04:00 New Revision: 4cd37415b24098c6822b2dbbf0e66d7e5f649624 URL: https://github.com/llvm/llvm-project/commit/4cd37415b24098c6822b2dbbf0e66d7e5f649624 DIFF: https://github.com/llvm/llvm-project/commit/4cd37415b24098c6822b2dbbf0e66d7e5f649624.diff

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

majaha wrote: > These are just non-wasm options, so they mean nothing to wasm. Yes, and using them gives no warning. > Wasm simply doesn't do anything with respect to these options and wasm is not > overriding them. --trap-unreachable is absolutely overridden, in exactly the same place as -

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/67084 >From 0e3417287a71454339cff40e20d5c2e41b728485 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 12 Sep 2023 18:31:18 -0700 Subject: [PATCH] [Driver] -include: deprecate probing .gch (#67084) `-include a.h`

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T == "TypeSourceInf

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1261 HelpText<"HIP runtime installation path, used for finding HIP version and adding HIP include path.">; +def hipstdpar : Flag<["-", "--"], "hipstdpar">, + Visibility<[ClangOption, CC1Option]>

[clang] f726da1 - [Driver] -include: deprecate probing .gch (#67084)

Author: Fangrui Song Date: 2023-09-25T09:56:28-07:00 New Revision: f726da1193baf51e0a66453cc32dcffb8a9121d4 URL: https://github.com/llvm/llvm-project/commit/f726da1193baf51e0a66453cc32dcffb8a9121d4 DIFF: https://github.com/llvm/llvm-project/commit/f726da1193baf51e0a66453cc32dcffb8a9121d4.diff

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T == "TypeSourceInf

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T == "TypeSourceInf

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6569 + + if (Args.hasArg(options::OPT_hipstdpar_interpose_alloc)) +CmdArgs.push_back("-hipstdpar-interpose-alloc"); This can use AddLastArg. CHANGES SINCE LAST ACTION

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/docs/HIPSupport.rst:266 + +- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on + phase, has the following effects: Newer long options that don't use the common prefix like `-f` are pr

[clang] e8a74f2 - [Driver] Use addOptInFlag for some HIP options. NFC

Author: Fangrui Song Date: 2023-09-25T10:05:11-07:00 New Revision: e8a74f2334ed82a422f0779d1b5dbc9550e394fb URL: https://github.com/llvm/llvm-project/commit/e8a74f2334ed82a422f0779d1b5dbc9550e394fb DIFF: https://github.com/llvm/llvm-project/commit/e8a74f2334ed82a422f0779d1b5dbc9550e394fb.diff

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: The "Index/annotate-module.m" test fails with this patch. For run line 29, the previous input is: ``` Punctuation: "#" [1:1 - 1:2] inclusion directive=Module/Sub2.h (/Users/Jan/Code/upstream-llvm/clang/test/Index/../Modules/Inputs/Module.framework/Headers/Sub2.h) Identifier:

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf created https://github.com/llvm/llvm-project/pull/67349 Differential Revision: https://reviews.llvm.org/D159128 >From 0515d9d0901bc00b26787b1774ef003d5f0b8567 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH] [ClangRepl] T

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Differential Revision: https://reviews.llvm.org/D159128 --- Patch is 20.30 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67349.diff 5 Files Affected: - (modified) clang/include/clang/Interpr

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

https://github.com/dkrupp created https://github.com/llvm/llvm-project/pull/67352 This commit renames alpha.security.taint.TaintPropagation checker to optin.security.taint.TaintPropagation. This checker was stabilized and improved by recent commits thus it's ready for production use. The che

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/5] Adding OpenMP Offloading Backend for C++ Parallel Algorith

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/5] Adding OpenMP Offloading Backend for C++ Parallel Algorith

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This commit renames alpha.security.taint.TaintPropagation checker to optin.security.taint.TaintPropagation. This checker was stabilized and improved by recent commits thus it's ready for production use. The checker is placed in the optin

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557315. efriedma added a comment. Updated with my attempt at guest exit thunks. Seems to be working for simple cases, but I'm not sure this is actually working properly (I'm still seeing LNK1000 crashes). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4650244 , @carlosgalvezp wrote: > @shafik @aaron.ballman @dblaikie > > Hello! Just wanted to check if there's any blockers for merging this patch? > We are now on Clang 18, i.e. 2 releases after the warning was intro

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

Caslyn wrote: Hi @ilya-biryukov - it seems this PR caused a couple test failures in RecursiveASTVisitorTests/ on the Fuchsia windows-x64 builder. Could you take a look to verify whether an additional fix (or revert) is needed? [clang-windows-x64-test failures](https://luci-milo.appspot.com/ui

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. Hey, Richard. It looks like your new tests are failing on Apple's buildbots, I'm guessing because the default ABI compatibility mode is older. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147655/new/ https://reviews.llv

[PATCH] D156344: Disable call to fma for soft-float

long5hot added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 90dae115b403ad7019f51154b4b771a2a2997a8f Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/2] [ClangRepl] Type Directed Code Completion Differential Revision:

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 4b371d40d74d6297bdb5ecbe2eae0573e20d0569 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/2] [ClangRepl] Type Directed Code Completion Differential Revision:

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. I've been informed that Apple's change to the default ABI compatibility mode is in our private fork, so this is not your problem; sorry for the noise. I'm not sure why we decided to do that privately; I'll see if we can fix that. Repository: rG LLVM Github Monorepo

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/67360 Functions with these attributes will be automatically called before main() or after main() exits gracefully, which means the functions should not accept arguments or have a returned value (nothing can provi

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Functions with these attributes will be automatically called before main() or after main() exits gracefully, which means the functions should not accept arguments or have a returned value (nothing can provide an argument to the call in th

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. In D147655#4650663 , @rjmccall wrote: > I've been informed that Apple's change to the default ABI compatibility mode > is in our private fork, so this is not your problem; sorry for the noise. > > I'm not sure why we decided to do

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

sam-mccall wrote: @Caslyn that failure doesn't look plausible for this commit, there's no dependency on AST matchers I'm not familiar with this buildbot, but it looks like there was an infra problem (failing install step) for a while that recently got fixed, and this test failure existed befo

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/66270 >From b934841d7fc3d3447b23a9718a38742943f76916 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Wed, 13 Sep 2023 11:09:28 -0700 Subject: [PATCH 1/2] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm t

[clang-tools-extra] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/66270 >From b934841d7fc3d3447b23a9718a38742943f76916 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Wed, 13 Sep 2023 11:09:28 -0700 Subject: [PATCH 1/2] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm t

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

tarunprabhu wrote: The buildkite [fails](https://buildkite.com/llvm-project/github-pull-requests/builds/3888#018acca9-e640-47a6-bfe8-3831aeddeb41) yet again because the link flags seem to be mapped differently. The link line generated on Windows is: `"C:\\BuildTools\\VC\\Tools\\MSVC\\14.29.3

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

haoNoQ wrote: #61826 has my data (which I unfortunately couldn't publish as-is, but the order of magnitude is, around 300 reports). My main problem with the tainted-number checkers is that they don't consider at constraints at all. Eg., this is clearly a false positive: ``` char buf[100]; size

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rjmccall added a comment. Yeah, the more I think about this, the more I think that while (1) Apple should upstream its use of an older default, regardless (2) the existence of any targets at all with an older default means that tests like this always need to be using `-fclang-abi-compat=latest`

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

haoNoQ wrote: (Yeah we still have those false positives, though `memset` isn't actually covered yet as a potential sink: https://godbolt.org/z/6h5x87vMc) https://github.com/llvm/llvm-project/pull/67352 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: Ok, the comment below seems to suggests that the built-ins buffers are not considered to be part of any TU: ```c++ bool SourceManager::isBeforeInTranslationUnit(SourceLocation LHS, SourceLocation RHS) const { // ... if (isIn

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/2] [clang][modules] Remove preloaded SLocEntries from PCM fi

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

jsonn wrote: Is this really desirable? It can actually break applications as it changes ELF semantics. https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66962 >From 1e36c68229a98ffbdb61ea652077bc3356fc177f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 16:50:48 -0700 Subject: [PATCH 1/3] [clang][modules] Remove preloaded SLocEntries from PCM fi

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

https://github.com/jansvoboda11 resolved https://github.com/llvm/llvm-project/pull/66962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/66270 >From b934841d7fc3d3447b23a9718a38742943f76916 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Wed, 13 Sep 2023 11:09:28 -0700 Subject: [PATCH 1/3] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm t

[clang] bb764ec - [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (#66270)

Author: Shafik Yaghmour Date: 2023-09-25T13:08:10-07:00 New Revision: bb764eccf8053244d64270df29c2e0bd3606f6c0 URL: https://github.com/llvm/llvm-project/commit/bb764eccf8053244d64270df29c2e0bd3606f6c0 DIFF: https://github.com/llvm/llvm-project/commit/bb764eccf8053244d64270df29c2e0bd3606f6c0.dif

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

arichardson wrote: > Is this really desirable? It can actually break applications as it changes > ELF semantics. I agree that it's not generally desirable, but this is only for the libunwind tests (which expect these semantics). https://github.com/llvm/llvm-project/pull/67205

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/6] Adding OpenMP Offloading Backend for C++ Parallel Algorith

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/6] Adding OpenMP Offloading Backend for C++ Parallel Algorith

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

https://github.com/shafik commented: Should they be valid for `constexpr` functions? https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >