[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9779a731a65fd8daee4d0a4b6945e882263b062e 159cc6b5d3cea0c4b51bd5dac7728a3cfa379f28 --

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function &F, raw_ostream &O) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the unspec

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67199 Change the attribute docs so that there is a separate one for the MSVC attribute. This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5. >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Change the attribute docs so that there is a separate one for the MSVC attribute. This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5. --- Patch is 25.37 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

amykhuang wrote: Previous commit attempt caused sphinx errors. Also, because we now have two attributes for the itanium and MSVC versions, there are two separate sections in the documentation, which I didn't realize before. https://github.com/llvm/llvm-project/pull/67199 __

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557261. Prabhuk added a comment. Add DataLayoutTest for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/Ta

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/5] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8ea7430 - [Driver] Implement ToolChain on Haiku (#66038)

Author: Brad Smith Date: 2023-09-22T18:17:44-04:00 New Revision: 8ea74302007465e4e824d420b103c2d23bd5838b URL: https://github.com/llvm/llvm-project/commit/8ea74302007465e4e824d420b103c2d23bd5838b DIFF: https://github.com/llvm/llvm-project/commit/8ea74302007465e4e824d420b103c2d23bd5838b.diff LO

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:108 +TEST(DataLayoutTest, TargetTripleManglingComponent) { + Triple TT = Triple("x86_64-unknown-uefi"); UEFI may be a better name in case we test mo

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557263. Prabhuk added a comment. Updated the test name and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/l

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67201 There is currently only limited support for passing target-specific flags (e.g. -mabi= or -march=) to the testsuites if you don't have a compiler (or wrapper script) that defaults to the expected flags. Howe

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

llvmbot wrote: @llvm/pr-subscribers-libunwind Changes There is currently only limited support for passing target-specific flags (e.g. -mabi= or -march=) to the testsuites if you don't have a compiler (or wrapper script) that defaults to the expected flags. However, some targets (e.g. RIS

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] ab78962 - [libunwind] Relax a REQUIRES on a test that passes on FreeBSD

Author: Alex Richardson Date: 2023-09-22T16:16:16-07:00 New Revision: ab7896231e176e52801702b7221bcac2f4ffbd59 URL: https://github.com/llvm/llvm-project/commit/ab7896231e176e52801702b7221bcac2f4ffbd59 DIFF: https://github.com/llvm/llvm-project/commit/ab7896231e176e52801702b7221bcac2f4ffbd59.dif

[clang] e1a5bb5 - [ORC][LLJIT] Move enable-debugger-support utility out of LLJITBuilder.

Author: Lang Hames Date: 2023-09-22T16:18:20-07:00 New Revision: e1a5bb59b91d60c0d87feb78f0e0614589a4c927 URL: https://github.com/llvm/llvm-project/commit/e1a5bb59b91d60c0d87feb78f0e0614589a4c927 DIFF: https://github.com/llvm/llvm-project/commit/e1a5bb59b91d60c0d87feb78f0e0614589a4c927.diff LO

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67205 I was trying to run the tests on FreeBSD and noticed that we weren't printing symbol names. It turns out this is because of the missing -Wl,--export dynamic flag. Instead of hardcoding the name of the flag a

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

llvmbot wrote: @llvm/pr-subscribers-libunwind Changes I was trying to run the tests on FreeBSD and noticed that we weren't printing symbol names. It turns out this is because of the missing -Wl,--export dynamic flag. Instead of hardcoding the name of the flag and only passing it for Linux

[clang] [Driver] Move assertion check before checking Output.isFilename (PR #67210)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/67210 None >From 39053d20aeec2fea1d0ef14bd9dde6a3454f83a7 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 22 Sep 2023 19:35:21 -0400 Subject: [PATCH] [Driver] Move assertion check before checking Output.isFilename

[clang-tools-extra] [compiler-rt] Implement __extendxftf2 for x86_64 (PR #66918)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/66918 >From 84cb5de329c228702da9f864312df31dc00692dc Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Wed, 20 Sep 2023 14:25:46 + Subject: [PATCH] Implement __extendxftf2 for x86_64 ---

[clang] [compiler-rt] Implement __extendxftf2 for x86_64 (PR #66918)

https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/66918 >From 84cb5de329c228702da9f864312df31dc00692dc Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Wed, 20 Sep 2023 14:25:46 + Subject: [PATCH] Implement __extendxftf2 for x86_64 ---

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/67212 This change avoids a crash in BasicValueFactory by checking the bit width of an APSInt to avoid calling getZExtValue if greater than 64-bits. This was caught by our internal, randomized test generator. Clang

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes This change avoids a crash in BasicValueFactory by checking the bit width of an APSInt to avoid calling getZExtValue if greater than 64-bits. This was caught by our internal, randomized test generator. Clang invocation c

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue &Val, QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) {

[clang] 3bca659 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2023-09-22T17:20:50-07:00 New Revision: 3bca65955668b478bcf2cac49f1731f20da8da9c URL: https://github.com/llvm/llvm-project/commit/3bca65955668b478bcf2cac49f1731f20da8da9c DIFF: https://github.com/llvm/llvm-project/commit/3bca65955668b478bcf2cac49f1731f20da8da9c.diff L

[clang] ce8c228 - Use llvm::drop_begin and llvm::drop_end (NFC)

Author: Kazu Hirata Date: 2023-09-22T17:29:10-07:00 New Revision: ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7 URL: https://github.com/llvm/llvm-project/commit/ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7 DIFF: https://github.com/llvm/llvm-project/commit/ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7.diff L

[clang] aaa79a5 - [release notes] Add forgotten case to list of changed manglings.

Author: Richard Smith Date: 2023-09-22T17:40:07-07:00 New Revision: aaa79a59317f859485d701d1eb68ac4cb213e1d1 URL: https://github.com/llvm/llvm-project/commit/aaa79a59317f859485d701d1eb68ac4cb213e1d1 DIFF: https://github.com/llvm/llvm-project/commit/aaa79a59317f859485d701d1eb68ac4cb213e1d1.diff

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4649864 , @dyung wrote: > Hi @rsmith, we have an internal test where your change seems to have changed > the mangling in C++17 mode and wanted to check if that was intentional. [...] > Are these changes in non-C++20 m

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr, TargetSpecificAttr { let Documentation = [ArmMveStrictPolymorphismDocs]; } -def NoUniqueAddress : InheritableAttr, TargetSpecificAttr { - let Spellings = [CXX11<"", "no_unique_address", 201803>]; +def NoUniq

[clang] Modify BoundsSan to improve debuggability (PR #65972)

@@ -180,19 +183,27 @@ static bool addBoundsChecking(Function &F, TargetLibraryInfo &TLI, // will create a fresh block every time it is called. BasicBlock *TrapBB = nullptr; auto GetTrapBB = [&TrapBB](BuilderTy &IRB) { -if (TrapBB && SingleTrapBB) - return TrapBB

[clang] Modify BoundsSan to improve debuggability (PR #65972)

@@ -0,0 +1,83 @@ +; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM +; What this test does is check that even with nomerge, the functions still get merged in +; compiled code as the ubsantrap call gets lowered to a single instructio

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/vitalybuka requested changes to this pull request. the code LGTM, but llvm-project/llvm/test/Instrumentation/BoundsChecking/ test is needed Maybe just extend llvm-project/llvm/test/Instrumentation/BoundsChecking/simple.ll https://github.com/llvm/llvm-project/pull/65972 _

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/sr-tream created https://github.com/llvm/llvm-project/pull/67213 Shows align for records and fields declarations in hover information. Example: ```cpp struct A { char a; short b; }; ``` For this struct hover informations shows: ``` Size: 4 bytes Align: 2 bytes ``` ![ima

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

llvmbot wrote: @llvm/pr-subscribers-clangd Changes Shows align for records and fields declarations in hover information. Example: ```cpp struct A { char a; short b; }; ``` For this struct hover informations shows: ``` Size: 4 bytes Align: 2 bytes ``` ![image](https://github.com/llvm/

[clang] [HIP] Support compressing device binary (PR #67162)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From aa1aee8695a062c472dbb9efd1e87a2ba7cdc58b Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option -f[no-]o

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

shafik wrote: This change is a lot more involved, this is on my list of things to do. See the discussion here: https://reviews.llvm.org/D150226 https://github.com/llvm/llvm-project/pull/67170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

@@ -31,6 +31,13 @@ static_assert(b, ""); constexpr int one = true; static_assert(one == 1, ""); +constexpr bool b2 = bool(); shafik wrote: There are a lot of scalars: https://eel.is/c++draft/basic.types.general#9 Can we have a test for each case? https://gi

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

https://github.com/shafik commented: Looks good but I want more tests. https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperands for inline asm (PR #67018)

topperc wrote: Does this mean the backend register allocation will pick a large LMUL register the same size as the whole tuple and force the register to be overly aligned? For example an lmul=1 seg2 tuple can use v0+v1, or v1+v2, or v2+v3, etc. But lmul=2 can only use v0+v1, v2+v3, v4+v5, etc.

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67218 None >From b00e6394bb1fe30be40e040b9201c4f3f1b28cd3 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 21:33:02 -0700 Subject: [PATCH] [clang-format][NFC] Clean up alignTrailingComments() --- clang/

[clang] e5f169f - Revert "[ORC][LLJIT] Move enable-debugger-support utility out of LLJITBuilder."

Author: Lang Hames Date: 2023-09-22T21:43:41-07:00 New Revision: e5f169f91a86af3490d9251387b3f5455941bb83 URL: https://github.com/llvm/llvm-project/commit/e5f169f91a86af3490d9251387b3f5455941bb83 DIFF: https://github.com/llvm/llvm-project/commit/e5f169f91a86af3490d9251387b3f5455941bb83.diff LO

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,102 @@ +//===- RedirectionManager.h - Redirection manager interface -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ORC] Implement basic reoptimization. (PR #67050)

https://github.com/lhames requested changes to this pull request. Just reviewing the `RedirectionManager` interface and implementation patch for now. I have some minor comments, but otherwise this is looking amazing -- thank you very much @sunho! https://github.com/llvm/llvm-project/pull/67050

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ORC] Implement basic reoptimization. (PR #67050)

@@ -0,0 +1,28 @@ +//=== RedirectionManager.cpp - Redirection manager interface in Orc ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

MaskRay wrote: > the missing -Wl,--export dynamic flag typo: missing `-` https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

@@ -10,8 +10,10 @@ link_flags = [] if @LIBUNWIND_ENABLE_CET@: compile_flags.append('-fcf-protection=full') -if '@CMAKE_SYSTEM_NAME@' == 'Linux': -link_flags.append('-Wl,--export-dynamic') +# Add -Wl,--export-dynamic if supported by the linker (this CMake variable will

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67221 Fixes #67116. >From 9fa6ed9430896ee9164260227f0791986c750f0f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 23:47:23 -0700 Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixes #67116. --- Full diff: https://github.com/llvm/llvm-project/pull/67221.diff 2 Files Affected: - (modified) clang/lib/Format/WhitespaceManager.cpp (+1-1) - (modified) clang/unittests/Format/FormatTestComments.cpp (+6) ```

<    1   2   3