[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-22 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Xcode is actively using this feature: the `.pch` extension is used for headers that are to be precompiled, the `.pch.gch` extension is used for the actual precompiled header, and Clang is expected to expand the given `-include X.pch` argument into `-include-pch X.pch.gch`.

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 requested changes to this pull request. Xcode is actively using this feature: the .pch extension is used for headers that are to be precompiled, the .pch.gch extension is used for the actual precompiled header, and Clang is expected to expand the given -include X

[clang] [Driver] -include: do not probe .gch (PR #67084)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Support compressing device binary (PR #67162)

2023-09-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/67162 Add option -f[no-]offload-compress to clang to enable/disable compression of device binary for HIP. By default it is disabled. Add option -compress to clang-offload-bundler to enable compression of offload bun

[clang] [HIP] Support compressing device binary (PR #67162)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Add option -f[no-]offload-compress to clang to enable/disable compression of device binary for HIP. By default it is disabled. Add option -compress to clang-offload-bundler to enable compression of offload bundle. By default it is

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: Is thi

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: never

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

2023-09-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. DataLayout needs a unittest in llvm/unittests/IR/DataLayoutTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] goldsteinn/ptrmask (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn created https://github.com/llvm/llvm-project/pull/67166 - [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC - [InstSimplify] Add some basic simplifications for `llvm.ptrmask` - [InstCombine] Add tests for combining `llvm.ptrmask`; NFC - [InstCombine] Make co

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Changes - [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC - [InstSimplify] Add some basic simplifications for `llvm.ptrmask` - [InstCombine] Add tests for combining `llvm.ptrmask`; NFC - [InstCombine] Make combines on `llvm.ptrmask

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
goldsteinn wrote: @nikic, think fixed all issues with `null`. Only case maybe not okay is for `llvm.ptrmask(undef, X)` -> `null`. https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9c5b38b49fa2a1a81dac78faa0a8432eff495615 7a93fe3f3dbf8c6e5afad08f0a6e880c66f34f46 --

[PATCH] D159540: [Basic] X86 backend changes for UEFI

2023-09-22 Thread Daniel Thornburgh via Phabricator via cfe-commits
mysterymath added a comment. There should also be tests for this behavior in llvm/test/CodeGen/X86. I wouldn't think it necessary to fully test the calling convention; that should already be well covered; just something in those key test files (e.g., `sse-regcall.ll`) to verify that the `uefi`

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

2023-09-22 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi @sammccall, your change seems to be causing a test failure on several bots, can you take a look and revert if you need time to investigate? TEST 'Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/8/35' FAILED ***

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-22 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + UnwindTableLevel Remove the IsIntegratedAssemble

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-22 Thread Christopher Di Bella via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: cjdb wrote: I'm okay with the change in general. https://github.com/llvm/llvm-project/pull/66514 ___

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

2023-09-22 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/67170 Casting an int into an enum is undefined behavior if the int is outside of the range of the enum. UB is not allowed in constant expressions, therefore the compiler must produce a hard error in that case.

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Casting an int into an enum is undefined behavior if the int is outside of the range of the enum. UB is not allowed in constant expressions, therefore the compiler must produce a hard error in that case. However, until now, the compiler p

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf jhuber6 wrote: Does this accidentally delete `printf`? https://github.com/llvm/llvm-projec

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf jhuber6 wrote: Does this accidentally delete `printf`? https://github.com/llvm/llvm-projec

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -126,6 +126,10 @@ set(TARGET_LIBC_ENTRYPOINTS libc.src.stdio.snprintf libc.src.stdio.vsprintf libc.src.stdio.vsnprintf +#TODO: Check if scanf can be enabled on aarch64 jhuber6 wrote: Seems like this should be tested first. https://github.co

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -126,6 +126,10 @@ set(TARGET_LIBC_ENTRYPOINTS libc.src.stdio.snprintf libc.src.stdio.vsprintf libc.src.stdio.vsnprintf +#TODO: Check if scanf can be enabled on aarch64 jhuber6 wrote: Seems like this should be tested first. https://github.co

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -9,44 +9,61 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H -#include "src/stdio/scanf_core/file_reader.h" -#include "src/stdio/scanf_core/string_reader.h" +#include "src/__support/macros/attributes.h" // For LIBC_INLINE #

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
@@ -9,44 +9,61 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H -#include "src/stdio/scanf_core/file_reader.h" -#include "src/stdio/scanf_core/string_reader.h" +#include "src/__support/macros/attributes.h" // For LIBC_INLINE #

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: The changes make sense to me overall with some nits. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: The changes make sense to me overall with some nits. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/4] [clang][modules] Move `SLocEntry` search into `ASTReader`

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also. https://g

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include "src/stdio/scanf

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
@@ -220,6 +220,20 @@ add_libc_test( libc.src.stdio.vprintf ) + +if(LLVM_LIBC_FULL_BUILD) + # In fullbuild mode, fscanf's tests use the internal FILE for other functions. + list(APPEND fscanf_test_deps + libc.src.stdio.fclose + libc.src.stdio.ferror + l

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include "src/stdio/scanf

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread Siva Chandra via cfe-commits
@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also. https://g

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67174 Implement __prefetch intrinsic. MSVC docs: https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170 Bug: https://github.com/llvm/llvm-project/issues/65405 >From c60ccb5cb84b7855b3a4a9

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes Implement __prefetch intrinsic. MSVC docs: https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170 Bug: https://github.com/llvm/llvm-project/issues/65405 --- Full diff: https://github.com/llvm/llvm-projec

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-22 Thread Alex Brachet via cfe-commits
https://github.com/abrachet updated https://github.com/llvm/llvm-project/pull/67067 >From 62f1432f09ba4844fb2e826c73ce5748c34c6daf Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Wed, 20 Sep 2023 17:55:44 -0400 Subject: [PATCH] [Fuchsia] Build with -fvisibility=default There was an issue wit

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-22 Thread Alex Brachet via cfe-commits
https://github.com/abrachet resolved https://github.com/llvm/llvm-project/pull/67067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3353f7d - Revert "[dataflow] use true/false literals in formulas, rather than variables"

2023-09-22 Thread Douglas Yung via cfe-commits
Author: Douglas Yung Date: 2023-09-22T11:43:27-07:00 New Revision: 3353f7dd3d91c9b2b6a15ba9229bee53e0cb8196 URL: https://github.com/llvm/llvm-project/commit/3353f7dd3d91c9b2b6a15ba9229bee53e0cb8196 DIFF: https://github.com/llvm/llvm-project/commit/3353f7dd3d91c9b2b6a15ba9229bee53e0cb8196.diff

[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

2023-09-22 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: To clarify, I'm not concerned about performance, but with code readability and maintainability. I realize the chain that I wrote above should not lead to recursion due to `SkipMethods::Yes` in the relevant call. I'd like to take a closer look at the problem, would you be

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

2023-09-22 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Not sure what happens with the failed job in CI, I rebased on latest trunk and ran the entire `ninja check-clang` suite and it passed successfully. Do I need some special CMake configuration flag to enable the failing test? About the patch itself - casting outside of range

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-22 Thread Alex Brachet via cfe-commits
abrachet wrote: I think the code formatting failure is because there are no source files changed in this commit. I feel fine pushing this. https://github.com/llvm/llvm-project/pull/67067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] ab82c3d - [Fuchsia] Build with -fvisibility=default (#67067)

2023-09-22 Thread via cfe-commits
Author: Alex Brachet Date: 2023-09-22T15:08:08-04:00 New Revision: ab82c3d0a8406edecfd26cb30678aab6d3eff1b7 URL: https://github.com/llvm/llvm-project/commit/ab82c3d0a8406edecfd26cb30678aab6d3eff1b7 DIFF: https://github.com/llvm/llvm-project/commit/ab82c3d0a8406edecfd26cb30678aab6d3eff1b7.diff

[clang] [Fuchsia] Build with -fvisibility=default (PR #67067)

2023-09-22 Thread Alex Brachet via cfe-commits
https://github.com/abrachet closed https://github.com/llvm/llvm-project/pull/67067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Sam McCall via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-22 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: It seems like tests are still failing because there is a double move. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-22 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: It seems like tests are still failing because there is a double move. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 3982b40f82c6cb91c9bec407cea6b7a4cdc4220e Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/9] [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

2023-09-22 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Hi @sammccall, also failed `FAIL: Clang-Unit::69` test on these builders - https://lab.llvm.org/buildbot/#/builders/86/builds/65581 - https://lab.llvm.org/buildbot/#/builders/60/builds/14027 - https://lab.llvm.org/buildbot/#/builders/119/builds/15226 Repository:

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread Florian Hahn via cfe-commits
@@ -196,8 +195,7 @@ define <16 x i8> @ptrmask_align8_ptr_align8(ptr align 8 %ptr) { ; TODO: Should be able to drop the ptrmask fhahn wrote: remove TODO now https://github.com/llvm/llvm-project/pull/67166 ___ cfe-comm

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread Florian Hahn via cfe-commits
@@ -183,8 +183,7 @@ define <16 x i8> @ptrmask_align8_ptr_align1(ptr align 1 %ptr) { ; TODO: Should be able to drop the ptrmask fhahn wrote: remove TODO now? https://github.com/llvm/llvm-project/pull/67166 ___ cfe-com

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai resolved https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] 4a55d42 - Implement [[msvc::no_unique_address]] (#65675)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T13:28:38-07:00 New Revision: 4a55d426967b9c70f5dea7b3a389e11393a4f4c4 URL: https://github.com/llvm/llvm-project/commit/4a55d426967b9c70f5dea7b3a389e11393a4f4c4 DIFF: https://github.com/llvm/llvm-project/commit/4a55d426967b9c70f5dea7b3a389e11393a4f4c4.diff LOG

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7ca8c21 - [Driver] Fix detection of libc++ with empty sysroot. (#66947)

2023-09-22 Thread via cfe-commits
Author: Sam McCall Date: 2023-09-22T22:29:25+02:00 New Revision: 7ca8c21af36acb117529e797b3d36e85a286ca47 URL: https://github.com/llvm/llvm-project/commit/7ca8c21af36acb117529e797b3d36e85a286ca47 DIFF: https://github.com/llvm/llvm-project/commit/7ca8c21af36acb117529e797b3d36e85a286ca47.diff LO

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall closed https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67147 >From aaf450faf7a26bb60de14b81fe7a661adb830273 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 22 Sep 2023 16:27:11 +0200 Subject: [PATCH] [clang][Interp] Handle CXXScalarValueInitExprs

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 3982b40f82c6cb91c9bec407cea6b7a4cdc4220e Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/9] [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
@@ -5607,6 +5607,21 @@ bool Sema::CheckRegparmAttr(const ParsedAttr &AL, unsigned &numParams) { return false; } +// Helper to get CudaArch. +static CudaArch getCudaArch(const TargetInfo &TI) { Artem-B wrote: You may need to verify that `TI->getTriple()->is

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function &F, raw_ostream &O) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the unspec

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67195 None >From d5347c906ac7db40f9b31ad0c0bcd193df453e4e Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 13:54:28 -0700 Subject: [PATCH] Fix attr docs from previous no-unique-adderss change --- cl

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 44f2db7 - Fix attr docs from previous no-unique-adderss change (#67195)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T13:55:48-07:00 New Revision: 44f2db7493454b41d2f5c81b76bd30f2f035ed31 URL: https://github.com/llvm/llvm-project/commit/44f2db7493454b41d2f5c81b76bd30f2f035ed31 DIFF: https://github.com/llvm/llvm-project/commit/44f2db7493454b41d2f5c81b76bd30f2f035ed31.diff LOG

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Previous change in https://github.com/llvm/llvm-project/pull/65675 broke the docs generation. --- Full diff: https://github.com/llvm/llvm-project/pull/67195.diff 1 Files Affected: - (modified) clang/include/clang/Basic/Attr.td (-1)

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk created https://github.com/llvm/llvm-project/pull/67196 None >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH] [clang] Predefined macros for float128 support --- clang/li

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk edited https://github.com/llvm/llvm-project/pull/67196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Expose some predefined macros for Float128 support. --- Full diff: https://github.com/llvm/llvm-project/pull/67196.diff 1 Files Affected: - (modified) clang/lib/Frontend/InitPreprocessor.cpp (+2) ``diff diff --git a/clang/lib/

[clang] 2d27bf2 - Revert "Fix attr docs from previous no-unique-adderss change (#67195)"

2023-09-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-22T14:04:16-07:00 New Revision: 2d27bf23369561e68456025aa24cb46fee130482 URL: https://github.com/llvm/llvm-project/commit/2d27bf23369561e68456025aa24cb46fee130482 DIFF: https://github.com/llvm/llvm-project/commit/2d27bf23369561e68456025aa24cb46fee130482.diff

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: The supposed doc fix (for `doc-clang-html`?) #67195 caused `error: Record `NoUniqueAddress', field `Documentation' exists but does not have a list value`. I have reverted #67195. https://github.com/llvm/llvm-project/pull/65675 ___ cfe-

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/67196 >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH 1/2] [clang] Predefined macros for float128 support --- clang/lib/

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-22 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. I tested it on a licheepi board (riscv64 debian) and all the tests passed. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67198 This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4. Reverting because this breaks sphinx documentation, and even with it fixed the format of the attribute makes the no_unique_address documentation sho

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 71f9e76 - Revert "Implement [[msvc::no_unique_address]] (#65675)" (#67198)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T14:39:00-07:00 New Revision: 71f9e7695b87298f9855d8890f0e6a3b89381eb5 URL: https://github.com/llvm/llvm-project/commit/71f9e7695b87298f9855d8890f0e6a3b89381eb5 DIFF: https://github.com/llvm/llvm-project/commit/71f9e7695b87298f9855d8890f0e6a3b89381eb5.diff LOG

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4. Reverting because this breaks sphinx documentation, and even with it fixed the format of the attribute makes the no_unique_address documentation show up twice. --- Patch is 25

<    1   2   3   >