[clang] [Driver] Some improvements for path handling on NetBSD (PR #66863)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/66863 - Make use of concat macro with various paths - Replace usage of = with SysRoot >From e5136b821a722d475797561a098cd567c5ca2f2e Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Wed, 20 Sep 2023 02:19:28 -0400 Subject

[clang] [Driver] Some improvements for path handling on NetBSD (PR #66863)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes - Make use of concat macro with various paths - Replace usage of = with SysRoot --- Full diff: https://github.com/llvm/llvm-project/pull/66863.diff 3 Files Affected: - (modified) clang/lib/Driver/ToolChains/NetBSD.cpp (+13-13) -

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

mydeveloperday wrote: I'm not sure I understand, looking at https://clang.llvm.org/docs/ClangFormatStyleOptions.html#lambdabodyindentation it seems to explicitly state it should be at the outer function scope, can you point to a github issue this is trying to solve or is this just personal p

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

https://github.com/mydeveloperday requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto &foo, const auto &bar) {\n" - " return foo.

[clang-tools-extra] [clangd] Allow --query-driver to match a dot-normalized form of the path (PR #66757)

HighCommander4 wrote: See also some existing reports we have on file about other types of normalization: * https://github.com/clangd/clangd/issues/1518 (Windows shorthands like `PROGRA~1`) * https://github.com/clangd/clangd/issues/1605 (symlinks) * https://github.com/llvm/llvm-project/is

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038 >From b34a9d04df124b9d875dc47808006c38ebb94902 Mon Sep 17 00:00:00 2001 From: X512 Date: Mon, 11 Sep 2023 20:56:02 -0400 Subject: [PATCH] [Driver] Implement ToolChain on Haiku Co-authored-by: David Karoly Co-autho

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

@@ -128,8 +253,14 @@ void Haiku::addLibCxxIncludePaths(const llvm::opt::ArgList &DriverArgs, concat(getDriver().SysRoot, "/boot/system/develop/headers/c++/v1")); } -void Haiku::addLibStdCxxIncludePaths(const llvm::opt::ArgList &DriverArgs, -

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 resolved https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LSAN][NFC] Add a new line to a log (PR #66305)

Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=, Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere ,Douglas Yung ,daisy202309 <144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere ,Mehdi Amini ,Siva Chandra ,Jonas Devlieghere , Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

cor3ntin wrote: This is neat! My biggest concerns is the handling of the keywords. It's very inaccurate and would hard to keep in sync. I think we could get `TextDiagnostic` to be constructed with a `Preprocessor` object (by modifying the various `BeginSourceFile` implementations, I think) Th

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From ef28607fec310ca190a41bc6cba25b9ba80dd75b Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 10:23:08 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

https://github.com/MaskRay requested changes to this pull request. https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

@@ -33,13 +33,33 @@ namespace sys { template using TimePoint = std::chrono::time_point; +// utc_clock and utc_time are only available since C++20. Add enough code to +// support formatting date/time in UTC. +class UtcClock : public std::chrono::system_clock {}; --

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

@@ -0,0 +1,25 @@ +// Please note the following: +// + we are checking that the first bytes of the PPA2 are 0x3 0x0 +// for C, and 0x3 0x1 for C++ +// + the label for the PPA2 seems to vary on different versions. +// We try to cover all cases, and use substitution block

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

@@ -43,6 +43,7 @@ enum class Language : uint8_t { HLSL, ///@} }; +const char *LanguageToString(Language L); MaskRay wrote: `languageToString`? This file correctly uses `functionName` unlike many other Clang files... https://github.com/llvm/llvm-project/p

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

nikic added a comment. I'm happy to sign off on the x86-64 part here, but I'm less sure about x86-32. If I understood correctly, the i128 alignment is raised there exclusively to fix the "f128 legalized to i128 libcall" case -- is there any other ABI requirement for i128 alignment on x86-32? Is

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 5ee5580985ca83ef8399e1912c87b24df8b2b85e Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Wed, 20 Sep 2023 10:25:33 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

@@ -9,20 +9,145 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace clang::driver::toolcha

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

tbaederr wrote: > My biggest concerns is the handling of the keywords. It's very inaccurate and > would hard to keep in sync. Totally agree. > I think we could get `TextDiagnostic` to be constructed with a `Preprocessor` > object (by modifying the various `BeginSourceFile` implementations,

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

@@ -50,3 +50,19 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir %s 2>&1 \

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/Naville ready_for_review https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4648634 , @nikic wrote: > I'm happy to sign off on the x86-64 part here, but I'm less sure about > x86-32. If I understood correctly, the i128 alignment is raised there > exclusively to fix the "f128 legalized to i128 li

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

brad0 wrote: > On top of that, Solaris `clang` doesn't handle `-r` correctly, passing `-e > _start -Bdynamic` to `ld`, which makes it choke... Looking at the GNU linker it seems to ignore -Bdynamic once -r is specified. Not sure how LLD handles things. The OpenBSD driver might need adjustments

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

jmmartinez wrote: @yxsamliu Is it ok if I merge this patch? https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a2046ca - [clang-format][NFC] Clean up signatures of some parser functions (#66569)

Author: Owen Pan Date: 2023-09-20T01:13:05-07:00 New Revision: a2046ca9afd575aeb458c6e5c9b720be3a35b857 URL: https://github.com/llvm/llvm-project/commit/a2046ca9afd575aeb458c6e5c9b720be3a35b857 DIFF: https://github.com/llvm/llvm-project/commit/a2046ca9afd575aeb458c6e5c9b720be3a35b857.diff LOG:

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/mstorsjo commented: This looks mostly good to me, but a few cases might need setting `CMAKE_MSVC_RUNTIME_LIBRARY` instead of the removed variable. The commit message needs improving though. This isn't related to the discussion about crt allocators at all. Instead the commit

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -30,7 +30,6 @@ set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") mstorsjo wrote: This case here seems to lack a corresponding setting of `CMAKE_MSVC_RUNTIME_LIB

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -70,10 +70,6 @@ foreach(variable ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH}) endif() endforeach() -if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") mstorsjo wrote: Same here - we should probably set `CMAKE_MSVC_RUNTIME_LIBRARY` instead of just removin

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -14,10 +14,7 @@ set(LLVM_PACKAGE_BUGREPORT @PACKAGE_BUGREPORT@) set(LLVM_BUILD_TYPE @CMAKE_BUILD_TYPE@) -set(LLVM_USE_CRT_DEBUG @LLVM_USE_CRT_DEBUG@) -set(LLVM_USE_CRT_MINSIZEREL @LLVM_USE_CRT_MINSIZEREL@) -set(LLVM_USE_CRT_RELEASE @LLVM_USE_CRT_RELEASE@) -set(LLVM_USE_CRT

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -951,7 +950,7 @@ if(LLVM_USE_SANITIZER) endif() # Prepare ASAN runtime if needed if (LLVM_USE_SANITIZER MATCHES ".*Address.*") -if (${LLVM_USE_CRT_${uppercase_CMAKE_BUILD_TYPE}} MATCHES "^(MT|MTd)$") +if (${CMAKE_MSVC_RUNTIME_LIBRARY} MATCHE

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -30,7 +30,6 @@ set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") Naville wrote: It's been set at Line 57? https://github.com/llvm/llvm-project/pull/66850 _

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -70,10 +70,6 @@ foreach(variable ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH}) endif() endforeach() -if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") Naville wrote: Same as above, maybe Line57 is enough? https://github.com/llvm/llvm-project/pull/66850 _

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -14,10 +14,7 @@ set(LLVM_PACKAGE_BUGREPORT @PACKAGE_BUGREPORT@) set(LLVM_BUILD_TYPE @CMAKE_BUILD_TYPE@) -set(LLVM_USE_CRT_DEBUG @LLVM_USE_CRT_DEBUG@) -set(LLVM_USE_CRT_MINSIZEREL @LLVM_USE_CRT_MINSIZEREL@) -set(LLVM_USE_CRT_RELEASE @LLVM_USE_CRT_RELEASE@) -set(LLVM_USE_CRT

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.h:88 + /// Returns the program. This is only needed for unittests. + Program &getProgram() const { return *P.get(); } + cor3ntin wrote: > This should return a const ref Things like `getGlob

[clang] [RISCV] Move sifive_files to riscv_files (PR #66872)

https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/66872 None >From 8de8e701d06f7c0e77d743a45db6f58f8bef9a0d Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed, 20 Sep 2023 01:23:54 -0700 Subject: [PATCH] [RISCV] Move sifive_files to riscv_files --- clang/lib/Headers/

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/DonatNagyE approved this pull request. https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/PiotrZSL approved this pull request. Clang-tidy part looking fine for me. https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -30,7 +30,6 @@ set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") mstorsjo wrote: Right, I didn't see that one. https://github.com/llvm/llvm-project/pull/66850 _

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/mstorsjo commented: Ok, the PR seems fine code-wise then - please update the commit message (PR description) and this should be fine. https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

@@ -70,10 +70,6 @@ foreach(variable ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH}) endif() endforeach() -if(WIN32) - set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") mstorsjo wrote: You mean line 91 here? Ok, that's also present elsewhere here. https://github.com/llvm/

[clang] [clang][NFC] Preprocessor only needs const LangOptions (PR #66874)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66874 NFC but requesting review since something outside of clang or downstream might break? >From 81573459077ce79d65a60310be12f01db4371e9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 20 S

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

kaz7 added a comment. In D152054#4648318 , @sandeepkosuri wrote: > @kaz7, it seems that the thread_limit is being set properly, but the > `omp_get_thread_limit()` is giving a wrong output when you enable anything > more than `-O1`. I will fix it as soo

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/66875 If we don't include riscv_vector.h, even we add the target-feature, it still can't find the intrinsic interface. >From fdf29e4b484d6d0d01e772464052a4f26376ff98 Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed,

[clang] [clang][NFC] Preprocessor only needs const LangOptions (PR #66874)

llvmbot wrote: @llvm/pr-subscribers-clang Changes NFC but requesting review since something outside of clang or downstream might break? --- Full diff: https://github.com/llvm/llvm-project/pull/66874.diff 2 Files Affected: - (modified) clang/include/clang/Lex/Preprocessor.h (+4-3) - (m

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

llvmbot wrote: @llvm/pr-subscribers-clang Changes If we don't include riscv_vector.h, even we add the target-feature, it still can't find the intrinsic interface. --- Full diff: https://github.com/llvm/llvm-project/pull/66875.diff 1 Files Affected: - (modified) clang/test/Sema/zvk-inva

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/DavidSpickett requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -4,14 +4,17 @@ // RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \ // RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix AARCH64 %} // AARCH64: All available -march extensions for AArch64 +// AARCH64: NameDesc

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -11,9 +11,10 @@ // //===--===// -#include "llvm/TargetParser/ARMTargetParser.h" #include "llvm/ADT/StringSwitch.h" +#include "llvm/Support/Format.h" #include "llvm/Support/raw_ostream.h" +#include "llvm/

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -4,14 +4,17 @@ // RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \ // RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix AARCH64 %} // AARCH64: All available -march extensions for AArch64 +// AARCH64: NameDesc

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -600,11 +601,16 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple &Triple, StringRef MArch) { llvm_unreachable("invalid arch name"); } -void ARM::PrintSupportedExtensions() { - outs() << "All available -march extensions for ARM\n\n"; +void ARM::PrintSupportedExtensi

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); DavidSpickett wrote: This can go if you just set the description of only one extension in the tests. https://g

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -210,24 +210,42 @@ static void verifyTables() { #endif } -void llvm::riscvExtensionsHelp() { - outs() << "All available -march extensions for RISC-V\n\n"; - outs() << '\t' << left_justify("Name", 20) << "Version\n"; +void llvm::getAllExtensions(StringMap &ExtMap) { + for

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string TargetStr) { std::unique_ptr TheTargetMachine( TheTarget->createTargetMachine(TargetStr, "", "", Options, std::nullopt)); const llvm::Triple &MachineTriple = TheTargetMachine->getTargetTriple(); +

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -210,24 +210,42 @@ static void verifyTables() { #endif } -void llvm::riscvExtensionsHelp() { - outs() << "All available -march extensions for RISC-V\n\n"; - outs() << '\t' << left_justify("Name", 20) << "Version\n"; +void llvm::getAllExtensions(StringMap &ExtMap) { + for

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

RKSimon wrote: For completeness the _mm_stream_sd / _mm_stream_ss SSE4A intrinsics still need updating as well: https://github.com/llvm/llvm-project/blob/59fbba94908f65eedb8bdd619e425bf97d84b2e3/clang/lib/Headers/ammintrin.h#L158C1-L158C14 https://github.com/llvm/llvm-project/pull/66310 __

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/Naville resolved https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

FreddyLeaf wrote: > For completeness the _mm_stream_sd / _mm_stream_ss SSE4A intrinsics still > need updating as well: > https://github.com/llvm/llvm-project/blob/59fbba94908f65eedb8bdd619e425bf97d84b2e3/clang/lib/Headers/ammintrin.h#L158C1-L158C14 Good catch. Seems like intrinsic guide missed

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

Krishna-13-cyber wrote: Ping. https://github.com/llvm/llvm-project/pull/65650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/Naville updated https://github.com/llvm/llvm-project/pull/66850 >From 80c5e05c69fe3eb2b1c4827eeb7b5743bd8679ee Mon Sep 17 00:00:00 2001 From: Zhang Date: Wed, 20 Sep 2023 10:28:13 +0800 Subject: [PATCH] [CMake]Fully delete the deprecated LLVM_USE_CRT* This has been deprecate

[clang] [CMake]Remove LLVM_USE_CRT* (PR #66850)

https://github.com/Naville edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

https://github.com/Naville edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

https://github.com/Naville edited https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake]Fully delete the deprecated LLVM_USE_CRT* (PR #66850)

Naville wrote: Updated the commit message @mstorsjo https://github.com/llvm/llvm-project/pull/66850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -4,14 +4,17 @@ // RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \ // RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix AARCH64 %} // AARCH64: All available -march extensions for AArch64 +// AARCH64: NameDesc

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

jacquesguan wrote: LGTM https://github.com/llvm/llvm-project/pull/66875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add missing V extensions for zvk-invalid-features.c (PR #66875)

https://github.com/jacquesguan approved this pull request. https://github.com/llvm/llvm-project/pull/66875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); cbalint13 wrote: I would leave it. It's fine for endusers to have an API with an accessor to the *full* list o

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) { TEST(TargetParserTest, ARMPrintSupportedExtensions) { std::string expected = "All available -march extensions for ARM\n\n" - "\tcrc\n\tcrypto\n\tsha2"; + "N

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

RKSimon wrote: They're AMD specific so probably not covered https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string TargetStr) { std::unique_ptr TheTargetMachine( TheTarget->createTargetMachine(TargetStr, "", "", Options, std::nullopt)); const llvm::Triple &MachineTriple = TheTargetMachine->getTargetTriple(); +

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -4,14 +4,17 @@ // RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \ // RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix AARCH64 %} // AARCH64: All available -march extensions for AArch64 +// AARCH64: NameDesc

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string TargetStr) { std::unique_ptr TheTargetMachine( TheTarget->createTargetMachine(TargetStr, "", "", Options, std::nullopt)); const llvm::Triple &MachineTriple = TheTargetMachine->getTargetTriple(); +

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); cbalint13 wrote: Regarding accesors see [these lines] (https://github.com/cbalint13/tvm/blob/4c17af1a187dee450a

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); DavidSpickett wrote: Ok but I'll refer you to MaskRay's comment there: ``` We need justification to have this A

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -22,7 +23,8 @@ struct RISCVExtensionInfo { unsigned MinorVersion; }; -void riscvExtensionsHelp(); +void getAllExtensions(StringMap &Features); DavidSpickett wrote: An external project needing something is not a reason to add methods in tree. It could be

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

https://github.com/brechtsanders created https://github.com/llvm/llvm-project/pull/66881 Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC >From b524ba27418a78a7314af53d36adefb947f2960d Mon Sep 17 00:00:00 2001 From: Brecht Sanders Date: Wed, 20 Sep 2023 11:

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

tbaederr wrote: Okay, that seems quite complex since a lexer with a preprocessor doesn't seem to return comments at all and the tokens I get are all identifiers and don't have their `kw_` state set. Provided what I'm doing isn't completely wrong of course. I'm open to suggestions of course, I

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

@@ -4,14 +4,17 @@ // RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \ // RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix AARCH64 %} // AARCH64: All available -march extensions for AArch64 +// AARCH64: NameDesc

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >