[clang-tools-extra] [clangd] Allow --query-driver to match a dot-normalized form of the path (PR #66757)

2023-09-19 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. https://github.com/llvm/llvm-project/pull/66757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesReader (PR #66769)

2023-09-19 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/66769 This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes >From e0649eedbe9f77241a7e26980aa40

[clang] [APINotes] Upstream APINotesReader (PR #66769)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes --- Patch is 71.63 KiB, truncated to 20.00 KiB below, full versi

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-09-19 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/6 >From 3ca9d8cb678a22e8c99b8a59c02209beadef208a Mon Sep 17 00:00:00 2001 From: skc7 Date: Mon, 18 Sep 2023 21:42:19 +0530 Subject: [PATCH] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone.

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

2023-09-19 Thread via cfe-commits
https://github.com/skc7 edited https://github.com/llvm/llvm-project/pull/6 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Identify post-visit state changes in the HTML logger. (PR #66746)

2023-09-19 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/66746 >From 46e47ed08dcaf2245e9c545e1e65846a6d642b16 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 19 Sep 2023 12:54:44 + Subject: [PATCH] [clang][dataflow] Identify post-visit state changes in the

[clang] [clang][dataflow] Identify post-visit state changes in the HTML logger. (PR #66746)

2023-09-19 Thread via cfe-commits
martinboehme wrote: Sorry, completely missed the fact that I had broken a test. Should be fixed now. https://github.com/llvm/llvm-project/pull/66746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] Fix math-errno issue (PR #66381)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-19 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer updated https://github.com/llvm/llvm-project/pull/65699 >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in t

[clang] a292e7e - Fix math-errno issue (#66381)

2023-09-19 Thread via cfe-commits
Author: Zahira Ammarguellat Date: 2023-09-19T09:13:02-04:00 New Revision: a292e7edf8b2fc51d3e86a96ff5dff45d16bd264 URL: https://github.com/llvm/llvm-project/commit/a292e7edf8b2fc51d3e86a96ff5dff45d16bd264 DIFF: https://github.com/llvm/llvm-project/commit/a292e7edf8b2fc51d3e86a96ff5dff45d16bd264

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-19 Thread Yusra Syeda via cfe-commits
ysyeda wrote: ping https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-19 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cf8e189 - [clang][TSA] Thread safety cleanup functions

2023-09-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-19T16:00:33+02:00 New Revision: cf8e189a99f988398a48148b9ea7901948665ab0 URL: https://github.com/llvm/llvm-project/commit/cf8e189a99f988398a48148b9ea7901948665ab0 DIFF: https://github.com/llvm/llvm-project/commit/cf8e189a99f988398a48148b9ea7901948665ab0.diff LO

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-19 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGcf8e189a99f9: [clang][TSA] Thread safety cleanup functions (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D152504?vs=556838&id=557042#

[libunwind] [libunwind][AIX] Fix up TOC register if unw_getcontext is called from a different module (PR #66549)

2023-09-19 Thread via cfe-commits
https://github.com/stephenpeckham approved this pull request. https://github.com/llvm/llvm-project/pull/66549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] e25cd08 - [libunwind][AIX] Fix up TOC register if unw_getcontext is called from a different module (#66549)

2023-09-19 Thread via cfe-commits
Author: xingxue-ibm Date: 2023-09-19T10:37:30-04:00 New Revision: e25cd088a642d270c688611b85e22bc83f32f48e URL: https://github.com/llvm/llvm-project/commit/e25cd088a642d270c688611b85e22bc83f32f48e DIFF: https://github.com/llvm/llvm-project/commit/e25cd088a642d270c688611b85e22bc83f32f48e.diff L

[libunwind] [libunwind][AIX] Fix up TOC register if unw_getcontext is called from a different module (PR #66549)

2023-09-19 Thread via cfe-commits
https://github.com/xingxue-ibm closed https://github.com/llvm/llvm-project/pull/66549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8f8f449 - [RISCV] Recognize veyron-v1 processor in clang driver. (#66703)

2023-09-19 Thread via cfe-commits
Author: mgudim Date: 2023-09-19T10:39:43-04:00 New Revision: 8f8f4493d5fc6a025fff678f030da73dcfd8baa7 URL: https://github.com/llvm/llvm-project/commit/8f8f4493d5fc6a025fff678f030da73dcfd8baa7 DIFF: https://github.com/llvm/llvm-project/commit/8f8f4493d5fc6a025fff678f030da73dcfd8baa7.diff LOG: [

[clang] [RISCV] Recognize veyron-v1 processor in clang driver. (PR #66703)

2023-09-19 Thread via cfe-commits
https://github.com/mgudim closed https://github.com/llvm/llvm-project/pull/66703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread via cfe-commits
@@ -1333,7 +1333,15 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + QualType T = S->get

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

2023-09-19 Thread Alex Voicu via Phabricator via cfe-commits
AlexVlx added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-09-19 Thread via cfe-commits
https://github.com/DonatNagyE commented: (I started to nitpick the documentation text before I realized that it's just old content moved in from elsewhere. Probably it's better to handle these in a separate commit.) https://github.com/llvm/llvm-project/pull/66207 __

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-09-19 Thread via cfe-commits
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C string functions: return strlen(0); // warn } +.. _unix-StdCLibraryFunctions: + +unix.StdCLibraryFunctions (C) +""" +Check for calls of standard library function

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-09-19 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-09-19 Thread via cfe-commits
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C string functions: return strlen(0); // warn } +.. _unix-StdCLibraryFunctions: + +unix.StdCLibraryFunctions (C) +""" +Check for calls of standard library function

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #66782)

2023-09-19 Thread via cfe-commits
https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/66782 evalIntegralCast was using makeIntVal, and when _BitInt() types were introduced this exposed a crash in evalIntegralCast as a result. Improve evalIntegralCast to use makeIntVal more efficiently to avoid the c

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #66782)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes evalIntegralCast was using makeIntVal, and when _BitInt() types were introduced this exposed a crash in evalIntegralCast as a result. Improve evalIntegralCast to use makeIntVal more efficiently to avoid the crash exposed

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 11bb5e5 - In ExprRequirement building, treat OverloadExpr as dependent (#66683)

2023-09-19 Thread via cfe-commits
Author: Erich Keane Date: 2023-09-19T08:31:18-07:00 New Revision: 11bb5e55dc1fa00f522ce73805d36e0b76819386 URL: https://github.com/llvm/llvm-project/commit/11bb5e55dc1fa00f522ce73805d36e0b76819386 DIFF: https://github.com/llvm/llvm-project/commit/11bb5e55dc1fa00f522ce73805d36e0b76819386.diff L

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-09-19 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Are there interactions between `optdebug` and other attributes that should be enforced by the verifier? Like, can't be mixed with `optnone`? https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

2023-09-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:75 + "cannot find HIP Standard Parallelism Acceleration library; provide it via " + "'--stdpar-path'">; +def err_drv_no_hipstdpar_thrust_lib : Error< needs to update th

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-09-19 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: > Are there interactions between `optdebug` and other attributes that should be > enforced by the verifier? Like, can't be mixed with `optnone`? +1, this is basically "I want `-O1`" vs "I want `-O0`" so they must conflict https://github.com/llvm/llvm-project/pull/66632

[clang] [clang][dataflow] Reorder checks to protect against a null pointer dereference. (PR #66764)

2023-09-19 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/66764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-09-19 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: And same with `optsize`/`minsize` since those explicitly want as many simplifications as possible which conflicts with `optdebug` https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-19 Thread Jocelyn Castellano via cfe-commits
https://github.com/pandaninjas updated https://github.com/llvm/llvm-project/pull/66315 >From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001 From: PandaNinjas Date: Wed, 13 Sep 2023 17:38:17 -0700 Subject: [PATCH 01/18] [libc++] Prevent calling the projection more than three

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-19 Thread Jocelyn Castellano via cfe-commits
https://github.com/pandaninjas updated https://github.com/llvm/llvm-project/pull/66315 >From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001 From: PandaNinjas Date: Wed, 13 Sep 2023 17:38:17 -0700 Subject: [PATCH 01/18] [libc++] Prevent calling the projection more than three

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

2023-09-19 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. I just did some digging. We completed the transition to the libcxx-headers-in-the-SDK already, and now upstream and downstream Clang are the same with respect to those search paths. I think it might just be the case that you need the very latest AppleClang for that to b

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-19 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,312 @@ +//===- StdVariantChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [dataflow] Parse formulas from text (PR #66424)

2023-09-19 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

2023-09-19 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In D157283#4614177 , @DmitryPolukhin wrote: > @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa > (I > don't know what it is)? > Al

[clang] [clang][dataflow] Reorder checks to protect against a null pointer dereference. (PR #66764)

2023-09-19 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/66764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

2023-09-19 Thread Alex Voicu via Phabricator via cfe-commits
AlexVlx updated this revision to Diff 557057. AlexVlx marked an inline comment as done. AlexVlx added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSupport.rst clang/docs/ReleaseNotes.rst Index: c

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
cor3ntin wrote: @erichkeane @shafik You are happy with that ? (modulo rebase / spurious ws changes I need to revert) https://github.com/llvm/llvm-project/pull/66021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-19 Thread via cfe-commits
goldsteinn wrote: Created: https://github.com/llvm/llvm-project/pull/66793 which fixes the backend regression this can cause. https://github.com/llvm/llvm-project/pull/66740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-19 Thread Jocelyn Castellano via cfe-commits
https://github.com/pandaninjas updated https://github.com/llvm/llvm-project/pull/66315 >From ead65bfcb70be46788bc9e88c891e7ae7f91b8d7 Mon Sep 17 00:00:00 2001 From: PandaNinjas Date: Wed, 13 Sep 2023 17:38:17 -0700 Subject: [PATCH 01/19] [libc++] Prevent calling the projection more than three

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-19 Thread via cfe-commits
@@ -8291,6 +8291,29 @@ static std::optional isImpliedCondICmps(const ICmpInst *LHS, if (L0 == R0 && match(L1, m_APInt(LC)) && match(R1, m_APInt(RC))) return isImpliedCondCommonOperandWithConstants(LPred, *LC, RPred, *RC); + // L0 = R0 = L1 + R1, L0 >=u L1 implies R0 >=

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-19 Thread via cfe-commits
@@ -8291,6 +8291,29 @@ static std::optional isImpliedCondICmps(const ICmpInst *LHS, if (L0 == R0 && match(L1, m_APInt(LC)) && match(R1, m_APInt(RC))) return isImpliedCondCommonOperandWithConstants(LPred, *LC, RPred, *RC); + // L0 = R0 = L1 + R1, L0 >=u L1 implies R0 >=

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-19 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/65910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

2023-09-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu marked an inline comment as done. zequanwu added a comment. For some unknown reasons, linker still generates __llvm_prf_names section in the final binary on mac even if the object file doesn't have this section. And I cannot use llvm-objdump to get anything from that section. $ llvm-

[clang] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

2023-09-19 Thread via cfe-commits
https://github.com/kstoimenov updated https://github.com/llvm/llvm-project/pull/66786 >From 44e9645567a558523d749fe65783e8cb2b499413 Mon Sep 17 00:00:00 2001 From: kstoimenov <87100199+kstoime...@users.noreply.github.com> Date: Tue, 19 Sep 2023 08:59:41 -0700 Subject: [PATCH] Fix the logic in DW

[clang-tools-extra] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

2023-09-19 Thread via cfe-commits
https://github.com/kstoimenov updated https://github.com/llvm/llvm-project/pull/66786 >From 44e9645567a558523d749fe65783e8cb2b499413 Mon Sep 17 00:00:00 2001 From: kstoimenov <87100199+kstoime...@users.noreply.github.com> Date: Tue, 19 Sep 2023 08:59:41 -0700 Subject: [PATCH] Fix the logic in DW

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

2023-09-19 Thread Ellis Hoag via Phabricator via cfe-commits
ellis added a comment. In D157913#4648296 , @zequanwu wrote: > For some unknown reasons, linker still generates __llvm_prf_names section in > the final binary on mac even if the object file doesn't have this section. > And I cannot use llvm-objdump to g

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

2023-09-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. I feel like either this feature not working well with mac or we should keep `__llvm_prf_names` section in the binary. Current idea is to completely get rid of `__llvm_prf_names` section in the binary. Even if I fixed the issue https://reviews.llvm.org/D157913#4648296,

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-19 Thread Sandeep via Phabricator via cfe-commits
sandeepkosuri added a comment. @kaz7, it seems that the thread_limit is being set properly, but the `omp_get_thread_limit()` is giving a wrong output when you enable anything more than `-O1`. I will fix it as soon as I can. Meanwhile, if you absolutely want the test case to work right now, remo

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. > That's better than the status quo (no lifetime markers at all) but still > suboptimal, and I don't think it will solve the particular case I care about > (a particular Linux kernel driver written in C which is passing many > aggregates by value). Ah, all in the same

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

2023-09-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. In D157913#4648313 , @ellis wrote: > I have seen that MachO sections remain in the header even if the size is zero > which seems to be the case here. You could use `llvm-objdump` to verify that > the section exists but the size

[clang-tools-extra] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/4] [Clang] Static member initializers are not immediate escal

[clang] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

2023-09-19 Thread via cfe-commits
kstoimenov wrote: Because I am github illiterate I pushed the fix directly into mainline. I will close this PR. https://github.com/llvm/llvm-project/pull/66786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang-tools-extra] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

2023-09-19 Thread via cfe-commits
https://github.com/kstoimenov closed https://github.com/llvm/llvm-project/pull/66786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix the logic in DWARFContext thread safety selection (#11) (PR #66786)

2023-09-19 Thread via cfe-commits
kstoimenov wrote: Because I am github illiterate I pushed the fix directly into mainline. I will close this PR. https://github.com/llvm/llvm-project/pull/66786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] a041572 - Let the c(xx)_status pages reflect that clang 17 is released

2023-09-19 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-19T20:28:45+02:00 New Revision: a041572353fbb9745c92f8dc1f9f184dbcaacfd9 URL: https://github.com/llvm/llvm-project/commit/a041572353fbb9745c92f8dc1f9f184dbcaacfd9 DIFF: https://github.com/llvm/llvm-project/commit/a041572353fbb9745c92f8dc1f9f184dbcaacfd9.diff

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/4] [Clang] Static member initializers are not immediate escal

[clang-tools-extra] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/4] [Clang] Static member initializers are not immediate escal

[libunwind] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/4] [Clang] Static member initializers are not immediate escal

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

2023-09-19 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. Gentle ping. Are we waiting on anything to ship this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 ___ cfe-commits mailing list cfe-

[PATCH] D158694: [libc++] Re-enable the __std_module test

2023-09-19 Thread Louis Dionne via Phabricator via cfe-commits
ldionne abandoned this revision. ldionne added a comment. [Github PR transition cleanup] Abandoning here, will re-open as a Github PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158694/new/ https://reviews.llvm.org/D158694

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/E

[clang] [libc++] Re-enable the clang_modules_include test for Objective-C++ (PR #66801)

2023-09-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/66801 This reverts commit aa60b2687, which was a temporary workaround. This was originally https://reviews.llvm.org/D158694. >From 7683064a0b9aa7d76cf6fcbd8c804ad897c4b625 Mon Sep 17 00:00:00 2001 From: Louis Dionne

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-19 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 added a comment. @aaron.ballman why the member is not an constexpr can be seen from getNumVBases(). The 'defaultedSpecialMemberIsConstexpr' returns false whenever getVNumBases is true for this so we can use that to identify when to give which error diagnostic. Can you verify whe

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-19 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: Thanks for the fast reply @ChuanqiXu9 > I remember that there is a defect that we may place the GRO on the coroutine > frame. Can you point me to such defect? I had no luck searching for it. > And my instinct reaction is that would this patch be covered by forcing GRO >

[clang] [libc++] Re-enable the clang_modules_include test for Objective-C++ (PR #66801)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This reverts commit aa60b2687, which was a temporary workaround. This was originally https://reviews.llvm.org/D158694. --- Full diff: https://github.com/llvm/llvm-project/pull/66801.diff 2 Files Affected: - (added) clang/foo () - (modi

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-19 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM - I was trying to find some hope in the standard that this was ill-formed. Alas. https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 816144b - [Coverage] Skip visiting ctor member initializers with invalid source locations.

2023-09-19 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2023-09-19T14:59:41-04:00 New Revision: 816144bfd2d86701020c0c7b693d403f8fc8dffe URL: https://github.com/llvm/llvm-project/commit/816144bfd2d86701020c0c7b693d403f8fc8dffe DIFF: https://github.com/llvm/llvm-project/commit/816144bfd2d86701020c0c7b693d403f8fc8dffe.diff LOG

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/65889 >From b7d3ca20cc195d9ac95e8914aa4e69b922b1aca3 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 9 Sep 2023 12:19:07 +0200 Subject: [PATCH] [clang] [C23] Fix crash with _BitInt running clang-tidy This

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread Erich Keane via cfe-commits
@@ -1333,7 +1333,14 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + QualType T = S->get

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: There are still some debug info LIT tests that are failing, but I am not going to edit them because I am not quite sure that's correct. Probably adding the "class" keyword shouldn't happen at all times even when the MSVCPolicy is true? https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: There are still some debug info LIT tests that are failing, but I am not going to edit them because I am not quite sure that's correct. Probably adding the "class" keyword shouldn't happen at all times even when the MSVCPolicy is true? https://github.com/llvm/llvm-project/pull/

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/5] [Clang] Static member initializers are not immediate escal

[libunwind] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/5] [Clang] Static member initializers are not immediate escal

[clang] GitHub learn (PR #66806)

2023-09-19 Thread via cfe-commits
https://github.com/kstoimenov created https://github.com/llvm/llvm-project/pull/66806 None >From b739af00963c23e4b50ae8e0a71550e5732e4d0d Mon Sep 17 00:00:00 2001 From: Kirill Stoimenov Date: Thu, 14 Sep 2023 00:00:53 + Subject: [PATCH] [LSAN][NFC] Add a new line to a log --- compiler-rt

[clang-tools-extra] GitHub learn (PR #66806)

2023-09-19 Thread via cfe-commits
https://github.com/kstoimenov created https://github.com/llvm/llvm-project/pull/66806 None >From b739af00963c23e4b50ae8e0a71550e5732e4d0d Mon Sep 17 00:00:00 2001 From: Kirill Stoimenov Date: Thu, 14 Sep 2023 00:00:53 + Subject: [PATCH] [LSAN][NFC] Add a new line to a log --- compiler-rt

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-19 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/65889 >From 79e1ab6388e44708eedf4d8351b35c7a2500367a Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 9 Sep 2023 12:19:07 +0200 Subject: [PATCH] [clang] [C23] Fix crash with _BitInt running clang-tidy This

<    1   2   3   4   5   >