llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Changes
Previously, bitwise shifts with constant operands were validated by the checker
`core.UndefinedBinaryOperatorResult`. However, this logic was unreliable, and
commit 25b9696b61e53a958e217bb3d0eab66350dc187f added the dedic
https://github.com/Fznamznon commented:
The change needs a release note, otherwise looks good.
Right, @cor3ntin ?
https://github.com/llvm/llvm-project/pull/66643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/66649
Fixes #66468
>From df20b6321bf9332571fc4e45ae370793876f7773 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 18 Sep 2023 09:58:29 -0400
Subject: [PATCH] [clang] Improve CI output when trailing whitespace i
ldionne wrote:
@asl This should make it a bit more explicit. I see this now when running
locally:
```
+ echo '*** Checking for trailing whitespace left in Clang source files ***'
*** Checking for trailing whitespace left in Clang source files ***
+ grep -rnI '[[:blank:]]$' clang/lib clang/inclu
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Fixes #66468
---
Full diff: https://github.com/llvm/llvm-project/pull/66649.diff
1 Files Affected:
- (modified) clang/utils/ci/run-buildbot (+5-1)
``diff
diff --git a/clang/utils/ci/run-buildbot b/clang/utils/ci/run-buildbot
in
erichkeane wrote:
> TBH, not sure if the UML diagrams would really help anyone understand what's
> going on.
I tend to agree with this, the documentation via these diagrams is confusing me
as well, it doesn't really seem to add anything (and in fact, seem to be
'subtracting' in my case).
Tha
hazohelet updated this revision to Diff 556946.
hazohelet added a comment.
After discussion in https://github.com/llvm/llvm-project/pull/66222, I noticed
I had misunderstood the recursiveness of constant-evaluated context.
I was pushing constant-evaluating on the lambda body when it appears insid
@@ -1333,7 +1333,14 @@ void StmtProfiler::VisitPredefinedExpr(const
PredefinedExpr *S) {
void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) {
VisitExpr(S);
S->getValue().Profile(ID);
- ID.AddInteger(S->getType()->castAs()->getKind());
+
+ QualType T = S->get
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne resolved
https://github.com/llvm/llvm-project/pull/66315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE approved this pull request.
Don't forget to update the commit message!
https://github.com/llvm/llvm-project/pull/65887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
ldionne wrote:
> Any idea why the CI is failing? It mentions line 86 not being constexpr
> because of assert, but it doesn't seem like I've done anything which should
> affect that...
I looked into it a bit and I think the CI is failing because of the
`std::forward` problem. The assertion on
@@ -37,9 +37,10 @@ struct __fn {
_LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj,
__high), std::invoke(__proj, __low))),
"Bad bounds passed to std::ranges::clamp");
-if (std::invoke(__comp, std::invoke(__proj,
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
@@ -108,7 +108,34 @@ constexpr bool test() {
auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove {
return x; };
assert(&std::ranges::clamp(val, low, high, moving_comp, prvalue_proj) ==
&val);
}
+ { // Make sure we don't call the projection more than
https://github.com/simpal01 updated
https://github.com/llvm/llvm-project/pull/65966
>From eb4d99345cbe9aba6b909ccbc7ce932dcaef3f7d Mon Sep 17 00:00:00 2001
From: Simi Pallipurath
Date: Mon, 11 Sep 2023 14:42:27 +0100
Subject: [PATCH] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has
https://github.com/rjodinchr created
https://github.com/llvm/llvm-project/pull/66651
This is reverting the previous implementation to avoid adding inline function
in opencl headers.
This was breaking clspv flow google/clspv#1231, while
https://reviews.llvm.org/D156743 mentioned that just decor
rjodinchr wrote:
@alan-baker @arsenm @AnastasiaStulova
Could you review this PR please?
Thank you
https://github.com/llvm/llvm-project/pull/66651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema &S,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if (S.getLangOpts().CPlusP
erichkeane added a comment.
I've got no further comments/concerns.
Comment at: clang/include/clang/AST/Decl.h:4272-4275
+FieldDecl *FD = nullptr;
+for (FieldDecl *Field : fields())
+ FD = Field;
+return FD;
aaron.ballman wrote:
> void wrote:
>
cor3ntin wrote:
@Fznamznon I think so too, although I'd be inclined to move the test to
`clang/test/Parser/` because even though the fix is in Sema, it's testing a
wrong parse.
The commit message also could do with a longer description.
Otherwise LGTM
https://github.com/llvm/llvm-project/pul
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@erichkeane Opinions?
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,133 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,132 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/66636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
I guess my first question is 'why'? My second is 'if this is unnecessary, why
was it here in the first place?`. I'd like some level of historical analysis
here/perhaps the knowledge of @zygoloid.
https://github.com/llvm/llvm-project/pull/66636
___
@@ -2613,70 +2579,6 @@ class TypeAliasTemplateDecl : public
RedeclarableTemplateDecl {
static bool classofKind(Kind K) { return K == TypeAliasTemplate; }
};
-/// Declaration of a function specialization at template class scope.
-///
-/// For example:
-/// \code
-/// templat
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq
c))`
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq
c))`
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Changes
This patch folds the pattern `a ne/eq (zext (a ne/eq c))` into a boolean
constant or a compare.
Clang vs GCC: https://godbolt.org/z/4ro817WE8
Alive2: https://alive2.llvm.org/ce/z/6z9NRF
Fixes #65073.
---
Full diff: https://githu
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Changes
This patch folds the pattern `a ne/eq (zext (a ne/eq c))` into a boolean
constant or a compare.
Clang vs GCC: https://godbolt.org/z/4ro817WE8
Alive2: https://alive2.llvm.org/ce/z/6z9NRF
Fixes #65073.
---
Full diff: https://githu
@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over
std::vector, causing
and is no longer "private to the implementation". A name like
``SmallVectorHeader`` might be more appropriate.
+.. _dss_pagedvector:
+
+llvm/ADT/PagedVector.h
+^^
https://github.com/dtcxzyw resolved
https://github.com/llvm/llvm-project/pull/65852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw resolved
https://github.com/llvm/llvm-project/pull/65852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pfusik wrote:
> I'd be inclined to move the test to clang/test/Parser/ because even though
> the fix is in Sema, it's testing a wrong parse.
It's an ICE in Sema. The test is identical to the bug report, but it doesn't
mean the issue is limited to syntax errors.
```cpp
int main() {
[]()__a
@@ -305,9 +305,22 @@ DEFINE_LIBUNWIND_FUNCTION(__unw_getcontext)
mflr 0
std 0, PPC64_OFFS_SRR0(3) // store lr as ssr0
PPC64_STR(1)
+ PPC64_STR(4) // Save r4 first since it will be used for fixing r2.
+#if defined(_AIX)
+ // The TOC register (r2) was changed by t
@@ -305,9 +305,22 @@ DEFINE_LIBUNWIND_FUNCTION(__unw_getcontext)
mflr 0
std 0, PPC64_OFFS_SRR0(3) // store lr as ssr0
PPC64_STR(1)
+ PPC64_STR(4) // Save r4 first since it will be used for fixing r2.
+#if defined(_AIX)
+ // The TOC register (r2) was changed by t
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/2] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 1/2] [InstCombine] Simplify the pattern `a ne/eq (zext (a
ne/eq c)
https://github.com/dtcxzyw resolved
https://github.com/llvm/llvm-project/pull/65852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
d-smirnov added a comment.
@nikic Could you check out the updated code to make sure we're on the right
track before I try to fix the rest of the unit tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155688/new/
https://reviews.llvm.org/D155688
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/65852
>From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sat, 9 Sep 2023 23:07:29 +0800
Subject: [PATCH 1/3] [InstCombine] Simplify the pattern `a ne/eq (zext (a
ne/eq c)
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/3] [clang-tidy] Update llvmlibc-implementation-in-namespa
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430
>From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Thu, 14 Sep 2023 21:58:21 +0200
Subject: [PATCH 01/16] Introduce PagedVector class
ktf wrote:
For the record, the latest version of this uses a BumpPtrAllocator to allocate
pages, as suggested.
https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,133 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -7944,9 +7944,13 @@ void ASTReader::PrintStats() {
std::fprintf(stderr, "*** AST File Statistics:\n");
unsigned NumTypesLoaded =
- TypesLoaded.size() - llvm::count(TypesLoaded, QualType());
+ TypesLoaded.size() - std::count(TypesLoaded.materialisedBegin(),
---
https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,132 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
sdkrystian wrote:
@erichkeane
> I guess my first question is 'why'?
Per the comment you mentioned, it is redundant. Switching to
`DependentFunctionTemplateSpecializationInfo` also results in constructs such
as:
```
template
struct A {
template<>
void f();
};
```
being diagnosed prior t
@@ -300,6 +300,11 @@ Changes in existing checks
` check to
identify calls to static member functions with out-of-class inline
definitions.
+- Updated :doc:`llvmlibc-implementation-in-namespace
PiotrZSL wrote:
Put changes in alphabetical order. use 'Impr
https://github.com/dfszabo updated
https://github.com/llvm/llvm-project/pull/65465
From 69e13118b0669b3e54c5fffc1f5ac60d8b6b2d62 Mon Sep 17 00:00:00 2001
From: dfszabo
Date: Wed, 6 Sep 2023 13:07:19 +0200
Subject: [PATCH] [Clang] Allow mixed scalar type constraints for inline asm
GCC supports
https://github.com/dfszabo updated
https://github.com/llvm/llvm-project/pull/65465
From 69e13118b0669b3e54c5fffc1f5ac60d8b6b2d62 Mon Sep 17 00:00:00 2001
From: dfszabo
Date: Wed, 6 Sep 2023 13:07:19 +0200
Subject: [PATCH] [Clang] Allow mixed scalar type constraints for inline asm
GCC supports
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(), "'%0' needs to be the outermost namespace")
- << RequiredNamespace
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Changes
This is reverting the previous implementation to avoid adding inline function
in opencl headers.
This was breaking clspv flow google/clspv#1231, while
https://reviews.llvm.org/D156743 mentioned that just decoring the call node
with
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(), "'%0' needs to be the outermost namespace")
- << RequiredNamespace
@@ -3,18 +3,18 @@
#define MACRO_A "defining macros outside namespace is valid"
class ClassB;
-// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
within the '__llvm_libc' namespace
+// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
@@ -0,0 +1,132 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -3,18 +3,18 @@
#define MACRO_A "defining macros outside namespace is valid"
class ClassB;
-// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
within the '__llvm_libc' namespace
+// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
401 - 463 of 463 matches
Mail list logo
