[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/66462 >From 36f7d8d284b4c22621f3addc55c0fdb7afe71a31 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 15 Sep 2023 11:33:53 +0800 Subject: [PATCH] [clangd] [C++20] [Modules] Introduce initial support for C++20 M

[clang] Introduce paged vector (PR #66430)

ktf wrote: Thank you for your feedback. Could you please be more specific? I cannot find any reference to ADT in the document you pointed me to. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 milestoned https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. I sent the next patch at: https://github.com/llvm/llvm-project/pull/66462 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] Introduce paged vector (PR #66430)

ChuanqiXu9 wrote: Sorry. I meant to sent: https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task. Also I feel like the comments are much less than other ADT types. I mean these are important and fundamental data structures. So that almost every LLVM developer

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/66462 >From a4e9cae646b9a7af5e246075b55c74fc4a152024 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 15 Sep 2023 11:33:53 +0800 Subject: [PATCH] [clangd] [C++20] [Modules] Introduce initial support for C++20 M

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/4] Introduce PagedVector class

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/phoebewang approved this pull request. LGTM. I didn't review Clang document before, but I'll give approval since I don't find anything blocking it. https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-com

[clang] bdac5de - [clang][Interp] Specify C standard in test case

Author: Timm Bäder Date: 2023-09-15T09:34:10+02:00 New Revision: bdac5de42833bc5dc4379a9548c8d172c7d15e2b URL: https://github.com/llvm/llvm-project/commit/bdac5de42833bc5dc4379a9548c8d172c7d15e2b DIFF: https://github.com/llvm/llvm-project/commit/bdac5de42833bc5dc4379a9548c8d172c7d15e2b.diff LO

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/5] Introduce PagedVector class

[clang] a259005 - [clang][Interp] Convert logical binop operands to bool

Author: Timm Bäder Date: 2023-09-15T09:52:41+02:00 New Revision: a259005a215d985586d0b3db5c9e6b9e7eb38e47 URL: https://github.com/llvm/llvm-project/commit/a259005a215d985586d0b3db5c9e6b9e7eb38e47 DIFF: https://github.com/llvm/llvm-project/commit/a259005a215d985586d0b3db5c9e6b9e7eb38e47.diff LO

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa259005a215d: [clang][Interp] Convert logical binop operands to bool (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D157

[clang] Introduce paged vector (PR #66430)

ktf wrote: Thank you for the clarification. I have added the requested documentation and there are now more lines of comment than lines of code. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] d485fc4 - [clang][Interp][NFC] Fix a comment typo

Author: Timm Bäder Date: 2023-09-15T09:55:52+02:00 New Revision: d485fc40f3e032694f0a91ca81fc52ef9a0765c0 URL: https://github.com/llvm/llvm-project/commit/d485fc40f3e032694f0a91ca81fc52ef9a0765c0 DIFF: https://github.com/llvm/llvm-project/commit/d485fc40f3e032694f0a91ca81fc52ef9a0765c0.diff LO

[clang] Introduce paged vector (PR #66430)

https://github.com/ChuanqiXu9 commented: I feel better to add unittests to llvm/unittests/ADT. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] Introduce paged vector (PR #66430)

ChuanqiXu9 wrote: I feel we need more reviewers for introducing ADT types. Let me try to add some people. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] Introduce paged vector (PR #66430)

nikic wrote: Any numbers on what / how much this improves? https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd2f2c1 - [clang][Interp] Visit Logical-not operand as bool

Author: Timm Bäder Date: 2023-09-15T10:12:20+02:00 New Revision: cd2f2c166203cb30f8231c0f3f8d2e28f30f9b8c URL: https://github.com/llvm/llvm-project/commit/cd2f2c166203cb30f8231c0f3f8d2e28f30f9b8c DIFF: https://github.com/llvm/llvm-project/commit/cd2f2c166203cb30f8231c0f3f8d2e28f30f9b8c.diff LO

[PATCH] D157200: [clang][Interp] Visit Logical-not operand as bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2f2c166203: [clang][Interp] Visit Logical-not operand as bool (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D157200?v

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556834. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Handle all of `tok::unknown, tok::eof, tok::eod`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; aaron.ballman wrote: > v.g.vassilev wrote: > > aaron.ballman wrote: > > > Hahnfeld wrote: > > > > aaron.ballman wrote: > > > > > I'

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

ChuanqiXu9 wrote: The bot shows some escaping code issue on windows: > YAML:6:44: error: Unrecognized escape code > -- >   | "file": > "C:\Users\ContainerAdministrator\AppData\Local\Temp\lit-tmp-ns06ti05\modules-test-e111b6/foo.cppm", And I'm like to skip the tests on windows temporarily sinc

[clang] [libc] Add invoke / invoke_result type traits (PR #65750)

https://github.com/legrosbuffle approved this pull request. https://github.com/llvm/llvm-project/pull/65750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/66462 >From df7c71d07f7db246aff0c6021e85acb70bd75868 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 15 Sep 2023 11:33:53 +0800 Subject: [PATCH] [clangd] [C++20] [Modules] Introduce initial support for C++20 M

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/7] Introduce PagedVector class

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson ^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_smallvector: ChuanqiXu9 wrote: T

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,125 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_smallvector: + +llvm/ADT/PagedVector.h +^^

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

tbaederr wrote: TBH, not sure if the UML diagrams would really help anyone understand what's going on. https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang] Fix wrong warning about missing init for flexible array members (PR #66341)

https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/66341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

@@ -0,0 +1,31 @@ +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=debug.ExprInspection \ +// RUN: -analyzer-config eagerly-assume=false \ +// RUN: -verify + +void clang_analyzer_eval(int); + +void test_simplified_before_cast_add

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

@@ -0,0 +1,31 @@ +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=debug.ExprInspection \ +// RUN: -analyzer-config eagerly-assume=false \ +// RUN: -verify + +void clang_analyzer_eval(int); + +void test_simplified_before_cast_add

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

https://github.com/steakhal commented: I like it. Thanks! This is pretty much good to go, but let's have a short discussion first. https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

@@ -264,7 +264,8 @@ ProgramStateRef ExprEngine::handleLValueBitCast( } // Delegate to SValBuilder to process. SVal OrigV = state->getSVal(Ex, LCtx); - SVal V = svalBuilder.evalCast(OrigV, T, ExTy); + SVal SimplifiedOrigV = svalBuilder.simplifySVal(state, OrigV); + SVal

[clang] Introduce paged vector (PR #66430)

ktf wrote: @ChuanqiXu9 I have added a simple unit test, which has 100% code coverage as far as I can tell and covers the usecase the container will be used for. @nikic This is in the context of improving the memory used when loading modules, in particular my usecase is the runtime overhead of

[clang] Introduce paged vector (PR #66430)

ktf wrote: @nikic I suspect the improvements will be also visible in any use case where modules are eagerly loaded but only sparsely used. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [libc] Add invoke / invoke_result type traits (PR #65750)

gchatelet wrote: Thx for the thorough review @legrosbuffle, I really appreciate it. https://github.com/llvm/llvm-project/pull/65750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Add invoke / invoke_result type traits (PR #65750)

gchatelet wrote: Thx for the thorough review @legrosbuffle, I really appreciate it. https://github.com/llvm/llvm-project/pull/65750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Add invoke / invoke_result type traits (PR #65750)

https://github.com/gchatelet closed https://github.com/llvm/llvm-project/pull/65750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Add invoke / invoke_result type traits (PR #65750)

https://github.com/gchatelet closed https://github.com/llvm/llvm-project/pull/65750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

https://github.com/0x59616e updated https://github.com/llvm/llvm-project/pull/65193 >From 3eafb85ff74271456cba24ea5892dd5660c1d332 Mon Sep 17 00:00:00 2001 From: Sheng Date: Wed, 30 Aug 2023 11:44:23 +0800 Subject: [PATCH 1/2] [clang][Sema] Fix a bug when instantiating a lambda with requires c

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

0x59616e wrote: Support for nested lambda has been added. I will address your kindly feedbacks later. https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

@@ -0,0 +1,6 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s +// REQUIRES: riscv-registered-target + +// expected-no-diagnostics + +#include eopXD wrote: I think we can't :( https://github.com/llvm/llvm-project/pull/66330 __

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

https://github.com/eopXD approved this pull request. https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/66480 We were previously checking that stencil input ranges were writable. It suffices for them to be readable. >From d9f8e39bb042165b53ae3c070f96a5bfe994f9fd Mon Sep 17 00:00:00 2001 From: Clement Courbet Date:

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/8] Introduce PagedVector class

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

llvmbot wrote: @llvm/pr-subscribers-clang Changes We were previously checking that stencil input ranges were writable. It suffices for them to be readable. -- Full diff: https://github.com/llvm/llvm-project/pull/66480.diff 3 Files Affected: - (modified) clang/include/clang/Too

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_smallvector: ktf wrote: Fixed. S

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,125 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_smallvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

ktf wrote: @ChuanqiXu9 I think I have addressed all your comments. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] [analyzer] Add std::variant checker (PR #66481)

https://github.com/spaits created https://github.com/llvm/llvm-project/pull/66481 As my BSc thesis I've implemented a checker for std::variant and std::any, and in the following weeks I'll upload a revised version of them here. # Prelude @Szelethus and I sent out an email with our initial pla

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/9] Introduce PagedVector class

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038 >From 0210654ea92a8c58746c2008af1c96d7553d96dd Mon Sep 17 00:00:00 2001 From: X512 Date: Mon, 11 Sep 2023 20:56:02 -0400 Subject: [PATCH] [Driver] Implement ToolChain on Haiku Co-authored-by: David Karoly Co-autho

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 556836. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1472 +// CHECK-NEXT:2: (CXXConstructExpr, [B1.3], F) +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: CleanupFunction (cleanup_F) aaronpu

[clang] Introduce paged vector (PR #66430)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ChuanqiXu9 commented: Thanks. Sorry for not commenting everything at the first sight. I don't have further concerns. But I'd like to give more times for other reviewers to take a look. https://github.com/llvm/llvm-project/pull/66430 __

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 556838. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target s

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

brad0 wrote: One thing to add to this. I noticed the Gnu addition does not check for `nostdlib, nodefaultlibs, or r` flags like the C++ library chunk does. With the proposed diff and what I had initially being right under the C++ chunk in the Solaris and *BSD ToolChain they would be checking f

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

brad0 wrote: Because of where the chunk is being added in the Solaris ToolChain (and what I had in my tree for *BSD's) it is checking for the ```nostdlib, nodefaultlibs, or r``` flags, where as the Gnu path does not. I just want to make sure the behavior is consistent. tools::gnutools::Linker

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::variant checker (PR #66481)

https://github.com/spaits ready_for_review https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From c6022432afb24b4788e6d5065f583b29a1a5277a Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalenc

[clang-tools-extra] [include-cleaner] Respect the UsingShadowDecl when find headers for ambiguous std symbols. (PR #66485)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/66485 In libcpp, the `std::remove(const char*)` is a using decl in std namespace `using ::remove`, which was not handled correctly in `headerForAmbiguousStdSymbol` >From ffd109a7b4273d6a1dc5810b64039a110a4147c9 Mon Se

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From 011c3997ac72918b23db511b94184e9fc5351a54 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalenc

[clang] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

PiotrZSL wrote: I run this check on two bigger projects, didn't found anything (I was expecting it wont). So at least in case of false-positives it looks fine. https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@li

[clang] Introduce paged vector (PR #66430)

vgvassilev wrote: > @ChuanqiXu9 I have added a simple unit test, which has 100% code coverage as > far as I can tell and covers the usecase the container will be used for. > > @nikic This is in the context of improving the memory used when loading > modules, in particular my usecase is the run

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/10] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs created https://github.com/llvm/llvm-project/pull/66487 If there is 2 guides one of them generated from a non-templated constructor and one of them from a templated constructor the standard gives priority to the first. Clang detected ambiguity before, now the correct

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/11] Introduce PagedVector class

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

Arthapz wrote: Oh nice going to try this :) https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

@@ -218,6 +218,8 @@ Bug Fixes in This Version (`#65156 `_) - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Fix lack of

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

ktf wrote: @vgvassilev done. @ChuanqiXu9 I think I addressed all your additional comments and updated the PR. Please let me know if you have further ones or if you want me to squash the commits into one. https://github.com/llvm/llvm-project/pull/66430 _

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

@@ -2320,5 +2320,14 @@ TEST_F(StructuralEquivalenceStmtTest, UnresolvedLookup) { EXPECT_TRUE(testStructuralMatch(t)); } +TEST_F(StructuralEquivalenceStmtTest, DeclRefENoEq) { danix800 wrote: ```suggestion TEST_F(StructuralEquivalenceStmtTest, DeclRefExpr) {

[clang] Introduce paged vector (PR #66430)

vgvassilev wrote: > @vgvassilev done. > > @ChuanqiXu9 I think I addressed all your additional comments and updated the > PR. Please let me know if you have further ones or if you want me to squash > the commits into one. I think we need to add some test on the clang modules side. I am current

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/12] Introduce PagedVector class

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

@@ -264,7 +264,8 @@ ProgramStateRef ExprEngine::handleLValueBitCast( } // Delegate to SValBuilder to process. SVal OrigV = state->getSVal(Ex, LCtx); - SVal V = svalBuilder.evalCast(OrigV, T, ExTy); + SVal SimplifiedOrigV = svalBuilder.simplifySVal(state, OrigV); + SVal

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget, return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

  1   2   3   4   5   >