[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

goldsteinn wrote: > > Split some tests for c/cpp; NFC > > Why was this necessary? Different `noundef` properties for some of the intrinsics. Since there are multiple unique checks thought it was simpler to just split than add c/cxx version for each of the existing checks. https://github.com/

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66055: >From ed5150a69925dc3b6557796026a2820ac5c2e2f5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 12 Sep 2023 14:41:57 +0800 Subject: [PATCH 01/11] add --- .../bugprone/BugproneTidyModule.cpp

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bf49237 - [Clang] Enable -print-pipeline-passes in clang.

Author: Joshua Cranmer Date: 2023-09-13T08:57:10-07:00 New Revision: bf492371033378cec4c0443a3f87db0f818bbade URL: https://github.com/llvm/llvm-project/commit/bf492371033378cec4c0443a3f87db0f818bbade DIFF: https://github.com/llvm/llvm-project/commit/bf492371033378cec4c0443a3f87db0f818bbade.diff

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

This revision was automatically updated to reflect the committed changes. jcranmer-intel marked an inline comment as done. Closed by commit rGbf4923710333: [Clang] Enable -print-pipeline-passes in clang. (authored by jcranmer-intel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66222: >From d7f281ed8809d991393de0c922fd08a0d657d863 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 13 Sep 2023 17:36:39 +0200 Subject: [PATCH] [Clang] Handle consteval expression in array bounds expressio

[clang] b4b4d8b - [test][clang-repl][Orc] Lsan report workaround

Author: Vitaly Buka Date: 2023-09-13T09:07:30-07:00 New Revision: b4b4d8bd61d8de946e130beff5049a4ab13e155d URL: https://github.com/llvm/llvm-project/commit/b4b4d8bd61d8de946e130beff5049a4ab13e155d DIFF: https://github.com/llvm/llvm-project/commit/b4b4d8bd61d8de946e130beff5049a4ab13e155d.diff L

[clang] remove common libc tuners (PR #66136)

https://github.com/sivachandra updated https://github.com/llvm/llvm-project/pull/66136: >From d1a9fda20a2be37385b44dcbf2f73b1890fa7d78 Mon Sep 17 00:00:00 2001 From: Siva Chandra Reddy Date: Tue, 12 Sep 2023 05:42:37 + Subject: [PATCH 1/3] [libc][NFC] Make entrypoint alias targets real libr

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. In D159167#4645214 , @vitalybuka wrote: > This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 I landed b4b4d8bd61d8de946e130beff5049a4ab13e155d

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

tbaederr wrote: @hazohelet Does this collide or intersect with the work wrt. (un)evaluated contexts in https://reviews.llvm.org/D155064 ? https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] remove common libc tuners (PR #66136)

https://github.com/sivachandra closed https://github.com/llvm/llvm-project/pull/66136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. Also maybe it's cleaner just disable a particular test (binary or test case) with incompatible sanitizer. Leaving this up to @lkail or @v.g.vassilev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://revi

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr, TPtr, RPa

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

nickdesaulniers added a comment. Also, I encourage you to test a build of the linux kernel with __counted_by BEFORE merging this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 _

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

nickdesaulniers added a comment. Perhaps worth updating the release notes, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 ___ cfe-commits mailing list cfe

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

NekoCdr added a comment. In D126960#4643979 , @AshleyRoll wrote: > If someone else wants to take it on, I'd be fine with that. You can resume working with this patch, if you want. It's just a reminder. ) Repository: rG LLVM Github Monorepo CHANGES

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto created https://github.com/llvm/llvm-project/pull/66243: An assertion issue that arose when handling union member access with virtual base class has been addressed. As pointed out by @zygoloid, there is no need for further derived-to-base analysis in this in

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto review_requested https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto review_requested https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto review_requested https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/antoniofrighetto review_requested https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement ACLE rintn and rintnf intrinsics (PR #66112)

https://github.com/Blue-Dot updated https://github.com/llvm/llvm-project/pull/66112: >From 6fd8cfd2c119dfd99702913ac9201a39e091f3e8 Mon Sep 17 00:00:00 2001 From: Blue-Dot Date: Wed, 13 Sep 2023 17:51:45 +0100 Subject: [PATCH 1/2] [AArch64][Clang] Implement ACLE rintn intrinsics Change-Id: I7f

[clang] [clang][AST] Bail out when handling union access with virtual inheritance (PR #66243)

llvmbot wrote: @llvm/pr-subscribers-clang Changes An assertion issue that arose when handling union member access with virtual base class has been addressed. As pointed out by @zygoloid, there is no need for further derived-to-base analysis in this instance, so we can bail out

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -108,6 +108,16 @@ class DataflowAnalysisContext { /// A null `PointeeType` can be used for the pointee of `std::nullptr_t`. PointerValue &getOrCreateNullPointerValue(QualType PointeeType); + /// Adds `Constraint` to current and future flow conditions in this context. +

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/Xazax-hun approved this pull request. LG! https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr, TPtr,

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/66023: >From c6330fb734a687d975dc2c6e674d98b03d8f2d1b Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Mon, 11 Sep 2023 15:22:15 -0700 Subject: [PATCH] [libc] Refactor scanf reader to match printf In a prev

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/66265: This shouldn't be necessary if we set the SDKROOT environment variable properly when we run the test suite, as it is expected on Apple platforms. To set the SDKROOT environment variable properly, we have to use

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/ldionne review_requested https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/ldionne review_requested https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/ldionne review_requested https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

llvmbot wrote: @llvm/pr-subscribers-libunwind Changes This shouldn't be necessary if we set the SDKROOT environment variable properly when we run the test suite, as it is expected on Apple platforms. To set the SDKROOT environment variable properly, we have to use a slight hack

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

https://github.com/ldionne labeled https://github.com/llvm/llvm-project/pull/65517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

ldionne wrote: The direction we've been taking with these config files is to keep the base config setup as simple as possible and avoid the proliferation of options that are not fundamentally tied to the test suite. These kinds of options should instead be hardcoded in a suitable `.cfg.in` fil

[clang] e504194 - [Driver][HLSL] Improve diagnostics for invalid shader model and stage

Author: Justin Bogner Date: 2023-09-13T10:45:39-07:00 New Revision: e504194d51e1f0f7ca5b684b4aa99db4940856c2 URL: https://github.com/llvm/llvm-project/commit/e504194d51e1f0f7ca5b684b4aa99db4940856c2 DIFF: https://github.com/llvm/llvm-project/commit/e504194d51e1f0f7ca5b684b4aa99db4940856c2.diff

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe504194d51e1: [Driver][HLSL] Improve diagnostics for invalid shader model and stage (authored by bogner). Repository: rG LLVM Github Monorepo CHA

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik created https://github.com/llvm/llvm-project/pull/66270: Currently CXXRewrittenBinaryOperator::getDecomposedForm(...) may crash if the spaceship operator returns a comparison category by reference. This because IgnoreImplicitAsWritten() does not look through CXXConstruc

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently CXXRewrittenBinaryOperator::getDecomposedForm(...) may crash if the spaceship operator returns a comparison category by reference. This because IgnoreImplicitAsWritten() does not look through CXXConstructExpr. The fix is

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

aaron.ballman requested changes to this revision. aaron.ballman added reviewers: efriedma, rjmccall, erichkeane. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! Please be sure to also add a release note to `clang/docs/ReleaseNotes.rst`

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

nickdesaulniers added a subscriber: jyknight. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:857 + if (IsDynamic) { +const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = +getLangOpts().getStrictFlexArraysLevel(); --

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:857 + if (IsDynamic) { +const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = +getLangOpts().getStrictFlexArraysLevel(); nickdesaulniers wrote: > aaron.ba

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:857 + if (IsDynamic) { +const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = +getLangOpts().getStrictFlexArraysLevel(); aaron.ballman wrote: > nickdesa

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:482 + /// Whether it resembles a flexible array member. + static bool isFlexibleArrayMemberLike( + ASTContext &Context, const Decl *D, QualType Ty, Why isn't this a member fun

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -961,10 +961,16 @@ def FormatNonStandard : DiagGroup<"format-non-iso">; def FormatY2K : DiagGroup<"format-y2k">; def FormatPedantic : DiagGroup<"format-pedantic">; def FormatTypeConfusion : DiagGroup<"format-type-confusion">; + +def FormatOverflowNonKprintf: DiagGroup<"forma

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -1350,10 +1360,17 @@ void Sema::checkFortifiedBuiltinMemoryFunction(FunctionDecl *FD, llvm::APSInt::getUnsigned(H.getSizeLowerBound()) .extOrTrunc(SizeTypeWidth); if (FormatSize > *SourceSize && *SourceSize != 0) { - DiagID = dia

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid commented: I'm happy with the overall approach here; please don't block on further review from me. https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid review_request_removed https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/zygoloid dismissed https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

arichardson wrote: The problem is that we end up with a combinatoric explosion of config files for all the different ABIs that can be used. Would you be open to having the cmake-bridge inject CMAKE_CXX_FLAGS_INIT/CMAKE_EXE_LINKER_FLAGS_INIT (which should be empty unless you use a toolchain fi

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zeroomega wrote: I look through all the bot failures from my mail box and I think so far there are two issues: * `error: unused function 'operator<<'` issue, this is caused by a type matching bug I introduced in the roll and it will be addressed by: https://github.com/llvm/llvm-project/commit

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

aaron.ballman added a comment. In D158472#4605228 , @hazohelet wrote: > This breaks the one-note-for-one-overload-candidate rule of overload > resolution failure diagnostics > (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc22190

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Actually, we could give you access to an AIX machine to debug this. Would that work for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/D151938 _

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 ___ cfe-commits mailing list

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

petrhosek wrote: This is going to break our builds because we always use the just built Clang (built using the bootstrap build) even on Darwin. I'm fine doing this change for `apple-*.cfg.in` configurations to better match Apple configuration, but for `llvm-*.cfg.in` I'd like to preserve the e

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556693. cjdb marked an inline comment as done. cjdb added a comment. partially reverts change and fixes typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: cla

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 ___

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/bnbarham created https://github.com/llvm/llvm-project/pull/66281: This reverts commit c2fb112021529c635cccd8bb9d846b2c64fc291d, which breaks: ``` lldb-api.commands/expression/diagnostics.TestExprDiagnostics.py lldb-api.lang/objc/modules.TestObjCModules.py lldb-api.lang/objc/mo

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

bnbarham wrote: Reverting pending discussion in https://github.com/llvm/llvm-project/pull/66271. We can add it back in there. https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This reverts commit c2fb112021529c635cccd8bb9d846b2c64fc291d, which breaks: ``` lldb-api.commands/expression/diagnostics.TestExprDiagnostics.py lldb-api.lang/objc/modules.TestObjCModules.py lldb-api.lang/objc/modules-incomplete.Te

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/66283: Currently, clang emits LLVM IR that fails verifier for the following code: ``` template __global__ void foo(T x); void bar() { foo<<<1, 1>>>(0); } ``` This is due to clang putting the kernel handle for foo i

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently, clang emits LLVM IR that fails verifier for the following code: ``` template __global__ void foo(T x); void bar() { foo<<<1, 1>>>(0); } ``` This is due to clang putting the kernel handle for foo into comdat, which i

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

dpaoliello added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:37-38 MCSymbol * AArch64MCInstLower::GetGlobalAddressSymbol(const MachineOperand &MO) const { const GlobalValue *GV = MO.getGlobal(); We now also need to call this

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

nickdesaulniers wrote: @nathanchance and I have done a bunch of testing of this revision (see comments https://github.com/ClangBuiltLinux/linux/issues/1923#issuecomment-1718144462 and down); this looks like something that will work nicely for the Linux kernel's use case! Thanks for all of the

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

ldionne wrote: Your `.cfg.in` files can use CMake variables themselves! In fact you can even add new parameters that are only valid for that configuration of the library, for example see https://github.com/llvm/llvm-project/blob/main/libcxx/test/configs/apple-libc%2B%2B-backdeployment.cfg.in#L

[clang] 1b07d43 - [clang] NFCI: Use `FileEntryRef` in `ModuleMap::InferredModuleAllowedBy`

Author: Jan Svoboda Date: 2023-09-13T13:32:26-07:00 New Revision: 1b07d4329880c98f313da426272be5cf50c0768d URL: https://github.com/llvm/llvm-project/commit/1b07d4329880c98f313da426272be5cf50c0768d DIFF: https://github.com/llvm/llvm-project/commit/1b07d4329880c98f313da426272be5cf50c0768d.diff L

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

https://github.com/steakhal approved this pull request. I don't think it deserves a fragile test case. I think the fix looks good. I also agree with your other statements on the addTransition subject. https://github.com/llvm/llvm-project/pull/66109 ___

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

steakhal wrote: I can understand the frustration of the FPs. However, propagating taint there is the right thing to do. To me, the fault is on the diagnostic on the malloc. Those are the cause of the FPs, thus that needs to be removed instead of the propagation. I have this opinion even if the

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

steakhal wrote: I actually wanted to propose another patch where the wchar variant of strlen would propagate taint, BTW. I still plan to do it, we will see when I reach that. https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing lis

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

@@ -43,6 +44,9 @@ __global__ void kernelfunc() {} __global__ void kernel_decl(); +template +__global__ void temp_kernel_decl(T x); Artem-B wrote: Nit: rename temp -> template? `temp` is strongly associated with 'temporary'. https://github.com/llvm/llvm-proj

[clang-tools-extra] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of using

[clang] 2793ef6 - [clang] NFCI: Use `FileEntryRef` in `SrcMgr::ContentCache`

Author: Jan Svoboda Date: 2023-09-13T13:55:32-07:00 New Revision: 2793ef6797a406abf983139b2a18b30a9e277687 URL: https://github.com/llvm/llvm-project/commit/2793ef6797a406abf983139b2a18b30a9e277687 DIFF: https://github.com/llvm/llvm-project/commit/2793ef6797a406abf983139b2a18b30a9e277687.diff L

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of using

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zeroomega wrote: Relanded as a866ce789eb99da4d7a486eeb60a53be6c75f4fd. I will monitor the bots and manually trigger clean build if linker error appears again. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of using

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of using

<    1   2   3   4   5   >