[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556629. iana added a comment. Adjust for the changes in D159483 . Mostly the header guards that were added in that review have moved to this one, the stdarg module needs to always be allowed, and a few tests needed to adjust f

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556630. iana added a comment. Actually allow the stdarg module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp clang/lib/Headers/__

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

hazohelet wrote: Thanks for the detailed suggestion! I agree it's the appropriate approach. I was planning to separate `Wformat-truncation` from `Wfortify-source` sometime after this PR (as was requested in the same issue), but now that we are going to introduce a new warning group, we should

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -247,6 +247,10 @@ Changes in existing checks ` to support for-loops with iterators initialized by free functions like ``begin``, ``end``, or ``size``. +- Improved :doc:`modernize-use-emplace + ` to not replace aggregates that + ``emplace_back`` cannot construct with a

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/PiotrZSL approved this pull request. Overall LGTM, check comments, and verify if check shouldn't be made more strict. https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -1332,6 +1337,17 @@ void testBracedInitTemporaries() { v3.push_back(NonTrivialWithCtor{{}}); v3.push_back({{0}}); v3.push_back({{}}); + + std::vector v4; + + // These should not be noticed or fixed; after the correction, the code won't + // compile. + v4.push_back(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66181: I don't now squat about Objective C, but the extra variable (and cast) seemed unnecessary and this is a good opportunity to re-format that ugly parameter list. >From 37501edc47aea61b09ab775dbbc36b801cc0994e M

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

llvmbot wrote: @llvm/pr-subscribers-clang Changes I don't now squat about Objective C, but the extra variable (and cast) seemed unnecessary and this is a good opportunity to re-format that ugly parameter list. -- Full diff: https://github.com/llvm/llvm-project/pull/66181.diff

[clang] Implement ACLE rintn and rintnf intrinsics (PR #66112)

https://github.com/davemgreen commented: Could this use __builtin_roundeven directly, avoiding the need for __builtin_arm_rintnf? https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021: >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/2] [Clang] Static member initializers are not immediate esca

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

DavidSpickett wrote: Maybe I just need to learn how to use Github, but did half the document disappear? I see a reference to the attacks section `See the section on `Attacks on pointer authentication`_ for more information.` but the section is gone from the diff even in a private window. htt

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH] [AArch64][SME]Update intrinsic interface for ld1/st1

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH] [AArch64][SME]Update intrinsic interface for ld1/st1

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,105 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,105 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] f5d41c1 - [clang][Sema] Rename ActOnIVar parameter (#66181)

Author: Timm Baeder Date: 2023-09-13T11:00:44+02:00 New Revision: f5d41c1dd4487e87796bf6076f2bf6f23c3f4987 URL: https://github.com/llvm/llvm-project/commit/f5d41c1dd4487e87796bf6076f2bf6f23c3f4987 DIFF: https://github.com/llvm/llvm-project/commit/f5d41c1dd4487e87796bf6076f2bf6f23c3f4987.diff L

[clang] [clang][Sema] Rename ActOnIVar parameter (PR #66181)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,105 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][ARM] Enable --print-supported-extensions for ARM (PR #66083)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 99594ba - [clang][ARM] Enable --print-supported-extensions for ARM (#66083)

Author: David Spickett Date: 2023-09-13T10:10:57+01:00 New Revision: 99594ba30aaba7ad7c0850923bac474e4676af8e URL: https://github.com/llvm/llvm-project/commit/99594ba30aaba7ad7c0850923bac474e4676af8e DIFF: https://github.com/llvm/llvm-project/commit/99594ba30aaba7ad7c0850923bac474e4676af8e.diff

[clang] [clang][ARM] Enable --print-supported-extensions for ARM (PR #66083)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,44 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to m

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,44 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to m

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

https://github.com/PiotrZSL commented: Few more nits, consider improving documentation & diagnostic message. https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969: >From 5ee1a4f83c69b5e2910ea883dca7f0fa2c1a4bd3 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Wed, 13 Sep 2023 17:43:11 +0900 Subject: [PATCH 1/2] [clang][Diagnostics] Separate Wformat-overflow and Wform

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

@@ -245,10 +245,10 @@ runDataflowAnalysis( /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. -template -llvm::Expected> diagnoseFunction( +template +llvm::Expected diagnoseFunction(

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

0x59616e wrote: > There is also the question of what happen in the deeply nested case > > ```c++ > int foo(auto...); > auto f(auto... a) { >return [] { >return [] () requires requires { foo(a...) ;} {}; >}(); > } > > auto g = f()(); > ``` > > we may have to visit all functi

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/martinboehme deleted https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

@@ -1427,8 +1427,13 @@ void StdLibraryFunctionsChecker::checkPostCall(const CallEvent &Call, }); Pred = C.addTransition(NewState, Pred, Tag); } - if (!Pred) + if (!Pred || Pred->isSink()) { +// Pred may be: +// - a nullpoint

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

martinboehme wrote: > Updated to enforce llvm::SmallVector, per Martin's recommendation. PTAL. LGTM, but note that the PR title is now out of date. https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/66109: >From b5c45907b0a5c075dfdbd7f6b3727634d976787b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Tue, 12 Sep 2023 18:07:34 +0200 Subject: [PATCH] [analyzer] Fix StdLibraryFunctionsChecker cra

[PATCH] D158169: [X86] Fix i128 argument passing under SysV ABI

RalfJung added a comment. > I think the CCIfSplit means it was larger than i64 to start. What about the case where R9 would take the *second* half of a split i128 (i.e., the value gets split across R8 and R9

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

https://github.com/DonatNagyE resolved https://github.com/llvm/llvm-project/pull/66109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StdLibraryFunctionsChecker crash on surprising sink node (PR #66109)

@@ -1427,8 +1427,13 @@ void StdLibraryFunctionsChecker::checkPostCall(const CallEvent &Call, }); Pred = C.addTransition(NewState, Pred, Tag); } - if (!Pred) + if (!Pred || Pred->isSink()) { +// Pred may be: +// - a nullpoint

[clang] Implement ACLE rintn and rintnf intrinsics (PR #66112)

https://github.com/RKSimon review_request_removed https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement ACLE rintn and rintnf intrinsics (PR #66112)

https://github.com/RKSimon unlabeled https://github.com/llvm/llvm-project/pull/66112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -108,6 +108,16 @@ class DataflowAnalysisContext { /// A null `PointeeType` can be used for the pointee of `std::nullptr_t`. PointerValue &getOrCreateNullPointerValue(QualType PointeeType); + /// Adds `Constraint` to current and future flow conditions in this context. +

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula &Val1, } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector &Constraints, -llvm::DenseSet &VisitedTokens) { - auto Res = VisitedTokens.

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula &Val1, } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector &Constraints, -llvm::DenseSet &VisitedTokens) { - auto Res = VisitedTokens.

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

@@ -150,7 +157,7 @@ bool DataflowAnalysisContext::flowConditionImplies(Atom Token, Constraints.insert(&arena().makeAtomRef(Token)); Constraints.insert(&arena().makeNot(Val)); llvm::DenseSet VisitedTokens; sam-mccall wrote: Indeed, oops! https://github.

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/65949: >From 1d765a3b22cd81d6739a20f2b2f7b68935773f2a Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Mon, 11 Sep 2023 13:21:11 +0200 Subject: [PATCH 1/3] [dataflow] Add global condition to DataflowAnalysisContext

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

Keenuts accepted this revision. Keenuts added a comment. This revision is now accepted and ready to land. LGTM from the SPIR-V side. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 ___

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH 1/2] [AArch64][SME]Update intrinsic interface for ld1

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -20,8 +20,10 @@ // CHECK-NEXT:ret void // ARM_STREAMING_ATTR void test_svld1_hor_za8(uint32_t slice_base, svbool_t pg, const void *ptr) { - svld1_hor_za8(0, slice_base, 0, pg, ptr); - svld1_hor_za8(0, slice_base, 15, pg, ptr); + uint32_t slice = slice_base; -

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[clang-tools-extra] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

martinboehme wrote: > > I don't see problem described by this check as an performance issue. For > > example: > > ``` > > std::unique_ptr> ptr; > > std::vector local = std::move(*ptr); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > No performance

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema &S, if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if (S.getLangOpts().CPlusP

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema &S, if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if (S.getLangOpts().CPlusP

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/Fznamznon commented: This needs a release note. cc @erichkeane https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

martinboehme wrote: > This check has issue in my opinion, the semantic of `std::move(*p)` is not > same as `*std::move(p)` Agree that the suggested fix may not always be correct. I would suggest simply not emitting a suggested fix (i.e. only emitting a warning). https://github.com/llvm/llvm-

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

martinboehme wrote: > This check has issue in my opinion, the semantic of `std::move(*p)` is not > same as `*std::move(p)` Agree that the suggested fix may not always be correct. I would suggest simply not emitting a suggested fix (i.e. only emitting a warning). https://github.com/llvm/llvm-

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/66139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,95 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

PiotrZSL wrote: Other common example from me: ``` struct SomeHeavyClass {}; std::unique_ptr build(); void sendMsg() { auto msgContent = build(); Message msg; msg.content = std::move(*msgContent); send(msg); } ``` And next one: ``` struct Info { virtual const std::string& get

[PATCH] D157205: [clangd] Add hexadecimal member offsets and sizes to hover popup

tetraxile added a comment. Just bumping this patch, I'd like if it could get reviewed before Phabricator becomes read-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157205/new/ https://reviews.llvm.org/D157205 ___ cfe-commits mailing li

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak added a comment. Thank you for the review. After I address your last comment my plan is to land this and the other two accepted REQUIRES patches that depended on it. Is there a preferred approach as to how to go about it? I could rebase them all and wait until the pre-merge builds finis

[clang] 88b7e06 - Revert "[clang][CodeGen] Emit annotations for function declarations."

Author: Benjamin Kramer Date: 2023-09-13T13:22:57+02:00 New Revision: 88b7e06dcf9723d0869b0c6bee030b4140e4366d URL: https://github.com/llvm/llvm-project/commit/88b7e06dcf9723d0869b0c6bee030b4140e4366d DIFF: https://github.com/llvm/llvm-project/commit/88b7e06dcf9723d0869b0c6bee030b4140e4366d.dif

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

kiranchandramohan added a comment. In D147218#4645055 , @skatrak wrote: > Thank you for the review. After I address your last comment my plan is to > land this and the other two accepted REQUIRES patches that depended on it. > > Is there a preferred appr

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

bkramer added a comment. Reverted this in 88b7e06dcf9723d0869b0c6bee030b4140e4366d as it makes clang crash. Reduced test case in the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

  1   2   3   4   5   >