[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -96,6 +96,21 @@ void JSONNodeDumper::Visit(QualType T) { JOS.attribute("qualifiers", T.split().Quals.getAsString()); } +void JSONNodeDumper::Visit(TypeLoc TL) { + if (TL.isNull()) +return; + JOS.attribute("kind", +(llvm::Twine(TL.getTypeLocClass() ==

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -415,9 +443,55 @@ class ASTNodeTraverser if (!T->isSugared()) Visit(T->getPattern()); } + void VisitAutoType(const AutoType *T) { +for (const auto &Arg : T->getTypeConstraintArguments()) + Visit(Arg); + } // FIXME: ElaboratedType, DependentNameType,

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -458,6 +532,9 @@ class ASTNodeTraverser if (Traversal == TK_IgnoreUnlessSpelledInSource && D->isCXXForRangeDecl()) return; +if (VisitLocs) sam-mccall wrote: Yes, there may be others but for now this is the only place I found where a Loc node

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/65484: >From f2269d93e313378581085bca418914229316bfc6 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Mon, 4 Sep 2023 15:48:47 +0200 Subject: [PATCH 1/3] [AST] Add dump() method to TypeLoc The ability to dump AST n

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The ability to dump AST nodes is important to ad-hoc debugging, and the fact this doesn't work with TypeLoc nodes is an obvious missing feature in e.g. clang-query (`set output dump` simply does nothing). Having TypeLoc::dump(), and enabling D

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -10,14 +10,10 @@ Cleaned up as follows: # Remove all the unnecessary files and directories $ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore $ rm -rf build-aux make msvc scripts test docs -$ rm -f `find . -name \*\.pump` $ rm -f s

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zeroomega wrote: I have addressed all review comments in the the latest amend commits. Please take a look. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

cpsauer wrote: 🎉 https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/65993: >From 52bcb5537fe67cdb93d50c16de181d87a7bcffc5 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 11 Sep 2023 11:28:04 -0700 Subject: [PATCH 1/2] Fix out of line Concept-comparisons of NestedNameSpecifiers

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList &Result) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier();

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

erichkeane wrote: So the latest patch doesn't FIX it, it has a problem with: ``` template concept Concept = true; template struct S { struct Inner0 { struct Inner1 { template static constexpr int method(); }; }; }; template<> template constexpr int S<1>::Inner0::Inner1::method() { return 0;

[clang] f2a1331 - [CUDA][HIP] Do not mark extern shared var (#65990)

Author: Yaxun (Sam) Liu Date: 2023-09-11T17:04:55-04:00 New Revision: f2a1331a01ff8ad19fed6bd407501791467ad061 URL: https://github.com/llvm/llvm-project/commit/f2a1331a01ff8ad19fed6bd407501791467ad061 DIFF: https://github.com/llvm/llvm-project/commit/f2a1331a01ff8ad19fed6bd407501791467ad061.dif

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList &Result) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier();

[clang] cc20130 - Revert "[Driver] Properly report error for unsupported powerpc darwin/macos triples"

Author: Nico Weber Date: 2023-09-11T14:08:59-07:00 New Revision: cc2013061ee63f3fc4f9b49c6d836d99d102071b URL: https://github.com/llvm/llvm-project/commit/cc2013061ee63f3fc4f9b49c6d836d99d102071b DIFF: https://github.com/llvm/llvm-project/commit/cc2013061ee63f3fc4f9b49c6d836d99d102071b.diff LO

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102 +outs() << "\n"; +return; + } aeubanks wrote: > I wouldn't return here, doesn't seem right that we'll skip running the opt > pipeline but continue with compilation.

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

jcranmer-intel updated this revision to Diff 556483. jcranmer-intel added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127221/new/ https://reviews.llvm.org/D127221 Files: clang/lib/CodeGen/BackendUtil.cpp c

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

rsmith added a comment. The changes in `SemaInit.cpp` don't look correct to me. Trying to recurse through the initializer and find every nested temporary is highly error-prone; I can't tell you which expression nodes you forgot to recurse through, but I'm sure there are some. I think the appro

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

thakis added inline comments. Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fopen

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList &Result) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier();

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4126101 , @erichkeane wrote: > On the fence about the diagnostic at all, but definitely should not be doing > string magic to make it quoted. Otherwise this is a LGTM. Whoops, missed this comment. I'll be addressing yo

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 556484. ZijunZhao added a comment. update the reformat msg and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/in

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

aeubanks accepted this revision. aeubanks added a comment. lg with one test comment Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102 +outs() << "\n"; +return; + } jcranmer-intel wrote: > aeubanks wrote: > > I wouldn't return here, doesn't seem right

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

aeubanks added inline comments. Comment at: clang/test/CodeGen/print-pipeline-passes.c:8 +// CHECK: always-inline +// CHECK-SAME: verify +void Foo(void) {} aeubanks wrote: > I believe this will fail in non-assert builds since we don't run the verifier in non-asse

[clang] 238a1ef - [test] Add x86-registered-target to amdgpu_throw_trap.cpp

Author: Arthur Eubanks Date: 2023-09-11T14:30:12-07:00 New Revision: 238a1ef44f4f2361205e538b3cb7ebc5ec70894d URL: https://github.com/llvm/llvm-project/commit/238a1ef44f4f2361205e538b3cb7ebc5ec70894d DIFF: https://github.com/llvm/llvm-project/commit/238a1ef44f4f2361205e538b3cb7ebc5ec70894d.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

aeubanks added inline comments. Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fop

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

thakis added inline comments. Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fopen

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4643577 , @rjmccall wrote: > In D74094#4643558 , @nickdesaulniers > wrote: > >> In D74094#4643495 , @rjmccall wrote: >> >>> I can'

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -10,14 +10,10 @@ Cleaned up as follows: # Remove all the unnecessary files and directories $ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore $ rm -rf build-aux make msvc scripts test docs -$ rm -f `find . -name \*\.pump` $ rm -f s

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. Thanks for fixing my tests! This is the second time I messed up the requirements. I am very sorry about that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand created https://github.com/llvm/llvm-project/pull/66014: The template is agnostic as to the type used by the list, as long as it is compatible with `llvm::move` and `std::back_inserter`. In practice, we've encountered analyses which use different types (`llvm::SmallVect

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

llvmbot wrote: @llvm/pr-subscribers-clang-analysis Changes The template is agnostic as to the type used by the list, as long as it is compatible with `llvm::move` and `std::back_inserter`. In practice, we've encountered analyses which use different types (`llvm::SmallVector` vs `std::vector`)

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The template is agnostic as to the type used by the list, as long as it is compatible with `llvm::move` and `std::back_inserter`. In practice, we've encountered analyses which use different types (`llvm::SmallVector` vs `std::vector`), so it s

[clang] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/66014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][dataflow] Change `diagnoseFunction` to take type of diagnostic list instead of diagnostic itself. (PR #66014)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes The template is agnostic as to the type used by the list, as long as it is compatible with `llvm::move` and `std::back_inserter`. In practice, we've encountered analyses which use different types (`llvm::SmallVector` vs `std::vector`), so

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556488. cjdb added a comment. responds to feedback: - removes diagnostic - adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: clang/docs/Langua

[clang] Extension: allow recursive macros (PR #65851)

https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/8] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

aeubanks added inline comments. Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fop

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

efriedma added a comment. I don't really like `extern cl::opt PrintPipelinePasses;` (as opposed to implementing a proper driver option that calls a proper API); secret handshakes like this make it harder for people to write non-clang frontends. But I won't block the patch just for that, I gues

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

thakis added inline comments. Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fopen

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/bnbarham approved this pull request. Thanks for looking into this @daniel-grumberg! LGTM except for the few small comments. https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/bnbarham edited https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

@@ -592,19 +524,22 @@ void ASTContext::attachCommentsToJustParsedDecls(ArrayRef Decls, D = &adjustDeclToTemplate(*D); -const SourceLocation DeclLoc = getDeclLocForCommentSearch(D, SourceMgr); +const auto DeclLocs = getDeclLocsForCommentSearch(D, SourceMgr); -

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

@@ -374,11 +374,10 @@ TEST(SourceCodeTest, getAssociatedRangeWithComments) { // Does not include comments when only the decl or the comment come from a // macro. bnbarham wrote: Comment isn't true any more. The comment on line 370 is also confusing to me,

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

@@ -167,115 +167,41 @@ static SourceLocation getDeclLocForCommentSearch(const Decl *D, isa(D)) return {}; + SmallVector Locations; // Find declaration location. // For Objective-C declarations we generally don't expect to have multiple // declarators, thus

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

@@ -56,7 +56,6 @@ void functionFromMacro(void) { \ typedef struct Struct_notdoxy Struct_notdoxy; \ } -/// IS_DOXYGEN_NOT_ATTACHED bnbarham wrote: I think it would be worth adding another test case where we have this one and check that it uses this

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/66021: Per CWG2760, default members initializers should be consider part the body of constructors, which mean they are evaluated in an immediate escalating context. However, this does not apply to static members. Th

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin review_requested https://github.com/llvm/llvm-project/pull/66021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Per CWG2760, default members initializers should be consider part the body of constructors, which mean they are evaluated in an immediate escalating context. However, this does not apply to static members. This patch produces some extraneous

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp updated https://github.com/llvm/llvm-project/pull/65401: >From b8cac30c34d7c26dd3ec8e3e00678d2034e9f51c Mon Sep 17 00:00:00 2001 From: Cassie Jones Date: Tue, 5 Sep 2023 12:12:45 -0700 Subject: [PATCH 1/2] [include-mapping] Python fixes - Move the multiprocessing.

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp resolved https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/65993: >From 52bcb5537fe67cdb93d50c16de181d87a7bcffc5 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 11 Sep 2023 11:28:04 -0700 Subject: [PATCH 1/3] Fix out of line Concept-comparisons of NestedNameSpecifiers

[clang] [include-mapping] Python fixes (PR #65401)

porglezomp wrote: Done https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

erichkeane wrote: Alright, I think I got it this time, we'll see how the buildbots treat it, but it passes locally for me. https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [include-mapping] Python fixes (PR #65401)

llvmbot wrote: @llvm/pr-subscribers-clang Changes I had to regenerate the include mapping while resolving a downstream merge conflict, and ran into two issue on my machine. These shouldn't change anything, just make things work on my config. - Move the `multiprocessing.Pool` initializer to

[clang] [include-mapping] Python fixes (PR #65401)

https://github.com/porglezomp review_requested https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bf06f14 - Fix a few messed up links in the ReleaseNotes

Author: erichkeane Date: 2023-09-11T15:32:16-07:00 New Revision: bf06f149f646cf1a86b35fecb6d662309a3f6592 URL: https://github.com/llvm/llvm-project/commit/bf06f149f646cf1a86b35fecb6d662309a3f6592 DIFF: https://github.com/llvm/llvm-project/commit/bf06f149f646cf1a86b35fecb6d662309a3f6592.diff LO

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

erichkeane added a comment. Is the changes to cxx_status.html still relevant/current? Also, did we ever figure out what GCC did for a builtin here? Do they have one yet? If not, have we encouraged them to implement this one? If so, DID they implement this one? Repository: rG LLVM Github

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added a comment. > Fuck me for trying to help, right? If x-values are part of the "basics" of > parameter passing, I'm afraid to ask about the more complicated cases. I can see how my response was somewhat aggressive, and I regret that and apologize. I imagine you're probably approach

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4643712 , @erichkeane wrote: > Is the changes to cxx_status.html still relevant/current? Yeah. > Also, did we ever figure out what GCC did for a builtin here? Do they have > one yet? If not, have we encouraged them t

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 556494. ZijunZhao added a comment. add #include_next Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. Oh, I shouldn't have so much green in the status, whoops! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 ___ cfe-commits mailing list cfe

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -214,14 +214,14 @@ class LLVM_MemcpyIntrOpBase : /*requiresAccessGroup=*/1, /*requiresAliasAnalysis=*/1> { dag args = (ins Arg:$dst, Arg:$src, - AnySignlessInteger:$len, I1Attr:$isVolatile); joker-eph wrote: Seems to

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 556496. ZijunZhao added a comment. update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556497. cjdb retitled this revision from "[clang] adds `__reference_constructs_from_temporary`" to "adds `__reference_constructs_from_temporary`". cjdb edited the summary of this revision. cjdb added a comment. Corrects cxx_status.html, which accidentally dupli

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

https://github.com/petrhosek review_requested https://github.com/llvm/llvm-project/pull/66025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

https://github.com/petrhosek review_requested https://github.com/llvm/llvm-project/pull/66025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/66025: We support RISC-V on Linux as the host platform for Fuchsia. >From d852343fdeae38eb1e96791533c3811af24fe534 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Mon, 11 Sep 2023 22:50:43 + Subject: [PATCH] [Fu

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

llvmbot wrote: @llvm/pr-subscribers-clang Changes We support RISC-V on Linux as the host platform for Fuchsia. -- Full diff: https://github.com/llvm/llvm-project/pull/66025.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+1-1) diff --git a/clang/cmake/caches/

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556499. cjdb added a comment. I somehow made cxx_status.html worse in the previous commit, not better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: clang/docs

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 556500. cjdb added a comment. runs 'arc diff `git merge-base HEAD origin` --update D135238 ' to try and get CI happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ htt

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65933: >From 70aafbc4717264205796fa2ea67d78482f9f2a0d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` F

[clang] e1bfeb6 - adds `__reference_constructs_from_temporary`

Author: Christopher Di Bella Date: 2023-09-11T23:14:08Z New Revision: e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54 URL: https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54 DIFF: https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54.dif

[PATCH] D135341: adds `__reference_constructs_from_temporary`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1bfeb6bcc62: adds `__reference_constructs_from_temporary` (author

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb added a comment. Sorry, I had read @erichkeane's LGTM and taken that as actually approved. Would you like me to revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 __

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 556504. ZijunZhao added a comment. Remove c++ related conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst clang/includ

[clang] [Fuchsia] Support building runtimes for RISC-V on Linux (PR #66025)

https://github.com/abrachet approved this pull request. https://github.com/llvm/llvm-project/pull/66025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a2e2f47 - [Clang][Docs] Fix typo in clang-offload-packager documentation

Author: Alexey Bader Date: 2023-09-11T16:24:37-07:00 New Revision: a2e2f471c51f0aea836a4929dfdf50523dcff1eb URL: https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb DIFF: https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb.diff

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafetyCommon.cpp:320 // Substitute call arguments for references to function parameters -assert(I < Ctx->NumArgs); -return translate(Ctx->FunArgs[I], Ctx->Prev); +if (const a

[clang] [libc][libm][GPU] Added missing vendor entry points to `libm` for GPUs (PR #66031)

Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=, Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar <1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song ,Razvan Lupusoru ,Walter Erquinigo ,"Yaxun (Sam) Liu" ,Nico Weber ,Stella Laurenzo ,Lang Hames ,Matthias Braun ,Arthur

<    1   2   3   4   5   6   7   >