[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/65990: Fixes: https://github.com/llvm/llvm-project/issues/65806 Currently clang put extern shared var ODR-used by host device functions in global var __clang_gpu_used_external. This behavior was due to https://revie

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Fixes: https://github.com/llvm/llvm-project/issues/65806 Currently clang put extern shared var ODR-used by host device functions in global var __clang_gpu_used_external. This behavior was due to https://reviews.llvm.org/D123441. However, cla

[clang] [CUDA][HIP] Do not mark extern shared var (PR #65990)

2023-09-11 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM. Thank you! https://github.com/llvm/llvm-project/pull/65990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

2023-09-11 Thread Elliott Hughes via Phabricator via cfe-commits
enh added a comment. (yeah, similar for Android --- we'll just use the clang one as-is. but if there's already precedent for allowing include_next, that doesn't hurt us either.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://re

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Zero Omega via cfe-commits
@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Zero Omega via cfe-commits
@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ PRIVATE googletest googlemock ) add_subdirectory(UnitTestMain) if (LLVM_INSTALL_GTEST) install(TARGETS llvm_gtest llvm_gtest_m

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Zero Omega via cfe-commits
@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ zeroomega wrote: My checkout just stales. Thanks for pointing it out. https://github.com/llvm/llvm-project/pull/65823

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. I manually set the code object of the `libc` test suite to be `4` for the time being. That should unblock this. https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-com

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
@@ -10,14 +10,10 @@ Cleaned up as follows: # Remove all the unnecessary files and directories $ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore $ rm -rf build-aux make msvc scripts test docs -$ rm -f `find . -name \*\.pump` $ rm -f s

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/65993: As reported in GH65810, we don't properly collect ALL of the template parameters in a nested name specifier, and were only doing the 'inner level'. This patch makes sure we collect from all levels. Fixes: #

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane review_requested https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes As reported in GH65810, we don't properly collect ALL of the template parameters in a nested name specifier, and were only doing the 'inner level'. This patch makes sure we collect from all levels. Fixes: #65810 -- Full diff: https://github.

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I can't easily tell you because the "standalone example" involves a million templates that I don't know anything about, and nobody seems to have done the analysis to identify the specific source of the miscompile. What I can tell you is that there is an enormous semant

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: thanks for your comments, > When I refer to CSE/DSE, I'm mostly talking about keeping values in registers > for longer. They don't know anything about individual fields in bitfields. If > we split bitfields too narrowly, we end up with extra memory accesses for > accessing mul

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan review_requested https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha created https://github.com/llvm/llvm-project/pull/65996: This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-f

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note tha

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note that

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note that this o

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note that

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note t

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-fptrauth-intrinsics`. Note tha

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

2023-09-11 Thread Ahmed Bougacha via Phabricator via cfe-commits
ab abandoned this revision. ab added a comment. This went through so many rebases that the incremental diff is not very helpful ;) Let's start over on github: https://github.com/llvm/llvm-project/pull/65996 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llv

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-11 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch updated https://github.com/llvm/llvm-project/pull/65483: >From 5a56cffb1e53e8c7415bf468a7edfb464fbc08a0 Mon Sep 17 00:00:00 2001 From: Aaron Jarmusch Date: Wed, 6 Sep 2023 13:56:16 + Subject: [PATCH 1/3] [Clang][OpenMP] Clang adding the addrSpace according to D

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-11 Thread Aaron Jarmusch via cfe-commits
ajarmusch wrote: @alexey-bataev sorry for the delay - the test is up https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

2023-09-11 Thread Yuri Istomin via Phabricator via cfe-commits
NekoCdr added a comment. @AshleyRoll are you still working on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126960/new/ https://reviews.llvm.org/D126960 ___ cfe-commits mailing list cfe-commi

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-11 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 556474. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp =

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

2023-09-11 Thread Zijun Zhao via Phabricator via cfe-commits
ZijunZhao updated this revision to Diff 556475. ZijunZhao marked an inline comment as done. ZijunZhao added a comment. Reformat the error msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-09-11 Thread Sam McCall via cfe-commits
@@ -223,6 +238,22 @@ void JSONNodeDumper::Visit(const APValue &Value, QualType Ty) { JOS.attribute("value", OS.str()); } +void JSONNodeDumper::Visit(const ConceptReference *CR) { + JOS.attribute("kind", "ConceptReference"); + JOS.attribute("id", createPointerRepresentatio

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall resolved https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Shafik Yaghmour via cfe-commits
@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList &Result) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier();

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

2023-09-11 Thread Joshua Cranmer via Phabricator via cfe-commits
jcranmer-intel updated this revision to Diff 556476. jcranmer-intel added a comment. Rebase to trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127221/new/ https://reviews.llvm.org/D127221 Files: clang/lib/CodeGen/BackendUtil.cpp clang/tes

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
@@ -231,14 +231,18 @@ Response HandleFunctionTemplateDecl(const FunctionTemplateDecl *FTD, MultiLevelTemplateArgumentList &Result) { if (!isa(FTD->getDeclContext())) { NestedNameSpecifier *NNS = FTD->getTemplatedDecl()->getQualifier();

[clang] Fix out of line Concept-comparisons of NestedNameSpecifiers (PR #65993)

2023-09-11 Thread Erich Keane via cfe-commits
erichkeane wrote: Huh, blarg, build-bot found an issue with my patch, curiously in the same file I was editing! I'll look into it. I at least reproduce it, which is nice... https://github.com/llvm/llvm-project/pull/65993 ___ cfe-commits mailing list

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D158540#4638605 , @NoumanAmir657 wrote: > In D158540#4632457 , @NoumanAmir657 > wrote: > >> @aaron.ballman >> This error gets generated on test cases even when a struct/class a

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

2023-09-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: efriedma, rjmccall. aaron.ballman added a comment. Adding codegen code owners as reviewers just so they're aware (I think you're fine to land these changes if you don't hear back in the next day or two). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-11 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,580 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --include-generated-funcs --replace-value-regex "__omp_offloading_[0-9a-z]+_[0-9a-z]+" "reduction_size[.].+[.]" "pl_cond[.].+[.|,]" --prefix-filecheck-ir-name _ --version

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

2023-09-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm labeled https://github.com/llvm/llvm-project/pull/65737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Changes Differential Revision: https://reviews.llvm.org/D159257 -- Full diff: https://github.com/llvm/llvm-project/pull/65737.diff 4 Files Affected: - (modified) clang/lib/CodeGen/CGCall.cpp (+20) - (modified) clang/lib/CodeGen/CGCall.h (+5

[clang] [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode (PR #65737)

2023-09-11 Thread Matt Arsenault via cfe-commits
@@ -375,6 +375,11 @@ class ReturnValueSlot { bool isExternallyDestructed() const { return IsExternallyDestructed; } }; +/// If \p F "target-features" are incompatible with the \p TargetOpts features, arsenm wrote: I think this comment needs more elaboration

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Zero Omega via cfe-commits
@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Zero Omega via cfe-commits
https://github.com/zeroomega resolved https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D74094#4643495 , @rjmccall wrote: > I can't easily tell you because the "standalone example" involves a million > templates that I don't know anything about, and nobody seems to have done the > analysis to identify the

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread Daniel Bertalan via cfe-commits
https://github.com/BertalanD created https://github.com/llvm/llvm-project/pull/66005: GCC has gained support for these multiprecision arithmetic builtins in `r14-1896-g2b4e0415ad6`, and although they aren't explicitly specified as such in the documentation, they are usable in a constexpr conte

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread Daniel Bertalan via cfe-commits
https://github.com/BertalanD review_requested https://github.com/llvm/llvm-project/pull/66005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes GCC has gained support for these multiprecision arithmetic builtins in `r14-1896-g2b4e0415ad6`, and although they aren't explicitly specified as such in the documentation, they are usable in a constexpr context. This commit adds constexpr ev

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-11 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 added a comment. **Code:** struct Base { constexpr Base() = default; }; struct Derived : virtual Base { constexpr Derived() = default; }; struct NoCopyMove { constexpr NoCopyMove() {} NoCopyMove(const NoCopyMove&); NoCopyMove(NoCopyMove&&); }; str

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Yitzhak Mandelbaum via cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula &Val1, } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector &Constraints, -llvm::DenseSet &VisitedTokens) { - auto Res = VisitedTokens.

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Yitzhak Mandelbaum via cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const Formula &Val1, } void DataflowAnalysisContext::addTransitiveFlowConditionConstraints( -Atom Token, llvm::SetVector &Constraints, -llvm::DenseSet &VisitedTokens) { - auto Res = VisitedTokens.

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

2023-09-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102 +outs() << "\n"; +return; + } I wouldn't return here, doesn't seem right that we'll skip running the opt pipeline but continue with compilation. we should either bail out

[clang] [clang] Implement constexpr evaluation for `__builtin_{add,sub}c` (PR #66005)

2023-09-11 Thread Daniel Bertalan via cfe-commits
https://github.com/BertalanD updated https://github.com/llvm/llvm-project/pull/66005: >From 1a1f9ce09efb51a26440f378334df97ec014cad5 Mon Sep 17 00:00:00 2001 From: Daniel Bertalan Date: Sat, 22 Jul 2023 08:20:45 +0200 Subject: [PATCH] [clang] Implement constexpr evaluation for `__builtin_{add,

[PATCH] D156156: [clang] Implement constexpr evaluation for `__builtin_{add,sub}c`

2023-09-11 Thread Daniel Bertalan via Phabricator via cfe-commits
BertalanD abandoned this revision. BertalanD added a comment. Moved to https://github.com/llvm/llvm-project/pull/66005 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156156/new/ https://reviews.llvm.org/D156156 _

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D74094#4643558 , @nickdesaulniers wrote: > In D74094#4643495 , @rjmccall wrote: > >> I can't easily tell you because the "standalone example" involves a million >> templates that I don

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-09-11 Thread Sam McCall via cfe-commits
@@ -415,9 +443,55 @@ class ASTNodeTraverser if (!T->isSugared()) Visit(T->getPattern()); } + void VisitAutoType(const AutoType *T) { +for (const auto &Arg : T->getTypeConstraintArguments()) + Visit(Arg); + } // FIXME: ElaboratedType, DependentNameType,

[clang] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru updated https://github.com/llvm/llvm-project/pull/65776: >From 967089f4e81d5bfcddeabddf81ab90912b5cc3b3 Mon Sep 17 00:00:00 2001 From: Razvan Lupusoru Date: Fri, 8 Sep 2023 09:06:57 -0700 Subject: [PATCH 1/4] [flang][openacc] Enable lowering support for OpenACC

[clang-tools-extra] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru updated https://github.com/llvm/llvm-project/pull/65776: >From 967089f4e81d5bfcddeabddf81ab90912b5cc3b3 Mon Sep 17 00:00:00 2001 From: Razvan Lupusoru Date: Fri, 8 Sep 2023 09:06:57 -0700 Subject: [PATCH 1/4] [flang][openacc] Enable lowering support for OpenACC

[clang] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Changes Since the OpenACC atomics specification is a subset of OpenMP atomics, the same lowering implementation can be used. This change extracts out the necessary pieces from the OpenMP lowering and puts them in a shared spot. The shared s

[clang-tools-extra] [flang][openacc] Enable lowering support for OpenACC atomic operations (PR #65776)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Changes Since the OpenACC atomics specification is a subset of OpenMP atomics, the same lowering implementation can be used. This change extracts out the necessary pieces from the OpenMP lowering and puts them in a shared spot. The shared s

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

2023-09-11 Thread Sam McCall via cfe-commits
@@ -458,6 +532,9 @@ class ASTNodeTraverser if (Traversal == TK_IgnoreUnlessSpelledInSource && D->isCXXForRangeDecl()) return; +if (VisitLocs) + if (const auto *TSI = D->getTypeSourceInfo()) +Visit(TSI->getTypeLoc()); sam-mccall wrote

<    1   2   3   4   5   6   7   >