[PATCH] D159490: Fix warning in MSVC

fdeazeve added a comment. I think this may have broken builds: worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function definition is not allowed here static bool mustPrintOnLeftSide(const Attr *A) { Probably missing a `}`? Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi added a comment. In D159490#4643191 , @fdeazeve wrote: > I think this may have broken builds: > > worktrees/src1/clang/lib/AST/DeclPrinter.cpp:293:48: error: function > definition is not allowed here > static bool mustPrintOnLeftSid

[PATCH] D159490: Fix warning in MSVC

erichkeane added a comment. In D159490#4643196 , @giulianobelinassi wrote: > In D159490#4643191 , @fdeazeve > wrote: > >> I think this may have broken builds: >> >> worktrees/src1/clang/lib/AST/DeclPrinter.cpp

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6c0b9e3 - Remove extra switch from 0323938d

Author: erichkeane Date: 2023-09-11T07:16:27-07:00 New Revision: 6c0b9e35761738726aded3b399db89eb0a86f82b URL: https://github.com/llvm/llvm-project/commit/6c0b9e35761738726aded3b399db89eb0a86f82b DIFF: https://github.com/llvm/llvm-project/commit/6c0b9e35761738726aded3b399db89eb0a86f82b.diff LO

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159490: Fix warning in MSVC

erichkeane added a comment. Fixed in 6c0b9e357617 . I didn't verify ahead of time, but hopefully the bots will yell at ME this time and I'll recognize it right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159490: Fix warning in MSVC

fdeazeve added a comment. In D159490#4643199 , @erichkeane wrote: > Fixed in 6c0b9e357617 > . I > didn't verify ahead of time, but hopefully the bots will yell at ME this time > and

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi added a comment. In D159490#4643199 , @erichkeane wrote: > Fixed in 6c0b9e357617 > . I > didn't verify ahead of time, but hopefully the bots will yell at ME this ti

[clang] 9272aa9 - [Driver] Do not generate error about unsupported target specific options when there is no compiler jobs

Author: Maciej Gabka Date: 2023-09-11T14:58:36Z New Revision: 9272aa9d08cbbf5b8612c264d5d547fdefae26c7 URL: https://github.com/llvm/llvm-project/commit/9272aa9d08cbbf5b8612c264d5d547fdefae26c7 DIFF: https://github.com/llvm/llvm-project/commit/9272aa9d08cbbf5b8612c264d5d547fdefae26c7.diff LOG:

[PATCH] D159361: [Driver] Do not generate error about unsupported target specific options when there is no compiler jobs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9272aa9d08cb: [Driver] Do not generate error about unsupported target specific options when… (authored by mgabka). Herald added a project: clang. Her

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/65966: >From 7cd4fe122a329d29023f978991baa486266a32f3 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Mon, 11 Sep 2023 14:42:27 +0100 Subject: [PATCH 1/2] [LLD][AARCH64] lld incorrectly handles .eh_frame when it

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/65938: From 7051cbfdd484dcb02c786876599820f8d669348e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Mon, 11 Sep 2023 11:00:34 +0200 Subject: [PATCH] [NFC][Clang] Address rev

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/65966: >From 7cd4fe122a329d29023f978991baa486266a32f3 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Mon, 11 Sep 2023 14:42:27 +0100 Subject: [PATCH 1/3] [LLD][AARCH64] lld incorrectly handles .eh_frame when it

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

https://github.com/simpal01 ready_for_review https://github.com/llvm/llvm-project/pull/65966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

@@ -43,7 +43,7 @@ int bar() { return no_attr() + attr_in_target() + attr_not_in_target() + attr_in // CHECK-LABEL: @attr_incompatible // CHECK-SAME: () #[[ATTR_INCOMPATIBLE:[0-9]+]] { -// CHECK: attributes #[[ATTR_BAR]] = { noinline nounwind optnone "no-trapping-math"="true"

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 556436. skatrak added a comment. Update patch. Ping for review and unblocking remaining accepted REQUIRES patches, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

@@ -1333,7 +1333,15 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + int FoldingSetID =

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

@@ -0,0 +1,253 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

@@ -0,0 +1,253 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

@@ -0,0 +1,253 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers closed https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2618154 - [clang][VarDecl] Reset un-evaluated constant for all C++ modes (#65818)

Author: Nick Desaulniers Date: 2023-09-11T08:37:01-07:00 New Revision: 26181544f7512eb2713243f301b712f845de13ef URL: https://github.com/llvm/llvm-project/commit/26181544f7512eb2713243f301b712f845de13ef DIFF: https://github.com/llvm/llvm-project/commit/26181544f7512eb2713243f301b712f845de13ef.di

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -20,8 +20,10 @@ // CHECK-NEXT:ret void // ARM_STREAMING_ATTR void test_svld1_hor_za8(uint32_t slice_base, svbool_t pg, const void *ptr) { - svld1_hor_za8(0, slice_base, 0, pg, ptr); - svld1_hor_za8(0, slice_base, 15, pg, ptr); + uint32_t slice = slice_base; -

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

kiranchandramohan added a comment. Could you add to the summary that the `atomic` related handling is done elsewhere. Could you expand the tests to cover the various `if` conditions that are used in the code? Comment at: flang/include/flang/Lower/OpenMP.h:16 +#include "mli

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65969: GCC stops counting format string's size when it sees %p format in order to avoid `Wformat-truncation` false positive against Linux kernel's format extension (%pOF, for example). This change makes clang's beha

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

llvmbot wrote: @llvm/pr-subscribers-clang Changes GCC stops counting format string's size when it sees %p format in order to avoid `Wformat-truncation` false positive against Linux kernel's format extension (%pOF, for example). This change makes clang's behavior align with GCC's. As requeste

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -96,6 +96,11 @@ void call_snprintf(double d) { __builtin_snprintf(buf, 1, "%.1000g", d); // expected-warning {{'snprintf' will always be truncated; specified size is 1, but format string expands to at least 2}} __builtin_snprintf(buf, 5, "%.1000g", d); __builtin_snpr

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga created https://github.com/llvm/llvm-project/pull/65972: Context BoundsSanitizer is a mitigation that is part of UBSAN. It can be enabled in "trap" mode to crash on OOB array accesses. Problem BoundsSan has zero false positives meaning every crash is a OOB array a

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/oskarwirga review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

oskarwirga wrote: CC: @vitalybuka I addressed some but not all comments pending further clarification :) https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Context BoundsSanitizer is a mitigation that is part of UBSAN. It can be enabled in "trap" mode to crash on OOB array accesses. Problem BoundsSan has zero false positives meaning every crash is a OOB array access, unfortunately optimizations

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -429,7 +429,13 @@ bool clang::analyze_format_string::ParsePrintfString(FormatStringHandler &H, // we can recover from? if (!FSR.hasValue()) continue; -// We have a format specifier. Pass it to the callback. +// We have a format specifier. +// In c

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

https://github.com/nickdesaulniers commented: Thanks for the patch! Can we document this behavior somewhere? https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

@@ -860,6 +860,16 @@ class EstimateSizeFormatHandler : Size(std::min(Format.find(0), Format.size()) + 1 /* null byte always written by sprintf */) {} + bool ShouldStopOnFormatSpecifier(const analyze_printf::PrintfSpecifier &FS, +

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Thank you for the comments! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:752 auto Action = [File = File.str(), Sel, TweakID = TweakID.str(), - CB = std::move(CB), + C

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

https://github.com/smithp35 edited https://github.com/llvm/llvm-project/pull/65966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

https://github.com/smithp35 commented: This will only fix the problem for AArch64, but it also affects other targets. Assuming relocateAlloc is the best place to fix this, then it would need applying in all instances of relocateAlloc. https://github.com/llvm/llvm-project/pull/65966 ___

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

@@ -770,6 +770,9 @@ void AArch64::relocateAlloc(InputSectionBase &sec, uint8_t *buf) const { uint64_t secAddr = sec.getOutputSection()->addr; if (auto *s = dyn_cast(&sec)) secAddr += s->outSecOff; + else if (auto *eh = dyn_cast(&sec)) smithp35 wrote:

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

https://github.com/VitaNuo approved this pull request. https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

zygoloid wrote: Is there some way we can narrow the scope of this patch so we don't lose warnings for normal `snprintf`s, only for the kernel one? If we really can't tell the difference from the source code, we could move the affected warnings to a different warning group instead, so the kerne

[clang] [RISCV] Support target attribute for function (PR #65948)

jrtc27 wrote: Please do not move from Phabricator to GitHub for existing changes, it loses all the context that was built up from previous reviews. New changes should be proposed on GitHub but existing ones should stay put. https://github.com/llvm/llvm-project/pull/65948 __

[clang] [clang-format] Fix a bug in annotating `&&` enclosed in `<` and `>` (PR #65933)

https://github.com/rymiel approved this pull request. I'm also suspicious of if a dereference like `*j` should ever be legal in a template argument, but that would be a different case https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mai

[clang] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

@@ -770,6 +770,9 @@ void AArch64::relocateAlloc(InputSectionBase &sec, uint8_t *buf) const { uint64_t secAddr = sec.getOutputSection()->addr; if (auto *s = dyn_cast(&sec)) secAddr += s->outSecOff; + else if (auto *eh = dyn_cast(&sec)) simpal01 wrote:

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab updated this revision to Diff 556443. ab added a comment. Herald added subscribers: llvm-commits, wangpc, MaskRay. Herald added projects: LLVM, All. Added the relevant bits of the great documentation John wrote in clang/docs/PointerAuthentication.rst. I tried to trim it down to only the gene

[clang] [clang] Better bitfield access units (PR #65742)

efriedma-quic wrote: > Hm, I've been thinking of it the opposite way round -- merging bitfields is > throwing away information (about where cuts might be). In essence, late optimizations can make accesses narrower, but it can't make them wider. The information about cuts is generally recovera

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

hassnaaHamdi wrote: Comments are resolved. https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

@@ -18,38 +18,39 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" #include +#include #include using namespace llvm; namespace { const char *ARMArch[] = { -"armv4","armv4t", "armv5", "armv5t", "armv5e", -"armv5te", "armv5tej

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Use Bitset instead of BitMasking for the Architecture Extensions, because the number of extensions will exceed the bitmask max size. -- Patch is 133.65 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pu

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4634966 , @rjmccall wrote: > Parameter objects are not temporaries and have their own lifetime rules, so > there's nothing wrong with this idea in principle. This seems to just be a > bug, probably that we're d

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/65952: From 010de76adf9264970e5c5dd6d6cc30205210df89 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Mon, 11 Sep 2023 14:00:58 +0200 Subject: [PATCH] [include-cleaner] Fix handling of enums in presence of qualif

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/65981: None >From 8e289774f65d49fbc3bfb11a0d51d9f706ed3ef2 Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Mon, 11 Sep 2023 13:05:53 -0400 Subject: [PATCH] [Fuchsia] Re-enable libcxx timezone database --- clang/c

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

llvmbot wrote: @llvm/pr-subscribers-clang Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/65981.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (-3) diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/65949: >From 1d765a3b22cd81d6739a20f2b2f7b68935773f2a Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Mon, 11 Sep 2023 13:21:11 +0200 Subject: [PATCH 1/2] [dataflow] Add global condition to DataflowAnalysisContext

[clang] b40a5be - [Driver][test] Don't check the version in the triple

Author: Fangrui Song Date: 2023-09-11T10:17:08-07:00 New Revision: b40a5bead2cb95c90ecd8c0fa566722e6133e01c URL: https://github.com/llvm/llvm-project/commit/b40a5bead2cb95c90ecd8c0fa566722e6133e01c DIFF: https://github.com/llvm/llvm-project/commit/b40a5bead2cb95c90ecd8c0fa566722e6133e01c.diff

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

https://github.com/hokein approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a4d1401 - [include-cleaner] Fix handling of enums in presence of qualifiers (#65952)

Author: kadir çetinkaya Date: 2023-09-11T19:21:02+02:00 New Revision: a4d14011e57b91f8040ac08fd3496780aee3c253 URL: https://github.com/llvm/llvm-project/commit/a4d14011e57b91f8040ac08fd3496780aee3c253 DIFF: https://github.com/llvm/llvm-project/commit/a4d14011e57b91f8040ac08fd3496780aee3c253.dif

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/lifetime-call-temp.c:54 + + // CXX-NOT @llvm.lifetime + // CXX: ret void this check line looks broken; missing `:` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/65981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 779a7b7 - [Fuchsia] Re-enable libcxx timezone database (#65981)

Author: Alex Brachet Date: 2023-09-11T13:37:38-04:00 New Revision: 779a7b7fd72f1203e0fe945e76693fa41f366816 URL: https://github.com/llvm/llvm-project/commit/779a7b7fd72f1203e0fe945e76693fa41f366816 DIFF: https://github.com/llvm/llvm-project/commit/779a7b7fd72f1203e0fe945e76693fa41f366816.diff

[clang] [Fuchsia] Re-enable libcxx timezone database (PR #65981)

https://github.com/abrachet closed https://github.com/llvm/llvm-project/pull/65981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f8431a0 - Avoid running optimization passes in frontend test

Author: Matthias Braun Date: 2023-09-11T10:38:06-07:00 New Revision: f8431a0e4008db374dfb17a21119178fb960e334 URL: https://github.com/llvm/llvm-project/commit/f8431a0e4008db374dfb17a21119178fb960e334 DIFF: https://github.com/llvm/llvm-project/commit/f8431a0e4008db374dfb17a21119178fb960e334.diff

[PATCH] D157518: Avoid running optimization passes in frontend test

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8431a0e4008: Avoid running optimization passes in frontend test (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157518/new/ https://rev

[PATCH] D159500: Reapply x2: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers created this revision. Herald added a subscriber: jvesely. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit b7f4915644844fb9f32e8763922a070f5fe4fd29

[PATCH] D159500: Reapply x2: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. meant to update another thread Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159500/new/ https://reviews.llvm.org/D159500 ___ cfe

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 556461. nickdesaulniers added a comment. This revision is now accepted and ready to land. - skip optimization when returning a reference; regardless of type - fix test run line - use --check-prefixes= - reflow RUN lines Repository: rG LLVM Github M

[PATCH] D157331: [clang] Implement C23

pirama added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8618-8619 + "operand argument to %select{overflow builtin|checked integer operation}0 " + "must be an integer type %select{|other than plain 'char', 'bool', bit-precise, " + "or an enum

[PATCH] D159500: Reapply x2: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 556462. nickdesaulniers added a comment. - update commit description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159500/new/ https://reviews.llvm.org/D159500 Files: clang/lib/CodeGen/CGCall.cpp c

[PATCH] D159500: Reapply x2: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. I hate arcanist! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159500/new/ https://reviews.llvm.org/D159500 ___ cfe-commits maili

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added a comment. Under [expr.call]p6 (https://eel.is/c++draft/expr.call#6), it is implementation-defined whether the lifetime of a parameter ends at the end of the containing full expression or at the end of the function. If the implementation chooses the latter, a reference to the pa

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. In D74094#4643439 , @rjmccall wrote: > Under [expr.call]p6 (https://eel.is/c++draft/expr.call#6), it is > implementation-defined whether the lifetime of a parameter ends at

[PATCH] D157331: [clang] Implement C23

jrtc27 added inline comments. Comment at: clang/lib/Headers/stdckdint.h:12 +#define __STDCKDINT_H + +/* C23 7.20.1 Defines several macros for performing checked integer arithmetic*/ pirama wrote: > aaron.ballman wrote: > > Should a hosted build attempt to do an

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -10,14 +10,10 @@ Cleaned up as follows: # Remove all the unnecessary files and directories $ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore $ rm -rf build-aux make msvc scripts test docs -$ rm -f `find . -name \*\.pump` $ rm -f s

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

https://github.com/sudonatalie created https://github.com/llvm/llvm-project/pull/65989: Add an option to target SPIR-V to the clang-dxc driver, which sets the target triple's architecture to logical SPIR-V. >From 699235b506e1949293305973429bd3ec3ee1b9e4 Mon Sep 17 00:00:00 2001 From: Natalie C

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

https://github.com/sudonatalie review_requested https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   >