[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Changes Modify memcpy, memcpy.inline & memmove intrinsics to change the final i1 isVolatile parameter becomes an i8 VolFlags parameter. The former is true if either (or both) dst and src point to volatile storage. The new VolFlags separates dst and s

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Modify memcpy, memcpy.inline & memmove intrinsics to change the final i1 isVolatile parameter becomes an i8 VolFlags parameter. The former is true if either (or both) dst and src point to volatile storage. The new VolFlags separates dst and

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan edited https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > Also, please have a look at the existing `-ffine-grained-bitfield-accesses` > flag and the discussions around it and IPO. That flag's behaviour is unchanged here -- it continues to not merge access units. My contention here is that (a) merging units can be advantageous, but

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > > > Note that changing the memory accesses performed by clang (load or store) > > > _is_ an ABI change at IR level because of UB. > > > > > > Could you clarify why UB is a consideration here? > > There's some weirdness with poison values; see > https://reviews.llvm.org/D129

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
@@ -1660,29 +1660,29 @@ let HasMasked = false, MaskedPolicyScheme = NonePolicy in { defm vmsbc : RVVIntMaskOutBuiltinSet; } -// 12.5. Vector Bitwise Logical Instructions +// 11.5. Vector Bitwise Logical Instructions let UnMaskedPolicyScheme = HasPassthruOperand in { defm

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
@@ -1660,29 +1660,29 @@ let HasMasked = false, MaskedPolicyScheme = NonePolicy in { defm vmsbc : RVVIntMaskOutBuiltinSet; } -// 12.5. Vector Bitwise Logical Instructions +// 11.5. Vector Bitwise Logical Instructions let UnMaskedPolicyScheme = HasPassthruOperand in { defm

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
@@ -2262,11 +2262,11 @@ defm vmfgt : RVVFloatingMaskOutBuiltinSet; defm vmfge : RVVFloatingMaskOutBuiltinSet; } -// 14.14. Vector Floating-Point Classify Instruction +// 13.14. Vector Floating-Point Classify Instruction let Name = "vfclass_v", UnMaskedPolicyScheme = HasPassth

[clang] [clang] Better bitfield access units (PR #65742)

2023-09-11 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > The advantage of exposing the wide accesses to the optimizer is that it > allows memory optimizations, like CSE or DSE, to reason about the entire > bitfield as a single unit, and easily eliminate accesses. Reducing the size > of bitfield accesses in the frontend is basically

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread Piyou Chen via cfe-commits
https://github.com/BeMg created https://github.com/llvm/llvm-project/pull/65948: The spec of RISC-V target feature is https://github.com/riscv-non-isa/riscv-c-api-doc/pull/35. --- This patch implements target attribute for RISC-V. >From 4e661a7cc4775e569bd648b0a119ece51ec031f7 Mon Sep 17 00:0

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread Piyou Chen via cfe-commits
https://github.com/BeMg review_requested https://github.com/llvm/llvm-project/pull/65948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The spec of RISC-V target feature is https://github.com/riscv-non-isa/riscv-c-api-doc/pull/35. --- This patch implements target attribute for RISC-V. -- Full diff: https://github.com/llvm/llvm-project/pull/65948.diff 3 Files Affected: - (m

[clang] [RISCV] Support target attribute for function (PR #65948)

2023-09-11 Thread Piyou Chen via cfe-commits
BeMg wrote: This pull request move from https://reviews.llvm.org/D151730. And update with lastest spec. 1. When it exist the duplicate target attribute, select the lastest one. 2. arch's features will override cpu's features https://github.com/llvm/llvm-project/pull/65948

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
https://github.com/punkyc updated https://github.com/llvm/llvm-project/pull/65944: >From 01a0763aa8c624834c5f6a98df22e75f3f5ae96b Mon Sep 17 00:00:00 2001 From: Ying Chen Date: Mon, 11 Sep 2023 18:36:22 +0800 Subject: [PATCH 1/2] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in risc

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
@@ -1660,29 +1660,29 @@ let HasMasked = false, MaskedPolicyScheme = NonePolicy in { defm vmsbc : RVVIntMaskOutBuiltinSet; } -// 12.5. Vector Bitwise Logical Instructions +// 11.5. Vector Bitwise Logical Instructions let UnMaskedPolicyScheme = HasPassthruOperand in { defm

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
@@ -1660,29 +1660,29 @@ let HasMasked = false, MaskedPolicyScheme = NonePolicy in { defm vmsbc : RVVIntMaskOutBuiltinSet; } -// 12.5. Vector Bitwise Logical Instructions +// 11.5. Vector Bitwise Logical Instructions let UnMaskedPolicyScheme = HasPassthruOperand in { defm

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
@@ -2262,11 +2262,11 @@ defm vmfgt : RVVFloatingMaskOutBuiltinSet; defm vmfge : RVVFloatingMaskOutBuiltinSet; } -// 14.14. Vector Floating-Point Classify Instruction +// 13.14. Vector Floating-Point Classify Instruction let Name = "vfclass_v", UnMaskedPolicyScheme = HasPassth

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
https://github.com/punkyc edited https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall created https://github.com/llvm/llvm-project/pull/65949: This records facts that are not sensitive to the current flow condition, and should apply to all environments. The motivating case is recording information about where a Value originated, such as nullability:

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This records facts that are not sensitive to the current flow condition, and should apply to all environments. The motivating case is recording information about where a Value originated, such as nullability: - we may see the same Value for m

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dbeb3d0 - Add missing vrnd intrinsics

2023-09-11 Thread Victor Campos via cfe-commits
Author: Max Iyengar Date: 2023-09-11T12:59:18+01:00 New Revision: dbeb3d029d8e3120668288a284d0babeb81545fd URL: https://github.com/llvm/llvm-project/commit/dbeb3d029d8e3120668288a284d0babeb81545fd DIFF: https://github.com/llvm/llvm-project/commit/dbeb3d029d8e3120668288a284d0babeb81545fd.diff L

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

2023-09-11 Thread Victor Campos via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbeb3d029d8e: Add missing vrnd intrinsics (authored by miyengar, committed by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I'd like to echo what @cor3ntin suggested above -- this needs an RFC to be posted to Discourse so the community is aware of the potential new language extension. We have a set of criteria for what we're looking for in such an RFC: https://clang.llvm.org/get_involved.html#cr

[clang] [dataflow] Add global condition to DataflowAnalysisContext (PR #65949)

2023-09-11 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand review_requested https://github.com/llvm/llvm-project/pull/65949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-11 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I have concerns mostly about the cast visitor. Comment at: clang/lib/StaticAnalyzer/Checkers/CXXDeleteChecker.cpp:192 + + const Stmt *S = N->getStmtForDiagnostics(); + if (!S) Discookie wrote: > steakhal wrote: > > Aren't you actuall

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

2023-09-11 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/65952: None From a53f4dbec3a6a0944e67d09bce1b9af2d107e418 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Mon, 11 Sep 2023 14:00:58 +0200 Subject: [PATCH] [include-cleaner] Fix handling of enums in presence of

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

2023-09-11 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/7] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[clang] c3a87dd - [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

2023-09-11 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-11T14:19:33+02:00 New Revision: c3a87ddad62a6cc01acaccc76592bc6730c8ac3c URL: https://github.com/llvm/llvm-project/commit/c3a87ddad62a6cc01acaccc76592bc6730c8ac3c DIFF: https://github.com/llvm/llvm-project/commit/c3a87ddad62a6cc01acaccc76592bc6730c8ac3c.diff

[clang] 0954dc3 - [analyzer] CStringChecker buffer access checks should check the first bytes

2023-09-11 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-11T14:19:33+02:00 New Revision: 0954dc3fb9214b994623f5306473de075f8e3593 URL: https://github.com/llvm/llvm-project/commit/0954dc3fb9214b994623f5306473de075f8e3593 DIFF: https://github.com/llvm/llvm-project/commit/0954dc3fb9214b994623f5306473de075f8e3593.diff

[PATCH] D159108: [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

2023-09-11 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc3a87ddad62a: [analyzer] CStringChecker should check the first byte of the destination of… (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D159109: [analyzer] CStringChecker buffer access checks should check the first bytes

2023-09-11 Thread Balázs Benics via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0954dc3fb921: [analyzer] CStringChecker buffer access checks should check the first bytes (authored by steakhal). Repository: rG LLVM Github Monor

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread via cfe-commits
kelbon wrote: > this needs an RFC to be posted to Discourse so the community is aware of the > potential new language extension I will create it soon > I'm not certain it's a particularly good name in terms of standardization as > there's no way for users to distinguish between define and def

[clang] Fix function (PR #65958)

2023-09-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/65958: None >From b4429aeefc00516ba390471f08fd71f5b0c441f9 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 11 Sep 2023 05:54:03 -0700 Subject: [PATCH] Testing. --- clang/lib/AST/Expr.cpp | 1 + 1 file change

[clang] Fix function (PR #65958)

2023-09-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/65958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix function (PR #65958)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix function (PR #65958)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix function (PR #65958)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/65958.diff 1 Files Affected: - (modified) clang/lib/AST/Expr.cpp (+1) diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index 4f3837371b3fc5..358a9fcd9e8c7e 100644 --

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -18,38 +18,39 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" #include +#include #include using namespace llvm; namespace { const char *ARMArch[] = { -"armv4","armv4t", "armv5", "armv5t", "armv5e", -"armv5te", "armv5tej

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -138,287 +185,332 @@ TEST_P(ARMCPUTestFixture, ARMCPUTests) { INSTANTIATE_TEST_SUITE_P( ARMCPUTestsPart1, ARMCPUTestFixture, ::testing::Values( -ARMCPUTestParams("invalid", "invalid", "invalid", ARM::AEK_NONE, ""), -ARMCPUTestParams("generic", "invali

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -552,7 +623,7 @@ struct CpuAlias { inline constexpr CpuAlias CpuAliases[] = {{"grace", "neoverse-v2"}}; -bool getExtensionFeatures(uint64_t Extensions, +bool getExtensionFeatures(Bitset Extensions, sdesmalen-arm wrote: Should `Extensions` be passed as a c

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -18,38 +18,39 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" #include +#include #include using namespace llvm; namespace { const char *ARMArch[] = { -"armv4","armv4t", "armv5", "armv5t", "armv5e", -"armv5te", "armv5tej

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -1605,13 +1691,14 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) { std::vector Features; - uint64_t ExtVal = 0; + Bitset ExtVal; for (auto Ext : Extensions) -ExtVal |= Ext; +ExtVal.set(Ext); sdesmalen-arm wrote: Does `|=` not work on B

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -96,64 +97,65 @@ static_assert(FEAT_MAX <= 64, // Arch extension modifiers for CPUs. These are labelled with their Arm ARM // feature name (though the canonical reference for those is AArch64.td) // clang-format off -enum ArchExtKind : uint64_t { - AEK_NONE =1, - A

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -69,6 +70,26 @@ std::string FormatExtensionFlags(uint64_t Flags) { return llvm::join(Features, ", "); } +std::string SerializeExtensionFlags(Bitset Flags) { + static_assert((AArch64::AEK_EXTENSIONS_MAX % 4 == 0), +"AArch64::AEK_EXTENSIONS_MAX shoubld be divisible by

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread via cfe-commits
martinboehme wrote: Duplicate of https://github.com/llvm/llvm-project/pull/65602 https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 706afc9 - Fixup "[analyzer] CStringChecker buffer access checks should check the first bytes"

2023-09-11 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-11T15:01:22+02:00 New Revision: 706afc9778827dfd8064192c26acd0bc1c421e48 URL: https://github.com/llvm/llvm-project/commit/706afc9778827dfd8064192c26acd0bc1c421e48 DIFF: https://github.com/llvm/llvm-project/commit/706afc9778827dfd8064192c26acd0bc1c421e48.diff

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-11 Thread via cfe-commits
cor3ntin wrote: Could you rebase on top of main? There have been a few changes to lambda that i think address part of the issues here, but this patch is still very much needed. We add a bug when referring to a capture in a decltype or a require would cause a crash, and that is fixed. I suspect

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

2023-09-11 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Yaxun Liu via cfe-commits
@@ -43,7 +43,7 @@ int bar() { return no_attr() + attr_in_target() + attr_not_in_target() + attr_in // CHECK-LABEL: @attr_incompatible // CHECK-SAME: () #[[ATTR_INCOMPATIBLE:[0-9]+]] { -// CHECK: attributes #[[ATTR_BAR]] = { noinline nounwind optnone "no-trapping-math"="true"

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread Kinuko Yasuda via cfe-commits
https://github.com/kinu closed https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread Kinuko Yasuda via cfe-commits
kinu wrote: Thanks, closing https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
https://github.com/zmodem review_requested https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
https://github.com/zmodem created https://github.com/llvm/llvm-project/pull/65961: …stantiation members during explicit instantiation. This is a continuation of https://reviews.llvm.org/D155713 Fixes https://github.com/llvm/llvm-project/issues/40363 >From 4649e122e5c100c5fb242cd0e76ef87b9271a

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
https://github.com/zmodem review_requested https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
@@ -1605,13 +1691,14 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) { std::vector Features; - uint64_t ExtVal = 0; + Bitset ExtVal; for (auto Ext : Extensions) -ExtVal |= Ext; +ExtVal.set(Ext); hassnaaHamdi wrote: It's works only for the

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes …stantiation members during explicit instantiation. This is a continuation of https://reviews.llvm.org/D155713 Fixes https://github.com/llvm/llvm-project/issues/40363 -- Full diff: https://github.com/llvm/llvm-project/pull/65961.diff 3 Files

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

2023-09-11 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Sent my diff along with tests based on Louis's patch as a pull request here: https://github.com/llvm/llvm-project/pull/65961 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155713/new/ https://reviews.llvm.org/D155713

[clang-tools-extra] [include-cleaner] Fix handling of enums in presence of qualifiers (PR #65952)

2023-09-11 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159497: [RFC][clangd] Check if SelectionTree is complete

2023-09-11 Thread Kugan Vivekanandarajah via Phabricator via cfe-commits
kuganv created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. kuganv retitled this revision from "[clangd] Check if SelectionTree is complete" to "[RFC][clangd] Check if SelectionTree is complete". kuganv edited the summary of this revision. kuganv added

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

2023-09-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Please address Ronan's comments. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-11 Thread via cfe-commits
https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159490: Fix warning in MSVC

2023-09-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems good enough to me. I'll commit it for you as before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159490/new/ https://revie

[clang] 0323938 - Fix warning in MSVC

2023-09-11 Thread via cfe-commits
Author: Giuliano Belinassi Date: 2023-09-11T06:51:11-07:00 New Revision: 0323938d3c7a1a48b60a7dea8ec7300e98b4a931 URL: https://github.com/llvm/llvm-project/commit/0323938d3c7a1a48b60a7dea8ec7300e98b4a931 DIFF: https://github.com/llvm/llvm-project/commit/0323938d3c7a1a48b60a7dea8ec7300e98b4a931.

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
@@ -10,14 +10,10 @@ Cleaned up as follows: # Remove all the unnecessary files and directories $ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README README.md .gitignore $ rm -rf build-aux make msvc scripts test docs -$ rm -f `find . -name \*\.pump` $ rm -f s

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-11 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 commented: Nice to see the LLVM intrusion into googletest proper is very minimized! IME, testing on Linux with both gcc and clang as build compilers is very helpful. With Windows/MSVC that covers the three main cases. https://github.com/llvm/llvm-project/pull/65823 __

[PATCH] D159490: Fix warning in MSVC

2023-09-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane closed this revision. erichkeane added a comment. Forgot to close the phab review automatically, but: 0323938d3c7a1a48b60a7dea8ec7300e98b4a931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-11 Thread Dinar Temirbulatov via cfe-commits
@@ -12,23 +12,15 @@ #include -void test_range_0_0(svbool_t pg, void *ptr) { +void test_range_0_0(uint32_t slice, svbool_t pg, void *ptr) { // expected-error@+1 {{argument value 18446744073709551615 is outside the valid range [0, 0]}} - SVE_ACLE_FUNC(svld1_hor_za8,,,)(-1

[clang] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

2023-09-11 Thread Dinar Temirbulatov via cfe-commits
@@ -12,23 +12,15 @@ #include -void test_range_0_0(svbool_t pg, void *ptr) { +void test_range_0_0(uint32_t slice, svbool_t pg, void *ptr) { // expected-error@+1 {{argument value 18446744073709551615 is outside the valid range [0, 0]}} - SVE_ACLE_FUNC(svld1_hor_za8,,,)(-1

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-11 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. I figure out the reason of strange behavior I mentioned last night. However, I'm still not sure what is the good way to solve this problem. Can someone check the behavior with `-O2` option please? Thanks! Comment at: openmp/runtime/test/target/target_

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-11 Thread Erich Keane via cfe-commits
@@ -102,7 +102,8 @@ std::optional Context::classify(QualType T) const { case 8: return PT_Sint8; default: - return std::nullopt; + return PT_IntAPS; + // return std::nullopt; erichkeane wrote: If we're removing these, I wonder if

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-11 Thread Erich Keane via cfe-commits
@@ -0,0 +1,253 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] d9c9c9f - [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (#65944)

2023-09-11 Thread via cfe-commits
Author: Ying Chen Date: 2023-09-11T21:58:51+08:00 New Revision: d9c9c9f2d94c30f3783acfcaea94c6b24a5ca718 URL: https://github.com/llvm/llvm-project/commit/d9c9c9f2d94c30f3783acfcaea94c6b24a5ca718 DIFF: https://github.com/llvm/llvm-project/commit/d9c9c9f2d94c30f3783acfcaea94c6b24a5ca718.diff LOG

[clang] [NFC][Clang][RISCV] Fix typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

2023-09-11 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. Could split all the test updates to a pre-commit but doesn't really matter https://github.com/llvm/llvm-project/pull/65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

<    1   2   3   4   5   6   7   >